Re: [PATCHES] Moving pg_autovacuum from contrib to src/bin

2004-05-29 Thread Tom Lane
Matthew T. O'Connor [EMAIL PROTECTED] writes: As outlined in my email, step 1 is to move pg_autovacuum from contrib to src/bin. Attached is a patch that modifies src/bin/Makefile and the pg_autovacuum Makefile which will be in src/bin/pg_autovacuum/Makefile once the pg_autovacuum directory is

Re: [PATCHES] Moving pg_autovacuum from contrib to src/bin

2004-05-29 Thread Peter Eisentraut
Matthew T. O'Connor wrote: The only reason I put it in src/bin is because I thought people wanted pg_autovacuum to still be a runable stand alone app. I see no reason for that. If it's integrated as a postmaster child, then it is run in a daemon-like mode automatically. But, I guess there

Re: [PATCHES] Moving pg_autovacuum from contrib to src/bin

2004-05-29 Thread Matthew T. O'Connor
On Sat, 2004-05-29 at 02:45, Peter Eisentraut wrote: Matthew T. O'Connor wrote: The only reason I put it in src/bin is because I thought people wanted pg_autovacuum to still be a runable stand alone app. I see no reason for that. If it's integrated as a postmaster child, then it is run

Re: [PATCHES] Moving pg_autovacuum from contrib to src/bin

2004-05-29 Thread Matthew T. O'Connor
On Sat, 2004-05-29 at 02:15, Tom Lane wrote: Matthew T. O'Connor [EMAIL PROTECTED] writes: As outlined in my email, step 1 is to move pg_autovacuum from contrib to src/bin. Attached is a patch that modifies src/bin/Makefile and the pg_autovacuum Makefile which will be in

Re: [PATCHES] Moving pg_autovacuum from contrib to src/bin

2004-05-29 Thread Dave Page
-Original Message- From: Peter Eisentraut [mailto:[EMAIL PROTECTED] Sent: 29 May 2004 09:44 To: Matthew T. O'Connor Cc: Tom Lane; pgsql-patches Subject: Re: [PATCHES] Moving pg_autovacuum from contrib to src/bin It is supposed to be linked into the postmaster and forked from

Re: [PATCHES] Moving pg_autovacuum from contrib to src/bin

2004-05-29 Thread Matthew T. O'Connor
On Sat, 2004-05-29 at 11:04, Tom Lane wrote: Peter Eisentraut [EMAIL PROTECTED] writes: It is supposed to be linked into the postmaster and forked from there. In the current state of pg_autovacuum it wouldn't matter a lot, but I am assuming that we will soon migrate it to depend on being

Re: [PATCHES] Moving pg_autovacuum from contrib to src/bin

2004-05-29 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: Matthew T. O'Connor wrote: I did understand Tom, but based on the hacker discussion I think the postmaster integration will consist of the postmaster launching and killing the pg_autovacuum standalone executable as required. In that sense, I don't

Re: [PATCHES] Moving pg_autovacuum from contrib to src/bin

2004-05-29 Thread Marc G. Fournier
On Sat, 29 May 2004, Matthew T. O'Connor wrote: On Sat, 2004-05-29 at 11:04, Tom Lane wrote: Peter Eisentraut [EMAIL PROTECTED] writes: It is supposed to be linked into the postmaster and forked from there. In the current state of pg_autovacuum it wouldn't matter a lot, but I am assuming that we

Re: [PATCHES] Moving pg_autovacuum from contrib to src/bin

2004-05-29 Thread Matthew T. O'Connor
On Sat, 2004-05-29 at 15:02, Marc G. Fournier wrote: On Sat, 29 May 2004, Matthew T. O'Connor wrote: I can wait, but I am really trying not to miss the feature freeze which AFAIK, is still happening in a few days. Is that changing? Will I have time if I wait a few days? Especially given

Re: [PATCHES] Moving pg_autovacuum from contrib to src/bin

2004-05-28 Thread Matthew T. O'Connor
On Sat, 2004-05-29 at 01:31, Matthew T. O'Connor wrote: Having no response from my email to hackers yesterday, I will assume (hope) that no news is good news and proceed onwards. As outlined in my email, step 1 is to move pg_autovacuum from contrib to src/bin. Attached is a patch that