Patch applied. Thanks.
I renamed aggregate_relation_size() to total_relation_size(). To me
'aggregate' was too closely associated with 'aggregates'. If you have
improved wording please let me know.
---
Ed L. wrote:
On
On Thursday February 3 2005 9:23, Ed L. wrote:
Neil, do you have a verdict on this patch?
On Friday January 28 2005 10:30, Ed L. wrote:
If the C code for the prior dbsize patch is not acceptable
for whatever reason, here's a SQL-based patch to replace it.
I submitted a dbsize patch on Jan
It is still in my mailbox for review. Sorry.
---
Ed L. wrote:
On Thursday February 3 2005 9:23, Ed L. wrote:
Neil, do you have a verdict on this patch?
On Friday January 28 2005 10:30, Ed L. wrote:
If the C code
On Wed, 2005-02-09 at 18:35 -0500, Bruce Momjian wrote:
It is still in my mailbox for review. Sorry.
Yeah, my apologies as well, I've been busy with other things. Bruce, if
you'd like to review apply this you are welcome to. Otherwise let me
know and I'll take a look.
-Neil
Neil Conway wrote:
On Wed, 2005-02-09 at 18:35 -0500, Bruce Momjian wrote:
It is still in my mailbox for review. Sorry.
Yeah, my apologies as well, I've been busy with other things. Bruce, if
you'd like to review apply this you are welcome to. Otherwise let me
know and I'll take a look.
Neil, do you have a verdict on this patch?
On Friday January 28 2005 10:30, Ed L. wrote:
If the C code for the prior dbsize patch is not acceptable for
whatever reason, here's a SQL-based patch to replace it. It's
not a drop-in for 7.3/7.4 as I'd hoped, only an 8.1 patch. I
believe it is
If the C code for the prior dbsize patch is not acceptable for whatever
reason, here's a SQL-based patch to replace it. It's not a drop-in for
7.3/7.4 as I'd hoped, only an 8.1 patch. I believe it is functionally
equivalent to the C patch, but simpler, shorter, and probably a tad slower.
I
On Thu, 2005-01-27 at 08:05 +0100, Michael Paesold wrote:
Perhaps you could rename indices_size to indexes_size.
Attached patch identical except for s/indices/indexes/g.
Attached is the same patch as context diff.
Ed
Index: contrib/dbsize/README.dbsize
Tom Lane wrote:
Andreas Pflug [EMAIL PROTECTED] writes:
Hm, these are all implementable as SQL functions, do we need these hard
coded too?
e.g.
create function aggregate_relation_size(oid) returns int8 as $CODE$
select sum(pg_relation_size(indexrelid)) from pg_index where indrelid=$1;
$CODE$
Neil Conway wrote:
On Tue, 2005-01-25 at 16:49 -0700, Ed L. wrote:
The attached dbsize patch:
+ makes relation_size(relname) include toast tables;
+ adds aggregate_relation_size(relname) to count table data and indices;
+ adds indices_size(relname) to report the size of
Andreas Pflug [EMAIL PROTECTED] writes:
Hm, these are all implementable as SQL functions, do we need these hard
coded too?
e.g.
create function aggregate_relation_size(oid) returns int8 as $CODE$
select sum(pg_relation_size(indexrelid)) from pg_index where indrelid=$1;
$CODE$ language
On Thu, 2005-01-27 at 08:05 +0100, Michael Paesold wrote:
Perhaps you could rename indices_size to indexes_size.
Attached patch identical except for s/indices/indexes/g.
Attached is the same patch as context diff. (prior send from unregistered
email address)
Ed
Index:
On Thursday January 27 2005 6:59, Andreas Pflug wrote:
Neil Conway wrote:
On Tue, 2005-01-25 at 16:49 -0700, Ed L. wrote:
The attached dbsize patch:
+ makes relation_size(relname) include toast tables;
+ adds aggregate_relation_size(relname) to count table data and
indices; +
On Thursday January 27 2005 2:12, Ed L. wrote:
Well, it seems quite a bit more complicated than that to me, but I'm
going to rework the patch so it drops into 7.3 as well and resubmit
shortly.
Too much trouble for now. Neil, if the latest patch is acceptable or useful
for others as-is,
On Tue, 2005-01-25 at 16:49 -0700, Ed L. wrote:
The attached dbsize patch:
+ makes relation_size(relname) include toast tables;
+ adds aggregate_relation_size(relname) to count table data and indices;
+ adds indices_size(relname) to report the size of indices for a
Neil Conway wrote:
On Tue, 2005-01-25 at 16:49 -0700, Ed L. wrote:
The attached dbsize patch:
+ makes relation_size(relname) include toast tables;
+ adds aggregate_relation_size(relname) to count table data and indices;
+ adds indices_size(relname) to report the size of indices for a
relation;
On Thu, 2005-01-27 at 08:05 +0100, Michael Paesold wrote:
Perhaps you could rename indices_size to indexes_size.
Yeah, sorry -- forgot to mention that. I believe we decided to
standardize on indexes as the plural of index (at least in
user-visible stuff) a few releases go.
Good catch :)
-Neil
17 matches
Mail list logo
