Re: [PATCHES] pg_autovacuum patches

2003-11-29 Thread Matthew T. O'Connor
One more time... The last patch didn't have the unitialized variables stuff in it. Please disregard the previous patch and apply this one. On Sat, 2003-11-29 at 00:34, Matthew T. O'Connor wrote: > ARRRGGHH ok, with patch this time... > > On Sat, 2003-11-29 at 00:17, Matthew T. O'Connor wrot

Re: [PATCHES] pg_autovacuum patches

2003-11-29 Thread Tom Lane
"Matthew T. O'Connor" <[EMAIL PROTECTED]> writes: > I noticed that there have been a few patched submitted for pg_autovacuum > that have not been applied, so I applied them locally and tested them on > my Fedora box. I am resubmitting them as one single patch. Bruce seems to be vastly behind on t

Re: [PATCHES] pg_autovacuum patches

2003-11-29 Thread Bruce Momjian
Tom Lane wrote: > "Matthew T. O'Connor" <[EMAIL PROTECTED]> writes: > > I noticed that there have been a few patched submitted for pg_autovacuum > > that have not been applied, so I applied them locally and tested them on > > my Fedora box. I am resubmitting them as one single patch. > > Bruce se

Re: [PATCHES] contrib/dbmirror conditional replication

2003-11-29 Thread Joe Conway
Steven Singer wrote: Downsides include that the code is kind of complicated, insert,updates and deletes are much slower and a lot of extra information needs to be stored by the mirroring system(see the accounting table). I second this part. I added a compile time flag to enable or disable this fea

[PATCHES] PG_VERSION in pg_config.h.win32

2003-11-29 Thread Joe Conway
PG_VERSION should be 7.5devel (not 7.4) in pg_config.h.win32, shouldn't it? Joe Index: src/include/pg_config.h.win32 === RCS file: /cvsroot/pgsql-server/src/include/pg_config.h.win32,v retrieving revision 1.12 diff -c -r1.12 pg_config

Re: [PATCHES] Problem with dblink

2003-11-29 Thread Joe Conway
Tom Lane wrote: (More generally, I wonder if AtEOXact_SPI oughtn't be fixed to emit a WARNING if the SPI stack isn't empty, except in the error case. Neglecting SPI_finish is analogous to a resource leak, and we have code in place to warn about other sorts of leaks.) Is the attached what you had in

Re: [PATCHES] pg_autovacuum patches

2003-11-29 Thread Neil Conway
Bruce Momjian <[EMAIL PROTECTED]> writes: > I am going to try to fill the queue tonight and apply it Monday. I > leave for Japan on Tuesday. Applying a load of patches and then promptly fleeing the country doesn't sound so wise -- it sounds mighty suspicious, in fact :-) (At the same time, I can

Re: [PATCHES] pg_autovacuum patches

2003-11-29 Thread Bruce Momjian
Neil Conway wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I am going to try to fill the queue tonight and apply it Monday. I > > leave for Japan on Tuesday. > > Applying a load of patches and then promptly fleeing the country > doesn't sound so wise -- it sounds mighty suspicious, in fac

Re: [PATCHES] pg_autovacuum patches

2003-11-29 Thread Bruce Momjian
Bruce Momjian wrote: > Neil Conway wrote: > > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > I am going to try to fill the queue tonight and apply it Monday. I > > > leave for Japan on Tuesday. > > > > Applying a load of patches and then promptly fleeing the country > > doesn't sound so wise --

Re: [PATCHES] improve psql lo_* help

2003-11-29 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Christopher Kings-Lynne wrote: > This mak

Re: [PATCHES] Alter Table phase 1 -- Please apply to 7.5

2003-11-29 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Rod Taylor wrote: > Completes: >

Re: [PATCHES] refactor CreateTupleDescCopy()

2003-11-29 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Neil Conway wrote: > Tom Lane <[EMAIL PRO

Re: [PATCHES] refactor CreateTupleDescCopy()

2003-11-29 Thread Bruce Momjian
This patch was withdrawn by the author. --- Neil Conway wrote: > Tom Lane <[EMAIL PROTECTED]> writes: > > That would be okay with me. It might be a good idea to change the > > name completely (perhaps CopyTupleDesc() ?) as

Re: [PATCHES] 7.4 shared memory error on 64-bit SPARC/Solaris 5.8

2003-11-29 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Thomas Baden wrote: > Hi there. My insta

Re: [PATCHES] internationalization of initdb

2003-11-29 Thread Bruce Momjian
This was applied by Peter a while ago. --- Euler Taveira de Oliveira wrote: > Hi, > > I just enable support for internationalization of initdb. I used the same style from > "scripts". The files need to be put in initdb dir

Re: [PATCHES] [BUGS] (Modified) Patch request for PostgreSQL 7.4 for HP-UX IA-64

2003-11-29 Thread Bruce Momjian
ViSolve Open Source Team wrote: > Subject: PostgreSQL Patch: Modified Test-and-set routine for HP-UX (IA-64) > specifically for the HP-C compiler > > With reference to Tom Lane's response to our previous patch request (at > http://archives.postgresql.org/pgsql-bugs/2003-10/msg00149.php) > this i

Re: [PATCHES] cleanup execTuples.c

2003-11-29 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Neil Conway wrote: > Tom Lane <[EMAIL PRO

Re: [PATCHES] fix PL/PgSQL doc typo

2003-11-29 Thread Bruce Momjian
Patch applied. Thanks. --- Neil Conway wrote: > There is an unused variable in an example function in the PL/PgSQL > documentation; this patch removes it. > > -Neil [ Attachment, skipping... ] > > -

Re: [PATCHES] YA Cygwin DLLIMPORT patch

2003-11-29 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. Will apply to 7.4.X also. --- Jason Tishler

[PATCHES] export FUNC_MAX_ARGS as a read-only GUC variable (was: [GENERAL] SELECT Question)

2003-11-29 Thread Joe Conway
Tom Lane wrote: I was thinking of proposing that we provide something just about like that as a standard function (written in C, not in plpgsql, so that it would be available whether or not you'd installed plpgsql). There are some places in the information_schema that desperately need it --- right

Re: [PATCHES] [BUGS] PATCH: Uninitialized variable usage in contrib/pg_autovacuum

2003-11-29 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Craig Boston wrote: > Sorry about the cro

Re: [PATCHES] minor cleanup in plpgsql.sgml

2003-11-29 Thread Bruce Momjian
Tom Lane wrote: > Robert Treat <[EMAIL PROTECTED]> writes: > > Funny. That's a good argument for doing it that way, but almost the same > > argument I make for putting the INTO at the end: so as to not confuse > > people with the "SELECT a,b,c INTO newtable FROM oldtable" sql syntax. > > In either

Re: [PATCHES] [HACKERS] initdb mkdir_p() doesn't work

2003-11-29 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Andrew Dunstan wrote: > > > Andrew Duns

Re: [PATCHES] PG_VERSION in pg_config.h.win32

2003-11-29 Thread Bruce Momjian
I have bumped all the changes mentioned in RELEASE_CHANGES for 7.5. I have _not_ touched 7.4.X. --- Joe Conway wrote: > PG_VERSION should be 7.5devel (not 7.4) in pg_config.h.win32, shouldn't it? > > Joe > Index: src/incl