On Fri, 2004-04-30 at 01:02, Bruce Momjian wrote:
> Simon Riggs wrote:
> > On Sun, 2004-04-25 at 19:06, Alvaro Herrera wrote:
> > > Hackers,
> > >
> > > This patch adds subtransaction support into the storage manager. Files
> > > created or dropped inside a subtransaction are correctly dealt with
On Fri, 2004-04-30 at 03:12, Alvaro Herrera wrote:
> On Thu, Apr 29, 2004 at 09:58:49PM -0400, Alvaro Herrera wrote:
>
> > Note that sometimes I do things incrementally, so I do "incremental
> > diffs" by commands like
> > cd /home/alvherre/CVS/pgsql/source
> > diff -cr --exclude-from=ignore-diff
> I have added this to CVS under src/timezone and have
> integrated this into configure.
Hi all,
looks like I am trying to hit a fast moving target, but here is a patch for
the changes I needed in order to get HEAD to build under win32/mingw after
these recent timezone lib changes.
I'm not su
Peter Eisentraut wrote:
> Bruce Momjian wrote:
> > I have added this to CVS under src/timezone and have integrated this
> > into configure.
>
> I think it would be better to put it under one of the generic
> subdirectories, such as src/utils/timezone. We may have to add
> additional libraries o
Simon Riggs wrote:
> > > If you add pg_subtrans, you will need to make recovery work all over
> > > again...really, you don't want to be doing that, do you?
> > >
> > > I also have other questions
> > > Forgive my lack of attention: I want SAVEPOINTs, not subtransactions...
> > > how do we do
> * timezone/private.h looks like it should be picking up its
> constants in another way (ie. had to comment out
> HAVE_SYMLINK). Looks like we'll need to spend some time in
> this file if we want it platform independent.
Yes, that's the place that the tz lib stores these things. Though in
tha
Am Freitag, 30. April 2004 15:27 schrieb Bruce Momjian:
> I put it under /src because it is a separate module of code that we may
> need to update someday with a new release. In that way it isn't really
> part of our backend binary but a module we call.
The same could be said of regex, but that h
Peter Eisentraut wrote:
> Am Freitag, 30. April 2004 15:27 schrieb Bruce Momjian:
> > I put it under /src because it is a separate module of code that we may
> > need to update someday with a new release. In that way it isn't really
> > part of our backend binary but a module we call.
>
> The sam
Bruce Momjian wrote:
> Peter Eisentraut wrote:
> > Am Freitag, 30. April 2004 15:27 schrieb Bruce Momjian:
> > > I put it under /src because it is a separate module of code that we may
> > > need to update someday with a new release. In that way it isn't really
> > > part of our backend binary but
I fixed the problem with ZIC compile needing libpgport, and the symlink
define.
I am confused why you are linking the timezone library into pg_dump and
pg_controldata. Is that required?
---
Claudio Natoli wrote:
>
>
> >
Tom Lane wrote:
> Bruce Momjian <[EMAIL PROTECTED]> writes:
> > /usr/include/time.h:104: `pg_timezone' redeclared as different kind of
> > symbol
>
> Your really defines "pg_timezone"?? I'm wondering if this is
> an indirect effect of a macro naming collision.
I applied the following pa
On Thu, Apr 29, 2004 at 11:38:52PM +0100, Simon Riggs wrote:
> On Sun, 2004-04-25 at 19:06, Alvaro Herrera wrote:
> > - pg_clog/pg_subtrans. Need a solution.
> As you're aware, our current work overlaps.
> pg_clog doesn't seem like the place to record subtransactions, though
> maybe it is... cou
Neil Conway <[EMAIL PROTECTED]> writes:
> On 30-Apr-04, at 1:06 AM, Tom Lane wrote:
>> Other than "it's in SQL2003", what's the point of implementing this?
> No idea, but it doesn't really matter IMHO: it is in SQL2003, it
> doesn't interfere with the rest of the system or impose a significant
>
Bruce Momjian <[EMAIL PROTECTED]> writes:
> The attached patch clears the password field on rename:
I think you should clear the password field *only* if it's
MD5-encrypted.
regards, tom lane
---(end of broadcast)---
TIP 4:
Tom Lane wrote:
> Bruce Momjian <[EMAIL PROTECTED]> writes:
> > The attached patch clears the password field on rename:
>
> I think you should clear the password field *only* if it's
> MD5-encrypted.
I thought about that but it seems strange to conditionally do the
clearing, but if you think we s
On 30-Apr-04, at 11:57 AM, Tom Lane wrote:
Because we have only limited manpower. It's water over the dam now,
since you've already expended the work, but IMHO you'd be better
advised
to spend your time implementing features or performance improvements
that someone has actually asked for.
Okay, y
Bruce Momjian writes:
> I am confused why you are linking the timezone library into
> pg_dump and pg_controldata. Is that required?
At the time, cvs HEAD required it; perhaps I caught you mid-commit. I
thought it was a fast moving target to try to hit. :-)
All looks good now.
Cheers,
Claudio
For application to HEAD.
As Andrew Dunstan appears to have cracked the regression test buffering nut,
this patch makes sure that:
* correct platform specific regression files are used under ming
* pwd prints out a usable win32 pathname
Cheers,
Claudio
---
Certain disclaimers and policies app
Claudio Natoli said:
>
> For application to HEAD.
>
> As Andrew Dunstan appears to have cracked the regression test buffering
> nut, this patch makes sure that:
> * correct platform specific regression files are used under ming
> * pwd prints out a usable win32 pathname
Claudio,
I'm assuming that
Peter Eisentraut <[EMAIL PROTECTED]> writes:
> I think it would be better to put it under one of the generic
> subdirectories, such as src/utils/timezone. We may have to add
> additional libraries of this kind in the future, and it would be better
> to have them grouped somehow.
The closest pr
> I'm assuming that you have checked that this works, as it is slightly
> different from what I did.
Seems to.
> Strictly speaking, the pwd flags test should probably depend
> in the test
> platform rather than the target platform. Something like:
>
> case `uname` in
> MINGW32*)
>
Tom Lane wrote:
> Peter Eisentraut <[EMAIL PROTECTED]> writes:
> > I think it would be better to put it under one of the generic
> > subdirectories, such as src/utils/timezone. We may have to add
> > additional libraries of this kind in the future, and it would be better
> > to have them groupe
Claudio Natoli said:
>> Strictly speaking, the pwd flags test should probably depend
>> in the test
>> platform rather than the target platform. Something like:
>>
>> case `uname` in
>> MINGW32*)
>> PWDFLAGS=-W;;
>> *)
>> PWDFLAGS=;;
>> esac
>
> There's three other tes
Neil Conway <[EMAIL PROTECTED]> writes:
> Okay, your opinion has been duly noted :-)
> Did you have any comment on the two questions I asked in my original
> patch email?
MHO: you already spent more time on this than it deserves. What you
have sounds fine.
regards, tom
On 1-May-04, at 2:04 AM, Hans-Jürgen Schönig wrote:
Doesn't your patch cause problems with the PostgreSQL ODBC driver
which adds [...]
I don't think this will cause an error (I tried it locally, and pg_proc
rows for the new functions are installed, but power() and ceiling()
continue to work). Of
I've written a small patch that could be useful for people with old
applications, since it restores the original behaviour of silently treating
empty strings as 0 (at least for integers). It introduces a new bool GUC
variable "empty_equals_0" with default "off". With a simple "SET
empty_equals_
26 matches
Mail list logo
