[PATCHES] String consistency

2004-08-01 Thread Alvaro Herrera
Hackers, This little patch reworks some strings that were already present in 7.4 with a minor difference. -- Alvaro Herrera () "La persona que no querĂ­a pecar / estaba obligada a sentarse en duras y empinadas sillas/ desprovistas, por cierto de blandos atenuantes" (P

Re: [PATCHES] pg_config

2004-08-01 Thread Peter Eisentraut
Bruce Momjian wrote: > Patch applied. Thanks. > > I made all the changes you suggested and the additions to path.c for > the new parameters. I think you forgot to commit the new source files. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broad

Re: [PATCHES] pg_config

2004-08-01 Thread Bruce Momjian
Oops, sorry, done. --- Peter Eisentraut wrote: > Bruce Momjian wrote: > > Patch applied. Thanks. > > > > I made all the changes you suggested and the additions to path.c for > > the new parameters. > > I think you forgot t

Re: [PATCHES] pg_config

2004-08-01 Thread Peter Eisentraut
Bruce Momjian wrote: > Oops, sorry, done. The --pgxs option seems to have gotten lost in the conversion. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 7: don't forget to increase your free space map set

Re: [PATCHES] pg_config

2004-08-01 Thread Andrew Dunstan
Peter Eisentraut wrote: Bruce Momjian wrote: Oops, sorry, done. The --pgxs option seems to have gotten lost in the conversion. It wasn't there when I did the conversion. Usual problem of duelling patches. Can you fix it, or do you need me to send in a patch? cheers andrew

Re: [PATCHES] Random regression failures

2004-08-01 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I am seeing random parallel regression failures. I would say 20% of > the time I see a failure on the regression test. It has happened > several times to me in the past few days. Regression diff attached. A stack trace and/or postmaster log report of

Re: [PATCHES] [subxacts] Last try before beta

2004-08-01 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Here is the last patch before beta for subtransactions. It fixes the > following outstanding issues: Applied with revisions. I had to whack around the code associated with the subtrans XID cache, because it was seriously violating the locking requirem

Re: [PATCHES] String consistency

2004-08-01 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > This little patch reworks some strings that were already present in 7.4 > with a minor difference. Applied. regards, tom lane ---(end of broadcast)--- TIP 8: explain analyze is yo

Re: [PATCHES]Traditional Chinese translations in UTF-8 for 7.5

2004-08-01 Thread Peter Eisentraut
Zhenbang Wei wrote: > Using UTF-8 instead of anonying Big5. > Sorry for causing problems. Installed. Whatever works for you is OK. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 7: don't forget to incre

Re: [PATCHES] [subxacts] Last try before beta

2004-08-01 Thread Alvaro Herrera
On Sun, Aug 01, 2004 at 01:41:39PM -0400, Tom Lane wrote: > > - Update comments in code, htup.h and xact.c > > The "update" in xact.c seemed to consist of wholesale removal of the top > comment. I didn't apply it, because the comment didn't seem that > useless. It does need editorial work, but

Re: [PATCHES] [subxacts] Last try before beta

2004-08-01 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Well, the README file integrated those comments as appropiate. Oh... > Apparently the embed-new-files-in-patch business was not a good idea > after all. Sorry for not being clear on the message. Yeah. I can deal with 'cvs diff' stuff but it wasn't a

Re: [PATCHES] Fix for OWNER TO breaking ACLs

2004-08-01 Thread Tom Lane
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > Attached is a patch that fixes the owner change command on objects that > have privileges. Applied with revisions. Just FYI --- * The aclnewowner code wasn't really right at all. It was changing ai_grantee without checking whether that valu

Re: [PATCHES] fix schema ownership on first connection preliminary patch v2

2004-08-01 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Fabien COELHO wrote: >> Please find attached a preliminary patch to fix schema ownership on first >> connection. It is for comments and advices as I still have doubts about >> various how-and-where issues, thus it is not submitted to the patch list. > I

Re: [PATCHES] Random regression failures

2004-08-01 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I am seeing random parallel regression failures. I would say 20% of > the time I see a failure on the regression test. FWIW, my other machine has been running repeated parallel regress tests for several hours. It's now up to 130 completed cycles with n

Re: [PATCHES] win32 version info - try 2

2004-08-01 Thread Gavin M. Roy
I took the ai file, reduced it to the right sizes in photoshop and used an icon editor to make it at various resolutions. Gavin On Sun, 1 Aug 2004 00:25:55 +0200, Magnus Hagander <[EMAIL PROTECTED]> wrote: > >> It's platform specific, therefor it should go in port/. > > > >The criterion for port/

[PATCHES] pg_ctl -o option dumps core when processing postmaster arguments...

2004-08-01 Thread Sean Chittenden
The attached space adds '\0' as a whitespace character and prevents pg_ctl from running out of bounds when processing arguments for -o. I don't think this ever worked, at least on Mac, but I suspect every platform suffered from this bug. % gdb ./bin/pg_ctl GNU gdb 5.3-20030128 (Apple version g

Re: [PATCHES] win32 version info - try 2

2004-08-01 Thread Alvaro Herrera
On Sat, Jul 31, 2004 at 05:40:34PM -0700, Gavin M. Roy wrote: > I took the ai file, reduced it to the right sizes in photoshop and > used an icon editor to make it at various resolutions. Can this be done programatically using, say, ImageMagick? -- Alvaro Herrera () "The West won the world not b

[PATCHES] UTF8 for all translations?

2004-08-01 Thread Serguei A. Mokhov
On Sun, 1 Aug 2004 [EMAIL PROTECTED] wrote: > Date: Sun, 01 Aug 2004 02:40:12 -0300 > > Date: Sun, 1 Aug 2004 13:31:08 +0800 > From: Zhenbang Wei <[EMAIL PROTECTED]> > Subject: Traditional Chinese translations in UTF-8 for 7.5 > > Using UTF-8 instead of anonying Big5. > Sorry for causing problems.

[PATCHES]Traditional Chinese initdb-zh_TW.po for 7.5

2004-08-01 Thread Zhenbang Wei
3 new messages translated. initdb-zh_TW.po Description: Binary data ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])

Re: [PATCHES] fix for parameterized queries in DECLARE CURSOR statements

2004-08-01 Thread Tom Lane
Oliver Jowett <[EMAIL PROTECTED]> writes: > Here's a patch that allows parameterized queries to be used in a DECLARE > CURSOR statement. Applied with minor editorialization. I found a couple of places where you'd missed inserting type Oids into constructed ParamLists, and I took advantage of the

Re: [PATCHES] fix schema ownership on first connection preliminary

2004-08-01 Thread Christopher Kings-Lynne
I'm also wondering about what side-effects this will have on pg_dump behavior. In particular, will pg_dump try to "ALTER OWNER public", and if so will that be appropriate? We haven't previously needed to assume that we are restoring into a database with the same datowner as we dumped from... In m

Re: [PATCHES] Fix for OWNER TO breaking ACLs

2004-08-01 Thread Christopher Kings-Lynne
* You had consistently changed the simple_heap_update calls to do the wrong thing. (I'm surprised it didn't blow up on you in your testing.) In a sequence like newtuple = heap_modifytuple(tup, rel, repl_val, repl_null, repl_repl); simple_heap_update(rel, &newtuple->t_self, newtuple

Re: [PATCHES] USING INDEX TABLESPACE

2004-08-01 Thread Tom Lane
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > The attached patch allows the specification of the tablespace the index > is to be created in for unique and pk constraints. It also fixes the > dumping of such constraints so that they are restored into the correct > tablespace, after they

Re: [PATCHES] USING INDEX TABLESPACE

2004-08-01 Thread Christopher Kings-Lynne
Applied. I also added some code to ruleutils.c to make pg_get_constraintdef output the USING INDEX TABLESPACE clause at need. We might want to think about getting pg_dump to rely more on pg_get_constraintdef and friends, instead of native wit ... Yes, that was really dumb of me not to think of tha

Re: [PATCHES] Fix for OWNER TO breaking ACLs

2004-08-01 Thread Tom Lane
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: >> The way you had it coded, it was generating >> new index entries pointing at the old version of the tuple ... > Strange. I guess I must have been testing with a database that had > short enough system catalogs that the indexes were never use

Re: [PATCHES] UTF8 for all translations?

2004-08-01 Thread Peter Eisentraut
Serguei A. Mokhov wrote: > Why not to use UTF8 fot all .po file for consistency (and to possibly > avoid future problems like that)? I'd consider that a bother that brings us no real benefit. > Take a look at pgAdmin III as an example. I assume that pgAdmin uses a Unicode-only display. We, howe