[PATCHES] doc patch for create role

2005-12-09 Thread Joachim Wieland
Appended is a small documentation patch that adds a note to the CREATE ROLE page, based on what Tom Lane told me here: http://archives.postgresql.org/pgsql-general/2005-11/msg00998.php I think this behavior should be explicitly noted in the docs. Joachim diff -cr

Re: [PATCHES] implement prepared queries in plperl

2005-12-09 Thread Dmitry Karasik
You should probably be working from a CVS checkout, on which case the file you would need to edit is doc/src/sgml/plperl.sgml Thanks! Next question: how do I convert these sgml files to html or text or anything to proofread? If I run gmake, all I get is errors: http://karasik.eu.org/misc/gmake

Re: [PATCHES] CVS of 8.1.x MS-VC6 probrem.

2005-12-09 Thread Magnus Hagander
While I have applied your patch, I am now confused about something. Your change was to pg_config.h.win32, which is used only for WIN32_CLIENT_ONLY compiles, namely MSVC and Borland C. The addition was: /* use _snprintf and _vsnprintf */ #define HAVE_DECL_SNPRINTF 1

Re: [PATCHES] CVS of 8.1.x MS-VC6 probrem.

2005-12-09 Thread Hiroshi Saito
Hi Magnus. libpq and psql also have message translation. AFAIK we don't support NLS builds with MSVC anyway. (Check pg_config.h.win32, it has no #define NLS). So I don't think this is an issue. Um, I agree with you. Probably, Bruce san is also noticed. I thought that Bruce san suggested

Re: [PATCHES] implement prepared queries in plperl

2005-12-09 Thread Dmitry Karasik
please supply documentation (i.e. a patch to the SGML) to accompany this patch the patch to doc/src/sgml/plperl.sgml is attached. -- Sincerely, Dmitry Karasik Index: plperl.sgml === RCS file:

Re: [PATCHES] implement prepared queries in plperl

2005-12-09 Thread Peter Eisentraut
Dmitry Karasik wrote: Thanks! Next question: how do I convert these sgml files to html or text or anything to proofread? If I run gmake, all I get is errors: http://karasik.eu.org/misc/gmake . The script collateindex.pl is also not included in the cvstree, so I'm not sure if I've installed

Re: [PATCHES] CVS of 8.1.x MS-VC6 probrem.

2005-12-09 Thread Magnus Hagander
libpq and psql also have message translation. AFAIK we don't support NLS builds with MSVC anyway. (Check pg_config.h.win32, it has no #define NLS). So I don't think this is an issue. Um, I agree with you. Probably, Bruce san is also noticed. I thought that Bruce san suggested

Re: [PATCHES] CVS of 8.1.x MS-VC6 probrem.

2005-12-09 Thread Tom Lane
Hiroshi Saito [EMAIL PROTECTED] writes: AFAIK we don't support NLS builds with MSVC anyway. (Check pg_config.h.win32, it has no #define NLS). So I don't think this is an issue. Um, I agree with you. Probably, Bruce san is also noticed. I thought that Bruce san suggested the evolution.

Re: [PATCHES] CVS of 8.1.x MS-VC6 probrem.

2005-12-09 Thread Dave Page
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Tom Lane Sent: 09 December 2005 14:01 To: Hiroshi Saito Cc: Magnus Hagander; Bruce Momjian; PostgreSQL-patches Subject: Re: [PATCHES] CVS of 8.1.x MS-VC6 probrem. Hiroshi Saito [EMAIL

Re: [PATCHES] CVS of 8.1.x MS-VC6 probrem.

2005-12-09 Thread Tom Lane
Dave Page dpage@vale-housing.co.uk writes: As one of the people who has had the joy of maintaining this in the past, I wanted to drop it as you may remember but that was rejected on the basis that someone somewhere might want to use their own VC++ build over our precompiled versions for some

Re: [PATCHES] CVS of 8.1.x MS-VC6 probrem.

2005-12-09 Thread Hiroshi Saito
Dear tom san. Thank you for suggestion. Yeah. I had hoped the client-only build would just work with the snprintf changes, but if not there is no time to make it work for 8.1.1. I would like to revisit this for 8.1.2 or 8.2, though. It would be good to have NLS support in the client-only

Re: [PATCHES] CVS of 8.1.x MS-VC6 probrem.

2005-12-09 Thread Dave Page
-Original Message- From: Tom Lane [mailto:[EMAIL PROTECTED] Sent: 09 December 2005 14:33 To: Dave Page Cc: Hiroshi Saito; Magnus Hagander; Bruce Momjian; PostgreSQL-patches Subject: Re: [PATCHES] CVS of 8.1.x MS-VC6 probrem. Dave Page dpage@vale-housing.co.uk writes: As one

Re: [PATCHES] CVS of 8.1.x MS-VC6 probrem.

2005-12-09 Thread Bruce Momjian
Hiroshi Saito wrote: for messages, but libpq and psql also have message translation. The work of using port/snprintf is needed. and If gettext is used Is it desired now? It will be tonight if it becomes so. Sorry, I only realized after I was in bed that we don't use libintl with the

Re: [PATCHES] CVS of 8.1.x MS-VC6 probrem.

2005-12-09 Thread Bruce Momjian
Magnus Hagander wrote: libpq and psql also have message translation. AFAIK we don't support NLS builds with MSVC anyway. (Check pg_config.h.win32, it has no #define NLS). So I don't think this is an issue. Um, I agree with you. Probably, Bruce san is also noticed. I

Re: [PATCHES] CVS of 8.1.x MS-VC6 probrem.

2005-12-09 Thread Bruce Momjian
Magnus Hagander wrote: While I have applied your patch, I am now confused about something. Your change was to pg_config.h.win32, which is used only for WIN32_CLIENT_ONLY compiles, namely MSVC and Borland C. The addition was: /* use _snprintf and _vsnprintf */ #define

Re: [PATCHES] Patch to allow contrib/pgbench files to have blank lines

2005-12-09 Thread David Fetter
On Wed, Nov 23, 2005 at 10:24:00PM +0900, Tatsuo Ishii wrote: Having blank lines in -f scripts was causing silent failures. This fixes it, for some value of fixes. If it's OK, please apply to 8.1 CURRENT and CVS TIP :) Thanks. I have committed your patches to current and 8.1 stable.

Re: [BUGS] [PATCHES] Patch to allow contrib/pgbench files to have blank lines

2005-12-09 Thread Tom Lane
David Fetter [EMAIL PROTECTED] writes: Please apply the following patch that removes an unneeded (and broken) counter increment. Done. regards, tom lane ---(end of broadcast)--- TIP 4: Have you searched our list archives?