[PATCHES] pgstat win32 fix

2004-03-13 Thread Claudio Natoli
For application to HEAD, following community review. Check for EOF on pipe differs under win32, as it is based on a socket implementation. --- Certain disclaimers and policies apply to all email sent from Memetrics. For the full text of these disclaimers and policies see http://www.memetrics.c

[PATCHES] win32 horology/float4/float8 fixes

2004-03-13 Thread Claudio Natoli
For application to HEAD. [float8-small-is-zero and float8-exp-three-digits will likely need similar changes] --- Certain disclaimers and policies apply to all email sent from Memetrics. For the full text of these disclaimers and policies see http://www.memetrics.com/emailpolicy.html";>http://

Re: [PATCHES] PSQLRC environment variable.

2004-03-13 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I just checked a few apps and I see they usually allow a global config > file to be specified. How about SYSPSQLRC that adds a system-wide psql > config file to be read before the one in the home directory? The ones I know of that allow such a thing gen

Re: [PATCHES] client side syntax error position (v3)

2004-03-13 Thread Tom Lane
Fabien COELHO <[EMAIL PROTECTED]> writes: > New submission... after suggestions by Tom and others, the current result > looks like the following: > psql> CREATE foo; > ERROR: syntax error at or near "foo" at character 8 > LINE 1: CREATE foo; >^ > psql> I have applied this patch,

Re: [PATCHES] change output of \dp

2004-03-13 Thread Bruce Momjian
Euler Taveira de Oliveira wrote: > Hi, > > > > I just noticed that \dp outputs "Table" to indicate relations > > > (tables, sequences and views) instead of "Relation" or "Name". This > > > patch just correct it, using "Name" and attaching its "Type". > > > > Maybe we should think of a more gener

Re: [PATCHES] PSQLRC environment variable.

2004-03-13 Thread Bruce Momjian
Bruce Momjian wrote: > Bruce Momjian wrote: > > Tom Lane wrote: > > > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > > Tom Lane wrote: > > > >> Uh, why is that a good idea? > > > > > > > Well, suppose you want all your users to use the same psqlrc file. > > > > Instead of creating symlinks for e

Re: [PATCHES] contrib/xml2 function name change and minor bitrot

2004-03-13 Thread Bruce Momjian
Tom Lane wrote: > Neil Conway <[EMAIL PROTECTED]> writes: > > A few comments on the module: > > > - can you include some licensing information? "Distributed under the > > same terms as PostgreSQL, Copyright ..." should be sufficient unless > > you'd prefer another license > > Actually, it had b

Re: [PATCHES] ECPG: Update tests & memory leak fix

2004-03-13 Thread Bruce Momjian
[ Using diff -c version.] Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Lee Kindness w

Re: [PATCHES] costly foreign key ri checks (4)

2004-03-13 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> * I changed the message wording to conform to the message style >> guidelines. I also made it complain about "costly sequential scans" >> instead of "costly cross-type conversion", since ISTM that's what's >> really at issue here. I'm

Re: [PATCHES] costly foreign key ri checks (4)

2004-03-13 Thread Bruce Momjian
Tom Lane wrote: > > * I changed the message wording to conform to the message style > guidelines. I also made it complain about "costly sequential scans" > instead of "costly cross-type conversion", since ISTM that's what's > really at issue here. I'm not completely wedded to that wording

Re: [PATCHES] costly foreign key ri checks (4)

2004-03-13 Thread Bruce Momjian
Applied by Tom. Thanks. --- Fabien COELHO wrote: > > Dear patchers, > > Following the discussion about previous versions of this patch, please > find attached a new patch candidate for warning about costly foreign key > r

Re: [PATCHES] costly foreign key ri checks (4)

2004-03-13 Thread Tom Lane
Fabien COELHO <[EMAIL PROTECTED]> writes: > Following the discussion about previous versions of this patch, please > find attached a new patch candidate for warning about costly foreign key > referential integrity checks. I have reviewed and applied this, with some tweaking. I attach the patch as

Re: [PATCHES] PSQLRC environment variable.

2004-03-13 Thread James Tanis
In message <[EMAIL PROTECTED]>, Tom Lane avows: %--- Begin Cite ---% > But if they do have their own .psqlrc, doesn't that mean that you fail > to apply the change you need? It seems like this mechanism doesn't If they have their own, then I trust them to do what they want (ie they can then add

Re: [PATCHES] PSQLRC environment variable.

2004-03-13 Thread James Tanis
In message <[EMAIL PROTECTED]>, Tom Lane avows: %--- Begin Cite ---% > James Tanis <[EMAIL PROTECTED]> writes: > > In the tradition of telnet, xinit, and others, I've created a patch wh > ich > > allows users to override the location of .psqlrc by setting the PSQLRC > > environment variable. > >

Re: [PATCHES] pg_autovacuum patch for 7.4.2 and HEAD

2004-03-13 Thread Matthew T. O'Connor
Tom Lane wrote: "Matthew T. O'Connor" <[EMAIL PROTECTED]> writes: ! new_tbl->relid = atol(PQgetvalue(res, row, PQfnumber(res, "oid"))); ! new_tbl->reltuples = atof(PQgetvalue(res, row, PQfnumber(res, "reltuples"))); ! new_tbl->relpages = atol(PQgetvalue(res, row, PQfnumber(res,

Re: [PATCHES] pg_autovacuum patch for 7.4.2 and HEAD

2004-03-13 Thread Matthew T. O'Connor
Tom Lane wrote: "Matthew T. O'Connor" <[EMAIL PROTECTED]> writes: ! new_tbl->relid = atol(PQgetvalue(res, row, PQfnumber(res, "oid"))); ! new_tbl->reltuples = atof(PQgetvalue(res, row, PQfnumber(res, "reltuples"))); ! new_tbl->relpages = atol(PQgetvalue(res, row, PQfnumber(res, "relpages")