Re: [PATCHES] Basic subtransaction facility

2004-04-19 Thread Alvaro Herrera
On Mon, Apr 19, 2004 at 11:13:35AM -0400, Alvaro Herrera wrote: > I noticed that I sent an old version because of a system crash (the > *one* time I don't review vi -r differences it bites me ... argh). It > has several obvious mistakes. Please do not waste your time reviewing > that; I'll submi

Re: [PATCHES] [JDBC] EXECUTE command tag returns actual command

2004-04-19 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Your patch has been added to the PostgreSQL unapplied patches list at: > Kris Jurka wrote: >> This patch makes the EXECUTE command's completion tag return the >> completion tag of the actual statement executed. While I don't have any strong reason to o

Re: [PATCHES] pg_restore ignore error patch v2

2004-04-19 Thread Bruce Momjian
Ah, this v2 version has the proper exit code. Great. --- Fabien COELHO wrote: > > Dear patchers, > > please find attached a small patch so that "pg_restore" ignores some sql > errors. This is the second submission, which

Re: [PATCHES] pg_restore ignore error patch

2004-04-19 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I looked over the patch and it seems to continue on pg_restore errors by > > default. That isn't good. By default, any error should make it exit > > loudly. > > I'm not sure of that. pg_dump is really designed and tested for the >

Re: [PATCHES] pg_restore ignore error patch v2

2004-04-19 Thread Bruce Momjian
[ Newest version.] Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Fabien COELHO wrote:

Re: [PATCHES] pg_restore ignore error patch

2004-04-19 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I looked over the patch and it seems to continue on pg_restore errors by > default. That isn't good. By default, any error should make it exit > loudly. I'm not sure of that. pg_dump is really designed and tested for the case of text dump to a psql sc

Re: [PATCHES] pg_restore ignore error patch

2004-04-19 Thread Bruce Momjian
Fabien COELHO wrote: > > Dear patchers, > > please find a small patch submission so that "pg_restore" ignores some sql > errors. > > The implementation seems quite reasonnable to me, but pg-gods may have a > different opinion. Two fields are added to the ArchiveHandler to trigger > the behavior.

Re: [PATCHES] minor readme patch for pg_autovacuum

2004-04-19 Thread Bruce Momjian
Patch applied. Thanks. --- Andrew Dunstan wrote: > > The attached patch for contrib/pg_autovacuum/README.pg_autovacuum fixes > one apparent error and makes a minor stylistic change that makes it more > consistent and ma

Re: [PATCHES] minor readme patch for pg_autovacuum

2004-04-19 Thread Matthew T. O'Connor
Andrew Dunstan wrote: *** *** 129,135 -v 1000 -V 2 -a 500 (half of -v if not specified) ! -A 1 (half of -v if not specified) -s 300 (5 minutes) -S 2 --- 129,135 -v 1000 -V 2 -a 500 (half of -v if not specified) ! -A 1 (half of -V if not specified) -s 300

[PATCHES] Fix for socket error msgs on win32

2004-04-19 Thread Magnus Hagander
Per discussion earlier today, here is a fix that lets ereport() on win32 report socket errors. //Magnus <> win32_socketerror.patch Description: win32_socketerror.patch ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ?

Re: [PATCHES] win32 fixes

2004-04-19 Thread Bruce Momjian
Newest version of patch applied. Thanks. --- Claudio Natoli wrote: > > For application to HEAD, following community review. > > * Most changes are to fix warnings issued when compiling win32 > * removed a few redundant d

[PATCHES] CSV patch applied

2004-04-19 Thread Bruce Momjian
I have applied the attached patch that complete TODO item: o -Allow dump/load of CSV format This adds new keywords to COPY and \copy: CSV - enable CSV mode QUOTE - specify quote character ESCAPE - specify escape character FORCE - force quoting of specified

[PATCHES] minor readme patch for pg_autovacuum

2004-04-19 Thread Andrew Dunstan
The attached patch for contrib/pg_autovacuum/README.pg_autovacuum fixes one apparent error and makes a minor stylistic change that makes it more consistent and makes clear something that confused me :-) cheers andrew Index: contrib/pg_autovacuum/README.pg_autovacuum

Re: [PATCHES] Basic subtransaction facility

2004-04-19 Thread Bruce Momjian
Patch withdrawn by author. --- Alvaro Herrera wrote: > Hackers, > > Here is a very preliminar patch that allows the user to say "BEGIN" > inside a transaction and have the system react accordingly. This is > only a modific

Re: [PATCHES] Basic subtransaction facility

2004-04-19 Thread Alvaro Herrera
On Sun, Apr 18, 2004 at 11:29:05AM -0400, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > If you want. When not #defined, the behavior is the same as the current > > code, so it shouldn't affect anything. However I posted mainly so > > people could comment on the modifications, a