Re: [PATCHES] [pgsql-hackers-win32] [BUGS] Win32 deadlock detection not wor

2004-09-02 Thread Claudio Natoli
> Just outta curiosity, why wasn't that detected by the > regression tests? > There is a test that depends on statement_timeout working ... For the record, this was reported here a couple days after the plpgsql test was changed: http://archives.postgresql.org/pgsql-hackers/2004-08/msg00482.php

Re: [PATCHES] [pgsql-hackers-win32] [BUGS] Win32 deadlock detection not working for Postgres8beta1

2004-09-02 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: >> A reasonable theory about this would be that the timer interrupt isn't >> firing. Does "statement_timeout" work either? > Bugger. I've found the reason for this - statement_timeout was also > broken. This was broken by the change of how signals are

Re: [PATCHES] [pgsql-hackers-win32] [BUGS] Win32 deadlock detection not working for Postgres8beta1

2004-09-02 Thread Magnus Hagander
>>Bugger. I've found the reason for this - statement_timeout was also >>broken. This was broken by the change of how signals are handled on >>win32. We disabled APCs completely, but APCs were still used in the >>timer emulation... This patch fixes this by re-enabling APCs >>in the main >>check loo

Re: [PATCHES] [pgsql-hackers-win32] [BUGS] Win32 deadlock detection not working for Postgres8beta1

2004-09-02 Thread Magnus Hagander
>Bugger. I've found the reason for this - statement_timeout was also >broken. This was broken by the change of how signals are handled on >win32. We disabled APCs completely, but APCs were still used in the >timer emulation... This patch fixes this by re-enabling APCs >in the main >check loop. Th

Re: [PATCHES] [pgsql-hackers-win32] [BUGS] Win32 deadlock detection not working for Postgres8beta1

2004-09-02 Thread Magnus Hagander
>> I am just starting to test out Postgres8 beta1 and notice that the >> deadlock detection mechanism is not working (under windows >XP pro with >> service pack 1). I am using the version of Postgres built by the >> PGFoundry project, and have it installed as a service. > >> To produce the bug I

Re: [PATCHES] Typo in initdb.c

2004-09-02 Thread Tom Lane
"Greg Sabino Mullane" <[EMAIL PROTECTED]> writes: > src/bin/initdb/initdb.c =~ s/authenication/authentication/ Got it, thanks. regards, tom lane ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL

Re: [PATCHES] getrusage on win32

2004-09-02 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > Here is a fix for getrusage on win32. This fixes the bad timing output > from vacuum verbose. Applied. regards, tom lane ---(end of broadcast)--- TIP 4: Don't 'kill -9' the pos

[PATCHES] getrusage on win32

2004-09-02 Thread Magnus Hagander
Here is a fix for getrusage on win32. This fixes the bad timing output from vacuum verbose. The reason for the really weird numbers before was that the memset() used to clear out the structure used sizeof(rusage) instead of sizeof(struct rusage). That said, the old version didn't actually return a

Re: [PATCHES] pgxs default installation + various fixes

2004-09-02 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > What was the argument for having an "install-all-headers" target in the > first place? By my count it adds about 2 megabytes to the installed footprint, which perhaps is not so much now as it was at the time. A larger problem from my point of view is t

Re: [PATCHES] pgxs default installation + various fixes

2004-09-02 Thread Alvaro Herrera
On Thu, Sep 02, 2004 at 02:10:13PM +0200, Peter Eisentraut wrote: > Am Donnerstag, 2. September 2004 10:16 schrieb Fabien COELHO: > > (1) "make intall" installs everything. > > > > (2) "make light-install" does not install pgxs and server dev stuff. > > this is the previous version of "make in

[PATCHES] Typo in initdb.c

2004-09-02 Thread Greg Sabino Mullane
src/bin/initdb/initdb.c =~ s/authenication/authentication/ ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]

Re: [PATCHES] pgxs default installation + various fixes

2004-09-02 Thread Alvaro Herrera
On Thu, Sep 02, 2004 at 02:31:14PM +0200, Fabien COELHO wrote: > This is to take into account Tom's view that distributions are often split > with a separate "dev" package for developpements. For instance under > Debian there are: postgresql, postgresql-client, postgresql-dev, > postgresql-doc...

Re: [PATCHES] pgxs default installation + various fixes

2004-09-02 Thread Fabien COELHO
Dear Peter, > > This is to take into account Tom's view that distributions are often split > > with a separate "dev" package for developpements. For instance under > > Debian there are: postgresql, postgresql-client, postgresql-dev, > > postgresql-doc... So this target would help checking what fi

Re: [PATCHES] pgxs default installation + various fixes

2004-09-02 Thread Peter Eisentraut
Am Donnerstag, 2. September 2004 14:31 schrieb Fabien COELHO: > I meant: "This target may be of interest for packagers", sorry for my poor > English writing and typing skills. I understood that. :) > This is to take into account Tom's view that distributions are often split > with a separate "dev

Re: [PATCHES] time_t timezone

2004-09-02 Thread Bruce Momjian
Reini Urban wrote: > > # PGAC_VAR_INT_TIMEZONE > > # - > > # Check if the global variable `timezone' exists. If so, define > > # HAVE_INT_TIMEZONE. > > AC_DEFUN([PGAC_VAR_INT_TIMEZONE], > > [AC_CACHE_CHECK(for int timezone, pgac_cv_var_int_timezone, > >

Re: [PATCHES] time_t timezone

2004-09-02 Thread Tom Lane
Reini Urban <[EMAIL PROTECTED]> writes: > This test fails, because you cannot do arithmetic with time_t. You apparently speak some different flavor of C than the rest of us. regards, tom lane ---(end of broadcast)--- TIP 4:

Re: [PATCHES] pgxs default installation + various fixes

2004-09-02 Thread Fabien COELHO
Dear Peter, > > (2) "make light-install" does not install pgxs and server dev stuff. > > this is the previous version of "make install". > > If we do that, we should remove install-all-headers. It's very confusing > otherwise. > > > This target maybe of interest of packagers. > > This

Re: [PATCHES] pgxs default installation + various fixes

2004-09-02 Thread Peter Eisentraut
Am Donnerstag, 2. September 2004 10:16 schrieb Fabien COELHO: > (1) "make intall" installs everything. > > (2) "make light-install" does not install pgxs and server dev stuff. > this is the previous version of "make install". If we do that, we should remove install-all-headers. It's very con

Re: [PATCHES] Win32 Version patch

2004-09-02 Thread Dave Page
> -Original Message- > From: Magnus Hagander [mailto:[EMAIL PROTECTED] > Sent: 02 September 2004 09:47 > To: Bruce Momjian; Dave Page > Cc: PostgreSQL-patches > Subject: RE: [PATCHES] Win32 Version patch > > But I can send > the same patch again. Line 398 should probably be + PGFIL

Re: [PATCHES] Win32 Version patch

2004-09-02 Thread Magnus Hagander
> Dave Page wrote: > > Evening committers, > > > > Any ideas when Magnus' win32 version numbering patch is > likely to get > > applied? > > Good question. Last I saw it it was quite large. Magnus, > would you post a new version so we can look it over again. I > have no problem with the bin

Re: [PATCHES] dbsize contrib

2004-09-02 Thread Andreas Pflug
Bruce Momjian wrote: Patch applied. Thanks. Can I get some documentation in the README for all the new functionality. Here it is. Regards, Andreas Index: README.dbsize === RCS file: /projects/cvsroot/pgsql-server/contrib/dbsize/README

[PATCHES] pgxs default installation + various fixes

2004-09-02 Thread Fabien COELHO
Dear patchers, This patch addresses open item "make pgxs install by default" in Bruce's list. (1) "make intall" installs everything. (2) "make light-install" does not install pgxs and server dev stuff. this is the previous version of "make install". This target maybe of interest of pa