Re: [ODBC] [PATCHES] patch win32.mak of libpq

2007-08-03 Thread Hiroshi Saito
Hi Magnus. I'm sorry lateness of a reaction.. Thanks! P.S) Inoue-san is busy and worsens condition. Regards, Hiroshi Saito Ok. Just to be clear, do you need MSVC7.1 support, or do you need win32.mak/nmake support? I realize they both work here, but if we changed something else that needed

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-08-03 Thread Magnus Hagander
On Wed, Aug 01, 2007 at 11:17:21AM +0900, Hiroshi Saito wrote: Hiroshi Saito [EMAIL PROTECTED] writes: [ patch to use pg_strftime in xlog.c ] This code deliberately does not use pg_strftime, for the same reasons that elog.c doesn't use it. I'm inclined to think that an appropriate fix is

Re: [PATCHES] patch win32.mak of libpq

2007-08-03 Thread Magnus Hagander
On Fri, Jul 27, 2007 at 10:01:06PM +0200, Magnus Hagander wrote: Hiroshi Saito wrote: Ok. So there are actually two ways to go about it: 1) Discontinue support for MSVC6 and require MSVC8 2) Change it so that MSVC6 can still build libpq, just not with SSPI support. This can be done by

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-08-03 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: On Fri, Aug 03, 2007 at 09:01:22AM -0400, Andrew Dunstan wrote: Having talked a bit off-list with Hiroshi-san, he came up with the suggestion taht we should be logging this information in UTC/GMT instead of the servers timezone (for all cases, not just

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-08-03 Thread Hiroshi Saito
Hi. From: Tom Lane [EMAIL PROTECTED] Gregory Stark [EMAIL PROTECTED] writes: Tom Lane [EMAIL PROTECTED] writes: I don't think it's an acceptable change in either place. People who want to see UTC in their logs can start the postmaster in UTC. Those who are accustomed to seeing local time

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-08-03 Thread Hiroshi Saito
Hiroshi Saito [EMAIL PROTECTED] writes: I understand the essence which you say. Then, I think that gmtime is an ideal there. localtime also takes summer time into consideration. It changes and sometimes falls unconsciously. Furthermore, a tzname can't be expressed by the present elog

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-08-03 Thread Tom Lane
Hiroshi Saito [EMAIL PROTECTED] writes: I understand the essence which you say. Then, I think that gmtime is an ideal there. localtime also takes summer time into consideration. It changes and sometimes falls unconsciously. Furthermore, a tzname can't be expressed by the present elog

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-08-03 Thread Tom Lane
Gregory Stark [EMAIL PROTECTED] writes: Tom Lane [EMAIL PROTECTED] writes: I don't think it's an acceptable change in either place. People who want to see UTC in their logs can start the postmaster in UTC. Those who are accustomed to seeing local time will squawk. It would probably make

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-08-03 Thread Magnus Hagander
On Fri, Aug 03, 2007 at 09:01:22AM -0400, Andrew Dunstan wrote: [ patch to use pg_strftime in xlog.c ] This code deliberately does not use pg_strftime, for the same reasons that elog.c doesn't use it. I'm inclined to think that an appropriate fix is the same as we use in elog.c,

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-08-03 Thread Andrew Dunstan
Magnus Hagander wrote: On Wed, Aug 01, 2007 at 11:17:21AM +0900, Hiroshi Saito wrote: Hiroshi Saito [EMAIL PROTECTED] writes: [ patch to use pg_strftime in xlog.c ] This code deliberately does not use pg_strftime, for the same reasons that elog.c doesn't use it. I'm

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-08-03 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Tom's idea of a log_timezone seems to make sense. I'll code that up and see if there are any unexpected gotchas. regards, tom lane ---(end of broadcast)--- TIP 4: Have you searched

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-08-03 Thread Gregory Stark
Tom Lane [EMAIL PROTECTED] writes: Magnus Hagander [EMAIL PROTECTED] writes: On Fri, Aug 03, 2007 at 09:01:22AM -0400, Andrew Dunstan wrote: Having talked a bit off-list with Hiroshi-san, he came up with the suggestion taht we should be logging this information in UTC/GMT instead of the

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-08-03 Thread Andrew Dunstan
Gregory Stark wrote: Well even if we include the time in integer seconds-since-unix-epoch format it would be useful for a CSV data format. That's probably the worst of all possible options. Two very common uses of CSVlogs will be a) to load them into a PostgreSQL table and b) to

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-08-03 Thread Michael Glaesemann
On Aug 3, 2007, at 10:33 , Tom Lane wrote: People who find the above arguments compelling would certainly be free to set their log_timezone to GMT. Those who don't find them compelling should not be forced to deal in GMT. The fact that Postgres has always logged in system local time,

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-08-03 Thread Gregory Stark
Andrew Dunstan [EMAIL PROTECTED] writes: That's probably the worst of all possible options. Two very common uses of CSVlogs will be a) to load them into a PostgreSQL table and b) to load them into a spreadsheet such as Excel. In both cases having a Unix epoch time rather than a timestamp

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-08-03 Thread Hiroshi Saito
Andrew Dunstan [EMAIL PROTECTED] writes: Tom's idea of a log_timezone seems to make sense. I'll code that up and see if there are any unexpected gotchas. BTW, windows user should do how.? How do you think? Does it say Set up an environment variable? set TZ= Regards, Hiroshi Saito

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-08-03 Thread Gregory Stark
Tom Lane [EMAIL PROTECTED] writes: Gregory Stark [EMAIL PROTECTED] writes: Tom Lane [EMAIL PROTECTED] writes: I don't think it's an acceptable change in either place. People who want to see UTC in their logs can start the postmaster in UTC. Those who are accustomed to seeing local time

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-08-03 Thread Tom Lane
Hiroshi Saito [EMAIL PROTECTED] writes: BTW, windows user should do how.? How do you think? Does it say Set up an environment variable? set TZ= What do they do now to set the postmaster's timezone? That would determine log_timezone too, if they don't override it in postgresql.conf.

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-08-03 Thread Magnus Hagander
Tom Lane wrote: Hiroshi Saito [EMAIL PROTECTED] writes: BTW, windows user should do how.? How do you think? Does it say Set up an environment variable? set TZ= What do they do now to set the postmaster's timezone? That would determine log_timezone too, if they don't override it in

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-08-03 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Tom's idea of a log_timezone seems to make sense. Here's a preliminary patch for this --- no docs yet, but code is all there. Seems to work OK. The patch is larger than it'd really have to be because I chose to rename global_timezone to

Re: [PATCHES] Async Commit, v21 (now: v22)

2007-08-03 Thread Simon Riggs
On Wed, 2007-08-01 at 18:54 -0400, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: Here's v23, including all suggested changes, plus some reworking of the transaction APIs to reduce the footprint of the patch. Applied with some editorialization --- Thanks I found a few bugs, as

Re: [PATCHES] Repair cosmetic damage (done by pg_indent?)

2007-08-03 Thread Decibel!
On Sun, Jul 29, 2007 at 12:06:50PM +0100, Gregory Stark wrote: Decibel! [EMAIL PROTECTED] writes: On Fri, Jul 27, 2007 at 04:07:01PM +0100, Gregory Stark wrote: Fwiw, do we really not want to compress anything smaller than 256 bytes (everyone in Postgres uses the default strategy, not the

Re: [PATCHES] strpos() KMP

2007-08-03 Thread Decibel!
On Thu, Aug 02, 2007 at 01:18:22AM +0500, Pavel Ajtkulov wrote: Hello, this patch allow to use Knuth-Morrison-Pratt algorithm for strpos() function (see Cormen et al. Introduction to Algorithms, MIT Press, 2001). It also works with multibyte wchar. In worst case current brute force

Re: [PATCHES] Repair cosmetic damage (done by pg_indent?)

2007-08-03 Thread Decibel!
On Fri, Aug 03, 2007 at 06:12:09PM -0500, Decibel! wrote: On Sun, Jul 29, 2007 at 12:06:50PM +0100, Gregory Stark wrote: Decibel! [EMAIL PROTECTED] writes: On Fri, Jul 27, 2007 at 04:07:01PM +0100, Gregory Stark wrote: Fwiw, do we really not want to compress anything smaller than 256

Re: [PATCHES] COPYable logs

2007-08-03 Thread Andrew Dunstan
Tom Lane wrote: There are two approaches we could take to fixing this: 1. Redirect_stderr is the start-time flag for both features, ie, if it's set we always create both pipes and start the syslogger, but Log_destination controls what actually gets used. (Possibly Redirect_stderr should be