Re: [PATCHES] msvc = VC7 understands __FUNCTION__

2007-10-01 Thread Magnus Hagander
On Fri, Sep 28, 2007 at 10:43:17PM +0200, Hannes Eder wrote: Hi, Starting from version VC7 msvc supports __FUNCTION__, so I think this could be enabled in pg_config.h.win32, see attached diff. Applied, thanks. //Magnus ---(end of

Re: [PATCHES] OpenSSL Applink

2007-10-01 Thread Magnus Hagander
On Sat, Sep 29, 2007 at 09:01:16PM +0100, Dave Page wrote: Tom Lane wrote: Dave Page [EMAIL PROTECTED] writes: From: Tom Lane [EMAIL PROTECTED] ... It's not entirely clear whether BIO_new_fp() would avoid the problematic calls, but it doesn't look like it'd be hard to try. The last

[PATCHES] 64bit compile linker problem of win32.mak.

2007-10-01 Thread Hiroshi Saito
Hi Magnus. I saw one problem on Platform SDK. http://support.microsoft.com/kb/894573/en/ This can be helped. Thanks! Regards, Hiroshi Saito win32mak_patch Description: Binary data ---(end of broadcast)--- TIP 7: You can help support the

Re: [PATCHES] TCL fix in HEAD

2007-10-01 Thread Marshall, Steve
Bruce Momjian wrote: Marshall, Steve wrote: The recent TCL patch assumed Tcl_NotifierProcs.initNotifierProc was added in TCL 8.2: In fact it was added in 8.4 so I have modified the CVS with the following patch. I confirmed this against the 8.2.5 release. Sorry I did not notice

Re: [PATCHES] OpenSSL Applink

2007-10-01 Thread Magnus Hagander
On Mon, Oct 01, 2007 at 02:37:44PM +0200, Magnus Hagander wrote: On Sat, Sep 29, 2007 at 09:01:16PM +0100, Dave Page wrote: Tom Lane wrote: Dave Page [EMAIL PROTECTED] writes: From: Tom Lane [EMAIL PROTECTED] ... It's not entirely clear whether BIO_new_fp() would avoid the

Re: [PATCHES] OpenSSL Applink

2007-10-01 Thread Magnus Hagander
On Mon, Oct 01, 2007 at 03:16:13PM +0200, Magnus Hagander wrote: On Mon, Oct 01, 2007 at 02:37:44PM +0200, Magnus Hagander wrote: On Sat, Sep 29, 2007 at 09:01:16PM +0100, Dave Page wrote: Tom Lane wrote: Dave Page [EMAIL PROTECTED] writes: From: Tom Lane [EMAIL PROTECTED] ...

Re: [PATCHES] OpenSSL Applink

2007-10-01 Thread Dave Page
Magnus Hagander wrote: Yes, that was the problem. Attached patch fixes the problem for me on Windows and Linux using the error mark functionality. It seems a lot cleaner than the other option. Dave - can you test this one? Assuming that works, I'll go ahead and apply it. Yep, looks good

Re: [PATCHES] 64bit compile linker problem of win32.mak.

2007-10-01 Thread Magnus Hagander
On Mon, Oct 01, 2007 at 09:45:43PM +0900, Hiroshi Saito wrote: Hi Magnus. I saw one problem on Platform SDK. http://support.microsoft.com/kb/894573/en/ This can be helped. Thanks! Applied, thanks. //Magnus ---(end of broadcast)--- TIP 9:

Re: [PATCHES] OpenSSL Applink

2007-10-01 Thread Tom Lane
Dave Page [EMAIL PROTECTED] writes: Magnus Hagander wrote: Should we backpatch all the stuff, or just the error push/pop thing? All of it. Anyone building just libpq/psql using the old MSVC makefiles will probably see the applink problem if they try to use client certs. I'd vote for

Re: [PATCHES] OpenSSL Applink

2007-10-01 Thread Magnus Hagander
On Mon, Oct 01, 2007 at 10:51:01AM -0400, Tom Lane wrote: Dave Page [EMAIL PROTECTED] writes: Magnus Hagander wrote: Should we backpatch all the stuff, or just the error push/pop thing? All of it. Anyone building just libpq/psql using the old MSVC makefiles will probably see the

Re: [PATCHES] OpenSSL Applink

2007-10-01 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: On Mon, Oct 01, 2007 at 10:51:01AM -0400, Tom Lane wrote: I'd vote for backpatching, but only as far as 8.2, seeing that we're abandoning the older branches on Windows. Should we backpatch a version of it to previous versions that does just the error

[PATCHES] Patch to inline stable SQL set returning UDFs

2007-10-01 Thread Richard Rowell
I discussed this hack with Neil and Josh in Ottawa back in May. I took a stab at it a few weeks ago and below are the results. It is mostly modeled after the existing inline_function. The approach taken is to recursively cleanup the RTable where stable SQL functions are found in it. I've been

Re: [PATCHES] TCL fix in HEAD

2007-10-01 Thread Tom Lane
Marshall, Steve [EMAIL PROTECTED] writes: Bruce Momjian wrote: Can you send in a patch against pltcl.sgml? PL/TCL documentation patch is attached. This seems a bit wordy, as well as wrongly placed --- the time to tell people they need a non-multithreaded Tcl is in the installation

Re: [PATCHES] TCL fix in HEAD

2007-10-01 Thread Marshall, Steve
I'm fine with Tom's wording and placement. This seems a bit wordy, as well as wrongly placed --- the time to tell people they need a non-multithreaded Tcl is in the installation instructions. I added the following instead. regards, tom lane

[PATCHES] Patch to inline stable SQL set returning UDFs

2007-10-01 Thread richard
I discussed this hack with Neil and Josh in Ottawa back in May. I took a stab at it a few weeks ago and below are the results. It is mostly modeled after the existing inline_function. The approach taken is to recursively cleanup the rtable. I've been testing this in our dev environment for a

Re: [PATCHES] [HACKERS] Text - C string

2007-10-01 Thread Brendan Jurd
As discussed on -hackers, I'm trying to get rid of some redundant code by creating a widely useful set of functions to convert between text and C string in the backend. The new extern functions, declared in include/utils/builtins.h and defined in backend/utils/adt/varlena.c, are: char *

Re: [PATCHES] OpenSSL Applink

2007-10-01 Thread Magnus Hagander
Tom Lane wrote: Magnus Hagander [EMAIL PROTECTED] writes: On Mon, Oct 01, 2007 at 10:51:01AM -0400, Tom Lane wrote: I'd vote for backpatching, but only as far as 8.2, seeing that we're abandoning the older branches on Windows. Should we backpatch a version of it to previous versions that

[PATCHES] Loose check was corrected of win32.mak.

2007-10-01 Thread Hiroshi Saito
Hi Magnus. Loose check was corrected... and, It notifies an intelligible error message. Regards, Hiroshi Saito win32mak_patch Description: Binary data ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings

[PATCHES] ecpg thread-safe descriptor

2007-10-01 Thread ITAGAKI Takahiro
Here is a patch to fix thread-safety of SQL DESCRIPTOR in ecpg. The global variable 'all_descriptors' is split into per-thread vars. There was another idea of splitting into per-connection vars, but I did not do that because there are allocating descriptors before connection and deallocating