Re: [PATCHES] "fix" for plpgsql polymorphism

2003-07-02 Thread Alvaro Herrera
a var node > + */ > + var = malloc(sizeof(PLpgSQL_var)); > + memset(var, 0, sizeof(PLpgSQL_var)); why is this a malloc() and not palloc()? And when/where/how is it freed? -- Alvaro Herrera () "El Maquinismo fue proscrito so pena de c

Re: [PATCHES] "fix" for plpgsql polymorphism

2003-07-02 Thread Alvaro Herrera
On Thu, Jul 03, 2003 at 12:11:36AM -0400, Tom Lane wrote: > Joe Conway <[EMAIL PROTECTED]> writes: > > Alvaro Herrera wrote: > >> why is this a malloc() and not palloc()? And when/where/how is it freed? > > > It isn't, at least not until the backend exits

[PATCHES] updated libpq spanish translation

2003-08-24 Thread Alvaro Herrera
One untranslated message ("NOTICE"). Please install. $ msgfmt -c -v po/es.po 99 mensajes traducidos, 1 mensaje sin traducir. -- Alvaro Herrera () Voy a acabar con todos los humanos / con los humanos yo acabaré voy a acabar con todos / con todos los humanos acabaré (Bender) # Spani

[PATCHES] psql spanish l10n

2003-08-24 Thread Alvaro Herrera
Attached is a (new) spanish PO file for psql: $ LANG= msgfmt -v -c po/es.po 269 translated messages, 2 untranslated messages. Please install. Don't forget to add to nls.mk... Thanks. -- Alvaro Herrera () Voy a acabar con todos los humanos / con los humanos yo acabaré voy a acabar con

[PATCHES] small typos

2003-08-24 Thread Alvaro Herrera
Patchers, This fixes three minor typos in hba.c. -- Alvaro Herrera () "There was no reply" (Kernel Traffic) Index: src/backend/libpq/hba.c === RCS file: /home/alvherre/cvs/pgsql-server/src/backend/libpq/hba.c,v retrievin

[PATCHES] message not following the guidelines

2003-09-11 Thread Alvaro Herrera
This message seems to be breaking the message guidelines. -- Alvaro Herrera () "Porque francamente, si para saber manejarse a uno mismo hubiera que rendir examen... ¿Quién es el machito que tendría carnet?" (Mafalda) Index: opc

[PATCHES] NLS changes

2003-09-14 Thread Alvaro Herrera
done: $ LANG= msgfmt -c -v es.po 1757 translated messages, 29 untranslated messages. I'll submit after I resolve a couple of translations that are not clear. -- Alvaro Herrera () "La victoria es para quien se atreve a estar solo" Index: nls.mk

Re: [PATCHES] NLS changes

2003-09-14 Thread Alvaro Herrera
On Sun, Sep 14, 2003 at 02:14:22AM -0400, Alvaro Herrera wrote: > - adds .y files to gettext-files in backend/nls.mk. gram.y contains > several translatable messages that are not catched by update-po unless > the gram.c file is generated. I don't know if this is desirable b

Re: [PATCHES] [BUGS] bug in clusterdb script

2003-09-27 Thread Alvaro Herrera
applies to the 7.3 branch only, because in 7.4 the script got reimplemented. -- Alvaro Herrera () "The Gord often wonders why people threaten never to come back after they've been told never to return" (www.actsofgord.com) ---(end of broadcast)-

[PATCHES] more spanish updates

2003-10-03 Thread Alvaro Herrera
Peter, Attached are psql and libpq spanish PO files, 100% translated. $ LC_MESSAGES=C msgfmt -c -v libpq-es.po 100 translated messages. $ LC_MESSAGES=C msgfmt -c -v psql-es.po 453 translated messages. Please install. -- Alvaro Herrera () "Por suerte hoy explotó el califont porque si

Re: [PATCHES] more spanish updates

2003-10-04 Thread Alvaro Herrera
On Sat, Oct 04, 2003 at 08:13:23PM +0200, Peter Eisentraut wrote: > Alvaro Herrera writes: > > > Attached are psql and libpq spanish PO files, 100% translated. > > Installed. Thanks. Did you get this one? http://archives.postgresql.org/pgsql-patches/2003-10/msg9.php (b

[PATCHES] spanish translation updates

2003-10-05 Thread Alvaro Herrera
Peter, Attached are pg_controldata, pgscripts and libpq spanish translations. I will be asking for review from the rest of the spanish group so there probably will be more updates as we get the style polished. Please install. Thanks. -- Alvaro Herrera () "El que vive para el futuro

Re: [Fwd: [PATCHES] Make psql use all pretty print options]

2003-10-10 Thread Alvaro Herrera
On Fri, Oct 10, 2003 at 12:42:50PM +0800, Christopher Kings-Lynne wrote: > OK, for reviewers. Note the index predicate and the check constraint in > particular. It seems to have the nice property of allowing output to be copy-n-pasted without further modification. -- Alvaro Herrera (

[PATCHES] spanish updates, take 2

2003-10-25 Thread Alvaro Herrera
I attach the whole spanish PO catalogs again, correcting some typos. They are at 100% again. I already posted them three days ago, but they got lost probably because the size of the mail. I will post the backend and libpq catalog separately. -- Alvaro Herrera () Si no sabes adonde vas, es muy

[PATCHES] spanish psql update

2003-10-25 Thread Alvaro Herrera
The spanish psql message catalog is attached. -- Alvaro Herrera () "La gente vulgar solo piensa en pasar el tiempo; el que tiene talento, en aprovecharlo" psql-es.po.gz Description: Binary data ---(end of broadcast)--- TIP 3: if posti

[PATCHES] spanish pg_dump catalog

2003-10-27 Thread Alvaro Herrera
One string added and some typos corrected. Please install. -- Alvaro Herrera () "La experiencia nos dice que el hombre peló millones de veces las patatas, pero era forzoso admitir la posibilidad de que en un caso entre millones, las patatas pelarían al hombre" (Ijon Tichy) pg_dum

Re: [PATCHES] [HACKERS] BEGIN vs START TRANSACTION

2003-11-10 Thread Alvaro Herrera
work alike. But maybe it would be useful to point out the difference; for example, users will get confused if they try to start a subtransaction inside a plpgsql function using BEGIN. -- Alvaro Herrera () "El miedo atento y previsor es la madre de la seguridad" (E. Burke) ---

Re: [PATCHES] ALTER TABLE modifications

2003-11-14 Thread Alvaro Herrera
ould break lots of > code. This is expected. Doing otherwise would incur into a much bigger performance hit. Anyway, IMHO no code should use SELECT * in any case, which is the only scenario where one would expect physical column order to matter, isn't it? -- Alvaro Herrera ()

Re: [PATCHES] introduce "default_use_oids"

2003-12-01 Thread Alvaro Herrera
a different RDBMS? I haven't tried it so I don't know if it works, but this patch takes out the ability to do that -- no one else will accept WITH/WITHOUT OIDS, so the dump will have to be modified. Is a switch provided to stop the emission of those modifiers? -- Alvaro Herrera () &q

Re: [PATCHES] fork/exec patch

2003-12-14 Thread Alvaro Herrera
and no one had issues with that. > > You can hardly claim that "no one had issues with that". I complained > about it and I think other people did too. It's a messy, ugly approach; > moreover we have no field experience that says it's reliable. Don't the

Re: [PATCHES] Alpha test

2003-12-22 Thread Alvaro Herrera
m? Just an idea. -- Alvaro Herrera () Si no sabes adonde vas, es muy probable que acabes en otra parte. ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match

[PATCHES] trivial typos

2004-01-19 Thread Alvaro Herrera
Attached is a patch that fixes some trivial typos and alignment. Please apply. -- Alvaro Herrera () "Siempre hay que alimentar a los dioses, aunque la tierra esté seca" (Orual) diff -cr --exclude=CVS 00orig/src/backend/access/transam/xact.c 01trivial/src/backend/access/tran

[PATCHES] small smgr refactoring

2004-01-19 Thread Alvaro Herrera
I attach a small patch that slightly refactors some code in storage/smgr/smgr.c. Regression test pass. There's no change in functionality, only code reordering. (Well, it changes an ad-hoc linked list into a proper List). Please review and if Ok, apply. -- Alvaro Herrera () "A

Re: [PATCHES] small smgr refactoring

2004-01-19 Thread Alvaro Herrera
On Mon, Jan 19, 2004 at 06:20:21PM -0500, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > (Well, it changes an ad-hoc linked > > list into a proper List). > > Why? AFAICT that just makes the code bigger, uglier, and slower ... Oh, does it? Hmm. W

Re: [PATCHES] installdir patch for win32

2004-03-25 Thread Alvaro Herrera
shouldn't have any platform dependencies. Don't forget about the EXEC_BACKEND businness ... is there any chance those could refactored somehow? -- Alvaro Herrera () "Amanece. (Ignacio Reyes) El Cerro San Cristóba

[PATCHES] Removing cruft in access/transam/xact.c

2004-03-26 Thread Alvaro Herrera
the latter can be renamed ... This passes the full regression test suite. Please review and apply if OK. -- Alvaro Herrera () "I think my standards have lowered enough that now I think 'good design' is when the page doesn't irritate the living f*ck out of me.&qu

Re: [PATCHES] Removing cruft in access/transam/xact.c

2004-03-27 Thread Alvaro Herrera
On Sat, Mar 27, 2004 at 12:21:07AM -0500, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > This patch removes the unnecesary TRANS_* states that supposedly > > represented "low level transaction state". The state is actually > > unnecesary

Re: [PATCHES] Removing cruft in access/transam/xact.c

2004-03-28 Thread Alvaro Herrera
On Sat, Mar 27, 2004 at 09:12:15PM -0400, Alvaro Herrera wrote: > On Sat, Mar 27, 2004 at 12:21:07AM -0500, Tom Lane wrote: > > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > > This patch removes the unnecesary TRANS_* states that supposedly > > > represented &q

Re: [PATCHES] Removing cruft in access/transam/xact.c

2004-03-28 Thread Alvaro Herrera
all this, I still think the TRANS state is unnecesary. I will add checks in the low level routines so they see what TBLOCK state they are called in, which should be enough to keep the current functionality and robustness. -- Alvaro Herrera () "A wizard is never late, Frodo Baggins, nor i

Re: [PATCHES] Removing cruft in access/transam/xact.c

2004-03-28 Thread Alvaro Herrera
On Sun, Mar 28, 2004 at 06:16:59PM -0400, Alvaro Herrera wrote: > After all this, I still think the TRANS state is unnecesary. I will add > checks in the low level routines so they see what TBLOCK state they are > called in, which should be enough to keep the current functional

[PATCHES] xact.c cleanup -- uncontroversial try

2004-03-30 Thread Alvaro Herrera
review and apply if OK. -- Alvaro Herrera () "El sabio habla porque tiene algo que decir; el tonto, porque tiene que decir algo" (Platon). Index: src/backend/access/transam/xact.c === RCS file: /home/alvherre/cvs/pgsql-

[PATCHES] Basic subtransaction facility

2004-04-13 Thread Alvaro Herrera
ser issues ROLLBACK, the parent can be allowed to continue. Please have a look and comment. This file does not move a lot so I don't think it will suffer from a lot of code drift. -- Alvaro Herrera () "I think my standards have lowered enough that now I think 'good design&

Re: [PATCHES] Basic subtransaction facility

2004-04-17 Thread Alvaro Herrera
gets more testing. > ------- > > Alvaro Herrera wrote: > > Hackers, > > > > Here is a very preliminar patch that allows the user to say "BEGIN" > > inside a transaction and have the system

Re: [PATCHES] Basic subtransaction facility

2004-04-19 Thread Alvaro Herrera
On Sun, Apr 18, 2004 at 11:29:05AM -0400, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > If you want. When not #defined, the behavior is the same as the current > > code, so it shouldn't affect anything. However I posted mainly so > > people co

Re: [PATCHES] Basic subtransaction facility

2004-04-19 Thread Alvaro Herrera
On Mon, Apr 19, 2004 at 11:13:35AM -0400, Alvaro Herrera wrote: > I noticed that I sent an old version because of a system crash (the > *one* time I don't review vi -r differences it bites me ... argh). It > has several obvious mistakes. Please do not waste your time reviewin

Re: [PATCHES] doc improv: backup/restore

2004-04-21 Thread Alvaro Herrera
in 24 hours barring any complaints. I'm not sure, but seems the reference to work_mem is gone? -- Alvaro Herrera () "El sentido de las cosas no viene de las cosas, sino de las inteligencias que las aplican a sus problemas diarios en busca del progreso." (Ernesto Hernández-Novich)

[PATCHES] Remove traces of xfunc

2004-04-24 Thread Alvaro Herrera
n also be removed after this change) -- Alvaro Herrera () "Hoy es el primer día del resto de mi vida" Index: src/backend/optimizer/path/allpaths.c === RCS file: /home/alvherre/cvs/pgsql-server/src/backend/optimizer/path/allpaths.

Re: [PATCHES] Remove traces of xfunc

2004-04-24 Thread Alvaro Herrera
On Sun, Apr 25, 2004 at 12:20:01AM -0400, Neil Conway wrote: > On 24-Apr-04, at 5:58 PM, Alvaro Herrera wrote: > >While playing with the init code I noticed traces of Hellerstein's > >"expensive function optimization". It is completely disabled, uses > >functio

[PATCHES] subtransactions -- storage manager

2004-04-25 Thread Alvaro Herrera
of the phrase "nested transactions" and I'm using the term "subtransactions" instead. In my head they are the same thing ... -- Alvaro Herrera () Hi! I'm a .signature virus! cp me into your .signature file to help me spread! diff -cr --exclude-from=diff-ignore 08simple/sr

[PATCHES] nested transactions

2004-05-14 Thread Alvaro Herrera
ckend/access/transam/subtrans.c subtrans.h should go into src/include/access/subtrans.h -- Alvaro Herrera () "Investigación es lo que hago cuando no sé lo que estoy haciendo" (Wernher von Braun) ---(end of broadcast)--- TIP 3: if posting/

Re: [PATCHES] nested transactions

2004-05-14 Thread Alvaro Herrera
On Fri, May 14, 2004 at 04:41:06PM -0400, Alvaro Herrera wrote: > Hackers, > > Here is my current patch implementing nested transactions. Turns out the patch is too big and the server won't publish it. Meanwhile, Bruce has posted it as ftp://candle.pha.pa.us/pub/postgr

Re: [PATCHES] PITR Phase 1 - Full set of patches

2004-04-29 Thread Alvaro Herrera
combination of the pgsql trees I have, simultaneously. So I picked a random number as "base", and the scripts takes the sum of this number and the number at the start of tree name, and uses it as the port (--with-pgport). So I can run all servers and clients, with no conflict. If t

Re: [PATCHES] PITR Phase 1 - Full set of patches

2004-04-29 Thread Alvaro Herrera
On Thu, Apr 29, 2004 at 09:58:49PM -0400, Alvaro Herrera wrote: > Note that sometimes I do things incrementally, so I do "incremental > diffs" by commands like > cd /home/alvherre/CVS/pgsql/source > diff -cr --exclude-from=ignore-diff 01xact 02blahblah ^^^ Note th

Re: [PATCHES] subtransactions -- storage manager

2004-04-30 Thread Alvaro Herrera
On Thu, Apr 29, 2004 at 11:38:52PM +0100, Simon Riggs wrote: > On Sun, 2004-04-25 at 19:06, Alvaro Herrera wrote: > > - pg_clog/pg_subtrans. Need a solution. > As you're aware, our current work overlaps. > pg_clog doesn't seem like the place to record subtransacti

Re: [PATCHES] new aggregate functions v1

2004-05-01 Thread Alvaro Herrera
Mysql compatible functions", "Oracle compatible functions", etc. Thus the backend would be free from this stuff, and people who needs it just installs the whole package. -- Alvaro Herrera () "La realidad se compone de muchos sueños, todos ellos diferentes, per

[PATCHES] smgr cleanup

2004-05-03 Thread Alvaro Herrera
. We could argue that a hypotethical future storage manager could do something at commit/abort so the hooks are needed, but we haven't had a different storage manager for years. If there are no objections, please apply. -- Alvaro Herrera () "Pensar que el espectro que vemos es ilusorio n

Re: [PATCHES] [BUGS] BUG #1134: ALTER USER ... RENAME breaks md5

2004-04-27 Thread Alvaro Herrera
, just like HTTP digest -- they are means of hiding it on the wire, not on disk. -- Alvaro Herrera () "El miedo atento y previsor es la madre de la seguridad" (E. Burke) ---(end of broadcast)--- TIP 2: you can get off all lists at

Re: [PATCHES] Basic subtransaction facility

2004-04-27 Thread Alvaro Herrera
I wrote ten seconds ago: > This version does. This patch includes both patches I > posted and a few more changes, and does the following: I mean this one. -- Alvaro Herrera () "¿Qué importan los años? Lo que realmente importa es comprobar que a fin de cuentas la mejor edad de

Re: [PATCHES] Basic subtransaction facility

2004-04-27 Thread Alvaro Herrera
ever an bug is found inside xact.c I feel this one is ready to be applied. Tom wanted to review it, of course. Still missing: - deal with prepared statements, deferred triggers - save state in pg_clog - visibility rules -- Alvaro Herrera () "La realidad se compone de muchos sueños, todos

Re: [PATCHES] Basic subtransaction facility

2004-04-28 Thread Alvaro Herrera
e different behaviour from ereport(ERROR), at least. And I don't think the answer should be elog(FATAL) for the former. -- Alvaro Herrera () "Ni aun el genio muy grande llegaría muy lejos si tuviera que sacarlo todo de su propio interior" (Goethe) --

Re: [PATCHES] Basic subtransaction facility

2004-04-29 Thread Alvaro Herrera
e's space for PANIC though (unless we suspect shared state corruption ... is that checked for anywhere? I haven't looked.) -- Alvaro Herrera () "No single strategy is always right (Unless the boss says so)" (Larry Wall) ---(end of broadcast)---

Re: [PATCHES] Basic subtransaction facility

2004-04-29 Thread Alvaro Herrera
> ERROR. I do not see the use-case for abort-all-levels-of-xact-but- > don't-exit. Ok, I'm not wedded to the idea of a new elevel. So you think elog(ERROR) should rather be elog(FATAL) ? -- Alvaro Herrera () Y una voz del caos me habló y me dijo "Sonríe y sé feliz, podría

Re: [PATCHES] Basic subtransaction facility

2004-04-29 Thread Alvaro Herrera
, what error were you thinking of > > that should abort the outer transaction? > > Theoretically, if you abort the inner transaction, that could free up > memory for use by the outer transaction. Yes, this is planned to happen. -- Alvaro Herrera () "La tristeza es u

Re: [PATCHES] Basic subtransaction facility

2004-04-29 Thread Alvaro Herrera
On Thu, Apr 29, 2004 at 06:42:31PM +0200, Manfred Koizar wrote: > On Wed, 28 Apr 2004 12:02:44 -0400, Alvaro Herrera > <[EMAIL PROTECTED]> wrote: > >In fact, I think we should mark ERROR as aborting the whole transaction > >tree, and create a new level which w

[PATCHES] Nested xacts, try 5

2004-05-23 Thread Alvaro Herrera
nd catcache code is correct. I'm almost sure there's a bug. Hopefully not much else. -- Alvaro Herrera () Tulio: oh, para qué servirá este boton, Juan Carlos? Policarpo: No, aléjense, no toquen la consola! Juan Carlos: Lo apretaré una y otra vez. nested-all-5.patch.gz Description: Bina

[PATCHES] Nested xacts 5, updated

2004-05-26 Thread Alvaro Herrera
I attach my current patch. Please test and review. -- Alvaro Herrera () "La experiencia nos dice que el hombre peló millones de veces las patatas, pero era forzoso admitir la posibilidad de que en un caso entre millones, las patatas pelarían al hombre" (Ijon Tichy) nested-all-

Re: [PATCHES] Cancel/Kill backend functions

2004-05-27 Thread Alvaro Herrera
an happen if a backend passes the IsBackendPid() test and terminates just before the kill() signal? It should be pretty unlikely but you could signal the wrong process ... shouldn't the SInvalLock be held throughout the whole operation? -- Alvaro Herrera () "El número de instalaciones

Re: [PATCHES] Cancel/Kill backend functions

2004-05-27 Thread Alvaro Herrera
to do some I/O to get the data, and there could be multiple queries, depending on the nesting level. I could write it to save the xid's in PGPROC in a first pass, then release the SInvalLock, then look at pg_subtrans. But I think doing it this way has a ("is a?") race condition. -

Re: [PATCHES] fix oid casting inconsistency

2004-06-03 Thread Alvaro Herrera
ions might be > examining this error message string, (a) this particular error message > isn't very likely be used for that (b) we have error codes now. This kind of error message consistency enhancement has been applied liberally in the past. -- Alvaro Herrera () "If you have noth

Re: [PATCHES] eventlog fix

2004-06-03 Thread Alvaro Herrera
> /* Global variables */ > HANDLE g_hModule = NULL; /* hModule of DLL */ We don't use this hungarian notation anywhere ... it certainly looks ugly. -- Alvaro Herrera () "Y eso te lo doy firmado con mis lágrimas" (Fiebre del Loco) -

Re: [PATCHES] PITR Archival

2004-06-15 Thread Alvaro Herrera
out for use of Ctrl, Shift and Alt -- very handy. Can use CVS as well, or you can use two source trees. -- Alvaro Herrera () "There is evil in the world. There are dark, awful things. Occasionally, we get a glimpse of them. But there are dark corners; horrors almost impossible to imagine

Re: [PATCHES] Nested transactions

2004-06-16 Thread Alvaro Herrera
rced to send all the commands before the aborting one to the server again. And there's no way to "undo" a command in the transaction, short of aborting it completely. I don't know what Oracle or other DBMSs expect in this area. Anyone care to give me a few pointers? If I

Re: [PATCHES] Nested transactions

2004-06-16 Thread Alvaro Herrera
.weird. I don't think we should explicitly forbid it. I think it should be forbidden to close the outermost transaction inside a function (else the function would not be able to terminate correctly), but for levels before that one it'd be OK. -- Alvaro Herrera

Re: [PATCHES] Nested transactions

2004-06-16 Thread Alvaro Herrera
ly to the latest one. Also, in SQL2003 there can be multiple "savepoint levels". I think for a first implementation it would be fine if we had only one level. It would, wouldn't it? -- Alvaro Herrera () "Estoy de acuerdo contigo en que la verdad

[PATCHES] Some index entries

2004-06-16 Thread Alvaro Herrera
The attached patch adds some index entries pointing to the cursor reference pages. Please apply. -- Alvaro Herrera () Thou shalt study thy libraries and strive not to reinvent them without cause, that thy code may be short and readable and thy days pleasant and productive. (7th Commandment for

Re: [PATCHES] Some index entries

2004-06-17 Thread Alvaro Herrera
ty! And it's not called bookindex.html anymore, now it shows up as i66180.html. Is this normal? Thanks, -- Alvaro Herrera () "Amanece. (Ignacio Reyes) El Cerro San Cristóbal me mira, cínicamente, con ojos de virgen"

Re: [PATCHES] nested xacts and phantom Xids

2004-06-21 Thread Alvaro Herrera
On Sun, Jun 20, 2004 at 04:37:16PM -0400, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Here I present the nested transactions patch and the phantom Xids patch > > that goes with it. > > I looked at the phantom XIDs stuff a bit. I still have l

Re: [PATCHES] nested xacts and phantom Xids

2004-06-21 Thread Alvaro Herrera
On Mon, Jun 21, 2004 at 10:28:59PM -0400, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > This is tricky because chunks are prepended to the queue, but it also > > means we can stop processing as soon as a message belongs to another > > transaction.

Re: [PATCHES] nested xacts and phantom Xids

2004-06-22 Thread Alvaro Herrera
urse, regression tests pass, but this doesn't actually prove anything. -- Alvaro Herrera () "¿Que diferencia tiene para los muertos, los huérfanos, y aquellos que han perdido su hogar, si la loca destrucción ha sido realizada bajo el nombre del totalitarismo o del santo nombre de la li

Re: [PATCHES] nested xacts and phantom Xids

2004-06-23 Thread Alvaro Herrera
not sure how hard it is to change the syntax; I don't think it'd be a big deal. -- Alvaro Herrera () "La conclusión que podemos sacar de esos estudios es que no podemos sacar ninguna conclusión de ellos" (Tanenbaum) ---(end of broadcast)---

Re: [PATCHES] nested xacts and phantom Xids

2004-06-23 Thread Alvaro Herrera
cleaner. The phantom > cid would have a tuple bit set indicating that instead of being a cid, > it is an index into an array of cmin/cmax pairs. Yeah, maybe this can work. I'm not going to try however, at least not now. If somebody else wants to try, be my guest. -- Alvaro Herrera ()

Re: [PATCHES] nested xacts and phantom Xids

2004-06-24 Thread Alvaro Herrera
the performance issues raised. Comments? -- Alvaro Herrera () "No single strategy is always right (Unless the boss says so)" (Larry Wall) Index: guc.c === RCS file: /home/alvherre/cvs/pgsql-server/src/backend/utils/misc/guc.c

Re: [PATCHES] nested xacts and phantom Xids

2004-06-26 Thread Alvaro Herrera
is is really excellent news. I'll work on adding the Xid-cache to PGPROC and using that in TransactionIdIsInProgress and the tqual routines. If you want to work on that let me know and I'll handle things like the password file, local bufmgr refcount, etc. -- Alvaro Herrera () FOO MANE PADME HUM

Re: [PATCHES] nested xacts and phantom Xids

2004-06-26 Thread Alvaro Herrera
tromping on each others' feet. Oops, I forgot that I had inadvertently left a kludge in commands/trigger.c. Please use this patch for this file instead. -- Alvaro Herrera () Jude: I wish humans laid eggs Ringlord: Why would you want humans to lay eggs? Jude: So I can eat them Index: incl

Re: [PATCHES] nested xacts and phantom Xids

2004-06-26 Thread Alvaro Herrera
On Sun, Jun 27, 2004 at 12:49:10AM -0400, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > I'll work on adding the Xid-cache to PGPROC and using that in > > TransactionIdIsInProgress and the tqual routines. If you want to work > > on that let me

[PATCHES] nested xacts: update password file

2004-06-27 Thread Alvaro Herrera
t was ripped before the 7.3 release. -- Alvaro Herrera () "Some men are heterosexual, and some are bisexual, and some men don't think about sex at all... they become lawyers" (Woody Allen) Index: src/backend/commands/user.c

[PATCHES] typo in runtime.sgml

2004-06-27 Thread Alvaro Herrera
Corrects a wrong filename separation. Please apply. -- Alvaro Herrera () You liked Linux a lot when he was just the gawky kid from down the block mowing your lawn or shoveling the snow. But now that he wants to date your daughter, you're not so sure he measures up. (Larry Greenemeier) Index

Re: [PATCHES] nested xacts and phantom Xids

2004-06-29 Thread Alvaro Herrera
On Tue, Jun 29, 2004 at 03:22:52PM -0400, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > - GUC vars are rolled back on subxact abort > > This did not work very well, but here is a revised GUC patch that I think > does work. It requires xact.c to export

Re: [PATCHES] nested xacts and phantom Xids

2004-06-29 Thread Alvaro Herrera
roll back with a nonzero reference count in a local buffer? -- Alvaro Herrera () "I dream about dreams about dreams", sang the nightingale under the pale moon (Sandman) Index: src/include/storage/bufmgr.h === RCS file: /home/

Re: [PATCHES] nested xacts and phantom Xids

2004-06-29 Thread Alvaro Herrera
On Tue, Jun 29, 2004 at 06:59:20PM -0400, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > As with the bufmgr.c original patch, I don't really know how to test > > that this actually works. [...] > > I forgot to mention to you that that code didn&

Re: [PATCHES] latest plperl

2004-07-01 Thread Alvaro Herrera
s > on a configure-conditional basis -- anyone know? Can't this stuff be tested somehow using Test::Simple, Test::Harness or something like that? I know this is not standard perl stuff but ... -- Alvaro Herrera () "I call it GNU/Linux. Except the GNU/ is silent." (Ben Reiter)

[PATCHES] [subxacts] Using a different syntax

2004-07-04 Thread Alvaro Herrera
l. I also thought about adding something to the sigsetjmp() block but I don't have a clue how to handle this. Regression tests pass; I had to change the transaction test to adopt the new syntax. I also added a couple of tests to verify the new functionality. -- Alvaro Herrera () "La

[PATCHES] value.h has no VALUE_H

2004-07-10 Thread Alvaro Herrera
The outer #define was forgotten. Attached patch adds it; please apply. -- Alvaro Herrera () "Sallah, I said NO camels! That's FIVE camels; can't you count?" (Indiana Jones) Index: src/include/nodes/value.h ===

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Alvaro Herrera
On Mon, Jul 12, 2004 at 12:05:40PM -0400, Bruce Momjian wrote: > > Alvaro, you call GetParentTransactionId(), but I see not definition for > it in the code. Let me include this patch in the next patch I'll submit shortly. -- Alvaro Herrera () "I suspect most samba dev

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Alvaro Herrera
ord file with empty password fields. (This is different from an empty password.) Such entries allow you to restrict users who can access the system. These entries cannot be managed by pg_passwd, but you can edit password files manually. -- Alvaro Herrera () "La primera l

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Alvaro Herrera
ne per pg_hba.conf entry? Can I use multiple files with a single pg_hba.conf entry? What happens if I have a username that has the separator in it? -- Alvaro Herrera () "Los dioses no protegen a los insensatos. Éstos reciben protección de otros insensatos mejor dotados" (Luis

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Alvaro Herrera
On Mon, Jul 12, 2004 at 03:19:43PM -0400, Bruce Momjian wrote: > Alvaro Herrera wrote: > > On Mon, Jul 12, 2004 at 02:31:37PM -0400, Bruce Momjian wrote: > > > > > OK, but why would we document the contents of a file that are not to be > > > modified by the user?

Re: [PATCHES] initdb authentication

2004-07-15 Thread Alvaro Herrera
ba.conf and the relevant documentation. If it were my choice, I'd disallow connections by default completely, and spit a reject message along the lines of "you should have a look at pg_hba.conf". -- Alvaro Herrera () "Uno combate cuando es necesario... ¡no cuando está de humo

Re: [PATCHES] [subxacts] Savepoint syntax

2004-07-15 Thread Alvaro Herrera
On Wed, Jul 14, 2004 at 03:03:02PM -0400, Alvaro Herrera wrote: > Please test, review and apply. If anyone is able to crash the server > using this I'll be most interested. I just noticed that the "misc" regression test is generated, and so it needs to be patched ... inte

[PATCHES] [subxact] Proof-of-concept: report nest level to client

2004-07-16 Thread Alvaro Herrera
ff, so maybe it doesn't apply at all ... if this is the case I'll submit a better patch tomorrow. -- Alvaro Herrera () "No hay hombre que no aspire a la plenitud, es decir, la suma de experiencias de que un hombre es capaz" diff -u src/backend/access/transam/xact.c src/backend/a

Re: [PATCHES] [subxacts] Savepoint syntax

2004-07-26 Thread Alvaro Herrera
On Sun, Jul 25, 2004 at 04:58:01PM -0400, Alvaro Herrera wrote: > Attached is the savepoints syntax patch, hopefully last try. > Essentially the same as the last patch, with the following differences: Brown paper bag patch. Please disregard. I'll post a good patch tomorrow morning.

[PATCHES] [subxacts] Some docs

2004-07-26 Thread Alvaro Herrera
Hackers, Here is a doc patch that includes pages for savepoint commands. It would be cool if they can be applied as starting points for savepoint documentation. Poeple who can do better, please feel free to improve in any way. -- Alvaro Herrera () "Cómo ponemos nuestros dedos en la ar

Re: [HACKERS] [PATCHES] DOC: catalog.sgml

2006-09-01 Thread Alvaro Herrera
r with the catalogs it could have some use. The OIDs may be useful to people inspecting pg_depend, for example; but then, it's foolish not to be using regclass in that case. Whether a table is "bootstrap" or not doesn't seem useful to me. -- Alvaro Herrera

Re: [HACKERS] [PATCHES] Patch for UUID datatype (beta)

2006-09-19 Thread Alvaro Herrera
code > > > is too complicated to maintain, or not portable enough. > > As others have mentioned, using MAC address doesn't remove the > > possibility of a collision. > > It does, as I control the MAC address. What happens if you have two postmaster running on the sa

Re: [PATCHES] Too many messages from Autovacuum

2006-09-26 Thread Alvaro Herrera
Simon Riggs wrote: > No server settings seem appropriate to remove these... > > So, patch enclosed to change LOG -> DEBUG1 Applied, thanks. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development,

Re: [HACKERS] [PATCHES] test: please ignore

2006-10-10 Thread Alvaro Herrera
> > Did you by any chance gzip it? IIRC, mails with gzipped attachments are > > silently dropped on- patches for some reason. > > Hm? They've always worked fine for me, and for a lot of other people. > You should ask Marc to look into this. It depends on the MIME type IIRC.

Re: [PATCHES] WAL logging freezing

2006-10-24 Thread Alvaro Herrera
the same method for determining the pg_clog cutoff point. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ---(end of broadcast)--- TIP 1: if posting/reading th

Re: [PATCHES] [HACKERS] COPY does not work with regproc and aclitem

2006-10-26 Thread Alvaro Herrera
is that regproc COPY is not useful to you for your particular use case. But there are workarounds, like the one I suggested and you promptly ignored. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---

Re: [PATCHES] WAL logging freezing

2006-10-30 Thread Alvaro Herrera
ll the optimization won by the relminxid patch. > Simon volunteered to make the clog changes for 3 because it's a PITR > related issue. I can write a patch/patches for the other changes if it > helps. I'm swamped at the moment, so I'd appreciate it. -- Alvaro Herrera

Re: [HACKERS] [PATCHES] WAL logging freezing

2006-10-30 Thread Alvaro Herrera
Simon Riggs wrote: > On Mon, 2006-10-30 at 12:05 -0500, Tom Lane wrote: > > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > > Ugh. Is there another solution to this? Say, sync the buffer so that > > > the hint bits are written to disk? > > > > Yeah.

  1   2   3   4   5   6   7   8   9   >