Re: [PATCHES] pg_dump additional options for performance

2008-07-25 Thread Greg Sabino Mullane
re "before" data.) Is that a small enough corner case > to live with in order to gain implementation simplicity and robustness? I'm not comfortable with corner cases for pg_restore backwards compatibility. What exactly would happen (worse case) in that scenario? - -- Greg Sabino

Re: [PATCHES] Better formatting of functions in pg_dump

2008-06-12 Thread Greg Sabino Mullane
witching between newline-before and newline-after > styles? Please be consistent. I thought they were all "after". On second glance, they still seem all after? - -- Greg Sabino Mullane [EMAIL PROTECTED] End Point Corporation PGP Key: 0x14964AC8 200806122044 http://biglumber.com/x/web

[PATCHES] Better formatting of functions in pg_dump

2008-06-12 Thread Greg Sabino Mullane
Attached patch puts the "metadata" about a function, especially the language name, at the top of the CREATE FUNCTION statement, above the possibly long, multi-line function definition. -- Greg Sabino Mullane Index:

Re: [PATCHES] LOCK_DEBUG documentation

2008-05-27 Thread Greg Sabino Mullane
self and others in production systems for debugging purposes, and the lack of detail in that section while doing so led to the patch. The docs also has the advantage of being more available, searchable, and found via the web. - -- Greg Sabino Mullane [EMAIL PROTECTED] End Point Corporation PGP Key:

[PATCHES] LOCK_DEBUG documentation

2008-05-20 Thread Greg Sabino Mullane
Documentation patch by Kevin L. McBride explaining LOCK_DEBUG options in detail. -- Greg Sabino Mullane End Point Corporation Index: config.sgml === RCS file: /projects/cvsroot/pgsql/doc/src/sgml/config.sgml,v retrieving revision

Re: [PATCHES] Consistent \d commands in psql

2008-04-02 Thread Greg Sabino Mullane
> the second. Agreed, we should respect the search path like the other commands do. Although I wonder if a long-term idea would be to at least indicate that there are other same-named things in your path? - -- Greg Sabino Mullane [EMAIL PROTECTED] [EMAIL PROTECTED] End Point Corporation 610-

Re: [PATCHES] Friendly help for psql

2008-04-02 Thread Greg Sabino Mullane
Index: mainloop.c === RCS file: /projects/cvsroot/pgsql/src/bin/psql/mainloop.c,v retrieving revision 1.87 diff -c -r1.87 mainloop.c *** mainloop.c 1 Jan 2008 19:45:56 - 1.87 --- mainloop.c 2 Apr 2008 12:51:36 - **

Re: [PATCHES] Better default_statistics_target

2008-02-03 Thread Greg Sabino Mullane
ot; number was made without any such analysis either, and I can assure you it has caused lots of real-world problems. Going from 10 to 100 adds a small amount of planner overhead. The 99/100 change adds an order of magnitude speed difference to SELECT queries. I still cannot see that as anything

Re: [PATCHES] Friendly help for psql

2008-01-28 Thread Greg Sabino Mullane
ot;. It's simple, standard, and points you to anything else you may need or want to do. > What would be interesting would be if the _server_ could send back some > message about "Use the help facility of your client application" but it > would have to have a trailing se

Re: [PATCHES] Friendly help for psql

2008-01-21 Thread Greg Sabino Mullane
ql prompt, and sends someone else in to it, or comes back later on. Same thing: the login note is no longer available ('screen' has a small scrollback), and even if you've used it before, "backslash question mark" is, let's be honest, very obscure, unintuitive, and

Re: [PATCHES] Friendly help for psql

2008-01-20 Thread Greg Sabino Mullane
g to > ever cause conflicts with a SQL command but perhaps it's better to be > prepared), one idea would be to respond with "please execute \help > instead", and then \help would emit the verbose output. Ugh. Why make people do two steps? - -- Greg Sabino Mullane [

[PATCHES] Friendly help for psql

2008-01-20 Thread Greg Sabino Mullane
Why not run help when someone enters "help" (or "HELP ME!") on the command line? \? is hardly an easy thing to remember (and some people can't be bothered to actually read the screen...) ? NOTES ? README ? SUBMIT ? backslash_consistency.patch ? ddproblem.sql ? dfs.20071104 ? pop ? psql ? scrap ? t

Re: [PATCHES] Better default_statistics_target

2007-12-05 Thread Greg Sabino Mullane
0, throw a big warning in the release notes, and then start some serious re-evaluation for 8.4? - -- Greg Sabino Mullane [EMAIL PROTECTED] End Point Corporation PGP Key: 0x14964AC8 200712050920 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B90

Re: [PATCHES] Re: [HACKERS] [GENERAL] plperl and regexps with accented characters - incompatible?

2007-12-01 Thread Greg Sabino Mullane
d our energy is better spent improving Pl/Perl itself at this point rather than tweaking things for old versions of Perl. I don't even think I have a pre 5.8 version around anymore. Would such a requirement cause any problems with packagers? I imagine a perl 5.8 prereq is a common thing

Re: [PATCHES] Proposed patch for operator lookup caching

2007-11-27 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 > Since Simon seems intent on hacking something in there, here is a patch > that I think is actually sane for improving operator lookup speed. +1 on the patch (reviewed and tested), and +1 for rolling it into RC. - -- Greg Sabino M

[PATCHES] Better default_statistics_target

2007-11-13 Thread Greg Sabino Mullane
Per a recent bug in which the planner can behave very differently at < 100, and accounting for the fact that analyze is still plenty fast on today's systems even at a tenfold increase, attached is a patch to change default_statistics_target from 10 to 100. Index: doc/src/sgml/config.sgml =

[PATCHES] Consistent \d commands in psql

2007-11-04 Thread Greg Sabino Mullane
on the vine, despite strong support from -general, hence I'm going to try again, as I really want a way to view my functions without querying the pg_proc tables directly. :) -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200711042003 http://biglumber.com/x/web?pk=2529DF6AB8F79407

[PATCHES] Better psql tab-completion support for schemas and tables

2007-10-21 Thread Greg Sabino Mullane
quot;foo" where select * from "Uppercase".lower where select * from "gtsm.com"."foo.Bar" where select * from "GTSM.com".foo where Also applies to other places that get lists of columns: insert into, alter table, create index, etc. -- Greg Sabino Mul

[PATCHES] Better psql tab-completion support for schemas and tables

2007-10-21 Thread Greg Sabino Mullane
ot;Uppercase".lower where select * from "gtsm.com"."foo.Bar" where select * from "GTSM.com".foo where Also applies to other places that get lists of columns: insert into, alter table, create index, etc. -- Greg Sabino Mullane [EMAIL PROTECTED] PG

[PATCHES] Have \da in psql show return type

2007-03-14 Thread Greg Sabino Mullane
Using \da in psql should show the return type. Index: doc/src/sgml/ref/psql-ref.sgml === RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/psql-ref.sgml,v retrieving revision 1.188 diff -c -r1.188 psql-ref.sgml *** doc/src/sgml/ref/

[PATCHES] Warning about LISTEN names

2007-02-20 Thread Greg Sabino Mullane
I'll save the full rant for my blog :), but wanted to submit this documentation patch for this listen gotcha that's been bugging me for a while. I'd like to see LISTEN and NOTIFY changed to use a simple text string, but until then, I think we should probably warn about the chopping off of the l

Re: [HACKERS] [pgsql-patches] pg_dump pretty_print

2007-01-30 Thread Greg Sabino Mullane
oday via psql so it seems like this should be a high priority. Plus of course I'd like to see it added to pg_dump once Peter, yourself, and others have more confidence in it working as one would expect. - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200701301509 http://biglum

Re: [pgsql-patches] pg_dump pretty_print

2007-01-26 Thread Greg Sabino Mullane
al flag. - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200701251003 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 -BEGIN PGP SIGNATURE- iD8DBQFFuXd2vJuQZxSWSsgRA9VDAJ9S1b+4DJomO3Bmij4wvida9wtgfgCeID16 qeoNrrehtTGIeJeL8T+mx9M= =VecV ---

Re: [pgsql-patches] pg_dump pretty_print

2007-01-22 Thread Greg Sabino Mullane
some concessions as far as making the dump file human-readable, offering this as an *optional* flag seems (mostly) harmless. - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200701221450 http://biglumber.com/x/web?pk=2529DF6AB8F7

[pgsql-patches] pg_dump pretty_print

2007-01-19 Thread Greg Sabino Mullane
Atached is a patch to allow pretty printing of system objects (constraints, indexes, rules, and views) when doing a pg_dump via a --pretty-print flag along with a warning in the docs to be careful about doing so :) -- Greg Sabino Mullane [EMAIL PROTECTED] [EMAIL PROTECTED] End Point Corporation

[PATCHES] Add pg_shdescription to the reindex docs

2007-01-04 Thread Greg Sabino Mullane
Adds the new pg_shdescription to the list of shared system catalogs on the reindex page. Index: doc/src/sgml/ref/reindex.sgml === RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/reindex.sgml,v retrieving revision 1.34 diff -c -r1.3

Re: [PATCHES] Information schema - finalize key_column_usage

2006-09-04 Thread Greg Sabino Mullane
> Please fix and resubmit soon. Attached version should now work properly. -- Greg Sabino Mullane [EMAIL PROTECTED] End Point Corporation PGP Key: 0x14964AC8 200609041803 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 Index: information_schema.

[PATCHES] Intervals within information_schema

2006-08-24 Thread Greg Sabino Mullane
tch), so I pulled those apart (for one view). Does anyone know what is supposed to go into the interval_type field? Thanks, -- Greg Sabino Mullane [EMAIL PROTECTED] End Point Corporation PGP Key: 0x14964AC8 200608241454 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964

Re: [PATCHES] Information_schema fixes for sequences and temporary tables

2006-08-18 Thread Greg Sabino Mullane
or all that ESCAPE junk, consider using regexps instead; they > play nicer with underscores in patterns. Hmph. I was just copying the surrounding code, in the theory that it increases the chance of my patches being accepted. :) - -- Greg Sabino Mullane [EMAIL PROTECTED] End Point Cor

[PATCHES] Information schema - finalize key_column_usage

2006-08-18 Thread Greg Sabino Mullane
Correctly populates the "position_in_unique_constraint" column in the information_schema.key_column_usage view. -- Greg Sabino Mullane [EMAIL PROTECTED] End Point Corporation PGP Key: 0x14964AC8 200608182231 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964

[PATCHES] Information_schema fixes for sequences and temporary tables

2006-08-18 Thread Greg Sabino Mullane
More to come, but these two are probably worth backpatching. Sequences were not being shown due to the use of lowercase 's' instead of 'S', and the views were not checking for table visibility with regards to temporary tables and sequences. -- Greg Sabino Mullane [EMAIL

[PATCHES] Fix statement timing display

2006-08-09 Thread Greg Sabino Mullane
The statement timing was showing "seconds.milliseconds ms" instead of "milliseconds.milliseconds ms". Attached patch should fix it up. -- Greg Sabino Mullane [EMAIL PROTECTED] [EMAIL PROTECTED] End Point Corporation PGP Key: 0x14964AC8 200608091553 http://bi

[PATCHES] New variable server_version_num

2006-07-29 Thread Greg Sabino Mullane
provide a new variable "server_version_num", which is almost the same as "server_version" but uses the handy PG_VERSION_NUM which allows apps to do things like if ($version >= 80200) without having to parse apart the value of server_version themselves. -- Greg Sabino Mullane [EMA

[PATCHES] pg_dump: multiple tables, schemas with exclusions and wildcards

2006-07-16 Thread Greg Sabino Mullane
may still need some more explaining. It should be nearly 100% backwards compatible with any existing scripts that use a single -t as well. -- Greg Sabino Mullane [EMAIL PROTECTED] End Point Corporation PGP Key: 0x14964AC8 200607162215 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B9067

Re: [PATCHES] plperl - put schema-name in $_TD

2006-05-25 Thread Greg Sabino Mullane
lschema to all > (mutatis mutandis w.r.t. names). +1 for table_schema and table_name, especially if in the future we provide things like trigger_schema. - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200605251203 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC

Re: [PATCHES] New pg_dump options: exclude tables/schemas, multiple

2006-03-02 Thread Greg Sabino Mullane
ing. *Hopefully* finished this weekend. I'll even do some work on it tonight... - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200603021936 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 -BEGIN PGP SIGNATURE- iD8DBQFEB4+fvJuQZxSWSsgRAtaCAJ

Re: [PATCHES] Patch to readme

2006-02-07 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > Perl - http://www.cpan.org Could someone please change this to: Perl - http://search.cpan.org/~dbdpg/ Thanks! - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200602071000 http://biglumber.com/x/web

Re: [PATCHES] New pg_dump options: exclude tables/schemas, multiple

2006-02-01 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > Where are we on this patch? Should we add code to do regex calls > to the backend using '~'. Yes - I am planning to submit a new patch when I get a few spare cycles. Hopefully no more than a few days from now. - -- Greg Sabin

Re: [PATCHES] New pg_dump options: exclude tables/schemas, multiple all, wildcards

2006-01-17 Thread Greg Sabino Mullane
ains regular expressions. Plus, while the underscore is common in namespace names, a period is not. - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200601172005 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 -BEGIN PGP SIGNATURE- iD8DBQ

Re: [PATCHES] New pg_dump options: exclude tables/schemas, multiple all, wildcards

2006-01-17 Thread Greg Sabino Mullane
ion one. Which probably means more arguments or at least modifying the existing one in a possibly nonintuitive, and definitely more complex, manner. I'm open to suggestions, however, but I don't want to make things too byzantine for the users. - -- Greg Sabino Mullane [

[PATCHES] New pg_dump options: exclude tables/schemas, multiple all, wildcards

2006-01-15 Thread Greg Sabino Mullane
Some examples: To dump all tables beginning with the string "slony", plus all tables with the word "log" inside of them: pg_dump -t "slony*" -t "*log*" To dump all schemas except "dev" and "qa", and all tables except those ending in

Re: [PATCHES] Another small pl/perl patch

2005-10-24 Thread Greg Sabino Mullane
-) ) I tried to match the indenting to what is already in the docs, which is fairly close to my own style. - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200510241105 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8

[PATCHES] Another small pl/perl patch

2005-10-23 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Another quick little patch to clean up the docs. If we are going to provide examples of perl code, no matter how trivial, we might as well provide well-written perl code. :) - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8

Re: [PATCHES] suggested warning about perl nested named subroutines

2005-10-23 Thread Greg Sabino Mullane
't need to change it and break backwards-compatibilty, but we could easily add in a synonym and deprecate spi_*. I prefer sql() or exec(), although the latter is a little to close to "EXECUTE". Maybe do() in the spirit of DBI (although it returns result sets, so that could be potentia

Re: [PATCHES] Small plperl documentation patch

2005-10-18 Thread Greg Sabino Mullane
lared variables. So, the danger is very minor, but it's a good practice to not use them for temporary variables in a script. - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200510182220 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B90

[PATCHES] Small plperl documentation patch

2005-10-18 Thread Greg Sabino Mullane
if (! defined $x) { > if (! defined $y) { return undef; } > return $y; 126,128c126,128 < if (! defined $b) { return $a; } < if ($a > $b) { return $a; } < return $b; --- > if (! defined $y) { return $x; } > if ($x > $y) { return $x; } > ret

Re: [PATCHES] suggested warning about perl nested named subroutines

2005-10-12 Thread Greg Sabino Mullane
noyance, while I'm here: what's with "spi_exec_query()"? Is that the best name we could come up with? How about something short and simple, in the same vein as "elog()", such as "sql()" ? :) - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964

[PATCHES] psql \x bug

2005-09-16 Thread Greg Sabino Mullane
; \x Expanded display is on. pgtest> SELECT * FROM pg_class LIMIT 2; (messy output) -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200509161020 https://www.biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8

Re: [PATCHES] [BUGS] PSQL commands not backwards-compatible

2005-08-31 Thread Greg Sabino Mullane
in a scenario with several versions on the same > machine of both client and server (hosting scenario, I'd imagine), that > would certainly help. This all seems so familiar somehow... :) http://archives.postgresql.org/pgsql-patches/2001-11/msg00184.php - -- Greg Sabino Mullane

Re: [PATCHES] PL/Perl embedding string common elements

2005-08-21 Thread Greg Sabino Mullane
7; (and perhaps some other pragma) without going through more contortions? I can't imagine enabling it would in any way make it more "untrusted". On the other hand, if 'use strict' was enabled for plperl, I might never have discovered the bug at the start of this thread. :)

[PATCHES] Column-level triggers

2005-07-04 Thread Greg Sabino Mullane
do what I wanted it to; that much, at least, finally works. This was a nice crash course in PG internals: no doubt there are better ways to do a lot of what I have done, so suggestions and corections welcome. - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200507041355 http://biglu

Re: [PATCHES] Quick little \h enhancement for psql

2005-06-17 Thread Greg Sabino Mullane
see it added, but willing to discuss/rewrite if not acceptable. Thanks, - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200506171234 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 -BEGIN PGP SIGNATURE- iD8DBQFCsvxevJuQZxSWSsgRAhwTAJ0bv/OrJ+7uXJvjI8

Re: [PATCHES] psql backslash consistency

2005-05-30 Thread Greg Sabino Mullane
f you have your functions in other schemas). - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200505280549 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 -BEGIN PGP SIGNATURE- iD8DBQFCmD+3vJuQZxSWSsgRAreqAKC/EekFZeLA1zGzo0LgDXSbTKRNuwCgsCWH jLLj4ySNl

[PATCHES] psql backslash consistency

2005-05-26 Thread Greg Sabino Mullane
fix psql so that \di [tab] only lists schemas that actually contain possible indexes (or indexes), rather than the current behavior which is to just list all schemas. - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200505261242 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B

[PATCHES] Bunch of tab-completion enhancements for psql

2005-05-16 Thread Greg Sabino Mullane
* Fix error in which REVOKE xx ON yy was receiving "TO", now gets "FROM" * Add GRANT/REVOKE xx ON yy TO/FROM choices: usernames, GROUP, PUBLIC * PREPARE xx AS "SELECT | INSERT | UPDATE | DELETE" * Add = at end of UPDATE xx SET yy * Beef up VACUUM stuff - -- Greg

[PATCHES] Quick little \h enhancement for psql

2005-05-16 Thread Greg Sabino Mullane
that fails, it tries to match the first word (e.g. "DELETE"). - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 20

Re: [HACKERS] [PATCHES] Continue transactions after errors in psql

2005-04-27 Thread Greg Sabino Mullane
each. Rather than worrying about collisions, I could simply \rollbackonerror (or whatever we're calling it today :) and silently discard the handful that happen to violate the primary key constraint and let the rest insert. - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 2005

Re: [HACKERS] [PATCHES] Continue transactions after errors in psql

2005-04-26 Thread Greg Sabino Mullane
This setting defaults to "off" and must be explicitly enabled. I'd be okay with a "smart" mode that explicitly enables the interactive/non-interactive split. - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200504260737 http://biglumber.com/x/web?pk=2529D

Re: [PATCHES] Remove unneeded left joins from psql

2005-04-12 Thread Greg Sabino Mullane
catalog interrelationships, it is possible for system bugs or > manual intervention to create non-matching situations. Yes, you are right about this: we should fail in a way that puts a null schema rather than not matching at all. Must get more sleep before blindly patching next time. :) -

[PATCHES] Remove unneeded left joins from psql

2005-04-11 Thread Greg Sabino Mullane
om psql. Done in the theory that we often point people to psql -E, so our queries there should be as correct as possible: if the joining column is not null, then we don't need a left join. - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200504112254 http

[PATCHES] Not to to confusing

2005-04-11 Thread Greg Sabino Mullane
was a "TO" - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200504112303 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 Index: tab-complete.c === RCS file: /projects/cvsroot/pgsql/src/bin/p

[PATCHES] Have psql \dD show checks

2005-04-03 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Patch to show check information when listing domains via \dD in psql. Per question by Edmund Bacon on the pgsql-general list. - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200504030911 http://biglumber.com/x/web?pk

Re: [PATCHES] Continue transactions after errors in psql

2005-03-13 Thread Greg Sabino Mullane
oll it back. The only other option I can see to my patch is to, upon a successful user savepoint creation, roll back their savepoint and immediately reissue it. That seems worse to me than having N*2 savepoints though. - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200

Re: [PATCHES] Continue transactions after errors in psql

2005-03-07 Thread Greg Sabino Mullane
ack or release, of course, in which case they also remove an equal number of our savepoints as their savepoints. So it doubles the number of savepoints a user currently has, but this is the price we pay for having the feature. - -- Greg Sabino Mullane [EMAIL PROTECTED] PG

Re: [PATCHES] Continue transactions after errors in psql

2005-03-06 Thread Greg Sabino Mullane
this patch: http://www.gtsm.com/pg/psql_error_recovery.diff - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200503060152 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 -BEGIN PGP SIGNATURE- iD8DBQFCKqjXvJuQZxSWSsgRArIsAJ9wR99qOOCrfS8Hly7xNnWHV/

Re: [PATCHES] New FAQ questions. minor fixes

2005-02-24 Thread Greg Sabino Mullane
" > > Any ideas on how that can be improved? Not off the top of my head, but I will play around with it. Worse comes to worse, we can manually clean it up or make a quick perl script to clean up after lynx. - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8

[PATCHES] New FAQ questions. minor fixes

2005-02-23 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Added a new question about sorting with a NULL. Also some minor cleanups, especially in regards to some of the http links: is some automatic tool messing these up somehow? (many had spaces and odd breaks in the middle) - -- Greg Sabino Mullane

Re: [PATCHES] Continue transactions after errors in psql

2005-02-01 Thread Greg Sabino Mullane
of savepoint names in order, allowing one to easily grab the whole list or just the "latest/current" one. - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200502012248 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 -BEGIN PGP SIGNATURE-

Re: [PATCHES] Continue transactions after errors in psql

2005-01-28 Thread Greg Sabino Mullane
h a message) if you issue your own. Plus there will be a warning in the docs to be careful about mixing savepoints and the \reseterror method. * We could also switch it back on after rollback or release, but this would entail a little more tracking. Comments? - -- Greg Sabino Mullane

[PATCHES] Continue transactions after errors in psql

2005-01-25 Thread Greg Sabino Mullane
psql session, and end up cursing as we have to restart our current transaction. :) - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200501252203 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 -BEGIN PGP SIGNATURE- iD8DBQFB9wlpvJuQZxSWSsgRAsAzAKCxQ

Re: [PATCHES] Allow pooled connections to list all prepared queries

2005-01-02 Thread Greg Sabino Mullane
has already been prepared. That, however, is something application writers should not have to worry about, which is why DBI and DBD::Pg will do all the creation, naming, tracking, and deletion of prepared statements for you behind the scenes. - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key

Re: [PATCHES] psql tab-completion improvements

2004-09-09 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > Is this for 8.0? Seems it is fixes? Well, there are no new features in it anyway. My vote is for 8.0, if only so that any bugs get found quicker and fixed for 8.1 :) - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200409092

[PATCHES] Change "recycled transaction log" from LOG to DEBUG1

2004-09-05 Thread Greg Sabino Mullane
DEBUG1, (errmsg("recycled transaction log file \"%s\"", xlde->d_name))); } -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200409051137 -BEGIN PGP SIGNATURE- iD8DBQFBOzNBvJuQZxSWSsgRApOvAKCPoVcSR29wft9RIxk4bi3R5SkahQCg0yKr ISROl8QXPuh8g1

[PATCHES] Minor psql consistency fixes

2004-09-05 Thread Greg Sabino Mullane
pg_largeobject') as \"%s\"\n" !"FROM (SELECT DISTINCT loid FROM pg_catalog.pg_largeobject) x\n" !"ORDER BY \"ID\"", gettext("Description")); res = PSQLexec(buf,

[PATCHES] Typo in initdb.c

2004-09-02 Thread Greg Sabino Mullane
src/bin/initdb/initdb.c =~ s/authenication/authentication/ ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]

[PATCHES] psql tab-completion improvements

2004-08-31 Thread Greg Sabino Mullane
vent ALTER INDEX xxx SET TABLESPACE from using "TO" * Support for ALTER LANGUAGE xxx (RENAME TO) * More support for ALTER TABLE xxx ALTER COLUMN xxx ... * More support for COPY -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 20040831

[PATCHES] Typo in tab-complete.c

2004-08-31 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Little typo I came across: src/bin/psql/tab-complete.c =~ s/CONVERSATION/CONVERSION/; - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200408311915 -BEGIN PGP SIGNATURE- iD8DBQFBNQa8vJuQZxSWSsgRAtXPAJ4pLYRMPYY3kWh89X

[PATCHES] Show full path name when saving in psql

2004-08-27 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 NotDashEscaped: You need GnuPG to verify this message This patch shows the full path name when doing a \s in psql, if you have previously issued a \cd command. -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200408271849 Index

Re: [PATCHES] Allow psql to work against non-tablespace servers (e.g.

2004-08-17 Thread Greg Sabino Mullane
sed interest in the past as far making psql backwards-compatible, and I think the code can be kept fairly clean. At least we are guaranteed to compile against current libraries - apps outside the source tree never get that luxury and have worse compatibility problems. :) - -- Greg Sabino Mullane [

Re: [PATCHES] Allow psql to work against non-tablespace servers (e.g.

2004-08-17 Thread Greg Sabino Mullane
this patch and I would rather they get evaluated separately. - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200408172006 -BEGIN PGP SIGNATURE- iD8DBQFBIp3IvJuQZxSWSsgRAuABAJ0Yzhl7neFUsufTSBRPCw4FtgFHmwCfRF7C 3y+2SRPeIbt5ZAhmSQgHogc= =t52z

[PATCHES] Replace incorrect example for quote_ident

2004-08-12 Thread Greg Sabino Mullane
Index: func.sgml === RCS file: /projects/cvsroot/pgsql-server/doc/src/sgml/func.sgml,v retrieving revision 1.217 diff -c -r1.217 func.sgml *** func.sgml 10 Aug 2004 00:55:03 - 1.217 --- func.sgml 12 Aug 2004 18:37:20 -000

[PATCHES] Allow psql to work against non-tablespace servers (e.g. 7.4)

2004-08-11 Thread Greg Sabino Mullane
Index: describe.c === RCS file: /projects/cvsroot/pgsql-server/src/bin/psql/describe.c,v retrieving revision 1.103 diff -c -r1.103 describe.c *** describe.c 15 Jul 2004 03:56:06 - 1.103 --- describe.c 11 Aug 2004 21:15:34 -

Re: [PATCHES] PQserverVersion

2004-08-11 Thread Greg Sabino Mullane
s/sever/server/ ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])

[PATCHES] PQserverVersion

2004-08-10 Thread Greg Sabino Mullane
Index: doc/src/sgml/libpq.sgml === RCS file: /projects/cvsroot/pgsql-server/doc/src/sgml/libpq.sgml,v retrieving revision 1.157 diff -c -r1.157 libpq.sgml *** doc/src/sgml/libpq.sgml 8 Jun 2004 13:49:22 - 1.157 --- doc/s

Re: [PATCHES] Make psql version aware; hide tablespace from older versions

2004-08-09 Thread Greg Sabino Mullane
e sversion variable? - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200408091920 -BEGIN PGP SIGNATURE- iD8DBQFBGAbcvJuQZxSWSsgRAuuWAKDsWC2M2MqzXZV6Kx8ZQ+MnuosbUwCgukUt NsXS8qGfUHNujPz8J2XsDqU= =PsJs -END PGP SIGNATURE- -

[PATCHES] Small addition to syslogger.c

2004-08-09 Thread Greg Sabino Mullane
Index: syslogger.c === RCS file: /projects/cvsroot/pgsql-server/src/backend/postmaster/syslogger.c,v retrieving revision 1.4 diff -c -r1.4 syslogger.c *** syslogger.c 6 Aug 2004 19:17:31 - 1.4 --- syslogger.c 9 Aug 2004 19:5

Re: [PATCHES] Make psql version aware; hide tablespace from older versions

2004-08-07 Thread Greg Sabino Mullane
SQL, the number could be smaller and easier to handle, of course, but better safe than sorry. - -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200408072054 -BEGIN PGP SIGNATURE- iD8DBQFBFXrbvJuQZxSWSsgRAhoFAKCAafstQcBMIuDR15tRk/a8Hih29gCgx

[PATCHES] Make psql version aware; hide tablespace from older versions

2004-08-07 Thread Greg Sabino Mullane
Index: describe.c === RCS file: /projects/cvsroot/pgsql-server/src/bin/psql/describe.c,v retrieving revision 1.103 diff -c -r1.103 describe.c *** describe.c 15 Jul 2004 03:56:06 - 1.103 --- describe.c 7 Aug 2004 22:15:03 -0

[PATCHES] Allow semicolons in psql \h strings

2004-08-04 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 NotDashEscaped: You need GnuPG to verify this message A minor itch I finally got around to scratching: allow semicolons at the end of help topics (also bump copyright years (should really be done for all files)) -- Greg Sabino Mullane [EMAIL

Re: [PATCHES] Remove confusing commented-defaullts from postgresql.conf

2004-07-13 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > No reason Greg can't do it if he wants to ... but the .sample file > itself is certainly not all that needs changing. No problem. I didn't expect the patch to pass as is, just wanted to get my foot in the door. :) - -- Gre

[PATCHES] Remove confusing commented-defaullts from postgresql.conf

2004-07-12 Thread Greg Sabino Mullane
bad thing, which caused confusion among even seasoned pg people. Thus, the patch below which simply removes the starting '#' from all settings. Forgive the lack of -c to the diff: I figured saving space was more important as the context is not needed in this case. -- Greg Sabino Mull

[PATCHES] Minor pager corrections in print.c and help.c (psql)

2003-06-27 Thread Greg Sabino Mullane
es95, formerly known as Postgres, which\n" "contains the following notice:\n\n" !"Portions Copyright(c) 1994, Regents of the University of California\n\n" "Permission to use, copy, modify, and distribute this software and its\n&q

[PATCHES] Minor PQclean additions in psql

2003-06-27 Thread Greg Sabino Mullane
foreignkey_count = PQntuples(result5); } -- Greg Sabino Mullane [EMAIL PROTECTED] PGP Key: 0x14964AC8 200306271147 -BEGIN PGP SIGNATURE- Comment: http://www.turnstep.com/pgp.html iD8DBQE+/GeYvJuQZxSWSsgRAtcIAJ92mG2uOQQG22kqn0CFuwb66ecn0wCfUvxF imu

[PATCHES] Consistent timestamp input

2003-06-23 Thread Greg Sabino Mullane
a two digit year: DD-MM-YY */ ! else if ((fmask & DTK_M(DAY)) && (fmask & DTK_M(MONTH))) ! { ! *tmask = DTK_M(YEAR); ! tm->tm_year = val; ! *is2digits = TRUE; ! } !