Re: [PATCHES] pg_postmaster_reload_time() patch

2008-04-29 Thread Gurjeet Singh
On Wed, Apr 30, 2008 at 9:53 AM, George Gensure <[EMAIL PROTECTED]> wrote: > I've done a quick write up for reload time reporting from the > administration TODO. I was a little paranoid with the locking, but > didn't want problems to occur with signals on the postmaster and the > read side. > > I

Re: [PATCHES] [HACKERS] [Fwd: Index Advisor]

2007-04-12 Thread Gurjeet Singh
On 4/12/07, Bruce Momjian <[EMAIL PROTECTED]> wrote: Gurjeet Singh wrote: > The interface etc. may not be beautiful, but it isn't ugly either! It is > a lot better than manually creating pg_index records and inserting them into > cache; we use index_create() API to cre

Re: [PATCHES] [HACKERS] [Fwd: Index Advisor]

2007-04-10 Thread Gurjeet Singh
the resulting cost!!! Best regards, -- [EMAIL PROTECTED] [EMAIL PROTECTED] gmail | hotmail | yahoo }.com 17°29'34.37"N 78°30'59.76"E - Hyderabad 18°32'57.25"N 73°56'25.42"E - Pune * On 4/6/07, Tom Lane <[EMAIL PROTECTED]> wrote: "Gurjeet Sin

Re: [PATCHES] \prompt for psql

2007-02-09 Thread Gurjeet Singh
On 2/9/07, Alvaro Herrera <[EMAIL PROTECTED]> wrote: At least it'd help those poor people trying to do conditional COMMIT or ROLLBACK based on the transaction status. The user doesn't need to check the status of the transaction if he just needs to end it. Just fire the END command and it'll t

Re: [PATCHES] \prompt for psql

2007-02-08 Thread Gurjeet Singh
On 2/8/07, Chad Wagner <[EMAIL PROTECTED]> wrote: This adds the ability to "prompt" for internal variable input, below are examples: In help.c:slashUsage(), the comment says: /* if you add/remove a line here, change the row count above */ So I guess, the patch should also include a chang

Re: [pgsql-patches] [PATCHES] [HACKERS] [Fwd: Index Advisor]

2007-01-19 Thread Gurjeet Singh
On 1/20/07, Bruce Momjian <[EMAIL PROTECTED]> wrote: I can't read a 7z file on my end. Please email me the file and I will put it at a URL. ------- Gurjeet Singh wrote: > Please find attached the patches por

Re: [pgsql-patches] [PATCHES] [HACKERS] [Fwd: Index Advisor]

2007-01-16 Thread Gurjeet Singh
On 1/15/07, Andrew Dunstan <[EMAIL PROTECTED]> wrote: Gurjeet Singh wrote: > > 1) pg_post_planner_plugin-REL8_2_STABLE-v1.patch.gz > 2) pg_index_adviser-REL8_2_STABLE-v26.patch.gz > Why are these patches against 8.2 rather than CVS HEAD? Is this not a new feature? We

Re: [pgsql-patches] [PATCHES] [HACKERS] [Fwd: Index Advisor]

2007-01-15 Thread Gurjeet Singh
> Please find attached two patches: > > 1) pg_post_planner_plugin-REL8_2_STABLE-v1.patch.gz > 2) pg_index_adviser-REL8_2_STABLE-v26.patch.gz > Why are these patches against 8.2 rather than CVS HEAD? Is this not a new feature? We never backport new features to the stable branches

Re: [pgsql-patches] [PATCHES] [HACKERS] [Fwd: Index Advisor]

2007-01-15 Thread Gurjeet Singh
** This is the second installment of the Index Adviser patch. It contains the item number (2) mentioned below. On 1/13/07, Gurjeet Singh < [EMAIL PROTECTED]> wrote: Hi All, Please find attached two patches: 1) pg_post_planner_plugin-REL8_2_STABLE-v1.patch.gz 2) pg_index_adviser-REL8_

Re: [pgsql-patches] [PATCHES] [HACKERS] [Fwd: Index Advisor]

2007-01-14 Thread Gurjeet Singh
It seems the size restriction has blocked my previous attempt. Please find the first patch attached, and the second one will be in the next mail. Best Regards, -- [EMAIL PROTECTED] [EMAIL PROTECTED] gmail | hotmail | yahoo }.com On 1/13/07, Gurjeet Singh <[EMAIL PROTECTED]> wrote: On

Re: [PATCHES] [HACKERS] [Fwd: Index Advisor]

2007-01-09 Thread Gurjeet Singh
On 1/9/07, Gurjeet Singh <[EMAIL PROTECTED]> wrote: I have another idea for making the hooks a bit more cleaner; I will try that and run it through you guys later today. Please find attached the latest version of the patch. It applies cleanly on REL8_2_STABLE. The following restri

Re: [PATCHES] A patch to pg_regress for Windows port

2007-01-05 Thread Gurjeet Singh
On 1/6/07, Tom Lane <[EMAIL PROTECTED]> wrote: "Gurjeet Singh" <[EMAIL PROTECTED]> writes: > This patch removes double-quotes from around the listen_addresses=%s part; I > couldn't find a way of doing that. But then, the questions is, can the %s > (hostna

Re: [PATCHES] A patch to pg_regress for Windows port

2007-01-05 Thread Gurjeet Singh
cool... On 1/6/07, Magnus Hagander <[EMAIL PROTECTED]> wrote: Gurjeet Singh wrote: > On Windows, if logged in as an Administrator, 'make check' fails with > our standard error, saying: > > > Execution of PostgreSQL by a user with administrative permissions i

Re: [PATCHES] A patch to pg_regress for Windows port

2007-01-05 Thread Gurjeet Singh
This patch removes double-quotes from around the listen_addresses=%s part; I couldn't find a way of doing that. But then, the questions is, can the %s (hostname) have spaces embedded in it? -- [EMAIL PROTECTED] [EMAIL PROTECTED] gmail | hotmail | yahoo }.com On 1/6/07, Gurjeet Singh &l

[PATCHES] A patch to pg_regress for Windows port

2007-01-05 Thread Gurjeet Singh
On Windows, if logged in as an Administrator, 'make check' fails with our standard error, saying: Execution of PostgreSQL by a user with administrative permissions is not permitted. The server must be started under an unprivileged user ID to prevent possible system security compromises. See the

Re: [PATCHES] [HACKERS] [Fwd: Index Advisor]

2007-01-04 Thread Gurjeet Singh
Hi All, Please find attached the latest version of the patch attached. It is based on REL8_2_STABLE. It includes a few bug fixes and an improvement to the size estimation function. It also includes a work-around to circumvent the problem we were facing earlier in xact.c; it now fakes itself

Re: [PATCHES] [HACKERS] BEGIN inside transaction should be an error

2006-05-26 Thread Gurjeet Singh
On 5/26/06, Andrew Dunstan <[EMAIL PROTECTED]> wrote: Please read the developers FAQ: http://www.postgresql.org/docs/faqs.FAQ_DEV.html For the most part, patches are probably best generated relative to the root directory of your CVS checkout. cheers andrew Gurjeet Singh wrote: >

Re: [PATCHES] [HACKERS] BEGIN inside transaction should be an error

2006-05-26 Thread Gurjeet Singh
On 5/26/06, Alvaro Herrera <[EMAIL PROTECTED]> wrote: Gurjeet Singh wrote: >I wish to > know the standard procedure (command) to generate a patch; and from > which level in the source directory should I execute it? The toplevel directory. The command is cvs -q diff -cp If

Re: [PATCHES] [HACKERS] BEGIN inside transaction should be an error

2006-05-26 Thread Gurjeet Singh
I have made the changes to implement this TODO item. I wish to know the standard procedure (command) to generate a patch; and from which level in the source directory should I execute it? On 5/18/06, Bruce Momjian wrote: Added to TODO: * Add a GUC to control whether BEGIN inside a