Tom Lane escribió:
Alvaro Herrera [EMAIL PROTECTED] writes:
Brendan Jurd escribi�:
Here's my attempt to remove the typename field from A_Const. There
were a few places (notably flatten_set_variable_args() in guc.c, and
typenameTypeMod() in parse_type.c) where the code expected to see an
Alvaro Herrera [EMAIL PROTECTED] writes:
Tom Lane escribió:
They're logically different things, and after I get done putting a parse
location field into A_Const, they'll still be physically different too.
Aha. Are you working from Brendan's patch? I was going to commit it.
Sure, go ahead.
Tom Lane escribió:
Alvaro Herrera [EMAIL PROTECTED] writes:
Tom Lane escribió:
They're logically different things, and after I get done putting a parse
location field into A_Const, they'll still be physically different too.
Aha. Are you working from Brendan's patch? I was going to
Alvaro Herrera escribió:
Tom Lane escribió:
Alvaro Herrera [EMAIL PROTECTED] writes:
Tom Lane escribió:
They're logically different things, and after I get done putting a parse
location field into A_Const, they'll still be physically different too.
Aha. Are you working from
Alvaro Herrera [EMAIL PROTECTED] writes:
I came up with the attached patch.
I wasn't envisioning anything anywhere near this invasive. We only
need locations on constants in a few contexts, I think.
BTW, you broke _equalAConst() ... it was a bad idea anyway to recast
it on the assumption that
Tom Lane escribió:
Alvaro Herrera [EMAIL PROTECTED] writes:
I came up with the attached patch.
I wasn't envisioning anything anywhere near this invasive. We only
need locations on constants in a few contexts, I think.
Aha. OK, I'll commit the original patch and let you deal with the rest
Alvaro Herrera [EMAIL PROTECTED] writes:
Hmm, I'm now wondering if the location should be added to Value as well,
so that it can be passed down to Const?
Just for the record, we don't want it in Const. Parse locations are
only useful in the raw grammar output, mainly because they aren't
