Re: [PATCHES] log_line_info

2004-03-08 Thread Bruce Momjian
Andrew Dunstan wrote: I think this is now ready for application, unless someone objects. Since the last patch I posted, I have done the following: . changed the escapes to lower case, as Peter prefers. This is also in line with what Apache does, which is the nearest equivalent I can

Re: [PATCHES] log_line_info

2004-03-08 Thread Bruce Momjian
Oh, I also renamed it to log_line_prefix, which was one of your suggestions. And I also updated some of the documentation phrasing. I also marked the TODO item as completed. Thanks. --- Andrew Dunstan wrote: I think

Re: [PATCHES] log_line_info

2004-03-01 Thread Andrew Dunstan
Jon Jensen wrote: On Sun, 29 Feb 2004, Andrew Dunstan wrote: . changed source port reporting from host:port to host(port) to avoid IP6 address ambiguity. I have no idea how widespread this is, but recent versions of BIND write it this way: 127.0.0.1#953 ::1#953 Personally I'd kind

Re: [PATCHES] log_line_info

2004-02-29 Thread Peter Eisentraut
Andrew Dunstan wrote: I will do docs. We could sensibly get rid of log_pid and log_timestamp with my latest patch. I would also suggest getting rid of log_source_port, since there really isn't any reason *not* to log the source port. There is the very definite possibility that people don't

Re: [PATCHES] log_line_info

2004-02-29 Thread Peter Eisentraut
Andrew Dunstan wrote: Attached is a patch for tagging log lines produced by backends. It is not quite ready for application - this is for people to look over and play with. For my testing I used the following settings: log_connections = true log_disconnections = true log_line_info = '%T

Re: [PATCHES] log_line_info

2004-02-29 Thread Andrew Dunstan
Peter Eisentraut wrote: Andrew Dunstan wrote: Attached is a patch for tagging log lines produced by backends. It is not quite ready for application - this is for people to look over and play with. For my testing I used the following settings: log_connections = true log_disconnections = true

Re: [PATCHES] log_line_info

2004-02-29 Thread Andrew Dunstan
Peter Eisentraut wrote: Andrew Dunstan wrote: I will do docs. We could sensibly get rid of log_pid and log_timestamp with my latest patch. I would also suggest getting rid of log_source_port, since there really isn't any reason *not* to log the source port. There is the very definite

[PATCHES] log_line_info

2004-02-29 Thread Andrew Dunstan
I think this is now ready for application, unless someone objects. Since the last patch I posted, I have done the following: . changed the escapes to lower case, as Peter prefers. This is also in line with what Apache does, which is the nearest equivalent I can think of. . added 2 new escapes:

Re: [PATCHES] log_line_info

2004-02-28 Thread Bruce Momjian
Andrew Dunstan wrote: Attached is a patch for tagging log lines produced by backends. It is not quite ready for application - this is for people to look over and play with. For my testing I used the following settings: log_connections = true log_disconnections = true log_line_info =

Re: [PATCHES] log_line_info

2004-02-28 Thread Andrew Dunstan
Bruce Momjian wrote: +case 'C': + j += snprintf(result+j,result_len-j,%lx.%lx, +(long)(MyProcPort-session_start.tv_sec), +(long)MyProcPid); One other comment. Are you sure you want a

Re: [PATCHES] log_line_info

2004-02-28 Thread Andrew Dunstan
Bruce Momjian wrote: Andrew Dunstan wrote: Attached is a patch for tagging log lines produced by backends. It is not quite ready for application - this is for people to look over and play with. For my testing I used the following settings: log_connections = true log_disconnections = true

[PATCHES] log_line_info

2004-02-23 Thread Andrew Dunstan
Attached is a patch for tagging log lines produced by backends. It is not quite ready for application - this is for people to look over and play with. For my testing I used the following settings: log_connections = true log_disconnections = true log_line_info = '%T [%P] [EMAIL