Re: [PATCHES] fix schema ownership for database owner on first

2004-06-10 Thread Fabien COELHO
Dear Bruce, On Wed, 9 Jun 2004, Bruce Momjian wrote: > Would you adjust based on Tom's comments and resubmit? Thanks. Done. ! Date: Wed, 9 Jun 2004 14:31:59 +0200 (CEST) ! From: Fabien COELHO <[EMAIL PROTECTED]> ! To: PostgreSQL Patches <[EMAIL PROTECTED]> ! Subject: [PATCHES] fix schema owne

Re: [PATCHES] Notice about costly ri checks

2004-06-10 Thread Tom Lane
Fabien COELHO <[EMAIL PROTECTED]> writes: > This patch adds a "notice" at constraint creation time if the referential > integrity check is to be "costly", that is the comparison operator > involves some coercion. This is not the correct test at all. The correct test would involve looking in pg_am

Re: [PATCHES] Fully enabling NLS in pg_ctl

2004-06-10 Thread Bruce Momjian
Peter says he has your patches and will have them in 7.4.3. --- Serguei Mokhov wrote: > - Original Message - > From: "Bruce Momjian" <[EMAIL PROTECTED]> > Sent: June 09, 2004 10:59 PM > > > > > OK, I added the nls

[PATCHES] win32 substitute_libpath_macro changes

2004-06-10 Thread Claudio Natoli
For application to HEAD, following community review. Determines the PKGLIBDIR equivalent under win32. Requires pgsql lib and bin directories to be packaged under the same root directory (eg. /pgsql/bin and /pgsql/lib) for the win32 port, which does not appear to be an onerous restriction. Cheers

Re: [PATCHES] Fully enabling NLS in pg_ctl

2004-06-10 Thread Serguei A. Mokhov
On Thu, 10 Jun 2004, Bruce Momjian wrote: > Date: Thu, 10 Jun 2004 09:25:14 -0400 (EDT) > > Peter says he has your patches and will have them in 7.4.3. Cool. Thanks. Will more translation patches be accepted on Friday and during the weekend before 7.4.3 release? -s > ---

Re: [PATCHES] pg_autovacuum patch for 7.4.2 and HEAD

2004-06-10 Thread Tom Lane
"Matthew T. O'Connor" <[EMAIL PROTECTED]> writes: > pg_autovacuum.c has some problems with int overflow and not using appropriate > datatypes to track certain table values. This patch attempts to fix all > these issues. Someone should take a look and make sure its valid. > ! new_tbl->reli

Re: [PATCHES] Fully enabling NLS in pg_ctl

2004-06-10 Thread Bruce Momjian
Serguei A. Mokhov wrote: > On Thu, 10 Jun 2004, Bruce Momjian wrote: > > > Date: Thu, 10 Jun 2004 09:25:14 -0400 (EDT) > > > > Peter says he has your patches and will have them in 7.4.3. > > Cool. Thanks. Will more translation patches be accepted on Friday and > during the weekend before 7.4.3 re

Re: [PATCHES] Fully enabling NLS in pg_ctl

2004-06-10 Thread Peter Eisentraut
Serguei A. Mokhov wrote: > On Thu, 10 Jun 2004, Bruce Momjian wrote: > > Date: Thu, 10 Jun 2004 09:25:14 -0400 (EDT) > > > > Peter says he has your patches and will have them in 7.4.3. > > Cool. Thanks. Will more translation patches be accepted on Friday and > during the weekend before 7.4.3 releas

Re: [PATCHES] Translation (partial): postgres-af.po

2004-06-10 Thread Peter Eisentraut
Petri Jooste wrote: [new postgres-af.po] Installed into 7.5 branch. ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings

Re: [PATCHES] Translations updates for 7.5: initdb-ru.po

2004-06-10 Thread Peter Eisentraut
Serguei Mokhov wrote: > Hello Peter, > > This patch completes translation of initdb for 7.5: > - Translate the remaining untranslated messages > - Proofread and run basic spellcheck Installed. ---(end of broadcast)--- TIP 9: the planner wil

Re: [PATCHES] translation updates pt_BR

2004-06-10 Thread Peter Eisentraut
Euler Taveira de Oliveira wrote: > Here are some updates for REL7_4. > Please apply it before release 7.4.3. > http://www.ufgnet.ufg.br/euler/pg_update_7_4_3.tar.gz Installed. Brazil takes the lead... ---(end of broadcast)--- TIP 1: subscribe and

Re: [PATCHES] Translation updates for 7.4/7.5: postgres-ru.po

2004-06-10 Thread Peter Eisentraut
Serguei Mokhov wrote: > Attached patch brings in new translations for 'postgres' > as well as fixes various typos and spelling errors > throughout the file. Please install for both 7.4 and 7.5. Both done. ---(end of broadcast)--- TIP 7: don't forge

Re: [PATCHES] Fully enabling NLS in pg_ctl

2004-06-10 Thread Peter Eisentraut
Serguei A. Mokhov wrote: > On Mon, 31 May 2004, Bruce Momjian wrote: > > Date: Mon, 31 May 2004 23:31:42 -0400 (EDT) > > > > I have added the setting of local calls to the top of pg_ctl.c. I > > did not localize ".", nor: > > > > printf("%s (PostgreSQL) %s\n", progname, PG_VERSION); >

Re: [PATCHES] Fully enabling NLS in pg_ctl

2004-06-10 Thread Peter Eisentraut
Bruce Momjian wrote: > OK, I added the nls and po files for pg_ctl. Thanks. Looks good at first glance. I was travelling a lot in recent weeks and had trouble keeping up. Thanks for handling it. ---(end of broadcast)--- TIP 3: if posting/readin

Re: [PATCHES] [HACKERS] serverlog function (log_destination file)

2004-06-10 Thread Andreas Pflug
Tom Lane wrote: Bruce Momjian <[EMAIL PROTECTED]> writes: Looks good to me. The only issue I saw was that the default file name mentioned in postgresql.conf doesn't match the actual default. I'm really not happy with the concept that the postmaster overrides its stderr direction. I agre

Re: [PATCHES] [HACKERS] serverlog function (log_destination file)

2004-06-10 Thread Bruce Momjian
Andreas Pflug wrote: > Tom Lane wrote: > > >Bruce Momjian <[EMAIL PROTECTED]> writes: > > > > > >>Looks good to me. The only issue I saw was that the default file name > >>mentioned in postgresql.conf doesn't match the actual default. > >> > >> > > > >I'm really not happy with the concept t

Re: [PATCHES] [HACKERS] serverlog function (log_destination file)

2004-06-10 Thread Andreas Pflug
Sorry I didn't get back on this earlier, yesterday morning my internet access was literally struck by lightning, I'm running temporary hardware now. Bruce Momjian wrote: Looks good to me. The only issue I saw was that the default file name mentioned in postgresql.conf doesn't match the actual d

Re: [PATCHES] [HACKERS] serverlog function (log_destination file)

2004-06-10 Thread Bruce Momjian
Andreas Pflug wrote: > Sorry I didn't get back on this earlier, yesterday morning my internet > access was literally struck by lightning, I'm running temporary hardware > now. > > Bruce Momjian wrote: > > Looks good to me. The only issue I saw was that the default file name > mentioned

Re: [PATCHES] [HACKERS] serverlog function (log_destination file)

2004-06-10 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Actually, my idea of sending a message to stderr saying we are using a > pre-configured file is so folks aren't surprised by the fact they can't > see any stderr anymore. Hm? I thought we'd just established that the patch wasn't going to suppress output

Re: [PATCHES] [HACKERS] serverlog function (log_destination file)

2004-06-10 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Actually, my idea of sending a message to stderr saying we are using a > > pre-configured file is so folks aren't surprised by the fact they can't > > see any stderr anymore. > > Hm? I thought we'd just established that the patch was

[PATCHES] pg_ctl using START with paths needing quotes

2004-06-10 Thread Bruce Momjian
This applied patch changes the way pg_ctl starts on Win32. Using START, it is not possible to quote the executable name, who's directory might have spaces: START /B /program files/x.exe The fix is to create a temporary batch file in C:\ containing: /program files/x.exe and run

Re: [PATCHES] delayed planning of unnamed statements

2004-06-10 Thread Bruce Momjian
Applied by Tom. Thanks. --- Oliver Jowett wrote: > Per discussion on -hackers > (http://archives.postgresql.org/pgsql-hackers/2004-05/msg00990.php), > here is a first cut at delaying query planning for unnamed statements

Re: [PATCHES] Compiling libpq with VisualC

2004-06-10 Thread Bruce Momjian
I have looked over this patch. I noticed this: -static pthread_mutex_t init_mutex = PTHREAD_MUTEX_INITIALIZER; - +static pthread_mutex_t init_mutex; +static int mutex_initialized = 0; +if (!mutex_initialized) +

Re: [PATCHES] pgpipe error reporting

2004-06-10 Thread Bruce Momjian
Patch applied. Thanks. --- Magnus Hagander wrote: > This patch updates pgpipe() on win32 to log exactly which part of the > call fails when it does. (As it is now, there is no way to figure out > the point of error). Shoul

Re: [PATCHES] [pgsql-hackers-win32] [HACKERS] select like...not using index

2004-06-10 Thread Bruce Momjian
Patch applied. Thanks. --- Magnus Hagander wrote: > >> It certainly doesn't. There still was a bug with the locale stuff, > >> though - the GUC variable was not set in the child > >processes. So "show > >> lc_collate" wou

Re: [PATCHES] CR fix for create_help.pl

2004-06-10 Thread Bruce Momjian
Patch applied. Thanks. --- Andrew Dunstan wrote: > > The attached tiny patch removes spurious carriage returns that might be > copied by the script that generates psql's help. (You can get the > spurious CRs if you use