Re: [PATCHES] eventlog fix

2004-06-19 Thread Laurent Ballester
Hello, I just looking under CVS web interface what is stored in pgevent directory and what is missing. The files attached with this mail have to be stored in pgevent directory. MSG01.bin is a bin files, result of Microsoft MC compiler. MC compiler can be downloaded for free with MS Core SDK b

Re: [PATCHES] Tablespace patch review

2004-06-19 Thread Dave Page
> -Original Message- > From: [EMAIL PROTECTED] on behalf of Bruce Momjian > Sent: Sat 6/19/2004 1:05 AM > To: Andreas Pflug > Cc: Tom Lane; Gavin Sherry; PostgreSQL-patches > Subject: Re: [PATCHES] Tablespace patch review > > We can build a gui on top of the command-line tool, no? No,

Re: [PATCHES] Tablespace patch review

2004-06-19 Thread Christopher Kings-Lynne
regression=# create database foo location 'bar'; WARNING: LOCATION is not supported anymore HINT: Consider using tablespaces instead. CREATE DATABASE and everything will go into the default tablespace. I don't really see how to do much better than that ... You could create an automatically named

Re: [PATCHES] Tablespace patch review

2004-06-19 Thread Andreas Pflug
Tom Lane wrote: Andreas Pflug <[EMAIL PROTECTED]> writes: Tom Lane wrote: As for the authentication-is-expensive issue, what of it? You *should* have to authenticate yourself in order to look inside another person's database. The sort of cross-database inspection being proposed here would

Re: [PATCHES] Tablespace patch review

2004-06-19 Thread Andreas Pflug
Dave Page wrote: -Original Message- From: [EMAIL PROTECTED] on behalf of Bruce Momjian Sent: Sat 6/19/2004 1:05 AM To: Andreas Pflug Cc: Tom Lane; Gavin Sherry; PostgreSQL-patches Subject: Re: [PATCHES] Tablespace patch review We can build a gui on top of the command-line tool, no? No, w

Re: [PATCHES] pgxs: build infrastructure for extensions v1

2004-06-19 Thread Peter Eisentraut
Fabien COELHO wrote: > Please find attached a patch which provides a working infrastructure > for pg extensions such as new gist-based indexes, functions, types... Comments: - Regarding GNUmakefile.in changes: files in directory foo/ must be handled by a makefile in directory foo/, so these chan

Re: [PATCHES] stderr & win32 admin check

2004-06-19 Thread Magnus Hagander
I plan to resubmit this patch shortly (hopefully during the weekend) including supprot for detecting if running as a service (and thus pick eventlog support). From what I can tell, the rest should be Ok to go, so expect a new one shortly. //Magnus >-Original Message- >From: Bruce Momjian

[PATCHES] Admin guide tablespace docs

2004-06-19 Thread Gavin Sherry
Attached. Thanks, Gavin tablespace-docs.diff.gz Description: GNU Zip compressed data ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] pgxs: build infrastructure for extensions v1

2004-06-19 Thread Fabien COELHO
Dear Peter, Thanks a lot for all these comments. I'll try to update my patch in the coming week, or maybe this weekend. Some responses to some of your comments: > - Please don't invent new targets like light-install, install-local. > Just install everything in the install target. The current s

Re: [PATCHES] Tablespace patch review

2004-06-19 Thread Bruce Momjian
Andreas Pflug wrote: > Dave Page wrote: > > >-Original Message- > >From: [EMAIL PROTECTED] on behalf of Bruce Momjian > >Sent: Sat 6/19/2004 1:05 AM > >To: Andreas Pflug > >Cc: Tom Lane; Gavin Sherry; PostgreSQL-patches > >Subject: Re: [PATCHES] Tablespace patch review > > > >We can build

Re: [PATCHES] eventlog fix

2004-06-19 Thread Bruce Momjian
Woh, we aren't requring MS C to compile this feature. Can't it be created by mingw? If not, I don't see what value an MS C compile is going to do for us. --- Laurent Ballester wrote: > Hello, > > I just looking under CVS

Re: [PATCHES] eventlog fix

2004-06-19 Thread Magnus Hagander
We require the MS "MC" compiler to build the BIN file (note - this is not C - this is the "Message Compiler"). The Ccode should compile fine in mingw. Not requiring it is the reason we'd include the .BIN file in CVS. MC is only needed to *rebuild* it. //Magnus >-Original Message- >From:

Re: [PATCHES] eventlog fix

2004-06-19 Thread Andrew Dunstan
There is also this message compiler - I have no idea of the quality: http://www.volny.cz/xnavara/SimpleMC.zip I believe the WINE project also has one. Putting the .bin file in CVS doesn't seem too horrible to me. cheers andrew Magnus Hagander wrote: We require the MS "MC" compiler to build the BIN

Re: [PATCHES] Tablespace patch review

2004-06-19 Thread Andreas Pflug
Bruce Momjian wrote: I don't see why an admin tool can't connect to each database and get a listing of what is in each tablespace. I don't think connecting to 100 databases to get that information will be slow. Well, whatever you call slow or not slow. I checked it; connecting 10 databases, re

Re: [PATCHES] eventlog fix

2004-06-19 Thread Dave Page
> -Original Message- > From: [EMAIL PROTECTED] on behalf of Bruce Momjian > Sent: Sat 6/19/2004 4:21 PM > To: Laurent Ballester > Cc: Alvaro Herrera; [EMAIL PROTECTED] > Subject: Re: [PATCHES] eventlog fix > > > Woh, we aren't requring MS C to compile this feature. Can't it be > creat

Re: [PATCHES] Tablespace patch review

2004-06-19 Thread Dave Page
> -Original Message- > From: Andreas Pflug [mailto:[EMAIL PROTECTED] > Sent: Sat 6/19/2004 6:40 PM > To: Bruce Momjian > Cc: Dave Page; Tom Lane; PostgreSQL-patches > Subject: Re: [PATCHES] Tablespace patch review > > Well, whatever you call slow or not slow. > I checked it; connecting

Re: [PATCHES] eventlog fix

2004-06-19 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > We require the MS "MC" compiler to build the BIN file (note - this is > not C - this is the "Message Compiler"). So is this tool readily available? What does one have to do/buy to lay hands on it? > Not requiring it is the reason we'd include the .

Re: [PATCHES] Tablespace patch review

2004-06-19 Thread Andreas Pflug
Dave Page wrote: -Original Message- From: Andreas Pflug [mailto:[EMAIL PROTECTED] Sent: Sat 6/19/2004 6:40 PM To: Bruce Momjian Cc: Dave Page; Tom Lane; PostgreSQL-patches Subject: Re: [PATCHES] Tablespace patch review Well, whatever you call slow or not slow. I checked it; connecting 10

Re: [PATCHES] eventlog fix

2004-06-19 Thread Dave Page
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Tom Lane > Sent: 19 June 2004 20:03 > To: Magnus Hagander > Cc: Bruce Momjian; Laurent Ballester; [EMAIL PROTECTED] > Subject: Re: [PATCHES] eventlog fix > > "Magnus Hagander" <[EMAIL PROTECTED]> w

Re: [PATCHES] Compiling libpq with VisualC

2004-06-19 Thread Andreas Pflug
Two minor tweaks: in libpq-be.h isn't present on win32 vc6. Apparently, it isn't used in Linux either; libpq will compile without it. All usages of gettimeofday throughout the backend don't seem connection related, so libpq-be.h seems an odd place to include it. ERROR in elog.h has conflicts w

Re: [PATCHES] eventlog fix

2004-06-19 Thread Tom Lane
"Dave Page" <[EMAIL PROTECTED]> writes: >> So is this tool readily available? What does one have to >> do/buy to lay hands on it? > It's included with the Windows Platform SDK (which is free). Oh, good. > It's a very large download to get the SDK (180MB) - that's a lot of > bandwidth for one l

Re: [PATCHES] eventlog fix

2004-06-19 Thread Dave Page
> -Original Message- > From: Tom Lane [mailto:[EMAIL PROTECTED] > Sent: 19 June 2004 22:49 > To: Dave Page > Cc: Magnus Hagander; Bruce Momjian; Laurent Ballester; > [EMAIL PROTECTED] > Subject: Re: [PATCHES] eventlog fix > > Hm, that is a lot ... but wouldn't the sort of people > i

Re: [PATCHES] Compiling libpq with VisualC

2004-06-19 Thread Tom Lane
Andreas Pflug <[EMAIL PROTECTED]> writes: > in libpq-be.h isn't present on win32 vc6. Apparently, it > isn't used in Linux either; libpq will compile without it. It's there to declare struct timeval, and I'm fairly certain that diking it out of the header would break things on some platforms. W

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-06-19 Thread Dave Page
> -Original Message- > From: Tom Lane [mailto:[EMAIL PROTECTED] > Sent: 19 June 2004 00:22 > To: Dave Page > Cc: PostgreSQL-development > Subject: Re: [HACKERS] Cannot initdb in cvs tip > > "Dave Page" <[EMAIL PROTECTED]> writes: > > I'm getting the following error when trying to init

Re: [PATCHES] Tablespace patch review

2004-06-19 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Well, I didn't use tablespaces here so the pg_tablespaces directory is > > empty, so I can't think of what the tablespace is. > > You look in the pg_tablespace catalog for the row with that OID. > > > Also, are we calling it pg_table

Re: [PATCHES] Tablespace patch review

2004-06-19 Thread Bruce Momjian
Andreas Pflug wrote: > Bruce Momjian wrote: > > > > > > >I don't see why an admin tool can't connect to each database and get a > >listing of what is in each tablespace. I don't think connecting to 100 > >databases to get that information will be slow. > > > > > > > Well, whatever you call slow

Re: [PATCHES] eventlog fix

2004-06-19 Thread Bruce Momjian
Dave Page wrote: > > > > -Original Message- > > From: Tom Lane [mailto:[EMAIL PROTECTED] > > Sent: 19 June 2004 22:49 > > To: Dave Page > > Cc: Magnus Hagander; Bruce Momjian; Laurent Ballester; > > [EMAIL PROTECTED] > > Subject: Re: [PATCHES] eventlog fix > > > > Hm, that is a lot .

Re: [PATCHES] Compiling libpq with VisualC

2004-06-19 Thread Bruce Momjian
Tom Lane wrote: > Andreas Pflug <[EMAIL PROTECTED]> writes: > > in libpq-be.h isn't present on win32 vc6. Apparently, it > > isn't used in Linux either; libpq will compile without it. > > It's there to declare struct timeval, and I'm fairly certain that diking > it out of the header would break

Re: [PATCHES] eventlog fix

2004-06-19 Thread Bruce Momjian
Patch applied, with doc additions I already posted. Please test CVS and let me know how it works. I added a README containing your explaination below for our later reference. I added the MSG01.bin as a binary CVS checkin.

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-06-19 Thread John Hansen
On Sun, 2004-06-20 at 08:04, Dave Page wrote: > > > -Original Message- > > From: Tom Lane [mailto:[EMAIL PROTECTED] > > Sent: 19 June 2004 00:22 > > To: Dave Page > > Cc: PostgreSQL-development > > Subject: Re: [HACKERS] Cannot initdb in cvs tip > > > > "Dave Page" <[EMAIL PROTECTED]>

[PATCHES] ALTER TABLE ... SET TABLESPACE

2004-06-19 Thread Gavin Sherry
Attached is a patch implementing this functionality. I've modified make_new_heap() as well as swap_relfilenodes() to not assume that tablespaces remain the same from old to new heap. I thought it better to go down this road than introduce a lot of duplicate code. Thanks Gavin altertable.diff.gz