[PATCHES] document "rep; no" black magic

2004-10-06 Thread Neil Conway
This patch adds a comment that describes what the "rep; no" sequence in spin_delay() does, in src/include/storage/s_lock.h. I think fully describing what this code sequence is intended to due is worth the space, but speak up if you think I've added too large a comment... Barring any objections, I

Re: [PATCHES] Quieting the copyright/startup message...

2004-10-06 Thread Neil Conway
On Tue, 2004-10-05 at 10:32, Neil Conway wrote: > I think the second hunk (arranging to read ~/.psqlrc before emitting the > copyright message) is all that's necessary [...] Patch applied. -Neil ---(end of broadcast)--- TIP 5: Have you checked ou

Re: [PATCHES] pgxs default installation + various fixes - v2

2004-10-06 Thread Bruce Momjian
Patch applied. Thanks. --- Fabien COELHO wrote: > > Dear patchers, > > please find attached an alternate submission which addresses open item > "make pgxs install by default". It is up to the committers to chose. > > (1

Re: [PATCHES] pg_hba.conf additional comment re local line

2004-10-06 Thread Bruce Momjian
Patch applied. Thanks. I adjusted the code slightly and I tested !HAVE_UNIX_SOCKETS rather than Win32. --- Andrew Dunstan wrote: > > The original of this seems to have gotten lost in the ether somewhere. > It might turn

Re: [PATCHES] plpython win32

2004-10-06 Thread Bruce Momjian
Patch applied. Thanks. --- Magnus Hagander wrote: > > > > So, here is a new patch. Summary: > > > > > > There is still a hard-coded python version in "libpython23.a". > > > > Argh. I thought I caught them all. How the he

Re: [PATCHES] SSL on win32

2004-10-06 Thread Bruce Momjian
Patch applied. Thanks. --- Magnus Hagander wrote: > Hello! > > Here is a patch to fix win32 ssl builds. Summary of changes: > > * Links with -leay32 and -lssleay32 instead of crypto and ssl. On win32, > "crypto and ssl"

Re: [PATCHES] pg_dumpall bug in PG 8.0b3 Win32 port

2004-10-06 Thread Luiz K. Matsumura
Andrew Dunstan wrote: Luiz K. Matsumura wrote: Hi, I tried to use pg_dumpall in Win32 and receive a error message like this: pg_dump.exe: [archiver (db)] connection to database "test" failed: FATAL: user "'postgres'" does not exist Well, the word "'postgres'" is the word is between simple qu

[PATCHES] Win32 libpq/ssl fix

2004-10-06 Thread Dave Page
The Win32 (mingw) build of libpq seems to have lost it's SSL libs from the link step resulting in a build failure. The attached patch fixes that. Please apply asap. Thanks, Dave libpq_ssl.patch Description: libpq_ssl.patch ---(end of broadcast)--

[PATCHES] Win32 VERSIONINFO fix

2004-10-06 Thread Dave Page
Unfortunately some re-jigging of Magnus' Win32 version patch broke the build by introducing some un-escaped double quotes into sed commands. The attached patch escapes those quotes without removing the re-jigging that was done. Regards, Dave. filedesc.diff Description: filedesc.diff ---

Re: [PATCHES] pg_dumpall bug in PG 8.0b3 Win32 port

2004-10-06 Thread Tom Lane
"Luiz K. Matsumura" <[EMAIL PROTECTED]> writes: > I modified pg_dumpall.c lines between 160 and 270 to add a #ifndef > WIN32... #endif clause to pgdumpopts to store > the parameters with double quotations intead simple quotation marks in > case of WIN32 ports This seems unnecessarily ugly. Why

Re: [PATCHES] Win32 VERSIONINFO fix

2004-10-06 Thread Magnus Hagander
> Unfortunately some re-jigging of Magnus' Win32 version patch > broke the build by introducing some un-escaped double quotes > into sed commands. > The attached patch escapes those quotes without removing the > re-jigging that was done. Hmm, this approach seems to make it even less readable

Re: [PATCHES] Win32 VERSIONINFO fix

2004-10-06 Thread Dave Page
> -Original Message- > From: Magnus Hagander [mailto:[EMAIL PROTECTED] > Sent: 06 October 2004 15:27 > To: Dave Page; PostgreSQL-patches > Subject: RE: [PATCHES] Win32 VERSIONINFO fix > > > > Unfortunately some re-jigging of Magnus' Win32 version > patch broke the > > build by intr

Re: [PATCHES] Win32 VERSIONINFO fix

2004-10-06 Thread Bruce Momjian
OK, I adjusted the sed script in CVS and Dave tested it. I also updated the win32ver.rc file to 8,0,000,000. --- Dave Page wrote: > > > > -Original Message- > > From: Magnus Hagander [mailto:[EMAIL PROTECTED] >

Re: [PATCHES] Win32 libpq/ssl fix

2004-10-06 Thread Bruce Momjian
Patch applied. Thanks. --- Dave Page wrote: > The Win32 (mingw) build of libpq seems to have lost it's SSL libs from > the link step resulting in a build failure. The attached patch fixes > that. > > Please apply asap. >

Re: [PATCHES] pg_dumpall bug in PG 8.0b3 Win32 port

2004-10-06 Thread Bruce Momjian
Patch applied. Thanks. --- Luiz K. Matsumura wrote: > > > Andrew Dunstan wrote: > > > > > > > Luiz K. Matsumura wrote: > > > >> Hi, > >> > >> I tried to use pg_dumpall in Win32 and receive a error message like > >> th

Re: [PATCHES] pg_dumpall bug in PG 8.0b3 Win32 port

2004-10-06 Thread Bruce Momjian
Tom Lane wrote: > "Luiz K. Matsumura" <[EMAIL PROTECTED]> writes: > > I modified pg_dumpall.c lines between 160 and 270 to add a #ifndef > > WIN32... #endif clause to pgdumpopts to store > > the parameters with double quotations intead simple quotation marks in > > case of WIN32 ports > > This s

Re: [PATCHES] pg_dumpall bug in PG 8.0b3 Win32 port

2004-10-06 Thread Andrew Dunstan
Bruce Momjian wrote: Tom Lane wrote: "Luiz K. Matsumura" <[EMAIL PROTECTED]> writes: I modified pg_dumpall.c lines between 160 and 270 to add a #ifndef WIN32... #endif clause to pgdumpopts to store the parameters with double quotations intead simple quotation marks in case of WIN32 ports

Re: [PATCHES] pg_dumpall bug in PG 8.0b3 Win32 port

2004-10-06 Thread Bruce Momjian
Andrew Dunstan wrote: > > > Bruce Momjian wrote: > > >Tom Lane wrote: > > > > > >>"Luiz K. Matsumura" <[EMAIL PROTECTED]> writes: > >> > >> > >>>I modified pg_dumpall.c lines between 160 and 270 to add a #ifndef > >>>WIN32... #endif clause to pgdumpopts to store > >>>the parameters with

Re: [PATCHES] pg_config fixes

2004-10-06 Thread Bruce Momjian
Patch applied. Thanks. --- Euler Taveira de Oliveira wrote: > Hi, > > This simple patch fixes a typo, ensure pg_config is removed in win32 > and correct some splitted message mistake. > > Please apply. > > PS> I'll send

Re: [PATCHES] CREATE DATABASE with tablespace fix

2004-10-06 Thread Bruce Momjian
I show this as fixed in CVS. --- Gavin Sherry wrote: > Attached is a patch resolving the issue raised here: > > http://groups.google.com.au/groups?q=tablespaces+group:comp.databases.postgresql.hackers&hl=en&lr=&ie=UTF-8&gro

[PATCHES] Warning for psql history not supported

2004-10-06 Thread Bruce Momjian
Here is an applied patch that suppresses psql \s help display for platforms like Win32 that don't typically install with readline. It also prints and error if you try to access it. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-

Re: [PATCHES] Warning for psql history not supported

2004-10-06 Thread Peter Eisentraut
Bruce Momjian wrote: > Here is an applied patch that suppresses psql \s help display for > platforms like Win32 that don't typically install with readline. > It also prints and error if you try to access it. But "history is not supported on this platform" is not really true, is it? -- Peter Eis

Re: [PATCHES] Warning for psql history not supported

2004-10-06 Thread Bruce Momjian
Peter Eisentraut wrote: > Bruce Momjian wrote: > > Here is an applied patch that suppresses psql \s help display for > > platforms like Win32 that don't typically install with readline. > > It also prints and error if you try to access it. > > But "history is not supported on this platform" is not

Re: [PATCHES] Warning for psql history not supported

2004-10-06 Thread Bruce Momjian
I changed it to "history is not supported". --- Bruce Momjian wrote: > Peter Eisentraut wrote: > > Bruce Momjian wrote: > > > Here is an applied patch that suppresses psql \s help display for > > > platforms like Win32 that

Re: [PATCHES] document "rep; no" black magic

2004-10-06 Thread Neil Conway
On Wed, 2004-10-06 at 17:04, Neil Conway wrote: > This patch adds a comment that describes what the "rep; no" sequence in > spin_delay() does, in src/include/storage/s_lock.h Patch applied to HEAD. (Of course, I meant to write "rep; nop" in the previous mail -- typo'd twice...) -Neil

[PATCHES] [psql] Setting the PROMPT on command line

2004-10-06 Thread Ingo van Lil
Hi there, I wrote a tiny patch to prevent psql from overwriting the PROMPT[1-3] variables with default values after parsing the command line. That way the prompt can be set from the command line by using: psql -v PROMPT1=... The patch is against postgres 7.4.5, but it's so trivial it should be p

Re: [PATCHES] s_lock_test build fix

2004-10-06 Thread Neil Conway
On Wed, 2004-10-06 at 14:36, Neil Conway wrote: > This trivial patch allows "make -C src/backend/storage/lmgr/ > s_lock_test" to succeed in vpath builds. Patch applied to HEAD. -Neil ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster

Re: [PATCHES] [psql] Setting the PROMPT on command line

2004-10-06 Thread Neil Conway
On Thu, 2004-10-07 at 10:04, Ingo van Lil wrote: > I wrote a tiny patch to prevent psql from overwriting the PROMPT[1-3] > variables with default values after parsing the command line. Looks good to me. Does anyone object to applying this for 8.0? -Neil ---(end of broad

Re: [PATCHES] [psql] Setting the PROMPT on command line

2004-10-06 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > On Thu, 2004-10-07 at 10:04, Ingo van Lil wrote: >> I wrote a tiny patch to prevent psql from overwriting the PROMPT[1-3] >> variables with default values after parsing the command line. > Looks good to me. Does anyone object to applying this for 8.0? I'm

[PATCHES] pg_ctl: WIN32 for CYGWIN also (services)

2004-10-06 Thread Reini Urban
I'd like to have this nice new features also :) Just redefine WIN32 #ifdef __CYGWIN___ or the clean and long way as in my patch? I'm not sure about any dirty side-effects. Builds fine and works as expected. (Just tablespace symlinks not yet. Will get to that soon.) --- postgresql-8.0.0cvs/src/bin

Re: [PATCHES] [psql] Setting the PROMPT on command line

2004-10-06 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > On Thu, 2004-10-07 at 13:05, Tom Lane wrote: >> I'm just wondering if the fix is in the right place. Doesn't the same >> issue arise for other variables? > Well, we don't manually set other variables in psql itself, with the > exception of defining some d

Re: [PATCHES] [psql] Setting the PROMPT on command line

2004-10-06 Thread Neil Conway
On Thu, 2004-10-07 at 13:05, Tom Lane wrote: > I'm just wondering if the fix is in the right place. Doesn't the same > issue arise for other variables? Well, we don't manually set other variables in psql itself, with the exception of defining some default values before we process command-line arg

[PATCHES] pg_config translation to pt_BR

2004-10-06 Thread Euler Taveira de Oliveira
Hi, Here is a patch to available the first translation of pg_config. The files attached needs to be in src/bin/pg_config. Basically, it is two files (nls.mk, pt_BR.po) and one directory (po/). Please apply. = Euler Taveira de Oliveira euler[at]yahoo_com_br