Re: [PATCHES] DROP OWNED again

Alvaro Herrera wrote: > I have added the regression tests in this new version, which I'll apply > on monday barring any objections. (I do not attach the SGML files > because these didn't change since the last post.) Applied. -- Alvaro Herrerahttp://www.CommandPr

[PATCHES] drop database if exists

here's a patch for "drop database if exists". Barring objections I will apply it in a day or two. cheers andrew Index: doc/src/sgml/ref/drop_database.sgml === RCS file: /cvsroot/pgsql/doc/src/sgml/ref/drop_database.sgml,v retr

Re: [PATCHES] In pg_dump "no owner" mode don't dump owner names in comments

Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > This fixes pg_dump so that when using the '-O' no owners option it does > not print the owner name in the object comment. Why is that a good idea? regards, tom lane ---(end of broadcast)---

[PATCHES] aclchk.c refactor

I intend to apply later today the attached patch in order to reduce some code duplication in aclchk.c and clean a bit the API I just introduced in the previous patch. This reduces aclchk.c from 2377 lines to 2206. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The

Re: [PATCHES] drop database if exists

Andrew Dunstan <[EMAIL PROTECTED]> writes: > here's a patch for "drop database if exists". Barring objections I will > apply it in a day or two. Please try to remember the src/backend/nodes/ files this time. (In general, when modifying a widely-known struct such as a parse node type, it's a good

Re: [PATCHES] drop database if exists

Tom Lane wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: here's a patch for "drop database if exists". Barring objections I will apply it in a day or two. Please try to remember the src/backend/nodes/ files this time. (In general, when modifying a widely-known struct such as a pa

Re: [PATCHES] aclchk.c refactor

Alvaro Herrera wrote: > I intend to apply later today the attached patch in order to reduce some > code duplication in aclchk.c and clean a bit the API I just introduced > in the previous patch. This reduces aclchk.c from 2377 lines to 2206. Of course, it would be much better if the proposed patc

Re: [PATCHES] aclchk.c refactor

Alvaro Herrera <[EMAIL PROTECTED]> writes: > Now I noticed that there are multiple functions pg_class_aclmask, > pg_database_aclmask, pg_language_aclmask, etc. Is there any objection > to making the exported routine expose the object type as an AclKind > parameter instead of having one function fo

Re: [PATCHES] drop database if exists

Andrew Dunstan <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> (In general, when modifying a widely-known struct such as a parse node >> type, it's a good idea to grep for every single mention of the struct >> type to make sure you've not missed anything.) > oops, ok, thanks, will do. Should we p

[PATCHES] Install pg_regress by default

This patch allows pg_regress to be installed by default. This was proposed awhile back but never done, any objections if I commit this? -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. Index: src/Makefile ===

Re: [PATCHES] Install pg_regress by default

Alvaro Herrera <[EMAIL PROTECTED]> writes: > This patch allows pg_regress to be installed by default. This was > proposed awhile back but never done, any objections if I commit this? I've forgotten the details, but it seems like there was something else that this depended on to be of any use? Wh

Re: [PATCHES] Install pg_regress by default

Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > This patch allows pg_regress to be installed by default. This was > > proposed awhile back but never done, any objections if I commit this? > > I've forgotten the details, but it seems like there was something else > that this depen

[PATCHES] Should libedit be preferred to libreadline?

It would certainly seem so on AIX. In tracking down why postgres 8.x would segfault on AIX 5.3, it became apparent to me that libreadline.a is a problematic library to link against and that libedit.a is preferable (and for reasons other than that readline is GPL while postgres is BSD-licensed). W

Re: [PATCHES] [HACKERS] Should libedit be preferred to libreadline?

Nice analysis, but we can't hack configure like that. It has to be able to be fully generated from its sources. I think the other source file you would need to look at is config/programs.m4. (Not sure about quoting $ac_popdir - why only that one?) Also, I suspect we'd want to enable the libe

Re: [PATCHES] [HACKERS] Should libedit be preferred to libreadline?

Andrew Dunstan <[EMAIL PROTECTED]> writes: > Also, I suspect we'd want to enable the libedit preference with a switch > rather than just force it, if we want to go this way. Quite. My recollection is that there are other platforms on which readline works and libedit is broken. (Readline used to

Re: [PATCHES] In pg_dump "no owner" mode don't dump owner names in

This fixes pg_dump so that when using the '-O' no owners option it does not print the owner name in the object comment. Why is that a good idea? At the moment I want to dump sample databases for a project. I don't want my name or username appearing anywhere in them. I dump without owners o