[PATCHES] contrib/spi makefile inconsistency

2007-03-22 Thread Magnus Hagander
Hi! contrib/spi has a Makefile that uses $(addsuffix) makefile rules for DATA_built and DOCS. It's the only Makefile in contrib that does it. I would like to change that to actually listing the modules instead. The reason for that is that parsing the Makefile for the msvc build will be a *lot* ea

Re: [PATCHES] [HACKERS] Stats processor not restarting

2007-03-22 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> Not really, but maybe it would be sensible to reset last_pgstat_start_time > >> when doing a database-wide restart? > > > You mean like this, attached? > > I'd be fairly surprised if resetting the variable in the

Re: [PATCHES] contrib/spi makefile inconsistency

2007-03-22 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > contrib/spi has a Makefile that uses $(addsuffix) makefile rules for > DATA_built and DOCS. It's the only Makefile in contrib that does it. > I would like to change that to actually listing the modules instead. This seems like a definite regression in

[PATCHES] OS timezone files support

2007-03-22 Thread Zdenek Kotala
This patch brings possibility to switch from default build-in timezone to another timezone source - typically to OS timezone location. This enhancement helps to packagers easy solve integration problem with systems Timezones. If --with-tzdir=/usr/share/zoneinfo is specified as ./configure p

Re: [PATCHES] OS timezone files support

2007-03-22 Thread Tom Lane
Zdenek Kotala <[EMAIL PROTECTED]> writes: > This patch brings possibility to switch from default build-in timezone > to another timezone source - typically to OS timezone location. > It was discussed few weeks ago: > http://archives.postgresql.org/pgsql-hackers/2007-03/msg00784.php AFAIR, the co

Re: [PATCHES] contrib/spi makefile inconsistency

2007-03-22 Thread Peter Eisentraut
Magnus Hagander wrote: > I would like to change that to actually listing the modules instead. > The reason for that is that parsing the Makefile for the msvc build > will be a *lot* easier if I don't have to parse $addsuffix rules. Let's not open that can of worms. Even if you think it's only a s

Re: [PATCHES] OS timezone files support

2007-03-22 Thread Magnus Hagander
Tom Lane wrote: > Zdenek Kotala <[EMAIL PROTECTED]> writes: >> This patch brings possibility to switch from default build-in timezone >> to another timezone source - typically to OS timezone location. > >> It was discussed few weeks ago: >> http://archives.postgresql.org/pgsql-hackers/2007-03/msg

Re: [PATCHES] OS timezone files support

2007-03-22 Thread Zdenek Kotala
Tom Lane wrote: Zdenek Kotala <[EMAIL PROTECTED]> writes: This patch brings possibility to switch from default build-in timezone to another timezone source - typically to OS timezone location. It was discussed few weeks ago: http://archives.postgresql.org/pgsql-hackers/2007-03/msg00784.php

Re: [PATCHES] OS timezone files support

2007-03-22 Thread Tom Lane
Zdenek Kotala <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> I certainly don't see the point of the implementation as you have it >> --- it adds a great deal of unnecessary infrastructure compared to just >> installing a symlink at share/postgresql/timezone. > The point of my solution is that al

Re: [PATCHES] OS timezone files support

2007-03-22 Thread Zdenek Kotala
Magnus Hagander wrote: Tom Lane wrote: Zdenek Kotala <[EMAIL PROTECTED]> writes: This patch brings possibility to switch from default build-in timezone to another timezone source - typically to OS timezone location. It was discussed few weeks ago: http://archives.postgresql.org/pgsql-hackers/2

Re: [PATCHES] [HACKERS] LIKE optimization in UTF-8 and locale-C

2007-03-22 Thread Tom Lane
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > I found LIKE operators are slower on multi-byte encoding databases > than single-byte encoding ones. It comes from difference between > MatchText() and MBMatchText(). > We've had an optimization for single-byte encodings using > pg_database_encoding_

[PATCHES] Re: [DOCS] suggestion for improving TMPDIR and "--format" docs for pg_dump

2007-03-22 Thread Bruce Momjian
Mark Stosberg wrote: > Bruce Momjian wrote: > > Mark Stosberg wrote: > >> It woud also be nice to document that the full names "custom" and "tar" are > >> supported. Longer names can be nice for clarity. > >> > >> ( Unfortunately, wrong formats like "txx" also work instead of throwing > >> an error

Re: [PATCHES] [HACKERS] Stats processor not restarting

2007-03-22 Thread Bruce Momjian
Applied. I did the case where we exit right away too, just for consistency. --- Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > Tom Lane wrote: > > >> Not really, but maybe it woul

Re: [PATCHES] vacuumdb cancel handler

2007-03-22 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- IT

Re: [PATCHES] [HACKERS] LIKE optimization in UTF-8 and locale-C

2007-03-22 Thread Hannu Krosing
Ühel kenal päeval, N, 2007-03-22 kell 11:08, kirjutas Tom Lane: > ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > > I found LIKE operators are slower on multi-byte encoding databases > > than single-byte encoding ones. It comes from difference between > > MatchText() and MBMatchText(). > > > We've

Re: [PATCHES] xpath_array with namespaces support

2007-03-22 Thread Bruce Momjian
Patch applied. Please provide a documentation addition. Thanks. --- Nikolay Samokhvalov wrote: > On 3/4/07, Nikolay Samokhvalov <[EMAIL PROTECTED]> wrote: > > I'll fix these issues and extend the patch with resgression te

Re: [HACKERS] [PATCHES] xml2 contrib patch supporting default XML namespaces

2007-03-22 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Mi

Re: [PATCHES] Re: [DOCS] suggestion for improving TMPDIR and "--format" docs for pg_dump

2007-03-22 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Thanks for the report. I have corrected this and the fix will be in > PostgreSQL 8.3. Interestingly, we support non-documented option > "append" and "file" too. Surely these should all be pg_strcasecmp? regards, tom lane -

Re: [PATCHES] Re: [DOCS] suggestion for improving TMPDIR and "--format" docs for pg_dump

2007-03-22 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Thanks for the report. I have corrected this and the fix will be in > > PostgreSQL 8.3. Interestingly, we support non-documented option > > "append" and "file" too. > > Surely these should all be pg_strcasecmp? Yep, fixed. -- B

Re: [HACKERS] [PATCHES] xpath_array with namespaces support

2007-03-22 Thread Bruce Momjian
Applying newest version of this patch now; still needs documentation. --- Nikolay Samokhvalov wrote: > On 3/5/07, Nikolay Samokhvalov <[EMAIL PROTECTED]> wrote: > > On 3/4/07, Nikolay Samokhvalov <[EMAIL PROTECTED]> wrote:

Re: [PATCHES] LIMIT/SORT optimization

2007-03-22 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Gr

Re: [PATCHES] Re: [DOCS] suggestion for improving TMPDIR and "--format" docs for pg_dump

2007-03-22 Thread Dave Page
Bruce Momjian wrote: > Thanks for the report. I have corrected this and the fix will be in > PostgreSQL 8.3. Interestingly, we support non-documented option > "append" and "file" too. Append is undocumented as it's intended to be used by pg_dumpall, not directly by users. Regards, Dave.

Re: [PATCHES] Updated Packed Varlena patch v20 (final?)

2007-03-22 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Gr

Re: [PATCHES] Synchronized Scan WIP patch

2007-03-22 Thread Bruce Momjian
Will use '16' rather than '100'. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --

Re: [PATCHES] Re: [DOCS] suggestion for improving TMPDIR and "--format" docs for pg_dump

2007-03-22 Thread Bruce Momjian
Dave Page wrote: > Bruce Momjian wrote: > > > Thanks for the report. I have corrected this and the fix will be in > > PostgreSQL 8.3. Interestingly, we support non-documented option > > "append" and "file" too. > > Append is undocumented as it's intended to be used by pg_dumpall, not > directly

Re: [PATCHES] Re: [DOCS] suggestion for improving TMPDIR and "--format" docs for pg_dump

2007-03-22 Thread Dave Page
Bruce Momjian wrote: > Dave Page wrote: >> Bruce Momjian wrote: >> >>> Thanks for the report. I have corrected this and the fix will be in >>> PostgreSQL 8.3. Interestingly, we support non-documented option >>> "append" and "file" too. >> Append is undocumented as it's intended to be used by pg_d

Re: [PATCHES] xpath_array with namespaces support

2007-03-22 Thread Peter Eisentraut
Nikolay Samokhvalov wrote: > Here is a new version of the patch. I didn't change any part of docs > yet. Since there were no objections I've changed the name of the > function to xmlpath(). I didn't see any discussion about changing the name to xmlpath. Seeing that the function implements xpath,

Re: [PATCHES] xpath_array with namespaces support

2007-03-22 Thread Peter Eisentraut
Bruce Momjian wrote: > Patch applied. This code seems to think that if an xml datum starts with "http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 6: explain analyze is your friend

Re: [PATCHES] xpath_array with namespaces support

2007-03-22 Thread Peter Eisentraut
Nikolay Samokhvalov wrote: > On 3/4/07, Nikolay Samokhvalov <[EMAIL PROTECTED]> wrote: > > I'll fix these issues and extend the patch with resgression tests > > and docs for xpath_array(). I'll resubmit it very soon. > > Here is a new version of the patch. I didn't change any part of docs > yet. Si

Re: [PATCHES] xpath_array with namespaces support

2007-03-22 Thread Peter Eisentraut
Andrew Dunstan wrote: > Would it be better to use some more unlikely name for the dummy root > element used to process fragments than ? Why do we even need to support xpath on fragments? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)-

Re: [PATCHES] guc patch: Make variables fall back to default values

2007-03-22 Thread Bruce Momjian
Is there a new version of this patch being worked on? --- Tom Lane wrote: > Joachim Wieland <[EMAIL PROTECTED]> writes: > > On Tue, Mar 13, 2007 at 11:52:38AM -0400, Tom Lane wrote: > >> Why do you need to tell that? IMHO,

Re: [PATCHES] xpath_array with namespaces support

2007-03-22 Thread Peter Eisentraut
Nikolay Samokhvalov wrote: > Also, maybe someone can suggest better approach for passing namespace > bindings (more convenient than ARRAY[ARRAY[...], ARRAY[...]])? Your code assumes ARRAY[ARRAY['myns', 'myns2'], ARRAY['http://example.com', 'http://example2.com']] Shouldn't it be ARRAY[ARRAY['m

Re: [HACKERS] [PATCHES] xml2 contrib patch supporting default XML namespaces

2007-03-22 Thread Peter Eisentraut
Bruce Momjian wrote: > Your patch has been added to the PostgreSQL unapplied patches list > at: > > http://momjian.postgresql.org/cgi-bin/pgpatches > > It will be applied as soon as one of the PostgreSQL committers > reviews and approves it. I was hoping that we're deprecating contrib/xml2,

Re: [HACKERS] [PATCHES] xml2 contrib patch supporting default XML namespaces

2007-03-22 Thread Bruce Momjian
Peter Eisentraut wrote: > Bruce Momjian wrote: > > Your patch has been added to the PostgreSQL unapplied patches list > > at: > > > > http://momjian.postgresql.org/cgi-bin/pgpatches > > > > It will be applied as soon as one of the PostgreSQL committers > > reviews and approves it. > > I was ho

Re: [PATCHES] simply custom variables protection

2007-03-22 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Pa

Re: [HACKERS] [PATCHES] xml2 contrib patch supporting default XML namespaces

2007-03-22 Thread Dave Page
Bruce Momjian wrote: > Peter Eisentraut wrote: >> I was hoping that we're deprecating contrib/xml2, so I wouldn't add more >> features to it. > > Author states: > >> I understand that XML support is planned and at least partially >> implemented for 8.3, but many production instances will be unab

Re: [PATCHES] simply custom variables protection

2007-03-22 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Your patch has been added to the PostgreSQL unapplied patches list at: > http://momjian.postgresql.org/cgi-bin/pgpatches > It will be applied as soon as one of the PostgreSQL committers reviews > and approves it. This patch was already objected to,

Re: [HACKERS] [PATCHES] xml2 contrib patch supporting default XML namespaces

2007-03-22 Thread Bruce Momjian
Dave Page wrote: > Bruce Momjian wrote: > > Peter Eisentraut wrote: > >> I was hoping that we're deprecating contrib/xml2, so I wouldn't add more > >> features to it. > > > > Author states: > > > >> I understand that XML support is planned and at least partially > >> implemented for 8.3, but man

Re: [PATCHES] simply custom variables protection

2007-03-22 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Your patch has been added to the PostgreSQL unapplied patches list at: > > http://momjian.postgresql.org/cgi-bin/pgpatches > > It will be applied as soon as one of the PostgreSQL committers reviews > > and approves it. > > This pa

Re: [PATCHES] simply custom variables protection

2007-03-22 Thread Bruce Momjian
Patch removed from patch queue. --- Pavel Stehule wrote: > > >"Pavel Stehule" <[EMAIL PROTECTED]> writes: > > > this patch contains function ArmorCustomVariables. This function set > >flag > > > armored on any custom varia

Re: [HACKERS] [PATCHES] xml2 contrib patch supporting default XML namespaces

2007-03-22 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Peter Eisentraut wrote: >> I was hoping that we're deprecating contrib/xml2, so I wouldn't add more >> features to it. > Author states: >> I understand that XML support is planned and at least partially >> implemented for 8.3, but many production insta

Re: [HACKERS] [PATCHES] xml2 contrib patch supporting default XML namespaces

2007-03-22 Thread Mike Rylander
On 3/22/07, Tom Lane <[EMAIL PROTECTED]> wrote: Bruce Momjian <[EMAIL PROTECTED]> writes: > Peter Eisentraut wrote: >> I was hoping that we're deprecating contrib/xml2, so I wouldn't add more >> features to it. > Author states: >> I understand that XML support is planned and at least partially

Re: [PATCHES] Synchronized Scan WIP patch

2007-03-22 Thread Jeff Davis
On Thu, 2007-03-22 at 16:43 -0400, Bruce Momjian wrote: > Will use '16' rather than '100'. > > Your patch has been added to the PostgreSQL unapplied patches list at: > > http://momjian.postgresql.org/cgi-bin/pgpatches > > It will be applied as soon as one of the PostgreSQL committers revie

Re: [PATCHES] Synchronized Scan WIP patchf

2007-03-22 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Je

Re: [PATCHES] LIMIT/SORT optimization

2007-03-22 Thread Alvaro Herrera
Bruce Momjian wrote: > > Your patch has been added to the PostgreSQL unapplied patches list at: > > http://momjian.postgresql.org/cgi-bin/pgpatches > > It will be applied as soon as one of the PostgreSQL committers reviews > and approves it. Did Greg push a version which didn't carry the

Re: [PATCHES] LIMIT/SORT optimization

2007-03-22 Thread Bruce Momjian
Alvaro Herrera wrote: > Bruce Momjian wrote: > > > > Your patch has been added to the PostgreSQL unapplied patches list at: > > > > http://momjian.postgresql.org/cgi-bin/pgpatches > > > > It will be applied as soon as one of the PostgreSQL committers reviews > > and approves it. > > Did Gre

Re: [PATCHES] Heap page diagnostic/test functions (v2)

2007-03-22 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Si

Re: [PATCHES] log_autovacuum

2007-03-22 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Si

Re: [PATCHES] Heap page diagnostic/test functions (v2)

2007-03-22 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Si

Re: [HACKERS] [PATCHES] xml2 contrib patch supporting default XML namespaces

2007-03-22 Thread Peter Eisentraut
Mike Rylander wrote: > A related question, however:  Will the XML features being included in > 8.3 support namespace prefix registration? That is certainly the plan. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)---

Re: [PATCHES] guc patch: Make variables fall back to default values

2007-03-22 Thread Joachim Wieland
On Thu, Mar 22, 2007 at 04:58:09PM -0400, Bruce Momjian wrote: > Is there a new version of this patch being worked on? Yes, I will submit a new version next week. Joachim ---(end of broadcast)--- TIP 5: don't forget to increase your free space m

Re: [HACKERS] [PATCHES] xml2 contrib patch supporting default XML namespaces

2007-03-22 Thread Joshua D. Drake
Peter Eisentraut wrote: > Mike Rylander wrote: >> A related question, however: Will the XML features being included in >> 8.3 support namespace prefix registration? > > That is certainly the plan. Let me bounce my ostrich (sp?) head up here and say, thanks for your work on this Peter. Joshua D.

[PATCHES] Load distributed checkpoint V3

2007-03-22 Thread ITAGAKI Takahiro
Folks, Here is the latest version of Load distributed checkpoint patch. I've fixed some bugs, including in cases of missing file errors and overlapping of asynchronous checkpoint requests. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center checkpoint_v3.patch.gz Description: Binary

[PATCHES] Fix pg_wchar_tbl.maxmblen

2007-03-22 Thread ITAGAKI Takahiro
Hello, I found wrong definitions of max bytes for a char in EUC_CN (3->2), EUC_TW (3->4) and MULE_INTERNAL (3->4). Especially, EUC_TW and MULE_INTERNAL might cause problems. Their pg_*_mblen could have returned values larger than their maxmblen. I'm worrying that it leads buffer overrun. Index:

Re: [PATCHES] Fix pg_wchar_tbl.maxmblen

2007-03-22 Thread ITAGAKI Takahiro
ITAGAKI Takahiro <[EMAIL PROTECTED]> wrote: > I found wrong definitions of max bytes for a char in > EUC_CN (3->2), EUC_TW (3->4) and MULE_INTERNAL (3->4). Also, the length of a char in GB18030 could be 4, though GB18030 is not supported as a server encoding. - {0, pg_gb18030_mblen, pg_gb

[PATCHES] Cleanup to procarray.c

2007-03-22 Thread Bruce Momjian
I have applied the following cleanup to procarray.c. -- Bruce Momjian <[EMAIL PROTECTED]> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + Index: src/backend/storage/ipc/procarray