[PATCHES] NLS: swedish

2003-10-09 Thread Dennis Bjorklund
I've not had time to translate everything yet, but here is what i've got now. I would like it to be commited. Two of the files are complete, the last strings I hope I will have time to complete before the release, but who knows. I'm in a busy period wrt my work so I don't know if I will make

Re: [Fwd: [PATCHES] Make psql use all pretty print options]

2003-10-09 Thread Dennis Bjorklund
On Thu, 9 Oct 2003, Bruce Momjian wrote: Uh, I can't apply this to 7.4 unless you can get others to agree it should be added. Sorry. It looks like the patch changes translated strings which isn't supposed to happen. It can of course still be accepted, that's not my call. ps. Unified diffs

Re: [PATCHES] NLS: Swedish update of psql.po

2003-10-25 Thread Dennis Bjorklund
On Sat, 18 Oct 2003, Dennis Bjorklund wrote: All strings in the swedish psql.po have been translated. The above have not been commited. I also see on the translate page that pg_dump is now at 99%, it was at a beautiful 100% before.. Is it possible to get cvs access, with say a promise that I

Re: [PATCHES] fork/exec patch

2003-12-14 Thread Dennis Bjorklund
On Sun, 14 Dec 2003, Bruce Momjian wrote: change to the code. We already have a GUC write of non-default values for exec and no one had issues with that. Of course, this one is per-backend. Yea, we could use shared memory for this too, but I don't see a problem with using the file

Re: [PATCHES] fork/exec patch

2003-12-14 Thread Dennis Bjorklund
On Sun, 14 Dec 2003, Bruce Momjian wrote: Why not use an anonymous pipe to send data from the parent to the child process? Doesn't that require the postmaster to stay around to feed that information into the pipe or can the postmaster just shove the data and continue on, and how do the

Re: [PATCHES] fork/exec patch

2003-12-14 Thread Dennis Bjorklund
On Mon, 15 Dec 2003, Claudio Natoli wrote: Moreover, in general, how do we handle things like this? IMHO, I'd rather live with a few kludges (that don't impact the *nix code) until the Windows port is actually a reality As long as it does not hurt the unix code it's not a big problem as I see

[PATCHES] String not marked for translation

2004-01-11 Thread Dennis Bjorklund
I've found a string not marked for translation. -- /Dennis Björklund Index: src/bin/psql/describe.c === RCS file: /cvsroot/pgsql-server/src/bin/psql/describe.c,v retrieving revision 1.91 diff -u -c -r1.91 describe.c ***

Re: [PATCHES] Patch to bring \copy syntax more in line with SQL copy

2004-01-21 Thread Dennis Bjorklund
On Wed, 21 Jan 2004, Peter Eisentraut wrote: Am Mittwoch, 21. Januar 2004 02:16 schrieb Bill Moran: BTW: Why is this frowned apon so? Are there compilers that have problems with it? Yes. Search the archives for AIX. :-) I googled a little for the aix compiler and it looks like it

[PATCHES] Show function parameter names in information schema

2004-01-22 Thread Dennis Bjorklund
This small patch updates the information schema to show function parameter names when they exist. -- /Dennis Björklund Index: doc/src/sgml/information_schema.sgml === RCS file:

Re: [PATCHES] reading uninitialized buffer

2004-02-01 Thread Dennis Bjorklund
On Sun, 1 Feb 2004, Andrew Dunstan wrote: As for the test being outside the if statement, it is true that that might waste a few cycles, but it hardly matters. The cycles are not important. My fix wasn't the most optimized either if one should count cycles. It was terminating the string twice

Re: [PATCHES] Fix doc for initcap

2004-02-26 Thread Dennis Bjorklund
On Thu, 26 Feb 2004, Neil Conway wrote: The improved text is still wrong: initcap() no longer uses whitespace to separate words. Aha, I didn't know the function had changed at all. How does it work with respect to the locale? When you say that a word is a sequence of alphanum characters,

[PATCHES] Doc for ltrim and rtrim

2004-03-04 Thread Dennis Bjorklund
The doc for the trim functions does not say that the second argument can be omitted. This patch fixes it. It also fixes that the type text was not wrapped as typetext/type. I can not build the docs myself, but i'm pretty sure it's correct. Is it okay to commit this? Should I do it on the 7.4

Re: [PATCHES] numeric input changes

2004-03-10 Thread Dennis Bjorklund
On Wed, 10 Mar 2004, Tom Lane wrote: nconway=# select 'Infinity'::float8; ERROR: type double precision value out of range: overflow This works in 7.4 and older releases. Sounds to me like you broke it. It does not work on 7.3 and 7.4 when I try. Looking at the currect cvs code it's not

Re: [PATCHES] Defining a tinyint data type - one byte unsigned

2004-03-10 Thread Dennis Bjorklund
On Thu, 11 Mar 2004, Shachar Shemesh wrote: It's a bit strange that this int is unsigned and the others are signed. Not that strange if you consider the fact that making it signed will not leave much room for actually using it. In any case, that's just the way it is:

[PATCHES] Add argument name to CREATE FUNCTION documentation

2004-06-24 Thread Dennis Bjorklund
It's not much text, but someone who speaks english might want to look at it. If it's okay I can commit. -- /Dennis Björklund Index: doc/src/sgml/ref/create_function.sgml === RCS file:

Re: [PATCHES] Add argument name to CREATE FUNCTION documentation

2004-06-24 Thread Dennis Bjorklund
On Thu, 24 Jun 2004, Tom Lane wrote: 1. We usually leave spaces around brackets in syntax definitions, so I'd go for ... [ argname ] ... not ... [argname] ... I saw both in that very rule (later there is an [EXTERNAL]) so I guessed that one use what looks best at different places. But

[PATCHES] Strings not possible to translate

2004-06-27 Thread Dennis Bjorklund
Here is a trivial fix for some error messages that was not translated before. I've also gotten rid of some cut and paste of strings. That doesn't always work (like in this case) when translating. -- /Dennis Björklund ---(end of broadcast)--- TIP

[PATCHES] psql schema permissions

2004-06-30 Thread Dennis Bjorklund
There is no way to show schema permissions in psql. The alternatives are: 1) A new \dpn command 2) Extend \dp to also show rights for schemas, but then we need an extra column to describe what kind of object it is, and it would mess up the pattern stuff. 3) Do nothing and let

Re: [PATCHES] psql schema permissions

2004-06-30 Thread Dennis Bjorklund
On Wed, 30 Jun 2004, Kris Jurka wrote: There is no way to show schema permissions in psql. 4) Since \dn only shows the name and the owner we can simply add a permission column. Someone requested that \dn+ also show the comment for the schema, if you're messing around in that

Re: [PATCHES] psql schema permissions

2004-07-02 Thread Dennis Bjorklund
On Fri, 2 Jul 2004, Peter Eisentraut wrote: You could extend \z (don't know where that name came from) so that \zX show the permissions for things that \dX displays. Yes, that was number 1) on the list 1) A new \dpn command \dp and \z is the same thing. Any solution works for me. The

Re: [PATCHES] [HACKERS] UNICODE characters above 0x10000

2004-08-07 Thread Dennis Bjorklund
On Sat, 7 Aug 2004, Tom Lane wrote: shy of a load --- for instance I see that pg_utf_mblen thinks there are no UTF8 codes longer than 3 bytes whereas your code goes to 4. I'm not an expert on this stuff, so I don't know what the UTF8 spec actually says. But I do think you are fixing the

Re: [PATCHES] [HACKERS] UNICODE characters above 0x10000

2004-08-07 Thread Dennis Bjorklund
On Sat, 7 Aug 2004, Tom Lane wrote: question at hand is whether we can support 32-bit characters or not --- and if not, what's the next bug to fix? True, and that's hard to just give an answer to. One could do some simple testing, make sure regexps work and then treat anything else that might

Re: [PATCHES] [HACKERS] UNICODE characters above 0x10000

2004-08-07 Thread Dennis Bjorklund
On Sat, 7 Aug 2004, John Hansen wrote: should not allow them to be stored, since there might me someone using the high ranges for a private character set, which could very well be included in the specification some day. There are areas reserved for private character sets. -- /Dennis

Re: [PATCHES] [HACKERS] UNICODE characters above 0x10000

2004-08-07 Thread Dennis Bjorklund
On Sat, 7 Aug 2004, Tatsuo Ishii wrote: More seriously, Unicode is filled with tons of confusion and inconsistency IMO. Remember that once Unicode adovocates said that the merit of Unicode was it only requires 16-bit width. Now they say they need surrogate pairs and 32-bit width chars...

[PATCHES] pg_controldata usage

2004-09-18 Thread Dennis Bjorklund
Today pg_controldata --help gives this usage info: | Usage: | pg_controldata [OPTION] | | Options: | DATADIRshow cluster control information for DATADIR | --help show this help, then exit | --version output version information, then exit | | If no data directory is

[PATCHES] lastval()

2005-05-08 Thread Dennis Bjorklund
Here is a small patch that implements a function lastval() that works just like currval() except that it give the current value of the last sequence used by nextval(). Using this function one can do: # CREATE TABLE abc (a serial, b int); CREATE TABLE # SELECT lastval(); ERROR: nextval have not

Re: [PATCHES] lastval()

2005-05-08 Thread Dennis Bjorklund
On Sun, 8 May 2005, Tom Lane wrote: Why is that a good idea? In a complex application it'd be awfully easy to break logic that depends on such a thing. Of course it can break. currval() can also break in a complex application with triggers and rules that do things the developer does not

Re: [PATCHES] lastval()

2005-05-08 Thread Dennis Bjorklund
On Sun, 8 May 2005, Tom Lane wrote: Like, say, the sequence being deleted before the lastval call? Then you get an error message. Same thing if you have revoked the rights on the sequence before you call lastval(). In this case you can get a value that belong to a sequence that is deleted. Is

Re: [PATCHES] lastval()

2005-06-04 Thread Dennis Bjorklund
On Thu, 2 Jun 2005, Neil Conway wrote: Here is a small patch that implements a function lastval() that Have you had a chance to respin this patch per my earlier comments on the implementation, Dennis? I've been spending my free time on another project and I don't multitask very well :-)

Re: [PATCHES] lastval()

2005-06-05 Thread Dennis Bjorklund
On Thu, 19 May 2005, Neil Conway wrote: +errmsg(currval of sequence with OID %d is not yet defined in this session, + last_used_seq-relid))); See above; however, when will this error actually be invoked? (The

[PATCHES] I have a non-ascii name.

2005-12-05 Thread Dennis Bjorklund
listitem para ! Allow function parameters to be declared with names (Dennis Bjorklund) /para para This allows better documentation of functions. Whether the names --- 4236,4242 listitem para ! Allow function parameters

[PATCHES] setseed() doc

2006-09-04 Thread Dennis Bjorklund
The doc doesn't state in what range the argument to setseed() should be. Some tests suggest that only values in the range -1.0 to 1.0 work as a seed and values outside of that give the same sequence of random numbers. I've attached a trivial one line patch (this is the patch list after all),

Re: [PATCHES] setseed() doc

2006-09-04 Thread Dennis Bjorklund
Tom Lane skrev: entryliteralfunctionsetseed/function(typedp/type)/literal/entry entrytypeint/type/entry - entryset seed for subsequent literalrandom()/literal calls/entry + entryset seed for subsequent literalrandom()/literal calls (value between -1.0 and

Re: [PATCHES] UTF8MatchText

2007-05-20 Thread Dennis Bjorklund
Tom Lane skrev: You could imagine trying to do % a byte at a time (and indeed that's what I'd been thinking it did) but that gets you out of sync which breaks the _ case. It is only when you have a pattern like '%_' when this is a problem and we could detect this and do byte by byte when it's