Re: [HACKERS] [PATCHES] Backend SSL configuration enhancement

2006-09-07 Thread Martijn van Oosterhout
aight into CVS at which point it'll be in the next release. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each according to his ability to > litigate. signature.asc Description: Digital signature

Re: [PATCHES] [HACKERS] Fix linking of OpenLDAP libraries

2006-09-08 Thread Martijn van Oosterhout
=> returns -lpq pg_config --static-link=> returns -lpq That way only people who actually want static linking need be bothered. Have a ncie day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each according to his ability to > litigate. signature.asc Description: Digital signature

Re: [PATCHES] [HACKERS] Fix linking of OpenLDAP libraries

2006-09-11 Thread Martijn van Oosterhout
ake static linking, because the same treatment will have to apply to -lssl, -lcrypto, -lkrb5, -lk5crypto and quite possibly others. Do we really want to go there? Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each

Re: [HACKERS] [PATCHES] Patch for UUID datatype (beta)

2006-09-18 Thread Martijn van Oosterhout
then you have to get it in the same second. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each according to his ability to > litigate. signature.asc Description: Digital signature

Re: [PATCHES] [HACKERS] Numeric overflow problem + patch

2006-09-28 Thread Martijn van Oosterhout
scale 4 must *round to* an absolute value less than 1 Since that more accurately describes the actual problem. Have a ncie day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each according to his ability to > litigate. signature.asc Description: Digital signature

Re: [HACKERS] [PATCHES] array_accum aggregate

2006-10-13 Thread Martijn van Oosterhout
presentation of. The name "internal" would be nice, but it's taken :( Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each according to his ability to > litigate. signature.asc Description: Digital signature

Re: [HACKERS] [PATCHES] Bug in WAL backup documentation

2006-11-03 Thread Martijn van Oosterhout
the code, but does > anyone have a contrary opinion? Arguably you could give people a choice, say %P for the absolute path and %p for the relative one. In Unix you can easily prepend $PWD to the string, but I don't know how easy that is in Windows. Have a nice day, -- Martijn van Oosterhout

Re: [HACKERS] [PATCHES] Bug in WAL backup documentation

2006-11-08 Thread Martijn van Oosterhout
ux getcwd doesn't have that problem for example. Should probably dig up some documention on which systems would be affected by this. Have a ncie day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each according to his ability to > litigate. signature.asc Description: Digital signature

Re: [HACKERS] [PATCHES] Bundle of patches

2006-12-04 Thread Martijn van Oosterhout
On Mon, Dec 04, 2006 at 01:35:21PM -0500, Tom Lane wrote: > > 3) Allow to use index for IS [NOT] NULL > >http://www.sigaev.ru/misc/indexnulls_82-0.6.gz > >Initially patch was developed by Martijn van Oosterhout > > . > >But it's reworked and sup

Re: [HACKERS] [PATCHES] Bundle of patches

2006-12-04 Thread Martijn van Oosterhout
ch where the arguments to the typmod_in function determine the types required. This allows the system to do proper checking and casting and most important of all, good error messages, eg: ERROR: Invalid argument to type: must be one of numeric(), numeric(integer), numeric(integer, integer) Ha

Re: [HACKERS] [PATCHES] Enums patch v2

2006-12-20 Thread Martijn van Oosterhout
st I/O functions that are the issue, consider the enum-to-integer cast. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each according to his ability to > litigate. signature.asc Description: Digital signature

Re: [HACKERS] [PATCHES] SGML index build fix

2007-01-07 Thread Martijn van Oosterhout
ed to be rerun. In any case it seems a much better approach to simply run it again when needed rather than printing a warning. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each according to his ability to > litigate. signature.asc Description: Digital signature

Re: [HACKERS] [PATCHES] COPY with no WAL, in certain circumstances

2007-01-07 Thread Martijn van Oosterhout
er is going to commit the transaction after the COPY is complete. Could they run analyze or vacuum or some other DDL command on the table that would get confused by the disparity between the hint bits and the xlog. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From

Re: [pgsql-patches] [HACKERS] [PATCHES] wal_checksum = on (default) | off

2007-01-12 Thread Martijn van Oosterhout
AL is known to be accurate. The WAL does not protect against random data corruption, in normal operation it is never read. If we want to detect random corruption, we'd need checksum everywhere, yes. But that's not the goal here. Have a nice day, -- Martijn van Oosterhout htt

Re: [PATCHES] [HACKERS] Arrays of Complex Types

2007-04-09 Thread Martijn van Oosterhout
array name would be kept internal and hidden from the user, just that it would exist after that command. What possible reason is there for allowing the user to give the array type a name? Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to h

Re: [PATCHES] [HACKERS] Arrays of Complex Types

2007-04-09 Thread Martijn van Oosterhout
ve them names if we wanted... > At any rate, the point of the remark was to take this off the table for now. Sure, once the array types are created automatically the command becomes completely redundant. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each a

[PATCHES] 5 new entries for FAQ

2005-08-10 Thread Martijn van Oosterhout
something about collation and locales but I'm sure sure I understand them myself. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing 5% of the work and then sitting around waiting

Re: [PATCHES] 5 new entries for FAQ

2005-08-10 Thread Martijn van Oosterhout
On Wed, Aug 10, 2005 at 11:17:40AM -0400, Alvaro Herrera wrote: > On Wed, Aug 10, 2005 at 10:04:23AM +0200, Martijn van Oosterhout wrote: > > > Comments welcome. I can write more, if people can suggest things to > > write about. I was thinking something about collation and l

Re: [PATCHES] 5 new entries for FAQ

2005-08-11 Thread Martijn van Oosterhout
On Wed, Aug 10, 2005 at 10:04:22AM +0200, Martijn van Oosterhout wrote: > After going through pgsql-general a bit I figured there were a few > important questions missing from the FAQ, so I wrote some. Given the additions to the FAQ and suggestions made by Bruce about how often the question

[PATCHES] [PATCH] Changing second argument to type input function

2005-08-12 Thread Martijn van Oosterhout
://archives.postgresql.org/pgsql-hackers/2005-08/msg00331.php This basically came about because currently there is no easy way for an input function to determine what type it's supposed to return. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% ins

[PATCHES] [PATCH] Clarify issues with SPI and C language function limitations

2005-08-13 Thread Martijn van Oosterhout
rifies when the get_fn_expr_rettype() and get_fn_expr_argtype() functions can actually provide the information requested. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing 5%

[PATCHES] [PATCH] Proposed: Have SPI_connect fail if there is no current snapshot

2005-08-13 Thread Martijn van Oosterhout
d document that to avoid future surprises. At least until the issue of non-immutable type input functions has been sorted out. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing 5%

Re: [PATCHES] [PATCH] Proposed: Have SPI_connect fail if there is no current snapshot

2005-08-14 Thread Martijn van Oosterhout
shot rules. In that case it may be better to document the failure case in SPI_exec. -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing 5% of the work and then sitting around waiting for someone >

Re: [PATCHES] [PATCH] Clarify issues with SPI and C language function limitations

2005-08-14 Thread Martijn van Oosterhout
On Sat, Aug 13, 2005 at 06:27:29PM -0400, Tom Lane wrote: > Martijn van Oosterhout writes: > > The second clarifies when the get_fn_expr_rettype() and > > get_fn_expr_argtype() functions can actually provide the information > > requested. > > Except it doesn't

[PATCHES] For review: Initial support for COLLATE

2005-09-07 Thread Martijn van Oosterhout
x27;) < text('B') COLLATE 'C', text('a') < text('B') COLLATE 'en_US.UTF-8'; ?column? | ?column? --+-- f| t (1 row) test=# SELECT text('A') < text('b') COLLATE 'C', text('A

Re: [PATCHES] For review: Initial support for COLLATE

2005-09-07 Thread Martijn van Oosterhout
CU. They both provide collate order *and* date/time formats *and* number formatting. Pretending they're seperate is silly. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing

Re: [PATCHES] For review: Initial support for COLLATE

2005-09-07 Thread Martijn van Oosterhout
On Thu, Sep 08, 2005 at 12:04:42AM +0200, Peter Eisentraut wrote: > Martijn van Oosterhout wrote: > > Look at the POSIX interface, look at ICU. They both provide collate > > order *and* date/time formats *and* number formatting. Pretending > > they're seperate is sill

Re: [PATCHES] For review: Initial support for COLLATE

2005-09-08 Thread Martijn van Oosterhout
On Thu, Sep 08, 2005 at 07:00:08PM +0200, Peter Eisentraut wrote: > Martijn van Oosterhout wrote: > > To support COLLATE PostgreSQL's locale support needs to be upgraded > > and made more flexible. This is not a surprise. Anything that doesn't > > use the new interfa

[PATCHES] [PATCH] Add support for IS NULL to btree indexes

2005-09-19 Thread Martijn van Oosterhout
..5.84 rows=6 width=44) (actual time=0.044..1.442 rows=250 loops=1) Index Cond: (t = NULL::text) Filter: (t IS NULL) Total runtime: 2.279 ms (4 rows) -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a >

Re: [PATCHES] [PATCH] Add support for IS NULL to btree indexes

2005-09-20 Thread Martijn van Oosterhout
ires explicitly representing IS NULL/IS NOT NULL > as distinct kinds of scankey. Well, this patch has a kind for IS NULL. It does have issues with other indexes, but there's no point working on that until there is a possibility of acceptance. The purpose was to demonstrate that it is trivia

[PATCHES] [PATCH] Indexing IS (NOT) NULL for btrees

2005-09-21 Thread Martijn van Oosterhout
bably better use of statistics. It's messier because now more places need to know about it, but functionalitywise it's like the last one. For the archive: http://svana.org/kleptog/pgsql/indexnulls3.diff -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5%

Re: [PATCHES] [HACKERS] \x output blowing up

2005-09-27 Thread Martijn van Oosterhout
his stage of beta. It is, IMHO, the much better solution. Thanks for the fix. -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing 5% of the work and then sitting around waiting for someone > e

[PATCHES] [PATCH] Using pread instead of lseek (with analysis)

2005-10-08 Thread Martijn van Oosterhout
5903 pread 0.700.002326 122 19 write 0.620.002032 406 5 fsync -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing 5% of

Re: [PATCHES] [PATCH] Using pread instead of lseek (with analysis)

2005-10-08 Thread Martijn van Oosterhout
ational latency of a hard disk read. I satisfied my curiosity and showed it just isn't worth it at this point. -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing 5% of the work and then sitt

Re: [PATCHES] [PATCH] Using pread instead of lseek (with analysis)

2005-10-10 Thread Martijn van Oosterhout
On Sun, Oct 09, 2005 at 12:19:57AM +0200, Martijn van Oosterhout wrote: > > It would be reasonable to check results in fully-cached cases, which > > would be the best real-world scenario for this to show any improvement > > in. > > If you look, I did that and even then

[PATCHES] [PATCH] Symbol restriction and versioning

2005-10-18 Thread Martijn van Oosterhout
ifferentiation. It's not like we're trying to provide any kind of backward compatability at that level. This patch will work on any system using GNU ld and where the system dynamic linker supports versioned symbols. The only one I'm sure of is Linux but others are easily added. Tha

[PATCHES] [PATCH] Fix Ctrl-C related issues in psql (not for 8.1)

2005-10-22 Thread Martijn van Oosterhout
rything nicely. The question of ignoring SIGINT while the pager is active is orthoginal, this patch doesn't address that at all. Any comments on coding style and/or side-effects of this patch, don't hesitate to forward to me. Also available at: http://svana.org/kleptog/pgsql/psql-ctrlc.

[PATCHES] [PATCH] Provide option to clients to enable coredump

2005-10-28 Thread Martijn van Oosterhout
ave a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing 5% of the work and then sitting around waiting for someone > else to do the other 95% so you can sue them. Index: src/back

[PATCHES] [PATCH] Formatting patch for psql

2005-11-17 Thread Martijn van Oosterhout
output unambiguous. Also available at: http://svana.org/kleptog/pgsql/psql-format.patch Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing 5% of the work and then sitting around w

Re: [PATCHES] [HACKERS] Should libedit be preferred to libreadline?

2005-11-22 Thread Martijn van Oosterhout
exporting memcpy that it's quite possible other binaries might be affected. Maybe create a BACKEND_LIBS which contains a shorter list. Even the GCC --as-needed flag can't save you from libs exporting functions they shouldn't... Have a nice day, -- Martijn van Oosterhout http

Re: [PATCHES] [PATCH] Formatting patch for psql

2005-11-24 Thread Martijn van Oosterhout
On Thu, Nov 24, 2005 at 03:45:12PM +0100, Peter Eisentraut wrote: > Martijn van Oosterhout wrote: > > Here is my patch to make psql handle multi-line output sanely. > > Instead of embedded newlines splattering your output across the > > screen, everything gets indente

Re: [PATCHES] [PATCH] Formatting patch for psql

2005-11-24 Thread Martijn van Oosterhout
charset that has ASCII as a subset. Unless someone can say that every single-byte encoding we support has an ASCII subset (EBCDIC being the obvious counter-example for not supported encodings) then I think we have to stick to enumerating them. Have a nice day, -- Martijn van Oosterhout http://s

Re: [PATCHES] [PATCH] Formatting patch for psql

2005-11-24 Thread Martijn van Oosterhout
On Thu, Nov 24, 2005 at 11:35:11PM +0100, Peter Eisentraut wrote: > Martijn van Oosterhout wrote: > > On Thu, Nov 24, 2005 at 03:45:12PM +0100, Peter Eisentraut wrote: > > > Shouldn't you use PQmblen() to determine whether an encoding is > > > single-byte, rathe

Re: [PATCHES] [PATCH] Formatting patch for psql

2005-11-25 Thread Martijn van Oosterhout
On Thu, Nov 24, 2005 at 09:23:55PM -0500, Tom Lane wrote: > Martijn van Oosterhout writes: > > And what I'm saying is that you can only do that if all single byte > > encodings are ASCII compatable and I'm not prepared to say that... > > psql already assumes tha

Re: [PATCHES] [PATCH] Formatting patch for psql

2005-11-25 Thread Martijn van Oosterhout
On Fri, Nov 25, 2005 at 09:58:21AM -0500, Tom Lane wrote: > Martijn van Oosterhout writes: > > ... There is a fair > > bit of encoding code in there already but the information you need here > > is specifically: is this char a control character and in particular, is >

Re: [PATCHES] [PATCH] Formatting patch for psql

2005-11-25 Thread Martijn van Oosterhout
On Fri, Nov 25, 2005 at 11:08:45AM -0500, Tom Lane wrote: > Martijn van Oosterhout writes: > > Would people prefer a patch that brought the libpq routines up to > > scratch and have mbprint use that? > > I would. ACK. Will look into it. -- Martijn van Oosterhout htt

[PATCHES] [PATCH] psql formatting patch (round 2)

2005-11-26 Thread Martijn van Oosterhout
haracters in the string it's trying to print... Patch available at: http://svana.org/kleptog/pgsql/psql-format.patch Comments welcome, Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a >

[PATCHES] [PATCH] Reduce dependancies of postmaster (without --as-needed)

2005-11-27 Thread Martijn van Oosterhout
someone with such a platforn should do it. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing 5% of the work and then sitting around waiting for someone > else to do the other 9

Re: [PATCHES] Reduce dependancies of postmaster (without --as-needed)

2005-11-28 Thread Martijn van Oosterhout
On Sun, Nov 27, 2005 at 06:30:59PM -0300, Alvaro Herrera wrote: > Martijn van Oosterhout wrote: > > > Attached is a patch which applies this filtering to the backend and has > > the same results as linking with --as-needed. I basically took the > > filter list of libpq a

Re: [PATCHES] Reduce dependancies of postmaster (without --as-needed)

2005-11-28 Thread Martijn van Oosterhout
ies make upgrading systems unnecessarily complicated due to libs like libpq pulling in specific versions of libs that conflict with libraries used by the program using libpq. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% persp

Re: [PATCHES] Reduce dependancies of postmaster (without --as-needed)

2005-11-28 Thread Martijn van Oosterhout
ls are from -ldl and -lcrypt. This would provide a solid base on which to make improvements. Thanks in advance, -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing 5% of the work and then sitting aro

Re: [PATCHES] Reduce dependancies of postmaster (without --as-needed)

2005-11-28 Thread Martijn van Oosterhout
On Mon, Nov 28, 2005 at 09:01:11PM +0100, Martijn van Oosterhout wrote: > Regarding the restrictions for backend libs, consider the attached > patch. It just filters out anything readline related. Threading LIBS > are not in the LIBS variable at all. Sorry, forgot the attachment. -- Ma

Re: [PATCHES] Reduce dependancies of postmaster (without --as-needed)

2005-11-28 Thread Martijn van Oosterhout
the linker though. That's why on most systems you can say -lreadline and not worry about whether it uses curses or termcap. And in any case, if it's only libsocket it that needs and we don't use any symbols in it ourselves, then we surely don't need to reference it. That's pu

Re: [PATCHES] Reduce dependancies of postmaster (without --as-needed)

2005-11-29 Thread Martijn van Oosterhout
t symbols are actually in the libs in question we can refine the autoconf setup. Thanks in advance, -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing 5% of the work and then sitting around waiting

Re: [PATCHES] Reduce dependancies of postmaster (without --as-needed)

2005-11-29 Thread Martijn van Oosterhout
of thing. > -lPW was added "for SCO support" in 1997: > http://developer.postgresql.org/cvsweb.cgi/pgsql/src/Attic/configure.in.diff?r1=1.64;r2=1.65 Ok, I've added it to the platforms/libraries dependancies list I'm compiling. I've got all the relevent info from the old

Re: [PATCHES] Allow an alias for the target table in UPDATE/DELETE

2006-01-22 Thread Martijn van Oosterhout
ying on file order to resolve this, appropriate use of %prec would have the same effect (just like for operator precedence). The output file tell you which way bison went. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% per

Re: [PATCHES] Allow an alias for the target table in UPDATE/DELETE

2006-01-22 Thread Martijn van Oosterhout
y applies > to shift/reduce conflicts anyway). But that's the point of the %prec directive. To force bison to choose one or the other, thus removing the warning... For an ambiguity that only appears in one statement, it seems a better solution than upgrade SET to a new class of ide

Re: [PATCHES] [COMMITTERS] pgsql: Allow psql multi-line column values to align

2006-02-10 Thread Martijn van Oosterhout
mitted this patch so long ago I figured it'd gotten lost. I was actually considering preparing a new version against HEAD. I'll try to address these warnings (unless someone beats me to it). -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspirati

Re: [PATCHES] [COMMITTERS] pgsql: Allow psql multi-line column values to align

2006-02-10 Thread Martijn van Oosterhout
On Fri, Feb 10, 2006 at 12:09:13PM -0500, Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian writes: > > > Martijn van Oosterhout wrote: > > >> I'll try to address these warnings (unless someone beats me to it). > > > > > I am looking a

Re: [PATCHES] [COMMITTERS] pgsql: Allow psql multi-line column values to align

2006-02-10 Thread Martijn van Oosterhout
On Fri, Feb 10, 2006 at 06:16:07PM +0100, Martijn van Oosterhout wrote: > Thanks for the tip. I'm currently merging CVS with my version and > getting a lot of conflicts (whitespace variations). > > It's fairly simple changes AFAICS. Just need to fix the declarations of &g

Re: [PATCHES] [COMMITTERS] pgsql: Allow psql multi-line column values to align

2006-02-10 Thread Martijn van Oosterhout
ing any public interfaces. ie the libpq interface remains unsigned, as does the psql formatting code, but the printTable stuff only is for the parts that actually do formatting... Patch attached. Passes -pedantic on gcc 3.3.5 Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog

Re: [PATCHES] [HACKERS] Spaces in psql output (Was: FW: PGBuildfarm member snake Branch HEAD Status changed)

2006-02-11 Thread Martijn van Oosterhout
ine is messy. OTOH, some people discourage the use of ?: but I prefer it to a whole if statement. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing 5% of the work and then sitt

Re: [PATCHES] [HACKERS] Spaces in psql output (Was: FW: PGBuildfarm member snake Branch HEAD Status changed)

2006-02-12 Thread Martijn van Oosterhout
On Sat, Feb 11, 2006 at 10:42:59PM -0500, Tom Lane wrote: > Martijn van Oosterhout writes: > > Well, the attached patch removes the padding on the last column, > > irrespective of the line. It will pad all the way to the end if the > > cell is empty due to one of the

[PATCHES] [PATCH] WIP: Create shell-types explicitly

2006-02-20 Thread Martijn van Oosterhout
des documentation updates. Does not include regression tests, yet. Comments? http://svana.org/kleptog/pgsql/shell.diff -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing 5% of the work and the

Re: [PATCHES] [PATCH] WIP: Create shell-types explicitly

2006-02-20 Thread Martijn van Oosterhout
On Mon, Feb 20, 2006 at 10:13:39AM -0500, Tom Lane wrote: > Martijn van Oosterhout writes: > > The first line creates public.text, but the drop tries to delete > > pg_catalog.text. > > This is not particularly specific to (or relevant to) shell types. So this is not a

[PATCHES] [PATCH] Explicit shell types

2006-02-21 Thread Martijn van Oosterhout
regression tests and here is the patch for inclusion. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing 5% of the work and then sitting around waiting for someone > else to do t

Re: [PATCHES] [HACKERS] how solve diff of API counstruct_md_array between

2006-02-28 Thread Martijn van Oosterhout
riting plug-ins. Attached. I like it. Arguably the development period between 8.1 and 8.2 could be designated 80190 (8.1.90) with various betas being 80191-80199. But hey, having any symbol define the current version is better than nothing at all. Thanks for this, -- Martijn van Oosterhout h

Re: [PATCHES] Proposed patch for error locations

2006-03-13 Thread Martijn van Oosterhout
seNode function, you may be able to avoid changing a lot of code down the line. Finally, is the count in characters or bytes (w.r.t. multibyte encodings)? Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration.

[PATCHES] [PATCH] Remove useless DH param code on client side

2006-04-11 Thread Martijn van Oosterhout
de. Have a nice day, [1] http://www.openssl.org/docs/ssl/SSL_CTX_set_tmp_dh_callback.html# [2] http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/fe-secure.c#rev1.2 [3] http://www.gnu.org/software/gnutls/reference/gnutls-gnutls.html#gnutls-dh-params-generate2 -- Martijn van

Re: [PATCHES] [PATCH] Remove useless DH param code on client side

2006-04-12 Thread Martijn van Oosterhout
On Wed, Apr 12, 2006 at 10:00:29AM -0400, Tom Lane wrote: > Martijn van Oosterhout writes: > > It's not clear why the code was added in the first place, > > I thought it was there to support client-side authentication (ie, > verifying the server's certificate). We do

[PATCHES] [PATCH] Reduce noise from tsort

2006-04-15 Thread Martijn van Oosterhout
Tiny patch to Makefile.shlib to reduce noise created by tsearch. All it does is remove duplicates. The behaviour itself is not changed. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > to

[PATCHES] [PATCH] Fix declaration of PQgetssl

2006-04-15 Thread Martijn van Oosterhout
Here's the tiny patch so libpq users don't have to include the openssl headers in their programs. -- Martijn van Oosterhout http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing 5% of the work and then sitting ar

Re: [PATCHES] [PATCH] Reduce noise from tsort

2006-04-15 Thread Martijn van Oosterhout
On Sat, Apr 15, 2006 at 12:12:53PM -0400, Tom Lane wrote: > Martijn van Oosterhout writes: > > Tiny patch to Makefile.shlib to reduce noise created by tsearch. All it > > does is remove duplicates. The behaviour itself is not changed. > > What cases exactly does that fix ..

Re: [PATCHES] [BUGS] bug in windows xp

2006-04-19 Thread Martijn van Oosterhout
the integer divide, I hope one of the others will trigger... For UNIX systems I've made it try kill() first, that seems the most reliable. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each according to his ability to >

[PATCHES] Two coverity non-bugs

2006-04-19 Thread Martijn van Oosterhout
ode is designed to never allow it to be NULL. Currently they've fixed the bogus errors relating to elog(), but not yet the ones relating to ereport(). There's still mountains of crap to wade through and not a single real bug found yet. Have a nice day, -- Martijn van Oosterhout

Re: [PATCHES] [BUGS] bug in windows xp

2006-04-19 Thread Martijn van Oosterhout
On Wed, Apr 19, 2006 at 10:15:54AM -0400, Tom Lane wrote: > Martijn van Oosterhout writes: > > Not that I know of. However, the first step is to add this regression > > test for SIGFPE [-patches CCed]. > > This seems completely pointless. The question is not about whether

Re: [PATCHES] Two coverity non-bugs

2006-04-19 Thread Martijn van Oosterhout
2205). It's me who misinterpreted the fix. We should probably be adding checks to all the strdups and to line 2205 instead. It doesn't directly complain about strdup itself because nowhere does any code do a strdup and dereference it in the same function. Have a nice day, -- Martijn van O

[PATCHES] [PATCH] Tiny memleak in libpq

2006-04-19 Thread Martijn van Oosterhout
Small memory leak in PQprintTuples(). This one found by Coverity. (Finally found one). -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each according to his ability to > litigate. Index: src/interfaces/libpq/fe-p

Re: [PATCHES] Cleaning up multiply-defined-symbol warnings on OS X

2006-04-29 Thread Martijn van Oosterhout
roblem forever (on linux at least, though anywhere with the GCC toolchain will work). Have a nice day, [1] http://archives.postgresql.org/pgsql-patches/2005-10/msg00166.php -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each according to his abi

Re: [PATCHES] Cleaning up multiply-defined-symbol warnings on OS X

2006-04-29 Thread Martijn van Oosterhout
On Sat, Apr 29, 2006 at 03:07:30PM -0400, Tom Lane wrote: > Martijn van Oosterhout writes: > > Now that 95% of this patch [1] (currently in the hold queue) has been > > implemented, perhaps we should go the final 5% and version the symbols > > to fix the ambiguous symbol prob

[PATCHES] [PATCH] Have configure complain about unknown options

2006-05-04 Thread Martijn van Oosterhout
this test. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each according to his ability to > litigate. Index: configure.in === RCS file: /projects/cvsroot/pg

Re: [PATCHES] [PATCH] Have configure complain about unknown options

2006-05-04 Thread Martijn van Oosterhout
On Thu, May 04, 2006 at 12:51:34PM -0400, Tom Lane wrote: > Martijn van Oosterhout writes: > > Currently, configure ignores unknown --enable/disable/with/without > > options. > > The autoconf people consider that a feature, not a bug. I'm > disinclined to second-gu

Re: [PATCHES] [PATCH] Have configure complain about unknown options

2006-05-05 Thread Martijn van Oosterhout
y complaining about unknown options can't be done in the general case. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each according to his ability to > litigate. signature.asc Description: Digital signature

Re: [PATCHES] [PATCH] Have configure complain about unknown options

2006-05-05 Thread Martijn van Oosterhout
n't indicate a means of doing adding abitrary options. But something like --enable-strict-options would be fairly straight forward. Problem being, if you mistype that option, it'll seem to work even when it isn't :) Maybe an evironment variable: PGAC_STRICT Have a nice day, -- Mar

Re: [PATCHES] Have configure complain about unknown options

2006-05-05 Thread Martijn van Oosterhout
build system used to build the package. It knows that the autotools are in use and appends it automatically. FWIW, I'd just add a line to the case statement accepting the enable_maintainer_mode variable since it's harmless and we're trying to catch typos here, not actual options that don&

Re: [PATCHES] Have configure complain about unknown options

2006-05-05 Thread Martijn van Oosterhout
g that disables a number of braindead things done by automake and libtool and probably others. autoconf OTOH doesn't know about it. So, independant of the options above, I think it should be accepted without warning. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ &g

Re: [PATCHES] [PATCH] Add support for GnuTLS

2006-05-06 Thread Martijn van Oosterhout
new version, in case any more changes came down the line. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each according to his ability to > litigate. signature.asc Description: Digital signature

Re: [PATCHES] [PATCH] Add support for GnuTLS

2006-05-06 Thread Martijn van Oosterhout
On Sat, May 06, 2006 at 02:47:33PM -0400, Bruce Momjian wrote: > Martijn van Oosterhout wrote: > > If you like I can split it into two patches, one patch splits the openssl > > stuff out of the main files and a second which adds gnutls support. > > Yes, I understood

[PATCHES] [PATCH] Magic block for modules

2006-05-07 Thread Martijn van Oosterhout
lock are merely logged at LOG level. This needs some discussion though. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each according to his ability to > litigate.

Re: [PATCHES] [PATCH] Magic block for modules

2006-05-08 Thread Martijn van Oosterhout
I was thinking of adding it with LOG level now, send a message on -announce saying that at the beginning of the 8.2 freeze it will be an ERROR. Give people time to react. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each according to his ability to > litigate. signature.asc Description: Digital signature

Re: [PATCHES] [PATCH] Magic block for modules

2006-05-08 Thread Martijn van Oosterhout
On Mon, May 08, 2006 at 10:32:47AM -0400, Tom Lane wrote: > Martijn van Oosterhout writes: > > I was trying to find variables that when changed would make some things > > corrupt. For example, a changed NAMEDATALEN will make any use of the > > syscache a source o

[PATCHES] [PATCH] Round 2: Magic block for modules

2006-05-08 Thread Martijn van Oosterhout
changing the way timestamps are stored and being configurable by a configure option, doesn't actually break anything important (only the btree_gist example in contrib). Any more comments? Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his abi

Re: [PATCHES] Cleaning up multiply-defined-symbol warnings on OS X

2006-05-09 Thread Martijn van Oosterhout
On Tue, May 09, 2006 at 10:19:56AM +0200, Peter Eisentraut wrote: > Am Samstag, 29. April 2006 21:27 schrieb Martijn van Oosterhout: > > What it does is remove the restriction that any one program can only > > use (directly or indirectly) one version of libpq at any moment. >

Re: [PATCHES] Have configure complain about unknown options

2006-05-09 Thread Martijn van Oosterhout
On Tue, May 09, 2006 at 10:37:43AM +0200, Peter Eisentraut wrote: > Am Freitag, 5. Mai 2006 20:07 schrieb Martijn van Oosterhout: > > 1. Provide an escape option they can add > > 2. Package systems can usually apply patches prior to compiling, they can > > always remove the o

Re: [PATCHES] Cleaning up multiply-defined-symbol warnings on OS X

2006-05-09 Thread Martijn van Oosterhout
On Tue, May 09, 2006 at 01:50:38PM +0200, Peter Eisentraut wrote: > Am Dienstag, 9. Mai 2006 10:41 schrieb Martijn van Oosterhout: > > Depends what you mean by signature. The structures of PGconn and > > PGresult have changed over time, so if you you pass a PGresult > > all

Re: [PATCHES] Cleaning up multiply-defined-symbol warnings on OS X

2006-05-09 Thread Martijn van Oosterhout
On Tue, May 09, 2006 at 09:18:17AM -0400, Tom Lane wrote: > Martijn van Oosterhout writes: > > Eh? It stops a program expecting libpq4 being linked to libpq3 for any > > reason, so the above situation can't happen. You don't need to version > > any structs, only th

Re: [PATCHES] Have configure complain about unknown options

2006-05-09 Thread Martijn van Oosterhout
we would be best printing out options we _didn't_ undertand at the > end of the build. I can live with that. It's a minor tweak... Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each according to his ability to &g

[PATCHES] [PATCH] Improve EXPLAIN ANALYZE overhead by sampling

2006-05-09 Thread Martijn van Oosterhout
re every tuple, though its parent node won't. We'll need some field testing to see if that remains a significant effect. - I don't let the user know anywhere how many samples it took. Is this something users should care about? Any comments? -- Martijn van Oosterhout http://svana.

Re: [PATCHES] [PATCH] Improve EXPLAIN ANALYZE overhead by sampling

2006-05-09 Thread Martijn van Oosterhout
me. In any case, the calibration is limited to half a millisecond (that's 500 microseconds), and it'll be a less on fast machines. Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each according to his ability to > litigate. signature.asc Description: Digital signature

Re: [PATCHES] [PATCH] Improve EXPLAIN ANALYZE overhead by sampling

2006-05-11 Thread Martijn van Oosterhout
his might still leave some noticable overhead (high loop count). I'm just not sure if they occur all that often in practice... Have a nice day, -- Martijn van Oosterhout http://svana.org/kleptog/ > From each according to his ability. To each according to his ability to > litig

  1   2   >