Re: [PATCHES] Tsearch2 update for Win32.

2004-09-14 Thread Dave Page
> -Original Message- > From: Tom Lane [mailto:[EMAIL PROTECTED] > Sent: 14 September 2004 05:00 > To: Dave Page > Cc: PostgreSQL-patches > Subject: Re: [PATCHES] Tsearch2 update for Win32. > > "Dave Page" <[EMAIL PROTECTED]> writes: > >

Re: [PATCHES] Tsearch2 update for Win32.

2004-09-13 Thread Tom Lane
"Dave Page" <[EMAIL PROTECTED]> writes: > The Win32 installer cannot easily handle 'copy from stdin' thus > preventing execution of scripts that use copy. Tsearch2 appears to have > the only script that does this - the attached patch changes the copy to > a bunch of INSERTs. Applied. I also fixed

Re: [PATCHES] Tsearch2 update for Win32.

2004-09-08 Thread Tom Lane
"Dave Page" <[EMAIL PROTECTED]> writes: >> I understand the difficulties, but ISTM that getting >> "psql -f scriptfile" >> working could be a Good Thing (tm). > If you have any suggestions on how we can trap errors I'm all ears I believe you can look at psql's exit status. (You may need to do

Re: [PATCHES] Tsearch2 update for Win32.

2004-09-08 Thread Dave Page
> -Original Message- > From: Andrew Dunstan [mailto:[EMAIL PROTECTED] > Sent: 08 September 2004 17:17 > To: Tom Lane > Cc: Magnus Hagander; Dave Page; PostgreSQL-patches > Subject: Re: [PATCHES] Tsearch2 update for Win32. > > > Not to mention someone

Re: [PATCHES] Tsearch2 update for Win32.

2004-09-08 Thread Andrew Dunstan
Tom Lane wrote: "Magnus Hagander" <[EMAIL PROTECTED]> writes: Oh. Hmm ... wouldn't it be easier and safer to launch "psql as a subprocess? I'd say no. Executing processes from the installer environment can be a headache (we've had enough problems with initdb already..). And you have

Re: [PATCHES] Tsearch2 update for Win32.

2004-09-08 Thread Dave Page
> -Original Message- > From: Tom Lane [mailto:[EMAIL PROTECTED] > Sent: 08 September 2004 15:49 > To: Magnus Hagander > Cc: Dave Page; PostgreSQL-patches > Subject: Re: [PATCHES] Tsearch2 update for Win32. > > I was about to mention trapping errors as being

Re: [PATCHES] Tsearch2 update for Win32.

2004-09-08 Thread Fabien COELHO
Dear Magnus, Oh. Hmm ... wouldn't it be easier and safer to launch "psql I'd say no. Executing processes from the installer environment can be a headache (we've had enough problems with initdb already..). And you have to go through all the weirdness with the commandline quoting etc on win32... It'

Re: [PATCHES] Tsearch2 update for Win32.

2004-09-08 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: >> Oh. Hmm ... wouldn't it be easier and safer to launch "psql > as a subprocess? > I'd say no. Executing processes from the installer environment can be a > headache (we've had enough problems with initdb already..). And you have > to go through all

Re: [PATCHES] Tsearch2 update for Win32.

2004-09-08 Thread Magnus Hagander
> >> While I have no particular objection to adjusting the > >> tsearch2 script, why has the installer got a problem with it? > >> Seems like this suggests a bug in win32 psql. > > > The installer runs contrib module scripts without using psql - it > > executes them in a 'custom action' - code

Re: [PATCHES] Tsearch2 update for Win32.

2004-09-08 Thread Tom Lane
"Dave Page" <[EMAIL PROTECTED]> writes: >> While I have no particular objection to adjusting the >> tsearch2 script, why has the installer got a problem with it? >> Seems like this suggests a bug in win32 psql. > The installer runs contrib module scripts without using psql - it > executes them

Re: [PATCHES] Tsearch2 update for Win32.

2004-09-08 Thread Dave Page
> -Original Message- > From: Tom Lane [mailto:[EMAIL PROTECTED] > Sent: 08 September 2004 15:14 > To: Dave Page > Cc: PostgreSQL-patches > Subject: Re: [PATCHES] Tsearch2 update for Win32. > > While I have no particular objection to adjusting the > t

Re: [PATCHES] Tsearch2 update for Win32.

2004-09-08 Thread Tom Lane
"Dave Page" <[EMAIL PROTECTED]> writes: > The Win32 installer cannot easily handle 'copy from stdin' thus > preventing execution of scripts that use copy. Tsearch2 appears to have > the only script that does this - the attached patch changes the copy to > a bunch of INSERTs. While I have no partic

[PATCHES] Tsearch2 update for Win32.

2004-09-08 Thread Dave Page
The Win32 installer cannot easily handle 'copy from stdin' thus preventing execution of scripts that use copy. Tsearch2 appears to have the only script that does this - the attached patch changes the copy to a bunch of INSERTs. Regards, Dave tsearch2.sql.in.diff Description: tsearch2.sql.in.diff