Are there any tests for this?
Chris
Moriyoshi Koizumi wrote:
moriyoshi Fri May 15 17:02:35 2009 UTC
Modified files:
/php-src/ext/standard array.c
Log:
* Roll it back then. I wonder if defaulting it to SORT_REGULAR would work
well
and I think
Christopher Jones wrote:
Are there any tests for this?
Do we really need one?
Moriyoshi
Chris
Moriyoshi Koizumi wrote:
moriyoshiFri May 15 17:02:35 2009 UTC
Modified files: /php-src/ext/standardarray.c
Log:
* Roll it back then. I wonder if
On Fri, May 15, 2009 at 20:40, Moriyoshi Koizumi m...@mozo.jp wrote:
Christopher Jones wrote:
Are there any tests for this?
Do we really need one?
Yes.
-Hannes
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Hannes Magnusson wrote:
On Fri, May 15, 2009 at 20:40, Moriyoshi Koizumi m...@mozo.jp wrote:
Christopher Jones wrote:
Are there any tests for this?
Do we really need one?
Yes.
-Hannes
Tests would help bring to attention any future change, making it
easier to analyze the impact. We
Moriyoshi Koizumi wrote:
I got a bug report, then I fixed it. That's just an normal procedure for
bugfixing. Isn't it? Am I supposed to have a written permission from you
whenever I fix a part you did ever touch?
And the old behavior is strange, but not *broken*. It just doesn't work
for your
Moriyoshi Koizumi wrote:
Whatever reasoning, I don't think it's a good idea to revert someone
else's patch before discussing anything.
Aside from this, I agree with you the old behavior is that stupid, but
BC should always be honored.
Moriyoshi,
You committed your fix and updated my NEWS
On 火, 2009-02-17 at 10:07 -0800, Andrei Zmievski wrote:
Moriyoshi Koizumi wrote:
Whatever reasoning, I don't think it's a good idea to revert someone
else's patch before discussing anything.
Aside from this, I agree with you the old behavior is that stupid,
but
BC should always be
Don't do this please. Why did you feel the need to go back and change my patch including
the NEWS entry? I knew what I was doing when I set the default behavior to SORT_REGULAR
and this was discussed with both 5.3 and 5.2 RMs. With your change it'l back to the stupid
old behavior of:
$array
Where do I edit the doc stuff again?
Kalle Sommer Nielsen wrote:
2008/12/12 Andrei Zmievski and...@php.net:
andrei Fri Dec 12 19:19:04 2008 UTC
Modified files:
/php-src/ext/standard array.c
Log:
Add sort flags parameter to array_unique().
2008/12/15 Andrei Zmievski and...@gravitonic.com:
Where do I edit the doc stuff again?
Do a checkout of the 'phpdoc' repo, inside the /en/ directory theres
the english translation files.
/en/language/ -- for language specific features
/en/reference/ -- for references for extensions, eg. array,
2008/12/12 Andrei Zmievski and...@php.net:
andrei Fri Dec 12 19:19:04 2008 UTC
Modified files:
/php-src/ext/standard array.c
Log:
Add sort flags parameter to array_unique().
http://cvs.php.net/viewvc.cgi/php-src/ext/standard/array.c?r1=1.467r2=1.468diff_format=u
Did you read my comment in that bug report?
--Jani
Felipe Pena wrote:
felipe Wed Jul 23 16:27:16 2008 UTC
Modified files:
/php-src/ext/standard array.c
Log:
- Fixed bug #45605 (array_uintersect_assoc gives incorrect error message)
(patch by ilewis at uk
Em Qua, 2008-07-23 às 20:11 +0300, Jani Taskinen escreveu:
Did you read my comment in that bug report?
Yes, but after the commit.
--Jani
Felipe Pena wrote:
felipe Wed Jul 23 16:27:16 2008 UTC
Modified files:
/php-src/ext/standard array.c
Felipe Pena kirjoitti:
Em Qua, 2008-07-23 às 20:11 +0300, Jani Taskinen escreveu:
Did you read my comment in that bug report?
Yes, but after the commit.
...and? :)
--Jani
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Em Qua, 2008-07-23 às 22:53 +0300, Jani Taskinen escreveu:
Felipe Pena kirjoitti:
Em Qua, 2008-07-23 às 20:11 +0300, Jani Taskinen escreveu:
Did you read my comment in that bug report?
Yes, but after the commit.
...and? :)
--Jani
I'll fix it again in some minutes... (goto home;)
On 25.01.2008 18:52, Rob Richards wrote:
rrichards Fri Jan 25 15:52:00 2008 UTC
Modified files:
/php-src/ext/standard array.c
Log:
fix zts build
Thanks!
--
Wbr,
Antony Dovgal
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit:
Sorry, and thanks. :)
I tried to commit stuff separate from other changes and this happened..
--Jani
On Fri, 2007-11-02 at 12:03 +, Antony Dovgal wrote:
tony2001 Fri Nov 2 12:03:25 2007 UTC
Modified files:
/php-src/ext/standard array.c
Log:
On 02.11.2007 15:22, Jani Taskinen wrote:
Sorry, and thanks. :)
I tried to commit stuff separate from other changes and this happened..
No worries, Jani.
--
Wbr,
Antony Dovgal
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Please use zend_parse_parameters() API.
-Andrei
On Oct 3, 2006, at 9:36 AM, Hannes Magnusson wrote:
bjori Tue Oct 3 16:36:57 2006 UTC
Modified files:
/php-src/ext/standard array.c
Log:
compact() doesnt throw wrong param count
Why do we want to continue treating objects as arrays? Can't people
simply pass get_object_vars($obj) result to array_walk?
In any case, does the error message make sense though?
+ php_error_docref(NULL TSRMLS_CC, E_WARNING, The argument should be
an array);
-Andrei
On Sep 19, 2006, at
Andrei Zmievski wrote:
Why do we want to continue treating objects as arrays? Can't people
simply pass get_object_vars($obj) result to array_walk?
That won't work because array_walk() takes a reference.
--
Michael
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit:
So assign it to a variable.
-Andrei
On Sep 19, 2006, at 8:52 AM, Michael Wallner wrote:
Andrei Zmievski wrote:
Why do we want to continue treating objects as arrays? Can't people
simply pass get_object_vars($obj) result to array_walk?
That won't work because array_walk() takes a reference.
On Sun, 26 Mar 2006, Andrei Zmievski wrote:
Shouldn't it be called unicode_collator.c?
I was wondering why the rest of the filenames where prepended with
unicode_... what's the point of that? :)
regards,
Derick
--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org
Shouldn't it be called unicode_collator.c?
-Andrei
On Mar 26, 2006, at 3:06 AM, Derick Rethans wrote:
derick Sun Mar 26 11:06:24 2006 UTC
Added files:
/php-src/ext/unicodecollator.c
Modified files:
/php-src/ext/standard array.c php_array.h
Hello Antony,
that looks pretty wrong (actually was wrong before already). The code
should read:
if (zend_call_function(fci, fci_cache TSRMLS_CC) != SUCCESS || !result) {
or like this:
if (zend_call_function(fci, fci_cache TSRMLS_CC) == FAILURE || !result) {
best regards
marcus
Tuesday,
On 28.12.2005 02:12, Marcus Boerger wrote:
Hello Antony,
that looks pretty wrong (actually was wrong before already). The code
should read:
if (zend_call_function(fci, fci_cache TSRMLS_CC) != SUCCESS || !result) {
or like this:
if (zend_call_function(fci, fci_cache TSRMLS_CC) == FAILURE
Hi Marcus,
Thank you for catch.
I reverted the patch and marked bug as bogus.
Dmitry.
-Original Message-
From: Marcus Boerger [mailto:[EMAIL PROTECTED]
Sent: Friday, October 21, 2005 10:01 PM
To: Dmitry Stogov
Cc: php-cvs@lists.php.net
Subject: Re: [PHP-CVS] cvs: php-src /ext
Hello Dmitry,
this is wrong! We agreed upon not allowing ArrayAccess in array*
functions. If you change this then change the macros in array.c from
Z_ARRVAL to HASH_OF and ensure that all functions also work with
ArrayAccess. Since you cannot do that you might probably explain why
the bug
Tony,
Please look into ext/standard/tests/array/bug30833.phpt
It is failed after your patch.
Probably test file itself should be fixed.
Thanks. Dmitry.
-Original Message-
From: Antony Dovgal [mailto:[EMAIL PROTECTED]
Sent: Wednesday, October 05, 2005 12:48 AM
To:
On 05.10.2005 10:57, Dmitry Stogov wrote:
Tony,
Please look into ext/standard/tests/array/bug30833.phpt
It is failed after your patch.
Probably test file itself should be fixed.
Fixed.
Thanks for noticing it =)
--
Wbr,
Antony Dovgal
--
PHP CVS Mailing List (http://www.php.net/)
To
Perhaps we should cache the locale object somewhere..
-Andrei
On Sep 12, 2005, at 2:53 AM, Derick Rethans wrote:
derick Mon Sep 12 05:53:23 2005 EDT
Modified files:
/ZendEngine2zend_operators.c
/php-src/ext/standard array.c
On Mon, 12 Sep 2005, Andrei Zmievski wrote:
Perhaps we should cache the locale object somewhere..
yes, that's already on my todo list. Have some basic stuff working for
that already, but no time to finish. Probably tomorrow on the plane.
Derick
--
Derick Rethans
http://derickrethans.nl |
Ok, I'll fix.
-Andrei
On Aug 17, 2005, at 2:43 PM, Andrei Zmievski wrote:
I think we can provide better Unicode support in range() if we follow
a simple rule that the low and high parameters are interpreted as
codepoints at the end of the range. It would be nice to be able to do
I think we can provide better Unicode support in range() if we follow
a simple rule that the low and high parameters are interpreted as
codepoints at the end of the range. It would be nice to be able to do
range('\u0200', '\u0500') and get the string of all the chars inbetween.
-Andrei
I agree, but don't know how to do it.
Dmitry.
-Original Message-
From: Andrei Zmievski [mailto:[EMAIL PROTECTED]
Sent: Thursday, August 18, 2005 1:44 AM
To: Dmitry Stogov
Cc: php-cvs@lists.php.net
Subject: Re: [PHP-CVS] cvs: php-src /ext/standard array.c
/ext/standard/tests
Close the bug? Add a NEWS entry ? :)
--Jani
On Wed, 15 Jun 2005, Andrei Zmievski wrote:
andrei Wed Jun 15 16:51:37 2005 EDT
Modified files:
/php-src/ext/standardbasic_functions.c basic_functions.h array.c
Log:
Fix FCI cache for array_walk and user array
On Wed, 15 Jun 2005 20:51:37 -
Andrei Zmievski [EMAIL PROTECTED] wrote:
andreiWed Jun 15 16:51:37 2005 EDT
Modified files:
/php-src/ext/standard basic_functions.c basic_functions.h array.c
Log:
Fix FCI cache for array_walk and user array
On Wed, 15 Jun 2005 21:20:28 -
Andrei Zmievski [EMAIL PROTECTED] wrote:
andreiWed Jun 15 17:20:28 2005 EDT
Modified files:
/php-src/ext/standard array.c
Log:
WS fix
Thanks!
--
Wbr,
Antony Dovgal aka tony2001
--
PHP CVS Mailing List
I'd share the array_sum() code with array_product() code..
They're identical except for + being * in latter.
(I guess you simply copy'pasted it? :)
--Jani
On Wed, 11 May 2005, Andrey Hristov wrote:
andrey Wed May 11 07:43:14 2005 EDT
Modified files:
Can you add a regression test for this too?
(if there isn't already :)
--Jani
On Tue, 12 Apr 2005, Antony Dovgal wrote:
tony2001Tue Apr 12 10:00:55 2005 EDT
Modified files:
/php-src/ext/standardarray.c
Log:
fix #30833 (array_count_values modifying input
On Wed, 15 Sep 2004, Derick Rethans wrote:
derickWed Sep 15 07:50:28 2004 EDT
Modified files:
/php-src/ext/standard array.c
Log:
- Added new boolean (fourth) parameter to array_slice() that turns on the
preservation of keys in the returned array.
I'd like
On Sat, 11 Sep 2004, Marcus Boerger wrote:
Hello Derick,
why not define the const only if it is usefull (strcoll available)?
I was under the (wrong) impression that constants where evaluated at
compile time where possible. Though I don't think it's a bad thing to
have this always available.
Hello Derick,
why not define the const only if it is usefull (strcoll available)?
regards
marcus
Saturday, September 11, 2004, 4:22:36 PM, you wrote:
derickSat Sep 11 10:22:36 2004 EDT
Modified files:
/ZendEngine2 zend_operators.c zend_operators.h
Yeah you should.
At 01:30 AM 1/24/2004 +0100, Andrey Hristov wrote:
Ooops, something else slipped in :/ (no more commits so late).
Anyway, should I revert the irrelevant part about ZEND_ENGINE_2 ?
Andrey
Andrey Hristov wrote:
andrey Fri Jan 23 19:25:58 2004 EDT
Modified files:
Yes, what's the point in having such compatibility things
in HEAD?
--Jani
On Sat, 24 Jan 2004, Andrey Hristov wrote:
Ooops, something else slipped in :/ (no more commits so late).
Anyway, should I revert the irrelevant part about ZEND_ENGINE_2 ?
Andrey
Andrey Hristov wrote:
Hi Jani,
there were some places in the codebase where the macro ZEND_ENGINE_2 was used.
I think these were the last 2 occurances.
Andrey
Jani Taskinen wrote:
Yes, what's the point in having such compatibility things
in HEAD?
--Jani
On Sat, 24 Jan 2004, Andrey Hristov wrote:
Ooops, something else slipped in :/ (no more commits so late).
Anyway, should I revert the irrelevant part about ZEND_ENGINE_2 ?
Andrey
Andrey Hristov wrote:
andrey Fri Jan 23 19:25:58 2004 EDT
Modified files:
/php-src/ext/standard array.c
Log:
Added third parameter
Still waiting for the documentation for these..and also
where are the NEWS entries?
--Jani
On Tue, 23 Sep 2003, Andrey Hristov wrote:
andrey Tue Sep 23 13:37:29 2003 EDT
Modified files:
/php-src/ext/standard array.c basic_functions.c
I will work on the documentation next week and will add a news entry soon.
Andrey
Jani Taskinen wrote:
Still waiting for the documentation for these..and also
where are the NEWS entries?
--Jani
On Tue, 23 Sep 2003, Andrey Hristov wrote:
andrey Tue Sep 23 13:37:29 2003
Wez Furlong wrote:
Should these functions really go into the core?
Perhaps they are better off in an extension (pecl/array_utils ?)
The names aren't really all that obvious to me either.
--Wez.
Hi Wez,
well maybe array_udiff_uassoc() and array_diff_uassoc() are of little
need but I added
Should these functions really go into the core?
Perhaps they are better off in an extension (pecl/array_utils ?)
The names aren't really all that obvious to me either.
--Wez.
- Original Message -
From: Andrey Hristov [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Tuesday, September 23,
I'll make it set the defaut value to NULL, that addresses the problem you've
described and maintains acceptable behaviour for the original problem.
Ilia
On August 9, 2003 02:09 am, Moriyoshi Koizumi wrote:
I don't think using 0 as the initial value by default is a good idea.
because
I don't think using 0 as the initial value by default is a good idea.
because array_reduce() can take any kind of element other than integer.
?php
$a = array(a, b, c);
$lambda = create_function('$a, $b', 'return $a . $b;');
var_dump(array_reduce($a, $lambda));
?
[Before this patch]
string(3) abc
Am Mon, 2003-08-04 um 04.38 schrieb Zeev Suraski:
zeev Mon Aug 4 04:38:24 2003 EDT
Modified files:
/php-src/ext/standard array.c
Log:
Fix bug #24652 - Sterling, do you begin to think that maybe it wasn't such
a good idea?
Nope. Needs only to be
54 matches
Mail list logo
