Re: [PHP-CVS] cvs: php-src /ext/standard config.m4 crypt_freesec.c crypt_freesec.h

2008-08-25 Thread Pierre Joye
hi, On Mon, Aug 25, 2008 at 2:52 PM, Jani Taskinen <[EMAIL PROTECTED]> wrote: > This was fun thread to read: Blind leading blind.. > Fix after fix to fix something that isn't broken. :) > > Pierre: There are other OSes than win32 and they're priority #1, Winblows is > the last. Please don't clutte

Re: [PHP-CVS] cvs: php-src /ext/standard config.m4 crypt_freesec.c crypt_freesec.h

2008-08-25 Thread Jani Taskinen
This was fun thread to read: Blind leading blind.. Fix after fix to fix something that isn't broken. :) Pierre: There are other OSes than win32 and they're priority #1, Winblows is the last. Please don't clutter the code with this win32 mania of yours. --Jani Arnaud Le Blanc wrote: Hi, O

Re: [PHP-CVS] cvs: php-src /ext/standard config.m4 crypt_freesec.c crypt_freesec.h

2008-08-23 Thread Arnaud Le Blanc
Hi, On Saturday 23 August 2008 21:58:53 Pierre Joye wrote: > On Sat, Aug 23, 2008 at 9:34 PM, Arnaud Le Blanc <[EMAIL PROTECTED]> wrote: > > Yes, but I was speaking about this line: > > typedef uint32_t u_int32_t; > > Right :) > > Do you have the time to give the inline a try? It works. > It

Re: [PHP-CVS] cvs: php-src /ext/standard config.m4 crypt_freesec.c crypt_freesec.h

2008-08-23 Thread Pierre Joye
On Sat, Aug 23, 2008 at 9:34 PM, Arnaud Le Blanc <[EMAIL PROTECTED]> wrote: > Yes, but I was speaking about this line: > typedef uint32_t u_int32_t; Right :) Do you have the time to give the inline a try? It would be nice to standardize it in php_config and config.w32.h as it can be used in other

Re: [PHP-CVS] cvs: php-src /ext/standard config.m4 crypt_freesec.c crypt_freesec.h

2008-08-23 Thread Arnaud Le Blanc
On Saturday 23 August 2008 21:21:16 Pierre Joye wrote: > On Sat, Aug 23, 2008 at 9:15 PM, Arnaud Le Blanc <[EMAIL PROTECTED]> wrote: > > Hi, > > > > On Saturday 23 August 2008 20:16:16 Pierre Joye wrote: > >> hi, > >> > >> >> > +# ifndef HAVE_U_INT32_T > >> >> > + typedef uint32_t u_int32_t; > >>

Re: [PHP-CVS] cvs: php-src /ext/standard config.m4 crypt_freesec.c crypt_freesec.h

2008-08-23 Thread Pierre Joye
On Sat, Aug 23, 2008 at 9:15 PM, Arnaud Le Blanc <[EMAIL PROTECTED]> wrote: > Hi, > > On Saturday 23 August 2008 20:16:16 Pierre Joye wrote: >> hi, >> >> >> > +# ifndef HAVE_U_INT32_T >> >> > + typedef uint32_t u_int32_t; >> >> > +# endif >> >> > +#endif >> >> >> >> I don't understand this part.

Re: [PHP-CVS] cvs: php-src /ext/standard config.m4 crypt_freesec.c crypt_freesec.h

2008-08-23 Thread Arnaud Le Blanc
Hi, On Saturday 23 August 2008 20:16:16 Pierre Joye wrote: > hi, > > >> > +# ifndef HAVE_U_INT32_T > >> > + typedef uint32_t u_int32_t; > >> > +# endif > >> > +#endif > >> > >> I don't understand this part. If HAVE_U_INT32_T is not defined, you > >> still use u_int32_t? > > > > If HAVE_U_INT32

Re: [PHP-CVS] cvs: php-src /ext/standard config.m4 crypt_freesec.c crypt_freesec.h

2008-08-23 Thread Pierre Joye
hi, On Sat, Aug 23, 2008 at 7:57 PM, Arnaud Le Blanc <[EMAIL PROTECTED]> wrote: > The commit adds AC_C_INLINE in config.m4, which defines "inline" appropriatly > to > __inline or __inline__ if the compiler does not know the "inline" keyword. > > Basically it does what you added in your commit, b

Re: [PHP-CVS] cvs: php-src /ext/standard config.m4 crypt_freesec.c crypt_freesec.h

2008-08-23 Thread Arnaud Le Blanc
Hi, On Saturday 23 August 2008 18:50:37 Pierre Joye wrote: > > -__inline int > > +static inline int > > __inline is known on gcc and windows, adding a define for solaris > sounds more appropriate. The commit adds AC_C_INLINE in config.m4, which defines "inline" appropriatly to __inline or __in

Re: [PHP-CVS] cvs: php-src /ext/standard config.m4 crypt_freesec.c crypt_freesec.h

2008-08-23 Thread Pierre Joye
hi Arnaud, this commit breaks the windows build. Parts of it makes little sense, see below: On Sat, Aug 23, 2008 at 3:57 PM, Arnaud Le Blanc <[EMAIL PROTECTED]> wrote: > lbarnaudSat Aug 23 13:57:02 2008 UTC > > Modified files: >/php-src/ext/standard config.m4 crypt_free