[piccolo2d-dev] Re: Issue 161 in piccolo2d: full bounds behavior has changed in Piccolo 1.3

2010-02-10 Thread piccolo2d
Updates: Status: Verified Comment #15 on issue 161 by cmal...@pixelzoom.com: full bounds behavior has changed in Piccolo 1.3 http://code.google.com/p/piccolo2d/issues/detail?id=161 Verified that reverting r923 fixes the example application (DebugFullBounds) and our production appli

[piccolo2d-dev] Re: Issue 161 in piccolo2d: full bounds behavior has changed in Piccolo 1.3

2010-02-09 Thread piccolo2d
Comment #14 on issue 161 by re...@colorado.edu: full bounds behavior has changed in Piccolo 1.3 http://code.google.com/p/piccolo2d/issues/detail?id=161 I've opened new issue 162 to address discussion and implementation of improved semantics for full bounds and PBounds(EMPTY) for Milestone 2

[piccolo2d-dev] Re: Issue 161 in piccolo2d: full bounds behavior has changed in Piccolo 1.3

2010-02-09 Thread piccolo2d
Comment #13 on issue 161 by heue...@gmail.com: full bounds behavior has changed in Piccolo 1.3 http://code.google.com/p/piccolo2d/issues/detail?id=161 I don't mind putting out new RCs, it's better late than never. Binding votes are those from project committers. Non-binding votes are those

[piccolo2d-dev] Re: Issue 161 in piccolo2d: full bounds behavior has changed in Piccolo 1.3

2010-02-09 Thread piccolo2d
Comment #12 on issue 161 by cmal...@pixelzoom.com: full bounds behavior has changed in Piccolo 1.3 http://code.google.com/p/piccolo2d/issues/detail?id=161 Thanks for the clarification on the rc votes, heuermh. I assumed that "binding" meant a commitment that couldn't be changed. Nice to k

[piccolo2d-dev] Re: Issue 161 in piccolo2d: full bounds behavior has changed in Piccolo 1.3

2010-02-09 Thread piccolo2d
Comment #11 on issue 161 by allain.lalonde: full bounds behavior has changed in Piccolo 1.3 http://code.google.com/p/piccolo2d/issues/detail?id=161 I've reverted and re-opened. Regarding the rc, technically yes we should re-vote. Since this is the only change, if things run off the trunk, i

[piccolo2d-dev] Re: Issue 161 in piccolo2d: full bounds behavior has changed in Piccolo 1.3

2010-02-09 Thread piccolo2d
Comment #10 on issue 161 by cmal...@pixelzoom.com: full bounds behavior has changed in Piccolo 1.3 http://code.google.com/p/piccolo2d/issues/detail?id=161 Btw... Just for the record, we've found a second PhET application broken by this change. And there are probably others that we haven't

[piccolo2d-dev] Re: Issue 161 in piccolo2d: full bounds behavior has changed in Piccolo 1.3

2010-02-09 Thread piccolo2d
Comment #9 on issue 161 by heue...@gmail.com: full bounds behavior has changed in Piccolo 1.3 http://code.google.com/p/piccolo2d/issues/detail?id=161 Any of us can change our votes on 1.3-rc2 if necessary. -- You received this message because you are listed in the owner or CC fields of this

[piccolo2d-dev] Re: Issue 161 in piccolo2d: full bounds behavior has changed in Piccolo 1.3

2010-02-09 Thread piccolo2d
Comment #8 on issue 161 by cmal...@pixelzoom.com: full bounds behavior has changed in Piccolo 1.3 http://code.google.com/p/piccolo2d/issues/detail?id=161 I also agree with Allain's recommendation to roll back the fix for issue 155, and reopen that ticket. Keeping the behavior the same in a

[piccolo2d-dev] Re: Issue 161 in piccolo2d: full bounds behavior has changed in Piccolo 1.3

2010-02-09 Thread piccolo2d
Comment #7 on issue 161 by allain.lalonde: full bounds behavior has changed in Piccolo 1.3 http://code.google.com/p/piccolo2d/issues/detail?id=161 Regarding comment 4... I'd be OK with that approach, but I think that it ought to be the exception rather than the rule. Children classes who wi

[piccolo2d-dev] Re: Issue 161 in piccolo2d: full bounds behavior has changed in Piccolo 1.3

2010-02-09 Thread piccolo2d
Comment #6 on issue 161 by re...@colorado.edu: full bounds behavior has changed in Piccolo 1.3 http://code.google.com/p/piccolo2d/issues/detail?id=161 I agree with the recommendation in Comment 5 to roll back the fix for issue 155 for the 1.3 release. Should we plan on a 1.3rc3 for this?

[piccolo2d-dev] Re: Issue 161 in piccolo2d: full bounds behavior has changed in Piccolo 1.3

2010-02-09 Thread piccolo2d
Comment #5 on issue 161 by allain.lalonde: full bounds behavior has changed in Piccolo 1.3 http://code.google.com/p/piccolo2d/issues/detail?id=161 We've tried as much as possible to cause no breaking changes while fixing bugs, but... the fix to Issue 155 has obviously done so. With hindsi

[piccolo2d-dev] Re: Issue 161 in piccolo2d: full bounds behavior has changed in Piccolo 1.3

2010-02-08 Thread piccolo2d
Comment #4 on issue 161 by re...@colorado.edu: full bounds behavior has changed in Piccolo 1.3 http://code.google.com/p/piccolo2d/issues/detail?id=161 Here's a proposed behavior that I think is predominantly consistent with the pre-r963 behavior, and that makes more sense to me. 1. Contai

[piccolo2d-dev] Re: Issue 161 in piccolo2d: full bounds behavior has changed in Piccolo 1.3

2010-02-08 Thread piccolo2d
Comment #3 on issue 161 by re...@colorado.edu: full bounds behavior has changed in Piccolo 1.3 http://code.google.com/p/piccolo2d/issues/detail?id=161 I've been using the DebugFullBounds.java attached above in order to reason about the desired behavior, and found another unexpected but rela

[piccolo2d-dev] Re: Issue 161 in piccolo2d: full bounds behavior has changed in Piccolo 1.3

2010-02-08 Thread piccolo2d
Comment #2 on issue 161 by re...@colorado.edu: full bounds behavior has changed in Piccolo 1.3 http://code.google.com/p/piccolo2d/issues/detail?id=161 I've been using the DebugFullBounds.java attached above in order to reason about the desired behavior, and found another unexpected but rela

[piccolo2d-dev] Re: Issue 161 in piccolo2d: full bounds behavior has changed in Piccolo 1.3

2010-02-08 Thread piccolo2d
Comment #1 on issue 161 by allain.lalonde: full bounds behavior has changed in Piccolo 1.3 http://code.google.com/p/piccolo2d/issues/detail?id=161 Piccolo has an interesting definition of empty. It's possible to have nodes that have girth and position but still be considered empty. -- You