Re: [Piglit] [PATCH] egl-util: remove GL include

2014-08-18 Thread Daniel Kurtz
On Mon, Aug 18, 2014 at 5:43 PM, Ken Phillis Jr kphilli...@gmail.com wrote: I think a ifdef is needed since egl can create opengl contexts. EGL can create an OpenGL context using an EGLConfig that has EGL_RENDERABLE_TYPE with EGL_OPENGL_BIT. It does so by first binding to the OpenGL API,

Re: [Piglit] [PATCH] egl-util: remove GL include

2014-08-18 Thread Kristian Høgsberg
On Sun, Aug 17, 2014 at 5:32 PM, Daniel Kurtz djku...@chromium.org wrote: On Aug 18, 2014 3:49 AM, Kristian Høgsberg k...@bitplanet.net wrote: On Sun, Aug 17, 2014 at 7:19 AM, Ken Phillis Jr kphilli...@gmail.com wrote: This patch looks good to me. On Aug 17, 2014 7:39 AM, Daniel Kurtz

Re: [Piglit] [PATCH] egl-util: remove GL include

2014-08-18 Thread Chad Versace
On 08/18/2014 11:15 AM, Kristian Høgsberg wrote: On Sun, Aug 17, 2014 at 5:32 PM, Daniel Kurtz djku...@chromium.org wrote: On Aug 18, 2014 3:49 AM, Kristian Høgsberg k...@bitplanet.net wrote: It certainly shouldn't be in the header, but egl-util.c needs it and breaks if you remove it.

[Piglit] [PATCH] egl-util: remove GL include

2014-08-17 Thread Daniel Kurtz
EGL util should not in any way depend on the headers of a particular client library. In fact, this breaks compilation on pure OpenGL ES systems, since they do not have OpenGL headers installed (GL/gl.h). Signed-off-by: Daniel Kurtz djku...@chromium.org --- I've test built this change on two

Re: [Piglit] [PATCH] egl-util: remove GL include

2014-08-17 Thread Ken Phillis Jr
This patch looks good to me. On Aug 17, 2014 7:39 AM, Daniel Kurtz djku...@chromium.org wrote: EGL util should not in any way depend on the headers of a particular client library. In fact, this breaks compilation on pure OpenGL ES systems, since they do not have OpenGL headers installed

Re: [Piglit] [PATCH] egl-util: remove GL include

2014-08-17 Thread Kristian Høgsberg
On Sun, Aug 17, 2014 at 7:19 AM, Ken Phillis Jr kphilli...@gmail.com wrote: This patch looks good to me. On Aug 17, 2014 7:39 AM, Daniel Kurtz djku...@chromium.org wrote: EGL util should not in any way depend on the headers of a particular client library. In fact, this breaks compilation

Re: [Piglit] [PATCH] egl-util: remove GL include

2014-08-17 Thread Daniel Kurtz
On Aug 18, 2014 3:49 AM, Kristian Høgsberg k...@bitplanet.net wrote: On Sun, Aug 17, 2014 at 7:19 AM, Ken Phillis Jr kphilli...@gmail.com wrote: This patch looks good to me. On Aug 17, 2014 7:39 AM, Daniel Kurtz djku...@chromium.org wrote: EGL util should not in any way depend on the