Re: [Piglit] [PATCH] arb_compute_variable_group_size: Fix require section.

2016-10-18 Thread Nicolai Hähnle
On 17.10.2016 22:33, Matt Turner wrote: On Mon, Oct 17, 2016 at 12:54 PM, Samuel Pitoiset wrote: On 10/17/2016 09:45 PM, Samuel Pitoiset wrote: Thanks for fixing this. Reviewed-by: Samuel Pitoiset Actually, we need to check for both ARB_compute_shader and ARB_compute_variable_group_siz

Re: [Piglit] [PATCH] arb_compute_variable_group_size: Fix require section.

2016-10-17 Thread Dylan Baker
Quoting Matt Turner (2016-10-17 13:33:11) > On Mon, Oct 17, 2016 at 12:54 PM, Samuel Pitoiset > wrote: > > > > > > On 10/17/2016 09:45 PM, Samuel Pitoiset wrote: > >> > >> Thanks for fixing this. > >> > >> Reviewed-by: Samuel Pitoiset > > > > > > Actually, we need to check for both ARB_compute_sh

Re: [Piglit] [PATCH] arb_compute_variable_group_size: Fix require section.

2016-10-17 Thread Samuel Pitoiset
On 10/17/2016 10:33 PM, Matt Turner wrote: On Mon, Oct 17, 2016 at 12:54 PM, Samuel Pitoiset wrote: On 10/17/2016 09:45 PM, Samuel Pitoiset wrote: Thanks for fixing this. Reviewed-by: Samuel Pitoiset Actually, we need to check for both ARB_compute_shader and ARB_compute_variable_grou

Re: [Piglit] [PATCH] arb_compute_variable_group_size: Fix require section.

2016-10-17 Thread Matt Turner
On Mon, Oct 17, 2016 at 12:54 PM, Samuel Pitoiset wrote: > > > On 10/17/2016 09:45 PM, Samuel Pitoiset wrote: >> >> Thanks for fixing this. >> >> Reviewed-by: Samuel Pitoiset > > > Actually, we need to check for both ARB_compute_shader and > ARB_compute_variable_group_size since > https://cgit.fr

Re: [Piglit] [PATCH] arb_compute_variable_group_size: Fix require section.

2016-10-17 Thread Samuel Pitoiset
On 10/17/2016 09:45 PM, Samuel Pitoiset wrote: Thanks for fixing this. Reviewed-by: Samuel Pitoiset Actually, we need to check for both ARB_compute_shader and ARB_compute_variable_group_size since https://cgit.freedesktop.org/mesa/mesa/commit/?id=8785a8ff8948385a913e9bd75e8cdd1092bd750f.

Re: [Piglit] [PATCH] arb_compute_variable_group_size: Fix require section.

2016-10-17 Thread Samuel Pitoiset
Thanks for fixing this. Reviewed-by: Samuel Pitoiset On 10/17/2016 09:39 PM, Matt Turner wrote: --- .../linker/mixed_fixed_variable_local_work_size.shader_test | 2 +- .../linker/no_local_size_specified.shader_test | 2 +- 2 files changed, 2 insertions(+),

Re: [Piglit] [PATCH] arb_compute_variable_group_size: Fix require section.

2016-10-17 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2016-10-17 12:39:18, Matt Turner wrote: > --- > .../linker/mixed_fixed_variable_local_work_size.shader_test | 2 > +- > .../linker/no_local_size_specified.shader_test | 2 > +- > 2 files changed, 2 insertions(+), 2 deletions(-)