Re: [pkg-discuss] quick codereview for terminal fix

2012-07-27 Thread johansen
On Fri, Jul 27, 2012 at 03:57:16PM -0700, Dan Price wrote: > > I introduced a bug in our terminal handling when TERM isn't set or > is set to a bogus value. Here's a fix: > > https://cr.opensolaris.org/action/browse/pkg/dp/setupterm/ This looks good. It took me a moment to realize that the exc

Re: [pkg-discuss] parallel linked images code review, take 3

2012-06-18 Thread johansen
On Mon, Jun 18, 2012 at 01:15:04PM -0700, Danek Duvall wrote: > Edward Pilatowicz wrote: > > > > > https://cr.opensolaris.org/action/browse/pkg/edp/pkg.pli.cr3/webrev.cr1.diff > > nrlock.py: > > - line 58: docstring is identical to the one for locked(); probably could > have a couple

Re: [pkg-discuss] code review request: zoneproxy lint

2012-04-24 Thread johansen
On Tue, Apr 24, 2012 at 03:13:44PM -0700, Danek Duvall wrote: > As a follow-up to Brock's fix for the gate not building, a full lint whack > on the zoneproxy utilities: > > https://cr.opensolaris.org/action/browse/pkg/dduvall/zplint Looks good. -j

Re: [pkg-discuss] creating a secure IPS repo...

2012-04-24 Thread johansen
On Tue, Apr 24, 2012 at 11:54:48AM -0700, John Fischer wrote: > On 04/24/12 11:38 AM, johan...@opensolaris.org wrote: > >openssl s_client -CApath /etc/certs/CA -connect 192.168.100.10:4321 > depth=0 C = US, ST = California, L = PV, O = Oracle, OU = Solaris > Install, CN = > 192.168.100.10 > verify

Re: [pkg-discuss] creating a secure IPS repo...

2012-04-24 Thread johansen
On Tue, Apr 24, 2012 at 10:46:09AM -0700, John Fischer wrote: > # pkg refresh > Refreshing catalog 3/3 > pkg: 2/3 catalogs successfully updated: > > Framework error: code: 60 reason: SSL certificate problem, verify > that the CA cert is OK. > Details: > error:14090086:SSL routines:SSL3_GET_SERVER_

Re: [pkg-discuss] How to validate whether a publisher is reachable or not

2012-03-15 Thread johansen
On Wed, Mar 14, 2012 at 01:47:12PM -0700, Steve Sundstrom wrote: > > So what happens when you check that the network is reachable before you > > execute the operation, and then a network failure happens later during > > the operation? You've just moved the point of failure without actually > >

Re: [pkg-discuss] granular configuration of http_proxy

2012-03-12 Thread johansen
On Tue, Mar 13, 2012 at 12:59:41PM +1300, Tim Foster wrote: > On the server-side, we'll add a new "proxied-urls" list property to > each existing "publishers" entry returned by the publisher/0/ > response. > > The list contains a series of [uri, proxy] lists so that clients > using -p can discover

Re: [pkg-discuss] Code review: making transport deal with poisonous web caches

2012-03-07 Thread johansen
On Wed, Mar 07, 2012 at 05:39:11PM +1300, Tim Foster wrote: > Ok, I've had another go at this, and have a webrev at: > > https://cr.opensolaris.org/action/browse/pkg/timf/poisoned-cache-v3 Thanks for making these modifications. I like this change. Just a few nits: stats.py: - line 320: typo

Re: [pkg-discuss] Code review: making transport deal with poisonous web caches

2012-03-05 Thread johansen
On Tue, Mar 06, 2012 at 11:55:42AM +1300, Tim Foster wrote: > On 03/ 6/12 11:17 AM, johan...@opensolaris.org wrote: > >On Tue, Mar 06, 2012 at 10:08:00AM +1300, Tim Foster wrote: > >>I've got an incremental, and new webrev at: > >>https://cr.opensolaris.org/action/browse/pkg/timf/poisoned-cache-v2/

Re: [pkg-discuss] Code review: making transport deal with poisonous web caches

2012-03-05 Thread johansen
On Tue, Mar 06, 2012 at 10:08:00AM +1300, Tim Foster wrote: > I've got an incremental, and new webrev at: > https://cr.opensolaris.org/action/browse/pkg/timf/poisoned-cache-v2/ On lines 1286-1298 and 1887-1899 you're not recording the fact that you've seen a content error, which is going to skew t

Re: [pkg-discuss] 'pkg install' performance issue

2011-12-28 Thread johansen
Hi Ervin: On Fri, Dec 23, 2011 at 01:33:33AM -0800, Ervin Yan wrote: > Since our customers may only need 4 of the packages for basic > functions, and need not download the whole image from our production > server, and to provide consistent customer experiences with other > platforms, we decided

[pkg-discuss] 19041 zoneproxyd door_server_create can race with door_create

2011-11-21 Thread krister . johansen
Author: Krister Johansen Repository: /hg/pkg/gate Latest revision: 54d9bb03f34a7aed7c43f3ce5712e33fffbc4b56 Total changesets: 1 Log message: 19041 zoneproxyd door_server_create can race with door_create Files: update: src/zoneproxy/zoneproxyd/zoneproxyd.c

[pkg-discuss] Code Review: zoneproxyd race

2011-11-17 Thread johansen
up confusing the code that binds the newly created thread to the door's private pool. Long story short: more synchronization needed. https://cr.opensolaris.org/action/browse/pkg/johansen/19041/webrev/ Thanks, -j ___ pkg-discuss mailing

Re: [pkg-discuss] Code review for 18463

2011-06-13 Thread johansen
On Fri, Jun 10, 2011 at 08:39:02PM -0700, Brock Pytlik wrote: > Webrev: > http://cr.opensolaris.org/~bpytlik/ips-18463-v1/ The transport engine handles connect timeouts, speed timeouts, and checks for libcurl stalls too. If you're trying to get something that's robust as the rest of the data tran

Re: [pkg-discuss] Code review for 18441 (pkg freeze)

2011-06-10 Thread johansen
On Fri, Jun 10, 2011 at 12:13:11AM -0700, Brock Pytlik wrote: > 1) If pkg unfreeze doesn't match any frozen packages, no > error is reported. I decided that seems reasonable since pkg > unfreeze details each package that was unfrozen, so no output means > no packages were unfrozen. Not that you c

Re: [pkg-discuss] li perf improvements webrev

2011-06-06 Thread johansen
On Mon, Jun 06, 2011 at 02:05:14PM -0700, Brock Pytlik wrote: > On 06/04/11 17:14, Edward Pilatowicz wrote: > >http://mcescher.us.oracle.com/export/ws/pkg.perf2/webrev/ > > > common.py: > 2229: If there's any chance of the command being run generating a > copious amount of error output, then a p.co

[pkg-discuss] 18449 zoneproxyd dies while trying to set max number of file descriptors

2011-06-02 Thread johansen
Author: johansen Repository: /hg/pkg/gate Latest revision: 8e786dd020035dedd71aaf134c11c3783a4a8026 Total changesets: 1 Log message: 18449 zoneproxyd dies while trying to set max number of file descriptors Files: update: src/zoneproxy/zoneproxyd/zoneproxyd.c

[pkg-discuss] Code Review: zoneproxyd fix

2011-06-02 Thread johansen
Folks, I have a small fix to zoneproxyd (< 20 lines). Could somebody please take a quick look at this one? http://cr.opensolaris.org/~johansen/webrev-18449/ Thanks, -j ___ pkg-discuss mailing list pkg-discuss@opensolaris.org h

Re: [pkg-discuss] [review] changes for rfe 18325

2011-06-01 Thread johansen
On Mon, May 23, 2011 at 01:00:06PM -0700, Shawn Walker wrote: > Greetings, > > The following webrev contains changes for the following RFE: > > 18325 image-create should accept simple paths for sources > > webrev: > http://cr.opensolaris.org/~swalker/pkg-18325/ This looks fine. I just have

Re: [pkg-discuss] code review for 18401

2011-06-01 Thread johansen
On Tue, May 31, 2011 at 01:48:09PM -0700, Erik Trauschke wrote: > On Mon, 2011-05-23 at 18:18 -0700, Erik Trauschke wrote: > > I put out a webrev for > > 18401 third party libraries should be moved to userland consolidation. > > > > http://cr.opensolaris.org/~erisch/pkg_gate0523/ > > Could anyone

Re: [pkg-discuss] [review] fix for 18438

2011-05-27 Thread johansen
On Fri, May 27, 2011 at 11:30:59AM -0700, Shawn Walker wrote: > Greetings, > > The following webrev contains a fix for the following issue: > > 18438 temporary workaround needed for leaked fd after calls to > libbe_py beList > > webrev: > http://cr.opensolaris.org/~swalker/pkg-tip/

Re: [pkg-discuss] Code review: sysrepo refactor

2011-05-24 Thread johansen
On Wed, May 25, 2011 at 10:49:48AM +1200, Tim Foster wrote: > Sure. One other solution might be to have the zone-proxy-client > instances simply do nothing in the face of a missing connection to the > zone-proxyd (perhaps it could write a single SMF log entry to that > effect, but leave the client

Re: [pkg-discuss] Code review: sysrepo refactor

2011-05-24 Thread johansen
On Wed, May 25, 2011 at 10:38:11AM +1200, Tim Foster wrote: > I agree. The problem here is, that at the moment if the sysrepo breaks, > then zones-proxyd goes offline. Then all of the zones-proxy-client > services will drop to maintenance and need to be manually cleared in > each zone on the syst

Re: [pkg-discuss] Code review: sysrepo refactor

2011-05-24 Thread johansen
On Mon, May 23, 2011 at 11:04:12PM -0700, Edward Pilatowicz wrote: > i talked about this with krister last week and the conclusion we reached > was that if the sysrepo port was changed and the service was refreshed, > any outstanding connections would get dropped, and then to make sure new > connec

Re: [pkg-discuss] Code review: sysrepo refactor

2011-05-24 Thread johansen
On Tue, May 24, 2011 at 02:44:14PM +1200, Tim Foster wrote: > On Mon, 2011-05-23 at 19:07 -0700, Edward Pilatowicz wrote: > > why are we using restart_on='restart'? > > I think because zones-proxyd pulls configuration from the > system-repository SMF service, in particular, which port to open > co

Re: [pkg-discuss] webrev for small bugfixes

2011-05-17 Thread johansen
On Mon, May 16, 2011 at 04:05:59PM -0700, Edward Pilatowicz wrote: > 18342 pylint in the build is too noisy, it should only report errors Does this mean that I won't get a notification that my code is rated 10/10 every time a build? I was enjoying that extra boost to my self esteem. :( -j __

[pkg-discuss] 18277 zoneproxy client should release socket on orderly shutdown

2011-05-12 Thread johansen
Author: johansen Repository: /hg/pkg/gate Latest revision: 4b4ff1617157c6c0dce485e90d88bc36021ecf7b Total changesets: 1 Log message: 18277 zoneproxy client should release socket on orderly shutdown 18278 zoneproxy should excise list code 18279 zoneproxyd needs to refresh its config 18291

Re: [pkg-discuss] Code review: zoneproxy bugfixes

2011-05-11 Thread johansen
On Wed, May 11, 2011 at 12:02:18PM +1200, Tim Foster wrote: > Hi Krister, > > On Tue, 2011-05-10 at 16:10 -0700, johan...@opensolaris.org wrote: > > Folks, > > Here's a webrev for some zoneproxy fixes that didn't make the cutoff for > > b165. > >

Re: [pkg-discuss] Code review: zoneproxy bugfixes

2011-05-11 Thread johansen
On Wed, May 11, 2011 at 09:03:23AM -0700, Danek Duvall wrote: > johan...@opensolaris.org wrote: > > > http://cr.opensolaris.org/~johansen/webrev-18277/ > > This isn't part of your change, but if someone could explain why we're > setting LD_LIBRARY_PATH in

Re: [pkg-discuss] Code review: zoneproxy bugfixes

2011-05-11 Thread johansen
On Tue, May 10, 2011 at 05:40:42PM -0700, Edward Pilatowicz wrote: > On Tue, May 10, 2011 at 04:10:26PM -0700, johan...@opensolaris.org wrote: > > Folks, > > Here's a webrev for some zoneproxy fixes that didn't make the cutoff for > > b165. > > > >

[pkg-discuss] Code review: zoneproxy bugfixes

2011-05-10 Thread johansen
Folks, Here's a webrev for some zoneproxy fixes that didn't make the cutoff for b165. http://cr.opensolaris.org/~johansen/webrev-18277/ Thanks, -K ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.o

[pkg-discuss] 18240 zone proxy needed

2011-05-06 Thread johansen
Author: johansen Repository: /hg/pkg/gate Latest revision: 63a4d56416c6942a1c1b0e9f0f7f726f88bb9b7c Total changesets: 1 Log message: 18240 zone proxy needed 18265 pkg.sysrepo has weird notions about maximum port and cache size Files: create: src/brand/boot create: src/brand/halt

Re: [pkg-discuss] Code review for 18240

2011-05-04 Thread johansen
On Tue, May 03, 2011 at 04:56:51PM -0700, Edward Pilatowicz wrote: > - > src/svc/zoneproxyd.xml > > - don't run as root. instead, run as daemon and add in just the privs > you need. (which i'm guessing are file_owner and file_dac_read. if > you need additional privs you can figure o

Re: [pkg-discuss] [review] fixes for bugs 18193, 18195

2011-04-26 Thread johansen
On Wed, Apr 20, 2011 at 02:35:26PM -0700, Shawn Walker wrote: > Greetings, > > The following webrev contains fixes for the following issues: > > 18193 transport can traceback for packages that belong to a publisher > not in configuration > 18195 transport adds all publisher caches fro

Re: [pkg-discuss] Code review for system repository work

2011-04-19 Thread johansen
On Wed, Mar 30, 2011 at 09:36:05PM -0700, Brock Pytlik wrote: > Here's the system repository work that Tim and I have been working > on for quite a while now. > http://cr.opensolaris.org/~bpytlik/ips-sysrepo-v1/ I took a look at the transport changes here, and they look fine. -K _

Re: [pkg-discuss] [review] fix for bug 17679

2011-01-04 Thread johansen
On Tue, Jan 04, 2011 at 04:09:22PM -0800, Shawn Walker wrote: > Greetings, > > What follows is a simple change to setup.py to ensure our build > works if mime types change unexpectedly for external sources: > > 17679 setup.py checks during extern source retrieval too strict This looks right. I

Re: [pkg-discuss] Adjusting large user communities to the IPS versioning approach

2010-12-17 Thread johansen
On Fri, Dec 17, 2010 at 03:31:42PM -0800, Bart Smaalders wrote: > One can certainly add per-version metadata to packages indicating > that while version 12.1 is really 12-Weaselly Wombat!{1.2}g, > version 12.2 is 12-Pernicious Platypus/#-+++0.3 q. If it were up to me, I'd make 12.1 Alliteration Al

Re: [pkg-discuss] [REVIEW] Fix for bugs 17453, 17454

2010-11-19 Thread johansen
On Fri, Nov 19, 2010 at 02:43:22PM -0800, Danek Duvall wrote: > Shawn Walker wrote: > > > http://cr.opensolaris.org/~swalker/pkg-tip/ > > Looks okay to me. And to me. -j ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolari

Re: [pkg-discuss] enabling services by default

2010-11-19 Thread johansen
On Fri, Nov 19, 2010 at 11:09:21AM -0800, Chris Quenelle wrote: > Nothing's wrong if you know the right magic incantation. > How is the user supposed to know that turning on "gdm" will give him a > GUI login? I suppose Linux users would know because all Linux users > are by definition system admin

Re: [pkg-discuss] File timestamp - mtime/ctime/atime

2010-11-19 Thread johansen
On Fri, Nov 19, 2010 at 06:36:13PM +, Peter Dennis wrote: > On 19/11/2010 18:23, johan...@opensolaris.org wrote: > >If so, that's what the atime and mtime should be set to. Otherwise, > >you're depending on implementation specific behavior. The code in > >action.file makes a temporary file, a

Re: [pkg-discuss] File timestamp - mtime/ctime/atime

2010-11-19 Thread johansen
On Fri, Nov 19, 2010 at 06:00:45PM +, Peter Dennis wrote: > Hello, > > A question on timestamps when files are delivered to a system. > > o when doing the install the files receive timestamps based > upon the time of the install: > > machine1: > ls -l -% all ant > -rwxr-xr-x 1 root

Re: [pkg-discuss] [REVIEW] Fix for bug 17398

2010-11-12 Thread johansen
On Fri, Nov 12, 2010 at 02:59:32PM -0800, Shawn Walker wrote: > Greetings, > > The following webrev contains fixes for the following issue: > > 17398 repository rebuild index locking can cause traceback when using > NFS > > webrev: > http://cr.opensolaris.org/~swalker/pkg-nfs/ Looks

Re: [pkg-discuss] [REVIEW] packaging fix for pkg

2010-11-09 Thread johansen
On Tue, Nov 09, 2010 at 05:32:07PM -0800, Shawn Walker wrote: > On 11/ 9/10 05:25 PM, Tim Foster wrote: > >On Tue, 2010-11-09 at 17:04 -0800, Shawn Walker wrote: > >>http://cr.opensolaris.org/~swalker/pkg-tip/ > > > >Yep, this looks good. pkglint does catch the errors, but only when > >linting aga

Re: [pkg-discuss] [REVIEW] packaging fix for pkg

2010-11-09 Thread johansen
On Tue, Nov 09, 2010 at 05:04:12PM -0800, Shawn Walker wrote: > Greetings, > > The following webrev contains fixes for the following issue: > > 17379 packages for pkg have wrong groups assigned to various lib/svc > entries > > http://cr.opensolaris.org/~swalker/pkg-tip/ This looks rig

[pkg-discuss] 17377 content encoding errors should be retryable

2010-11-09 Thread johansen
Author: johansen Repository: /hg/pkg/gate Latest revision: 796ccf4dfa896c3938d3d5d147aa4889c30dfba6 Total changesets: 1 Log message: 17377 content encoding errors should be retryable Files: update: src/modules/client/transport/exception.py

[pkg-discuss] Another small code review: 17377

2010-11-09 Thread johansen
This one is so small that I'm attaching the diffs instead of generating a webrev. A user recently hit a problem with a gzip encoded download that kept failing with an E_BAD_CONTENT_ENCODING error. It turns out that if the gzip stream gets a CRC error, we can return this error. It should be retry

[pkg-discuss] 17327 pkg image-update to 151 raises NRLockException

2010-11-09 Thread johansen
Author: johansen Repository: /hg/pkg/gate Latest revision: c9985876d799e7f3b3b8ab92a58c131d2a2d0792 Total changesets: 1 Log message: 17327 pkg image-update to 151 raises NRLockException Files: update: src/modules/client/api.py ___ pkg-discuss

[pkg-discuss] Code review: 17327

2010-11-08 Thread johansen
Folks, Can I get a quick code review for the following bug fix? This is a two-line change, so it ought to be an easy review. http://cr.opensolaris.org/~johansen/webrev-17327/ Thanks, -j ___ pkg-discuss mailing list pkg-discuss@opensolaris.org

Re: [pkg-discuss] image-update in the background does not like set-publisher in the foreground

2010-11-08 Thread johansen
On Mon, Nov 08, 2010 at 07:29:37AM -0800, johan...@opensolaris.org wrote: > On Fri, Nov 05, 2010 at 08:18:16PM -0700, Darren Reed wrote: > > pkg: An unexpected error happened during image-update: Release of > > unacquired lock > > > > Traceback (most recent call last): > > File "/usr/bin/pkg", l

Re: [pkg-discuss] image-update in the background does not like set-publisher in the foreground

2010-11-08 Thread johansen
On Fri, Nov 05, 2010 at 08:18:16PM -0700, Darren Reed wrote: > pkg: An unexpected error happened during image-update: Release of > unacquired lock > > Traceback (most recent call last): > File "/usr/bin/pkg", line 4242, in handle_errors > __ret = func(*args, **kwargs) > File "/usr/bin/pkg"

Re: [pkg-discuss] [REVIEW] Fix for bug 17350

2010-11-04 Thread johansen
On Thu, Nov 04, 2010 at 02:09:27PM -0700, Shawn Walker wrote: > On 11/ 4/10 01:21 PM, johan...@opensolaris.org wrote: > >On Thu, Nov 04, 2010 at 11:33:21AM -0700, Shawn Walker wrote: > >>Greetings, > >> > >>The following webrev contains fixes for the following issue: > >> > >> 17350 depot smf sor

Re: [pkg-discuss] [REVIEW] Fix for bug 17350

2010-11-04 Thread johansen
On Thu, Nov 04, 2010 at 11:33:21AM -0700, Shawn Walker wrote: > Greetings, > > The following webrev contains fixes for the following issue: > > 17350 depot smf sort_file_max_size default of '' causes search > indexing problems > > webrev: > http://cr.opensolaris.org/~swalker/pkg-1735

Re: [pkg-discuss] [REVIEW] Fixes for bugs 15411, 17308

2010-10-28 Thread johansen
On Thu, Oct 28, 2010 at 04:21:54PM -0700, Shawn Walker wrote: > On 10/28/10 04:15 PM, Shawn Walker wrote: > >On 10/28/10 04:02 PM, Danek Duvall wrote: > >>Shawn Walker wrote: > >> > >>>http://cr.opensolaris.org/~swalker/pkg-15411/ > > I've updated the webrev in place. Changed files have a comment

Re: [pkg-discuss] [REVIEW] Fix for bug 17296

2010-10-26 Thread johansen
On Tue, Oct 26, 2010 at 03:32:17PM -0700, Danek Duvall wrote: > Shawn Walker wrote: > > > On 10/26/10 02:31 PM, Danek Duvall wrote: > > >Shawn Walker wrote: > > > > > >> http://cr.opensolaris.org/~swalker/pkg-tip/ > > > > I've updated the webrev based on comments. > > > > There's no diff as I

Re: [pkg-discuss] pkg error 134 -> 150

2010-10-25 Thread johansen
On Mon, Oct 25, 2010 at 01:15:54PM +0100, Jon Anderson wrote: > Hi Guys, > > Trying to update from 134 -> latest in http://ipkg.sfbay/dev which > I think is 150. Getting this error: > > Expected 48353 files, received 48354 files instead. > > Expected 790177689 bytes, received 790179005 bytes ins

Re: [pkg-discuss] [REVIEW] pkgrecv/pkgsend fixes and enhancements

2010-10-18 Thread johansen
On Mon, Oct 18, 2010 at 02:33:17PM -0700, Shawn Walker wrote: > Greetings, > > The following webrev contains fixes and enhancements for pkgrecv and > pkgsend: > > 16818 pkgrecv -d should publish per-package, not in one lump > 9197 pkgrecv could show progress indicator for republishing > 919

Re: [pkg-discuss] [REVIEW] client format and license acceptance changes

2010-10-12 Thread johansen
On Tue, Oct 12, 2010 at 02:36:30PM -0700, Shawn Walker wrote: > Greetings, > > The webrev linked below contains changes for the following items: > > 7276 /var/pkg metadata needs reorg (looks busy) > 5750 add versioning information for image meta data (cfg_cache, etc.) > 7273 manifests shoul

Re: [pkg-discuss] [REVIEW] client format and license acceptance changes

2010-10-12 Thread johansen
On Tue, Oct 12, 2010 at 02:36:30PM -0700, Shawn Walker wrote: > Greetings, > > The webrev linked below contains changes for the following items: > > 7276 /var/pkg metadata needs reorg (looks busy) > 5750 add versioning information for image meta data (cfg_cache, etc.) > 7273 manifests shoul

Re: [pkg-discuss] code review request

2010-10-04 Thread johansen
On Mon, Oct 04, 2010 at 03:34:06PM -0700, Bart Smaalders wrote: > Pretty simple: > > http://cr.opensolaris.org/~barts/12530/ Looks good. -j ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discus

Re: [pkg-discuss] Code review for 17151

2010-10-04 Thread johansen
On Mon, Oct 04, 2010 at 02:00:02PM -0700, Brock Pytlik wrote: > Webrev: > http://cr.opensolaris.org/~bpytlik/ips-17151-v1/ > > Bug: > 17151 importer.py crashes post build 149 > > The bug contains more details bug the short version is that the api > version needed revving and the variants co

[pkg-discuss] 17144 Unix socket support is defunct

2010-10-01 Thread johansen
Author: johansen Repository: /hg/pkg/gate Latest revision: 6a366b063036fba80ed3c2df865b1c1dfdec5e56 Total changesets: 1 Log message: 17144 Unix socket support is defunct 17145 Add pycurl support for proxy username and password Files: delete: doc/system-repository.txt delete: src

[pkg-discuss] Code Review: Removal of UNIX socket support

2010-09-29 Thread johansen
tches Pycurl to better support proxy authentication. http://cr.opensolaris.org/~johansen/webrev-17144/ Thanks, -j ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Re: [pkg-discuss] [REVIEW] Fixes for bugs 17055, 8785, 16109, 17117

2010-09-27 Thread johansen
On Mon, Sep 27, 2010 at 04:51:18PM -0700, Shawn Walker wrote: > Greetings, > > The following webrev contains fixes for the following issues: > > 17055 image configuration should use pkg.config classes > 8785 ImageConfig.read() should reset itself completely before reading > 16109 imageconfi

Re: [pkg-discuss] Code review: fixes for some pkglint usability bugs

2010-09-27 Thread johansen
On Mon, Sep 27, 2010 at 03:06:11PM +1300, Tim Foster wrote: > Hi All, > > I've got a small pkglint webrev here, which fixes some usability bugs & > enhancements, and was wondering if I could get a code review please? > > http://cr.opensolaris.org/~timf/pkglint-cli-webrev lint/engine.py - line

Re: [pkg-discuss] [REVIEW] Changes for RFE 2775, bug 15462

2010-09-22 Thread johansen
On Wed, Sep 22, 2010 at 03:39:45PM -0700, Shawn Walker wrote: > On 09/10/10 06:48 PM, Shawn Walker wrote: > >Greetings, > > > >The following webrev contains changes for the following items: > > > >2775 pkg should provide a way to downgrade (reinstall) packages > >15462 pkg install subcommand needs

Re: [pkg-discuss] Code review for pkglint info.classification and underscore checks

2010-09-22 Thread johansen
Hey Tim, On Thu, Sep 23, 2010 at 09:22:29AM +1200, Tim Foster wrote: > http://cr.opensolaris.org/~timf/info-classification-webrev I asked Danek about this a couple of weeks ago, but his opinion was that two reviewers were only necessary for our restricted builds, or when additional scrutiny was d

Re: [pkg-discuss] Code review for 15958 please

2010-09-17 Thread johansen
On Fri, Sep 17, 2010 at 06:38:53PM -0700, Brock Pytlik wrote: > On 09/17/10 06:24 PM, johan...@opensolaris.org wrote: > >On Fri, Sep 17, 2010 at 06:13:41PM -0700, Brock Pytlik wrote: > >> And yet one more webrev which addresses some issues with pkglint > >>that Tim noticed. > >> > >>The major cha

Re: [pkg-discuss] Code review for 15958 please

2010-09-17 Thread johansen
On Fri, Sep 17, 2010 at 06:13:41PM -0700, Brock Pytlik wrote: > And yet one more webrev which addresses some issues with pkglint > that Tim noticed. > > The major changes are in the src/module/lint/* files. Also, a > difference method has been added to VariantCombinationTemplate in > src/modules/

Re: [pkg-discuss] [REVIEW] Fix for bug 17049

2010-09-15 Thread johansen
On Wed, Sep 15, 2010 at 02:03:54PM -0700, Shawn Walker wrote: > Greetings, > > The following webrev contains a fix for the following issue: > > 17049 operations can fail with cache error when creating new be > > This was just introduced in the current gate build and I happened to > spot the pr

Re: [pkg-discuss] [REVIEW] Fix for bug 17033

2010-09-14 Thread johansen
On Tue, Sep 14, 2010 at 05:39:09PM -0700, Shawn Walker wrote: > Greetings, > > The following webrev contains fixes for the following issue: > > 17033 operations can fail with traceback if no packages are added > or removed > > webrev: > http://cr.opensolaris.org/~swalker/pkg-17033/ Looks good

Re: [pkg-discuss] [trivial review] pkg gate could use a caching example

2010-09-14 Thread johansen
On Tue, Sep 14, 2010 at 03:51:43PM -0700, Erik Trauschke wrote: > Hi folks, > > so there seem to be a lot of folks who have questions about setting up > Apache disk caching with the depot servers. So Shawn was thinking we > should put an example in the gate: > > http://cr.opensolaris.org/~erisch/

[pkg-discuss] 17044 pkg(1) refers to non-existent pkg.mdnsd(1M) manpage

2010-09-14 Thread johansen
Author: johansen Repository: /hg/pkg/gate Latest revision: 493e37f51c95bf9acb51d4db271e9b5dca42f5e9 Total changesets: 1 Log message: 17044 pkg(1) refers to non-existent pkg.mdnsd(1M) manpage Files: update: src/man/pkg.1.txt ___ pkg-discuss

[pkg-discuss] Code Review: 17044

2010-09-14 Thread johansen
I can't type today, which has made this whole bug, and fix, more amusing. The following is a small fix for the pkg(1) manpage. The mdns functionality is described in pkg.depotd(1m). The references to pkg.mdnsd(1M) are for a manpage that we decided not to write during code review, I just somehow

Re: [pkg-discuss] [REVIEW] Changes for RFE 2775, bug 15462

2010-09-13 Thread johansen
Hey Shawn, On Fri, Sep 10, 2010 at 06:48:19PM -0700, Shawn Walker wrote: > Greetings, > > The following webrev contains changes for the following items: > > 2775 pkg should provide a way to downgrade (reinstall) packages > 15462 pkg install subcommand needs to indicate it can be used for > u

Re: [pkg-discuss] [REVIEW] Fixes for bugs 16998, 9572, 14613, 16261, 16921, 16996, 16997, 17006

2010-09-13 Thread johansen
On Mon, Sep 13, 2010 at 03:05:12PM -0700, Shawn Walker wrote: > On 09/ 9/10 03:45 PM, Shawn Walker wrote: > >Greetings, > > > >The following webrev contains fixes for the following issues: > > > >16998 transport should support publisher-specific write and read caches > >9572 FactoredManifest should

[pkg-discuss] 16641 transport operations need ability to accept alternate Repository

2010-09-13 Thread johansen
Author: johansen Repository: /hg/pkg/gate Latest revision: 604fffd79b385dd297c30ff40c6cde13945fa98a Total changesets: 1 Log message: 16641 transport operations need ability to accept alternate Repository Files: update: src/modules/client/transport/transport.py

Re: [pkg-discuss] Code Review: Alternate repository selection

2010-09-13 Thread johansen
On Mon, Sep 13, 2010 at 01:37:43PM -0700, Danek Duvall wrote: > johan...@opensolaris.org wrote: > > > http://cr.opensolaris.org/~johansen/webrev-16641/ > > Sometimes you call it "alt_repository", and sometimes you call it > "alt_repo". I take

[pkg-discuss] Code Review: Alternate repository selection

2010-09-13 Thread johansen
ok at this, and is fine with the change. If anyone else wants to review this before I put it back, let me know. If I don't hear anything, I'll integrate later this afternoon. http://cr.opensolaris.org/~johansen/webrev-16641/ Thanks, -j

Re: [pkg-discuss] [REVIEW] Fixes for bugs 16998, 9572, 14613, 16261, 16921, 16996, 16997, 17006

2010-09-10 Thread johansen
Hi Shawn, On Thu, Sep 09, 2010 at 03:45:07PM -0700, Shawn Walker wrote: > Greetings, > > The following webrev contains fixes for the following issues: > > 16998 transport should support publisher-specific write and read caches > 9572 FactoredManifest should allow consumers to specify cache l

Re: [pkg-discuss] Installing further packages with an offline repo

2010-09-09 Thread johansen
On Thu, Sep 09, 2010 at 09:04:18PM -0700, Darren Reed wrote: > >>I think I'll add a "pkg set publisher -d darrenr" to my > >>first-boot-install service.. > >Maybe I don't understand your problem, but once you've disabled a > >publisher it should stay disabled. In your script, please use --disable

Re: [pkg-discuss] Installing further packages with an offline repo

2010-09-09 Thread johansen
On Thu, Sep 09, 2010 at 06:22:37PM -0700, Darren Reed wrote: > On 9/09/10 05:48 PM, johan...@opensolaris.org wrote: > >On Thu, Sep 09, 2010 at 05:40:46PM -0700, Darren Reed wrote: > >>In my test environment, I ran a depot server as publisher "darrenr" > >>to provide a custom package during the ini

Re: [pkg-discuss] Installing further packages with an offline repo

2010-09-09 Thread johansen
On Thu, Sep 09, 2010 at 05:40:46PM -0700, Darren Reed wrote: > In my test environment, I ran a depot server as publisher "darrenr" > to provide a custom package during the initial install. I've since > disabled that but now "pkg install" (to install a package from > opensolaris.org) complains becau

Re: [pkg-discuss] [REVIEW] Fix for bug 10148

2010-09-09 Thread johansen
On Thu, Sep 09, 2010 at 05:14:52PM -0700, Shawn Walker wrote: > Greetings, > > The following webrev contains changes for the following RFE: > >10148 successful image operations with no effect should be elided > from history > > webrev: > http://cr.opensolaris.org/~swalker/pkg-10148/ Looks g

Re: [pkg-discuss] pkg verify and elfhash...

2010-09-09 Thread johansen
On Thu, Sep 09, 2010 at 02:12:05PM -0700, Shawn Walker wrote: > On 09/ 9/10 02:02 PM, johan...@opensolaris.org wrote: > ... > >IMO, the case for verifying compromised systems duplicates functionality > >already implemented in bart(1) and tripwire, but I'm willing to listen > >to reasonable argument

Re: [pkg-discuss] pkg verify and elfhash...

2010-09-09 Thread johansen
On Thu, Sep 09, 2010 at 01:46:34PM -0700, Darren Reed wrote: > Should RFEs for pkg go into bugzilla or bugster? > > I think I can see two separate RFEs here: > > - being able to specify the source of the information used to > verify the package manifests (and installed data) rather than > rel

Re: [pkg-discuss] pks search fails with 503 Service unavailable

2010-09-09 Thread johansen
On Thu, Sep 09, 2010 at 09:19:38AM +0200, Paul van der Zwan wrote: > Thanks, that fixed it, but this is the first time I ever needed to do > this after extracting the repo isos IMHO That means something has > changed in the way either the repo isos are built or the way the repo > server behaves bec

Re: [pkg-discuss] pkg verify and elfhash...

2010-09-08 Thread johansen
On Wed, Sep 08, 2010 at 03:34:57PM -0500, Nicolas Williams wrote: > (Avoiding the need to boot from media is in large part what Validated > Execution is about.) Read only root would have been a simpler solution to that problem. -j ___ pkg-discuss mailin

Re: [pkg-discuss] pks search fails with 503 Service unavailable

2010-09-08 Thread johansen
On Wed, Sep 08, 2010 at 09:33:30AM +0200, Paul van der Zwan wrote: > $ pkg search thunderbird > pkg: Some repositories failed to respond appropriately: > opensolaris.org: > http protocol error: code: 503 reason: Service Unavailable > URL: 'http://vetinari:8080/search/1/False_2_None_None_%3A%3A%3Ath

Re: [pkg-discuss] Need to manually create a dependency

2010-09-07 Thread johansen
On Tue, Sep 07, 2010 at 02:28:57PM -0700, Ben Chang wrote: >Thanks. > >Also thanks to those of you who answered Shawn's question about "make". > >BTW, are there any test suites that I need to run before RTI'ing > my code change? You might consider running pkglint(1) and pkgdep(1) aga

Re: [pkg-discuss] [review] fixes for bugs 16982, 16941, 16949

2010-09-07 Thread johansen
Hi Shawn, On Sat, Sep 04, 2010 at 11:20:21PM -0700, Shawn Walker wrote: > webrev: > http://cr.opensolaris.org/~swalker/pkg-16982/ This looks good. Everything that follows are just nits. man/pkg.depotd.1m.txt: - lines 17-21: This is fine as is, but the editor in me wants to break this in

Re: [pkg-discuss] Code review for 16852

2010-09-07 Thread johansen
ude int main(void) { int rc; char *args[1]; args[0] = NULL; rc = execv("/home/johansen/args", args); if (rc < 0) { perror("execv"); exit(EXIT_FAILURE); } return (0); } If I run the first

Re: [pkg-discuss] 16976 transport caching mechanism for file repository needs update

2010-09-07 Thread johansen
Did anybody review this fix? I would have liked to. -j On Tue, Sep 07, 2010 at 08:26:09PM +, shawn.wal...@oracle.com wrote: > Author: Shawn Walker > Repository: /hg/pkg/gate > Latest revision: 2aef71869aaa5e3dda39f6b2371b7d9d990be6c3 > Total changesets: 1 > Log message: > 16976 transport ca

[pkg-discuss] 16981 pkgrecv republication should get publisher prefix, not configuration

2010-09-03 Thread johansen
Author: johansen Repository: /hg/pkg/gate Latest revision: a4a664a78547f8586a01a20b15635ecd419eaec3 Total changesets: 1 Log message: 16981 pkgrecv republication should get publisher prefix, not configuration Files: update: src/pull.py ___ pkg

Re: [pkg-discuss] Code Review: 16981

2010-09-03 Thread johansen
On Fri, Sep 03, 2010 at 05:34:15PM -0700, Shawn Walker wrote: > Seems right to me, although what about the lines around 457? We > really want to use the source origins? I had thought that the source publisher configuration would be less problematic, but I'm willing to consider other options. My

[pkg-discuss] Code Review: 16981

2010-09-03 Thread johansen
Folks, My most recent putback got the publisher configuration aspect of the pkgrecv(1) republication wrong. The client should have been retrieving the remote prefix, but not the entireity of the remote configuration. This 2-line fix solves the problem, and makes everything work the way that it sho

[pkg-discuss] 10390 make pkgrecv gracefully handle existing packages in destination

2010-09-03 Thread johansen
Author: johansen Repository: /hg/pkg/gate Latest revision: 874a83b3e8d10ad76999a5383218e47ada25a2c9 Total changesets: 1 Log message: 10390 make pkgrecv gracefully handle existing packages in destination Files: update: src/pull.py update: src/tests/cli/t_pkgrecv.py

Re: [pkg-discuss] Code Review: pkgrecv and pre-existing packages

2010-09-03 Thread johansen
Hi Danek, Thanks for reviewing this. On Fri, Sep 03, 2010 at 02:13:19PM -0700, Danek Duvall wrote: > johan...@opensolaris.org wrote: > > > http://cr.opensolaris.org/~johansen/webrev-10390/ > > pull.py: > > - line 447: You might add a comment explaining w

Re: [pkg-discuss] why does pkgrepo complain for empty directory?

2010-09-03 Thread johansen
On Fri, Sep 03, 2010 at 02:05:25PM -0700, Shawn Walker wrote: > Yes, I'm aware it's simple to do, it just seemed somewhat wrong that > given that a repository is a pre-defined set of directories that a > creation operation wouldn't actually be the one to create that > entire set. Another possibili

Re: [pkg-discuss] why does pkgrepo complain for empty directory?

2010-09-03 Thread johansen
On Fri, Sep 03, 2010 at 01:53:09PM -0700, Shawn Walker wrote: > This was done intentionally because we essentially have no way to > guarantee that the target directory isn't being used for something > else or that continuing with the operation won't cause loss of data > or other unexpected behaviou

Re: [pkg-discuss] Short code review for bug 16977

2010-09-03 Thread johansen
On Thu, Sep 02, 2010 at 08:04:07PM -0700, Brock Pytlik wrote: > Webrev: > http://cr.opensolaris.org/~bpytlik/ips-16977-v1/ > > Bug: > 16977 Test needed for advanced signature version This looks fine. -j ___ pkg-discuss mailing list pkg-discuss@opensola

  1   2   3   4   5   6   7   8   9   10   >