Re: [pkg-go] Call for review - containerd and dependencies

2018-03-21 Thread Arnaud Rebillout
On 03/21/2018 03:12 PM, Arnaud Rebillout wrote: > > On 03/21/2018 02:55 PM, Michael Stapelberg wrote: >> >> >> On Tue, Mar 20, 2018 at 11:59 AM, Arnaud Rebillout >> > > wrote: >> >> >> On 03/20/2018 02:36 PM, Michael

Re: [pkg-go] Call for review - containerd and dependencies

2018-03-21 Thread Arnaud Rebillout
On 03/21/2018 02:55 PM, Michael Stapelberg wrote: > > > On Tue, Mar 20, 2018 at 11:59 AM, Arnaud Rebillout > > wrote: > > > On 03/20/2018 02:36 PM, Michael Stapelberg wrote: >> >> >> Uploaded. >>   >> >> >> >>

Re: [pkg-go] Call for review - containerd and dependencies

2018-03-21 Thread Michael Stapelberg
On Tue, Mar 20, 2018 at 11:59 AM, Arnaud Rebillout < arnaud.rebill...@collabora.com> wrote: > > > On 03/20/2018 02:36 PM, Michael Stapelberg wrote: > > > > On Mon, Mar 19, 2018 at 3:29 AM, Arnaud Rebillout < > arnaud.rebill...@collabora.com> wrote: > >> Hello all, let me follow up on this ! >> >>

Re: [pkg-go] Call for review - containerd and dependencies

2018-03-20 Thread Arnaud Rebillout
On 03/20/2018 02:36 PM, Michael Stapelberg wrote: > > > On Mon, Mar 19, 2018 at 3:29 AM, Arnaud Rebillout > > wrote: > > Hello all, let me follow up on this ! > > According to discussions on this mailing list, I

Re: [pkg-go] Call for review - containerd and dependencies

2018-03-20 Thread Michael Stapelberg
On Mon, Mar 19, 2018 at 3:29 AM, Arnaud Rebillout < arnaud.rebill...@collabora.com> wrote: > Hello all, let me follow up on this ! > > According to discussions on this mailing list, I made the following > changes on the packages: > - the license issues have been clarified with containerd

Re: [pkg-go] Call for review - containerd and dependencies

2018-03-18 Thread Arnaud Rebillout
Hello all, let me follow up on this ! According to discussions on this mailing list, I made the following changes on the packages: - the license issues have been clarified with containerd projects, except for containerd-typeurl which doesn't receive much attention from upstream. As a consequence

Re: [pkg-go] Call for review - containerd and dependencies

2018-03-12 Thread Michael Stapelberg
On Fri, Mar 2, 2018 at 4:38 AM, Arnaud wrote: > Hi, > > I addressed all your comments, thanks very much for the feedback. More > details bellow. > > On 02/28/2018 04:05 PM, Michael Stapelberg wrote: > > > >> containerd >>

Re: [pkg-go] Call for review - containerd and dependencies

2018-03-01 Thread Arnaud
Hi, I addressed all your comments, thanks very much for the feedback. More details bellow. On 02/28/2018 04:05 PM, Michael Stapelberg wrote: > > > containerd > > >

Re: [pkg-go] Call for review - containerd and dependencies

2018-02-28 Thread Michael Stapelberg
On Wed, Feb 28, 2018 at 3:49 AM, Arnaud wrote: > > > On 02/27/2018 03:32 AM, Michael Stapelberg wrote: > > Once you feel your packages are ready for review (possibly this reply > > prompts some changes?), please send an up-to-date list of git URLs to > > what

Re: [pkg-go] Call for review - containerd and dependencies

2018-02-27 Thread Arnaud
On 02/27/2018 03:32 AM, Michael Stapelberg wrote: > > There's a `docs/.gitignore`, it's in a subdirectory. Files-Excluded > will remove it from the orig tarball, right ? Is it really suitable here ? > > Correct, and up to you (see the caveat which tincho expressed). Bug > #812721 discusses a gbp

Re: [pkg-go] Call for review - containerd and dependencies

2018-02-27 Thread Arnaud
On 02/27/2018 03:32 AM, Michael Stapelberg wrote: > Once you feel your packages are ready for review (possibly this reply > prompts some changes?), please send an up-to-date list of git URLs to > what you’d like reviewed. Thanks! Ok, here is the package list again, I prefer to leave all the

Re: [pkg-go] Call for review - containerd and dependencies

2018-02-26 Thread Michael Stapelberg
Once you feel your packages are ready for review (possibly this reply prompts some changes?), please send an up-to-date list of git URLs to what you’d like reviewed. Thanks! Replies inline: On Fri, Feb 23, 2018 at 11:40 AM, Arnaud wrote: > > > On 02/23/2018

Re: [pkg-go] Call for review - containerd and dependencies

2018-02-23 Thread Martín Ferrari
On 23/02/18 11:10, Michael Stapelberg wrote: > Which file specifically is affected? The Files-Excluded directive in > debian/copyright is a good way to exclude files. Not anymore.. If you are not using import-orig and the like, that is effectively ignored. -- Martín Ferrari (Tincho)

Re: [pkg-go] Call for review - containerd and dependencies

2018-02-23 Thread Arnaud
On 02/23/2018 05:10 PM, Michael Stapelberg wrote: > I can’t have a look at the individual packages right now No rush ! > containerd > > > - There's a lintian

Re: [pkg-go] Call for review - containerd and dependencies

2018-02-23 Thread Michael Stapelberg
I can’t have a look at the individual packages right now (but might have some time in the evening/over the weekend), but here’s some quick feedback: On Fri, Feb 23, 2018 at 11:01 AM, Arnaud wrote: > Hello Go Packaging Team, > > I reached a milestone, I managed to

[pkg-go] Call for review - containerd and dependencies

2018-02-23 Thread Arnaud
Hello Go Packaging Team, I reached a milestone, I managed to get an up-to-date containerd package! I changed a bit my workflow and worked on my "personal staging area" in salsa, ie `salsa.debian.org/elboulangero-guest`, rather than directly in `salsa.debian.org/go-team`. I find it more