[Pkg-javascript-devel] Bug#853035: node-liftoff: Non-determistically FTBFS due to unreliable timing in tests
Hi Graham, > > I'm pretty hardcore on tests being determinstic, so merely increasing > > the wait time feels especially gross to me. :) > > Would you please explain your objection to timeouts in tests? Well, we should probably separate the cases of using /timing/ in tests as part of, say, checking whether something is "fast enough" or an algorithm is O(n) vs O(n^2) and timing that is essentially relying on the machine not being under load or is otherwise slow. I am sure you would agree the former is problematic and not even remotely determinstic! The latter is borderline, but when you can't rely on test failures being genuine test failures, you psychologically start to demote them in your mind in terms of importance and whether you should care about the,. > I think it is practical to give up waiting for a response some point. > Even Debian's buildds give up after 150 minutes. Mm, as a sanity check for the integrity of the test/build platform, timing out after X hours or so makes sense and I have no problem with this. It's just the stuff on the order of Y seconds that is a little bit more difficult to justify. :) (Can this test really not reliably detect whether something was killed/ spawned...?) Best wishes, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#853035: node-liftoff: Non-determistically FTBFS due to unreliable timing in tests
[Resending including 853...@bugs.debian.org in CC this time..]
Hi Graham,
Thanks for the followup.
> Chris, you wrote "...the test would still be unreliable whatever value
> you choose", can you propose something other than increasing the
> timeout?
Well, just to be 100% clear, I don't propose increasing the timeout at
all: I'm pretty hardcode on tests being determinstic so merely increasing
the wait time feels especially gross to me. :)
So, indeed, another solution is really required but alas I'm really not
familiar with this particular test nor this package in general so I would
not be able to comment with any authority.
Have you tried speaking to upstream?
Best wishes,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#892425: node-package-preamble: please make the output reproducible
Hi Ben,
> Is this change generally useful to recipients of the upstream code base?
> Or is it specific to OS distributions?
It is generally useful, not specific to any OS.
> Does this constitute an improvement to the upstream code base? Or should
> remain a persistent patch in the Debian package?
Upstream. I've filed it here:
https://github.com/mbostock/preamble/pull/4
> Does this change apply more generally to many JavaScript packages?
Not that I am aware of. It would only apply to a limit subset of
packages where:
a) We use the output during a package build
b) That output ends up in the resulting binaries
c) The output actually is not reproducible (ie. dates).
(The only other example I can recall right now is in uglifyjs which
has non- determinstic dictionary ordering IIRC.)
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#892425: node-package-preamble: please make the output reproducible
forwarded 892425 https://github.com/mbostock/preamble/pull/4 thanks I've forwarded this upstream here: https://github.com/mbostock/preamble/pull/4 Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#892425: node-package-preamble: please make the output reproducible
Source: node-package-preamble
Version: 0.1.0-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: toolchain timestamps
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Hi,
Whilst working on the Reproducible Builds effort [0], we noticed
that node-package-preamble generates output that is not
reproducible which is affecting the reproducibility of (at least)
5 packages.
Patch attached.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
diff --git a/bin/preamble b/bin/preamble
index a563140..be96d96 100755
--- a/bin/preamble
+++ b/bin/preamble
@@ -3,12 +3,17 @@
var os = require("os"),
fs = require("fs");
+var now = new Date();
+if (process.env.SOURCE_DATE_EPOCH) {
+ now = new Date((process.env.SOURCE_DATE_EPOCH * 1000) +
(now.getTimezoneOffset() * 6));
+}
+
fs.readFile("package.json", "utf8", function(error, text) {
if (error) throw error;
var json = JSON.parse(text);
process.stdout.write("// " + (json.homepage || json.name)
+ " Version " + json.version + "."
- + " Copyright " + (new Date).getFullYear()
+ + " Copyright " + now.getFullYear()
+ " " + json.author.name + (/\.$/.test(json.author.name) ? "" : ".")
+ os.EOL);
});
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#891899: node-rollup: please make the build reproducible
forwarded 891899 https://github.com/rollup/rollup/pull/2024 thanks I've forwarded this upstream here: https://github.com/rollup/rollup/pull/2024 Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#891899: node-rollup: please make the build reproducible
Source: node-rollup
Version: 0.50.0-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Hi,
Whilst working on the Reproducible Builds effort [0], we noticed
that node-rollup could not be built reproducibly as it encodes
the current build time via "new Date()".
Patch attached.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
--- a/debian/patches/0001-reproducible-build.patch 1970-01-01
01:00:00.0 +0100
--- b/debian/patches/0001-reproducible-build.patch 2018-03-02
09:41:49.392154726 +
@@ -0,0 +1,19 @@
+Description: Make the build reproducible
+Author: Chris Lamb <la...@debian.org>
+Last-Update: 2018-03-02
+
+--- node-rollup-0.50.0.orig/rollup.config.js
node-rollup-0.50.0/rollup.config.js
+@@ -14,9 +14,11 @@ const commitHash = (function() {
+ }
+ })();
+
++const now = new Date(process.env.SOURCE_DATE_EPOCH ?
(process.env.SOURCE_DATE_EPOCH * 1000) : new Date().getTime());
++
+ const banner = readFileSync('src/banner.js', 'utf-8')
+ .replace('${version}', pkg.version)
+- .replace('${time}', new Date())
++ .replace('${time}', now.toUTCString())
+ .replace('${commitHash}', commitHash);
+
+ export default [
--- a/debian/patches/series 1970-01-01 01:00:00.0 +0100
--- b/debian/patches/series 2018-03-02 09:20:55.357126507 +
@@ -0,0 +1 @@
+0001-reproducible-build.patch
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] three.js_80+dfsg2-2_amd64.changes REJECTED
Pirate Praveen wrote: > > I'm lost already, sorry. As I understand the case of three.js's recent > > rejection, no other ftp-master said anything and thus there cannot be > > any dissention. > > I think it would be better if that is made explicit else how many days > should someone wait to see no response and assume no dissent? or is to > be always assumed there won't be any dissent? Apologies, but this reads like another non-sequitur to me. Why would deciding on a number of days before one can assume _no_ dissent make any difference at all to the case of three.js given that you are claiming there _is_ dissent? Best wishes, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] three.js_80+dfsg2-2_amd64.changes REJECTED
Pirate, > 1. If a single ftp master is in disagreement, there should be a team > decision (in previous cases of disagreement also, other team members did > not get involved). I'm lost already, sorry. As I understand the case of three.js's recent rejection, no other ftp-master said anything and thus there cannot be any dissention. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-has_1.0.1-1_amd64.changes REJECTED
Author: Bastian Blank Version: 1.0.1-1 Timestamp: 2017-12-31 16:51:18.148440+00:00 REJECT redicolous short code === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-is-svg_2.1.0-1_amd64.changes REJECTED
Author: Bastian Blank Version: 2.1.0-1 Timestamp: 2017-12-31 16:07:45.213504+00:00 REJECT metadata larger the code, should be replaced by generic libmagic wrapper as used by everyone else === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] three.js_80+dfsg2-2_amd64.changes REJECTED
Author: Bastian Blank Version: 80+dfsg2-2 Timestamp: 2017-12-15 15:15:24.424738+00:00 REJECT no need to have with one just two symlinks in the node.js path === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Comments regarding node-node-localstorage_1.3.0-2_amd64.changes
Might be worth using "Laurence (Larry) Maccherone" - this alternative/nickname can be somewhat Western-centric. -- Chris Lamb <la...@debian.org> Thu, 22 Feb 2018 10:38:40 + -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-flow-remove-types_1.2.3-1_amd64.changes REJECTED
debian/copyright says "Copyright: 2017 Lee Byron <l...@leebyron.com>" but LICENSE says Copyright (c) 2014-2016, Facebook, -- Chris Lamb <la...@debian.org> Sat, 17 Feb 2018 22:06:15 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-node-localstorage_1.3.0-1_amd64.changes REJECTED
Hi! I think either: a) Your source package name is wrong b) You need to justify it somewhere (README.source, debian/copyright, debian/changelog?) -- Chris Lamb <la...@debian.org> Sat, 17 Feb 2018 21:49:35 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#886277: node-promise: please make the build reproducible
forwarded 886277 https://github.com/then/promise/pull/148
thanks
Hi.
Updated patch attached and noting the new upstream pull request at:
https://github.com/then/promise/pull/148
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
From a6d0176784d16315a89ae12b2abe5395255b963d Mon Sep 17 00:00:00 2001
From: Chris Lamb <ch...@chris-lamb.co.uk>
Date: Sun, 11 Feb 2018 16:39:00 +
Subject: [PATCH] Make the build reproducible
Whilst working on the Reproducible Builds effort [0], we noticed
that node-promise could not be built reproducibly as it uses
random numbers as throwaway identifiers.
This patch uses a determinstic suffix for these identifiers based
on the contents of the src/ directory.
This was filed in @Debian as https://bugs.debian.org/886277. There was
also a previous aborted attempt in #146.
[0] https://reproducible-builds.org/
[1] https://github.com/then/promise/pull/146
Signed-off-by: Chris Lamb <ch...@chris-lamb.co.uk>
---
build.js | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/build.js b/build.js
index 1e028e9..eb984d8 100644
--- a/build.js
+++ b/build.js
@@ -4,19 +4,17 @@ var fs = require('fs');
var rimraf = require('rimraf');
var acorn = require('acorn');
var walk = require('acorn/dist/walk');
+var crypto = require('crypto');
-var ids = [];
-var names = {};
+var shasum = crypto.createHash('sha512');
+fs.readdirSync(__dirname + '/src').forEach(function (filename) {
+ shasum.update(fs.readFileSync(__dirname + '/src/' + filename, 'utf8'));
+});
+var salt = shasum.digest('hex');
+// Deterministic 4 char suffix seeded from contents of src
function getIdFor(name) {
- if (name in names) return names[name];
- var id;
- do {
-id = '_' + Math.floor(Math.random() * 100);
- } while (ids.indexOf(id) !== -1)
- ids.push(id);
- names[name] = id;
- return id;
+ return '_' + crypto.pbkdf2Sync(name, salt, 0, 2, 'sha512').toString('hex');
}
function fixup(src) {
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Should Debian be shipping node-promise?
Hi, FYI upstream don't seem to think we should be building node-promise from source: https://github.com/then/promise/pull/146 Ignoring any legal argument, does that mean we "should" be shipping this in Debian? Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-fbjs_0.8.16-1_amd64.changes REJECTED
Contains un-attributed code copies of (at least) parts of underscore.js. -- Chris Lamb <la...@debian.org> Sat, 06 Jan 2018 20:06:30 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Comments regarding node-prop-types_15.6.0+ds-1_amd64.changes
vcs-browser 404s. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#886290: node-timed-out: FTBFS: Assumes
Source: node-timed-out Version: 4.0.1-1 Severity: serious Justification: fails to build from source User: reproducible-bui...@lists.alioth.debian.org Usertags: ftbfs X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Dear Maintainer, node-timed-out fails to build from source in unstable/amd64. Not sure why it fails to timeout when accessing http://192.0.2.1 but this seems to be a broken way of testing anyway... […] 1) should emit ETIMEDOUT when connection timeout expires when connection is established ✓ should emit ESOCKETTIMEDOUT (no data) (221ms) ✓ should emit ESOCKETTIMEDOUT (only first chunk of body) (313ms) ✓ should be able to only apply connect timeout ✓ should be able to only apply socket timeout (55ms) ✓ should not add event handlers twice for the same socket ✓ should set socket timeout if socket is already connected (211ms) ✓ should clear socket timeout for keep-alive sockets 7 passing (3s) 1 failing 1) should emit ETIMEDOUT when connection timeout expires: Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. at Timeout. (/usr/lib/nodejs/mocha/lib/runnable.js:238:19) debian/rules:13: recipe for target 'override_dh_auto_test' failed make[1]: *** [override_dh_auto_test] Error 1 […] The full build log is attached or can be viewed here: https://tests.reproducible-builds.org/debian/logs/unstable/amd64/node-timed-out_4.0.1-1.build1.log.gz Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- node-timed-out.4.0.1-1.unstable.amd64.log.txt.gz Description: Binary data -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#886288: node-macaddress: FTBFS: Assumes build environment has network interfaces
Source: node-macaddress Version: 0.2.8-1 Severity: serious Justification: fails to build from source User: reproducible-bui...@lists.alioth.debian.org Usertags: ftbfs X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Dear Maintainer, node-macaddress fails to build from source in amd64/unstable if there are no network interfaces: dh_auto_test node test.js /build/1st/node-macaddress-0.2.8/test.js:5 throw err || mac; ^ no interfaces found debian/rules:13: recipe for target 'override_dh_auto_test' failed Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#886287: node-coveralls: FTBFS: makes assumptions about build path
Source: node-coveralls Version: 3.0.0-1 Severity: serious Justification: fails to build from source User: reproducible-bui...@lists.alioth.debian.org Usertags: ftbfs X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Dear Maintainer, node-coveralls fails to build from source in amd64/unstable if you rename the build directory. I see you patch the upstream function but the whole thing is too brittle IMHO. eg. $ cd $(mktemp -d) $ apt-get source node-coveralls $ mv node-coveralls*/ renamed $ cd renamed $ dpkg-buildpackage -uc -us […] 2) detectLocalGit "after all" hook: Error: Tried to clean a temp git directory that did not match path: node-coveralls/test at _deleteFolderRecursive (test/detectLocalGit.js:61:11) at _cleanTempGitDir (test/detectLocalGit.js:55:5) at Context. (test/detectLocalGit.js:19:9) at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:354:21) at Hook.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7) at next (/usr/lib/nodejs/mocha/lib/runner.js:304:10) at Immediate. (/usr/lib/nodejs/mocha/lib/runner.js:334:5) debian/rules:30: recipe for target 'override_dh_auto_test' failed make[1]: *** [override_dh_auto_test] Error 1 make[1]: Leaving directory '/build/node-coveralls-3.0.0/2nd' debian/rules:10: recipe for target 'build' failed make: *** [build] Error 2 dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 I: copying local configuration E: Failed autobuilding of package […] Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- node-coveralls.3.0.0-1.logs.unstable.log.txt.gz Description: Binary data -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#886277: node-promise: please make the build reproducible
forwarded 886277 https://github.com/then/promise/pull/146 thanks I've forwarded this upstream here: https://github.com/then/promise/pull/146 Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#886277: node-promise: please make the build reproducible
Source: node-promise
Version: 8.0.1-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Hi,
Whilst working on the Reproducible Builds effort [0], we noticed
that node-promise could not be built reproducibly as it uses
random numbers as throwaway identifiers.
Patch attached.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
--- a/debian/patches/reproducible-build.patch 1970-01-01 01:00:00.0
+0100
--- b/debian/patches/reproducible-build.patch 2018-01-03 18:22:12.685911282
+
@@ -0,0 +1,25 @@
+Description: Make the build reproducible
+Author: Chris Lamb <la...@debian.org>
+Last-Update: 2018-01-03
+
+--- node-promise-8.0.1.orig/build.js
node-promise-8.0.1/build.js
+@@ -5,16 +5,12 @@ var rimraf = require('rimraf');
+ var acorn = require('acorn');
+ var walk = require('acorn/dist/walk');
+
+-var ids = [];
++var idx = 0;
+ var names = {};
+
+ function getIdFor(name) {
+ if (name in names) return names[name];
+- var id;
+- do {
+-id = '_' + Math.floor(Math.random() * 100);
+- } while (ids.indexOf(id) !== -1)
+- ids.push(id);
++ var id = '_' + idx++;
+ names[name] = id;
+ return id;
+ }
--- a/debian/patches/series 1970-01-01 01:00:00.0 +0100
--- b/debian/patches/series 2018-01-03 18:22:11.685904510 +
@@ -0,0 +1 @@
+reproducible-build.patch
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-sockjs-client_1.1.4+dfsg-1_amd64.changes REJECTED
Hi, debian/copyright says Bryce Kahle but LICENSE says VMWare. -- Chris Lamb <la...@debian.org> Tue, 02 Jan 2018 21:38:17 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#886001: node-jquery: please make the build reproducible
Source: node-jquery
Version: 2.2.4+dfsg-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Hi,
Whilst working on the Reproducible Builds effort [0], we noticed
that node-jquery could not be built reproducibly.
Patch attached. I tried looking at process.env.SOURCE_DATE_EPOCH
instead but that didn't seem to work for some reason.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
--- a/debian/patches/reproducible-build.patch 1970-01-01 01:00:00.0
+0100
--- b/debian/patches/reproducible-build.patch 2018-01-01 12:35:20.678032936
+
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <la...@debian.org>
+Last-Update: 2018-01-01
+
+--- node-jquery-2.2.4+dfsg.orig/src/intro.js
node-jquery-2.2.4+dfsg/src/intro.js
+@@ -8,8 +8,6 @@
+ * Copyright jQuery Foundation and other contributors
+ * Released under the MIT license
+ * http://jquery.org/license
+- *
+- * Date: @DATE
+ */
+
+ (function( global, factory ) {
--- a/debian/patches/series 2018-01-01 12:27:41.307107672 +
--- b/debian/patches/series 2018-01-01 12:35:19.590025986 +
@@ -1,2 +1,3 @@
skip-modules.patch
skip-gzip-js.patch
+reproducible-build.patch
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#886002: node-deflate-js: please make the build reproducible
Source: node-deflate-js Version: 0.2.3-1 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: umask X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Hi, Whilst working on the Reproducible Builds effort [0], we noticed that node-deflate-js could not be built reproducibly. Patch attached. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- --- a/debian/rules 2018-01-01 12:35:57.066265402 + --- b/debian/rules 2018-01-01 12:36:15.334382147 + @@ -17,4 +17,5 @@ rm -f test/*.pyc override_dh_fixperms: + dh_fixperms chmod +x debian/node-deflate-js/usr/lib/nodejs/deflate-js/bin/*.js -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-gzip-js_0.3.2-1_amd64.changes REJECTED
Contains unattributed gzip spec memo at test/test-files/spec.txt (and possibly others). -- Chris Lamb <la...@debian.org> Sun, 31 Dec 2017 09:22:44 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#885909: node-crc32: please make the build reproducible
Chris Lamb wrote: > This is because it does not call dh_fixperms in > override_dh_fixperms. I've filed this against Lintian here: https://bugs.debian.org/885910 Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#885909: node-crc32: please make the build reproducible
Source: node-crc32 Version: 0.2.2-1 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: umask X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Hi, Whilst working on the Reproducible Builds effort [0], we noticed that node-crc32 could not be built reproducibly. This is because it does not call dh_fixperms in override_dh_fixperms. Patch attached. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- --- a/debian/rules 2017-12-31 08:34:58.065447804 + --- b/debian/rules 2017-12-31 08:36:18.097984961 + @@ -13,4 +13,5 @@ cd test; ./runTests.sh; cd - override_dh_fixperms: + dh_fixperms chmod +x debian/node-crc32/usr/lib/nodejs/crc32/bin/runner.js -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Comments regarding node-crc32_0.2.2-1_amd64.changes
Might be nice if LICENSE.MIT didn't say "name of copyright holder" :p -- Chris Lamb <la...@debian.org> Sat, 30 Dec 2017 18:07:45 + -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] node-ms in NEW
Hi Paolo, > there is a node-ms package in the NEW queue since some time. > > It now blocks the update of node-debug to 3.1.0 Processed :) Best wishes, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#881262: node-module-deps: please make the build reproducible
Source: node-module-deps
Version: 4.1.1-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Hi,
Whilst working on the Reproducible Builds effort [0], we noticed
that node-module-deps could not be built reproducibly.
This is because output.json includes the absolute build path. Patch
attached that replaces this with the examples directory.
We could also do this via a patch on the source file itself (ie.
removing __dirname) but this way keeps all patching of these files
together at the very least.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
--- a/debian/rules 2017-11-09 13:02:17.499619258 +
--- b/debian/rules 2017-11-09 13:44:02.853843244 +
@@ -32,6 +32,8 @@
# patch example
find
$(CURDIR)/debian/node-module-deps/usr/share/doc/node-module-deps/examples/
-name '*.js' -exec \
sed -i
"s,require\s*[(]\s*'[.][.][^']*'\s*[)],require('module-deps'),g" {} \;
+ sed -i -e
"s,$(CURDIR)/example/,/usr/share/doc/node-module-deps/examples/,g" \
+
$(CURDIR)/debian/node-module-deps/usr/share/doc/node-module-deps/examples/output.json
else
override_dh_installexamples:
endif
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] libjs-vue_2.4.4+dfsg-1_amd64.changes REJECTED
RoM: Please reject libjs-vue: https://ftp-master.debian.org/new/libjs-vue_2.4.4+dfsg-1.html I uploaded this package, but I no longer believe it should be accepted. === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] simplemde-markdown-editor_1.11.2+dfsg-1_amd64.changes REJECTED
Hi, Hm, I don't think we are going around in circles here but debug/simplemde.js still (?) contains an embedded code copy (see line 12,866) that is not attributed or mentioned. See also debug/simplemde.debug.js, but there may be more. -- Chris Lamb <la...@debian.org> Wed, 25 Oct 2017 19:18:29 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] node-babel_6.25.0+dfsg-13_amd64.changes REJECTED
> > This makes me worry we are still not in sync about what the problem is... […] > You must retain, in the Source form of any Derivative Works > [] [name of copyright owner] > license to reproduce, prepare Derivative Works of, > patent, trademark, and But this is part of the license's documentation, not a statement about the package itself. - APPENDIX: How to apply the Apache License to your work. - - To apply the Apache License to your work, attach the following - boilerplate notice, with the fields enclosed by brackets "[]" - replaced with your own identifying information. (Don't include - the brackets!) The text should be enclosed in the appropriate - comment syntax for the file format. We also recommend that a - file or class name and description of purpose be included on the - same "printed page" as the copyright notice for easier - identification within third-party archives. - - Copyright [] [name of copyright owner] - - Licensed under the Apache License, Version 2.0 (the "License"); - you may not use this file except in compliance with the License. - You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - - Unless required by applicable law or agreed to in writing, software - distributed under the License is distributed on an "AS IS" BASIS, - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - See the License for the specific language governing permissions and - limitations under the License. It is part of the "How to apply the Apache License to your work" boilerplate... Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] node-babel_6.25.0+dfsg-13_amd64.changes REJECTED
> > The obvious solution to me is to remove the accidental reference in > > debian/copyright, not remove the file which contains some meta-copyright > > message. > > If this was suggested early on, we did not have to go through this long > thread This makes me worry we are still not in sync about what the problem is... Ignore this package for now: if I, totally by accident, mispasted a line into a debian/copyright file, the solution would be to remove such a line, no? Not rework the package so that the attribution became true. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] node-babel_6.25.0+dfsg-13_amd64.changes REJECTED
Pirate, > Now with those files removed from the source tarball, lets move on. > Please see if the current uploads in NEW meets the criteria. Please try and refrain such emotionally-driven comments in future. I hope it is clear I attempted to be friendly and reset the frame of this discussion, but in my experience it rarely helps to lash out like this, especially when asking someone to do something for you. > I have suggested two possible solutions and you seem to be fixated on > the semantics of the problem than a solution. I assure you I am not. Your solutions seemed to imply we were looking at a different problem altogether and were furthermore retrograde and/or detrimental to the packaging such as removing useful things such as tests, etc. The obvious solution to me is to remove the accidental reference in debian/copyright, not remove the file which contains some meta-copyright message. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] node-babel_6.25.0+dfsg-13_amd64.changes REJECTED
Hi, > > Where it is used is not material here > > There is a difference which missed to articulate in previous replies. If > it is an optional component like only used for tests, we can just get > rid of it without affecting the functionality. No. Pirate, please read over the following extremely carefully before replying as I would like to avoid either of us becoming frustrated by these repeated failures at conversation. The situation, as I understand it, is as follows: a) You uploaded 6.25.0+dfsg-13 with a debian/copyright including the following: 11 Files: packages/babel-preset-es2015/test/fixtures/traceur/* 12 Copyright: [] [name of copyright owner] 13 License: Apache-2.0 14 Comment: name of copyright holder is missing b) This "[] [name of copyright owner]" placeholder text comes from the LICENSE file. c) The portion of the LICENSE file where it comes from is part of the usual "How to apply this license to your own code." This is what was meant by "meta statement" in my original REJECT. d) The statement in debian/copyright therefore has no meaning whatsover, likely just a false positive from whatever tool you are using to generate such files. e) (It is therefore totally irrelevant to this disuss whether the tests are used, whether the package is "useful", whether its packages in NEW or contrib depend on it, etc. You seem fixated on this point.) Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] node-babel_6.25.0+dfsg-13_amd64.changes REJECTED
Hi Pirate Praveen, We are talking different things. -Chris > On ഞായര് 08 ഒക്ടോബര് 2017 09:07 വൈകു, Chris Lamb wrote: > > Again, it makes no difference.. The text you quote is part of 'how do I > > apply this license' not a copyright statement in itself.. > > We are in this situation because the License file does not include the > name of copyright holder. I have added Google Inc as copyright holder > (from the github project address that hosts traceur project) and > re-uploaded. If that is also not okay, please suggest a solution that is > acceptable. > > Email had 1 attachment: > + signature.asc > 1k (application/pgp-signature) -- Chris Lamb chris-lamb.co.uk / @lolamby -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] node-babel_6.25.0+dfsg-13_amd64.changes REJECTED
Hi Pirate Praveen, Where it is used is not material here unless I am missing something fundamental. > On ഞായര് 08 ഒക്ടോബര് 2017 08:30 വൈകു, Chris Lamb wrote: > > > > > > 11 Files: packages/babel-preset-es2015/test/fixtures/traceur/* > > 12 Copyright: [] [name of copyright owner] > > 13 License: Apache-2.0 > > 14 Comment: name of copyright holder is missing > > > > Really? No it's not. This is a meta statement in a LICENSE text AFAICT. Are > > you > > generating these lines automatically or something? > > This is only used for tests, I could add copyright to google > (https://github.com/google/traceur-compiler) or remove these files. > > Email had 1 attachment: > + signature.asc > 1k (application/pgp-signature) -- Chris Lamb chris-lamb.co.uk / @lolamby -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] node-babel_6.25.0+dfsg-13_amd64.changes REJECTED
Hi Pirate Praveen, Again, it makes no difference.. The text you quote is part of 'how do I apply this license' not a copyright statement in itself.. > On ഞായര് 08 ഒക്ടോബര് 2017 08:54 വൈകു, Chris Lamb wrote: > > > > > > Hi Pirate Praveen, > > > > Where it is used is not material here unless I am missing something > > fundamental. > > I meant, these are not generated by me, its provided as fixtures, that > is used during test. > > I'm adding copyright to Google Inc as the traceur project is hosted at > https://github.com/google/ > > Even this https://github.com/google/traceur-compiler/blob/master/LICENSE > has just the license text. > > Email had 1 attachment: > + signature.asc > 1k (application/pgp-signature) -- Chris Lamb chris-lamb.co.uk / @lolamby -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-babel-preset-env_1.6.0-1_amd64.changes REJECTED
Hi 2017 Henry Zhu <h...@henryzoo.com> in debian/copyright (line 7) disagrees with LICENSE line 3. -- Chris Lamb <la...@debian.org> Sun, 08 Oct 2017 13:20:40 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-babel_6.25.0+dfsg-12_amd64.changes REJECTED
. === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-babel-preset-env_1.6.0-2_amd64.changes REJECTED
Hi 2017 Henry Zhu <h...@henryzoo.com> in debian/copyright (line 7) disagrees with LICENSE line 3. -- Chris Lamb <la...@debian.org> Sun, 08 Oct 2017 13:19:42 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-babel_6.25.0+dfsg-13_amd64.changes REJECTED
11 Files: packages/babel-preset-es2015/test/fixtures/traceur/* 12 Copyright: [] [name of copyright owner] 13 License: Apache-2.0 14 Comment: name of copyright holder is missing Really? No it's not. This is a meta statement in a LICENSE text AFAICT. Are you generating these lines automatically or something? -- Chris Lamb <la...@debian.org> Sun, 08 Oct 2017 13:17:26 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-babel_6.25.0+dfsg-11_amd64.changes REJECTED
. === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#867753: grunt: please make the output reproducible
Hi, > grunt: please make the output reproducible Any chance of applying this in Debian? :) It's now making src:searx not-reproducible (as well as src:jquery-tablesorter:) Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-unicode-tr51_9.0.0-1_amd64.changes REJECTED
Sat 09 10:40 < Snark> hi, could you reject node-unicode-tr51 which is in NEW? Sat 09 10:40 < Snark> the unicode-data package has been improved, so this package can too Sat 09 10:41 < Snark> there's no point in reviewing a package where a large chunk will just be removed Sat 09 10:41 < Snark> thanks === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] libjs-cssrelpreload_1.3.1-1_amd64.changes REJECTED
Per request --- I checked over my other uploads and it seems libjs-cssrelpreload [1] should be also be rejected, for the same reason. Could you please kick that back and I'll get documentation corrected for both packages? [1] https://ftp-master.debian.org/new/libjs-cssrelpreload_1.3.1-1.html Thanks for the careful review! === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] libjs-autolink_1.0.2+dfsg2-1_amd64.changes REJECTED
Hi, There is some kind of unattributed (etc.) code copy under test/jasmine/. This needs, at the very least, clarification in debian/copyright (not here!). -- Chris Lamb <la...@debian.org> Mon, 28 Aug 2017 10:00:57 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-array-reduce_0.0.0-1_amd64.changes REJECTED
Mon 21 02:12 < broucari> hi, just send you a mail asking for reject/removal from new queue of node-array-filter node-array-map node-array-reduce. Thanks for your work === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-array-map_0.0.0-1_amd64.changes REJECTED
Mon 21 02:12 < broucari> hi, just send you a mail asking for reject/removal from new queue of node-array-filter node-array-map node-array-reduce. Thanks for your work === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#869999: highlight.js: Incomplete debian/copyright?
Source: highlight.js
Version: 9.12.0+dfsg1-2
Severity: serious
Justication: Policy 12.5
X-Debbugs-CC: Ximin Luo <infini...@debian.org>
Hi,
I just ACCEPTed highlight.js from NEW but noticed it was missing
attribution in debian/copyright for at least
test/detect/{dts,rsl}/default.txt
(This is not exhaustive so please check over the entire package
carefully and address these on your next upload.)
Regards,
--
,''`.
: :' : Chris Lamb, Debian Project Leader
`. `'` la...@debian.org / chris-lamb.co.uk
`-
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#868321: node-marked-man: please make the output reproducible
forwarded 868321 https://github.com/kapouer/marked-man/pull/12 thanks Sent upstream: https://github.com/kapouer/marked-man/pull/12 Regards, -- ,''`. : :' : Chris Lamb, Debian Project Leader `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#868321: node-marked-man: please make the output reproducible
Source: node-marked-man
Version: 0.2.0-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timestamps toolchain
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Hi,
Whilst working on the Reproducible Builds effort [0], we noticed
that node-marked-man generated reproducible output. In particular,
it uses the current timestamp which varies between builds.
Patch attached that uses SOURCE_DATE_EPOCH[1] if that is exported
in the environment.
[0] https://reproducible-builds.org/
[1] https://reproducible-builds.org/specs/source-date-epoch/
Regards,
--
,''`.
: :' : Chris Lamb, Debian Project Leader
`. `'` la...@debian.org / chris-lamb.co.uk
`-
diff --git a/lib/marked-man.js b/lib/marked-man.js
index 71e58d2..e34d089 100644
--- a/lib/marked-man.js
+++ b/lib/marked-man.js
@@ -414,6 +414,9 @@ function rparseHeader(str, options) {
}
function manDate(date) {
date = new Date(date);
+ if (process.env.SOURCE_DATE_EPOCH) {
+date = new Date(process.env.SOURCE_DATE_EPOCH * 1000);
+ }
var month = ["January", "February", "March", "April", "May", "June", "July",
"August", "September", "October", "November", "December"][date.getMonth()];
return month + " " + date.getFullYear();
}
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#867753: grunt: please make the output reproducible
forwarded 867753 https://github.com/gruntjs/grunt/pull/1596 thanks Forwarded upstream here: https://github.com/gruntjs/grunt/pull/1596 Regards, -- ,''`. : :' : Chris Lamb, Debian Project Leader `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#867753: grunt: please make the output reproducible
Source: grunt
Version: 1.0.1-5
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timestamps toolchain
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Hi,
Whilst working on the Reproducible Builds effort [0], we noticed
that grunt can generate non-reproducible output.
This is affecting the reproducibility status other packages such as
libjquery-tablesorter that set a "pkg.banner" such as:
<%= grunt.template.today("mm-dd-")
Patch attached.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb, Debian Project Leader
`. `'` la...@debian.org / chris-lamb.co.uk
`-
diff --git a/lib/grunt/template.js b/lib/grunt/template.js
index d1967df..15e1fe1 100644
--- a/lib/grunt/template.js
+++ b/lib/grunt/template.js
@@ -10,7 +10,11 @@ template.date = require('dateformat');
// Format today's date.
template.today = function(format) {
- return template.date(new Date(), format);
+ var now = new Date();
+ if (process.env.SOURCE_DATE_EPOCH) {
+now = new Date((process.env.SOURCE_DATE_EPOCH * 1000) +
(now.getTimezoneOffset() * 6));
+ }
+ return template.date(now, format);
};
// Template delimiters.
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-locate-character_2.0.1-1_amd64.changes REJECTED
Thu 06 17:09 < Snark> hi Thu 06 17:09 < Snark> could you reject node-locate-character? I got LocutusOfBorg to sponsor it, but I'm not happy with my packaging after all... :-/ Thu 06 17:09 < Snark> (it's in NEW) Thu 06 17:09 < Snark> thanks Thu 06 17:10 < LocutusOfBorg> not sure why, I liked it but meh :) reject please Thu 06 17:12 < Snark> I'm not happy with the directory structure === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-watchpack_1.3.1-1_amd64.changes REJECTED
LICENSE file contians "Copyright JS Foundation and other contributors" which differs from d/copyright entirely... === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] node-ecc-jsbn_0.1.1-1_amd64.changes REJECTED
Pirate Praveen wrote: > On തിങ്കള് 08 മെയ് 2017 12:30 രാവിലെ, Chris Lamb wrote: > > lib/LICENSE-jsbn seems to refer to other stuff. please clarify in > > debian/copyright [..] > What clarification should be added to debian/copyright? Well, "node-jsbn already has the correct copyright notice. This library is only linking to jsbn and not embedding it." ie. exactly your own justification that it is not an issue :) Best wishes, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-ecc-jsbn_0.1.1-1_amd64.changes REJECTED
lib/LICENSE-jsbn seems to refer to other stuff. please clarify in debian/copyright -- Chris Lamb <la...@debian.org> Sun, 07 May 2017 18:10:02 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-source-list-map_1.1.1+dfsg-1_amd64.changes REJECTED
Missing attribution for (at least) lib/base64-vlq.js, alas :) -- Chris Lamb <la...@debian.org> Fri, 05 May 2017 10:48:48 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#861592: node-dateformat: FTBFS: AssertionError: '1:19:44 PM GMT' === '1:19:44 PM UTC'
Source: node-dateformat Version: 1.0.11-2 Severity: serious Justification: fails to build from source User: reproducible-bui...@lists.alioth.debian.org Usertags: ftbfs X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Dear Maintainer, node-dateformat fails to build from source in unstable/amd64: […] dh build dh_testdir dh_update_autotools_config dh_auto_configure dh_auto_build debian/rules override_dh_auto_test make[1]: Entering directory '«BUILDDIR»' mocha -R spec [0m[0m [0m dayOfWeek[0m [32m ✓[0m[90m should correctly format the timezone part [0m [0m dateformat([now], [mask])[0m [32m ✓[0m[90m should format `default` mask [0m [32m ✓[0m[90m should format `shortDate` mask [0m [32m ✓[0m[90m should format `mediumDate` mask [0m [32m ✓[0m[90m should format `longDate` mask [0m [32m ✓[0m[90m should format `fullDate` mask [0m [32m ✓[0m[90m should format `shortTime` mask [0m [32m ✓[0m[90m should format `mediumTime` mask [0m [31m 1) should format `longTime` mask[0m [32m ✓[0m[90m should format `isoDate` mask [0m [32m ✓[0m[90m should format `isoTime` mask [0m [32m ✓[0m[90m should format `isoDateTime` mask [0m [32m ✓[0m[90m should format `isoUtcDateTime` mask [0m [31m 2) should format `expiresHeaderFormat` mask[0m [32m ✓[0m[90m should use `default` mask, when `mask` is empty [0m [0m isoUtcDateTime[0m [32m ✓[0m[90m should correctly format the timezone part [0m [92m [0m[32m 14 passing[0m[90m (22ms)[0m [31m 2 failing[0m [0m 1) dateformat([now], [mask]) should format `longTime` mask: [31mAssertionError: '1:19:44 PM GMT' === '1:19:44 PM UTC'[0m [42m+ expected[0m [41m- actual[0m [41m-1:19:44 PM GMT[0m [42m+1:19:44 PM UTC[0m [0m[90m at Context. («BUILDDIR»/test/test_formats.js:64:14) at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:196:15) at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:373:10) at /usr/lib/nodejs/mocha/lib/runner.js:451:12 at next (/usr/lib/nodejs/mocha/lib/runner.js:298:14) at /usr/lib/nodejs/mocha/lib/runner.js:308:7 at next (/usr/lib/nodejs/mocha/lib/runner.js:246:23) at Immediate._onImmediate (/usr/lib/nodejs/mocha/lib/runner.js:275:5) at processImmediate [as _immediateCallback] (timers.js:396:17) [0m [0m 2) dateformat([now], [mask]) should format `expiresHeaderFormat` mask: [31mAssertionError: 'Wed, 26 Nov 2014 13:19:44 GMT' === 'Wed, 26 Nov 2014 13:19:44 UTC'[0m [42m+ expected[0m [41m- actual[0m [41m-Wed, 26 Nov 2014 13:19:44 GMT[0m [42m+Wed, 26 Nov 2014 13:19:44 UTC[0m [0m[90m at Context. («BUILDDIR»/test/test_formats.js:64:14) at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:196:15) at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:373:10) at /usr/lib/nodejs/mocha/lib/runner.js:451:12 at next (/usr/lib/nodejs/mocha/lib/runner.js:298:14) at /usr/lib/nodejs/mocha/lib/runner.js:308:7 at next (/usr/lib/nodejs/mocha/lib/runner.js:246:23) at Immediate._onImmediate (/usr/lib/nodejs/mocha/lib/runner.js:275:5) at processImmediate [as _immediateCallback] (timers.js:396:17) [0m debian/rules:7: recipe for target 'override_dh_auto_test' failed make[1]: *** [override_dh_auto_test] Error 2 make[1]: Leaving directory '«BUILDDIR»' debian/rules:3: recipe for target 'build' failed make: *** [build] Error 2 dpkg-buildpackage: error: debian/rules build gave error exit status 2 […] The full build log is attached. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- node-dateformat.1.0.11-2.unstable.amd64.log.txt.gz Description: Binary data -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] typescript-types_20170424-1_amd64.changes REJECTED
Hi, Please clarify the copyrights of (at least): jquery/index.d.ts lodash/LICENSE mocha/LICENSE node/LICENSE requirejs/index.d.ts ... in debian/copyright. They might not be copyrightable, but this needs clarificatoin in d/copyright either way. -- Chris Lamb <la...@debian.org> Sat, 29 Apr 2017 20:56:11 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-ripemd160_2.0.1+20172804git0cd03c4f72385-1_amd64.changes REJECTED
Copyright: 2017 FIX_ME upstream author .. does not match LICENSE. -- Chris Lamb <la...@debian.org> Sat, 29 Apr 2017 08:12:58 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-assert-plus_1.0.0-1_amd64.changes REJECTED
Missing attributions for Joylent. -- Chris Lamb <la...@debian.org> Sat, 29 Apr 2017 08:12:00 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#856830: Bug#856830: Could not reproduce with pbuilder
Hi, > Successfully built with sbuild too. autopkgtest also passed. > > Chris, can you check if you can still reproduce the failure? Cannot reproduce, so closing in BCC :) Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#856830: node-dateformat: FTBFS: dateformat([now], [mask]) should format `longTime` mask
Source: node-dateformat Version: 1.0.11-2 Severity: serious Justification: fails to build from source User: reproducible-bui...@lists.alioth.debian.org Usertags: ftbfs X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Dear Maintainer, node-dateformat fails to build from source in unstable/amd64: […] dh build dh_testdir dh_update_autotools_config dh_auto_configure dh_auto_build debian/rules override_dh_auto_test make[1]: Entering directory '«BUILDDIR»' mocha -R spec [0m[0m [0m dayOfWeek[0m [32m ✓[0m[90m should correctly format the timezone part [0m [0m dateformat([now], [mask])[0m [32m ✓[0m[90m should format `default` mask [0m [32m ✓[0m[90m should format `shortDate` mask [0m [32m ✓[0m[90m should format `mediumDate` mask [0m [32m ✓[0m[90m should format `longDate` mask [0m [32m ✓[0m[90m should format `fullDate` mask [0m [32m ✓[0m[90m should format `shortTime` mask [0m [32m ✓[0m[90m should format `mediumTime` mask [0m [31m 1) should format `longTime` mask[0m [32m ✓[0m[90m should format `isoDate` mask [0m [32m ✓[0m[90m should format `isoTime` mask [0m [32m ✓[0m[90m should format `isoDateTime` mask [0m [32m ✓[0m[90m should format `isoUtcDateTime` mask [0m [31m 2) should format `expiresHeaderFormat` mask[0m [32m ✓[0m[90m should use `default` mask, when `mask` is empty [0m [0m isoUtcDateTime[0m [32m ✓[0m[90m should correctly format the timezone part [0m [92m [0m[32m 14 passing[0m[90m (22ms)[0m [31m 2 failing[0m [0m 1) dateformat([now], [mask]) should format `longTime` mask: [31mAssertionError: '1:19:44 PM GMT' === '1:19:44 PM UTC'[0m [42m+ expected[0m [41m- actual[0m [41m-1:19:44 PM GMT[0m [42m+1:19:44 PM UTC[0m [0m[90m at Context. («BUILDDIR»/test/test_formats.js:64:14) at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:196:15) at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:373:10) at /usr/lib/nodejs/mocha/lib/runner.js:451:12 at next (/usr/lib/nodejs/mocha/lib/runner.js:298:14) at /usr/lib/nodejs/mocha/lib/runner.js:308:7 at next (/usr/lib/nodejs/mocha/lib/runner.js:246:23) at Immediate._onImmediate (/usr/lib/nodejs/mocha/lib/runner.js:275:5) at processImmediate [as _immediateCallback] (timers.js:396:17) [0m [0m 2) dateformat([now], [mask]) should format `expiresHeaderFormat` mask: [31mAssertionError: 'Wed, 26 Nov 2014 13:19:44 GMT' === 'Wed, 26 Nov 2014 13:19:44 UTC'[0m [42m+ expected[0m [41m- actual[0m [41m-Wed, 26 Nov 2014 13:19:44 GMT[0m [42m+Wed, 26 Nov 2014 13:19:44 UTC[0m [0m[90m at Context. («BUILDDIR»/test/test_formats.js:64:14) at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:196:15) at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:373:10) at /usr/lib/nodejs/mocha/lib/runner.js:451:12 at next (/usr/lib/nodejs/mocha/lib/runner.js:298:14) at /usr/lib/nodejs/mocha/lib/runner.js:308:7 at next (/usr/lib/nodejs/mocha/lib/runner.js:246:23) at Immediate._onImmediate (/usr/lib/nodejs/mocha/lib/runner.js:275:5) at processImmediate [as _immediateCallback] (timers.js:396:17) [0m debian/rules:7: recipe for target 'override_dh_auto_test' failed make[1]: *** [override_dh_auto_test] Error 2 make[1]: Leaving directory '«BUILDDIR»' debian/rules:3: recipe for target 'build' failed make: *** [build] Error 2 dpkg-buildpackage: error: debian/rules build gave error exit status 2 […] The full build log is attached. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- node-dateformat.1.0.11-2.unstable.amd64.log.txt.gz Description: Binary data -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#856807: node-mocha: please make the build reproducible
forwarded 856807 https://github.com/mochajs/mocha/pull/2727 thanks Forwarded upstream to: https://github.com/mochajs/mocha/pull/2727 Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#856807: node-mocha: please make the build reproducible
Source: node-mocha Version: 1.20.1-2 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: locale X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Hi, Whilst working on the Reproducible Builds effort [0], we noticed that node-mocha could not be built reproducibly. Patch attached. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- --- a/debian/patches/0004-reproducible_build.patch 1970-01-01 01:00:00.0 +0100 --- b/debian/patches/0004-reproducible_build.patch 2017-03-04 22:08:07.627508560 + @@ -0,0 +1,15 @@ +Description: Make the build reproducible +Author: Chris Lamb <la...@debian.org> +Last-Update: 2017-03-04 + +--- node-mocha-1.20.1.orig/Makefile node-mocha-1.20.1/Makefile +@@ -1,7 +1,7 @@ + + REPORTER ?= dot + TM_BUNDLE = JavaScript\ mocha.tmbundle +-SRC = $(shell find lib -name "*.js" -type f | sort) ++SRC = $(shell find lib -name "*.js" -type f | LC_ALL=C sort) + SUPPORT = $(wildcard support/*.js) + + all: mocha.js --- a/debian/patches/series 2017-03-04 22:05:17.590246118 + --- b/debian/patches/series 2017-03-04 22:07:21.511163989 + @@ -3,3 +3,4 @@ 0002_fix_node_shebang.patch 0003_images_in_usr_share.patch register-coffeescript.patch +0004-reproducible_build.patch -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#849314: node-gulp: please make the build reproducible
> Would you consider applying this patch and uploading? Friendly ping on this :) Best wishes, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#855066: jarisplayer: FTBFS:
Source: jarisplayer Version: 2.0.17~dfsg-3 Severity: serious Justification: fails to build from source User: reproducible-bui...@lists.alioth.debian.org Usertags: ftbfs X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Dear Maintainer, jarisplayer fails to build from source in unstable/amd64: […] find -type f -name '*.metadata_dump' -delete haxe -main jaris.Main -swf player.swf -cp src -D no-pattern-matching -dce full src/jaris/player/Player.hx:1533: characters 17-33 : Only inline or read-only (default, never) fields can be used as a pattern debian/rules:58: recipe for target 'debian/stamp-swf-build' failed make: *** [debian/stamp-swf-build] Error 1 dpkg-buildpackage: error: debian/rules build gave error exit status 2 […] The full build log is attached. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- jarisplayer.2.0.17~dfsg-3.unstable.amd64.log.txt.gz Description: Binary data -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#845745: node-rimraf: please make the build reproducible
Hi, > Thank you, and i did that in some other packages recently, > i'll try to fix them. Friendly ping on this? :) Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#853035: node-liftoff: Non-determistically FTBFS due to unreliable timing in tests
Source: node-liftoff Version: 2.3.0-2 Severity: serious Justification: fails to build from source User: reproducible-bui...@lists.alioth.debian.org Usertags: ftbfs X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Dear Maintainer, node-liftoff's testsuite appears to use method timing/benchmarking in such a way that it will non-deterministically FTBFS: […] [0m 1) Liftoff launch should skip respawning if process.argv has no values from v8flags in it: [0m[31m Error: timeout of 5000ms exceeded[0m[90m at null. (/usr/lib/nodejs/mocha/lib/runnable.js:139:19) at Timer.listOnTimeout (timers.js:92:15) [0m debian/rules:13: recipe for target 'override_dh_auto_test' failed make[1]: *** [override_dh_auto_test] Error 1 make[1]: Leaving directory '«BUILDDIR»' debian/rules:8: recipe for target 'build' failed make: *** [build] Error 2 dpkg-buildpackage: error: debian/rules build gave error exit status 2 […] The full build log is attached. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- node-liftoff.2.3.0-2.unstable.amd64.log.txt.gz Description: Binary data -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#853036: node-liftoff: Non-determistically FTBFS due to unreliable timing in tests
Source: node-liftoff Version: 2.3.0-2 Severity: serious Justification: fails to build from source User: reproducible-bui...@lists.alioth.debian.org Usertags: ftbfs X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Dear Maintainer, node-liftoff's testsuite appears to use method timing/benchmarking in such a way that it will non-deterministically FTBFS: […] [0m 1) Liftoff launch should skip respawning if process.argv has no values from v8flags in it: [0m[31m Error: timeout of 5000ms exceeded[0m[90m at null. (/usr/lib/nodejs/mocha/lib/runnable.js:139:19) at Timer.listOnTimeout (timers.js:92:15) [0m debian/rules:13: recipe for target 'override_dh_auto_test' failed make[1]: *** [override_dh_auto_test] Error 1 make[1]: Leaving directory '«BUILDDIR»' debian/rules:8: recipe for target 'build' failed make: *** [build] Error 2 dpkg-buildpackage: error: debian/rules build gave error exit status 2 […] The full build log is attached. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-invariant_2.2.2-1_amd64.changes REJECTED
Missing attributions from Facebook. -- Chris Lamb <la...@debian.org> Sun, 25 Dec 2016 22:47:24 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#849314: node-gulp: please make the build reproducible
Source: node-gulp Version: 3.9.1-1 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: timestamps X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Hi, Whilst working on the Reproducible Builds effort [0], we noticed that node-gulp could not be built reproducibly. Patch attached. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- --- a/debian/rules 2016-12-25 09:52:50.937545082 + --- b/debian/rules 2016-12-25 09:57:01.179626236 + @@ -9,7 +9,7 @@ override_dh_auto_build: dh_auto_build - marked-man --name gulp docs/CLI.md > gulp.1 + marked-man --name gulp --date="$(shell dpkg-parsechangelog --show-field=Date)" docs/CLI.md > gulp.1 #override_dh_auto_test: -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-glob-stream_5.3.4-1_amd64.changes REJECTED
LICENSE says: Copyright (c) 2015 Blaine Bublitz, Eric Schoffstall and other contributors d/copyright says: 2016 Gulp Team <t...@gulpjs.com> (http://gulpjs.com/) -- Chris Lamb <la...@debian.org> Sat, 17 Dec 2016 22:25:52 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#848013: node-temporary: FTBFS: Error: Cannot find module 'sinon'
Source: node-temporary Version: 0.0.8-1 Severity: serious Justification: fails to build from source User: reproducible-bui...@lists.alioth.debian.org Usertags: ftbfs X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Dear Maintainer, node-temporary fails to build from source in unstable/amd64: […] dh build dh_testdir dh_update_autotools_config dh_auto_configure dh_auto_build make -j1 make[1]: Entering directory '«BUILDDIR»' module.js:327 throw err; ^ Error: Cannot find module 'sinon' at Function.Module._resolveFilename (module.js:325:15) at Function.Module._load (module.js:276:25) at Module.require (module.js:353:17) at require (internal/module.js:12:17) at Object. («BUILDDIR»/test/dir.test.js:16:13) at Module._compile (module.js:409:26) at Object.Module._extensions..js (module.js:416:10) at Module.load (module.js:343:32) at Function.Module._load (module.js:300:12) at Module.require (module.js:353:17) at require (internal/module.js:12:17) at /usr/lib/nodejs/mocha/lib/mocha.js:172:27 at Array.forEach (native) at Mocha.loadFiles (/usr/lib/nodejs/mocha/lib/mocha.js:169:14) at Mocha.run (/usr/lib/nodejs/mocha/lib/mocha.js:356:31) at Object. (/usr/lib/nodejs/mocha/bin/_mocha:366:16) at Module._compile (module.js:409:26) at Object.Module._extensions..js (module.js:416:10) at Module.load (module.js:343:32) at Function.Module._load (module.js:300:12) at Function.Module.runMain (module.js:441:10) at startup (node.js:139:18) at node.js:974:3 Makefile:4: recipe for target 'test' failed make[1]: *** [test] Error 1 make[1]: Leaving directory '«BUILDDIR»' dh_auto_build: make -j1 returned exit code 2 debian/rules:8: recipe for target 'build' failed make: *** [build] Error 2 dpkg-buildpackage: error: debian/rules build gave error exit status 2 […] The full build log is attached. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- node-temporary.0.0.8-1.unstable.amd64.log.txt.gz Description: Binary data -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#847740: jquery: FTBFS: Error: Cannot find module '/usr/lib/nodejs/r.js'
Source: jquery Version: 3.1.1-1 Severity: serious Justification: fails to build from source User: reproducible-bui...@lists.alioth.debian.org Usertags: ftbfs X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Dear Maintainer, jquery fails to build from source in unstable/amd64: […] dh_auto_configure debian/rules override_dh_auto_build make[1]: Entering directory '«BUILDDIR»' sed -e '/^\/\*\s*eslint-/d; /^\/\/ @CODE/,$ d' src/wrapper.js > start.js || (rm -f start.js; false) sed -e '1,/^\/\/ @CODE/ d; /\/\/ build.js inserts compiled jQuery here/d' src/wrapper.js > end.js || (rm -f end.js; false) cp debian/build.js build.js nodejs /usr/lib/nodejs/r.js -o build.js module.js:327 throw err; ^ Error: Cannot find module '/usr/lib/nodejs/r.js' at Function.Module._resolveFilename (module.js:325:15) at Function.Module._load (module.js:276:25) at Function.Module.runMain (module.js:441:10) at startup (node.js:139:18) at node.js:974:3 debian/rules:14: recipe for target 'dist/jquery.js' failed make[1]: *** [dist/jquery.js] Error 1 make[1]: Leaving directory '«BUILDDIR»' debian/rules:40: recipe for target 'binary' failed make: *** [binary] Error 2 dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 […] The full build log is attached. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- jquery.3.1.1-1.unstable.amd64.log.txt.gz Description: Binary data -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] node-lodash-packages_4.15.0-1_amd64.changes REJECTED
Pirate Praveen wrote: > Can you review jquery-ui before my other packages in NEW? I need it to > fix rc bug in gitlab. These other packages have less priority compared > to jqueryui. Did you correct Thorsten's previous comments/notes ooi? Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-lodash-packages_4.15.0-1_amd64.changes REJECTED
Looks like missing attribution from jQuery (stopped checking there) -- Chris Lamb <la...@debian.org> Sat, 10 Dec 2016 08:34:50 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-grunt-contrib-requirejs_1.0.0-1_amd64.changes REJECTED
"Copyright: 2016 Grunt Team" but some individual contributors named (eg. Tyler Keller). Please recheck the entire package. -- Chris Lamb <la...@debian.org> Sat, 10 Dec 2016 08:32:59 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-vinyl_2.0.1-1_amd64.changes REJECTED
LICENSE says Copyright (c) 2013 Blaine Bublitz <blaine.bubl...@gmail.com>, Eric Schoffstall <y...@contra.io> and other contributors but d/copyright says: 6 Files: * 7 Copyright: 2016 Gulp Team <t...@gulpjs.com> (http://gulpjs.com/) -- Chris Lamb <la...@debian.org> Wed, 07 Dec 2016 09:07:02 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#845745: node-rimraf: please make the build reproducible
Source: node-rimraf Version: 2.5.4-1 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: umask X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Hi, Whilst working on the Reproducible Builds effort [0], we noticed that node-rimraf could not be built reproducibly. This is due to exluding bin.js from dh_fixperms (to keep it executable) which means that the group "write" bit is inherited from the system's umask. Patch attached. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- --- a/debian/rules 2016-11-26 12:20:11.766655153 + --- b/debian/rules 2016-11-26 12:22:01.617818051 + @@ -8,4 +8,5 @@ dh $@ override_dh_fixperms: - dh_fixperms -X debian/node-rimraf/usr/lib/nodejs/rimraf/bin.js + dh_fixperms + chmod +x debian/node-rimraf/usr/lib/nodejs/rimraf/bin.js -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#845617: node-nopt: FTBFS: Error: Cannot find module 'abbrev'
Source: node-nopt Version: 3.0.6-2 Severity: serious Justification: fails to build from source User: reproducible-bui...@lists.alioth.debian.org Usertags: ftbfs X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Dear Maintainer, node-nopt fails to build from source in unstable/amd64: […] debian/rules override_dh_auto_test make[1]: Entering directory '«BUILDDIR»' tap test/*.js TAP version 13 # Subtest: test/basic.js module.js:327 throw err; ^ Error: Cannot find module 'abbrev' at Function.Module._resolveFilename (module.js:325:15) at Function.Module._load (module.js:276:25) at Module.require (module.js:353:17) at require (internal/module.js:12:17) at Object. («BUILDDIR»/lib/nopt.js:10:14) at Module._compile (module.js:409:26) at Object.Module._extensions..js (module.js:416:10) at Module.load (module.js:343:32) at Function.Module._load (module.js:300:12) at Module.require (module.js:353:17) 1..0 not ok 1 - test/basic.js # time=62.125ms --- results: plan: start: 1 end: 0 skipAll: true pass: 0 ok: false count: 0 command: /usr/bin/nodejs exitCode: 1 timeout: 3 arguments: - test/basic.js file: test/basic.js ... 1..1 # failed 1 of 1 tests # time=93.481ms debian/rules:11: recipe for target 'override_dh_auto_test' failed make[1]: *** [override_dh_auto_test] Error 1 make[1]: Leaving directory '«BUILDDIR»' debian/rules:8: recipe for target 'build' failed make: *** [build] Error 2 […] The full build log is attached. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- node-nopt.3.0.6-2.unstable.amd64.log.txt.gz Description: Binary data -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-grunt-contrib-nodeunit_1.0.0-1_amd64.changes REJECTED
Missing attribution for Ben Alman (and possibly more). -- Chris Lamb <la...@debian.org> Wed, 23 Nov 2016 09:34:52 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#845379: node-fuzzaldrin-plus: FTBFS: Npm module "grunt-contrib-coffee" not found.
Source: node-fuzzaldrin-plus Version: 0.3.1+git.20161008.da2cb58+dfsg-1 Severity: serious Justification: fails to build from source User: reproducible-bui...@lists.alioth.debian.org Usertags: ftbfs X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Dear Maintainer, node-fuzzaldrin-plus fails to build from source in unstable/amd64: […] debian/rules override_dh_auto_clean make[1]: Entering directory '«BUILDDIR»' dh_auto_clean grunt clean [31m>> [39mLocal Npm module "grunt-contrib-coffee" not found. Is it installed? [31m>> [39mLocal Npm module "grunt-shell" not found. Is it installed? [31m>> [39mLocal Npm module "grunt-browserify" not found. Is it installed? [31m>> [39mLocal Npm module "grunt-contrib-uglify" not found. Is it installed? [4mRunning "clean" task[24m [32mDone.[39m rm -rf dist-browser make[1]: Leaving directory '«BUILDDIR»' dh_clean debian/rules build dh build dh_testdir dh_update_autotools_config dh_auto_configure debian/rules override_dh_auto_build make[1]: Entering directory '«BUILDDIR»' dh_auto_build grunt [31m>> [39mLocal Npm module "grunt-contrib-coffee" not found. Is it installed? [31m>> [39mLocal Npm module "grunt-shell" not found. Is it installed? [31m>> [39mLocal Npm module "grunt-browserify" not found. Is it installed? [31m>> [39mLocal Npm module "grunt-contrib-uglify" not found. Is it installed? [33mWarning: Task "coffee" not found. Use --force to continue.[39m [31mAborted due to warnings.[39m debian/rules:11: recipe for target 'override_dh_auto_build' failed make[1]: *** [override_dh_auto_build] Error 3 make[1]: Leaving directory '«BUILDDIR»' debian/rules:8: recipe for target 'build' failed make: *** [build] Error 2 […] The full build log is attached. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- node-fuzzaldrin-plus.0.3.1+git.20161008.da2cb58+dfsg-1.unstable.amd64.log.txt.gz Description: Binary data -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-doctrine_2.0.0-1_amd64.changes REJECTED
Saying "and other contributors" is not really up to Debian standards I'm afraid. Missing (at least) JS Foundation, etc. etc. -- Chris Lamb <la...@debian.org> Thu, 17 Nov 2016 11:20:43 + === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#843529: node-dateformat: FTBFS: Error: Cannot find module 'underscore'
Source: node-dateformat Version: 1.0.11-1 Severity: serious Justification: fails to build from source User: reproducible-bui...@lists.alioth.debian.org Usertags: ftbfs X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org Dear Maintainer, node-dateformat fails to build from source in unstable/amd64: […] dh_auto_build debian/rules override_dh_auto_test make[1]: Entering directory '/home/lamby/temp/cdt.20161107132446.quqSm7tjme.db.node-dateformat/node-dateformat-1.0.11' mocha -R spec module.js:327 throw err; ^ Error: Cannot find module 'underscore' at Function.Module._resolveFilename (module.js:325:15) at Function.Module._load (module.js:276:25) at Module.require (module.js:353:17) at require (internal/module.js:12:17) at Object. (/home/lamby/temp/cdt.20161107132446.quqSm7tjme.db.node-dateformat/node-dateformat-1.0.11/test/test_formats.js:3:9) at Module._compile (module.js:409:26) at Object.Module._extensions..js (module.js:416:10) at Module.load (module.js:343:32) at Function.Module._load (module.js:300:12) at Module.require (module.js:353:17) at require (internal/module.js:12:17) at /usr/lib/nodejs/mocha/lib/mocha.js:172:27 at Array.forEach (native) at Mocha.loadFiles (/usr/lib/nodejs/mocha/lib/mocha.js:169:14) at Mocha.run (/usr/lib/nodejs/mocha/lib/mocha.js:356:31) at Object. (/usr/lib/nodejs/mocha/bin/_mocha:366:16) at Module._compile (module.js:409:26) at Object.Module._extensions..js (module.js:416:10) at Module.load (module.js:343:32) at Function.Module._load (module.js:300:12) at Function.Module.runMain (module.js:441:10) at startup (node.js:139:18) at node.js:974:3 debian/rules:7: recipe for target 'override_dh_auto_test' failed make[1]: *** [override_dh_auto_test] Error 1 make[1]: Leaving directory '/home/lamby/temp/cdt.20161107132446.quqSm7tjme.db.node-dateformat/node-dateformat-1.0.11' debian/rules:3: recipe for target 'build' failed make: *** [build] Error 2 […] The full build log is attached. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- node-dateformat.1.0.11-1.unstable.amd64.log.txt.gz Description: Binary data -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#842209: node-redis: accesses the internet during build
Source: node-redis Version: 0.12.1-2 Severity: important Justification: Policy 4.9 User: la...@debian.org Usertags: network-access Dear Maintainer, Whilst node-redis builds successfully on unstable/amd64, according to Debian Policy 4.9 packages may not attempt network access during a build. 00:00:00.00 IP 476558fa4dd0.38070 > 10.0.1.1.domain: 64666+ A? filefish.redistogo.com. (40) 00:00:00.059148 IP 10.0.1.1.domain > 476558fa4dd0.38070: 64666 2/0/0 CNAME ec2-75-101-153-205.compute-1.amazonaws.com., A 75.101.153.205 (109) 00:00:00.060112 IP 476558fa4dd0.39556 > ec2-75-101-153-205.compute-1.amazonaws.com.9006: Flags [S], seq 2678420516, win 29200, options [mss 1460,sackOK,TS val 35120573 ecr 0,nop,wscale 7], length 0 00:00:00.153304 IP ec2-75-101-153-205.compute-1.amazonaws.com.9006 > 476558fa4dd0.39556: Flags [S.], seq 1558569924, ack 2678420517, win 26847, options [mss 1400,sackOK,TS val 257662111 ecr 35120573,nop,wscale 7], length 0 00:00:00.153383 IP 476558fa4dd0.39556 > ec2-75-101-153-205.compute-1.amazonaws.com.9006: Flags [.], ack 1, win 229, options [nop,nop,TS val 35120596 ecr 257662111], length 0 00:00:00.154420 IP 476558fa4dd0.39556 > ec2-75-101-153-205.compute-1.amazonaws.com.9006: Flags [P.], seq 1:54, ack 1, win 229, options [nop,nop,TS val 35120596 ecr 257662111], length 53 00:00:00.247261 IP ec2-75-101-153-205.compute-1.amazonaws.com.9006 > 476558fa4dd0.39556: Flags [.], ack 54, win 210, options [nop,nop,TS val 257662135 ecr 35120596], length 0 00:00:00.247270 IP ec2-75-101-153-205.compute-1.amazonaws.com.9006 > 476558fa4dd0.39556: Flags [P.], seq 1:6, ack 54, win 210, options [nop,nop,TS val 257662135 ecr 35120596], length 5 00:00:00.247308 IP 476558fa4dd0.39556 > ec2-75-101-153-205.compute-1.amazonaws.com.9006: Flags [.], ack 6, win 229, options [nop,nop,TS val 35120620 ecr 257662135], length 0 00:00:00.248334 IP 476558fa4dd0.39556 > ec2-75-101-153-205.compute-1.amazonaws.com.9006: Flags [P.], seq 54:68, ack 6, win 229, options [nop,nop,TS val 35120620 ecr 257662135], length 14 [..] The full build log (including tcpdump output) is attached. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- node-redis.0.12.1-2.unstable.amd64.log.txt.gz Description: Binary data -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#834988: twitter-bootstrap3: please make the build reproducible
Hi Antonio, Thanks for the explanation. Looking at the patch quickly: year := $(shell date -d @$(SOURCE_DATE_EPOCH) +%Y) This should actually be: year := $(shell date -u -d @$(SOURCE_DATE_EPOCH) +%Y) … otherwise it will not be reproducible "on" New Years Eve or New Year's Day due to timezones. :) Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#834988: twitter-bootstrap3: please make the build reproducible
Antonio Terceiro wrote: > Unfortunately this patch does not fix the issue as the file it changes > is not actually used in the Debian build. Interesting. Could you elaborate? I would have tested it at the time, I would hope! Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#834988: twitter-bootstrap3: please make the build reproducible
Dear Maintainer, > Source: twitter-bootstrap3 > Version: 3.3.6+dfsg-1 > Tags: patch There hasn't seem to be any update on this bug in 63 days, in which time the Reproducible Builds effort has come on a long way. :) Would you consider applying this patch and uploading? Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#841698: node-lodash: FTBFS with bash as /bin/sh
tags 841698 + patch thanks Patch attached. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- diff --git a/debian/rules b/debian/rules index 07026b3..db6cc15 100755 --- a/debian/rules +++ b/debian/rules @@ -14,10 +14,6 @@ override_dh_auto_clean: override_dh_auto_build: dh_auto_build - if [ ! -d debian/build ]; \ - then mkdir debian/build; \ - fi; \ - do \ - cp lodash.js debian/build/; \ - $(js-compressor) -o debian/build/$$(basename lodash .js).min.js lodash.js; \ - done + mkdir -p debian/build + cp lodash.js debian/build + $(js-compressor) -o debian/build/$$(basename lodash .js).min.js lodash.js -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#841698: node-lodash: FTBFS with bash as /bin/sh
Source: node-lodash Version: 2.4.1+dfsg-3 Severity: serious Justification: fails to build from source User: reproducible-bui...@lists.alioth.debian.org Usertags: ftbfs X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org Dear Maintainer, node-lodash fails to build from source in unstable/amd64 when /bin/sh is set to bash: […] debian/rules override_dh_auto_build make[1]: Entering directory '/home/lamby/temp/cdt.20161022151027.jj3SRN2eOz.db.node-lodash/node-lodash-2.4.1+dfsg' dh_auto_build if [ ! -d debian/build ]; \ then mkdir debian/build; \ fi; \ do \ cp lodash.js debian/build/; \ uglifyjs -o debian/build/$(basename lodash .js).min.js lodash.js; \ done /bin/sh: -c: line 3: syntax error near unexpected token `do' /bin/sh: -c: line 3: `do \' debian/rules:16: recipe for target 'override_dh_auto_build' failed […] The full build log is attached. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- node-lodash.2.4.1+dfsg-3.unstable.amd64.log.txt.gz Description: Binary data -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#841274: node-define-property: FTBFS: Error: Cannot find module 'wrappy'
Santiago Vila wrote: > Thanks and sorry for the noise. Really don't worry about it; was just an FYI. :) > Assuming that this one is the real cause for all the bugs I reported, > I'm going to merge them all into this one. Awesome - great work. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#841338: node-repeat-element: FTBFS (Error: Cannot find module wrappy)
Hi, > node-repeat-element: FTBFS (Error: Cannot find module wrappy) This (and others) appears to be a duplicate of #841274. I used "affects" there, perhaps incorrectly, but at least it avoids duplicates. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-fs.realpath_1.0.0-1_amd64.changes REJECTED
Doesn't mention joylent (?). Please clarify and re-upload. === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
