Re: On commit messages... again

2011-01-08 Thread IOhannes m zmölnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/08/2011 03:19 PM, Jonas Smedegaard wrote: > On Sat, Jan 08, 2011 at 03:04:55PM +0100, IOhannes m zmölnig wrote: >> On 01/08/2011 01:05 AM, Felipe Sateler wrote: >>> Please, be descriptive in the commit messages. A commit messa

Re: On commit messages... again

2011-01-08 Thread Jonas Smedegaard
On Sat, Jan 08, 2011 at 03:04:55PM +0100, IOhannes m zmölnig wrote: On 01/08/2011 01:05 AM, Felipe Sateler wrote: Please, be descriptive in the commit messages. A commit message saying "add libblah-dev as build-depends" is not really useful, as we can see that from the patch. Th

Re: On commit messages... again

2011-01-08 Thread IOhannes m zmölnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/08/2011 01:05 AM, Felipe Sateler wrote: > Please, be descriptive in the commit messages. A commit message saying > "add libblah-dev as build-depends" is not really useful, as we can see > that from the patch. The point of co

On commit messages... again

2011-01-07 Thread Felipe Sateler
Please, be descriptive in the commit messages. A commit message saying "add libblah-dev as build-depends" is not really useful, as we can see that from the patch. The point of commit messages is to explain why the changes are necessary (eg, "Enable support for doing something

Re: Commit messages

2010-10-14 Thread Alessio Treglia
Hi Felipe! Sorry for the delay, I got back home few hours ago. On Thu, Oct 7, 2010 at 4:10 PM, Felipe Sateler wrote: > Please, when the reason for the change is not obvious, elaborate on it > on the commit message! ALSA is linux specific, so without any further > information I would say that thi

Commit messages

2010-10-07 Thread Felipe Sateler
On 10/06/2010 05:33 PM, ales...@users.alioth.debian.org wrote: > The following commit has been merged in the master branch: > commit 04552b834cd82771e5b1bbf85cf5f6e43288f22f > Author: Alessio Treglia > Date: Wed Oct 6 23:33:13 2010 +0200 > > Re-enable libasound2-dev build-dependency for hur