D11219: Increase the "Add Source" dialog's width

This revision was automatically updated to reflect the committed changes. Closed by commit R134:53f3ce95e634: Increase the Add Source dialogs width (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11219?vs=29371=29372

D11219: Increase the "Add Source" dialog's width

ngraham updated this revision to Diff 29371. ngraham added a comment. Stupid caveman fix using the web interface REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11219?vs=29370=29371 REVISION DETAIL https://phabricator.kde.org/D11219

D11219: Increase the "Add Source" dialog's width

ngraham updated this revision to Diff 29370. ngraham added a comment. For some reason rebaseing on master pulled in an unrelated appstream change REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11219?vs=29369=29370 BRANCH

D11219: Increase the "Add Source" dialog's width

ngraham updated this revision to Diff 29369. ngraham added a comment. Rebase on master REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11219?vs=29192=29369 BRANCH wider-add-source-dialog (branched from master) REVISION DETAIL

D11214: Don't let the selection text overlap the Update button

ngraham abandoned this revision. ngraham added a comment. Abandoning in favor of D11218 , which is a better approach. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11214 To: ngraham, #discover_software_store,

D11215: Improve Updates page toolbar entries left and right padding

ngraham abandoned this revision. ngraham added a comment. Abandoning in favor of D11218 , which is a better approach. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11215 To: ngraham, #discover_software_store,

D11218: Show all actions on the main Kirigami toolbar and use the secondary one only for status

ngraham closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11218 To: ngraham, apol, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11218: Show all actions on the main Kirigami toolbar and use the secondary one only for status

ngraham updated this revision to Diff 29368. ngraham added a comment. Rebase on master REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11218?vs=29329=29368 BRANCH better-updates-page-toolbars (branched from master) REVISION DETAIL

D11274: Fix font rendering for non-HiDPI and integer scale factors

ngraham created this revision. ngraham added reviewers: mart, davidedmundson, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY QQC2-desktop-style was attempting to force

D11219: Increase the "Add Source" dialog's width

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I'm not sure. Oh well, land it as is, if it becomes a problem we'll solve it. REPOSITORY R134 Discover Software Store BRANCH wider-add-source-dialog (branched from master) REVISION DETAIL

D11197: Allow OverlaySheet clients to omit the built-in close button

ngraham updated this revision to Diff 29359. ngraham added a comment. Make the property a simple alias REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11197?vs=29130=29359 BRANCH overlay-sheet-without-close-button (branched from master) REVISION DETAIL

D1230: GBM remote access support for KWin

romangg added inline comments. INLINE COMMENTS > main_wayland.cpp:780 > pluginName = KWin::automaticBackendSelection(); > +std::cerr << "Selected backend " << pluginName.toStdString() << > std::endl; > } Put this after the if clause (such that it shows the selected

D1231: Add Remote Access interface to KWayland

romangg added a comment. Please rebase onto master (or if this leads to problems with your remote merge master). REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson, romangg Cc: jgrulich, romangg, ngraham, alexeymin,

D11219: Increase the "Add Source" dialog's width

ngraham added a comment. In D11219#223908 , @apol wrote: > I wonder if wit would make sense to make it in terms of the parent size too. Something like: `width: Math.min(gridUnit*20, parent.width * 0.8)` For some reason `Math.min

D11072: [Active Window Control] Show window title when app name is missing

Pitel added a comment. Do I need to do anything to make it land? REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D11072 To: Pitel, #plasma, martinkostolny Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10669: Reduce plasmashell frozen time

This revision was automatically updated to reflect the committed changes. Closed by commit R278:ff6c795dcda7: Reduce plasmashell frozen time (authored by jtamate). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10669?vs=27575=29346#toc REPOSITORY R278 KWindowSystem CHANGES SINCE LAST

D11262: KDE logout screen background color fix

Pitel added a comment. In D11262#224113 , @ngraham wrote: > Would you be interested in producing similar patches for the Lock and Login screens, which suffer from the same issue? > > - Login screen:

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

ngraham added a comment. In D11253#223776 , @hein wrote: > This patch is based on misunderstanding a reddit comment: https://bugs.kde.org/show_bug.cgi?id=391485#c9 > > Heavy -1 for making the menu way too wordy. > > On a meta-level, it's

D11262: KDE logout screen background color fix

ngraham added a comment. In D11262#224062 , @Pitel wrote: > With dark button background as it used to F5750710: Screenshot_20180312_151959.png > but if you choose some crazy combination (like black text

D11205: Fix ActionButton size

mart added a comment. In D11205#222643 , @ngraham wrote: > I think the real error is deriving the button size from a Spacing value and not a Size value. We should fix that, or else we'll have to do the same thing if we ever change the spacing

D11197: Allow OverlaySheet clients to omit the built-in close button

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. I'm ok with it, tough i would change a bit the logic, as described INLINE COMMENTS > OverlaySheet.qml:117 > + */ > +property bool showCloseButton: true > + property alias

D11189: Force a content size into the background style item

mart added inline comments. INLINE COMMENTS > apol wrote in PrivateActionToolButton.qml:70 > It's just copying the logic that is used above. but why a static number at all? the problem is that the v arrow can be outside? but it's in the RowLayout, so its size should be taken into account in

D11261: Add a button to clear the notification history

Fuchs added a comment. In D11261#224058 , @abetts wrote: > In D11261#224056 , @Fuchs wrote: > > > In D11261#224054 , @abetts wrote: > > > > > We have

D11262: KDE logout screen background color fix

abetts added a comment. Seems pretty good! +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11262 To: Pitel, mart, #plasma Cc: abetts, broulik, mvourlakos, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11262: KDE logout screen background color fix

Pitel added a comment. With dark button background as it used to F5750710: Screenshot_20180312_151959.png but if you choose some crazy combination (like black text on green background) it will also work (without this patch the background here would be

D11261: Add a button to clear the notification history

abetts added a comment. In D11261#224056 , @Fuchs wrote: > In D11261#224054 , @abetts wrote: > > > We have discussed something like this before. My only worry with this implementation is that we

D11261: Add a button to clear the notification history

Fuchs added a comment. In D11261#224054 , @abetts wrote: > We have discussed something like this before. My only worry with this implementation is that we have so much red on the screen that it becomes distracting. Not the fault of this patch,

D11261: Add a button to clear the notification history

abetts added a comment. We have discussed something like this before. My only worry with this implementation is that we have so much red on the screen that it becomes distracting. Not the fault of this patch, but I am wondering if there is a way that we can use a monochrome X button?

D11262: KDE logout screen background color fix

abetts added a comment. What will it look like now? Screenshot? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11262 To: Pitel, mart, #plasma Cc: abetts, broulik, mvourlakos, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol,

D10750: wayland: Add support for zwp_linux_dmabuf

fredrik updated this revision to Diff 29331. fredrik added a comment. Import the context. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10750?vs=27803=29331 REVISION DETAIL https://phabricator.kde.org/D10750 AFFECTED FILES

D11262: KDE logout screen background color fix

broulik added a comment. See https://www.w3.org/TR/2008/REC-WCAG20-20081211/#relativeluminancedef REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11262 To: Pitel, mart, #plasma Cc: broulik, mvourlakos, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D11262: KDE logout screen background color fix

mvourlakos added a comment. @broulik do you know why this part is needed? var a = [color.r, color.g, color.b].map(function (v) { return (v <= 0.03928) ? v / 12.92 : Math.pow( ((v + 0.055) / 1.055), 2.4 ); });

D11218: Show all actions on the main Kirigami toolbar and use the secondary one only for status

ngraham updated this revision to Diff 29329. ngraham added a comment. - Bring back left-justifies text in secondary toolbar - Add an icon for the refresh action REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11218?vs=29193=29329 BRANCH

D11218: Show all actions on the main Kirigami toolbar and use the secondary one only for status

ngraham added a comment. I thought the centered text looked better, but I can undo that. I think the real issue here is that if I add a second action to `contextualActions`, they both appear under an overflow button, despite the fact that there's enough room on the toolbar to fit both

D11261: Add a button to clear the notification history

Fuchs closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11261 To: Fuchs, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11262: KDE logout screen background color fix

broulik added a comment. In color picker I use: // formula for luminance according to https://www.w3.org/TR/2008/REC-WCAG20-20081211/#relativeluminancedef var a = [color.r, color.g, color.b].map(function (v) { return (v

D11262: KDE logout screen background color fix

mvourlakos added a comment. For Latte I am using a different way to determine Luminance.. https://en.wikipedia.org/wiki/Relative_luminance something like property real luminance = 0.2126*r + 0.7152*g + 0.0722*b values above 0.65 threshold I consider them light and lower I

D11261: Add a button to clear the notification history

Fuchs added a comment. New screenshot with fixes F5750621: clearhistory.png REPOSITORY R120 Plasma Workspace BRANCH fuchs-notification-clearhistory (branched from master) REVISION DETAIL https://phabricator.kde.org/D11261 To: Fuchs, broulik Cc:

D11261: Add a button to clear the notification history

Fuchs updated this revision to Diff 29325. Fuchs added a comment. - Better hack for placement REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11261?vs=29321=29325 BRANCH fuchs-notification-clearhistory (branched from master) REVISION DETAIL

D7537: KDE logout screen - change black icons & texts to white/greyish

Pitel added a comment. I finally found what was wrong here: the background should not be black when button background color is light but the calculation introduced by D5036 is wrong. My attempt to fix it is D11262 .

D11262: KDE logout screen background color fix

Pitel created this revision. Pitel added reviewers: mart, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY The patch D5036 did calculate

D11220: option to force FolderView icon-only presentation

mvourlakos added a comment. Please read also: https://bugs.kde.org/show_bug.cgi?id=379888 why I proposed this. The issue appeared from Latte Dock. When the user uses the parabolic effect and the FolderView is animated then somewhere in the middle of the animation it changes from icon

D11261: Add a button to clear the notification history

Fuchs updated this revision to Diff 29321. Fuchs added a comment. - Change the layout import according to kbroulik REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11261?vs=29320=29321 BRANCH fuchs-notification-clearhistory (branched from master)

D11261: Add a button to clear the notification history

Fuchs updated this revision to Diff 29320. Fuchs added a comment. - Use Math.round() as per discussion REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11261?vs=29319=29320 BRANCH fuchs-notification-clearhistory (branched from master) REVISION

D11261: Add a button to clear the notification history

Fuchs updated this revision to Diff 29319. Fuchs added a comment. - Capitalized History in the tooltip label as per discussion REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11261?vs=29318=29319 BRANCH fuchs-notification-clearhistory (branched

D11215: Improve Updates page toolbar entries left and right padding

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I'm not sure why this is needed now. I guess it makes sense to have this in 5.12. REPOSITORY R134 Discover Software Store BRANCH improve-updates-page-toolbar-buttons-padding (branched

D11261: Add a button to clear the notification historyBUG: 386068FIXED-IN: 5.13.0

Fuchs added a comment. Screenshot: F5750498: clear_history.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11261 To: Fuchs, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D11261: Add a button to clear the notification historyBUG: 386068FIXED-IN: 5.13.0

Fuchs created this revision. Fuchs added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Fuchs requested review of this revision. REVISION SUMMARY Adds a button in the plasmoid header to clear the history, same as the

D7537: KDE logout screen - change black icons & texts to white/greyish

davidedmundson added a comment. I'm a bit confused. Your "before" screenshot doesn't match what I see, and yet your bug report mentions "normal Breeze theme". In the current code, it should be loading the complementary colour set (which effectively is the "dark background colour

D11218: Show all actions on the main Kirigami toolbar and use the secondary one only for status

apol added a comment. It looks to me like the Refresh action has more relevance here, which is odd. Also the centered text looks weird now, maybe needs reconsideration too. INLINE COMMENTS > UpdatesPage.qml:69 > RowLayout { > -anchors.fill: parent > +

D11219: Increase the "Add Source" dialog's width

apol added a comment. I wonder if wit would make sense to make it in terms of the parent size too. Something like: `width: Math.min(gridUnit*20, parent.width*0.8)` REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11219 To: ngraham, apol,

Plasma weekly meeting notes

Attached logs and notes for week 11 -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D 16:35 <@bshah> alright.. Sho_ notmart romangg kbroulik bshah is the order 16:35 <@bshah> Sho_: go go :) 16:35 k sec

D11220: option to force FolderView icon-only presentation

sebas added a comment. In principle yes, but the applet should of course react suitably to these constraints. A config option for this seems to duplicate the concept of constraints (which are indeed determined by the containment.) REPOSITORY R119 Plasma Desktop REVISION DETAIL

D11220: option to force FolderView icon-only presentation

broulik added inline comments. INLINE COMMENTS > ConfigIcons.qml:155 > +checked: cfg_forceIconInPanel > +text: i18n("Force icon presentation in panel") > +} "Always show as icon" or something like that? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D11064: add preview images to fonts kcm

progwolff added a comment. @davidedmundson ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson, ngraham Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai,

D11220: option to force FolderView icon-only presentation

hein added a reviewer: mart. hein added a comment. Hmm I don't like the approach about putting this into individual applets - I think the containment should force constraints on the applets instead, and the applets need to follow the constraints. That's more Plasma-idiomatic to me. Marco?

D11257: Improve By Desktop sorting for task groups

hein created this revision. hein added a reviewer: Plasma. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY TaskGroupingProxyModel used to return QVariant() as the AbstractTasksModel::VirtualDesktop role for task groups, resulting in

D11233: Ordered system tray

wsdfhjxc updated this revision to Diff 29307. wsdfhjxc added a comment. - Wait for the item id before inserting it into tray - Sort the tray items by categories and ids REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11233?vs=29275=29307 BRANCH

D11254: Fix scrollbar on empty search results

hein created this revision. hein added a reviewer: Plasma. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY ListView.contentItem does crazy things when the view is set to 0 height, causing ScrollArea to show a scrollbar. This avoids

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

hein added a comment. This patch is based on misunderstanding a reddit comment: https://bugs.kde.org/show_bug.cgi?id=391485#c9 -1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11253 To: ngraham, #plasma, davidedmundson Cc: hein, broulik, richardbowen,

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

broulik added a comment. +1 I just hope it won't make the menu too wide „Arbeitsfläche und Hintergrundbild einrichten“ is what I guess it would be for my locale (but then we already have „Inhalt der Zwischenablage einfügen“ for Paste) so that is not a big deal ;) REPOSITORY R119