D13481: Recommend window border size "None"

ngraham added a comment. Does this/should this also implement the diff from D13278 ? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D13481 To: romangg, #plasma, #vdg Cc: ngraham, davidedmundson, graesslin, abetts, mart,

D13529: [minimizeAll] Do not try to restore window state on model change

anthonyfieroni updated this revision to Diff 36300. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13529?vs=36270=36300 REVISION DETAIL https://phabricator.kde.org/D13529 AFFECTED FILES applets/minimizeall/package/contents/ui/main.qml To:

D13596: Fix there being more security updates than total updates in notifier

ngraham added subscribers: apol, ngraham. ngraham added reviewers: Discover Software Store, apol. ngraham added a comment. For bugfixes like this, the workflow is to commit to the "stable branch" (in this case `Plasma/5.12`) and then merge to master. In this case you would also merge to

D13596: Fix there being more security updates than total updates in notifier

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY We currently read the previous `m_securityCount` instead of using the current `securityCount`. BUG:

D13529: [minimizeAll] Do not try to restore window state on model change

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > davidedmundson wrote in main.qml:98 > Oh! > > The old c++ plugin had deactivate(bool) where the parameter indicated whether > we restored

D13095: Scren brightness follow a quatratic progression

sharvey added a comment. A couple of random ideas: - The Arch Wiki has a lengthy page on screen brightness. Maybe there's something there that can help. - Is there a valid use case for going all the way to zero? Minimum doesn't

D13095: Scren brightness follow a quatratic progression

ngraham added a comment. I don't think we want the possibility of breaking anyone. A setting doesn't seem ideal either; who would ever find and change this? Rather, let's focus on the issue that's hurting us here to see if we can resolve it somehow. Is there any way to programmatically

D13095: Scren brightness follow a quatratic progression

thsurrel added a comment. > Same values as `/sys/class/backlight/*/brightness`, in other words. Thanks Nate, even if that's not the answer I was hoping for ... The future of this patch: - accept to break some systems (but who wants that ?) - add an option for this quadratic

D6096: Add Wayland RemoteAccess capabilities to KRfb

zzag added inline comments. INLINE COMMENTS > pw_framebuffer.h:27 > +PWFrameBuffer(WId winid, QObject *parent = nullptr); > +virtual ~PWFrameBuffer() override; > + `virtual` is redundant. (also, it doesn't make sense to have both `virtual` and `override`) > pw_framebufferplugin.h:36 >

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

ngraham added a comment. Most of this stuff used to be hidden behind a Configure button, but it was changed to put everything on the main page in 5.13 as part of the QML port: D8916 IMHO as long as we're going to present everything on the main page,

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

abetts added a comment. In D13593#279642 , @nicolasfella wrote: > Sometimes it's better to be precise about well-known technical terms instead of hiding them. Would a person who does not know what anti-aliasing is want/need to change that

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

nicolasfella added a comment. Sometimes it's better to be precise about well-known technical terms instead of hiding them. Would a person who does not know what anti-aliasing is want/need to change that setting? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Improve the user-friendliness of some strings in the Fonts

D13591: Set complete vectors instead of creting them at runtime

zzag added inline comments. INLINE COMMENTS > zzag wrote in breezesizegrip.cpp:150 > Can be const. Also, couldn't you do painter.drawPolygon( QVector<>{} ); REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D13591 To: tcanabrava, #breeze Cc: ngraham, zzag,

D13591: Set complete vectors instead of creting them at runtime

tcanabrava added inline comments. INLINE COMMENTS > zzag wrote in breezeshadowhelper.cpp:461-464 > Not the best thing. But shadows in Breeze have positive margins so that's > okay. they where added to the data vector before, and the data vector is quint32, so I don't see the difference.

D13591: Set complete vectors instead of creting them at runtime

zzag added inline comments. INLINE COMMENTS > breezesizegrip.cpp:54 > // mask > -QPolygon p; > -p << QPoint( 0, GripSize ) > -<< QPoint( GripSize, 0 ) > -<< QPoint( GripSize, GripSize ) > -<< QPoint( 0, GripSize ); > +QPolygon

D13591: Set complete vectors instead of creting them at runtime

zzag added a comment. Maybe, it makes sense to create a static const, e.g. static const QVector s_minimizeButtonPoly { QPointF( 4, 9 ), QPointF( 9, 4 ), QPointF( 14, 9 ), QPointF( 9, 14 ) }; REPOSITORY R31 Breeze REVISION DETAIL

D13573: Touchpad KCM QtQuickControls2 Conversion

furkantokac added a comment. @davidedmundson @mart Thanks for the feedback. New patch is coming. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13573 To: furkantokac, romangg, ngraham, #plasma, mart Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel,

D13591: Set complete vectors instead of creting them at runtime

tcanabrava created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY Don't iterate over a vector to append in a vector Append a vector instead of 4 items

D13481: Recommend window border size "None"

davidedmundson added a comment. There are two visual hints when the mouse is inside the deadzone. You would still get the different cursor The client gets the mouse left event and would not show any hover effect on whatever control might be there. REPOSITORY R31 Breeze REVISION

D13481: Recommend window border size "None"

graesslin added a comment. I realized that there's yet another problem with the approach: if two windows border and the window with pointer focus is lower in the stacking order this would create a dead zone in the window. With compositing disabled this would be worse as there's not even a

D13481: Recommend window border size "None"

abetts added a comment. +1 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D13481 To: romangg, #plasma, #vdg Cc: abetts, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D13586: Ref KConfig whilst we're using it

fvogt added a comment. In D13586#279514 , @ngraham wrote: > Could this have any relationship to https://bugs.kde.org/show_bug.cgi?id=395401? In theory yes, this is undefined behaviour and could cause everything between making a pixel

D13586: Ref KConfig whilst we're using it

ngraham added a comment. Could this have any relationship to https://bugs.kde.org/show_bug.cgi?id=395401? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13586 To: davidedmundson, #plasma Cc: ngraham, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D13586: Ref KConfig whilst we're using it

fvogt added a comment. I guess KSharedConfig would work as well, that way the KConfig keeps a reference alive. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13586 To: davidedmundson, #plasma Cc: fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D13586: Ref KConfig whilst we're using it

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY In current code we would have a KConfigGroup

D13481: Recommend window border size "None"

mart added a comment. +1 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D13481 To: romangg, #plasma, #vdg Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D13529: [minimizeAll] Do not try to restore window state on model change

anthonyfieroni updated this revision to Diff 36270. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13529?vs=36160=36270 REVISION DETAIL https://phabricator.kde.org/D13529 AFFECTED FILES applets/minimizeall/package/contents/ui/main.qml To:

D13573: Touchpad KCM QtQuickControls2 Conversion

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > davidedmundson wrote in main.qml:23 > this is either unused or wrong he's using qqc1 tooltips, they should be ported as well. > davidedmundson wrote in

D13529: [minimizeAll] Do not try to restore window state on model change

davidedmundson added a comment. > Because you can miss or forgive that you activate it, we definitely NOT want to deactivate effect when you click desktop :) in this patch it DOES set active = false when you click on the desktop That's why I used the onDataChanged REPOSITORY R114

D13529: [minimizeAll] Do not try to restore window state on model change

anthonyfieroni added a comment. onVirtualDesktopChanged and onActivityChanged it looks good to deactivate effect with restoring windows state. Because you can miss or forgive that you activate it, we definitely NOT want to deactivate effect when you click desktop :) I think now it's looking

D13529: [minimizeAll] Do not try to restore window state on model change

davidedmundson added inline comments. INLINE COMMENTS > main.qml:98 > +onActiveTaskChanged: { > +root.active = false; > +root.minimizedClients = []; Oh! The old c++ plugin had deactivate(bool) where the parameter indicated whether we restored the minimised

D13360: Touchpad KDED module: Convert to JSON metadata

fvogt added a comment. This doesn't seem to be in Plasma/5.13. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13360 To: marten, #plasma, davidedmundson Cc: fvogt, romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,