Re: Plasma repositories sprint cleaning

Cheers, Ivan -- dr Ivan Čukić KDE e.V., ivan.cu...@kde.org, https://cukic.co/ gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232 07AE 01C6 CE2B FF04 1C12

Re: C++/library requirements for Plasma 5.26

th experimental compiler features. If we go for coroutines, I'd just advise a slower and well-planned adoption then - use it in a smaller, but often used part, and then go from there. (I hate advocating slow adoption of something this cool, but... :) ) Cheers, Ivan -- dr Ivan Čukić ivan.cu...

Re: C++/library requirements for Plasma 5.26

one, I can't dare to imagine issues we can introduce to Clang-based distros. :) Cheers, Ivan p.s. From a personal standpoint, yes, I'd really like to be able to use QCoro in Vault... [1] https://en.cppreference.com/w/cpp/compiler_support/20 [2] https://clang.llvm.org/cxx_status.html -- dr Ivan

Re: Request on the Kickoff replacement

Hi David, > The KickOff replacement is a big change. I adapted to KickOff and now I > have to adapt to the new one. Just a small note - you don't have to - the old one is now on store.kde.org as Legacy Kickoff [1] Cheers, Ivan [1] https://store.kde.org/p/1468103/ -- dr Ivan Č

Re: Activities (problems & proposals)

w by default. Martin wrote: > The window menu approach is quite awkward. I wonder whether dragging > a window onto the widget which then would open a sidebar with all Dragging the window was not possible so the dragging from task manager to the applet was introduced. But, it seems to have problems for Niccolo. Cheers, Ivan -- dr Ivan Čukić i...@cukic.co, https://cukic.co/ gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232 07AE 01C6 CE2B FF04 1C12

Re: Gitlab and plasma dev

rge of doing is to @people that I'd like to notice the review in the comment to the MR. Cheers, Ivan -- dr Ivan Čukić i...@cukic.co, https://cukic.co/ gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232 07AE 01C6 CE2B FF04 1C12

Re: Plasma Firewall

- Assigning long-lived parents is naughty: https://invent.kde.org/tcanabrava/ plasma-firewall/-/blob/master/kcm/backends/ufw/ufwclient.cpp#L318 So much from me at this point. Cheers, Ivan -- dr Ivan Čukić i...@cukic.co, https://cukic.co/ gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232 07AE 01C6 CE2B FF04 1C12

Re: Gitlab and plasma dev

*) for me at least, it had an opposite effect to the desired -- dr Ivan Čukić i...@cukic.co, https://cukic.co/ gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232 07AE 01C6 CE2B FF04 1C12

D29679: Dedicated drop areas for assigning tasks to activities

ivan closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29679 To: ivan, #plasma, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,

D29595: Add gocryptfs support

ivan added a comment. Done. Thanks again for the patch! REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D29595 To: mpilia, ivan, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot,

D29595: Add gocryptfs support

ivan closed this revision. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D29595 To: mpilia, ivan, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D29679: Dedicated drop areas for assigning tasks to activities

ivan created this revision. ivan added reviewers: Plasma, ngraham, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ivan requested review of this revision. REVISION SUMMARY Instead of using a difficult to discover 'move to activity by default, copy to activity

D29595: Add gocryptfs support

ivan added inline comments. INLINE COMMENTS > mpilia wrote in vaultwizardbase.h:65 > Of course, sorry. For some reason I though 1 was highest priority. Heh, it was my first impression when the priority patch was contributed to Vaults. Now I'm extra careful :) REPOSITORY R845 Plasma Vault

D29595: Add gocryptfs support

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Great work! INLINE COMMENTS > vaultwizardbase.h:65 > +{ "cryfs", 2 }, > +{ "gocryptfs", 3 }, > }; Lower the priority to 1. I don't want to have gocryptfs as

D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Superseeded by https://phabricator.kde.org/D29548 since there was no activity for >2 months. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27353

D29548: Drag and drop assigning windows to activities in the default switcher

ivan closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29548 To: ivan, #plasma, mart, davidedmundson, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,

D29548: Drag and drop assigning windows to activities in the default switcher

ivan created this revision. ivan added reviewers: Plasma, mart, davidedmundson, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ivan requested review of this revision. REVISION SUMMARY When dragging a window from the taskbar onto the activity switcher applet,

D29379: Unassign activity from vault on activity deletion

ivan closed this revision. REVISION DETAIL https://phabricator.kde.org/D29379 To: ivan, ngraham, davidedmundson, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg,

D29379: Unassign activity from vault on activity deletion

ivan updated this revision to Diff 81780. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29379?vs=81779=81780 REVISION DETAIL https://phabricator.kde.org/D29379 AFFECTED FILES kded/service.cpp kded/service.h To: ivan, ngraham Cc: plasma-devel, Orage, LeGast00n,

D29379: Unassign activity from vault on activity deletion

ivan created this revision. ivan added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ivan requested review of this revision. REVISION SUMMARY CCBUG: 420784 REPOSITORY R845 Plasma Vault BRANCH master REVISION DETAIL

Re: Information regarding upcoming Gitlab Migration: clarifications

both sentiments - that projects should have different names and that this is a bit off topic for the gitlab migration. Cheers, Ivan -- dr Ivan Čukić i...@cukic.co, https://cukic.co/ gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232 07AE 01C6 CE2B FF04 1C12

D29110: [applet] Port to Kirigami.PlaceholderMessage

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Fair enough. REPOSITORY R845 Plasma Vault BRANCH port-to-PlaceholderMessage (branched from master) REVISION DETAIL https://phabricator.kde.org/D29110 To: ngraham, #vdg, #plasma, ivan,

D29130: [Applet] Show in system tray iff at least one vault is open

ivan added a comment. And I'l just be using my keyboard shortcut ;) REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D29130 To: ksmanis, #plasma, #vdg, ivan Cc: kmaterka, broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D29130: [Applet] Show in system tray iff at least one vault is open

ivan added a comment. I'm not fond of this change, but I agree with Nate's comment about the possibility of setting 'always visible' for users that wish to keep the current behaviour, so I'm not going to give this a -1. I'd still like the current behaviour kept, maybe with a different

D29110: [applet] Port to Kirigami.PlaceholderMessage

ivan added a comment. Not sure I like pulling in Kirigami just for this. Are there other places where Kirigami could improve the Vaults applet? REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D29110 To: ngraham, #vdg, #plasma, ivan, niccolove Cc: plasma-devel,

D28333: Add a new daemon for stats monitoring

ivan added inline comments. INLINE COMMENTS > client.cpp:65-66 > +m_connections.insertMulti(sensor, connect(sensor, > ::sensorInfoChanged, this, [this, sensor]() { > +auto newInfo = sensor->info(); > +m_pendingMetaDataChanges[sensor->path()] =

D28333: Add a new daemon for stats monitoring

ivan added inline comments. INLINE COMMENTS > main.cpp:45 > +m_property1->setMin(0); > +m_property1->setMin(100); > +m_property1->setShortName("Some Sensor 1"); `setMax`? > client.cpp:38 > +{ > +connect(m_daemon, ::sensorRemoved, this, [=](const > QString ) { > +

Re: Update on Status of Gitlab Migration

Hi all, While I do like the invent name, I agree there should be a redirect of some sort from git.kde.org to it. The aforementioned Debian salsa server has one as well - https:// git.debian.org/ - a message stating that the new server is 'salsa.debian.org' Cheers, Ivan -- dr Ivan Čukić i

D28798: Make warning and error messages grammatically correct

ivan added a comment. Maybe "Unable to close the vault; it is being used by %1" -> "Unable to close the vault as it is being used by %1" ? "Unable to close the vault; an application is using it" -> "Unable to close the vault because an application is using it" While writing for

D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar

ivan added a comment. Any news on this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27353 To: wstephenson, #plasma, ivan, davidedmundson Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D28136: Add the option to show the current activity name and icon

ivan added a comment. > used Layouts instead of Anchors I know, I'm oldschool - when I was young, we didn't have QML, Kirigami and ... :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28136 To: ivan, #plasma, ngraham, davidedmundson, mart Cc:

D28136: Add the option to show the current activity name and icon

This revision was automatically updated to reflect the committed changes. Closed by commit R119:36e322792002: Add the option to show the current activity name and icon (authored by ivan). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28136: Add the option to show the current activity name and icon

ivan added a comment. Last change - use "activities" icon if no icon is set (though this should not happen if the user creates the activity through legal ways) REVISION DETAIL https://phabricator.kde.org/D28136 To: ivan, #plasma, ngraham, davidedmundson, mart Cc: plasma-devel, Orage,

D28136: Add the option to show the current activity name and icon

ivan updated this revision to Diff 78018. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28136?vs=78014=78018 REVISION DETAIL https://phabricator.kde.org/D28136 AFFECTED FILES applets/showActivityManager/package/contents/config/config.qml

D28136: Add the option to show the current activity name and icon

ivan marked 3 inline comments as done. ivan added a comment. Done REVISION DETAIL https://phabricator.kde.org/D28136 To: ivan, #plasma, ngraham, davidedmundson, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D28136: Add the option to show the current activity name and icon

ivan updated this revision to Diff 78014. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28136?vs=78006=78014 REVISION DETAIL https://phabricator.kde.org/D28136 AFFECTED FILES applets/showActivityManager/package/contents/config/config.qml

D28136: Add the option to show the current activity name and icon

ivan added a comment. Kirigami has quite interesting features I must say :) REVISION DETAIL https://phabricator.kde.org/D28136 To: ivan, #plasma, ngraham, davidedmundson, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D28136: Add the option to show the current activity name and icon

ivan updated this revision to Diff 78006. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28136?vs=77985=78006 REVISION DETAIL https://phabricator.kde.org/D28136 AFFECTED FILES applets/showActivityManager/package/contents/config/config.qml

D28136: Add the option to show the current activity name and icon

ivan added a comment. The reason for the icon setting is to have full backwards compatibility. Maybe someone likes the static icon better than random icons they set for each activity. I don't like to have everything configurable, but here it is not a significant maintainance overhead, and

D28136: Add the option to show the current activity name and icon

ivan added a comment. Screenshot: F8184234: Screenshot_20200319_112003.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28136 To: ivan, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28136: Add the option to show the current activity name and icon

ivan created this revision. ivan added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ivan requested review of this revision. REVISION SUMMARY The current activity switching applet shows a generic icon that opens the activity switcher which does

D28099: Show command output on unknown failure

This revision was automatically updated to reflect the committed changes. Closed by commit R845:1e2988d7d3ca: Show command output on unknown failure (authored by ivan). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28099?vs=77828=77836 REVISION DETAIL

D28099: Show command output on unknown failure

ivan updated this revision to Diff 77828. REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28099?vs=77822=77828 REVISION DETAIL https://phabricator.kde.org/D28099 AFFECTED FILES .gitignore kded/engine/backends/cryfs/cryfsbackend.cpp

D28099: Show command output on unknown failure

ivan added a comment. Of course... I need to reboot my brain it seems. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D28099 To: ivan, #plasma, davidedmundson, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28099: Show command output on unknown failure

ivan created this revision. ivan added reviewers: Plasma, davidedmundson, ngraham, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ivan requested review of this revision. REVISION SUMMARY If the error is unknown (all errors in encfs), show the 'details...' button

D28069: Support execution of shell scripts on activity events

This revision was automatically updated to reflect the committed changes. Closed by commit R161:9a36c4da7d7a: Support execution of shell scripts on activity events (authored by ivan). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28069?vs=77722=77724#toc REPOSITORY R161 KActivity

D28069: Support execution of shell scripts on activity events

ivan updated this revision to Diff 77722. REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28069?vs=77715=77722 REVISION DETAIL https://phabricator.kde.org/D28069 AFFECTED FILES CMakeLists.txt cmake/modules/CheckCxxFeatures.cmake

D28069: Support execution of shell scripts on activity events

ivan created this revision. ivan added reviewers: davidedmundson, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ivan requested review of this revision. REVISION SUMMARY In addition to opening a file and starting an application specified by a .desktop file,

D28035: [Applet] Port to ExpandableListItem

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. I assume people tell you that you're awesome all the time, so I'm not going to ;) REPOSITORY R845 Plasma Vault BRANCH port-to-ExpandableListItem (branched from master) REVISION DETAIL

D28035: [Applet] Port to ExpandableListItem

ivan added a comment. I like it. Is the device notifier going to look like this as Vaaults tried to mimic that one? REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D28035 To: ngraham, #vdg, #plasma, ivan Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar

ivan added a comment. This looks cool. The thing I'm missing (correct me if I'm wrong - I'm yet to test the patch) is for it to open the switcher when dragging the window over the switcher applet icon. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27353

D27322: Allow move or add window to Activities during Dnd using Ctrl modifier

ivan added a comment. Cool idea, I'll have to think of something similar for the regular activity switcher REVISION DETAIL https://phabricator.kde.org/D27322 To: wstephenson, davidedmundson, #plasma, hein Cc: ivan, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D26447: Dynamically show and hide based on whether or not any vaults are configured

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. That is why I put the "or in addition to" part. Anyhow, I don't mind this to go in as is. REPOSITORY R845 Plasma Vault BRANCH dynamically-show-and-hide (branched from master)

D26111: KRunner add a recentlyused runner accessing KActivityStats data

ivan added a comment. > Why not change the recentdocuments runner? Looks fine to me, I just don't see a response to this comment. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik Cc: broulik,

D26438: Runners: Convert foreach to for

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. @meven I hate Qt... defining `operator*` without `operator->` ... ugh I've approved the patch, sorry for the bad nitpick :) REPOSITORY R120 Plasma Workspace BRANCH master

D26438: Runners: Convert foreach to for

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. @davidedmundson Yes, the wrapper just serves for keyval iterators to be usable with a range-based for loop. Quite useful if there are a lot of these. In this case, where it is

D26438: Runners: Convert foreach to for

ivan added a comment. Something like this: template class asRangeImpl { public: asRange(const T ) : m_data{data} { } auto begin() const { return m_data.keyValueBegin(); } auto end() const { return

D26438: Runners: Convert foreach to for

ivan requested changes to this revision. ivan added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > davidedmundson wrote in fetchsqlite.cpp:100 > There's an optimisation available here This can be made much better by providing a custom range object to iterate

D26447: Dynamically show and hide based on whether or not any vaults are configured

ivan added a comment. For some reason, hiding this icon when there are no vaults was deemed undesired before. I don't recall why as I think it is a good idea. :) Maybe it was always shown for discoverability purposes... don't know. Is there a reason why this is a `count` instead of

D22005: Ensure url from KActivity resources are properly built

ivan added inline comments. INLINE COMMENTS > backend.cpp:322 > while (actionCount < 5 && resultIt != results.end()) { > -const QString resource = (*resultIt).resource(); > +QString resource = (*resultIt).resource(); > +if (QDir::isAbsolutePath(resource)) {

D22382: Add global shortcuts for switching to the previous/next activity

ivan added a comment. I'm not thrilled about having default shortcuts set. We have the shortcuts space quite polluted as it is. Especially since we have the meta+tab with different semantics. Maybe the text should explicitly state what 'next' means in this case. REPOSITORY R120

D22381: Add previous-/nextActivity methods

ivan added inline comments. INLINE COMMENTS > Activities.cpp:56 > +inline > +bool nameBaseOrdering(const ActivityInfo , const ActivityInfo > ) > +{ Nitpick Base -> Based > Activities.cpp:251 > + > +for (int i = 0; i < a.count(); ++i) { > +if (a[i] == currentActivity) {

D23737: Extract mimetype from recentlyused.xbel

ivan requested changes to this revision. ivan added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > GtkEventSpy.cpp:207 > > -void GtkEventSpyPlugin::addDocument(const QUrl , const QString > ) > +void GtkEventSpyPlugin::addDocument(const QUrl , const QString

D23112: Add a event Spy for GtkFileChooser recent files

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Another tiny change, and I think it is ready to land. Unless someone else sees other issues. INLINE COMMENTS > GtkEventSpy.cpp:126 > + > +if (exec.at(0) ==

D23112: Add a event Spy for GtkFileChooser recent files

ivan added inline comments. INLINE COMMENTS > GtkEventSpy.cpp:68 > +QDateTime visited; > +QList *applications; > + No need for this to be a pointer to a list. Make it just `QList applications`. > GtkEventSpy.cpp:70 > + > +Bookmark(){ > +applications = new QList(); The

D23112: Add a event Spy for GtkFileChooser recent files

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Thanks for geting involved this much! INLINE COMMENTS > GtkEventSpy.cpp:129 > +// remove "'" caracters wrapping the command > +exec = exec.mid(1, exec.size() -2 ); >

D22381: Add previous-/nextActivity methods

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Inserting/Removing/Updating a sorted list does not need to resort every time - removing is easy, adding a new item is std::lower_bound (a binary search), and updating is a

D22381: Add previous-/nextActivity methods

ivan added a comment. You are right, they are randomized. And, yes, that is what I meant on IRC - that redundancy due to keeping a sorted list will likely lead to future issues, but I see no other way if we want to be consistent regarding listing and switching. As it is required to

D22381: Add previous-/nextActivity methods

ivan requested changes to this revision. ivan added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > Activities.cpp:218 > +auto a = q->ListActivitiesWithInformation(); > +std::sort(a.begin(), a.end(), ); > + I don't like the fact that it constantly

D19997: Change http URLs to https

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Accepted, but incomplete ;) REPOSITORY R845 Plasma Vault BRANCH master REVISION DETAIL https://phabricator.kde.org/D19997 To: vkrause, ivan Cc: ivan, plasma-devel, jraleigh, GB_2,

D19991: FileItem plugin for opening and closing Vaults from Dolphin

ivan closed this revision. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D19991 To: ivan, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19991: FileItem plugin for opening and closing Vaults from Dolphin

ivan updated this revision to Diff 54609. REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19991?vs=54607=54609 REVISION DETAIL https://phabricator.kde.org/D19991 AFFECTED FILES CMakeLists.txt fileitemplugin/CMakeLists.txt

D19991: FileItem plugin for opening and closing Vaults from Dolphin

ivan updated this revision to Diff 54607. REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19991?vs=54599=54607 REVISION DETAIL https://phabricator.kde.org/D19991 AFFECTED FILES CMakeLists.txt fileitemplugin/CMakeLists.txt

D19991: FileItem plugin for opening and closing Vaults from Dolphin

ivan created this revision. ivan added a reviewer: davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ivan requested review of this revision. REVISION SUMMARY Adds a context menu item when the user right-clicks a directory that is a registered vaults mount

Reverted "[Activities KCM] vertically center the buttons"

Hi all, Just to notify you that I've reverted commit 9cdfe25910cbbfbef09364ce3adba53bcc292853 because it broke the layout (see [1]) of the items in the Activities KCM. Cheers, Ivan [1] https://ibin.co/4W7JHc5mZ64Q.jpg -- dr Ivan Čukić KDE, ivan.cu...@kde.org, https://cukic.co/ gpg key

D17039: ASAN: Fix leak in KAStatsFavoritesModel

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Ok, +2 from me then REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D17039 To: kfunk, davidedmundson, ivan Cc: plasma-devel, ragreen, Pitel,

D17039: ASAN: Fix leak in KAStatsFavoritesModel

ivan added a comment. Using a shared pointer seems like a pessimization. Could this be done with std::unique_ptr? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17039 To: kfunk, davidedmundson, ivan Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D16257: Use correct wording, since it is an action word(not a noun)

ivan requested changes to this revision. ivan added a comment. It is (also) a noun, though MW spells it as "pop-up" [1] [1] https://www.merriam-webster.com/dictionary/pop-up edit: Heh, Nate was faster :) REPOSITORY R120 Plasma Workspace REVISION DETAIL

D15011: [Kickoff] Make the search field always look like a search field

ivan added a comment. Different search bars are on different levels of usefulness. Use-cases for searching activities are much rarer than, for example, searching widgets. The current activity switcher UI clearly shows the search button, so there's no problem with discoverability. While

D16087: RFC: Store full URL as URI

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. > Not sure what the implications are for this change, it does fix Dolphin showing folders in its This I don't like. KAMD stores file paths, not URIs for local files in the

Re: Discussion for Virtual Desktops and Activities future

> shouldn't be more, add an activity you get one new virtual desktop, > then you can add more for that activity if you want? +1 I guess that original David's comment was about when we thought all activities would have the same number of VDs. Cheers, Ivan -- KDE, ivan.cu...@kde.org,

Re: Virtual Desktop and Activities future: Merging proposal

What to do with X11? I don't like the idea that we have two completely different behaviours for W and X. Cheers, Ivan

Re: Virtual Desktop and Activities future: Merging proposal

So, if I understood this correctly, KAMD keeps a list of activities, and a list of VDs which are usually mapped 1-1, but could also be 1-n. Adding an activity would mean adding a VD (just one by default). Removing an activity would mean removing all VDs for that activity. This could be (I think)

Re: Discussion for Virtual Desktops and Activities future

> Couldn't we teach each Swoosh how to have its own set of favorites, > recents etc, but also how to inherit the "standard" or "default" set? > Then a Swoosh could be either an Activity or a Virtual Desktop. So, configuration? That would work if it can be made pretty. Cheers, Ivan

Re: Discussion for Virtual Desktops and Activities future

UI-wise: We currently (let's pretend) have two options for the users (I've replaced the terms activity and VD with 'swoosh' inspired by the former Mozilla problem): - have multiple swooshes where favourites, recents etc. are shared - have multiple swooshes where favorties, recents are per-swoosh

Re: Discussion for Virtual Desktops and Activities future

> Work "stack" Home "stack" > || || > |VD 1| |VD 3| > | Web browser| | Web browser| > | IDE| |Music player| > || || > > || || > |VD 2| |VD

Re: Discussion for Virtual Desktops and Activities future

> I think kwin shouldn't filter them. Pager lists all, effects and shortcuts > cover all. Ugh... I think that will kill the group 'C'*. While it /would/ be possible to to use multi-VD-multi-activity setup, it would be far from convenient. Or it would require an alternative set of applets that

Re: Discussion for Virtual Desktops and Activities future

@David Regarding the backend (wherever the actual logic ends up in - kwin or kamd), your idea does sound nice. It would also provide the ability that some of the 'C' category users wanted - to have variable number of VDs per activity. But the problem is not primarily how to handle the

Re: Discussion for Virtual Desktops and Activities future

> And there would be quite a nice opportunity for a nice pr campaign. IF (and that is a big "if") we can create a new feature (just don't call it "Virtual Activated Desktops" :D) that will merge activities and VDs in a sane way, which would not be overly limiting, I would be more than happy. It

Re: Discussion for Virtual Desktops and Activities future

> Personally i always used virtual desktops exactly for that, as "activities", > even before activities were a thing, "i need a new physical space to stuff > new windows" is not an use case that ever occurred to me in any way > noted that there are people which see virtual desktops like that..

Re: Discussion for Virtual Desktops and Activities future

David> Are you (Michail and Ivan) at Akademy? Not this year, I'm taking a rest from socializing ;) Nate> very different things: Virtual Desktops are for window organization Nate> within the current set of tasks, and Activities are for higher-level This is exactly my view of VD vs activities.

Re: Discussion for Virtual Desktops and Activities future

> I think this is a fair recap so far: The recap sounds great. > When Martin and I started talking about the > Wayland protocol, we > were keen to do work that would reusable > for either use case. This I especially like this part. As I said, merging the implementation (at least to some

Re: Discussion for Virtual Desktops and Activities future

Just read the phab discussion. If I misunderstood the situation, please correct me. Wondering where the original discussion happened where 'we' decided to merge two orthogonal concepts into one. Can you point me to the relevant thread on plasma-devel?If this is about providing a unified

D13255: Make dependency on KF5NetworkManagerQt optional

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R845 Plasma Vault BRANCH arcpatch-D13255 REVISION DETAIL https://phabricator.kde.org/D13255 To: asturmlechner, #plasma, ivan Cc: plasma-devel, ragreen, Pitel,

D13255: Make dependency on KF5NetworkManagerQt optional

ivan added a comment. Very nice, thanks. If you want I can accept this (after the `Q_UNUSED` change) and I'll do the UI patch separately. INLINE COMMENTS > service.cpp:53 > +{ > +(void)enabled; > +} You should use `Q_UNUSED` instead. REPOSITORY R845 Plasma Vault

D13255: Make dependency on KF5NetworkManagerQt optional

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. - Would rather have a separate NetworkManager wrapper class implementation (a dummy implementation for when NM is disabled) than this. - Also, instead of a cmake flag, it is more

Re: KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

> In regards to NetworkManagerQt, that is unavailable as > NetworkManager itself isn't available on FreeBSD. Ok, didn't know that. NM will be an optional dep once I get to it (probably not in the next release). I guess after that PV will be buildable again on BSD. Cheers, Ivan -- KDE,

Re: Plasma Vaults by Default

Yes, that is what I meant. Cheers, Ivan On Wed, May 23, 2018 at 7:14 PM Marco Martin <notm...@gmail.com> wrote: > On domenica 20 maggio 2018 17:28:08 CEST Ivan Čukić wrote: > > Hi Jonathan, > > > > One possibility is to hide the icon if the user does not use

D13042: Do not show activity switcher during fast switches

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Looks ok to me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13042 To: thsurrel, #plasma, ivan Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot,

Re: KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

Hi all, I was on a trip. P-V is meant to be linux-only. If someone to make it work on BSD, I'm open to that. Though, it seems like a missing dep only - Could NOT find KF5 (missing: NetworkManagerQt) I'll skip commenting other parts of this discussion. Cheers, Ivan

  1   2   3   4   5   6   7   8   9   10   >