D13178: Compress calls to configuration slots upon new connections

2018-06-11 Thread Jacopo De Simoi
jacopods updated this revision to Diff 36031. jacopods added a comment. I used the direct connection as suggested. Today I learned about QOverload... CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13178?vs=35045=36031 REVISION DETAIL https://phabricator.kde.org/D13178

D13178: Compress calls to configuration slots upon new connections

2018-05-30 Thread Jacopo De Simoi
jacopods added a comment. In D13178#270671 , @mart wrote: > are configureKeyboard configureMouse etc doing an immediate write to disk? (like KConfig::sync() Hey notmart, long time no see! The configureKeyboard() method is calling

D13178: Compress calls to configuration slots upon new connections

2018-05-28 Thread Jacopo De Simoi
jacopods created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. jacopods requested review of this revision. REVISION SUMMARY Some input devices register several copies of themselves upon connection (e.g. a mouse registers

Re: Review Request 128702: Use default weight rather than normal weight

2016-09-15 Thread Jacopo De Simoi
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 663c87bc6f3881091c04beb3ce447922945cf14e by David Edmundson on behalf of Jacopo De Simoi to branch master. Repository: plasma-workspace Description --- Honor the choice of a user that has chosen

Review Request 128702: Use default weight rather than normal weight

2016-08-16 Thread Jacopo De Simoi
, Jacopo De Simoi

Re: RFC: Change Krunner's default key shortcut for Next

2014-05-20 Thread Jacopo De Simoi
Currently the secondary shortcut is set to Alt + Shift + F2. I don't think any of us will miss this. Actually this opens krunner with the content of the clipboard as the search term; quite handy sometimes. Is this change going to break this behavior? __J

Re: Review Request 112812: Use type description sort order in devicenotifier when non-removable devices are displayed

2013-09-28 Thread Jacopo De Simoi
On Sept. 28, 2013, 1:59 a.m., Jacopo De Simoi wrote: Let me have a look at the patch; I'll be able to do it tomorrow and commit it myself if it is ok. Thanks __J Device notifier mantainer Ok, even with the patch, within any given category (e.g. Storage Volume) devices

Mono icons in systray

2012-12-11 Thread Jacopo De Simoi
Dear all, I noticed how the new air theme (which is just beautiful, btw) makes the mono icons in systray quite low-constrast; this is especially apparent with compositing turned off. I started thinking about a sensible solution which would not require rebuilding all mono icons every

Re: Mono icons in systray

2012-12-11 Thread Jacopo De Simoi
On Tuesday 11 December 2012 12:13:11 you wrote: A Terça, 11 de Dezembro de 2012 10:06:36 você escreveu: Dear all, I noticed how the new air theme (which is just beautiful, btw) makes the mono icons in systray quite low-constrast; this is especially apparent with compositing

Re: Mono icons in systray

2012-12-11 Thread Jacopo De Simoi
On Tuesday 11 December 2012 21:37:13 Marco Martin wrote: On Tuesday 11 December 2012, Jacopo De Simoi wrote: recalling some recent post on icon fonts, I wonder if switching to an icon font for monochrome plasma icons would provide us with a solution; in my opinion there are quite a number

Re: Mono icons in systray

2012-12-11 Thread Jacopo De Simoi
This is indeed a considerable overhead; perhaps then one could implement shape-rendering:crispEdges rendering in QtSvg; actually if the svg routines are shared with webkit, it could be that they are already implemented… ok, this might be pure nonsense; I checked out the specs of what

Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

2012-11-30 Thread Jacopo De Simoi
or people will keep using the horrible PlasmaWidgets.IconWidget Jacopo De Simoi wrote: Hi Michael, indeed I can well see your point. Using a fraction of the size of the dialog icon might be so-so (in fact the ratio 22/32 is quite unique in our icons, it would basically be good

Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

2012-11-26 Thread Jacopo De Simoi
On Nov. 26, 2012, 9:35 a.m., Marco Martin wrote: This is really an issue that needs addressing, thanks for taking time for it. i'm very in favor of removing all those hardcoded sizes from the code. however i see two problems with that approach 1) icons are cleanly painted

Re: Review Request: make the DeviceNotifier Plasmoid scale with high-res screens

2012-11-24 Thread Jacopo De Simoi
it so hard to handle such things nicely. I hope to be able to test this during the weekend; the diff looks reasonable, though. Thanks __J --Device notifier mantainer - Jacopo De Simoi On Nov. 23, 2012, 10:11 p.m., Michael Zanetti wrote

Re: Review Request: Device notifier: show mounted device and path

2012-10-12 Thread Jacopo De Simoi
On Friday 12 October 2012 15:56:18 Sebastian Kügler wrote: On Friday, October 12, 2012 13:42:35 Lamarque Vieira Souza wrote: This tooltip looks really odd and out of place this way.:/ The transparency effect does not look good here. I would like to know how to disable it too, there is this

Re: Review Request: Device notifier: show mounted device and path

2012-10-07 Thread Jacopo De Simoi
be resolved in some other way (e.g. by making use of lsof in solid to identify blocking apps), so I am not super-sure that the user should be given such specific information as /dev/. - Jacopo De Simoi On Oct. 7, 2012, 2:55 p.m., Jonathan Marten wrote

Re: [RFC] Trigger KRunner on top screenedge

2012-10-05 Thread Jacopo De Simoi
On Wednesday 03 October 2012 13:44:06 Martin Gräßlin wrote: Hi all, just wanted some feedback on an idea I got today. What about binding the showing of KRunner on hitting the top screen edge? Given that KRunner slides in from the top edge it would end up in a neat functionality, throw the

Re: Review Request: Use Product instead of description for device names

2012-09-30 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106637/#review19654 --- Ship it! Ship It! - Jacopo De Simoi On Sept. 29, 2012, 8

Re: Review Request: better handling of Removable property for volumes in soliddevice engine

2012-07-07 Thread Jacopo De Simoi
to the dataengine. I would rather consider inclusion in the solid API; I vaguely recall having read (or written) some similar code somewhere else, so it would definitely make sense to put it in the libs. Best Regards - Jacopo De Simoi On July 5, 2012, 6:44 a.m., Andriy Gapon wrote

Re: Plasma Applet Testing for 4.9

2012-05-22 Thread Jacopo De Simoi
On Monday 21 May 2012 00:37:07 Viranch Mehta wrote: On Thu, May 17, 2012 at 3:58 AM, David Edmundson da...@davidedmundson.co.uk wrote: - a list of all the new QML-based applets (by the time of the first beta) (afaik, nowplaying, battery, locklogout, activitymanager.. but there

Review Request: Avoid multiple map - engine connections

2012-05-21 Thread Jacopo De Simoi
to have been like that from ages. Was there a reason for that? Diffs - plasma/generic/dataengines/soliddevice/devicesignalmapmanager.cpp 4549cd4 Diff: http://git.reviewboard.kde.org/r/105003/diff/ Testing --- basic testing: everything works as expected. Thanks, Jacopo De Simoi

Re: Review Request: Avoid multiple map - engine connections

2012-05-21 Thread Jacopo De Simoi
as expected. Thanks, Jacopo De Simoi ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Device notifier popup did not hide after the intended timeout of 7.5 s.

2011-10-18 Thread Jacopo De Simoi
right now. I'll have a more in-depth look. Please bear with me a bit more; spare time is very scarce in these days. - Jacopo De Simoi On Oct. 11, 2011, 10:18 a.m., Simon Persson wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request: Add option to not show popup when devices are added

2011-10-18 Thread Jacopo De Simoi
notifier from popping up altogheter; If a user doesn't want the notifier to popup for a specific device she can simply hide it by right-clicking on the device item. - Jacopo De Simoi On Oct. 11, 2011, 1:30 p.m., Simon Persson wrote

Review Request: Make the activities runner available for single runner use

2011-04-16 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101144/ --- Review request for Plasma and Aaron J. Seigo. Summary --- Enables

Re: Review Request: Expand last plugged device in Device Notifier applet

2011-03-22 Thread Jacopo De Simoi
What happens when a device with multiple partitions is plugged in? Afaics all of them are expanded, which I'm not sure it is really what I'd like to happen, because the second partition is likely to be hidden below the first one… ---

Re: about commit 83ea19670eff0febff516380fb59a65a1d7667a9: use Qt::Popup in tasks applet

2011-03-10 Thread Jacopo De Simoi
On Tuesday, March 8, 2011, Jacopo De Simoi wrote: This strategy is quite debatable, but apparently has been there forever (4.5) Can we workaround this fact? i don't know; to me it really sounds like something that needs to be fixed in Qt. here we go, merge request http

Take care of your WA_TranslucentBackground flag

2011-03-08 Thread Jacopo De Simoi
A few days ago I started investigating about some visual glitches happening with the sliding popup effect, which are caused by a bizarre initial pixmap initialization strategy. Basically what happens is that under some conditions (most notably when the Qt widget window has the

Re: [patch] enabling autorun in devicenotifier applet

2011-01-05 Thread Jacopo De Simoi
Hi, I've made this patch with some directions from aseigo. I wanted some kind of autorun settings for specific devices dependant on the media of optical drives; so i made a patch to recognize X-KDE-Autorun in .desktop file action entries. this patch was for 4.5.90 and it builds.

Re: [patch] enabling autorun in devicenotifier applet

2011-01-05 Thread Jacopo De Simoi
On Wednesday, January 5, 2011, Jacopo De Simoi wrote: Was there a specific reason for patching the notifier? yep: Maarten, who wanted, the feature appear on irc and i offered a few places he could do this, and he picked the easiest and shortest path. the itch he was scratching

KDE/kdebase/workspace/plasma/generic/applets/devicenotifier

2010-07-14 Thread Jacopo De Simoi
SVN commit 1149977 by jacopods: First attempt to get rid of the capacity bar in the device notifier: use a Plasma::Meter with tooltips. Screenshot: http://imagebin.ca/view/ccJ3dD.html Feedback is more than welcome CCMAIL:plasma-devel@kde.org M +17 -17deviceitem.cpp M +3 -2

Re: KDE/kdebase/workspace/plasma/generic/applets/devicenotifier

2010-07-14 Thread Jacopo De Simoi
On July 14, 2010, Jacopo De Simoi wrote: SVN commit 1149977 by jacopods: First attempt to get rid of the capacity bar in the device notifier: use a Plasma::Meter with tooltips. Screenshot: http://imagebin.ca/view/ccJ3dD.html the screenshot looks nice; but i'm curious: what were

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-26 Thread Jacopo De Simoi
Like one more font face and not aligned with anything either. the font should be the same as the top header, so there shouldn't be another font face. as for alignment, iirc they are right aligned. You recall correctly, but it has been changed since :) Right aligning with (un)mount

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-26 Thread Jacopo De Simoi
On May 22, 2010, Jacopo De Simoi wrote: I'm playing around with that now, and here's what I got so far... how do you like it? it puts a third size of icon in the dialog, and it isn't really aligned with anything visually. Yep, I was trying to make it look like an extender in fact

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-22 Thread Jacopo De Simoi
Well, as far as device notifier goes, there's a couple more things about it that I'd like to see fixed as well. Here I am, the device notifier mantainer, at your service :) This one about tooltips sounds nice, but then it kinda duplicates what's in the real device list, and there seems to

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-22 Thread Jacopo De Simoi
you mean, to make the icon smaller? Yes, it takes *way* too much space. And, what's the point? The user will learn very soon what this widget does, so then it's kinda unnecessary. There are a lot of other plasmoids out there. Some of them do have a header, some of them don't. I have a

Review Request: Routing (un)mounting error notifications via knotify; part II: dataengine

2010-05-05 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3896/ --- Review request for Plasma, Aaron Seigo, Marco Martin, and Olivier Goffart.

KDE/kdebase/workspace/plasma/generic/applets/devicenotifier

2010-04-11 Thread Jacopo De Simoi
SVN commit 1113686 by jacopods: Show error messages inside the applet instead of using Plasma::MessageBox As soon as a patch in solid is accepted, the notifier will be able to react to errors triggered by other applications, hence errors will be shown also when triggered from other applications

Re: Running queries via dbus

2010-03-23 Thread Jacopo De Simoi
CC'ing plasma-devel, since this is an important point regarding runners that use D-Bus. Please keep any discussion on this issue at plasma-devel. On Tuesday 23 March 2010 17:26:54 Alex Merry wrote: On Monday 22 March 2010 22:05:26 Jacopo De Simoi wrote: In particular, Meta::Track has

Re: Running queries via dbus

2010-03-23 Thread Jacopo De Simoi
On Tuesday 23 March 2010 21:55:08 Alex Merry wrote: Instead, you should use QDBusConnection::asyncCall. This can be used in exactly the same way (implicit casting FTW), and casting to a QDBusReply will cause the calling thread to block as you would expect. But, importantly, it WON'T

Re: Running queries via dbus

2010-03-23 Thread Jacopo De Simoi
I just got a quite crazy idea; it might work though. Since we are making the thread stall by waiting for the async reply we could as well check that while we get the pending reply the context is still valid and bail out discarding the reply otherwise. If this can be coded in a simple way I

Re: 4.5 polishment: krunner (under_the_hood)

2010-03-08 Thread Jacopo De Simoi
Am Montag 08 März 2010 01:28:23 schrieb Aaron J. Seigo: On March 7, 2010, Lukas Appelhans wrote: I can give a patch if needed of course... it's just a matter of porting it from the app-runner to main KRunner... I'd love to see the patch! Further, I've a question, since I don't really

Re: 4.5 polishment: krunner (under_the_hood)

2010-03-08 Thread Jacopo De Simoi
Am Montag 08 März 2010 22:43:33 schrieb Jacopo De Simoi: Am Montag 08 März 2010 01:28:23 schrieb Aaron J. Seigo: On March 7, 2010, Lukas Appelhans wrote: I can give a patch if needed of course... it's just a matter of porting it from the app-runner to main KRunner... I'd

Re: n+1st report about arrow keys in krunner

2010-03-08 Thread Jacopo De Simoi
On 8 March 2010 01:42, Aaron J. Seigo ase...@kde.org wrote: this reminds me about jokes about the difference between theory and practice. if we remove the history then we'll get to deal with tons of bug reports about how you can't do alt+f2, up arrow, enter which is a very, very

Re: KCM icons, krunner and consistency

2010-03-08 Thread Jacopo De Simoi
On Sunday 07 March 2010 15:55:05 Jacopo De Simoi wrote: Browsing .desktop files of KCMs you can notice that there is no common convention; some of them use xxx Configuration, some others Configure xxx, others xxx settings, others xxx. It would be nice to fix a rule and stick to it, what

Re: n+1st report about arrow keys in krunner

2010-03-07 Thread Jacopo De Simoi
to post my impressions here and hope for some smart feedback. Of course I can attach a patch if you're willing to try it out on your local copy. Am Samstag 27 Februar 2010 23:09:57 schrieb Jacopo De Simoi: If (and only if) pressing Down without any further entry in the history, then it could move

4.5 polishment: krunner (under_the_hood)

2010-03-07 Thread Jacopo De Simoi
Hi there, this is the first part of my ideas for polishing krunner for 4.5. This thread will focus mostly about under_the_hood (i.e. not UI) changes, sooo here are my ideas: * Better sorting: at the moment krunner remembers which items the user runs frequently and kicks them up in the results

KCM icons, krunner and consistency

2010-03-07 Thread Jacopo De Simoi
Dear devs, in view of our commitment to polish for 4.5, I'd like to raise a small issue regarding systemsettings and more specifically KCM icons and .desktop files At the moment icons for kcms can be shown in a few different settings, in systemsettings, in the configure menu of applets or

n+1st report about arrow keys in krunner

2010-02-27 Thread Jacopo De Simoi
Dear plasmoids I just closed as WONTFIX the (n+1)st report about people trying to use downarrow key to select entries other than the first one in krunner default interface. In view of our committment to polish for 4.5 I guess it's time to do something about this issue, which seems to hit

Re: n+1st report about arrow keys in krunner

2010-02-27 Thread Jacopo De Simoi
I have been annoyed many times by this, although I never reported a bug. I also found it confusing to have autocompletion, but I still have to type it through. you can use the End key to accept the completion; this is another active topic about krunner on bko, by the way.

Re: [Kde-hardware-devel] Status of encrypted devices in Plasma / Solid

2010-02-25 Thread Jacopo De Simoi
looking forward to check the validity of a bug regarding the device notifier and encrypted devices (containers) I noticed several issues with them in the current implementation of the dataengines The imporant thing to know about them is that they show up in solid as a StorageVolume such

services runner matching categories

2010-01-10 Thread Jacopo De Simoi
Dear plasma-devs After finally upgrading to 4.4 I noticed that the service runner started matching app categories; (the commit indeed happened ~6 months ago) which can be very handy for specific (i.e. single runner, plasma-netbook) queries, but might be imho a bit confusing in krunner

Re: Review Request: update the data when the predicate files change

2010-01-04 Thread Jacopo De Simoi
Ping Any news on this? This is meant to fix one of the last remaining bugs for the device notifier and it would be great to have it reviewed and merged soon Thanks On Monday 7 December 2009 18:38:59 Giulio Camuffo wrote: --- This

Re: Solid - places runners conflict

2009-12-22 Thread Jacopo De Simoi
On Tuesday 22 December 2009 22:41:01 Aaron J. Seigo wrote: On December 18, 2009, Jacopo De Simoi wrote: Dear plasmadevs, I just noticed that we have some feature conflict among the runners; in fact the places runner shows solid devices as well and triggers dolphin on them upon

Re: Solid - places runners conflict

2009-12-22 Thread Jacopo De Simoi
On Wednesday 23 December 2009 06:50:50 Aaron J. Seigo wrote: On December 22, 2009, Jacopo De Simoi wrote: I don't intend to disable the places runner itself, but just the matches referring to devices. that's probably ok; my only concern would be where the user changes the name

Solid - places runners conflict

2009-12-18 Thread Jacopo De Simoi
Dear plasmadevs, I just noticed that we have some feature conflict among the runners; in fact the places runner shows solid devices as well and triggers dolphin on them upon selection. Since this feature is included in solid runner, which is specialized to treat solid devices in a fairly

Status of encrypted devices in Plasma / Solid

2009-12-07 Thread Jacopo De Simoi
Dear plasma-devs, hardware-devs looking forward to check the validity of a bug regarding the device notifier and encrypted devices (containers) I noticed several issues with them in the current implementation of the dataengines The imporant thing to know about them is that they show up in

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-24 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/ --- (Updated 2009-11-24 12:59:38.449340) Review request for Plasma, Aaron Seigo and

Re: Solidrunner moved to kdereview

2009-11-23 Thread Jacopo De Simoi
Should I move it to trunk? If so, kdebase or kde-plasma-addons? Thanks --J On Friday 13 November 2009 19:33:57 Jacopo De Simoi wrote: I've just moved a the solidrunner to kdereview, for inclusion in 4.4 in kde-plasma-addons or kdebase; I'm actually not quite sure on that. The runner

Review Request: Add removeMatch(es) methods to runnerContext

2009-11-22 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2260/ --- Review request for Plasma and Aaron Seigo. Summary --- This patch adds

Re: Plasma desktop crashed (mp3 player connected during startup)

2009-11-22 Thread Jacopo De Simoi
On Saturday 21 November 2009 20:44:32 l...@tlen.pl wrote: Device notifier automount version 0.3 crashes either when mp3 player is connected during KDE startup or when I tried to remove mounted mp3 player devicenotifier_automount is an unofficial add-on and as such it is not supported by kde

Re: Review Request: Add removeMatch(es) methods to runnerContext

2009-11-22 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2260/ --- (Updated 2009-11-22 15:32:19.727345) Review request for Plasma and Aaron Seigo.

Review Request: Add action support to krunner default interface

2009-11-21 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2259/ --- Review request for Plasma and Aaron Seigo. Summary --- This patch adds

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-21 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/ --- (Updated 2009-11-21 18:49:12.791648) Review request for Plasma, Aaron Seigo and

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-17 Thread Jacopo De Simoi
the need to explain how it works in the apidox :) Jacopo De Simoi wrote: well, the correct name should indeed be addSyntaxAndSetAsDefault, but I guess it's a little bit too much :) Aaron Seigo wrote: i think setDefaultSyntax implies it will become part of the syntax bunch; perhaps

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-17 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/ --- (Updated 2009-11-17 17:52:14.417634) Review request for Plasma, Aaron Seigo and

Re: Solidrunner moved to kdereview

2009-11-17 Thread Jacopo De Simoi
now the solidrunner is in the more appropriate location kdereview/plasma/runners thanks for reviewing! On Friday 13 November 2009 19:33:57 Jacopo De Simoi wrote: I've just moved a the solidrunner to kdereview, for inclusion in 4.4 in kde-plasma-addons or kdebase; I'm actually not quite sure

Re: Review Request: Update ItemBackground widget

2009-11-17 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2194/#review3149 --- Ship it! I should have removed that HACK at least one month ago. ;)

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-16 Thread Jacopo De Simoi
::singleRunnerMode() then replaceEmptyQuery should be implied? Jacopo De Simoi wrote: In fact it should. I was worried of changing the default behaviour of this method. I was not sure to be able to check that this wouldn't affect any other app using runnermanager (kickoff?) Aaron Seigo

Re: Review Request: Add support for single Runner queries to krunner (part II: krunner)

2009-11-16 Thread Jacopo De Simoi
really evident what's going on? Jacopo De Simoi wrote: Clickmessage would be cool, however, since the lineedit immediately gets focus, it is never shown so it is useless. A label could be a solution indeed; The issue is: what should the label read? just the name of the runner

Re: Review Request: Add support for single Runner queries to krunner (part II: krunner)

2009-11-16 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2091/ --- (Updated 2009-11-16 23:50:00.387923) Review request for Plasma, Aaron Seigo and

Solidrunner moved to kdereview

2009-11-13 Thread Jacopo De Simoi
I've just moved a the solidrunner to kdereview, for inclusion in 4.4 in kde-plasma-addons or kdebase; I'm actually not quite sure on that. The runner is conceived as an alternative to the device notifier, combining the same capabilities (although the actions support is still lacking for the

Re: Solidrunner moved to kdereview

2009-11-13 Thread Jacopo De Simoi
On Friday 13 November 2009 20:06:48 Burkhard Lück wrote: Am Freitag, 13. novembre 2009 19:33:57 schrieb Jacopo De Simoi: Please let me know of any issues that you find There are some i18n calls, but the runner has no translation catalog, message extraction via Messages.sh is missing

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-12 Thread Jacopo De Simoi
--- On 2009-11-07 20:16:02, Jacopo De Simoi wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090

Re: Review Request: Add support for single Runner queries to krunner (part II: krunner)

2009-11-12 Thread Jacopo De Simoi
--- On 2009-11-07 20:29:26, Jacopo De Simoi wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2091

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-12 Thread Jacopo De Simoi
::singleRunnerMode() then replaceEmptyQuery should be implied? Jacopo De Simoi wrote: In fact it should. I was worried of changing the default behaviour of this method. I was not sure to be able to check that this wouldn't affect any other app using runnermanager (kickoff?) Aaron Seigo

Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-07 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/ --- Review request for Plasma, Aaron Seigo and Ryan Bitanga. Summary --- This

Review Request: Add support for single Runner queries to krunner (part II: krunner)

2009-11-07 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2091/ --- Review request for Plasma, Aaron Seigo and Ryan Bitanga. Summary --- This

Review Request: Adds windows runner single runner query support

2009-11-07 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2092/ --- Review request for Plasma, Aaron Seigo and Martin Gräßlin. Summary ---

Re: Review Request: Embed related kcms in the device notifier configuration dialog

2009-10-31 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1979/ --- (Updated 2009-10-31 10:40:50.365695) Review request for Plasma, Aaron Seigo,

Re: Review Request: Add to the devicenotifier configuration buttons to open related kcms

2009-10-27 Thread Jacopo De Simoi
On Tuesday 27 October 2009 17:16:58 Aaron Seigo wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1979/#review2832 ---

Re: Review Request: Unified ItemBackground in new Device Notifier

2009-10-06 Thread Jacopo De Simoi
request for Plasma, Jacopo De Simoi and Giulio Camuffo. Summary --- proof of concept showing how the item background could be unified into NotifierDialog; requires today's libplasma for fixes to the ItemBackground widget Diffs - /trunk/kdereview/plasma/applets

Re: New devicenotifier moved to kdereview

2009-10-06 Thread Jacopo De Simoi
On Tuesday 06 October 2009 21:58:08 Aaron J. Seigo wrote: i think anyway a better approach would be to add an action file for them, and add a property in the DeviceItem to set if they are (un)mountable it would prevent any special-case code in the notifier widget, yes. If we have no

Re: New devicenotifier moved to kdereview

2009-10-06 Thread Jacopo De Simoi
On Tuesday 06 October 2009 22:17:02 Aaron J. Seigo wrote: so much for simplicity :/ I'm confused; I can read in test-predicate-openinwindow.desktop: X-KDE-Solid-Predicate=[ [ StorageVolume.ignored == false AND [ StorageVolume.usage == 'FileSystem' OR StorageVolume.usage == 'Encrypted' ] ] OR

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Jacopo De Simoi
On Sunday 04 October 2009 20:57:11 Aaron J. Seigo wrote: On October 4, 2009, Jacopo De Simoi wrote: now, we believe that it is ready for merging into trunk. Of course we need your feedback first, so grab it, try it out and tell us what you think! with options out of the way :) some

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Jacopo De Simoi
* when an item is expanded, should the background remain painted? it might make it more evident that the item is open, and it would also allow a way to solve the next point, too. (and if the background remains, perhaps the capacity bar should too?) Now that I think some more about it...

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Jacopo De Simoi
On Sunday 04 October 2009 22:31:49 Aaron J. Seigo wrote: * when an item is expanded, should the background remain painted? it might make it more evident that the item is open, and it would also allow a way to solve the next point, too. (and if the background remains, perhaps the

Review Request: Delay updating shape until next event cycle

2009-10-02 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1756/ --- Review request for Plasma, Aaron Seigo and Marco Martin. Summary --- Delay

Re: Review Request: Delay for updating shape of itemBackground

2009-10-02 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1756/ --- (Updated 2009-10-02 08:36:48.375398) Review request for Plasma, Aaron Seigo and

Review Request: Add to itemBackground signals to track animation progress

2009-10-02 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1757/ --- Review request for Plasma, Aaron Seigo and Marco Martin. Summary ---

Re: Review Request: Add to itemBackground signals to track animation progress

2009-10-02 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1757/ --- (Updated 2009-10-02 09:10:16.950247) Review request for Plasma, Aaron Seigo and

Re: Review Request: Add to itemBackground signals to track animation progress

2009-10-02 Thread Jacopo De Simoi
--- On 2009-10-02 09:10:16, Jacopo De Simoi wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1757

Re: Initial size and aspect ratio

2009-10-02 Thread Jacopo De Simoi
setAspectRatioMode(Plasma::IgnoreAspectRatio) Yes I just found it in the qalculate source :-) I was looking for a PopupApplet example. Speaking of which, it would be nice if a popupApplet had a way to /remember/ its preferred AspectRatioMode; in fact last time I checked, once the

Re: devicenotifier with qgw

2009-09-23 Thread Jacopo De Simoi
On Sunday 20 September 2009 18:09:20 Aaron J. Seigo wrote: On September 20, 2009, Aaron J. Seigo wrote: On September 19, 2009, Jacopo De Simoi wrote: 1) we need to activate the items on hover, but with the itemBackground animation delay, hoverEvent is not good anymore to track that. I

Re: devicenotifier with qgw

2009-09-23 Thread Jacopo De Simoi
On Sunday 20 September 2009 17:30:36 Aaron J. Seigo wrote: On September 19, 2009, Jacopo De Simoi wrote: 1) we need to activate the items on hover, but with the itemBackground animation delay, hoverEvent is not good anymore to track that. I can see two solutons: - itemBackground should

devicenotifier with qgw

2009-09-19 Thread Jacopo De Simoi
Dear Plasma-devs Giulio and I are currently porting the device notifier to use qgw, the delegate stuff was really too rigid to implement decent animations and a few features (e.g. busy widget on top of the item being (un)mounted). Of course we'd like to use the shiny new itemBackground; I'd

Re: devicenotifier with qgw

2009-09-19 Thread Jacopo De Simoi
On Saturday 19 September 2009 14:50:50 Marco Martin wrote: On Saturday 19 September 2009, Jacopo De Simoi wrote: Dear Plasma-devs Giulio and I are currently porting the device notifier to use qgw, the delegate stuff was really too rigid to implement decent animations and a few features

Re: Review Request: big revamp of Device Notifier

2009-09-10 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2266 --- Much better as for code and configuration, there are just a few

Re: Review Request: big revamp of Device Notifier

2009-08-30 Thread Jacopo De Simoi
On Sunday 30 August 2009 08:43:52 David Baron wrote: ...last but not least, the bug I reported about this thing sitting on hald/dbus. This too me is a showstopper. The original device notifier certainly does not do this. Uhm, afaiu the dependency has been removed as requested by Kevin...

Re: Review Request: big revamp of Device Notifier

2009-08-30 Thread Jacopo De Simoi
On 2009-08-24 12:43:32, Aaron Seigo wrote: i'm not going to look at the code just yet. instead i'd like to focus on what's exposed in the configuration dialog first. then we can get to code :) automounting: that's already been discussed on the mailing list so we can skip that one

  1   2   >