[Differential] [Commented On] D3950: Try to fix "Pinned Chrome disappears when all Chrome windows are closed"

subdiff added a comment. Just tested it. Last revision fixes the problem indeed. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3950 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, mart,

[Differential] [Commented On] D3302: [Task Manager] Indicate applications playing audio

subdiff added a comment. Last try: It's the speaker symbol without the speaker. Should be easy to make by just cutting away the speaker. Plus vertically centered to the app icon. F1952405: Screenshot_20170105_111200.png REPOSITORY R119 Plasma

[Differential] [Closed] D3738: [Task Manager] Tooltips redesign

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4f9198fc5f21: [Task Manager] Tooltips redesign (authored by subdiff). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3738?vs=9787=9795 REVISION DETAIL

[Differential] [Updated, 1,123 lines] D3738: [Task Manager] Tooltips redesign

subdiff updated this revision to Diff 9787. subdiff added a comment. Fallback to previously used method: One ToolTipDelegate, which gets repositioned to the the task currently containing the mouse. To do this cleanly, the ToolTipDelegate needed to be split up. On the plus side the ugly

[Differential] [Commented On] D3738: [Task Manager] Tooltips redesign

subdiff added a comment. In https://phabricator.kde.org/D3738#74290, @hein wrote: > I just tried running the patch, and instead of smooth morphs when going between tooltip contents I get an instant change with a 1-frame glitchy stretch ... it's pretty bad. Sorry, I can't

[Differential] [Commented On] D3738: [Task Manager] Tooltips redesign

subdiff added inline comments. INLINE COMMENTS > hein wrote in ContextMenu.qml:59 > That's kinda what I was wondering. If the context menu is opened for an > element in the tooltip, why is the visualParent the task item? It's basically the second best solution. ;) When I tried to set the

[Differential] [Updated, 1,078 lines] D3738: [Task Manager] Tooltips redesign

subdiff updated this revision to Diff 9695. subdiff marked 12 inline comments as done. subdiff added a comment. - Better description of the workaround - Use `active` property instead of reloading component for workaround - `hideToolTipTemporarily()` to not rely on the workaround when

[Differential] [Updated] D3738: [Task Manager] Tooltips redesign

subdiff added inline comments. INLINE COMMENTS > hein wrote in ContextMenu.qml:59 > Maybe s/get/data to be more conventional, but could you argue for kicks why > this churn is needed vs. just making sure the visualParent has the m prop? The context menu can be called now also for a grouped

[Differential] [Updated, 1,056 lines] D3738: [Task Manager] Tooltips redesign

subdiff updated this revision to Diff 9670. subdiff marked 6 inline comments as done. subdiff added a comment. - Rebased on current master - Review changes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3738?vs=9170=9670 REVISION DETAIL

[Differential] [Closed] D3630: [Digital Clock] Bug fixes and ui code optimization

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1d362c4ae2e2: [Digital Clock] Bug fixes and ui code optimization (authored by subdiff). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3630?vs=9657=9659

[Differential] [Updated, 354 lines] D3630: [Digital Clock] Bug fixes and ui code optimization

subdiff updated this revision to Diff 9657. subdiff marked an inline comment as done. subdiff added a comment. - Fixed pixelSize of sizehelper. - Only changes now to small horizontal mode if date or timezone visible (no sudden size change when resizing with clock only visible). REPOSITORY

[Differential] [Updated] D3923: Make AppstreamQt optional

subdiff added a reviewer: apol. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3923 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, apol Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,

[Differential] [Accepted] D3885: Minor fix for plasma folder view filename editor

subdiff accepted this revision. subdiff added a reviewer: subdiff. subdiff added a comment. This revision is now accepted and ready to land. Just a nitpick: Since you have `realHeight` as the first argument, maybe also define it as first. REPOSITORY R119 Plasma Desktop REVISION DETAIL

[Differential] [Commented On] D3885: Minor fix for plasma folder view filename editor

subdiff added a comment. Good find but why does it need to compare `_height` with `contentHeight` in the beginning at all? Normally what should imo happen is simply: - Compare `realHeight` with max possible height `maxHeight` - If larger, set `_height = realHeight`, else `_height =

[Differential] [Commented On] D3870: [Converter Runner] Also convert to the user's local currency

subdiff added a comment. In https://phabricator.kde.org/D3870#72396, @davidedmundson wrote: > (Slightly offtopic: > when Martin G, eike or I make a diff, there's always an option to expand the context in phab to view lines above, when Kai or Subdiff make one, it says "Context not

[Differential] [Updated, 2,358 lines] D3617: [Touchpad KCM] New KWin Wayland version

subdiff updated this revision to Diff 9495. subdiff marked 8 inline comments as done. Restricted Application edited projects, added Plasma on Wayland, KWin; removed Plasma. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3617?vs=9407=9495 REVISION

[Differential] [Commented On] D3617: [Touchpad KCM] New KWin Wayland version

subdiff added inline comments. INLINE COMMENTS > sebas wrote in kwinwaylandtouchpad.h:36 > I wonder if it wouldn't be neater if the features would be an enum, and you'd > have methods to check for supported and enabled features. Have you thought of > this? Haven't thought about it. The

[Differential] [Updated, 2,367 lines] D3617: [Touchpad KCM] New KWin Wayland version

subdiff updated this revision to Diff 9407. subdiff marked 12 inline comments as done. Restricted Application edited projects, added Plasma; removed KWin, Plasma on Wayland. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3617?vs=9389=9407 REVISION

[Differential] [Closed] D3033: Cancel the Switch-user-overlay by clicking on empty space

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3e9d1a48a1ca: [Look and Feel] Dismiss User Switcher on empty space click (authored by subdiff). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3033?vs=7339=9392#toc REPOSITORY R120 Plasma

[Differential] [Updated, 2,384 lines] D3617: [Touchpad KCM] New KWin Wayland version

subdiff updated this revision to Diff 9389. subdiff marked 4 inline comments as done. subdiff added a comment. Restricted Application edited projects, added Plasma on Wayland, KWin; removed Plasma. Replace foreach loops. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D3617: [Touchpad KCM] New KWin Wayland version

subdiff added inline comments. INLINE COMMENTS > knambiar wrote in kwinwaylandbackend.cpp:72 > Just wondering whether these calls are synchronous and may cause delay in > startup. > Just wondering whether these calls are synchronous and may cause delay in > startup. I assume so. Should be no

[Differential] [Updated, 2,384 lines] D3617: [Touchpad KCM] New KWin Wayland version

subdiff updated this revision to Diff 9359. subdiff marked 12 inline comments as done. Restricted Application edited projects, added Plasma; removed KWin, Plasma on Wayland. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3617?vs=8848=9359 REVISION

[Differential] [Updated] D3630: [Digital Clock] Bug fixes and ui code optimization

subdiff updated the summary for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3630 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Updated, 353 lines] D3630: [Digital Clock] Bug fixes and ui code optimization

subdiff updated this revision to Diff 9354. subdiff marked 2 inline comments as done. subdiff added a comment. Reduced code complexity (in particular only one date label for all states now) and optimized layouting in general. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D3302: [Task Manager] Indicate applications playing audio

subdiff added a comment. Could be something like this made possible in icon only mode? F971459: taskbar-sound-indicator.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3302 EMAIL PREFERENCES

[Differential] [Commented On] D3738: [Task Manager] Tooltips redesign

subdiff added a comment. In https://phabricator.kde.org/D3738#70083, @colomar wrote: > Great improvements! > Is the desktop / Activity only shown if > > - there are multiple ones and > - the task manager shows tasks from different ones? Glad you like it! And yes, yes. :)

[Differential] [Updated] D3738: [Task Manager] Tooltips redesign

subdiff added a reviewer: VDG. subdiff added a project: VDG. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3738 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma, #vdg Cc: plasma-devel, lesliezhai,

[Differential] [Request, 1,069 lines] D3738: [Task Manager] Tooltips redesign

subdiff created this revision. subdiff added a reviewer: Plasma. subdiff added a subscriber: plasma-devel. subdiff set the repository for this revision to R119 Plasma Desktop. subdiff added a project: Plasma. REVISION SUMMARY This patch reworks the design of the task manager tooltips as

[Differential] [Closed] D3667: [MPRIS Dataengine] Let clients distinguish media players by process id more easily

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d78b63b9ea77: [MPRIS Dataengine] Export process id of player instance as separate data entry (authored by subdiff). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Updated, 9 lines] D3667: [MPRIS Dataengine] Let clients distinguish media players by process id more easily

subdiff updated this revision to Diff 9025. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3667?vs=9024=9025 REVISION DETAIL https://phabricator.kde.org/D3667 AFFECTED FILES dataengines/mpris2/playercontainer.cpp EMAIL PREFERENCES

[Differential] [Updated, 6 lines] D3667: [MPRIS Dataengine] Let clients distinguish media players by process id more easily

subdiff updated this revision to Diff 9024. subdiff added a comment. Using David's superior method. With this method it's also possible to have in the VLC case, where they don't append the pid, atleast the one controllable media player instance identified. REPOSITORY R120 Plasma Workspace

[Differential] [Request, 20 lines] D3667: [MPRIS Dataengine] Let clients distinguish media players by process id more easily

subdiff created this revision. subdiff added a reviewer: Plasma. subdiff added a subscriber: plasma-devel. subdiff set the repository for this revision to R120 Plasma Workspace. subdiff added a project: Plasma. REVISION SUMMARY The MPRIS specification recommends to media players to distinguish

[Differential] [Accepted] D3641: Register AbstractTasksModel as uncreatable type.

subdiff accepted this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3641 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, davidedmundson, #plasma, subdiff Cc: plasma-devel, lesliezhai,

[Differential] [Commented On] D3630: [Digital Clock] Bug fixes and ui code optimization

subdiff added inline comments. INLINE COMMENTS > DigitalClock.qml:211 > > -height: Math.max(sizehelper.lineCount > 1 ? 2 * > Math.round(timeLabel.height / 6) : 2 * Math.round(timeLabel.height / 3), > theme.smallestFont.pixelSize) > +height:

[Differential] [Request, 160 lines] D3630: [Digital Clock] Bug fixes and ui code optimization

subdiff created this revision. subdiff added a reviewer: Plasma. subdiff added a subscriber: plasma-devel. subdiff set the repository for this revision to R120 Plasma Workspace. subdiff added a project: Plasma. REVISION SUMMARY This patch is meant to improve the Digital Clock applet in the

[Differential] [Commented On] D3616: [Lock Screen / Login] Add "reveal password button"

subdiff added a comment. On one hand: Yea, why not. On the other imagine the following situation: Two people sit in front of the PC, and one of them wants to login to the PC. After entering his password, he accidently hits the "show password" icon (since it's pretty near to the

[Differential] [Updated] D3617: [Touchpad KCM] New KWin Wayland version

subdiff updated the summary for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3617 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #kwin, #plasma_on_wayland, #plasma, #vdg Cc: kwin, plasma-devel,

[Differential] [Updated] D3617: [Touchpad KCM] New KWin Wayland version

subdiff added a reviewer: VDG. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3617 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #kwin, #plasma_on_wayland, #plasma, #vdg Cc: kwin, plasma-devel, lesliezhai,

[Differential] [Request, 2,415 lines] D3617: [Touchpad KCM] New KWin Wayland version

subdiff created this revision. subdiff added reviewers: KWin, Plasma on Wayland, Plasma. subdiff added a subscriber: plasma-devel. subdiff set the repository for this revision to R119 Plasma Desktop. subdiff added a project: Plasma. Restricted Application edited projects, added Plasma on Wayland,

[Differential] [Closed] D3590: [libinput] Sane unset behaviour of scroll method and acceleration profile properties

This revision was automatically updated to reflect the committed changes. Closed by commit R108:fd07b1dc981c: [libinput] Change unset of scroll method and acceleration profile (authored by subdiff). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3590?vs=8758=8805#toc REPOSITORY R108

[Differential] [Request, 87 lines] D3590: [libinput] Sane unset behaviour of scroll method and acceleration profile properties

subdiff created this revision. subdiff added a reviewer: KWin. subdiff added a subscriber: plasma-devel. subdiff set the repository for this revision to R108 KWin. subdiff added a project: KWin. Restricted Application added a subscriber: kwin. REVISION SUMMARY Unsetting a scroll method should

[Differential] [Closed] D3479: [libinput] Add more support for touchpads in preparation for the new touchpad KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R108:7f16d83e046b: [libinput] Add more support for pointer devices, in particular touchpads (authored by subdiff). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

[Differential] [Updated] D3479: [libinput] Add more support for touchpads in preparation for the new touchpad KCM

subdiff edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D3479 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #kwin, davidedmundson, #plasma Cc: graesslin, davidedmundson,

[Differential] [Updated] D3479: [libinput] Add more support for touchpads in preparation for the new touchpad KCM

subdiff edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D3479 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #kwin, davidedmundson, #plasma Cc: graesslin, davidedmundson,

[Differential] [Updated, 789 lines] D3479: [libinput] Add more support for touchpads in preparation for the new touchpad KCM

subdiff updated this revision to Diff 8696. subdiff added a comment. Restricted Application edited projects, added KWin; removed Plasma. - Changed D-Bus path to `/org/kde/KWin/InputDevice` - D-Bus signals for adding/removing devices @davidedmundson: I changed my mind regarding the

[Differential] [Commented On] D3479: [libinput] Add more support for touchpads in preparation for the new touchpad KCM

subdiff added a comment. In https://phabricator.kde.org/D3479#66129, @graesslin wrote: > @davidedmundson do you have any further comments on the DBus usage? if not, I would give it an "Accepted". At the moment @davidedmundson helps me with the dbus signals. I tried to implement

[Differential] [Updated] D3479: [libinput] Add more support for touchpads in preparation for the new touchpad KCM

subdiff updated the summary for this revision. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3479 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #kwin, #plasma Cc: graesslin, davidedmundson, plasma-devel, kwin, #kwin,

[Differential] [Request, 781 lines] D3479: [libinput] Add more support for touchpads in preparation for the new touchpad KCM

subdiff created this revision. subdiff added reviewers: KWin, Plasma. subdiff added subscribers: KWin, plasma-devel. subdiff set the repository for this revision to rKWIN KWin. subdiff added a project: KWin. Restricted Application edited projects, added Plasma; removed KWin. Restricted Application

[Differential] [Closed] D3324: [Touchpad KCM] Prevent save dialog if no touchpad was found

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP77463a0143d8: [Touchpad KCM] Prevent save dialog if no touchpad was found (authored by subdiff). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Updated, 5 lines] D3324: [Touchpad KCM] Prevent save dialog if no touchpad was found

subdiff updated this revision to Diff 8064. subdiff marked an inline comment as done. subdiff added a comment. Adjusted name. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3324?vs=8058=8064 REVISION DETAIL

[Differential] [Request, 5 lines] D3324: [Touchpad KCM] Prevent save dialog if no touchpad was found

subdiff created this revision. subdiff added a reviewer: Plasma. subdiff set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If there is no touchpad

[Differential] [Accepted] D3231: [Lock Screen] Show "Switch User" button only if allowed

subdiff accepted this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3231 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart, subdiff Cc: davidedmundson, plasma-devel, lesliezhai,

[Differential] [Abandoned] D3078: Add new DBus method for applet de-/activation and in order to fix non-closing launchers on Meta (and also on Active Screenedges)

subdiff abandoned this revision. subdiff added a comment. Abandoned because we now use the other solution in https://git.reviewboard.kde.org/r/129204/ making this diff not necessary anymore. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3078

[Differential] [Closed] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP05c3125cd831: Launchers set new bool in plasma-frameworks to toggle expanded (authored by subdiff). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3055: Small polishing changes to the lockscreen lookandfeel package

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEd0fc18e1831d: Lockscreen: Keyboard focus and commands, more animations (authored by subdiff). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Updated, 6 lines] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

subdiff updated this revision to Diff 7515. subdiff added a comment. Implemented David's condition if variable exists. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3079?vs=7474=7515 REVISION DETAIL https://phabricator.kde.org/D3079

[Differential] [Updated, 6 lines] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

subdiff updated this revision to Diff 7474. subdiff added a comment. Adjustements to second revision of the Diff in Plasma-Frameworks on Reviewboard: https://git.reviewboard.kde.org/r/129204/ REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Updated, 25 lines] D3078: Add new DBus method for applet de-/activation and in order to fix non-closing launchers on Meta (and also on Active Screenedges)

subdiff updated this revision to Diff 7472. subdiff added a comment. Adjustements to second revision of the Diff in Plasma-Frameworks on Reviewboard: https://git.reviewboard.kde.org/r/129204/ But it reverts all changes here, since no changes are necessary anymore in Plasma-Workspace. In

[Differential] [Commented On] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

subdiff added a comment. In https://phabricator.kde.org/D3079#57067, @davidedmundson wrote: > This breaks the normal keyboard shortcut working at all. > > You either need to connect to both or > > if we put in the addition emit I suggest in

[Differential] [Updated] D3078: Add new DBus method for applet de-/activation and in order to fix non-closing launchers on Meta (and also on Active Screenedges)

subdiff added a reviewer: graesslin. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3078 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, graesslin Cc: plasma-devel, #plasma, lesliezhai, ali-mohamed,

[Differential] [Request, 2 lines] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

subdiff created this revision. subdiff added reviewers: graesslin, broulik. subdiff added a subscriber: Plasma. subdiff set the repository for this revision to rPLASMADESKTOP Plasma Desktop. subdiff added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY

[Differential] [Request, 25 lines] D3078: Add new DBus method for applet de-/activation and in order to fix non-closing launchers on Meta (and also on Active Screenedges)

subdiff created this revision. subdiff added a subscriber: Plasma. subdiff set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. subdiff added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Add new DBus method for toggling the

[Differential] [Accepted] D3050: Use new PlasmaWindowInterface::setIcon

subdiff accepted this revision. subdiff added a reviewer: subdiff. subdiff added a comment. This revision is now accepted and ready to land. Tested with Inkscape, Chrome, Gimp. Works fine, for Gimp (tested only in single-window mode) it needed some time to show the app/icon in the taskbar,

[Differential] [Accepted] D3049: Support passing generic QIcon through PlasmaWindow interface

subdiff accepted this revision. subdiff added a reviewer: subdiff. subdiff added a comment. Told you, I had problems compiling at first. Works now for unknown reason and icons are displayed together with https://phabricator.kde.org/D3050. INLINE COMMENTS > graesslin wrote in

[Differential] [Changed Subscribers] D3035: Add request to have focus in a PlasmaShellSurface of Role Panel

subdiff added inline comments. INLINE COMMENTS > plasma-shell.xml:373 > + > + > + Use another name instead of "skip" (copy paste from set_skip_taskbar) ? > plasmashell_interface.cpp:90 > static void panelAutoHideShowCallback(wl_client *client, wl_resource > *resource); >

[Differential] [Commented On] D3055: Small polishing changes to the lockscreen lookandfeel package

subdiff added a comment. In https://phabricator.kde.org/D3055#56705, @eliasp wrote: > What about hiding the password input field (or at least providing the required property) as long as the password grace period hasn't expired? > > So as long as no password is required to hide the

[Differential] [Commented On] D3062: Hide "automatic login" button in UserAccounts since is does absolutely nothing

subdiff added a comment. I would just delete it, because as you say having the same settings in two places is messy. But if there is a nice way of informing the user about the different place of the setting, we should do that. REPOSITORY rUSERMANAGER User Manager REVISION DETAIL

[Differential] [Changed Subscribers] D3062: Hide "automatic login" button in UserAccounts since is does absolutely nothing

subdiff added inline comments. INLINE COMMENTS > accountinfo.cpp:66 > +m_info->automaticLogin->setVisible(false); > +m_info->automaticLoginLabel->setVisible(false); > + Maybe only hide the checkbox and add a small description for users, that they can find the option in the sddm kcm for

[Differential] [Commented On] D3055: Small polishing changes to the lockscreen lookandfeel package

subdiff added inline comments. INLINE COMMENTS > davidedmundson wrote in LockScreenUi.qml:134 > you don't need to do this. (and if you do need to do this, something else is > wrong) > > They're within separate focus scopes, both "focusitems" should always have > focus, then you switch

[Differential] [Commented On] D2957: [SDDM Theme] Offer switching to the user's session if there is one

subdiff added a comment. Is this Differential abandoned? I think the proposed behavioural change is greatly needed! I'm doing some small work on the lock screen at the moment and while testing I created sometimes accidentally a second user session in sddm, which always (!) locked up my

[Differential] [Updated] D3055: Small polishing changes to the lockscreen lookandfeel package

subdiff set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3055 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, davidedmundson

[Differential] [Updated, 233 lines] D3055: Small polishing changes to the lockscreen lookandfeel package

subdiff removed rPLASMAWORKSPACE Plasma Workspace as the repository for this revision. subdiff updated this revision to Diff 7399. subdiff marked an inline comment as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3055?vs=7391=7399 REVISION DETAIL

[Differential] [Request, 228 lines] D3055: Small polishing changes to the lockscreen lookandfeel package

subdiff created this revision. subdiff added a reviewer: davidedmundson. subdiff set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. subdiff added projects: Plasma, VDG. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Several small improvements

[Differential] [Closed] D3034: Lockscreen: New session only on switchSessionPage

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEe7a07a154006: Lockscreen: New session only on switchSessionPage (authored by subdiff). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D3034: Lockscreen: New session only on switchSessionPage

subdiff added a comment. > but if we have a design I don't want to just ignore it. Absolutely! I just didn't know about this mockup. Thanks for the link. I was looking at the task right here before: https://phabricator.kde.org/T3364 REPOSITORY rPLASMAWORKSPACE Plasma Workspace

[Differential] [Updated] D3034: Lockscreen: New session only on switchSessionPage

subdiff updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3034 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, davidedmundson Cc: colomar, andreask, plasma-devel,

[Differential] [Updated] D3034: Lockscreen: New session only on switchSessionPage

subdiff updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3034 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, davidedmundson Cc: colomar, andreask, plasma-devel,

[Differential] [Updated, 27 lines] D3034: Lockscreen: New session only on switchSessionPage

subdiff added a subscriber: colomar. subdiff updated this revision to Diff 7349. subdiff added a comment. - Cleanup of newSession signal - Text on button on switch user page now changes accordingly to action Regarding the VDG: There wasn't a decision until now. But from my point of

[Differential] [Request, 8 lines] D3034: Lockscreen: New session only on switchSessionPage

subdiff created this revision. subdiff added a reviewer: davidedmundson. subdiff added a subscriber: andreask. subdiff set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. subdiff added a project: VDG. Restricted Application added a project: Plasma. Restricted Application

[Differential] [Request, 5 lines] D3033: Cancel the Switch-user-overlay by clicking on empty space

subdiff created this revision. subdiff added a reviewer: davidedmundson. subdiff set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Small patch