D11233: Ordered system tray

2018-09-03 Thread Kristopher Ives
kives added a comment. I think this is a useful feature to add to KDE. If others disagree with the way @wsdfhjxc implemented it I think they should provide a clear pathway to getting it accepted. As long as this can be implemented in a way that doesn't affect default sorting behavior, it

D11233: Ordered system tray

2018-03-13 Thread Radek Hušek
Pitel added a comment. I really like the idea of being able to reorder the systray as I wish. I could not resist and took my stab on the issue (with drag) D11292 . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11233

D11233: Ordered system tray

2018-03-13 Thread Marco Martin
mart added a comment. In D11233#223694 , @ngraham wrote: > In D11233#223661 , @broulik wrote: > > > Drag and drop might be an acceptable way to rearrange them but then I think we should just have a

D11233: Ordered system tray

2018-03-13 Thread Marco Martin
mart added a comment. I'm really against manual reordering and saving.. as the only thing i would like for the systray is to make it simpler, not more complicated :p that said yes, icons need to be in a more predictable, or at least consistent position I think it would be fairly

D11233: Ordered system tray

2018-03-12 Thread Wojciech Stachurski
wsdfhjxc updated this revision to Diff 29307. wsdfhjxc added a comment. - Wait for the item id before inserting it into tray - Sort the tray items by categories and ids REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11233?vs=29275=29307 BRANCH

D11233: Ordered system tray

2018-03-11 Thread Nathaniel Graham
ngraham added a comment. In D11233#223661 , @broulik wrote: > Drag and drop might be an acceptable way to rearrange them but then I think we should just have a smarter more predictable sorting logic (currently it's on a first come first serve

D11233: Ordered system tray

2018-03-11 Thread Kai Uwe Broulik
broulik added a comment. Before the rewrite in Plasma 5.7 System Tray icons were automatically sorted based on their type (e.g. Hardware stuff, applications, Status indicators) so the positions were somewhat consistent. I don't really like the idea of adding a huge save and restoration

D11233: Ordered system tray

2018-03-11 Thread Nathaniel Graham
ngraham added a comment. Conceptually, +1 from me. No comment about the code. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11233 To: wsdfhjxc, #plasma_workspaces, #plasma, #vdg Cc: ngraham, anthonyfieroni, Pitel, alexeymin, plasma-devel, ZrenBot,

D11233: Ordered system tray

2018-03-11 Thread Wojciech Stachurski
wsdfhjxc updated this revision to Diff 29275. wsdfhjxc added a comment. - Squashed commit of the following: - Use theme based icons instead of char glyph labels for buttons - Use QRegularExpression instead of QRegExp REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D11233: Ordered system tray

2018-03-11 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > ConfigEntries.qml:464 > + (shownAutoItems[0].taskId != modelData.taskId)) > +text: "▲" > +width: 30 icon: "arrow-up" > ConfigEntries.qml:478 > +

D11233: Ordered system tray

2018-03-11 Thread Wojciech Stachurski
wsdfhjxc created this revision. wsdfhjxc added a reviewer: Plasma: Workspaces. wsdfhjxc added a project: Plasma: Workspaces. Restricted Application edited projects, added Plasma; removed Plasma: Workspaces. Restricted Application added a subscriber: plasma-devel. wsdfhjxc requested review of this