D12318: Use consistent color button components for color config UI elements

kossebau updated this revision to Diff 32505. kossebau added a comment. also update potd wallpaper with KQuickControls.ColorButton REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12318?vs=32502=32505 BRANCH useconsistentcolorbutton REVISION DETAIL

D12318: Use consistent color button components for color config UI elements

kossebau added a comment. In D12318#249050 , @davidedmundson wrote: > There's ColorButton (https://api.kde.org/frameworks/kdeclarative/html/classColorButton.html) inside kquickcontrols > > Can't we use that? Ah, I had only grepped

D12318: Use consistent color button components for color config UI elements

kossebau updated this revision to Diff 32502. kossebau added a comment. use KQuickControls.ColorButton REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12318?vs=32491=32502 BRANCH useconsistentcolorbutton REVISION DETAIL

D12318: Use consistent color button components for color config UI elements

davidedmundson added a comment. There's ColorButton (https://api.kde.org/frameworks/kdeclarative/html/classColorButton.html) inside kquickcontrols Can't we use that? INLINE COMMENTS > kossebau wrote in ColorPicker.qml:34 > Open question to developers: > how expensive is it to have an

D12318: Use consistent color button components for color config UI elements

ngraham added a comment. +1! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12318 To: kossebau, #plasma, #vdg Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12318: Use consistent color button components for color config UI elements

kossebau added inline comments. INLINE COMMENTS > ColorPicker.qml:34 > + > +QtDialogs.ColorDialog { > +id: colorDialog Open question to developers: how expensive is it to have an instance of ColorDialog per button, instead of sharing one over all buttons? That's where the code for

D12318: Use consistent color button components for color config UI elements

kossebau added a comment. Before: F5811833: Screenshot_20180418_191455.png F5811834: Screenshot_20180418_191409.png After: F5811837: Screenshot_20180418_191620.png

D12318: Use consistent color button components for color config UI elements

kossebau created this revision. kossebau added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY For a consistent UX use the same component code for config