D26992: [SystemTray] Use unified data model everywhere

kossebau added inline comments. INLINE COMMENTS > kmaterka wrote in systemtray.h:100 > Oh, OK, now I remember, sorry for misinforming you... > > I haven't had any problems with this, it "Just Worked" :) Maybe it should > return just plain QObject*, I'm not experienced in this area, what do you

D26992: [SystemTray] Use unified data model everywhere

kmaterka marked an inline comment as done. kmaterka added inline comments. INLINE COMMENTS > kossebau wrote in systemtray.h:100 > Thanks for your reply. Okay, so seems you did not hit anything related. > > Thing is, you added > `` > Q_INVOKABLE Plasma::Service *serviceForSource(const QString );

D26992: [SystemTray] Use unified data model everywhere

kossebau added inline comments. INLINE COMMENTS > kmaterka wrote in systemtray.h:100 > I don't know, this code was there before my changes, I've just done some > refactoring here. Thanks for your reply. Okay, so seems you did not hit anything related. Thing is, you added `` Q_INVOKABLE

D26992: [SystemTray] Use unified data model everywhere

kmaterka marked an inline comment as done. kmaterka added inline comments. INLINE COMMENTS > kossebau wrote in systemtray.h:100 > Hi. Seeing this code, I have a question: from what I understood so far, for > this method to be useable from the JavaScript inside QML, the type > "Plasma::Service

D26992: [SystemTray] Use unified data model everywhere

kossebau added inline comments. INLINE COMMENTS > systemtray.h:100 > */ > -Q_INVOKABLE void reorderItemAfter(QQuickItem* after, QQuickItem* before); > - > -Q_INVOKABLE bool isSystemTrayApplet(const QString ); > +Q_INVOKABLE Plasma::Service *serviceForSource(const QString ); >

D26992: [SystemTray] Use unified data model everywhere

This revision was automatically updated to reflect the committed changes. kmaterka marked an inline comment as done. Closed by commit R120:39975673cb6a: [SystemTray] Use unified data model everywhere (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26992: [SystemTray] Use unified data model everywhere

kmaterka marked an inline comment as done. kmaterka added inline comments. INLINE COMMENTS > davidedmundson wrote in AbstractItem.qml:34 > Lets look at fixing in a follow up patch > > QML can do enums now OK, I will change that in a separate patch REPOSITORY R120 Plasma Workspace BRANCH

D26992: [SystemTray] Use unified data model everywhere

davidedmundson accepted this revision. davidedmundson added inline comments. INLINE COMMENTS > AbstractItem.qml:34 > property Item iconItem > property int /*PlasmaCore.Types.ItemStatus*/ status > +property int /*PlasmaCore.Types.ItemStatus*/ effectiveStatus Lets look at fixing in

D26992: [SystemTray] Use unified data model everywhere

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. UI and interaction are good, and a basic code review reveals no issues to me. Still, you may want to wait for a more thorough code review from a #plasma

D26992: [SystemTray] Use unified data model everywhere

ngraham added a comment. My bad, your patch actually fixes a pre-existing visual bug. :) That accounts for the change. +1 visually REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26992 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham,

D26992: [SystemTray] Use unified data model everywhere

kmaterka added a comment. In D26992#614426 , @ngraham wrote: > UI looks good except for one thing: the changes to show a highlight effect on hover in the popup are unrelated and should be done in a separate patch (preferably in coordination

D26992: [SystemTray] Use unified data model everywhere

ngraham added a comment. UI looks good except for one thing: the changes to show a highlight effect on hover in the popup are unrelated and should be done in a separate patch (preferably in coordination with #VDG folks since we're moving towards the

D26992: [SystemTray] Use unified data model everywhere

kmaterka updated this revision to Diff 76028. kmaterka added a comment. Second (and last) change extracted from this one is in master. Rebased, ready for review. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26992?vs=75134=76028 BRANCH master

D26992: [SystemTray] Use unified data model everywhere

kmaterka updated this revision to Diff 75134. kmaterka added a comment. Rebase, only D27088 left REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26992?vs=74805=75134 BRANCH master REVISION DETAIL

D26992: [SystemTray] Use unified data model everywhere

kmaterka added a comment. ... and second one: D27088 . It contains model refactoring and sorting. After that two are accepped I will rebase this one. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26992 To:

D26992: [SystemTray] Use unified data model everywhere

kmaterka added a comment. First revision: D27085 . In contains some random improvements REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26992 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik

D26992: [SystemTray] Use unified data model everywhere

davidedmundson added a comment. The patch is big, but it's manageable. Splitting is up to you, don't feel you have to. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26992 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik Cc:

D26992: [SystemTray] Use unified data model everywhere

kmaterka updated this revision to Diff 74805. kmaterka added a comment. I will split it into smaller changes, this one is too big for a review. I'll keep it here as a backup. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26992?vs=74802=74805

D26992: [SystemTray] Use unified data model everywhere

kmaterka updated this revision to Diff 74802. kmaterka added a comment. Rebase2 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26992?vs=74797=74802 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26992 AFFECTED FILES

D26992: [SystemTray] Use unified data model everywhere

kmaterka updated this revision to Diff 74797. kmaterka added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26992?vs=74586=74797 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26992 AFFECTED FILES

D26992: [SystemTray] Use unified data model everywhere

kmaterka added a comment. This change is very big. I can try to split in into two (maybe more) id that's required. If yes, should I connect revisions somehow? Create task, add parent/child revision? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26992

D26992: [SystemTray] Use unified data model everywhere

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson, ngraham, broulik. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY Use the unified data model everywhere, not just in configuration. This