Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

[David Edmundson]

> On Nov. 18, 2015, 2:40 p.m., David Edmundson wrote:
> > won't make a difference, SDDM sources a tonne before we get to you.
> 
> David Edmundson wrote:
> more specifically:
> 
> https://github.com/sddm/sddm/blob/master/data/scripts/wayland-session
> 
> we also have anything loaded from pam_env which can include 
> ~/.pam_environment depending on pam_env config.
> 
> Martin Gräßlin wrote:
> that's not good. Is there a chance we can get this changed in sddm or is 
> that needed?

The top one, we can do.

It will break some workflows (otherwise we wouldn't be sourcing them), but 
speaking purely technically that's possible.

The second one:
Getting the env from pam is something we *need* to do, and on almost every 
distro that includes pam_env with it's hook to load user set things.
There is an option to pam_env to make it not load envs from the user dir, but 
that means every distro updating their pam files.

On arch:
-required   pam_env.so
+required   pam_env.so user_env=0

on the following files:
system-auth
system-login

we can't change that from sddm.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126102/#review88525
---


On Nov. 18, 2015, 8:18 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126102/
> ---
> 
> (Updated Nov. 18, 2015, 8:18 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This change makes sure that the environment scripts are not sourced
> before KWin is started. No user installed scripts are allowed to modify
> KWin's environment as that opens an attack vector.
> 
> For example any binary plugin loaded into KWin (be it QStyle, QPT plugin,
> etc.) is able to become a key logger. If the env variables were allowed
> to be sourced before KWin is started a malicious application run as user
> (e.g. exploiting browser vulnerability) would be able to install a key
> logger. Required steps:
> 1. install a malicious QStyle plugin somewhere in $HOME
> 2. place a script in env to adjust variables to load the QStyle plugin
> 
> This would be enough to have a key logger on next login.
> 
> Given that the startup of KWin must not be affected by any scripts
> owned by user prior to startup.
> 
> The env scripts are now sourced as first step of startplasma, so
> for applications in the session there is no difference.
> 
> 
> Diffs
> -
> 
>   startkde/startplasma.cmake 8360a636d3f68c957a15158484360a611cfe3ff8 
>   startkde/startplasmacompositor.cmake 
> 8b5db615142455fd360c66504fc5d5a7754a029c 
> 
> Diff: https://git.reviewboard.kde.org/r/126102/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126104: Make networkmanager-qt an optional dependency

[Alex Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126104/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

I can't compile networkmanager-qt on my current system because the version
of NetworkManager seems to be too old.

Also not every system has NetworkManager (FreeBSD?) so it should be
optional.


Diffs
-

  CMakeLists.txt d21a2b7a7774ac712f905f1db1ee478dca10b45c 
  dataengines/CMakeLists.txt 014da10aac5629be202bd5ad96012f817bf846ef 

Diff: https://git.reviewboard.kde.org/r/126104/diff/


Testing
---

compiles


Thanks,

Alex Richardson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

[Martin Klapetek]

> On Nov. 18, 2015, 10:14 a.m., Kai Uwe Broulik wrote:
> > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp, line 37
> > 
> >
> > Add context this

Isn't "this" caputred implicitly?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125862/#review88512
---


On Nov. 18, 2015, 1:33 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125862/
> ---
> 
> (Updated Nov. 18, 2015, 1:33 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is very simple for now as there is no configuration
> yet, so it just takes the default region (your locale)
> and shows holidays from that.
> 
> Obviously this needs a config to set up which regions
> you want to show in there, but this is a start.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 4783a78 
>   plasmacalendarintegration/CMakeLists.txt PRE-CREATION 
>   plasmacalendarintegration/HolidaysConfig.qml PRE-CREATION 
>   plasmacalendarintegration/holidayeventsplugin.json PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.h PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.cpp PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/CMakeLists.txt PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.h 
> PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp 
> PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125862/diff/
> 
> 
> Testing
> ---
> 
> Holidays are properly listed in calendar applet.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125705: Use LANG for month names in calendar applet

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125705/
---

(Updated Nov. 18, 2015, 5:38 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 6f3fed77d59227a9b3ec85d343ffb2443086f7fa by Martin 
Klapetek to branch master.


Bugs: 353715
http://bugs.kde.org/show_bug.cgi?id=353715


Repository: plasma-framework


Description
---

Simple QDate::longMonthName won't do the job as it
will return the month name using LC_DATE locale which is used
for date formatting etc. So for example, in en_US locale
and cs_CZ LC_DATE, it would return Czech month names while
it should return English ones. So here we force the LANG
locale and take the month name from that.


Diffs
-

  src/declarativeimports/calendar/calendar.cpp 67a08e5 

Diff: https://git.reviewboard.kde.org/r/125705/diff/


Testing
---

LC_DATE=cs_CZ
LANG=en_US

Month names in calendar applet are now english.


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126018: Use the plural form for "Notification" category

[Martin Klapetek]

> On Nov. 10, 2015, 10:57 p.m., Martin Klapetek wrote:
> > > should I change also X-KDE-System-Settings-Category=notification to 
> > > notifications
> > 
> > I don't think so, it would require changing everywhere. Unless there is 
> > nothing actually using it, in which case, yes.
> 
> Luigi Toscano wrote:
> Where should I look for its usage? But anyway, if you think it shouldn't 
> matter, I will commit (just on time before the freeze, I missed the "ship it")

lxr.kde.org probably.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126018/#review88227
---


On Nov. 17, 2015, 12:51 a.m., Luigi Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126018/
> ---
> 
> (Updated Nov. 17, 2015, 12:51 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: systemsettings
> 
> 
> Description
> ---
> 
> The word used to be plural (even if combined with other words) in the 
> previous major version of Plasma.
> 
> Question: if accepted, should I change also 
> X-KDE-System-Settings-Category=notification to notifications, or would it be 
> not worth of?
> 
> 
> Diffs
> -
> 
>   categories/settings-personalization-notification.desktop 24fee0d 
> 
> Diff: https://git.reviewboard.kde.org/r/126018/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

[Matthias Klumpp]

> On Nov. 18, 2015, 2:57 nachm., Matthias Klumpp wrote:
> > It just wanted to write what David wrote ;-)
> > Maybe a way to resolve this is to filter environment variables in KWin or 
> > before starting KWin, so anything pointing to directories in $HOME gets 
> > stripped away (unsetting LD_* variables might also be part of that).
> 
> Martin Gräßlin wrote:
> well that are many possible variables and it might be a terrible catch up 
> game with any new variable Qt includes. It at least would affect:
> - LD_LIBRARY_PATH
> - QT_PLUGIN_PATH
> - PATH
> - LD_PRELOAD (see general LD_PRELOAD Wayland keylogger hack)
> - some QML variables which I don't know right now
> - anything else I don't remember right now
> - any aliases (one could do alias kwin_wayland="something evil"
> - any bash functions.
> 
> Ideally there just shouldn't be any scripts sourced before kwin gets 
> started

I was thinking more of an "unset all => set what's needed" workflow. Aliases 
can be worked around by giving absolute paths in the script.
Still, it isn't nice and unfortunately some of those scripts need to be sourced 
because of $HISTORIC_REASON or simply because users expect it, or - in case of 
.pam_environment - because it's a global distro default.
The only way around that would be starting KWin before SDDM starts (which would 
have it's own problems, as far as I can see).
Meh :-/


- Matthias


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126102/#review88528
---


On Nov. 18, 2015, 8:18 vorm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126102/
> ---
> 
> (Updated Nov. 18, 2015, 8:18 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This change makes sure that the environment scripts are not sourced
> before KWin is started. No user installed scripts are allowed to modify
> KWin's environment as that opens an attack vector.
> 
> For example any binary plugin loaded into KWin (be it QStyle, QPT plugin,
> etc.) is able to become a key logger. If the env variables were allowed
> to be sourced before KWin is started a malicious application run as user
> (e.g. exploiting browser vulnerability) would be able to install a key
> logger. Required steps:
> 1. install a malicious QStyle plugin somewhere in $HOME
> 2. place a script in env to adjust variables to load the QStyle plugin
> 
> This would be enough to have a key logger on next login.
> 
> Given that the startup of KWin must not be affected by any scripts
> owned by user prior to startup.
> 
> The env scripts are now sourced as first step of startplasma, so
> for applications in the session there is no difference.
> 
> 
> Diffs
> -
> 
>   startkde/startplasma.cmake 8360a636d3f68c957a15158484360a611cfe3ff8 
>   startkde/startplasmacompositor.cmake 
> 8b5db615142455fd360c66504fc5d5a7754a029c 
> 
> Diff: https://git.reviewboard.kde.org/r/126102/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

[Martin Gräßlin]

> On Nov. 18, 2015, 3:40 p.m., David Edmundson wrote:
> > won't make a difference, SDDM sources a tonne before we get to you.
> 
> David Edmundson wrote:
> more specifically:
> 
> https://github.com/sddm/sddm/blob/master/data/scripts/wayland-session
> 
> we also have anything loaded from pam_env which can include 
> ~/.pam_environment depending on pam_env config.
> 
> Martin Gräßlin wrote:
> that's not good. Is there a chance we can get this changed in sddm or is 
> that needed?
> 
> David Edmundson wrote:
> The top one, we can do.
> 
> It will break some workflows (otherwise we wouldn't be sourcing them), 
> but speaking purely technically that's possible.
> 
> The second one:
> Getting the env from pam is something we *need* to do, and on almost 
> every distro that includes pam_env with it's hook to load user set things.
> There is an option to pam_env to make it not load envs from the user dir, 
> but that means every distro updating their pam files.
> 
> On arch:
> -required   pam_env.so
> +required   pam_env.so user_env=0
> 
> on the following files:
> system-auth
> system-login
> 
> we can't change that from sddm.

I see, thanks for explaining. I'll discard this review request then. It's 
clearly not a solution.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126102/#review88525
---


On Nov. 18, 2015, 9:18 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126102/
> ---
> 
> (Updated Nov. 18, 2015, 9:18 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This change makes sure that the environment scripts are not sourced
> before KWin is started. No user installed scripts are allowed to modify
> KWin's environment as that opens an attack vector.
> 
> For example any binary plugin loaded into KWin (be it QStyle, QPT plugin,
> etc.) is able to become a key logger. If the env variables were allowed
> to be sourced before KWin is started a malicious application run as user
> (e.g. exploiting browser vulnerability) would be able to install a key
> logger. Required steps:
> 1. install a malicious QStyle plugin somewhere in $HOME
> 2. place a script in env to adjust variables to load the QStyle plugin
> 
> This would be enough to have a key logger on next login.
> 
> Given that the startup of KWin must not be affected by any scripts
> owned by user prior to startup.
> 
> The env scripts are now sourced as first step of startplasma, so
> for applications in the session there is no difference.
> 
> 
> Diffs
> -
> 
>   startkde/startplasma.cmake 8360a636d3f68c957a15158484360a611cfe3ff8 
>   startkde/startplasmacompositor.cmake 
> 8b5db615142455fd360c66504fc5d5a7754a029c 
> 
> Diff: https://git.reviewboard.kde.org/r/126102/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

[Martin Gräßlin]

> On Nov. 18, 2015, 3:57 p.m., Matthias Klumpp wrote:
> > It just wanted to write what David wrote ;-)
> > Maybe a way to resolve this is to filter environment variables in KWin or 
> > before starting KWin, so anything pointing to directories in $HOME gets 
> > stripped away (unsetting LD_* variables might also be part of that).

well that are many possible variables and it might be a terrible catch up game 
with any new variable Qt includes. It at least would affect:
- LD_LIBRARY_PATH
- QT_PLUGIN_PATH
- PATH
- LD_PRELOAD (see general LD_PRELOAD Wayland keylogger hack)
- some QML variables which I don't know right now
- anything else I don't remember right now
- any aliases (one could do alias kwin_wayland="something evil"
- any bash functions.

Ideally there just shouldn't be any scripts sourced before kwin gets started


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126102/#review88528
---


On Nov. 18, 2015, 9:18 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126102/
> ---
> 
> (Updated Nov. 18, 2015, 9:18 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This change makes sure that the environment scripts are not sourced
> before KWin is started. No user installed scripts are allowed to modify
> KWin's environment as that opens an attack vector.
> 
> For example any binary plugin loaded into KWin (be it QStyle, QPT plugin,
> etc.) is able to become a key logger. If the env variables were allowed
> to be sourced before KWin is started a malicious application run as user
> (e.g. exploiting browser vulnerability) would be able to install a key
> logger. Required steps:
> 1. install a malicious QStyle plugin somewhere in $HOME
> 2. place a script in env to adjust variables to load the QStyle plugin
> 
> This would be enough to have a key logger on next login.
> 
> Given that the startup of KWin must not be affected by any scripts
> owned by user prior to startup.
> 
> The env scripts are now sourced as first step of startplasma, so
> for applications in the session there is no difference.
> 
> 
> Diffs
> -
> 
>   startkde/startplasma.cmake 8360a636d3f68c957a15158484360a611cfe3ff8 
>   startkde/startplasmacompositor.cmake 
> 8b5db615142455fd360c66504fc5d5a7754a029c 
> 
> Diff: https://git.reviewboard.kde.org/r/126102/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

[Martin Gräßlin]

> On Nov. 18, 2015, 3:57 p.m., Matthias Klumpp wrote:
> > It just wanted to write what David wrote ;-)
> > Maybe a way to resolve this is to filter environment variables in KWin or 
> > before starting KWin, so anything pointing to directories in $HOME gets 
> > stripped away (unsetting LD_* variables might also be part of that).
> 
> Martin Gräßlin wrote:
> well that are many possible variables and it might be a terrible catch up 
> game with any new variable Qt includes. It at least would affect:
> - LD_LIBRARY_PATH
> - QT_PLUGIN_PATH
> - PATH
> - LD_PRELOAD (see general LD_PRELOAD Wayland keylogger hack)
> - some QML variables which I don't know right now
> - anything else I don't remember right now
> - any aliases (one could do alias kwin_wayland="something evil"
> - any bash functions.
> 
> Ideally there just shouldn't be any scripts sourced before kwin gets 
> started
> 
> Matthias Klumpp wrote:
> I was thinking more of an "unset all => set what's needed" workflow. 
> Aliases can be worked around by giving absolute paths in the script.
> Still, it isn't nice and unfortunately some of those scripts need to be 
> sourced because of $HISTORIC_REASON or simply because users expect it, or - 
> in case of .pam_environment - because it's a global distro default.
> The only way around that would be starting KWin before SDDM starts (which 
> would have it's own problems, as far as I can see).
> Meh :-/

> The only way around that would be starting KWin before SDDM starts

nope, wouldn't be a solution as KWin needs to run in user session.

so, yeah maybe just unsetting all variables after the sourcing of the scripts. 
Might break my workflow, but well ;-)


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126102/#review88528
---


On Nov. 18, 2015, 9:18 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126102/
> ---
> 
> (Updated Nov. 18, 2015, 9:18 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This change makes sure that the environment scripts are not sourced
> before KWin is started. No user installed scripts are allowed to modify
> KWin's environment as that opens an attack vector.
> 
> For example any binary plugin loaded into KWin (be it QStyle, QPT plugin,
> etc.) is able to become a key logger. If the env variables were allowed
> to be sourced before KWin is started a malicious application run as user
> (e.g. exploiting browser vulnerability) would be able to install a key
> logger. Required steps:
> 1. install a malicious QStyle plugin somewhere in $HOME
> 2. place a script in env to adjust variables to load the QStyle plugin
> 
> This would be enough to have a key logger on next login.
> 
> Given that the startup of KWin must not be affected by any scripts
> owned by user prior to startup.
> 
> The env scripts are now sourced as first step of startplasma, so
> for applications in the session there is no difference.
> 
> 
> Diffs
> -
> 
>   startkde/startplasma.cmake 8360a636d3f68c957a15158484360a611cfe3ff8 
>   startkde/startplasmacompositor.cmake 
> 8b5db615142455fd360c66504fc5d5a7754a029c 
> 
> Diff: https://git.reviewboard.kde.org/r/126102/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126102/
---

(Updated Nov. 18, 2015, 4:36 p.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-workspace


Description
---

This change makes sure that the environment scripts are not sourced
before KWin is started. No user installed scripts are allowed to modify
KWin's environment as that opens an attack vector.

For example any binary plugin loaded into KWin (be it QStyle, QPT plugin,
etc.) is able to become a key logger. If the env variables were allowed
to be sourced before KWin is started a malicious application run as user
(e.g. exploiting browser vulnerability) would be able to install a key
logger. Required steps:
1. install a malicious QStyle plugin somewhere in $HOME
2. place a script in env to adjust variables to load the QStyle plugin

This would be enough to have a key logger on next login.

Given that the startup of KWin must not be affected by any scripts
owned by user prior to startup.

The env scripts are now sourced as first step of startplasma, so
for applications in the session there is no difference.


Diffs
-

  startkde/startplasma.cmake 8360a636d3f68c957a15158484360a611cfe3ff8 
  startkde/startplasmacompositor.cmake 8b5db615142455fd360c66504fc5d5a7754a029c 

Diff: https://git.reviewboard.kde.org/r/126102/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

[David Edmundson]

> On Nov. 18, 2015, 9:14 a.m., Kai Uwe Broulik wrote:
> > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp, line 37
> > 
> >
> > Add context this
> 
> Martin Klapetek wrote:
> Isn't "this" caputred implicitly?

no, but it is captured by "="
If it wasn't you'd have had a compile error.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125862/#review88512
---


On Nov. 18, 2015, 12:33 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125862/
> ---
> 
> (Updated Nov. 18, 2015, 12:33 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is very simple for now as there is no configuration
> yet, so it just takes the default region (your locale)
> and shows holidays from that.
> 
> Obviously this needs a config to set up which regions
> you want to show in there, but this is a start.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 4783a78 
>   plasmacalendarintegration/CMakeLists.txt PRE-CREATION 
>   plasmacalendarintegration/HolidaysConfig.qml PRE-CREATION 
>   plasmacalendarintegration/holidayeventsplugin.json PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.h PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.cpp PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/CMakeLists.txt PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.h 
> PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp 
> PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125862/diff/
> 
> 
> Testing
> ---
> 
> Holidays are properly listed in calendar applet.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

[Martin Klapetek]

> On Nov. 18, 2015, 10:14 a.m., Kai Uwe Broulik wrote:
> > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp, line 37
> > 
> >
> > Add context this
> 
> Martin Klapetek wrote:
> Isn't "this" caputred implicitly?
> 
> David Edmundson wrote:
> no, but it is captured by "="
> If it wasn't you'd have had a compile error.

Right, that's what I meant, "implicitly if you use [=]"

Thinking about it, capturing [this] instead of [=] might
make more sense as a tinytinyoptimization as the lambda
does require only [this] in fact.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125862/#review88512
---


On Nov. 18, 2015, 1:33 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125862/
> ---
> 
> (Updated Nov. 18, 2015, 1:33 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is very simple for now as there is no configuration
> yet, so it just takes the default region (your locale)
> and shows holidays from that.
> 
> Obviously this needs a config to set up which regions
> you want to show in there, but this is a start.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 4783a78 
>   plasmacalendarintegration/CMakeLists.txt PRE-CREATION 
>   plasmacalendarintegration/HolidaysConfig.qml PRE-CREATION 
>   plasmacalendarintegration/holidayeventsplugin.json PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.h PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.cpp PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/CMakeLists.txt PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.h 
> PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp 
> PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125862/diff/
> 
> 
> Testing
> ---
> 
> Holidays are properly listed in calendar applet.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355560] New: Missing Breeze Cursor themes after update

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355560

Bug ID: 355560
   Summary: Missing Breeze Cursor themes after update
   Product: Breeze
   Version: 5.4.3
  Platform: Fedora RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: hotmusic...@mail.bg

Hello!

After the last update of Breeze theme breeze-cursor-theme was lost. It is
uninstalled and it is not available as a package at all.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355560] Missing Breeze Cursor themes after update

[Martin Klapetek via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355560

Martin Klapetek  changed:

   What|Removed |Added

 CC||mklape...@kde.org

--- Comment #1 from Martin Klapetek  ---
Thanks for the report

You should probably contact your distribution about this though.

I'll see if I can send someone from fedora here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355561] Breeze themes look a bit inconsistent after recent update

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355561

hotmusic...@mail.bg changed:

   What|Removed |Added

   Platform|Other   |Fedora RPMs

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355561] New: Breeze themes look a bit inconsistent after recent update

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355561

Bug ID: 355561
   Summary: Breeze themes look a bit inconsistent after recent
update
   Product: Breeze
   Version: 5.4.3
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: hotmusic...@mail.bg

Hello!

The last update to Breeze desktop theme brought a new vision to the panels and
especially to the task managers - they no long have blue lines above the
icons/tasks (now a tiny blue squares) unlike the tray items or the items in the
Kickoff. I know it is a matter of taste but according to me it seems a bit
inconsistent. 

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[plasmashell] [Bug 355561] Breeze themes look a bit inconsistent after recent update

[Martin Klapetek via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355561

Martin Klapetek  changed:

   What|Removed |Added

 CC||mklape...@kde.org,
   ||plasma-b...@kde.org
   Target Milestone|--- |1.0
   Assignee|plasma-devel@kde.org|visual-des...@kde.org
Product|Breeze  |plasmashell
  Component|general |Theme - Breeze

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125991: [Widget Explorer] Allow uninstalling user-installed applets

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125991/#review88548
---


Ping

I don't want to ease people installing applets (cf Review 125968) but then not 
provide a way to uninstall them :)

- Kai Uwe Broulik


On Nov. 17, 2015, 9:37 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125991/
> ---
> 
> (Updated Nov. 17, 2015, 9:37 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The no longer enabled tooltip also contained the uninstall button. This 
> restores the uninstall functionality similar to the wallpaper dialog.
> 
> User-installed applets get an uninstall button. I chose to always show it 
> rather than on hover since only a few applets are likely to be uninstallable 
> and I don't want to play the guessing-game, perhaps we should introduce a 
> filter for "User-installed applets" similar to the (less useful) "running" 
> ones. Clicking the button will queue the uninstallation which can be 
> cancelled anytime the dialog is still opened. As soon as the dialog closes, 
> the actual uninstall is executed.
> 
> Multiple applets can be enqueued simultaneously.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 5a81b91 
>   desktoppackage/contents/explorer/WidgetExplorer.qml af27229 
>   desktoppackage/contents/views/Desktop.qml b555fea 
> 
> Diff: https://git.reviewboard.kde.org/r/125991/diff/
> 
> 
> Testing
> ---
> 
> Installed plasmoid through drag and drop, uninstalled after fixing an 
> uninstall bug (Review 125990)
> 
> The tooltip says "Undo uninstall". I just noticed I should probably fade the 
> applet name too.
> 
> 
> File Attachments
> 
> 
> Uninstall before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/adcb91e0-a8c2-4481-89f1-139b4e716da3__uninstall1.png
> Undo uninstall
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/ebdae6ad-28bd-42f0-bb36-bfa6dfd3cc30__uninstall2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

[Kai Uwe Broulik]

> On Nov. 18, 2015, 9:14 vorm., Kai Uwe Broulik wrote:
> > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp, line 37
> > 
> >
> > Add context this
> 
> Martin Klapetek wrote:
> Isn't "this" caputred implicitly?
> 
> David Edmundson wrote:
> no, but it is captured by "="
> If it wasn't you'd have had a compile error.
> 
> Martin Klapetek wrote:
> Right, that's what I meant, "implicitly if you use [=]"
> 
> Thinking about it, capturing [this] instead of [=] might
> make more sense as a tinytinyoptimization as the lambda
> does require only [this] in fact.

I was referring to connect(this, ::bar, this, [=] { ... }) but given you 
connect *from* this already, I suppose there's no need to provide a receiver 
context. Sorry for the noise.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125862/#review88512
---


On Nov. 18, 2015, 12:33 vorm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125862/
> ---
> 
> (Updated Nov. 18, 2015, 12:33 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is very simple for now as there is no configuration
> yet, so it just takes the default region (your locale)
> and shows holidays from that.
> 
> Obviously this needs a config to set up which regions
> you want to show in there, but this is a start.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 4783a78 
>   plasmacalendarintegration/CMakeLists.txt PRE-CREATION 
>   plasmacalendarintegration/HolidaysConfig.qml PRE-CREATION 
>   plasmacalendarintegration/holidayeventsplugin.json PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.h PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.cpp PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/CMakeLists.txt PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.h 
> PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp 
> PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125862/diff/
> 
> 
> Testing
> ---
> 
> Holidays are properly listed in calendar applet.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Release plasma-framework + kdeclarative beta with plasma 5.5beta?

[Martin Klapetek]

On Wed, Nov 18, 2015 at 9:38 AM, David Edmundson  wrote:

>
> On Wed, Nov 18, 2015 at 2:25 PM, Martin Klapetek <
> martin.klape...@gmail.com> wrote:
>
>> Hi,
>>
>> so there's a plasma 5.5 beta release in the following days
>> and there is some stuff in workspace that requires latest
>> plasma-framework + kdeclarative,
>>
>
> Then it needs reverting, you missed the window.
>

Ok, reverted and postponed for 5.6.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasmoid templates in plasma-sdk

[Marco Martin]

On Monday 16 November 2015, Sebastian Kügler wrote:
> > yes, makes sense, most important is to have them in places harder to
> > forget about
> 
> If in plasma-framework, it would kind of fit in with all the example
> plasmoid code. Not sure if that, or plasma-sdk, both make sense to me,
> perhaps plasma- sdk a bit more, even.

sooo, plasma-sdk or plasma-framework? is the same for me, i have them ready, 
just to push wherever ;)

the argument for plasma-framework to me is *if* other frameworks are going to 
have their own templates in their repos as well

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355540] New: Tooltips color wrong in gtk applications

[郭云鹤]

https://bugs.kde.org/show_bug.cgi?id=355540

Bug ID: 355540
   Summary: Tooltips color wrong in gtk applications
   Product: Breeze
   Version: unspecified
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: guoyunhebr...@gmail.com

KDE 5.4.2, Qt 5.5, openSUSE 42.1

By default, tooltips on icons are: white text, dark background. In Firefox and
Thunderbird: black text, light gray background. But in Inkscape and GIMP, they
are white text, light gray background, which is very hard to read.

http://i.imgur.com/SZWqA79.png

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126089/
---

(Updated Nov. 18, 2015, 11:10 a.m.)


Review request for Plasma.


Repository: plasma-sdk


Description
---

* add a metadata editor functionality that allows to create a theme based upon 
the default one and edit some of the metadata afterwards

* add a graphical editor for the color file that has a little preview with fake 
widgets to give an idea how the colors will look


Diffs (updated)
-

  themeexplorer/package/contents/ui/ColorButton.qml PRE-CREATION 
  themeexplorer/package/contents/ui/ColorEditor.qml PRE-CREATION 
  themeexplorer/package/contents/ui/FormLabel.qml PRE-CREATION 
  themeexplorer/package/contents/ui/MetadataEditor.qml PRE-CREATION 
  themeexplorer/package/contents/ui/fakecontrols/Button.qml PRE-CREATION 
  themeexplorer/package/contents/ui/fakecontrols/CheckBox.qml PRE-CREATION 
  themeexplorer/package/contents/ui/fakecontrols/LineEdit.qml PRE-CREATION 
  themeexplorer/package/contents/ui/main.qml af61c39 
  themeexplorer/src/CMakeLists.txt c971784 
  themeexplorer/src/coloreditor.h PRE-CREATION 
  themeexplorer/src/coloreditor.cpp PRE-CREATION 
  themeexplorer/src/main.cpp f2ec4a2 
  themeexplorer/src/themelistmodel.h 3ae6eb4 
  themeexplorer/src/themelistmodel.cpp 32a6fd4 
  themeexplorer/src/thememodel.h 18e404d 
  themeexplorer/src/thememodel.cpp 5366a7e 

Diff: https://git.reviewboard.kde.org/r/126089/diff/


Testing
---


File Attachments


snapshot18.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/2ec2a6f6-a9db-4527-b3ce-05c9ac4585a2__snapshot18.png
snapshot17.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/3cba4a35-5bf0-485b-a94e-65e6fd07e778__snapshot17.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125705: Use LANG for month names in calendar applet

[David Edmundson]

> On Oct. 28, 2015, 8:44 p.m., Martin Klapetek wrote:
> > So...any word on this?
> 
> Albert Astals Cid wrote:
> Re-reading your comment, if i understand it correctly, you claim it is a 
> bug in Qt that it does obey LC_DATE for month names when according to you 
> LC_DATE is only for the formatting and should be using LANG, right? 
> Why not fix it upstream then?
> 
> Martin Klapetek wrote:
> I don't claim it's a bug as I simply don't know if it's correct behavior 
> or not, just that the way it works does not suit our intended use case, 
> because we encourage our users to mess with LC_* variables through the 
> Formats KCM, which makes it prone to mixed configurations like LC_DATE=cs_CZ 
> and LANG=en_US.
> 
> But nevertheless a) David Edmundson has a patch in the works so let's see 
> if they think it's a bug and b) we'd need something for the meantime anyway.
> 
> David Edmundson wrote:
> Just uploaded: https://codereview.qt-project.org/139295
> 
> Martin Klapetek wrote:
> Given the Qt patch was rejected, I'll ship this if noone objects.

+1


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125705/#review87617
---


On Oct. 20, 2015, 7:04 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125705/
> ---
> 
> (Updated Oct. 20, 2015, 7:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 353715
> http://bugs.kde.org/show_bug.cgi?id=353715
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple QDate::longMonthName won't do the job as it
> will return the month name using LC_DATE locale which is used
> for date formatting etc. So for example, in en_US locale
> and cs_CZ LC_DATE, it would return Czech month names while
> it should return English ones. So here we force the LANG
> locale and take the month name from that.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp 67a08e5 
> 
> Diff: https://git.reviewboard.kde.org/r/125705/diff/
> 
> 
> Testing
> ---
> 
> LC_DATE=cs_CZ
> LANG=en_US
> 
> Month names in calendar applet are now english.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

[Marco Martin]

> On Nov. 17, 2015, 1:24 p.m., Kai Uwe Broulik wrote:
> > themeexplorer/package/contents/ui/ColorEditor.qml, lines 326-329
> > 
> >
> > Does keyboard navigation work with that still? ie. return/escape? Also 
> > set "isDefault: true" for the default button

tab navigation is fine. enter and escape is indeed broken. but using the 
default buttons is so broken that i would manage the keys on my own


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126089/#review88477
---


On Nov. 16, 2015, 2:37 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126089/
> ---
> 
> (Updated Nov. 16, 2015, 2:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-sdk
> 
> 
> Description
> ---
> 
> * add a metadata editor functionality that allows to create a theme based 
> upon the default one and edit some of the metadata afterwards
> 
> * add a graphical editor for the color file that has a little preview with 
> fake widgets to give an idea how the colors will look
> 
> 
> Diffs
> -
> 
>   themeexplorer/package/contents/ui/ColorButton.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/ColorEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/FormLabel.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/MetadataEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/Button.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/CheckBox.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/LineEdit.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/main.qml af61c39 
>   themeexplorer/src/CMakeLists.txt c971784 
>   themeexplorer/src/coloreditor.h PRE-CREATION 
>   themeexplorer/src/coloreditor.cpp PRE-CREATION 
>   themeexplorer/src/main.cpp f2ec4a2 
>   themeexplorer/src/themelistmodel.h 3ae6eb4 
>   themeexplorer/src/themelistmodel.cpp 32a6fd4 
>   themeexplorer/src/thememodel.h 18e404d 
>   themeexplorer/src/thememodel.cpp 5366a7e 
> 
> Diff: https://git.reviewboard.kde.org/r/126089/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot18.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/2ec2a6f6-a9db-4527-b3ce-05c9ac4585a2__snapshot18.png
> snapshot17.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/3cba4a35-5bf0-485b-a94e-65e6fd07e778__snapshot17.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126098: Install session file for plasma on wayland

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126098/#review88514
---

Ship it!


Ship It!

- Martin Gräßlin


On Nov. 17, 2015, 4:55 p.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126098/
> ---
> 
> (Updated Nov. 17, 2015, 4:55 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Currently session is listed by at least sddm 0.13 and higher as "Plasma 
> (wayland)"
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 4783a78 
>   plasmawayland.desktop.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126098/diff/
> 
> 
> Testing
> ---
> 
> works
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126101: allow loading backends in-process

[Daniel Vrátil]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126101/#review88510
---



src/backendlauncher/backendloader.cpp (line 122)


Use return directly?



autotests/testconfigmonitor.cpp (line 120)


I think you want to setop->exec() first, then check for error ;) Or you can 
just QVERIFY(setop->exec()), because exec() returns value of hasError().



autotests/testconfigmonitor.cpp (line 130)


Same here - QVERIFY(setop2->exec()) will do.



autotests/testinprocess.cpp (line 91)


QVERIFY



src/configoperation.cpp (line 25)


Not needed anymore?



src/configoperation.cpp (line 141)


I am not a big fan of being able to reload a different backend just by 
changing the env variable. This can lead to all kinds of funny situations that 
we don't want.

IMO we should require that shutdownBackend() is called explicitly before 
loading a different backend, enforcing that QPluginLoader::unload() is called 
first, m_backend is cleared etc.

Same goes with changing the KSCREEN_BACKEND_ARGS - while calling init() to 
re-init works for the simple Fake backend, it might not be enough for more 
complex backends.

Basically the intended behaviour is that you call get(InProcess)Backend() 
(or something like that), and you fall back to parsing the env variables and 
calling loadBackendInProcess() if getBackend() returned null pointer. Or you 
can just move the env parsing to loadBackendInProcess() when loading a new 
plugin, always returning the cached backend unless it's null, then loading 
based on current env variables.



src/configoperation_p.h (line 43)


Maybe we don't even need to store it? Looking at the implementation in both 
Operations, it might just fine if loadBackend() returned the backend pointer...


- Daniel Vrátil


On Nov. 18, 2015, 3:36 a.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126101/
> ---
> 
> (Updated Nov. 18, 2015, 3:36 a.m.)
> 
> 
> Review request for Plasma, Solid, Àlex Fiestas, Aleix Pol Gonzalez, Daniel 
> Vrátil, and Martin Gräßlin.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> This patchset adds in-process operation to libkscreen
> 
> purpose:
> - allow easier debugging
> - for some backends (qscreen, upcoming kwayland) the out of process operation 
> is not necessary since these backends are well-shielded
> 
> This implementation is backwards compatible and should mean only minimal 
> changes to running setups.
> 
> If the user exports KSCREEN_BACKEND_INPROCESS=1 before running, all 
> operations will be done in process. Otherwise, the out-of-process mode is 
> used.
> 
> The idea is that we use 
> The changes in the clients to use the in-process mode are to use 
> ConfigOperation::create() and ConfigOperation::setOperation() to retrieve the 
> get or set config jobs. The rest will be handled inside libkscreen.
> 
> Autotests should cover all the cases (and actually a few currently 
> unsupported ones, such as using different backends in the same process).
> 
> Details on performance, etc.: 
> http://vizzzion.org/blog/2015/11/wayland-and-libkscreen-benchmarks/
> 
> 
> Diffs
> -
> 
>   src/configoperation.h 2405d79 
>   autotests/testconfigmonitor.cpp a051226 
>   backends/fake/fake.cpp 60264dd 
>   src/configmonitor.cpp a14bc70 
>   src/backendlauncher/backendloader.cpp 52051df 
>   src/backendmanager.cpp ca9c746 
>   src/backendmanager_p.h c6418e2 
>   src/config.cpp 75d947d 
>   src/configmonitor.h b6f1189 
>   src/configoperation.cpp 87fe141 
>   CMakeLists.txt 86a0965 
>   autotests/CMakeLists.txt 69af7f0 
>   autotests/testinprocess.cpp PRE-CREATION 
>   autotests/testqscreenbackend.cpp da4dbae 
>   autotests/testscreenconfig.cpp ecbcedf 
>   autotests/testxrandr.cpp b9b838a 
>   src/configoperation_p.h afdc462 
>   src/getconfigoperation.h c85bfaa 
>   src/getconfigoperation.cpp 22f92b4 
>   src/output.cpp bd381fa 
>   src/setconfigoperation.h 020a990 
>   src/setconfigoperation.cpp 6ea944f 
> 
> Diff: https://git.reviewboard.kde.org/r/126101/diff/
> 
> 
> Testing
> ---
> 
> Added a ton of autotests, made sure all existing ones pass.
> 
> tried "KSCREEN_BACKEND_INPROCESS=1 kcmshell5 kscreen", all working as 
> expected.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

[Marco Martin]

> On Nov. 17, 2015, 1:24 p.m., Kai Uwe Broulik wrote:
> > themeexplorer/package/contents/ui/ColorEditor.qml, line 97
> > 
> >
> > I think if you made the ColumnLayout the contentItem the Dialog would 
> > deduce window sizing automatically from it

does a white background if i assign as contentItem
if i assign it instead as default property, it deduces correctly the window 
size from ColumnLayout hints, but resizing the column layout from the manually 
resized window won't work


> On Nov. 17, 2015, 1:24 p.m., Kai Uwe Broulik wrote:
> > themeexplorer/package/contents/ui/ColorEditor.qml, lines 189-192
> > 
> >
> > You could just make the GridLayout child of the ScrollView

I need to center it horizontally, i don't think it can do that if i don't put 
it in a blank parent?


> On Nov. 17, 2015, 1:24 p.m., Kai Uwe Broulik wrote:
> > themeexplorer/package/contents/ui/MetadataEditor.qml, line 39
> > 
> >
> > .forceActiveFocus() ?

works this way too (iirc forceActiveFocus had problems with accessibility?)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126089/#review88477
---


On Nov. 16, 2015, 2:37 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126089/
> ---
> 
> (Updated Nov. 16, 2015, 2:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-sdk
> 
> 
> Description
> ---
> 
> * add a metadata editor functionality that allows to create a theme based 
> upon the default one and edit some of the metadata afterwards
> 
> * add a graphical editor for the color file that has a little preview with 
> fake widgets to give an idea how the colors will look
> 
> 
> Diffs
> -
> 
>   themeexplorer/package/contents/ui/ColorButton.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/ColorEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/FormLabel.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/MetadataEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/Button.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/CheckBox.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/LineEdit.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/main.qml af61c39 
>   themeexplorer/src/CMakeLists.txt c971784 
>   themeexplorer/src/coloreditor.h PRE-CREATION 
>   themeexplorer/src/coloreditor.cpp PRE-CREATION 
>   themeexplorer/src/main.cpp f2ec4a2 
>   themeexplorer/src/themelistmodel.h 3ae6eb4 
>   themeexplorer/src/themelistmodel.cpp 32a6fd4 
>   themeexplorer/src/thememodel.h 18e404d 
>   themeexplorer/src/thememodel.cpp 5366a7e 
> 
> Diff: https://git.reviewboard.kde.org/r/126089/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot18.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/2ec2a6f6-a9db-4527-b3ce-05c9ac4585a2__snapshot18.png
> snapshot17.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/3cba4a35-5bf0-485b-a94e-65e6fd07e778__snapshot17.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126102/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

This change makes sure that the environment scripts are not sourced
before KWin is started. No user installed scripts are allowed to modify
KWin's environment as that opens an attack vector.

For example any binary plugin loaded into KWin (be it QStyle, QPT plugin,
etc.) is able to become a key logger. If the env variables were allowed
to be sourced before KWin is started a malicious application run as user
(e.g. exploiting browser vulnerability) would be able to install a key
logger. Required steps:
1. install a malicious QStyle plugin somewhere in $HOME
2. place a script in env to adjust variables to load the QStyle plugin

This would be enough to have a key logger on next login.

Given that the startup of KWin must not be affected by any scripts
owned by user prior to startup.

The env scripts are now sourced as first step of startplasma, so
for applications in the session there is no difference.


Diffs
-

  startkde/startplasma.cmake 8360a636d3f68c957a15158484360a611cfe3ff8 
  startkde/startplasmacompositor.cmake 8b5db615142455fd360c66504fc5d5a7754a029c 

Diff: https://git.reviewboard.kde.org/r/126102/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126102/#review88511
---



startkde/startplasma.cmake (line 20)


We do depend on 5.4 now? :) outside of this patch though


- Kai Uwe Broulik


On Nov. 18, 2015, 8:18 vorm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126102/
> ---
> 
> (Updated Nov. 18, 2015, 8:18 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This change makes sure that the environment scripts are not sourced
> before KWin is started. No user installed scripts are allowed to modify
> KWin's environment as that opens an attack vector.
> 
> For example any binary plugin loaded into KWin (be it QStyle, QPT plugin,
> etc.) is able to become a key logger. If the env variables were allowed
> to be sourced before KWin is started a malicious application run as user
> (e.g. exploiting browser vulnerability) would be able to install a key
> logger. Required steps:
> 1. install a malicious QStyle plugin somewhere in $HOME
> 2. place a script in env to adjust variables to load the QStyle plugin
> 
> This would be enough to have a key logger on next login.
> 
> Given that the startup of KWin must not be affected by any scripts
> owned by user prior to startup.
> 
> The env scripts are now sourced as first step of startplasma, so
> for applications in the session there is no difference.
> 
> 
> Diffs
> -
> 
>   startkde/startplasma.cmake 8360a636d3f68c957a15158484360a611cfe3ff8 
>   startkde/startplasmacompositor.cmake 
> 8b5db615142455fd360c66504fc5d5a7754a029c 
> 
> Diff: https://git.reviewboard.kde.org/r/126102/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125862/#review88512
---



plasmacalendarintegration/HolidaysConfig.qml (line 62)


I think we should at one point make a kqc component from this



plasmacalendarintegration/HolidaysConfig.qml (line 70)


There's no Connections {} actually using this signal. See the timezone table



plasmacalendarintegration/holidaysevents.cpp (line 45)


Please m_regions.clear() afterwards

I've seen various Plasma crashes on teardown becasue we qDeleteAll'd 
without clearing.



plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp (line 37)


Add context this


- Kai Uwe Broulik


On Nov. 18, 2015, 12:33 vorm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125862/
> ---
> 
> (Updated Nov. 18, 2015, 12:33 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is very simple for now as there is no configuration
> yet, so it just takes the default region (your locale)
> and shows holidays from that.
> 
> Obviously this needs a config to set up which regions
> you want to show in there, but this is a start.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 4783a78 
>   plasmacalendarintegration/CMakeLists.txt PRE-CREATION 
>   plasmacalendarintegration/HolidaysConfig.qml PRE-CREATION 
>   plasmacalendarintegration/holidayeventsplugin.json PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.h PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.cpp PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/CMakeLists.txt PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.h 
> PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp 
> PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125862/diff/
> 
> 
> Testing
> ---
> 
> Holidays are properly listed in calendar applet.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126098: Install session file for plasma on wayland

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126098/
---

(Updated Nov. 18, 2015, 9:38 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Martin Gräßlin.


Changes
---

Submitted with commit 49194b62294350751aaa1361d6c868c47a371cec by Bhushan Shah 
to branch master.


Repository: plasma-workspace


Description
---

Currently session is listed by at least sddm 0.13 and higher as "Plasma 
(wayland)"


Diffs
-

  CMakeLists.txt 4783a78 
  plasmawayland.desktop.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126098/diff/


Testing
---

works


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Release plasma-framework + kdeclarative beta with plasma 5.5beta?

[David Edmundson]

On Wed, Nov 18, 2015 at 2:25 PM, Martin Klapetek 
wrote:

> Hi,
>
> so there's a plasma 5.5 beta release in the following days
> and there is some stuff in workspace that requires latest
> plasma-framework + kdeclarative,
>

Then it needs reverting, you missed the window.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

[Martin Gräßlin]

> On Nov. 18, 2015, 3:40 p.m., David Edmundson wrote:
> > won't make a difference, SDDM sources a tonne before we get to you.
> 
> David Edmundson wrote:
> more specifically:
> 
> https://github.com/sddm/sddm/blob/master/data/scripts/wayland-session
> 
> we also have anything loaded from pam_env which can include 
> ~/.pam_environment depending on pam_env config.

that's not good. Is there a chance we can get this changed in sddm or is that 
needed?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126102/#review88525
---


On Nov. 18, 2015, 9:18 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126102/
> ---
> 
> (Updated Nov. 18, 2015, 9:18 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This change makes sure that the environment scripts are not sourced
> before KWin is started. No user installed scripts are allowed to modify
> KWin's environment as that opens an attack vector.
> 
> For example any binary plugin loaded into KWin (be it QStyle, QPT plugin,
> etc.) is able to become a key logger. If the env variables were allowed
> to be sourced before KWin is started a malicious application run as user
> (e.g. exploiting browser vulnerability) would be able to install a key
> logger. Required steps:
> 1. install a malicious QStyle plugin somewhere in $HOME
> 2. place a script in env to adjust variables to load the QStyle plugin
> 
> This would be enough to have a key logger on next login.
> 
> Given that the startup of KWin must not be affected by any scripts
> owned by user prior to startup.
> 
> The env scripts are now sourced as first step of startplasma, so
> for applications in the session there is no difference.
> 
> 
> Diffs
> -
> 
>   startkde/startplasma.cmake 8360a636d3f68c957a15158484360a611cfe3ff8 
>   startkde/startplasmacompositor.cmake 
> 8b5db615142455fd360c66504fc5d5a7754a029c 
> 
> Diff: https://git.reviewboard.kde.org/r/126102/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

[Matthias Klumpp]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126102/#review88528
---


It just wanted to write what David wrote ;-)
Maybe a way to resolve this is to filter environment variables in KWin or 
before starting KWin, so anything pointing to directories in $HOME gets 
stripped away (unsetting LD_* variables might also be part of that).

- Matthias Klumpp


On Nov. 18, 2015, 8:18 vorm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126102/
> ---
> 
> (Updated Nov. 18, 2015, 8:18 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This change makes sure that the environment scripts are not sourced
> before KWin is started. No user installed scripts are allowed to modify
> KWin's environment as that opens an attack vector.
> 
> For example any binary plugin loaded into KWin (be it QStyle, QPT plugin,
> etc.) is able to become a key logger. If the env variables were allowed
> to be sourced before KWin is started a malicious application run as user
> (e.g. exploiting browser vulnerability) would be able to install a key
> logger. Required steps:
> 1. install a malicious QStyle plugin somewhere in $HOME
> 2. place a script in env to adjust variables to load the QStyle plugin
> 
> This would be enough to have a key logger on next login.
> 
> Given that the startup of KWin must not be affected by any scripts
> owned by user prior to startup.
> 
> The env scripts are now sourced as first step of startplasma, so
> for applications in the session there is no difference.
> 
> 
> Diffs
> -
> 
>   startkde/startplasma.cmake 8360a636d3f68c957a15158484360a611cfe3ff8 
>   startkde/startplasmacompositor.cmake 
> 8b5db615142455fd360c66504fc5d5a7754a029c 
> 
> Diff: https://git.reviewboard.kde.org/r/126102/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

[David Edmundson]

> On Nov. 18, 2015, 2:40 p.m., David Edmundson wrote:
> > won't make a difference, SDDM sources a tonne before we get to you.

more specifically:

https://github.com/sddm/sddm/blob/master/data/scripts/wayland-session

we also have anything loaded from pam_env which can include ~/.pam_environment 
depending on pam_env config.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126102/#review88525
---


On Nov. 18, 2015, 8:18 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126102/
> ---
> 
> (Updated Nov. 18, 2015, 8:18 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This change makes sure that the environment scripts are not sourced
> before KWin is started. No user installed scripts are allowed to modify
> KWin's environment as that opens an attack vector.
> 
> For example any binary plugin loaded into KWin (be it QStyle, QPT plugin,
> etc.) is able to become a key logger. If the env variables were allowed
> to be sourced before KWin is started a malicious application run as user
> (e.g. exploiting browser vulnerability) would be able to install a key
> logger. Required steps:
> 1. install a malicious QStyle plugin somewhere in $HOME
> 2. place a script in env to adjust variables to load the QStyle plugin
> 
> This would be enough to have a key logger on next login.
> 
> Given that the startup of KWin must not be affected by any scripts
> owned by user prior to startup.
> 
> The env scripts are now sourced as first step of startplasma, so
> for applications in the session there is no difference.
> 
> 
> Diffs
> -
> 
>   startkde/startplasma.cmake 8360a636d3f68c957a15158484360a611cfe3ff8 
>   startkde/startplasmacompositor.cmake 
> 8b5db615142455fd360c66504fc5d5a7754a029c 
> 
> Diff: https://git.reviewboard.kde.org/r/126102/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Release plasma-framework + kdeclarative beta with plasma 5.5beta?

[Martin Klapetek]

Hi,

so there's a plasma 5.5 beta release in the following days
and there is some stuff in workspace that requires latest
plasma-framework + kdeclarative, their qml imports to be
more precise. The final 5.5 will be out when those frameworks
are out but for the beta, we'll be releasing half-broken calendar.

Could we therefore release plasma-fw + kdeclarative betas
alongside plasma 5.5 beta?

Also I'm not in release-team, please CC me.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126102/#review88525
---


won't make a difference, SDDM sources a tonne before we get to you.

- David Edmundson


On Nov. 18, 2015, 8:18 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126102/
> ---
> 
> (Updated Nov. 18, 2015, 8:18 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This change makes sure that the environment scripts are not sourced
> before KWin is started. No user installed scripts are allowed to modify
> KWin's environment as that opens an attack vector.
> 
> For example any binary plugin loaded into KWin (be it QStyle, QPT plugin,
> etc.) is able to become a key logger. If the env variables were allowed
> to be sourced before KWin is started a malicious application run as user
> (e.g. exploiting browser vulnerability) would be able to install a key
> logger. Required steps:
> 1. install a malicious QStyle plugin somewhere in $HOME
> 2. place a script in env to adjust variables to load the QStyle plugin
> 
> This would be enough to have a key logger on next login.
> 
> Given that the startup of KWin must not be affected by any scripts
> owned by user prior to startup.
> 
> The env scripts are now sourced as first step of startplasma, so
> for applications in the session there is no difference.
> 
> 
> Diffs
> -
> 
>   startkde/startplasma.cmake 8360a636d3f68c957a15158484360a611cfe3ff8 
>   startkde/startplasmacompositor.cmake 
> 8b5db615142455fd360c66504fc5d5a7754a029c 
> 
> Diff: https://git.reviewboard.kde.org/r/126102/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

[Gregor Mi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124675/
---

(Updated Nov. 18, 2015, 10:51 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, KDE Usability and Jens Reuterberg.


Changes
---

Submitted with commit 0b50e08a38865fac7912aa4c99c4472586b6f05c by Gregor Mi to 
branch master.


Bugs: 311991
https://bugs.kde.org/show_bug.cgi?id=311991


Repository: plasma-desktop


Description
---

This fixes Bug 311991. Though I am not sure if there are side effects which I 
am not aware of.


Diffs
-

  applets/taskmanager/package/contents/ui/Task.qml 
f655801ab1f7b1a9a915f35149c858f0ede22a29 

Diff: https://git.reviewboard.kde.org/r/124675/diff/


Testing
---


Thanks,

Gregor Mi

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124675/#review88552
---


Sorry, was there an extra discussion that's not mentioned on here?

- David Edmundson


On Nov. 18, 2015, 10:51 p.m., Gregor Mi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124675/
> ---
> 
> (Updated Nov. 18, 2015, 10:51 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Jens Reuterberg.
> 
> 
> Bugs: 311991
> https://bugs.kde.org/show_bug.cgi?id=311991
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This fixes Bug 311991. Though I am not sure if there are side effects which I 
> am not aware of.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/Task.qml 
> f655801ab1f7b1a9a915f35149c858f0ede22a29 
> 
> Diff: https://git.reviewboard.kde.org/r/124675/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[plasmashell] [Bug 355563] Taskbar is cluttered and colorfull

[Martin Klapetek via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355563

Martin Klapetek  changed:

   What|Removed |Added

   Assignee|plasma-devel@kde.org|visual-des...@kde.org
Product|Breeze  |plasmashell
  Component|general |Theme - Breeze
   Target Milestone|--- |1.0
 CC||mklape...@kde.org,
   ||plasma-b...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126100: [KRunner] Forward KRunner switchUser to KSMServer

[Vishesh Handa]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126100/#review88555
---

Ship it!


- Vishesh Handa


On Nov. 17, 2015, 7:09 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126100/
> ---
> 
> (Updated Nov. 17, 2015, 7:09 p.m.)
> 
> 
> Review request for Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> To maintain compatibility with users of that interface, calling it will 
> forward that to KSMServer showing the new user switcher
> 
> 
> Diffs
> -
> 
>   krunner/view.cpp 8841128 
> 
> Diff: https://git.reviewboard.kde.org/r/126100/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355563] Taskbar is cluttered and colorfull

[Christoph Feck via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355563

Christoph Feck  changed:

   What|Removed |Added

  Component|window decoration   |general
   Assignee|hugo.pere...@free.fr|plasma-devel@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125465/
---

(Updated Nov. 18, 2015, 10:03 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit daa54f5f9ec969edca3943fd7efe662c6e25bb38 by David Rosca 
to branch master.


Bugs: 346336
https://bugs.kde.org/show_bug.cgi?id=346336


Repository: plasma-desktop


Description
---

xcb-xinput is not available on some distributions (eg. Debian 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733227).
This patch adds udev device discovery to reapply settings when adding new 
keyboard / mouse.


Diffs
-

  CMakeLists.txt 193238a 
  cmake/modules/FindUDev.cmake PRE-CREATION 
  kcms/keyboard/CMakeLists.txt 99f4bb3 
  kcms/keyboard/config-keyboard.h.cmake PRE-CREATION 
  kcms/keyboard/kcm_add_layout_dialog.h a2c0ac5 
  kcms/keyboard/kcm_add_layout_dialog.cpp 64551d9 
  kcms/keyboard/kcm_keyboard_widget.h 5994ea4 
  kcms/keyboard/tests/CMakeLists.txt 5d7a3e7 
  kcms/keyboard/udev_helper.h PRE-CREATION 
  kcms/keyboard/udev_helper.cpp PRE-CREATION 
  kcms/keyboard/xinput_helper.h af70365 
  kcms/keyboard/xinput_helper.cpp 0ad7e9c 
  kcms/keyboard/xkb_rules.h ecebd6d 

Diff: https://git.reviewboard.kde.org/r/125465/diff/


Testing
---

Plugging in keyboard is now correctly recognized.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355560] Missing Breeze Cursor themes after update

[Rex Dieter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355560

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@math.unl.edu
 Resolution|--- |DOWNSTREAM
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Rex Dieter  ---
This is a downstream fedora packaging bug (we were caught a little by surprise
that breeze-icons were separated, but that did not also include the cursors
too), see also,
https://bugzilla.redhat.com/show_bug.cgi?id=1282203

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [kde-promo] 5.5 announcement

[Martin Klapetek]

On Wed, Nov 18, 2015 at 1:36 PM, Jonathan Riddell  wrote:

>
> Thanks for the various suggestions and corrections I've had, should be all
> in
>
> https://www.kde.org/announcements/plasma-5.4.95.php
>
> Is anyone able to take a screenshot of "Legacy System Tray Icons" with the
> 5.5 icons?
>

I've tried but I a) don't have spotify and b) other issues

https://www.dropbox.com/s/7g1sm39k5dqcv4n/new_snapshot14_calendar.png?dl=0

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

[Gregor Mi]

> On Nov. 18, 2015, 11:28 p.m., David Edmundson wrote:
> > Sorry, was there an extra discussion that's not mentioned on here?

Hi David, the original requirement was to ask the VDG team and follow their 
decision (as you said 3 month ago). The comment "Nevertheless, we agreed that 
since greying out is definitely not the correct visualization and your patch 
fixes this, you can ship it." from Thomas on Oct. 27 reads like a "Ship It" 
from the designers to me.


- Gregor


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124675/#review88552
---


On Nov. 18, 2015, 10:51 p.m., Gregor Mi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124675/
> ---
> 
> (Updated Nov. 18, 2015, 10:51 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Jens Reuterberg.
> 
> 
> Bugs: 311991
> https://bugs.kde.org/show_bug.cgi?id=311991
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This fixes Bug 311991. Though I am not sure if there are side effects which I 
> am not aware of.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/Task.qml 
> f655801ab1f7b1a9a915f35149c858f0ede22a29 
> 
> Diff: https://git.reviewboard.kde.org/r/124675/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126107: Use absolute path to kwin_wayland

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126107/#review88564
---


+1

- Bhushan Shah


On Nov. 19, 2015, 12:14 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126107/
> ---
> 
> (Updated Nov. 19, 2015, 12:14 p.m.)
> 
> 
> Review request for Plasma, David Edmundson and Matthias Klumpp.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This prevents possible attacks to replace kwin_wayland through a
> sourced env variable script which aliases kwin_wayland to evil tool.
> 
> 
> Diffs
> -
> 
>   startkde/startplasmacompositor.cmake 
> 8b5db615142455fd360c66504fc5d5a7754a029c 
> 
> Diff: https://git.reviewboard.kde.org/r/126107/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

[Martin Gräßlin]

> On Nov. 19, 2015, 8:22 a.m., Thomas Lübking wrote:
> > Is the full path required because of security concerns or because 
> > startplasmacompositor is broken (lacks proper environment setup)?

security concerns. Problem is that an env scripct (which are sourced for 
reasons by the login process):
alias kwin_wayland=kwin_evil_wayland

and the kwin_evil_wayland could do things like key logging.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126106/#review88567
---


On Nov. 19, 2015, 7:44 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126106/
> ---
> 
> (Updated Nov. 19, 2015, 7:44 a.m.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, and Matthias Klumpp.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> The absolute path is needed by e.g. startplasmacompositor.
> 
> 
> Diffs
> -
> 
>   KWinDBusInterfaceConfig.cmake.in 89a69032c27966c54dc40536355b35eb4692e426 
> 
> Diff: https://git.reviewboard.kde.org/r/126106/diff/
> 
> 
> Testing
> ---
> 
> installs with correct path
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

[Thomas Lübking]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126106/#review88569
---

Ship it!


Ship It!

- Thomas Lübking


On Nov. 19, 2015, 6:44 vorm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126106/
> ---
> 
> (Updated Nov. 19, 2015, 6:44 vorm.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, and Matthias Klumpp.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> The absolute path is needed by e.g. startplasmacompositor.
> 
> 
> Diffs
> -
> 
>   KWinDBusInterfaceConfig.cmake.in 89a69032c27966c54dc40536355b35eb4692e426 
> 
> Diff: https://git.reviewboard.kde.org/r/126106/diff/
> 
> 
> Testing
> ---
> 
> installs with correct path
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126107: Use absolute path to kwin_wayland

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126107/
---

Review request for Plasma, David Edmundson and Matthias Klumpp.


Repository: plasma-workspace


Description
---

This prevents possible attacks to replace kwin_wayland through a
sourced env variable script which aliases kwin_wayland to evil tool.


Diffs
-

  startkde/startplasmacompositor.cmake 8b5db615142455fd360c66504fc5d5a7754a029c 

Diff: https://git.reviewboard.kde.org/r/126107/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126106/
---

Review request for kwin, Plasma, David Edmundson, and Matthias Klumpp.


Repository: kwin


Description
---

The absolute path is needed by e.g. startplasmacompositor.


Diffs
-

  KWinDBusInterfaceConfig.cmake.in 89a69032c27966c54dc40536355b35eb4692e426 

Diff: https://git.reviewboard.kde.org/r/126106/diff/


Testing
---

installs with correct path


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126106/#review88563
---


Is it posssible to put it in seperate file? Because CMakeConfig is named as 
DBusInterface and no-one would expect it to have path to kwin_wayland.

- Bhushan Shah


On Nov. 19, 2015, 12:14 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126106/
> ---
> 
> (Updated Nov. 19, 2015, 12:14 p.m.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, and Matthias Klumpp.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> The absolute path is needed by e.g. startplasmacompositor.
> 
> 
> Diffs
> -
> 
>   KWinDBusInterfaceConfig.cmake.in 89a69032c27966c54dc40536355b35eb4692e426 
> 
> Diff: https://git.reviewboard.kde.org/r/126106/diff/
> 
> 
> Testing
> ---
> 
> installs with correct path
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

[Martin Gräßlin]

> On Nov. 19, 2015, 7:53 a.m., Bhushan Shah wrote:
> > Is it posssible to put it in seperate file? Because CMakeConfig is named as 
> > DBusInterface and no-one would expect it to have path to kwin_wayland.

well I used what we have. I'm open with introducing a new file or renaming 
after Plasma 5.5. release, but at the moment adding a new file here and 
changing in Plasma-workspace would technically be a new dependency after 
feature freeze.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126106/#review88563
---


On Nov. 19, 2015, 7:44 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126106/
> ---
> 
> (Updated Nov. 19, 2015, 7:44 a.m.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, and Matthias Klumpp.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> The absolute path is needed by e.g. startplasmacompositor.
> 
> 
> Diffs
> -
> 
>   KWinDBusInterfaceConfig.cmake.in 89a69032c27966c54dc40536355b35eb4692e426 
> 
> Diff: https://git.reviewboard.kde.org/r/126106/diff/
> 
> 
> Testing
> ---
> 
> installs with correct path
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

[Thomas Lübking]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126106/#review88567
---


Is the full path required because of security concerns or because 
startplasmacompositor is broken (lacks proper environment setup)?

- Thomas Lübking


On Nov. 19, 2015, 6:44 vorm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126106/
> ---
> 
> (Updated Nov. 19, 2015, 6:44 vorm.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, and Matthias Klumpp.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> The absolute path is needed by e.g. startplasmacompositor.
> 
> 
> Diffs
> -
> 
>   KWinDBusInterfaceConfig.cmake.in 89a69032c27966c54dc40536355b35eb4692e426 
> 
> Diff: https://git.reviewboard.kde.org/r/126106/diff/
> 
> 
> Testing
> ---
> 
> installs with correct path
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355560] Missing Breeze Cursor themes after update

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355560

--- Comment #2 from hotmusic...@mail.bg ---
I'll fill a bug in their Bugzilla and will link this one to it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel