Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 30 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/30/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 27 Jan 2017 06:35:35 +
Build duration: 18 min

CHANGE SET
Revision 50349ae9842d3a011a4ea9d5ea440a8668eea194 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit applets/trash/package/metadata.desktop
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1566/3802 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

[Differential] [Accepted] D4302: Clip by bounding delegate size instead of Item.clip.

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4302

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129872: [lookandfeel] Support changing window decoration

[Martin Gräßlin]

> On Jan. 25, 2017, 10:30 a.m., Martin Gräßlin wrote:
> > I don't understand. We already have support for this in 5.9?!?
> 
> Anthony Fieroni wrote:
> I made in same approach like other roles and i commit defaults (in blocks)
> 
> Martin Gräßlin wrote:
> But Marco already implemented that, didn't he? That's why I don't 
> understand your change.
> 
> Anthony Fieroni wrote:
> This is rebase over Marco's changes. If he told me to discard it i will, 
> for it's needed.

So I don't understand what your change does what Marco's change doesn't do 
already. What I see is that you rebased, but why and what for?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129872/#review102237
---


On Jan. 24, 2017, 9 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129872/
> ---
> 
> (Updated Jan. 24, 2017, 9 p.m.)
> 
> 
> Review request for Plasma, Kai Uwe Broulik, Hugo Pereira Da Costa, and Marco 
> Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   kcms/lookandfeel/autotests/kcmtest.cpp 29d6ec0f 
>   kcms/lookandfeel/autotests/lookandfeel/contents/defaults ef3165de 
>   kcms/lookandfeel/kcm.h c27b7f3d 
>   kcms/lookandfeel/kcm.cpp 6ea3d050 
> 
> Diff: https://git.reviewboard.kde.org/r/129872/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

[Differential] [Request, 163 lines] D4304: Split Keyboard Repeat handling into a dedicated InputEventSpy

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  So far the keyboard repeat handling was triggered directly from
  KeyboardInputRedirection::processKey. With the introduction of
  InputEventSpies it is no longer required to be done like that, we can
  split it out into a dedicated spy.
  
  This means that processKey only has to care about processing the key
  and allows us to better extend in future. So far keyboard repeat is
  only functional for libinput based platforms. But it should also be
  possible to use it in nested setups. By splitting it out we can
  prepare for that.

TEST PLAN
  Auto-test using repeat still passes

REPOSITORY
  R108 KWin

BRANCH
  keyboard-repeat

REVISION DETAIL
  https://phabricator.kde.org/D4304

AFFECTED FILES
  CMakeLists.txt
  keyboard_input.cpp
  keyboard_input.h
  keyboard_repeat.cpp
  keyboard_repeat.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, eliasp, sebas

Re: Review Request 129872: [lookandfeel] Support changing window decoration

[Anthony Fieroni]

> On Ян. 25, 2017, 11:30 преди обяд, Martin Gräßlin wrote:
> > I don't understand. We already have support for this in 5.9?!?
> 
> Anthony Fieroni wrote:
> I made in same approach like other roles and i commit defaults (in blocks)
> 
> Martin Gräßlin wrote:
> But Marco already implemented that, didn't he? That's why I don't 
> understand your change.

This is rebase over Marco's changes. If he told me to discard it i will, for 
it's needed.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129872/#review102237
---


On Ян. 24, 2017, 10 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129872/
> ---
> 
> (Updated Ян. 24, 2017, 10 след обяд)
> 
> 
> Review request for Plasma, Kai Uwe Broulik, Hugo Pereira Da Costa, and Marco 
> Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   kcms/lookandfeel/autotests/kcmtest.cpp 29d6ec0f 
>   kcms/lookandfeel/autotests/lookandfeel/contents/defaults ef3165de 
>   kcms/lookandfeel/kcm.h c27b7f3d 
>   kcms/lookandfeel/kcm.cpp 6ea3d050 
> 
> Diff: https://git.reviewboard.kde.org/r/129872/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 575 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/575/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 27 Jan 2017 04:58:39 +
Build duration: 6 min 18 sec

CHANGE SET
Revision 2f59ea042a09d3e1236d8cd20148deaf0f415c0a by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit applets/icontasks/metadata.desktop
  change: edit applets/trash/package/metadata.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

[Breeze] [Bug 373668] Lock Screen should warn when the keyboard status is not default (layout/capslock)

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=373668

--- Comment #18 from Kai Uwe Broulik  ---
It is. Look in the bottom left corner.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Request, 5 lines] D4302: Clip by bounding delegate size instead of Item.clip.

[Eike Hein]

hein created this revision.
hein added a reviewer: Plasma.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  - "Never enable clipping on a delegate." 
(http://doc.qt.io/qt-5/qtquick-performance.html) It mucks with the scene 
graph's ability to optimize draw order.
  
  - Also means window rects don't get cut off, their frames are nicely bounded. 
Technically this is a small information loss - you can't tell from the pager 
anymore when a window is going out of screen bounds - but it's visually rather 
pleasing.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4302

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 21 lines] D4301: [System Tray] SNI fallback to context menu on failing Activate

[Roman Gilg]

subdiff created this revision.
subdiff added reviewers: Plasma, davidedmundson.
subdiff set the repository for this revision to R120 Plasma Workspace.
subdiff added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This patch primarily is aimed at applications using libappindicator. For 
example:
  
  - Steam
  - Discord
  - Deluge
  
  libappindicator doesn't provide functionality for raising an application, but 
only a context menu. Since it also doesn't even provide the corresponding DBus 
method, we use the resulting error to try to display the context menu instead, 
which matches the behaviour on Unity and Gnome.
  
  https://www.gamingonlinux.com/forum/topic/2519
  https://bugs.kde.org/show_bug.cgi?id=375351

TEST PLAN
  Manually with libappindicator and Qt based tray icons.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4301

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  dataengines/statusnotifieritem/statusnotifieritemjob.cpp
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp
  dataengines/statusnotifieritem/statusnotifieritemsource.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Breeze] [Bug 373668] Lock Screen should warn when the keyboard status is not default (layout/capslock)

[David Heidelberg]

https://bugs.kde.org/show_bug.cgi?id=373668

David Heidelberg  changed:

   What|Removed |Added

 CC||da...@ixit.cz

--- Comment #17 from David Heidelberg  ---
guys, I'd like to add my 2 cents... I don't think that _keyboard layout_
indicator is visible on _lockscreen_. In Czech Republic is common to use US and
CS layout, so entering password is always guess which last layout I used... :(

Please add indicator in case there is more than one keyboard layout. (not
saying it's great to see battery percentage, but seeing layout would be even
better :D )

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Commented On] D3650: lower mouse acceleration limit to 0.0

[Harald Sitter]

sitter added a comment.


  That's not really answering my question now is it?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3650

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, plasma-devel
Cc: graesslin, broulik, jensreuterberg, lesliezhai, ali-mohamed, abetts, sebas

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

[Demitrius Belai]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126418/
---

(Updated Jan. 26, 2017, 9:30 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Hi,

This is same #105677 but for plasmapkg2


Diffs
-

  src/plasmapkg/plasmapkg.cpp 4626323cd5d1dc3a3147fe43102d901d615e0b66 

Diff: https://git.reviewboard.kde.org/r/126418/diff/


Testing
---


Thanks,

Demitrius Belai

[Differential] [Closed] D4279: proofread/update systemsettings docbook

[Burkhard Lück]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:2ddc4993caca: proofread/update systemsettings docbook 
(authored by lueck).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4279?vs=10546=10603

REVISION DETAIL
  https://phabricator.kde.org/D4279

AFFECTED FILES
  doc/index.docbook

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: lueck, #plasma, #documentation, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4299: Disable standard actions on VirtualKeyboard SNI

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  virtkeyboard-sni-no-standard-actions

REVISION DETAIL
  https://phabricator.kde.org/D4299

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, eliasp, sebas

[Differential] [Request, 1 line] D4299: Disable standard actions on VirtualKeyboard SNI

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  We don't want a context-menu entry to quit KWin.
  
  https://phabricator.kde.org/T5168

TEST PLAN
  No more context menu shown.

REPOSITORY
  R108 KWin

BRANCH
  virtkeyboard-sni-no-standard-actions

REVISION DETAIL
  https://phabricator.kde.org/D4299

AFFECTED FILES
  virtualkeyboard.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, eliasp, sebas

[Differential] [Commented On] D4298: [Color Picker] Add contrast frame around colors in popup

[Andreas Kainz]

andreaska added a comment.


  Look good to me +1

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D4298

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mart
Cc: andreaska, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Re: Review Request 129872: [lookandfeel] Support changing window decoration

[Martin Gräßlin]

> On Jan. 25, 2017, 10:30 a.m., Martin Gräßlin wrote:
> > I don't understand. We already have support for this in 5.9?!?
> 
> Anthony Fieroni wrote:
> I made in same approach like other roles and i commit defaults (in blocks)

But Marco already implemented that, didn't he? That's why I don't understand 
your change.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129872/#review102237
---


On Jan. 24, 2017, 9 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129872/
> ---
> 
> (Updated Jan. 24, 2017, 9 p.m.)
> 
> 
> Review request for Plasma, Kai Uwe Broulik, Hugo Pereira Da Costa, and Marco 
> Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   kcms/lookandfeel/autotests/kcmtest.cpp 29d6ec0f 
>   kcms/lookandfeel/autotests/lookandfeel/contents/defaults ef3165de 
>   kcms/lookandfeel/kcm.h c27b7f3d 
>   kcms/lookandfeel/kcm.cpp 6ea3d050 
> 
> Diff: https://git.reviewboard.kde.org/r/129872/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

[Differential] [Updated] D4293: [Task Manager] Show "Mark applications that play audio" option only if plasma-pa is available

[Eike Hein]

hein added a comment.


  Maybe greyout and suggest what to install?
  
  I'm actually fine with all three variants, but I think hiding it makes the 
support story harder - I imagine users talking and one can't find the check 
box, ...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4293

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: subdiff, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Closed] D4256: Support global shortcut to switch to specific layout

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:6b0b4cf46871: Support global shortcut to switch to 
specific layout (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4256?vs=10466=10600

REVISION DETAIL
  https://phabricator.kde.org/D4256

AFFECTED FILES
  keyboard_layout.cpp
  keyboard_layout.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, eliasp, sebas

[Differential] [Commented On] D3650: lower mouse acceleration limit to 0.0

[Martin Gräßlin]

graesslin added a comment.


  According to my comments in the Wayland port: the value 1.0 means no 
acceleration. Values below 1.0 mean a de-acceleration or a slow down. But it's 
still a factor. I'm also afraid that putting a 0.0 there could result in a 
devision by 0 value.
  
  So in any case your commit message does not match the actual reality. And 
given that I think you are trying to fix the wrong problem. Might it be that 
you use the libinput xorg driver? If yes, that's not yet supported and needs 
porting. But this change has potential of breaking the non-libinput xorg driver 
then.
  
  From my side something between -1 and -2 for this change.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3650

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, plasma-devel
Cc: graesslin, broulik, jensreuterberg, lesliezhai, ali-mohamed, abetts, sebas

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[Konstantin Shtepa]

konstantinshtepa added a comment.


  In https://phabricator.kde.org/D4204#80553, @davidedmundson wrote:
  
  > Though really any max > min on the client is undefined behaviour, so it's 
hard to say any is "right".
  
  
  You are right. It's undefined behaviour. At current state there is a hole in 
mechanis:
  
plasmoid.Layout.minimumHeight = 150
plasmoid.Layout.maximumHeight = 130
plasmoid.Layout.maximumHeight = 150
  
  because Qt wouldn't emit signal - Layout.minimumHeight is not changed. 
  But I don't think that it can be fixed, it's just how QML works, and it's a 
user job to be sure that at his end these values are alright.
  
  > Anyway, I think there's still room for improvements in this file overall 
(mostly with the existing structure), but for now I think this is good to go. 
I've been testing it for a day, seems to work fine. Including with RTL.
  
  Thanks!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  plasmoid_size_restraints

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, davidedmundson, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 305 lines] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[Konstantin Shtepa]

konstantinshtepa updated this revision to Diff 10599.
konstantinshtepa added a comment.


  Fixed littke bug which would happend with code
  
plasmoid.Layout.minimumHeight = 150
plasmoid.Layout.maximumHeight = 130
plasmoid.Layout.maximumHeight = 150
  
  Bug led to maximumHeight = 150 when minimumHeight would still be = 130

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4204?vs=10593=10599

BRANCH
  plasmoid_size_restraints

REVISION DETAIL
  https://phabricator.kde.org/D4204

AFFECTED FILES
  containments/desktop/package/contents/ui/AppletAppearance.qml
  containments/desktop/package/contents/ui/AppletHandle.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, davidedmundson, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 32 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/32/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 Jan 2017 16:18:15 +
Build duration: 14 min

CHANGE SET
Revision a9f5ada73bf86a145e057eff188f45dfdf61917a by David Edmundson: (When 
swapping Wallpapers, save the config to file, not just to)
  change: edit shell/containmentconfigview.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5947 
(39%)CONDITIONAL 1597/5894 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Closed] D4285: When swapping Wallpapers, save the config to file, not just to propertymap

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a9f5ada73bf8: When swapping Wallpapers, save the config 
to file, not just to propertymap (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4285?vs=10567=10598

REVISION DETAIL
  https://phabricator.kde.org/D4285

AFFECTED FILES
  shell/containmentconfigview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4290: [Calculator Runner] Use "approximate" approximation mode

[Marco Martin]

mart added a comment.


  ship it with "aproximate" text (and just 5.10)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4290

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma_workspaces
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4279: proofread/update systemsettings docbook

[Marco Martin]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D4279

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: lueck, #plasma, #documentation, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4285: When swapping Wallpapers, save the config to file, not just to propertymap

[Marco Martin]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4285

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4288: Add Kleopatra tray icon

[Marco Martin]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4288

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: guoyunhe, #plasma, mart
Cc: plasma-devel, guoyunhe, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D4298: [Color Picker] Add contrast frame around colors in popup

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:75fd9dda750c: [Color Picker] Add contrast frame around 
colors in popup (authored by broulik).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4298?vs=10596=10597

REVISION DETAIL
  https://phabricator.kde.org/D4298

AFFECTED FILES
  applets/colorpicker/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4298: [Color Picker] Add contrast frame around colors in popup

[Marco Martin]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D4298

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Heh, you're right that's what would happen. Though really any max > min on 
the client is undefined behaviour, so it's hard to say any is "right".
  
  Anyway, I think there's still room for improvements in this file overall 
(mostly with the existing structure), but for now I think this is good to go. 
I've been testing it for a day, seems to work fine. Including with RTL.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  plasmoid_size_restraints

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma, davidedmundson
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Request, 13 lines] D4298: [Color Picker] Add contrast frame around colors in popup

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R114 Plasma Addons.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This adds a frame around the color sections, makes it look a lot nicer and 
improves contrast.
  
  Since here the frame takes only a minor portion of surface area compared to 
the circle in a panel, I opted not to base it on luminosity, also for 
consistency's sake when there's 9 different colors in one view.

TEST PLAN
  F2181321: Screenshot_20170126_162502.png 

  
  F2181328: Screenshot_20170126_162519.png 


REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D4298

AFFECTED FILES
  applets/colorpicker/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D4224: [Color Picker] Add border around color if contrast to surrounding view is too little

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:ef3fd95a3257: [Color Picker] Add border around color if 
contrast to surrounding view is too… (authored by broulik).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4224?vs=10389=10595

REVISION DETAIL
  https://phabricator.kde.org/D4224

AFFECTED FILES
  applets/colorpicker/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 574 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/574/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 Jan 2017 15:05:05 +
Build duration: 16 min

CHANGE SET
Revision 5a938450bd742b395d24118be575531556958637 by Marco Martin: (fix 
autotest)
  change: edit kcms/lookandfeel/autotests/kcmtest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

[Differential] [Updated] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[Konstantin Shtepa]

konstantinshtepa updated the summary for this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 29 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/29/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 Jan 2017 15:05:50 +
Build duration: 6 min 6 sec

CHANGE SET
Revision 12697f13b6e4533668ff76e2ab65196435fbac64 by Marco Martin: (fix 
autotest)
  change: edit kcms/lookandfeel/autotests/kcmtest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1566/3802 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[Konstantin Shtepa]

konstantinshtepa added inline comments.

INLINE COMMENTS

> davidedmundson wrote in AppletAppearance.qml:445
> Edit, maybe it won't - that's why you have the separate Binding.
> 
> However changing this to:
> minimumWidth: Math.min(minimumSize.width, maximumSize.width);
> 
> for all 4
> 
> would still be a bit cleaner as then appletItem can trust these values are 
> correct

Ok, I removed bindings at cost of two additional handlers.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D4297: fix autotest

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5a938450bd74: fix autotest (authored by mart).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4297?vs=10592=10594

REVISION DETAIL
  https://phabricator.kde.org/D4297

AFFECTED FILES
  kcms/lookandfeel/autotests/kcmtest.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 297 lines] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[Konstantin Shtepa]

konstantinshtepa updated this revision to Diff 10593.
konstantinshtepa marked an inline comment as done.
konstantinshtepa added a comment.


  Removed Bindings

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4204?vs=10453=10593

BRANCH
  plasmoid_size_restraints

REVISION DETAIL
  https://phabricator.kde.org/D4204

AFFECTED FILES
  containments/desktop/package/contents/ui/AppletAppearance.qml
  containments/desktop/package/contents/ui/AppletHandle.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D4297: fix autotest

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  phab/test

REVISION DETAIL
  https://phabricator.kde.org/D4297

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 7 lines] D4297: fix autotest

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  now the look kcm actually checks for the colorscheme
  file existence. therefore the test has to make sure
  that such a file actually exists

TEST PLAN
  autotest works now

REPOSITORY
  R119 Plasma Desktop

BRANCH
  phab/test

REVISION DETAIL
  https://phabricator.kde.org/D4297

AFFECTED FILES
  kcms/lookandfeel/autotests/kcmtest.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 573 - Still unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/573/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 Jan 2017 14:18:24 +
Build duration: 18 min

CHANGE SET
Revision 9d66f0bc8ff8c2510445661e92abddcf4ff43e5e by kde: ([Task Manager] Focus 
last item when pressing up with no active item)
  change: edit applets/taskmanager/package/contents/ui/GroupDialog.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2274/3415 
(67%)CONDITIONAL 1528/3757 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 275/398 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

Plasma 5.9 tars available for packaging

[Jonathan Riddell]

Tars are on depot for packagers to package.  Release is due Tuesday middayish

Jonathan

[Differential] [Closed] D4282: Dialog: Hide when focus changes to ConfigView with hideOnWindowDeactivate

[David Rosca]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:d2c7435b1bc1: Dialog: Hide when focus changes to 
ConfigView with hideOnWindowDeactivate (authored by drosca).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4282?vs=10558=10590

REVISION DETAIL
  https://phabricator.kde.org/D4282

AFFECTED FILES
  src/plasmaquick/dialog.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, davidedmundson
Cc: hein, broulik, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D4292: [Task Manager] Focus last item when pressing up with no active item

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9d66f0bc8ff8: [Task Manager] Focus last item when 
pressing up with no active item (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4292?vs=10580=10589

REVISION DETAIL
  https://phabricator.kde.org/D4292

AFFECTED FILES
  applets/taskmanager/package/contents/ui/GroupDialog.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hein, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: khotkeys Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 4 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khotkeys%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/4/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 Jan 2017 13:37:38 +
Build duration: 8 min 22 sec

CHANGE SET
Revision 617de4bd3fd080d43cce9bdc8af82963960d5c3a by David Edmundson: (Fix 
build with -fno-operator-names)
  change: edit kcm_hotkeys/hotkeys_model.cpp
  change: edit libkhotkeysprivate/action_data/action_data_group.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Jenkins-kde-ci: khotkeys Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 4 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khotkeys%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/4/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 Jan 2017 13:37:38 +
Build duration: 8 min 22 sec

CHANGE SET
Revision 617de4bd3fd080d43cce9bdc8af82963960d5c3a by David Edmundson: (Fix 
build with -fno-operator-names)
  change: edit kcm_hotkeys/hotkeys_model.cpp
  change: edit libkhotkeysprivate/action_data/action_data_group.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Jenkins-kde-ci: khotkeys Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 3 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/khotkeys%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/3/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 Jan 2017 13:22:53 +
Build duration: 6 min 27 sec

CHANGE SET
No changes

[Differential] [Accepted] D4282: Dialog: Hide when focus changes to ConfigView with hideOnWindowDeactivate

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4282

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, davidedmundson
Cc: hein, broulik, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D4281: [Task Manager] Limit context menu width

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4281

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hein, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4292: [Task Manager] Focus last item when pressing up with no active item

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4292

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hein, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4256: Support global shortcut to switch to specific layout

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.

BRANCH
  keyboard-layout-per-layout-shortcut

REVISION DETAIL
  https://phabricator.kde.org/D4256

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, eliasp, sebas

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

[Demitrius Belai]

> On Jan. 21, 2017, 12:44 a.m., Albert Astals Cid wrote:
> > Unfortunately noone commited this patch and doesn't apply anymore, could 
> > you update it?
> 
> Demitrius Belai wrote:
> Sure. I have to submit new request review because the PackageStructure 
> plugin for kpackagetool5 must be in the kwin repository.

Done! #129891


- Demitrius


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126418/#review102134
---


On Dez. 18, 2015, 6:30 p.m., Demitrius Belai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126418/
> ---
> 
> (Updated Dez. 18, 2015, 6:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Hi,
> 
> This is same #105677 but for plasmapkg2
> 
> 
> Diffs
> -
> 
>   src/plasmapkg/plasmapkg.cpp 4626323cd5d1dc3a3147fe43102d901d615e0b66 
> 
> Diff: https://git.reviewboard.kde.org/r/126418/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Demitrius Belai
> 
>

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 31 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/31/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 Jan 2017 11:10:23 +
Build duration: 16 min

CHANGE SET
Revision b5d729567a0673698bbc45f0b1a3b02dc020a2fe by Jonathan Riddell: (Update 
version number for 5.9.0 GIT_SILENT)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5947 
(39%)CONDITIONAL 1597/5894 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Commented On] D4293: [Task Manager] Show "Mark applications that play audio" option only if plasma-pa is available

[Roman Gilg]

subdiff added a comment.


  Set enable property instead of visible (and always uncheck in case Plasma-pa 
not avail)?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4293

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: subdiff, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 28 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/28/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 Jan 2017 11:08:43 +
Build duration: 17 min

CHANGE SET
Revision 0907765892828d446db4a81a136cdbbcf254b928 by Jonathan Riddell: (Update 
version number for 5.9.0 GIT_SILENT)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2274/3415 
(67%)CONDITIONAL 1548/3798 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 275/398 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

[Differential] [Request, 1 line] D4293: [Task Manager] Show "Mark applications that play audio" option only if plasma-pa is available

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Everywhere else the code assumes plasma-pa might not be around but the config 
dialog would still show the check box unconditionally. Plasma-pa is not a 
dependency for Plasma-desktop and you can safely uninstall it (if you prefer 
e.g. kmix), so we should cover this case.

TEST PLAN
  Uninstalled plasma-pa, setting was gone
  Re-installed plasma-pa, setting was there again

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4293

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-tests Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 2 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-tests%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 Jan 2017 11:09:53 +
Build duration: 59 sec

CHANGE SET
Revision 8b1686c06d1fc66fa32960535fb02e7c95daf453 by Jonathan Riddell: (Update 
version number for 5.9.0 GIT_SILENT)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 
test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Jenkins-kde-ci: khotkeys Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 2 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/khotkeys%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 Jan 2017 11:04:28 +
Build duration: 52 sec

CHANGE SET
Revision b0525a3b0de729299a4840359f91e38897c6d841 by Jonathan Riddell: (Update 
version number for 5.9.0 GIT_SILENT)
  change: edit CMakeLists.txt

[Differential] [Accepted] D4291: [KRunner] In doubt use primary screen for view position

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4291

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

[Demitrius Belai]

> On Jan. 21, 2017, 12:44 a.m., Albert Astals Cid wrote:
> > Unfortunately noone commited this patch and doesn't apply anymore, could 
> > you update it?

Sure. I have to submit new request review because the PackageStructure plugin 
for kpackagetool5 must be in the kwin repository.


- Demitrius


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126418/#review102134
---


On Dez. 18, 2015, 6:30 p.m., Demitrius Belai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126418/
> ---
> 
> (Updated Dez. 18, 2015, 6:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Hi,
> 
> This is same #105677 but for plasmapkg2
> 
> 
> Diffs
> -
> 
>   src/plasmapkg/plasmapkg.cpp 4626323cd5d1dc3a3147fe43102d901d615e0b66 
> 
> Diff: https://git.reviewboard.kde.org/r/126418/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Demitrius Belai
> 
>

[Differential] [Request, 5 lines] D4292: [Task Manager] Focus last item when pressing up with no active item

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This way when opening a group with no active window, we start at the bottom 
of the list and work our way up, makes it consistent with virtually any other 
list. Especially since when we start at the top, the next key press would wrap 
around anyway.

TEST PLAN
  Opened task manager group where there is no active window, pressed up key. 
Ended up focusing the last item like I would in e.g. Kickoff.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4292

AFFECTED FILES
  applets/taskmanager/package/contents/ui/GroupDialog.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4290: [Calculator Runner] Use "approximate" approximation mode

[Kai Uwe Broulik]

broulik added a comment.


  Probably needs some indication that the result is approximate:
  
  When `result.isApproximate()` returns true I'll add a (approximation) suffix 
or something like this – can't go into 5.9 then.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4290

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma_workspaces
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D4288: Add Kleopatra tray icon

[Yunhe Guo]

guoyunhe updated the summary for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4288

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: guoyunhe, #plasma
Cc: plasma-devel, guoyunhe, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated] D4290: [Calculator Runner] Use "approximate" approximation mode

[Kai Uwe Broulik]

broulik updated the test plan for this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4290

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma_workspaces
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D4290: [Calculator Runner] Use "approximate" approximation mode

[Kai Uwe Broulik]

broulik updated the test plan for this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4290

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma_workspaces
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 16 lines] D4291: [KRunner] In doubt use primary screen for view position

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Seems this logic of screen with cursor may break with XRandR scaling.
  
  BUG: 375574
  FIXED-IN: 5.8.6

TEST PLAN
  Still shows up on the right screen

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4291

AFFECTED FILES
  krunner/view.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 30 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/30/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 Jan 2017 09:14:18 +
Build duration: 15 min

CHANGE SET
Revision 83719920b2c811b4f5c9279994b76a072ceaa521 by kde: ([Icon Applet] Use 
KIO::statJob to work with remote URLs)
  change: edit applets/icon/package/contents/ui/main.qml
  change: edit applets/icon/iconapplet.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5947 
(39%)CONDITIONAL 1597/5894 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Commented On] D3650: lower mouse acceleration limit to 0.0

[Harald Sitter]

sitter added a comment.


  Do I need to do something to get this moving forward?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3650

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, plasma-devel
Cc: graesslin, broulik, jensreuterberg, lesliezhai, ali-mohamed, abetts, sebas

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 704 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/704/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 Jan 2017 09:18:43 +
Build duration: 6 min 13 sec

CHANGE SET
Revision e47a5c96783453d974404f80853dccea9bd10389 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit templates/ion-dataengine/ion-dataengine.kdevtemplate
Revision f5bf988c5bd50ec0d39e4ca4ad19ea3b25a4fbf5 by hein: (Fix group parents 
not appearing when disabling inline grouping.)
  change: edit libtaskmanager/tasksmodel.cpp
Revision 3b44f2e50a36ab57da296703ea342faf22163d45 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit templates/ion-dataengine/ion-dataengine.kdevtemplate
Revision 83719920b2c811b4f5c9279994b76a072ceaa521 by kde: ([Icon Applet] Use 
KIO::statJob to work with remote URLs)
  change: edit applets/icon/package/contents/ui/main.qml
  change: edit applets/icon/iconapplet.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5947 
(39%)CONDITIONAL 1597/5894 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

[Differential] [Request, 4 lines] D4290: [Calculator Runner] Use "approximate" approximation mode

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma: Workspaces.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The runner calculator isn't entitled for being a scientifically correct 
calculator.
  This keeps seemingly innocent calculations such as "2^0.3" from 
eating all RAM until it crashes.
  
  BUG: 277011
  FIXED-IN: 5.9.1

TEST PLAN
  Upstream issue https://github.com/Qalculate/libqalculate/issues/16
  
  I'll also investigate how to have krunner cancel calculations once the runner 
context becomes invalid.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4290

AFFECTED FILES
  runners/calculator/qalculate_engine.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma_workspaces
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:83719920b2c8: [Icon Applet] Use KIO::statJob to work with 
remote URLs (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4157?vs=10535=10576

REVISION DETAIL
  https://phabricator.kde.org/D4157

AFFECTED FILES
  applets/icon/iconapplet.cpp
  applets/icon/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 0 lines] D4288: Add Kleopatra tray icon

[Yunhe Guo]

guoyunhe created this revision.
guoyunhe added a reviewer: Plasma.
guoyunhe set the repository for this revision to R242 Plasma Framework 
(Library).
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Add Kleopatra tray icon.
  
  F2167935: Screenshot_20170126_102312.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4288

AFFECTED FILES
  src/desktoptheme/breeze/icons/kleopatra.svgz

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: guoyunhe, #plasma
Cc: plasma-devel, guoyunhe, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4157

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas