[Differential] [Updated, 8 lines] D2843: Fix method that calls itself recursively
davidedmundson updated this revision to Diff 6889. davidedmundson added a comment. fix phab getting excited REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2843?vs=6888=6889 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2843 AFFECTED FILES wallpapers/image/image.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 17 lines] D2843: Fix method that calls itself recursively
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Read the code. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2843 AFFECTED FILES klipper/clipcommandprocess.h runners/windows/windowsrunner.cpp systemmonitor/kdedksysguard.cpp systemmonitor/kdedksysguard.h wallpapers/image/image.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 364 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/364/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 23 Sep 2016 01:24:24 + Build duration: 8 min 46 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2275/3386 (67%)CONDITIONAL 1532/3733 (41%) By packages kcms.cursortheme.xcursor FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 22/98 (22%) kcms.keyboard FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 (49%)CONDITIONAL 600/1672 (36%) kcms.keyboard.preview FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 431/1110 (39%) kcms.keyboard.tests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 236/358 (66%) kcms.krdb FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 108/196 (55%) kcms.lookandfeel FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 83/195 (43%) kcms.lookandfeel.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 (100%)CONDITIONAL 52/104 (50%)
Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 364 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/364/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 23 Sep 2016 01:24:24 + Build duration: 8 min 46 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2275/3386 (67%)CONDITIONAL 1532/3733 (41%) By packages kcms.cursortheme.xcursor FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 22/98 (22%) kcms.keyboard FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 (49%)CONDITIONAL 600/1672 (36%) kcms.keyboard.preview FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 431/1110 (39%) kcms.keyboard.tests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 236/358 (66%) kcms.krdb FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 108/196 (55%) kcms.lookandfeel FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 83/195 (43%) kcms.lookandfeel.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 (100%)CONDITIONAL 52/104 (50%)
Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 363 - Still Failing!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/363/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 23 Sep 2016 01:17:55 + Build duration: 3 min 34 sec CHANGE SET No changes
Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 362 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/362/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 23 Sep 2016 01:08:32 + Build duration: 2 min 36 sec CHANGE SET Revision 5d3f0d2a15598c8d470682ec7266710516ba4637 by David Edmundson: (Add metadata license to appstream) change: edit org.kde.plasmashell.metainfo.xml
Re: Review Request 128997: Fix most obvious clazy and clang warnings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128997/ --- (Updated Sept. 23, 2016, 1:05 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit f684124287e0b6f108688317616479feeb9c2099 by Aleix Pol on behalf of Aleix Pol Gonzalez to branch Plasma/5.8. Repository: plasma-workspace Description --- Should be ok, would like your +1 nevertheless. Diffs - applets/digital-clock/plugin/timezonemodel.cpp efd4eb2 applets/notifications/plugin/notificationshelper.h 066048e appmenu/appmenu.cpp bb2e7f5 components/shellprivate/interactiveconsole/interactiveconsole.cpp 12f0bb0 components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels.cpp 2560d5d components/shellprivate/widgetexplorer/widgetexplorer.cpp be5c9dc dataengines/apps/appsengine.cpp 81e8ce5 dataengines/geolocation/geolocation.cpp 38e106c dataengines/share/shareengine.cpp 039777d dataengines/weather/ions/noaa/ion_noaa.cpp 40dcd46 drkonqi/parser/backtraceparser.h 9728e20 klipper/clipcommandprocess.cpp b6631b5 klipper/editactiondialog.cpp afd7d3e klipper/klipper.cpp 525ef87 krunner/dialog.h a34152a kuiserver/progresslistdelegate.h 0fa3d6f libtaskmanager/abstracttasksmodel.h cb6e74f libtaskmanager/abstracttasksproxymodeliface.h 4c627f1 libtaskmanager/activityinfo.cpp 8427cfd libtaskmanager/flattentaskgroupsproxymodel.cpp 8b02d57 libtaskmanager/taskfilterproxymodel.cpp b2cd2b1 libtaskmanager/tasksmodel.h 1a7eb2c libtaskmanager/waylandtasksmodel.cpp 458a0c8 plasma-windowed/main.cpp de3dff8 runners/bookmarks/browsers/chrome.cpp 9d5e6e9 runners/bookmarks/browsers/chromefindprofile.cpp 925083a runners/bookmarks/faviconfromblob.cpp 77512eb runners/kill/killrunner.cpp a7a7a01 runners/shell/shellrunner.h 29d5d3c runners/webshortcuts/webshortcutrunner.cpp 1ad6677 shell/alternativeshelper.cpp a96b266 shell/containmentconfigview.cpp 3ae2985 shell/desktopview.h f72add1 shell/panelview.h 36c414e shell/scripting/scriptengine_v1.cpp ab33bf5 shell/shellcorona.cpp 25e0378 wallpapers/image/backgroundlistmodel.cpp 8130b1c wallpapers/image/image.h c488a84 wallpapers/image/image.cpp ea66733 Diff: https://git.reviewboard.kde.org/r/128997/diff/ Testing --- Thanks, Aleix Pol Gonzalez
[Differential] [Request, 2 lines] D2842: Add kinfocenter to the computer tab of Kickoff
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 368080 REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2842 AFFECTED FILES applets/kickoff/package/contents/config/main.xml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 1 line] D2841: Don't load system apps model twice
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The system apps model is set from QML via ComputerModel::setSystemApplications This is always called from Kickoff, and Kickoff is the only user of this class. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2841 AFFECTED FILES applets/kicker/plugin/computermodel.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 361 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/361/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 23 Sep 2016 00:44:42 + Build duration: 9 min 34 sec CHANGE SET Revision edd8a0af680a2e21a05959b34766ebe5f3c78501 by David Edmundson: (Don#039;t end summary with a fullstop.) change: edit org.kde.plasmashell.metainfo.xml Revision b735ab043a741d9ea6b91da5e6edef98ea3eff57 by David Edmundson: (Fix call to missing function) change: edit applets/kickoff/package/contents/ui/KickoffItem.qml JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: TestSuite.appstreamtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2275/3386 (67%)CONDITIONAL 1532/3733 (41%) By packages kcms.cursortheme.xcursor FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 22/98 (22%) kcms.keyboard FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 (49%)CONDITIONAL 600/1672 (36%) kcms.keyboard.preview FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 431/1110 (39%) kcms.keyboard.tests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 236/358 (66%) kcms.krdb FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 108/196 (55%) kcms.lookandfeel FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 83/195 (43%) kcms.lookandfeel.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 (100%)CONDITIONAL 52/104 (50%)
[Differential] [Closed] D2836: Enable high DPI support in KCMShell
This revision was automatically updated to reflect the committed changes. Closed by commit rKDECLITOOLS91dd63abce3e: Enable high DPI support in KCMShell (authored by davidedmundson). REPOSITORY rKDECLITOOLS KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2836?vs=6877=6884 REVISION DETAIL https://phabricator.kde.org/D2836 AFFECTED FILES kcmshell/main.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D2838: Fix memory leak + cleanup in projecthandlertest
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMASDKb78aceee04f4: Fix memory leak + cleanup in projecthandlertest (authored by davidedmundson). REPOSITORY rPLASMASDK Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2838?vs=6879=6883 REVISION DETAIL https://phabricator.kde.org/D2838 AFFECTED FILES plasmate/app/tests/projecthandlertest.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D2838: Fix memory leak + cleanup in projecthandlertest
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMASDK Plasma SDK BRANCH master REVISION DETAIL https://phabricator.kde.org/D2838 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D2836: Enable high DPI support in KCMShell
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKDECLITOOLS KDE CLI Utilities BRANCH master REVISION DETAIL https://phabricator.kde.org/D2836 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: Review Request 118865: [startkde from plasma next] create ~/.kde directory if it doesn't exist
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118865/
---
(Updated Sept. 22, 2016, 8:40 p.m.)
Status
--
This change has been discarded.
Review request for Plasma.
Repository: plasma-workspace
Description
---
Hi,
I have been working a bit in kubuntu's plasma packaging, when I started plasma
from a fresh new account I noticed I couldn't see most icons in the GUI's
except for a few ones.
So I checked the starkde output to try to find out what was wrong, I found a
line like this one:
static QPlatformTheme* QKdeTheme::createKdeTheme(): Unable to determine KDEHOME
Digging a bit more into the issue I also found out where this message comes
from.
File src/platformsupport/themes/genericunix/qgenericunixthemes.cpp (Qt 5.3.0)
lines 446-468:
QPlatformTheme *QKdeTheme::createKdeTheme()
{
// Check for version >= 4 and determine home folder from environment,
// defaulting to ~/.kde, ~/.kde
const QByteArray kdeVersionBA = qgetenv("KDE_SESSION_VERSION");
const int kdeVersion = kdeVersionBA.toInt();
if (kdeVersion < 4)
return 0;
const QString kdeHomePathVar = QString::fromLocal8Bit(qgetenv("KDEHOME"));
if (!kdeHomePathVar.isEmpty())
return new QKdeTheme(kdeHomePathVar, kdeVersion);
const QString kdeVersionHomePath = QDir::homePath() +
QStringLiteral("/.kde") + QLatin1String(kdeVersionBA);
if (QFileInfo(kdeVersionHomePath).isDir())
return new QKdeTheme(kdeVersionHomePath, kdeVersion);
const QString kdeHomePath = QDir::homePath() + QStringLiteral("/.kde");
if (QFileInfo(kdeHomePath).isDir())
return new QKdeTheme(kdeHomePath, kdeVersion);
qWarning("%s: Unable to determine KDEHOME", Q_FUNC_INFO);
return 0;
}
So I'm inclined to think the ~/.kde directory should be created if it doesn't
exist, thats what the patch does. What do you think?
Diffs
-
startkde/startkde.cmake ea0bdfe
Diff: https://git.reviewboard.kde.org/r/118865/diff/
Testing
---
Applied a similar patch in a customized kubuntu package. With the patch the
~/.kde directory is created and the icons can be seen.
Thanks,
José Manuel Santamaría Lema
Re: Review Request 117750: populate the konsole and enable it by default in plasmoidviewer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117750/#review99467 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On April 24, 2014, 6:24 p.m., Giorgos Tsiapaliokas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117750/ > --- > > (Updated April 24, 2014, 6:24 p.m.) > > > Review request for Plasma. > > > Repository: plasma-sdk > > > Description > --- > > populate the konsole and enable it by default in plasmoidviewer > > we add a custom message handler which will print all the output to > stdout and also it will check from debug messages which come from > the category "qml" and those which are coming from QML > > > Diffs > - > > plasmoidviewer/main.cpp 009acbbe7591b03487913cb1316d5f61e6a2b500 > plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml > d99c8cd8ebfbbe27ca04ba30c7a2bbe396d1a064 > plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml > 34db7f6fc6a04ce96cd307455ff15abe6697f194 > plasmoidviewer/view.h d997f15d093584f4446bbdb3475c30c98441e728 > plasmoidviewer/view.cpp aa8914539358b216b9641da679050f95ba5af512 > > Diff: https://git.reviewboard.kde.org/r/117750/diff/ > > > Testing > --- > > > File Attachments > > > plasmoidviewer_message > > https://git.reviewboard.kde.org/media/uploaded/files/2014/04/24/8ad4291f-c8b8-4378-8ab0-0330bb01d454__plasmoidviewer_msghandler_reviewboard_ok.png > > > Thanks, > > Giorgos Tsiapaliokas > >
Re: Review Request 126640: [WindowThumbnail] Discard pixmap on map events.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126640/ --- (Updated Sept. 22, 2016, 8:44 p.m.) Status -- This change has been marked as submitted. Review request for kwin and Plasma. Repository: plasma-framework Description --- According to [X.org docs](http://www.x.org/releases/X11R7.7/doc/compositeproto/compositeproto.txt) regarding NameWindowPixmap: "This pixmap will remain allocated until freed, even if 'window' is unmapped, reconfigured or destroyed. However, 'window' will get a new pixmap allocated each time it is mapped or resized, so this request will need to be reinvoked" So, pixmap needs to be discarded not only on XCB_CONFIGURE_NOTIFY event but on XCB_MAP_NOTIFY event also. Diffs - src/declarativeimports/core/windowthumbnail.cpp 21e655e Diff: https://git.reviewboard.kde.org/r/126640/diff/ Testing --- Tested by using simple qml app with WindowThumbnail and minimizing\unminimizing of corresponding window. Now after unminimizing pixmap is still valid and live updating works. Thanks, Mihail Ivchenko
Re: Review Request 117615: Implementation of Search in Local Browsing in Plasma Media Center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117615/ --- (Updated Sept. 22, 2016, 8:39 p.m.) Status -- This change has been discarded. Review request for Plasma, Akshay Ratan, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- I have implemented the local browsing search only to the Videos section as of now, but the application crashes, and it searches on the drive selection window, but doesn't search on the folder and file selection window after that. Please look into it and suggest where I am going wrong. Once this is done, it's the same implementation for images and songs. I would do that similarly. Diffs - browsingbackends/localfiles/localfilesabstractbackend.h 2d47eba browsingbackends/localfiles/localfilesabstractbackend.cpp b86a28a browsingbackends/localfiles/localvideos/localvideosbackend.h ce92a9e browsingbackends/localfiles/localvideos/localvideosbackend.cpp 8c20f27 Diff: https://git.reviewboard.kde.org/r/117615/diff/ Testing --- Errors yet there so testing on hold. Thanks, Harshit Agarwal
Re: Review Request 117139: Make menu strings conform to KDE's usability guidelines. Capitalize menu words.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117139/ --- (Updated Sept. 22, 2016, 8:43 p.m.) Status -- This change has been discarded. Review request for Plasma and Shantanu Tushar. Repository: plasma-mediacenter Description --- This patch is created to provide uniform string format to pmc according to our Visual Design Group's guidelines ( http://techbase.kde.org/Projects/Usability/HIG/Capitalization ). All menu strings are converted so words start with capital letter. Diffs - browsingbackends/localfiles/localmusic/localmusic.desktop ab47666 browsingbackends/localfiles/localpictures/localpictures.desktop 4ffe275 browsingbackends/localfiles/localvideos/localvideos.desktop 4f22968 browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.desktop 93b7c62 browsingbackends/metadatabackends/metadatapicturebackend/metadatapicturebackend.desktop a06a168 browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop 9d04068 browsingbackends/onlineservices/youtube/youtubebackend.desktop 4b3ba9c browsingbackends/utility/fullscreen/pmcfullscreen.desktop c992932 Diff: https://git.reviewboard.kde.org/r/117139/diff/ Testing --- Thanks, Nikolaos Chatzidakis
Re: Review Request 120306: Exclude X11 when building for Wayland
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120306/#review99474 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On Sept. 21, 2014, 2:50 p.m., Pier Luigi Fiorini wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120306/ > --- > > (Updated Sept. 21, 2014, 2:50 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Exclude X11 when building for Wayland > > > Diffs > - > > CMakeLists.txt d9c78cf4ccc0ba8a37a2b43840a6867a9092d646 > src/plasma/config-plasma.h.cmake ed14e7aa28835599f3a40ea1aff32d347f33a16c > > Diff: https://git.reviewboard.kde.org/r/120306/diff/ > > > Testing > --- > > > Thanks, > > Pier Luigi Fiorini > >
Re: Review Request 112812: Use type description sort order in devicenotifier when non-removable devices are displayed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112812/ --- (Updated Sept. 22, 2016, 8:35 p.m.) Status -- This change has been discarded. Review request for Plasma. Bugs: 324459 http://bugs.kde.org/show_bug.cgi?id=324459 Repository: kde-workspace Description --- Use type description sort order in the devicenotifier applet when non-removable devices are configured to be displayed. This avoids apparently random sort order (by device engine population timestamp) and unneccessary ListView sections. The problem becomes apparent if other types of devices besides simple storage volumes are configured in /etc/fstab, like for example network mounts. Fixes bug #324459. Diffs - plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml 9b6132e Diff: https://git.reviewboard.kde.org/r/112812/diff/ Testing --- Works for me using KDE 4.10.5 packaged with Fedora 19. Thanks, Benedikt Gollatz
Re: Review Request 120306: Exclude X11 when building for Wayland
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120306/ --- (Updated Sept. 22, 2016, 8:43 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Exclude X11 when building for Wayland Diffs - CMakeLists.txt d9c78cf4ccc0ba8a37a2b43840a6867a9092d646 src/plasma/config-plasma.h.cmake ed14e7aa28835599f3a40ea1aff32d347f33a16c Diff: https://git.reviewboard.kde.org/r/120306/diff/ Testing --- Thanks, Pier Luigi Fiorini
Re: Review Request 117494: Proposed Patch for Bug 198661 - Add option to disable scroll on taskbar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117494/#review99473 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On April 11, 2014, 5:38 a.m., Olexa Bilaniuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117494/ > --- > > (Updated April 11, 2014, 5:38 a.m.) > > > Review request for Plasma. > > > Bugs: 198661 > https://bugs.kde.org/show_bug.cgi?id=198661 > > > Repository: plasma-desktop > > > Description > --- > > Patch against plasma-desktop git master rev. > ba6f2d7c054e7cdc1013c03a3f0821e8e328329b, fixing Bug 198661 - Add option to > disable scroll on taskbar. > > This patch adds a new checkbox under Task Manager Settings > General and a > corresponding property called enableMouseScroll, with the default set to True > (the current default). This property is checked on every onWheelMoved event, > and only if true does it permit scrolling. > > > Diffs > - > > applets/taskmanager/package/contents/config/main.xml 1a8fe8a > applets/taskmanager/package/contents/ui/ConfigGeneral.qml 114f88a > applets/taskmanager/package/contents/ui/MouseHandler.qml 124e4c9 > applets/taskmanager/package/contents/ui/Task.qml b6c3539 > > Diff: https://git.reviewboard.kde.org/r/117494/diff/ > > > Testing > --- > > Don't know how to test. However, patch is trivially small; problems should be > eyeballable. > > > Thanks, > > Olexa Bilaniuk > >
Re: Review Request 112208: KMix qml applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/ --- (Updated Sept. 22, 2016, 8:41 p.m.) Status -- This change has been discarded. Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko. Repository: kmix Description --- KMix qml applet. As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :) Differences from the old kmix tray: * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in); * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm; Known issues: * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume; * no scroll events over the sliders too; * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well. * resize doesn't work properly. Diffs - plasma/kmix-applet-qml/contents/ui/ButtonBar.qml 1467957 plasma/kmix-applet-qml/contents/ui/kmixapplet.qml 6c09359 Diff: https://git.reviewboard.kde.org/r/112208/diff/ Testing --- Tested against master and works fine. File Attachments Default look https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png Menu Actions https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png Applet Config Options https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png Vertical Control https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png ToolButton label and Config page after updates https://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png Control Icon and Label left aligned https://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png Kmix, horizontal view https://git.reviewboard.kde.org/media/uploaded/files/2014/05/04/9d6b0ca4-5a75-45cc-ab8e-61b13d4079e6__kmix_horizontal_new.png Kmix applet, vertical view https://git.reviewboard.kde.org/media/uploaded/files/2014/05/04/7efb308a-c306-47c2-883f-64d1f32db5b5__kmix_vertical_new.png Thanks, Diego Casella
Re: Review Request 120248: Override the implicitSizes in the ruler completley
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120248/ --- (Updated Sept. 22, 2016, 8:36 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-desktop Description --- Override the implicitSizes in the ruler completley Needed to fix: https://gerrit.vesnicky.cesnet.cz/r/#/c/41/2 Though I think that change was correct (and so is this one) Diffs - desktoppackage/contents/configuration/panelconfiguration/Ruler.qml 6cdccc9 Diff: https://git.reviewboard.kde.org/r/120248/diff/ Testing --- Thanks, David Edmundson
Re: Review Request 112208: KMix qml applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/#review99472 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On Aug. 22, 2014, 8:26 a.m., Diego Casella wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/112208/ > --- > > (Updated Aug. 22, 2014, 8:26 a.m.) > > > Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and > Igor Poboiko. > > > Repository: kmix > > > Description > --- > > KMix qml applet. > As you can see from the screenshot, the applet is pretty much functional: you > can display all the controls available, change its orientation, and decide to > whether show all of them or just the Master Control, and refresh its status > when new controls are added/removed/updated (such as Amarok current playing > track). See screenshots below :) > Differences from the old kmix tray: > * no media player controls ( I never investigated how to get them, but > honestly opening the audio applet to change/skip/pause audio track makes > little sense to me ... if anyone wants this feature back, don't be shy and > step in); > * the button used to select which Mixers are visible has been changed to open > Phonon kcm page: since visible mixers are already configurable from KMix app, > having a button to show KMix *and* a button to modify Mixers visibilty made > little sense here too, so I preferred to give more visibility to Phonon kcm; > > Known issues: > * there is still no way to get notified of mouse wheel events over the > popupIcon, so it is not possible to scroll over to increase/decrease the > master control volume; > * no scroll events over the sliders too; > * if you want to use the applet you most likely will disable KMix tray icon > but, if you do so, KMix will show its GUI at every login and you have to > close it manually. This requires KMix to be patched. Furthermore, if you > click "KMix Setup" button, KMix window will not restored anymore: this needs > to be pathed as well. > * resize doesn't work properly. > > > Diffs > - > > plasma/kmix-applet-qml/contents/ui/ButtonBar.qml 1467957 > plasma/kmix-applet-qml/contents/ui/kmixapplet.qml 6c09359 > > Diff: https://git.reviewboard.kde.org/r/112208/diff/ > > > Testing > --- > > Tested against master and works fine. > > > File Attachments > > > Default look > > https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png > Menu Actions > > https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png > Applet Config Options > > https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png > Vertical Control > > https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png > ToolButton label and Config page after updates > > https://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png > Control Icon and Label left aligned > > https://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png > Kmix, horizontal view > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/04/9d6b0ca4-5a75-45cc-ab8e-61b13d4079e6__kmix_horizontal_new.png > Kmix applet, vertical view > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/04/7efb308a-c306-47c2-883f-64d1f32db5b5__kmix_vertical_new.png > > > Thanks, > > Diego Casella > >
Re: Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119025/ --- (Updated Sept. 22, 2016, 8:40 p.m.) Status -- This change has been discarded. Review request for kde-workspace, Plasma and Hui Ni. Repository: kimtoy Description --- The ibus-panel can't build on OpenBSD because some required definitions obtained from pkgconfig file are not used. This happens due to the following reasons: 1. IBUS_DEFINITIONS is not used in ibus-panel/CMakeLists.txt 2. IBUS_DEFINITIONS is not saved in cache, and thus isn't available at compile time This patch resolves both issues and makes ibus-panel compile on OpenBSD. (I found no suitable review group and therefore used "plasma" instead, as it was in "plasma-addons" previously; please, feel free to correct me if I'm wrong and sorry for any possible inconvenience) ((as there was no feedback for more than a week, I've added "kde-workspace" group to list of reviewers, too)) Diffs - ibus-panel/CMakeLists.txt 3a1ee49 Diff: https://git.reviewboard.kde.org/r/119025/diff/ Testing --- OpenBSD/i386-CURRENT, KDE 4.13 (it doesn't have kimtoy package, of course, but the code is same) Thanks, Vadim Zhukov
Re: Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119025/#review99471 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On July 19, 2014, 6:43 p.m., Vadim Zhukov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119025/ > --- > > (Updated July 19, 2014, 6:43 p.m.) > > > Review request for kde-workspace, Plasma and Hui Ni. > > > Repository: kimtoy > > > Description > --- > > The ibus-panel can't build on OpenBSD because some required definitions > obtained from pkgconfig file are not used. This happens due to the following > reasons: > > 1. IBUS_DEFINITIONS is not used in ibus-panel/CMakeLists.txt > 2. IBUS_DEFINITIONS is not saved in cache, and thus isn't available at > compile time > > This patch resolves both issues and makes ibus-panel compile on OpenBSD. > > (I found no suitable review group and therefore used "plasma" instead, as it > was in "plasma-addons" previously; please, feel free to correct me if I'm > wrong and sorry for any possible inconvenience) > > ((as there was no feedback for more than a week, I've added "kde-workspace" > group to list of reviewers, too)) > > > Diffs > - > > ibus-panel/CMakeLists.txt 3a1ee49 > > Diff: https://git.reviewboard.kde.org/r/119025/diff/ > > > Testing > --- > > OpenBSD/i386-CURRENT, KDE 4.13 (it doesn't have kimtoy package, of course, > but the code is same) > > > Thanks, > > Vadim Zhukov > >
Re: Review Request 112812: Use type description sort order in devicenotifier when non-removable devices are displayed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112812/#review99458 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On Sept. 19, 2013, 3:24 p.m., Benedikt Gollatz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/112812/ > --- > > (Updated Sept. 19, 2013, 3:24 p.m.) > > > Review request for Plasma. > > > Bugs: 324459 > http://bugs.kde.org/show_bug.cgi?id=324459 > > > Repository: kde-workspace > > > Description > --- > > Use type description sort order in the devicenotifier applet when > non-removable devices are configured to be displayed. This avoids apparently > random sort order (by device engine population timestamp) and unneccessary > ListView sections. The problem becomes apparent if other types of devices > besides simple storage volumes are configured in /etc/fstab, like for example > network mounts. > > Fixes bug #324459. > > > Diffs > - > > > plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml > 9b6132e > > Diff: https://git.reviewboard.kde.org/r/112812/diff/ > > > Testing > --- > > Works for me using KDE 4.10.5 packaged with Fedora 19. > > > Thanks, > > Benedikt Gollatz > >
Re: Review Request 105932: Fix for Bug 165792 - Allow multirow panels
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105932/ --- (Updated Sept. 22, 2016, 8:35 p.m.) Status -- This change has been discarded. Review request for Plasma. Bugs: 165792 http://bugs.kde.org/show_bug.cgi?id=165792 Repository: kde-workspace Description --- goes back to: https://bugs.kde.org/show_bug.cgi?id=165792 Diffs - plasma/desktop/shell/panelview.cpp 50826a8 Diff: https://git.reviewboard.kde.org/r/105932/diff/ Testing --- Thanks, Tobias Franz
Re: Review Request 118865: [startkde from plasma next] create ~/.kde directory if it doesn't exist
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118865/#review99470
---
Closing as this review request is more than 2 years old.
If it still applies to current Plasma please reopen this review request. Thanks
- David Edmundson
On June 21, 2014, 2:26 p.m., José Manuel Santamaría Lema wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118865/
> ---
>
> (Updated June 21, 2014, 2:26 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> ---
>
> Hi,
>
> I have been working a bit in kubuntu's plasma packaging, when I started
> plasma from a fresh new account I noticed I couldn't see most icons in the
> GUI's except for a few ones.
>
> So I checked the starkde output to try to find out what was wrong, I found a
> line like this one:
> static QPlatformTheme* QKdeTheme::createKdeTheme(): Unable to determine
> KDEHOME
>
> Digging a bit more into the issue I also found out where this message comes
> from.
> File src/platformsupport/themes/genericunix/qgenericunixthemes.cpp (Qt 5.3.0)
> lines 446-468:
> QPlatformTheme *QKdeTheme::createKdeTheme()
> {
> // Check for version >= 4 and determine home folder from environment,
> // defaulting to ~/.kde, ~/.kde
> const QByteArray kdeVersionBA = qgetenv("KDE_SESSION_VERSION");
> const int kdeVersion = kdeVersionBA.toInt();
> if (kdeVersion < 4)
> return 0;
> const QString kdeHomePathVar = QString::fromLocal8Bit(qgetenv("KDEHOME"));
> if (!kdeHomePathVar.isEmpty())
> return new QKdeTheme(kdeHomePathVar, kdeVersion);
>
> const QString kdeVersionHomePath = QDir::homePath() +
> QStringLiteral("/.kde") + QLatin1String(kdeVersionBA);
> if (QFileInfo(kdeVersionHomePath).isDir())
> return new QKdeTheme(kdeVersionHomePath, kdeVersion);
>
> const QString kdeHomePath = QDir::homePath() + QStringLiteral("/.kde");
> if (QFileInfo(kdeHomePath).isDir())
> return new QKdeTheme(kdeHomePath, kdeVersion);
>
> qWarning("%s: Unable to determine KDEHOME", Q_FUNC_INFO);
> return 0;
> }
>
> So I'm inclined to think the ~/.kde directory should be created if it doesn't
> exist, thats what the patch does. What do you think?
>
>
> Diffs
> -
>
> startkde/startkde.cmake ea0bdfe
>
> Diff: https://git.reviewboard.kde.org/r/118865/diff/
>
>
> Testing
> ---
>
> Applied a similar patch in a customized kubuntu package. With the patch the
> ~/.kde directory is created and the icons can be seen.
>
>
> Thanks,
>
> José Manuel Santamaría Lema
>
>
Re: Review Request 108308: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/108308/ --- (Updated Sept. 22, 2016, 8:35 p.m.) Status -- This change has been discarded. Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. Repository: kdelibs Description --- When setting "Keep window thumbnails" to "Always (Breaks minimization)", kwin will keep WM_STATE to be NORMAL when a client is minimized while including _NET_WM_STATE_HIDDEN in its _NET_WM_STATE, as confirmed by ICCCM[1] and Extended Window Manager Hints[2]. However, apart from the expected result (breaks minimization: the client will continue to refresh its content) the minimized window is not shown as minimized in icontasks and pager. These two plasma addons (and probably other addons as well) uses KWindowInfo::isMinimized to determine whether the window is minimized. However, this function threat all window that are not Iconic (WM_STATE != ICONIC) as not minimized, in contradiction to the "Extended window manager hints" which says, "Pagers and similar applications should use _NET_WM_STATE_HIDDEN instead of WM_STATE to decide whether to display a window in miniature representations of the windows on a desktop." This patch correct this behavior and therefore correct the behavior of both pager and icontasks in this situation. [1] http://tronche.com/gui/x/icccm/sec-4.html#s-4.1.3.1 [2] http://standards.freedesktop.org/wm-spec/wm-spec-1.3.html#id2731936 Diffs - kdeui/windowmanagement/kwindowinfo_x11.cpp d983c9a Diff: https://git.reviewboard.kde.org/r/108308/diff/ Testing --- Compiled, pager and icontasks shows minimized windows correctly. Also tested on openbox (+plasma's pager) by "Xuetian Weng". Thanks, Yichao Yu
Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115431/ --- (Updated Sept. 22, 2016, 8:40 p.m.) Status -- This change has been discarded. Review request for Plasma. Bugs: 228902 http://bugs.kde.org/show_bug.cgi?id=228902 Repository: kde-workspace Description --- For bug, see https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1052059 and https://bugs.kde.org/show_bug.cgi?id=228902 The problem is that in original code, it always uses 23:59 to calculate the width of the text. However, in some font, AM is wider than PM, and 0 is wider than 2 and 5. That causes some fonts been cropped. Diffs - plasma/generic/applets/digital-clock/clock.cpp f26e328 Diff: https://git.reviewboard.kde.org/r/115431/diff/ Testing --- Thanks, Yichao Zhou
Re: Review Request 117750: populate the konsole and enable it by default in plasmoidviewer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117750/ --- (Updated Sept. 22, 2016, 8:40 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-sdk Description --- populate the konsole and enable it by default in plasmoidviewer we add a custom message handler which will print all the output to stdout and also it will check from debug messages which come from the category "qml" and those which are coming from QML Diffs - plasmoidviewer/main.cpp 009acbbe7591b03487913cb1316d5f61e6a2b500 plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml d99c8cd8ebfbbe27ca04ba30c7a2bbe396d1a064 plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml 34db7f6fc6a04ce96cd307455ff15abe6697f194 plasmoidviewer/view.h d997f15d093584f4446bbdb3475c30c98441e728 plasmoidviewer/view.cpp aa8914539358b216b9641da679050f95ba5af512 Diff: https://git.reviewboard.kde.org/r/117750/diff/ Testing --- File Attachments plasmoidviewer_message https://git.reviewboard.kde.org/media/uploaded/files/2014/04/24/8ad4291f-c8b8-4378-8ab0-0330bb01d454__plasmoidviewer_msghandler_reviewboard_ok.png Thanks, Giorgos Tsiapaliokas
Re: Review Request 118697: Treat albums with different artists as different albums
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118697/#review99468 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On June 12, 2014, 3:43 p.m., Shantanu Tushar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118697/ > --- > > (Updated June 12, 2014, 3:43 p.m.) > > > Review request for Plasma. > > > Repository: plasma-mediacenter > > > Description > --- > > This one has been pending for some time now. Our Album data model assumed > that a album name is enough to uniquely identify an album. This creates > problems because multiple artists may have albums with the same name. > This patch makes Media Library and ItemCache aware of this fact. > > > Diffs > - > > libs/mediacenter/album.h 4926e48 > libs/mediacenter/album.cpp 881f65a > libs/mediacenter/itemcache.h ffee05f > libs/mediacenter/medialibrary.cpp 9c58b44 > libs/test/itemcachetest.h 4fc6807 > libs/test/itemcachetest.cpp e6dee33 > libs/test/medialibrarytest.h 718457d > libs/test/medialibrarytest.cpp e1a8c9b > libs/test/mediatest.cpp 8fde60b > libs/test/pmcalbumtest.cpp 9f2b4c8 > > Diff: https://git.reviewboard.kde.org/r/118697/diff/ > > > Testing > --- > > Unit tests pass. Added test to take care of the new scenario. > > > Thanks, > > Shantanu Tushar > >
Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115431/#review99469 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On March 18, 2014, 12:56 p.m., Yichao Zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115431/ > --- > > (Updated March 18, 2014, 12:56 p.m.) > > > Review request for Plasma. > > > Bugs: 228902 > http://bugs.kde.org/show_bug.cgi?id=228902 > > > Repository: kde-workspace > > > Description > --- > > For bug, see > https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1052059 and > https://bugs.kde.org/show_bug.cgi?id=228902 > > The problem is that in original code, it always uses 23:59 to calculate the > width of the text. However, in some font, AM is wider than PM, and 0 is > wider than 2 and 5. That causes some fonts been cropped. > > > Diffs > - > > plasma/generic/applets/digital-clock/clock.cpp f26e328 > > Diff: https://git.reviewboard.kde.org/r/115431/diff/ > > > Testing > --- > > > Thanks, > > Yichao Zhou > >
Re: Review Request 116800: introduce the command line argument --appletPath in plasmoidviewer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116800/#review99466 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On April 24, 2014, 1:38 p.m., Giorgos Tsiapaliokas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116800/ > --- > > (Updated April 24, 2014, 1:38 p.m.) > > > Review request for Plasma. > > > Repository: plasma-sdk > > > Description > --- > > The appletPath contains the path of the applet, if the user > doesn't give a path then the refresh button of the plasmoidviewer will > be hidden because we need the plasmoid path in order to execute > `plasmapkg2 -u $myapplet`. Also this patch installs the plasmoid automatically > so the user can refresh the plasmoid without having to install the plasmoid > manually. > > > Diffs > - > > plasmoidviewer/main.cpp 009acbb > plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml 8a125ea > plasmoidviewer/view.h d997f15 > plasmoidviewer/view.cpp aa89145 > > Diff: https://git.reviewboard.kde.org/r/116800/diff/ > > > Testing > --- > > 1. paths like ~/kf5/foo/plasmoid work > 2. the plasmoid is being loaded even without the --appletPath > > > Thanks, > > Giorgos Tsiapaliokas > >
Re: Review Request 118697: Treat albums with different artists as different albums
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118697/ --- (Updated Sept. 22, 2016, 8:40 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-mediacenter Description --- This one has been pending for some time now. Our Album data model assumed that a album name is enough to uniquely identify an album. This creates problems because multiple artists may have albums with the same name. This patch makes Media Library and ItemCache aware of this fact. Diffs - libs/mediacenter/album.h 4926e48 libs/mediacenter/album.cpp 881f65a libs/mediacenter/itemcache.h ffee05f libs/mediacenter/medialibrary.cpp 9c58b44 libs/test/itemcachetest.h 4fc6807 libs/test/itemcachetest.cpp e6dee33 libs/test/medialibrarytest.h 718457d libs/test/medialibrarytest.cpp e1a8c9b libs/test/mediatest.cpp 8fde60b libs/test/pmcalbumtest.cpp 9f2b4c8 Diff: https://git.reviewboard.kde.org/r/118697/diff/ Testing --- Unit tests pass. Added test to take care of the new scenario. Thanks, Shantanu Tushar
Re: Review Request 117736: Plasmaboard: don't use m_keyboardSize for plasmoid size
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117736/ --- (Updated Sept. 22, 2016, 8:39 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: kdeplasma-addons Description --- m_keyboardSize calculates wrong. So if I add plasmaboard to panel from js code using plasma updates mechanism, the default size sets really wrong (like 400x1024). This patch simply returns fixed size for plasmoid in any case. Diffs - applets/plasmaboard/widget.cpp 5628d63 Diff: https://git.reviewboard.kde.org/r/117736/diff/ Testing --- Thanks, Sergei Lopatin
Re: Review Request 116800: introduce the command line argument --appletPath in plasmoidviewer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116800/ --- (Updated Sept. 22, 2016, 8:40 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-sdk Description --- The appletPath contains the path of the applet, if the user doesn't give a path then the refresh button of the plasmoidviewer will be hidden because we need the plasmoid path in order to execute `plasmapkg2 -u $myapplet`. Also this patch installs the plasmoid automatically so the user can refresh the plasmoid without having to install the plasmoid manually. Diffs - plasmoidviewer/main.cpp 009acbb plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml 8a125ea plasmoidviewer/view.h d997f15 plasmoidviewer/view.cpp aa89145 Diff: https://git.reviewboard.kde.org/r/116800/diff/ Testing --- 1. paths like ~/kf5/foo/plasmoid work 2. the plasmoid is being loaded even without the --appletPath Thanks, Giorgos Tsiapaliokas
Re: Review Request 117615: Implementation of Search in Local Browsing in Plasma Media Center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117615/#review99465 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On April 17, 2014, 5:52 p.m., Harshit Agarwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117615/ > --- > > (Updated April 17, 2014, 5:52 p.m.) > > > Review request for Plasma, Akshay Ratan, Shantanu Tushar, and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > --- > > I have implemented the local browsing search only to the Videos section as of > now, but the application crashes, and it searches on the drive selection > window, but doesn't search on the folder and file selection window after > that. Please look into it and suggest where I am going wrong. > > Once this is done, it's the same implementation for images and songs. I would > do that similarly. > > > Diffs > - > > browsingbackends/localfiles/localfilesabstractbackend.h 2d47eba > browsingbackends/localfiles/localfilesabstractbackend.cpp b86a28a > browsingbackends/localfiles/localvideos/localvideosbackend.h ce92a9e > browsingbackends/localfiles/localvideos/localvideosbackend.cpp 8c20f27 > > Diff: https://git.reviewboard.kde.org/r/117615/diff/ > > > Testing > --- > > Errors yet there so testing on hold. > > > Thanks, > > Harshit Agarwal > >
Re: Review Request 117444: Bug 313734 - konsole profiles widget loses cursor highlight
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117444/ --- (Updated Sept. 22, 2016, 8:39 p.m.) Status -- This change has been discarded. Review request for Plasma. Bugs: 313734 http://bugs.kde.org/show_bug.cgi?id=313734 Repository: kdeplasma-addons Description --- Set the highlight to visible inside the Keys::onPressed handler. With this fix, after the highlight is set to invisible due to the user's mouse exiting the widget area, it will be made visible again if the user interacts with the widget via key press. Diffs - applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml bea8bfabcb65dcbee586becd6c4b4fc3dc0d9b16 Diff: https://git.reviewboard.kde.org/r/117444/diff/ Testing --- The following test steps were performed and passed: 1. Add Konsole Profiles Widget to the panel and give it a keyboard shortcut. 2. Invoke the Konsole Profiles widget via keyboard shortcut. 3. Attempt to navigate the profile list via arrow keys and make sure that the highlight appears. 4. Have the mouse enter and then leave the widget's mouse area so that the highlight disappears. 5. Interact with the widget with the arrow keys and make sure that the highlight appears again. Thanks, Jeffrey Enns
Re: Review Request 117736: Plasmaboard: don't use m_keyboardSize for plasmoid size
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117736/#review84690 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On April 24, 2014, 11:21 a.m., Sergei Lopatin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117736/ > --- > > (Updated April 24, 2014, 11:21 a.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > --- > > m_keyboardSize calculates wrong. So if I add plasmaboard to panel from js > code using plasma updates mechanism, the default size sets really wrong (like > 400x1024). > This patch simply returns fixed size for plasmoid in any case. > > > Diffs > - > > applets/plasmaboard/widget.cpp 5628d63 > > Diff: https://git.reviewboard.kde.org/r/117736/diff/ > > > Testing > --- > > > Thanks, > > Sergei Lopatin > >
Re: Review Request 117444: Bug 313734 - konsole profiles widget loses cursor highlight
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117444/#review99464 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On April 9, 2014, 4:52 a.m., Jeffrey Enns wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117444/ > --- > > (Updated April 9, 2014, 4:52 a.m.) > > > Review request for Plasma. > > > Bugs: 313734 > http://bugs.kde.org/show_bug.cgi?id=313734 > > > Repository: kdeplasma-addons > > > Description > --- > > Set the highlight to visible inside the Keys::onPressed handler. > > With this fix, after the highlight is set to invisible due to the user's > mouse exiting the widget area, it will be made visible again if the user > interacts with the widget via key press. > > > Diffs > - > > applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml > bea8bfabcb65dcbee586becd6c4b4fc3dc0d9b16 > > Diff: https://git.reviewboard.kde.org/r/117444/diff/ > > > Testing > --- > > The following test steps were performed and passed: > 1. Add Konsole Profiles Widget to the panel and give it a keyboard shortcut. > 2. Invoke the Konsole Profiles widget via keyboard shortcut. > 3. Attempt to navigate the profile list via arrow keys and make sure that the > highlight appears. > 4. Have the mouse enter and then leave the widget's mouse area so that the > highlight disappears. > 5. Interact with the widget with the arrow keys and make sure that the > highlight appears again. > > > Thanks, > > Jeffrey Enns > >
Re: Review Request 116744: Play All Button in Plasma Media Center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116744/ --- (Updated Sept. 22, 2016, 8:37 p.m.) Status -- This change has been discarded. Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 331040 http://bugs.kde.org/show_bug.cgi?id=331040 Repository: plasma-mediacenter Description --- Tried to fix the Play All button... Now it plays the first track of the album that is added... Earlier, it was just getting populated in the playlist and the sog wasn't playing... Diffs - browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 Diff: https://git.reviewboard.kde.org/r/116744/diff/ Testing --- Thanks, Atul Dubey
Re: Review Request 115162: Launch single instance of plasma-mediacenter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115162/#review99460 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On Jan. 22, 2014, 6:38 a.m., Sujith Haridasan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115162/ > --- > > (Updated Jan. 22, 2014, 6:38 a.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > --- > > Launching single instance of plasma-mediacenter. Using KUniqueApplication > only single instance of plasma-mediacenter is launched. > > > Diffs > - > > shells/newshell/CMakeLists.txt 60949df > shells/newshell/application.h PRE-CREATION > shells/newshell/application.cpp PRE-CREATION > shells/newshell/main.cpp 9fd5df3 > shells/newshell/mainwindow.h 5e0753e > shells/newshell/mainwindow.cpp 1bf56ac > shells/newshell/plasma-mediacenter.desktop c3c5781 > > Diff: https://git.reviewboard.kde.org/r/115162/diff/ > > > Testing > --- > > Tests done using konsole: > a) Open a tab and launch pmc. > b) Open another tab and try to launch another instance of pmc. > c) After executing (b) pmc wont launch because already another instance of > pmc from (a) is already running. > > Tests done using Dolphin: > a) Go to the music folder and right click on the file to be played. Click > open with and launch pmc. > b) Try to open another file using same step as (a) > c) After executing (b) wait for few seconds and you can see that only single > instance of (a) will be running. > > > Thanks, > > Sujith Haridasan > >
Re: Review Request 117101: This patch fixes font size behaviour when pmc is resized.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117101/#review99463 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On March 26, 2014, 9:29 p.m., Nikolaos Chatzidakis wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117101/ > --- > > (Updated March 26, 2014, 9:29 p.m.) > > > Review request for Plasma and Shantanu Tushar. > > > Repository: plasma-mediacenter > > > Description > --- > > This is my first patch trying to hack PMC. Untill now, whenever PMC was > resized, the menu strings font size remained fixed. Now it changes the font > size according to parents dimensions. > > > Diffs > - > > mediaelements/mediawelcome/BackendsListDelegate.qml 4840982 > mediaelements/mediawelcome/MediaWelcome.qml a3108d8 > > Diff: https://git.reviewboard.kde.org/r/117101/diff/ > > > Testing > --- > > The size of the icons in the menus remains the same, due to the file format > (png). Converting these graphics to SVG may solve the graphics resize issue > as well. > > > Thanks, > > Nikolaos Chatzidakis > >
Re: Review Request 116983: Fix the height of the buttonsbar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116983/#review99462 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On March 24, 2014, 10:26 a.m., Giorgos Tsiapaliokas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116983/ > --- > > (Updated March 24, 2014, 10:26 a.m.) > > > Review request for Plasma. > > > Repository: plasma-sdk > > > Description > --- > > If I am not mistaken a regression has been introduced in plasmoidviewer. > This patch solves the issue. > > > Diffs > - > > plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml c3624a5 > > Diff: https://git.reviewboard.kde.org/r/116983/diff/ > > > Testing > --- > > I have attached two images 1 without my patch and one with my patch > > > File Attachments > > > after.png > > https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/145ef74a-1936-4237-b09d-022fe128baa2__after.png > before.png > > https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/ebdf5aee-69e2-4c79-a5e4-7501059ceab2__before.png > plasmoidviewer without margins > > https://git.reviewboard.kde.org/media/uploaded/files/2014/03/24/19f7cde7-7736-4199-b4f6-938b5fd75772__without_margins.png > > > Thanks, > > Giorgos Tsiapaliokas > >
Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110122/#review99459 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On April 25, 2013, 1:58 p.m., James Pike wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/110122/ > --- > > (Updated April 25, 2013, 1:58 p.m.) > > > Review request for Plasma. > > > Bugs: 318295 > http://bugs.kde.org/show_bug.cgi?id=318295 > > > Repository: kde-workspace > > > Description > --- > > Currently the timeout of the last notification to arrive is used as a basis > for hiding the notification display. This means that a notification with a > high timeout can get hidden by a new notification arriving with a much lower > timeout. > > This patch simply changes the behaviour to, when expiring a timer, go back > through the stack and display the most recent unexpired timer. If all timers > are expired the notification is closed as before. > > > Diffs > - > > plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml > 2fa1b11 > > Diff: https://git.reviewboard.kde.org/r/110122/diff/ > > > Testing > --- > > Test script in https://bugs.kde.org/show_bug.cgi?id=318295 > > > Thanks, > > James Pike > >
Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110122/ --- (Updated Sept. 22, 2016, 8:37 p.m.) Status -- This change has been discarded. Review request for Plasma. Bugs: 318295 http://bugs.kde.org/show_bug.cgi?id=318295 Repository: kde-workspace Description --- Currently the timeout of the last notification to arrive is used as a basis for hiding the notification display. This means that a notification with a high timeout can get hidden by a new notification arriving with a much lower timeout. This patch simply changes the behaviour to, when expiring a timer, go back through the stack and display the most recent unexpired timer. If all timers are expired the notification is closed as before. Diffs - plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 2fa1b11 Diff: https://git.reviewboard.kde.org/r/110122/diff/ Testing --- Test script in https://bugs.kde.org/show_bug.cgi?id=318295 Thanks, James Pike
Re: Review Request 115162: Launch single instance of plasma-mediacenter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115162/ --- (Updated Sept. 22, 2016, 8:37 p.m.) Status -- This change has been discarded. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Launching single instance of plasma-mediacenter. Using KUniqueApplication only single instance of plasma-mediacenter is launched. Diffs - shells/newshell/CMakeLists.txt 60949df shells/newshell/application.h PRE-CREATION shells/newshell/application.cpp PRE-CREATION shells/newshell/main.cpp 9fd5df3 shells/newshell/mainwindow.h 5e0753e shells/newshell/mainwindow.cpp 1bf56ac shells/newshell/plasma-mediacenter.desktop c3c5781 Diff: https://git.reviewboard.kde.org/r/115162/diff/ Testing --- Tests done using konsole: a) Open a tab and launch pmc. b) Open another tab and try to launch another instance of pmc. c) After executing (b) pmc wont launch because already another instance of pmc from (a) is already running. Tests done using Dolphin: a) Go to the music folder and right click on the file to be played. Click open with and launch pmc. b) Try to open another file using same step as (a) c) After executing (b) wait for few seconds and you can see that only single instance of (a) will be running. Thanks, Sujith Haridasan
Re: Review Request 117101: This patch fixes font size behaviour when pmc is resized.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117101/ --- (Updated Sept. 22, 2016, 8:38 p.m.) Status -- This change has been discarded. Review request for Plasma and Shantanu Tushar. Repository: plasma-mediacenter Description --- This is my first patch trying to hack PMC. Untill now, whenever PMC was resized, the menu strings font size remained fixed. Now it changes the font size according to parents dimensions. Diffs - mediaelements/mediawelcome/BackendsListDelegate.qml 4840982 mediaelements/mediawelcome/MediaWelcome.qml a3108d8 Diff: https://git.reviewboard.kde.org/r/117101/diff/ Testing --- The size of the icons in the menus remains the same, due to the file format (png). Converting these graphics to SVG may solve the graphics resize issue as well. Thanks, Nikolaos Chatzidakis
Re: Review Request 116983: Fix the height of the buttonsbar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116983/ --- (Updated Sept. 22, 2016, 8:37 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-sdk Description --- If I am not mistaken a regression has been introduced in plasmoidviewer. This patch solves the issue. Diffs - plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml c3624a5 Diff: https://git.reviewboard.kde.org/r/116983/diff/ Testing --- I have attached two images 1 without my patch and one with my patch File Attachments after.png https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/145ef74a-1936-4237-b09d-022fe128baa2__after.png before.png https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/ebdf5aee-69e2-4c79-a5e4-7501059ceab2__before.png plasmoidviewer without margins https://git.reviewboard.kde.org/media/uploaded/files/2014/03/24/19f7cde7-7736-4199-b4f6-938b5fd75772__without_margins.png Thanks, Giorgos Tsiapaliokas
Re: Review Request 116744: Play All Button in Plasma Media Center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116744/#review99461 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On March 15, 2014, 5:20 a.m., Atul Dubey wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116744/ > --- > > (Updated March 15, 2014, 5:20 a.m.) > > > Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and > Sujith Haridasan. > > > Bugs: 331040 > http://bugs.kde.org/show_bug.cgi?id=331040 > > > Repository: plasma-mediacenter > > > Description > --- > > Tried to fix the Play All button... Now it plays the first track of the album > that is added... > > Earlier, it was just getting populated in the playlist and the sog wasn't > playing... > > > Diffs > - > > browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 > > Diff: https://git.reviewboard.kde.org/r/116744/diff/ > > > Testing > --- > > > Thanks, > > Atul Dubey > >
Re: Review Request 110504: Group tasks by activity
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110504/#review99457
---
Closing as this review request is more than 2 years old.
If it still applies to current Plasma please reopen this review request. Thanks
- David Edmundson
On May 18, 2013, 2:13 p.m., José Millán Soto wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110504/
> ---
>
> (Updated May 18, 2013, 2:13 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kde-workspace
>
>
> Description
> ---
>
> New grouping strategy was created to allow tasks to be grouped by activity.
> If an item is available in multiple activities, it will only appear in one of
> the activities the task is available on (except if it's available on all
> activities).
> GroupManager was modified so that whether items should be grouped just when
> the task bar is full or not is not only taken into account when grouping by
> program but also when grouping by activity.
> Activity icons are not handled yet, so an icon from the first task which was
> on the group is used as the icon of the task group.
>
>
> Diffs
> -
>
> libs/taskmanager/CMakeLists.txt 70fa791
> libs/taskmanager/groupmanager.h ad4167a
> libs/taskmanager/groupmanager.cpp 9ac15e7
> libs/taskmanager/strategies/activitygroupingstrategy.h PRE-CREATION
> libs/taskmanager/strategies/activitygroupingstrategy.cpp PRE-CREATION
> plasma/desktop/applets/tasks/tasks.cpp dbbb0cb
>
> Diff: https://git.reviewboard.kde.org/r/110504/diff/
>
>
> Testing
> ---
>
> Three activities were created (named "Activity 1", "Activity 2" and "Activity
> 3").
> One instance of KDialog was assigned to Activity 1, two instances of KDialog
> were assigned to Activity 2, three instances of KDialog were assigned to
> Activity 3 and one instance of KDialog was assigned both to Activities 2 & 3.
> The tasks applet was executed in plasma-windowed in all activities.
> Screenshot 1 & 2 show the task manager in the situation described above.
> Screenshot 3 shows the same task manager after leaving only one instance of
> KDialog in each activity ("Only group when taskbar is full" enabled), and
> screenshot 4 shows the task manager when the tasks are the same that in
> screenshot 3 but "Only group when taskbar is full" is disabled.
>
>
> File Attachments
>
>
> Screenshot 1
> https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img1.png
> Screenshot 2
> https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img2.png
> Screenshot 3
> https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img3.png
> Screenshot 4
> https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img4.png
>
>
> Thanks,
>
> José Millán Soto
>
>
Re: Review Request 105677: Plasmapkg: Add KWin/Decoration support to Plasmapkg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105677/ --- (Updated Sept. 22, 2016, 8:35 p.m.) Status -- This change has been discarded. Review request for kwin, Plasma and Martin Gräßlin. Repository: kde-runtime Description --- Hello, This patch is adding support for "plasmapkg -t kwindecoration" Diffs - plasma/tools/plasmapkg/main.cpp 3dc061c Diff: https://git.reviewboard.kde.org/r/105677/diff/ Testing --- Thanks, Antonis Tsiapaliokas
Re: Review Request 110504: Group tasks by activity
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110504/
---
(Updated Sept. 22, 2016, 8:35 p.m.)
Status
--
This change has been discarded.
Review request for Plasma.
Repository: kde-workspace
Description
---
New grouping strategy was created to allow tasks to be grouped by activity.
If an item is available in multiple activities, it will only appear in one of
the activities the task is available on (except if it's available on all
activities).
GroupManager was modified so that whether items should be grouped just when the
task bar is full or not is not only taken into account when grouping by program
but also when grouping by activity.
Activity icons are not handled yet, so an icon from the first task which was on
the group is used as the icon of the task group.
Diffs
-
libs/taskmanager/CMakeLists.txt 70fa791
libs/taskmanager/groupmanager.h ad4167a
libs/taskmanager/groupmanager.cpp 9ac15e7
libs/taskmanager/strategies/activitygroupingstrategy.h PRE-CREATION
libs/taskmanager/strategies/activitygroupingstrategy.cpp PRE-CREATION
plasma/desktop/applets/tasks/tasks.cpp dbbb0cb
Diff: https://git.reviewboard.kde.org/r/110504/diff/
Testing
---
Three activities were created (named "Activity 1", "Activity 2" and "Activity
3").
One instance of KDialog was assigned to Activity 1, two instances of KDialog
were assigned to Activity 2, three instances of KDialog were assigned to
Activity 3 and one instance of KDialog was assigned both to Activities 2 & 3.
The tasks applet was executed in plasma-windowed in all activities.
Screenshot 1 & 2 show the task manager in the situation described above.
Screenshot 3 shows the same task manager after leaving only one instance of
KDialog in each activity ("Only group when taskbar is full" enabled), and
screenshot 4 shows the task manager when the tasks are the same that in
screenshot 3 but "Only group when taskbar is full" is disabled.
File Attachments
Screenshot 1
https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img1.png
Screenshot 2
https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img2.png
Screenshot 3
https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img3.png
Screenshot 4
https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img4.png
Thanks,
José Millán Soto
Re: Review Request 105677: Plasmapkg: Add KWin/Decoration support to Plasmapkg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105677/#review99456 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On July 23, 2012, 2:47 p.m., Antonis Tsiapaliokas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/105677/ > --- > > (Updated July 23, 2012, 2:47 p.m.) > > > Review request for kwin, Plasma and Martin Gräßlin. > > > Repository: kde-runtime > > > Description > --- > > Hello, > > This patch is adding support for "plasmapkg -t kwindecoration" > > > Diffs > - > > plasma/tools/plasmapkg/main.cpp 3dc061c > > Diff: https://git.reviewboard.kde.org/r/105677/diff/ > > > Testing > --- > > > Thanks, > > Antonis Tsiapaliokas > >
Re: Review Request 108308: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/108308/#review99455 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On Jan. 16, 2013, 2:37 p.m., Yichao Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/108308/ > --- > > (Updated Jan. 16, 2013, 2:37 p.m.) > > > Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. > > > Repository: kdelibs > > > Description > --- > > When setting "Keep window thumbnails" to "Always (Breaks minimization)", kwin > will keep WM_STATE to be NORMAL when a client is minimized while including > _NET_WM_STATE_HIDDEN in its _NET_WM_STATE, as confirmed by ICCCM[1] and > Extended Window Manager Hints[2]. However, apart from the expected result > (breaks minimization: the client will continue to refresh its content) the > minimized window is not shown as minimized in icontasks and pager. > > These two plasma addons (and probably other addons as well) uses > KWindowInfo::isMinimized to determine whether the window is minimized. > However, this function threat all window that are not Iconic (WM_STATE != > ICONIC) as not minimized, in contradiction to the "Extended window manager > hints" which says, "Pagers and similar applications should use > _NET_WM_STATE_HIDDEN instead of WM_STATE to decide whether to display a > window in miniature representations of the windows on a desktop." > > This patch correct this behavior and therefore correct the behavior of both > pager and icontasks in this situation. > > [1] http://tronche.com/gui/x/icccm/sec-4.html#s-4.1.3.1 > [2] http://standards.freedesktop.org/wm-spec/wm-spec-1.3.html#id2731936 > > > Diffs > - > > kdeui/windowmanagement/kwindowinfo_x11.cpp d983c9a > > Diff: https://git.reviewboard.kde.org/r/108308/diff/ > > > Testing > --- > > Compiled, pager and icontasks shows minimized windows correctly. > Also tested on openbox (+plasma's pager) by "Xuetian Weng". > > > Thanks, > > Yichao Yu > >
Re: Review Request 103101: Add a groupingstrategy to automatically group tasks that are grouped using kwin's windowtabbing
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/103101/ --- (Updated Sept. 22, 2016, 8:34 p.m.) Status -- This change has been discarded. Review request for Plasma. Bugs: 224690 http://bugs.kde.org/show_bug.cgi?id=224690 Repository: kde-workspace Description --- This patch adds a groupingstrategy that groups tasks by their tab group, from kwin's window tabbing feature. Most of the code in wintabgroupingstrategy is copied from programgroupingstrategy. This patch is based on https://git.reviewboard.kde.org/r/103099/ to be included in KDELibs 4.7 Diffs - libs/taskmanager/CMakeLists.txt c3848cf libs/taskmanager/groupmanager.h 760ddf1 libs/taskmanager/groupmanager.cpp b66c6fa libs/taskmanager/strategies/wintabgroupingstrategy.h PRE-CREATION libs/taskmanager/strategies/wintabgroupingstrategy.cpp PRE-CREATION libs/taskmanager/task.h aa05176 libs/taskmanager/task_x11.cpp 9b7d8cb Diff: https://git.reviewboard.kde.org/r/103101/diff/ Testing --- Tested without problems so far. Thanks, Anton Kreuzkamp
Re: Review Request 105932: Fix for Bug 165792 - Allow multirow panels
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105932/#review99454 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On Aug. 8, 2012, 4:19 p.m., Tobias Franz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/105932/ > --- > > (Updated Aug. 8, 2012, 4:19 p.m.) > > > Review request for Plasma. > > > Bugs: 165792 > http://bugs.kde.org/show_bug.cgi?id=165792 > > > Repository: kde-workspace > > > Description > --- > > goes back to: > https://bugs.kde.org/show_bug.cgi?id=165792 > > > Diffs > - > > plasma/desktop/shell/panelview.cpp 50826a8 > > Diff: https://git.reviewboard.kde.org/r/105932/diff/ > > > Testing > --- > > > Thanks, > > Tobias Franz > >
Re: Review Request 102727: quicklaunch: Add a confirmation dialog before the delete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102727/ --- (Updated Sept. 22, 2016, 8:34 p.m.) Status -- This change has been discarded. Review request for Plasma. Bugs: 270105 http://bugs.kde.org/show_bug.cgi?id=270105 Repository: kde-workspace Description --- Hello, This patch is adding a new feature to the quicklaunch plasmaoid. Diffs - plasma/generic/applets/quicklaunch/quicklaunch.cpp dfc6125 Diff: https://git.reviewboard.kde.org/r/102727/diff/ Testing --- kde-workspace compiles fine. Thanks, Antonis Tsiapaliokas
Re: Review Request 103101: Add a groupingstrategy to automatically group tasks that are grouped using kwin's windowtabbing
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/103101/#review99453 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On Nov. 10, 2011, 8:49 p.m., Anton Kreuzkamp wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/103101/ > --- > > (Updated Nov. 10, 2011, 8:49 p.m.) > > > Review request for Plasma. > > > Bugs: 224690 > http://bugs.kde.org/show_bug.cgi?id=224690 > > > Repository: kde-workspace > > > Description > --- > > This patch adds a groupingstrategy that groups tasks by their tab group, from > kwin's window tabbing feature. > Most of the code in wintabgroupingstrategy is copied from > programgroupingstrategy. > This patch is based on https://git.reviewboard.kde.org/r/103099/ to be > included in KDELibs 4.7 > > > Diffs > - > > libs/taskmanager/CMakeLists.txt c3848cf > libs/taskmanager/groupmanager.h 760ddf1 > libs/taskmanager/groupmanager.cpp b66c6fa > libs/taskmanager/strategies/wintabgroupingstrategy.h PRE-CREATION > libs/taskmanager/strategies/wintabgroupingstrategy.cpp PRE-CREATION > libs/taskmanager/task.h aa05176 > libs/taskmanager/task_x11.cpp 9b7d8cb > > Diff: https://git.reviewboard.kde.org/r/103101/diff/ > > > Testing > --- > > Tested without problems so far. > > > Thanks, > > Anton Kreuzkamp > >
Re: Review Request 102727: quicklaunch: Add a confirmation dialog before the delete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102727/#review99452 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On Sept. 28, 2011, 8:44 p.m., Antonis Tsiapaliokas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/102727/ > --- > > (Updated Sept. 28, 2011, 8:44 p.m.) > > > Review request for Plasma. > > > Bugs: 270105 > http://bugs.kde.org/show_bug.cgi?id=270105 > > > Repository: kde-workspace > > > Description > --- > > Hello, > > This patch is adding a new feature to the quicklaunch plasmaoid. > > > Diffs > - > > plasma/generic/applets/quicklaunch/quicklaunch.cpp dfc6125 > > Diff: https://git.reviewboard.kde.org/r/102727/diff/ > > > Testing > --- > > kde-workspace compiles fine. > > > Thanks, > > Antonis Tsiapaliokas > >
Re: Review Request 102350: Implement automatic scanning of source code for required data engines
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102350/#review99451 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On Sept. 27, 2011, 11:38 p.m., Kevin Kofler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/102350/ > --- > > (Updated Sept. 27, 2011, 11:38 p.m.) > > > Review request for Plasma. > > > Repository: kdelibs > > > Description > --- > > For packages in scripting languages and distributed through OCS, this is fully > automatic and triggered from Package::installPackage. If an > X-Plasma-RequiredDataEngines entry is present in the .desktop file (even if > empty), the dependency extraction is not run and the explicitly provided > information is trusted instead. > > For native distribution packages, we ship a tool called > plasma-dataengine-depextractor which can be run at any time during the build > process and which adds the dependency information to the relevant .desktop > file. > > Authors of plasmoids are encouraged to run plasma-dataengine-depextractor > and/or > fill in X-Plasma-RequiredDataEngines manually. (Please note that the list is > expected to be comma-separated.) > > This is the final portion of my GSoC 2011 project. > > > Diffs > - > > plasma/CMakeLists.txt f929967 > plasma/depextractor/depextractor.cpp PRE-CREATION > plasma/package.cpp 4c00d36 > plasma/private/componentinstaller.cpp 870667f > plasma/private/componentinstaller_p.h f85cbb6 > > Diff: https://git.reviewboard.kde.org/r/102350/diff/ > > > Testing > --- > > Compiles on Fedora 15. > > Tested plasma-dataengine-depextractor on the weather plasmoid, it detected > the dependency on the weather dataengine correctly and wrote a valid > X-Plasma-RequiredDataEngines entry into the .desktop file. > > > Thanks, > > Kevin Kofler > >
Re: Review Request 102350: Implement automatic scanning of source code for required data engines
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102350/ --- (Updated Sept. 22, 2016, 8:34 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: kdelibs Description --- For packages in scripting languages and distributed through OCS, this is fully automatic and triggered from Package::installPackage. If an X-Plasma-RequiredDataEngines entry is present in the .desktop file (even if empty), the dependency extraction is not run and the explicitly provided information is trusted instead. For native distribution packages, we ship a tool called plasma-dataengine-depextractor which can be run at any time during the build process and which adds the dependency information to the relevant .desktop file. Authors of plasmoids are encouraged to run plasma-dataengine-depextractor and/or fill in X-Plasma-RequiredDataEngines manually. (Please note that the list is expected to be comma-separated.) This is the final portion of my GSoC 2011 project. Diffs - plasma/CMakeLists.txt f929967 plasma/depextractor/depextractor.cpp PRE-CREATION plasma/package.cpp 4c00d36 plasma/private/componentinstaller.cpp 870667f plasma/private/componentinstaller_p.h f85cbb6 Diff: https://git.reviewboard.kde.org/r/102350/diff/ Testing --- Compiles on Fedora 15. Tested plasma-dataengine-depextractor on the weather plasmoid, it detected the dependency on the weather dataengine correctly and wrote a valid X-Plasma-RequiredDataEngines entry into the .desktop file. Thanks, Kevin Kofler
Re: Review Request 102291: Trigger installation of missing components when installing a package
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102291/ --- (Updated Sept. 22, 2016, 8:34 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: kdelibs Description --- This is another part of my GSoC 2011 work. For script engines, the existing metadata (X-Plasma-API) is sufficient. For data engines, we introduce a new metadata entry: X-Plasma-RequiredDataEngines. Third-party packages will have to add this entry to benefit from this feature at this time. Automatic support for scanning package source code on installation (at least for some languages) is planned, but the metadata entry is definitely the most efficient method. Diffs - plasma/package.cpp 4c00d36 plasma/packagemetadata.h b10f0e4 plasma/packagemetadata.cpp 59163b2 Diff: https://git.reviewboard.kde.org/r/102291/diff/ Testing --- Verified that it compiles without errors and that it successfully prompts for a missing Python script engine right after installing a Python widget (I used Veromix for my test) through KHNS (not only when actually using it) on Fedora 15. Also verified that there is no such prompt if plasma-scriptengine-python is already installed. (The patch is against master (4.8), but applies without changes to the kdelibs 4.6.5 in Fedora 15, which is how I tested it.) Thanks, Kevin Kofler
Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114424/#review99449 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On Dec. 13, 2013, 12:53 p.m., Yichao Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114424/ > --- > > (Updated Dec. 13, 2013, 12:53 p.m.) > > > Review request for Plasma, Aaron J. Seigo, Martin Gräßlin, and Ivan Čukić. > > > Bugs: 320995 > http://bugs.kde.org/show_bug.cgi?id=320995 > > > Repository: kdeplasma-addons > > > Description > --- > > The lancelot main window sets the _KDE_NET_WM_SHADOW property to "1" but > never set anything valid to it and therefore has no drop shadow. > This patch add the shadow when using a qt style that is aware of the KDE > shadow hint in the widget's property. I haven't found a documentation for > this property but it seems that they are recognized by oxygen and are also > copied to qtcurve (and probably bespin, haven't checked). > A better solution might be using the plasma shadow although I don't know how > to do that without copying the code to install shadows from kdelibs, unless > someone adds a new api to apply plasma themed shadows to a window. > > > Diffs > - > > applets/lancelot/application/LancelotWindow.cpp c66c565 > > Diff: https://git.reviewboard.kde.org/r/114424/diff/ > > > Testing > --- > > Compiles. > Have shadow with both oxygen and qtcurve. > > > Thanks, > > Yichao Yu > >
Re: Review Request 102291: Trigger installation of missing components when installing a package
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102291/#review99450 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On Aug. 10, 2011, 10:10 p.m., Kevin Kofler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/102291/ > --- > > (Updated Aug. 10, 2011, 10:10 p.m.) > > > Review request for Plasma. > > > Repository: kdelibs > > > Description > --- > > This is another part of my GSoC 2011 work. > > For script engines, the existing metadata (X-Plasma-API) is sufficient. > > For data engines, we introduce a new metadata entry: > X-Plasma-RequiredDataEngines. Third-party packages will have to add this entry > to benefit from this feature at this time. Automatic support for scanning > package source code on installation (at least for some languages) is planned, > but the metadata entry is definitely the most efficient method. > > > Diffs > - > > plasma/package.cpp 4c00d36 > plasma/packagemetadata.h b10f0e4 > plasma/packagemetadata.cpp 59163b2 > > Diff: https://git.reviewboard.kde.org/r/102291/diff/ > > > Testing > --- > > Verified that it compiles without errors and that it successfully prompts for > a missing Python script engine right after installing a Python widget (I used > Veromix for my test) through KHNS (not only when actually using it) on Fedora > 15. Also verified that there is no such prompt if plasma-scriptengine-python > is already installed. > > (The patch is against master (4.8), but applies without changes to the > kdelibs 4.6.5 in Fedora 15, which is how I tested it.) > > > Thanks, > > Kevin Kofler > >
Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114424/ --- (Updated Sept. 22, 2016, 8:34 p.m.) Status -- This change has been discarded. Review request for Plasma, Aaron J. Seigo, Martin Gräßlin, and Ivan Čukić. Bugs: 320995 http://bugs.kde.org/show_bug.cgi?id=320995 Repository: kdeplasma-addons Description --- The lancelot main window sets the _KDE_NET_WM_SHADOW property to "1" but never set anything valid to it and therefore has no drop shadow. This patch add the shadow when using a qt style that is aware of the KDE shadow hint in the widget's property. I haven't found a documentation for this property but it seems that they are recognized by oxygen and are also copied to qtcurve (and probably bespin, haven't checked). A better solution might be using the plasma shadow although I don't know how to do that without copying the code to install shadows from kdelibs, unless someone adds a new api to apply plasma themed shadows to a window. Diffs - applets/lancelot/application/LancelotWindow.cpp c66c565 Diff: https://git.reviewboard.kde.org/r/114424/diff/ Testing --- Compiles. Have shadow with both oxygen and qtcurve. Thanks, Yichao Yu
Re: Review Request 107868: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107868/ --- (Updated Sept. 22, 2016, 8:33 p.m.) Status -- This change has been discarded. Review request for Plasma. Bugs: 188494 http://bugs.kde.org/show_bug.cgi?id=188494 Repository: kdeplasma-addons Description --- What the current konquerorsessions plugin does is eventually calling "konqueror --profile xyz", so it is really for the profile feature of konqueror, not the session feature of konqueoror. The patch just contains various moving and renaming opeations to make its code, name and behavior being consistent. I actually have made a real konquerosessions plugin based upon this unreal plugin. Will post it in another review. Diffs - runners/CMakeLists.txt bb4b491 runners/konquerorprofiles/CMakeLists.txt PRE-CREATION runners/konquerorprofiles/Messages.sh PRE-CREATION runners/konquerorprofiles/konquerorprofiles.cpp PRE-CREATION runners/konquerorprofiles/konquerorprofiles.desktop PRE-CREATION runners/konquerorprofiles/konquerorprofiles.h PRE-CREATION runners/konquerorprofiles/konquerorsessions_renamed_to_konquerorprofiles.upd PRE-CREATION runners/konquerorsessions/CMakeLists.txt be2ea9d runners/konquerorsessions/Messages.sh 0720e1e runners/konquerorsessions/konquerorsessions.cpp f2e437a runners/konquerorsessions/konquerorsessions.desktop df81780 runners/konquerorsessions/konquerorsessions.h 957f976 Diff: https://git.reviewboard.kde.org/r/107868/diff/ Testing --- Thanks, Jekyll Wu
Re: Review Request 107868: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107868/#review99448 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On Dec. 31, 2012, 7:12 p.m., Jekyll Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/107868/ > --- > > (Updated Dec. 31, 2012, 7:12 p.m.) > > > Review request for Plasma. > > > Bugs: 188494 > http://bugs.kde.org/show_bug.cgi?id=188494 > > > Repository: kdeplasma-addons > > > Description > --- > > What the current konquerorsessions plugin does is eventually calling > "konqueror --profile xyz", so it is really for the profile feature of > konqueror, not the session feature of konqueoror. > > The patch just contains various moving and renaming opeations to make its > code, name and behavior being consistent. I actually have made a real > konquerosessions plugin based upon this unreal plugin. Will post it in > another review. > > > Diffs > - > > runners/CMakeLists.txt bb4b491 > runners/konquerorprofiles/CMakeLists.txt PRE-CREATION > runners/konquerorprofiles/Messages.sh PRE-CREATION > runners/konquerorprofiles/konquerorprofiles.cpp PRE-CREATION > runners/konquerorprofiles/konquerorprofiles.desktop PRE-CREATION > runners/konquerorprofiles/konquerorprofiles.h PRE-CREATION > > runners/konquerorprofiles/konquerorsessions_renamed_to_konquerorprofiles.upd > PRE-CREATION > runners/konquerorsessions/CMakeLists.txt be2ea9d > runners/konquerorsessions/Messages.sh 0720e1e > runners/konquerorsessions/konquerorsessions.cpp f2e437a > runners/konquerorsessions/konquerorsessions.desktop df81780 > runners/konquerorsessions/konquerorsessions.h 957f976 > > Diff: https://git.reviewboard.kde.org/r/107868/diff/ > > > Testing > --- > > > Thanks, > > Jekyll Wu > >
Re: Review Request 107869: Add a real konquerorsessions plugin for krunner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107869/ --- (Updated Sept. 22, 2016, 8:33 p.m.) Status -- This change has been discarded. Review request for Plasma. Bugs: 188494 http://bugs.kde.org/show_bug.cgi?id=188494 Repository: kdeplasma-addons Description --- This is a follow-up of https://git.reviewboard.kde.org/r/107868/ . The code is based upon the old and unreal konquerorsessions plugin, with minimal modification (since I'm not familiar with krunner plugins) to make it work in the way as its name implies. The patch can't be uploaded as diff, since it depends upon the patch in https://git.reviewboard.kde.org/r/107868/ and that one has not be committed. See the attached file below. Diffs - Diff: https://git.reviewboard.kde.org/r/107869/diff/ Testing --- File Attachments the patch https://git.reviewboard.kde.org/media/uploaded/files/2012/12/23/0002-Add-a-real-konquerorsessions-plugin_1.patch Thanks, Jekyll Wu
Re: Review Request 107869: Add a real konquerorsessions plugin for krunner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107869/#review99447 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On Dec. 23, 2012, 12:27 p.m., Jekyll Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/107869/ > --- > > (Updated Dec. 23, 2012, 12:27 p.m.) > > > Review request for Plasma. > > > Bugs: 188494 > http://bugs.kde.org/show_bug.cgi?id=188494 > > > Repository: kdeplasma-addons > > > Description > --- > > This is a follow-up of https://git.reviewboard.kde.org/r/107868/ . > > The code is based upon the old and unreal konquerorsessions plugin, with > minimal modification (since I'm not familiar with krunner plugins) to make it > work in the way as its name implies. > > The patch can't be uploaded as diff, since it depends upon the patch in > https://git.reviewboard.kde.org/r/107868/ and that one has not be committed. > See the attached file below. > > > Diffs > - > > > Diff: https://git.reviewboard.kde.org/r/107869/diff/ > > > Testing > --- > > > File Attachments > > > the patch > > https://git.reviewboard.kde.org/media/uploaded/files/2012/12/23/0002-Add-a-real-konquerorsessions-plugin_1.patch > > > Thanks, > > Jekyll Wu > >
Re: Review Request 109124: qml port currentappcontrol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109124/ --- (Updated Sept. 22, 2016, 8:32 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: kde-workspace Description --- Heya folks, This is a qml port of the netbook applet currentappcontrol. It's ready to use, but not fully complete. Missing features/bugs: - If you click on the title on the task bar, it doesn't show the kwin present windows effect, how to implement that? Is there interest in a 'kwin dataengine' or should I go for a mixed C++/QML applet? - there is an annoyance in the task list(present windows fallback): I can set a minimum height, but if I close a task and re-set the minimum height, the popup won't shrink again, leaving an unpleasant empty space; plasma bug? - the close/restore buttons don't glow on hover. I couldn't load a theme svg using the IconItem. Is that possible? - do you know how to read the size of the containment the widget is contained? Diffs - CMakeLists.txt 6084d7dd7655372506e02abe9f141b73155c5857 plasma/netbook/applets/currentappcontrol/CMakeLists.txt 46178ce3a9351845855e9fccfbc13a9d3946fc95 plasma/netbook/applets/currentappcontrol/Messages.sh 45d44681ae1be43b2d71ca48ab3e77af37ad8861 plasma/netbook/applets/currentappcontrol/package/contents/ui/Task.qml PRE-CREATION plasma/netbook/applets/currentappcontrol/package/contents/ui/main.qml PRE-CREATION plasma/netbook/applets/currentappcontrol/package/metadata.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/109124/diff/ Testing --- Thanks, Gregor Tätzner
Re: Review Request 109124: qml port currentappcontrol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109124/#review99446 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma. Please reopen. Thanks - David Edmundson On Feb. 25, 2013, 6:20 p.m., Gregor Tätzner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/109124/ > --- > > (Updated Feb. 25, 2013, 6:20 p.m.) > > > Review request for Plasma. > > > Repository: kde-workspace > > > Description > --- > > Heya folks, > This is a qml port of the netbook applet currentappcontrol. It's ready to > use, but not fully complete. > Missing features/bugs: > - If you click on the title on the task bar, it doesn't show the kwin present > windows effect, how to implement that? Is there interest in a 'kwin > dataengine' or should I go for a mixed C++/QML applet? > - there is an annoyance in the task list(present windows fallback): I can set > a minimum height, but if I close a task and re-set the minimum height, the > popup won't shrink again, leaving an unpleasant empty space; plasma bug? > - the close/restore buttons don't glow on hover. I couldn't load a theme svg > using the IconItem. Is that possible? > - do you know how to read the size of the containment the widget is contained? > > > Diffs > - > > CMakeLists.txt 6084d7dd7655372506e02abe9f141b73155c5857 > plasma/netbook/applets/currentappcontrol/CMakeLists.txt > 46178ce3a9351845855e9fccfbc13a9d3946fc95 > plasma/netbook/applets/currentappcontrol/Messages.sh > 45d44681ae1be43b2d71ca48ab3e77af37ad8861 > plasma/netbook/applets/currentappcontrol/package/contents/ui/Task.qml > PRE-CREATION > plasma/netbook/applets/currentappcontrol/package/contents/ui/main.qml > PRE-CREATION > plasma/netbook/applets/currentappcontrol/package/metadata.desktop > PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/109124/diff/ > > > Testing > --- > > > Thanks, > > Gregor Tätzner > >
Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114428/#review99444
---
Closing as this review request is more than 2 years old.
If it still applies to current Plasma. Please reopen. Thanks
- David Edmundson
On Dec. 13, 2013, 3:05 p.m., Heena Mahour wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114428/
> ---
>
> (Updated Dec. 13, 2013, 3:05 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith
> Haridasan.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> ---
>
> Replaced Text {} by PlasmaComponents.Label {}
>
>
> Diffs
> -
>
> mediaelements/mediawelcome/BackendsListDelegate.qml e76af63
> mediaelements/mediawelcome/HomeScreenText.qml 35cd20a
>
> Diff: https://git.reviewboard.kde.org/r/114428/diff/
>
>
> Testing
> ---
>
> works fine .
>
>
> Thanks,
>
> Heena Mahour
>
>
Re: Review Request 117139: Make menu strings conform to KDE's usability guidelines. Capitalize menu words.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117139/#review99445 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma. Please reopen. Thanks - David Edmundson On March 28, 2014, 5:12 p.m., Nikolaos Chatzidakis wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117139/ > --- > > (Updated March 28, 2014, 5:12 p.m.) > > > Review request for Plasma and Shantanu Tushar. > > > Repository: plasma-mediacenter > > > Description > --- > > This patch is created to provide uniform string format to pmc according to > our Visual Design Group's guidelines ( > http://techbase.kde.org/Projects/Usability/HIG/Capitalization ). All menu > strings are converted so words start with capital letter. > > > Diffs > - > > browsingbackends/localfiles/localmusic/localmusic.desktop ab47666 > browsingbackends/localfiles/localpictures/localpictures.desktop 4ffe275 > browsingbackends/localfiles/localvideos/localvideos.desktop 4f22968 > > browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.desktop > 93b7c62 > > browsingbackends/metadatabackends/metadatapicturebackend/metadatapicturebackend.desktop > a06a168 > > browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop > 9d04068 > browsingbackends/onlineservices/youtube/youtubebackend.desktop 4b3ba9c > browsingbackends/utility/fullscreen/pmcfullscreen.desktop c992932 > > Diff: https://git.reviewboard.kde.org/r/117139/diff/ > > > Testing > --- > > > Thanks, > > Nikolaos Chatzidakis > >
Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114428/
---
(Updated Sept. 22, 2016, 8:32 p.m.)
Status
--
This change has been discarded.
Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
Repository: plasma-mediacenter
Description
---
Replaced Text {} by PlasmaComponents.Label {}
Diffs
-
mediaelements/mediawelcome/BackendsListDelegate.qml e76af63
mediaelements/mediawelcome/HomeScreenText.qml 35cd20a
Diff: https://git.reviewboard.kde.org/r/114428/diff/
Testing
---
works fine .
Thanks,
Heena Mahour
Re: Review Request 111770: Implemented search feature in Local Browsing.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111770/#review99443 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma. Please reopen. Thanks - David Edmundson On Sept. 10, 2013, 7:31 p.m., Akshay Ratan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/111770/ > --- > > (Updated Sept. 10, 2013, 7:31 p.m.) > > > Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith > Haridasan. > > > Repository: plasma-mediacenter > > > Description > --- > > Plasma Media Center now supports searching in local files and media. Used > Regular expression to match the name. > > Request to merge the branch akshay_localSearch to master of PMC. > > > Diffs > - > > browsingbackends/localfiles/localfilesabstractbackend.h 84758e4 > browsingbackends/localfiles/localfilesabstractbackend.cpp 1144e49 > browsingbackends/localfiles/localfilesabstractmodel.h 43f50b7 > browsingbackends/localfiles/localfilesabstractmodel.cpp ebfc602 > mediaelements/mediabrowser/MediaBrowser.qml 6ae777f > > Diff: https://git.reviewboard.kde.org/r/111770/diff/ > > > Testing > --- > > Works as intended. > > > Thanks, > > Akshay Ratan > >
Re: Review Request 119575: Fix krunner contacts pllugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119575/ --- (Updated Sept. 22, 2016, 8:31 p.m.) Status -- This change has been discarded. Review request for KDEPIM and Plasma. Bugs: 282567 http://bugs.kde.org/show_bug.cgi?id=282567 Repository: kdeplasma-addons Description --- Fix krunner contacts plugin to lookup contacts through Akonadi Diffs - runners/contacts/contactsrunner.h 9bcb40d34a40dad414ea5154b745c97c18d6d81b runners/contacts/contactsrunner.cpp 2261e3744c695d046ec95e6dd97f1ad26c800d71 Diff: https://git.reviewboard.kde.org/r/119575/diff/ Testing --- Compiled, installed and tested locally Thanks, Marc Deop
Re: Review Request 119575: Fix krunner contacts pllugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119575/#review99442 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma. Please reopen. Thanks - David Edmundson On Aug. 9, 2014, 11:55 a.m., Marc Deop wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119575/ > --- > > (Updated Aug. 9, 2014, 11:55 a.m.) > > > Review request for KDEPIM and Plasma. > > > Bugs: 282567 > http://bugs.kde.org/show_bug.cgi?id=282567 > > > Repository: kdeplasma-addons > > > Description > --- > > Fix krunner contacts plugin to lookup contacts through Akonadi > > > Diffs > - > > runners/contacts/contactsrunner.h 9bcb40d34a40dad414ea5154b745c97c18d6d81b > runners/contacts/contactsrunner.cpp > 2261e3744c695d046ec95e6dd97f1ad26c800d71 > > Diff: https://git.reviewboard.kde.org/r/119575/diff/ > > > Testing > --- > > Compiled, installed and tested locally > > > Thanks, > > Marc Deop > >
Re: Review Request 119990: Fix libraries and includes to follow the KF5 naming scheme
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119990/ --- (Updated Sept. 22, 2016, 8:31 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: libksysguard Description --- Since libksysguard probably aims to be a framework, the libraries should have respective names and includes should be installed to KF5_INCLUE_INSTALL_DIR. Solves conflicts with KDE 4. Diffs - ksgrd/CMakeLists.txt 64ad24a lsofui/CMakeLists.txt 2b0c8ac processcore/CMakeLists.txt 31eee10 processui/CMakeLists.txt 150e198 signalplotter/CMakeLists.txt 67aa8bb Diff: https://git.reviewboard.kde.org/r/119990/diff/ Testing --- Builds, installs, libraries are called libKF5*.so, includes in /usr/include/KF5/KSysGuard/ Thanks, Daniel Vrátil
Re: Review Request 119990: Fix libraries and includes to follow the KF5 naming scheme
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119990/#review99441 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma. Please reopen. - David Edmundson On Aug. 29, 2014, 1 p.m., Daniel Vrátil wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119990/ > --- > > (Updated Aug. 29, 2014, 1 p.m.) > > > Review request for Plasma. > > > Repository: libksysguard > > > Description > --- > > Since libksysguard probably aims to be a framework, the libraries should have > respective names and includes should be installed to KF5_INCLUE_INSTALL_DIR. > Solves conflicts with KDE 4. > > > Diffs > - > > ksgrd/CMakeLists.txt 64ad24a > lsofui/CMakeLists.txt 2b0c8ac > processcore/CMakeLists.txt 31eee10 > processui/CMakeLists.txt 150e198 > signalplotter/CMakeLists.txt 67aa8bb > > Diff: https://git.reviewboard.kde.org/r/119990/diff/ > > > Testing > --- > > Builds, installs, libraries are called libKF5*.so, includes in > /usr/include/KF5/KSysGuard/ > > > Thanks, > > Daniel Vrátil > >
Re: Review Request 126640: [WindowThumbnail] Discard pixmap on map events.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126640/#review99440 --- Ship it! So sorry we missed this for so long. I'm not sure what happened. I'll merge this now. - David Edmundson On Jan. 5, 2016, 3:35 p.m., Mihail Ivchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126640/ > --- > > (Updated Jan. 5, 2016, 3:35 p.m.) > > > Review request for kwin and Plasma. > > > Repository: plasma-framework > > > Description > --- > > According to [X.org > docs](http://www.x.org/releases/X11R7.7/doc/compositeproto/compositeproto.txt) > regarding NameWindowPixmap: > > "This pixmap will remain allocated until freed, even if 'window' is unmapped, > reconfigured or destroyed. However, 'window' will get a new pixmap allocated > each time it is mapped or resized, so this request will need to be reinvoked" > > So, pixmap needs to be discarded not only on XCB_CONFIGURE_NOTIFY event but > on XCB_MAP_NOTIFY event also. > > > Diffs > - > > src/declarativeimports/core/windowthumbnail.cpp 21e655e > > Diff: https://git.reviewboard.kde.org/r/126640/diff/ > > > Testing > --- > > Tested by using simple qml app with WindowThumbnail and > minimizing\unminimizing of corresponding window. Now after unminimizing > pixmap is still valid and live updating works. > > > Thanks, > > Mihail Ivchenko > >
Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126524/ --- (Updated Sept. 22, 2016, 3:56 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and David Edmundson. Changes --- Submitted with commit 50445f794b3142f29dcc043f3af83c549c694bcd by David Edmundson on behalf of Joshua Noack to branch Plasma/5.8. Repository: sddm-kcm Description --- For some reason sddm cannot handle absolute file paths to wallpapers and also needs the wallpaper to be readable by others. This is fixed by copying the wallpaper to the root directory of the selected theme. On save the sddmauthhelper copies the background from the absolute path into the theme directory and sets the "background" key of the theme.user.conf to the copied file. If previously a different background was set it is removed beforehand. Diffs - sddmauthhelper.cpp 648b24c77e7570641d454fca9d121709a622bc36 src/themeconfig.cpp bdd6dd29fd8eb052e2f2b2239b0c46ebbebec88c Diff: https://git.reviewboard.kde.org/r/126524/diff/ Testing --- Copies and removes backgrounds as intended. The wallpaper is shown in sddm. Thanks, Joshua Noack
Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128949/ --- (Updated Sept. 22, 2016, 7:24 p.m.) Status -- This change has been marked as submitted. Review request for kde-workspace and Plasma. Changes --- Submitted with commit 9e44ca1112bea650a190411ee0783e60c10758e3 by David Edmundson on behalf of Pascal VITOUX to branch master. Repository: ksysguard Description --- Add monitors for Linux memory infos dirty and writeback A usecase can be the monitoring of datas being written to a slow storage device like a USB mass storage before umounting and removing it. Diffs - ksysguardd/Linux/Memory.h 2dbd6f2 ksysguardd/Linux/Memory.c 1bc3ace Diff: https://git.reviewboard.kde.org/r/128949/diff/ Testing --- Works as expected in the ksysguard GUI application (system monitor). Also, I use it with a plasma widget almost everyday since several months without issue. Thanks, Pascal VITOUX
Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback
> On sep. 22, 2016, 8:53 après-midi, David Edmundson wrote: > > Do you have commit access? No I don't. - Pascal --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128949/#review99427 --- On sep. 22, 2016, 4:01 après-midi, Pascal VITOUX wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128949/ > --- > > (Updated sep. 22, 2016, 4:01 après-midi) > > > Review request for kde-workspace and Plasma. > > > Repository: ksysguard > > > Description > --- > > Add monitors for Linux memory infos dirty and writeback > > A usecase can be the monitoring of datas being written to a slow storage > device like a USB mass storage before umounting and removing it. > > > Diffs > - > > ksysguardd/Linux/Memory.h 2dbd6f2 > ksysguardd/Linux/Memory.c 1bc3ace > > Diff: https://git.reviewboard.kde.org/r/128949/diff/ > > > Testing > --- > > Works as expected in the ksysguard GUI application (system monitor). > Also, I use it with a plasma widget almost everyday since several months > without issue. > > > Thanks, > > Pascal VITOUX > >
Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128949/#review99427 --- Ship it! Do you have commit access? - David Edmundson On Sept. 22, 2016, 2:01 p.m., Pascal VITOUX wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128949/ > --- > > (Updated Sept. 22, 2016, 2:01 p.m.) > > > Review request for kde-workspace and Plasma. > > > Repository: ksysguard > > > Description > --- > > Add monitors for Linux memory infos dirty and writeback > > A usecase can be the monitoring of datas being written to a slow storage > device like a USB mass storage before umounting and removing it. > > > Diffs > - > > ksysguardd/Linux/Memory.h 2dbd6f2 > ksysguardd/Linux/Memory.c 1bc3ace > > Diff: https://git.reviewboard.kde.org/r/128949/diff/ > > > Testing > --- > > Works as expected in the ksysguard GUI application (system monitor). > Also, I use it with a plasma widget almost everyday since several months > without issue. > > > Thanks, > > Pascal VITOUX > >
[Differential] [Closed] D2839: make media frame start with random image if set to random
This revision was automatically updated to reflect the committed changes. Closed by commit rKDEPLASMAADDONS5be10115438c: Make media frame start with random image if set to random (authored by jnicolay, committed by davidedmundson). REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2839?vs=6880=6882 REVISION DETAIL https://phabricator.kde.org/D2839 AFFECTED FILES applets/mediaframe/package/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, jnicolay Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Widget's Configuration Icon Colors
Hi! My desktop is configured as follows: Look and Feel: Breeze Desktop Theme: Breeze Screenshot 1 shows Kickoff's Application Launcher Settings Now I change Desktop Theme to Breeze Dark Screenshot 2 shows Kickoff's Application Launcher Settings again. As you can see the Icon (start-here-kde) and the Menu Buttons appear as white. Is there any way to change the SVG's icon color (not the button's) to dark (possibly text color or something dark)? Thanks! [Screenshot 1]: http://jsalatas.ictpro.gr/01.png [Screenshot 2]: http://jsalatas.ictpro.gr/02.png John Salatas Web Page: http://jsalatas.ictpro.gr
[Differential] [Commandeered] D2839: make media frame start with random image if set to random
davidedmundson commandeered this revision. davidedmundson edited reviewers, added: jnicolay; removed: davidedmundson. This revision now requires review to proceed. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D2839 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, jnicolay Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D2839: make media frame start with random image if set to random
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D2839 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jnicolay, #plasma, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 7 lines] D2839: make media frame start with random image if set to random
jnicolay created this revision. jnicolay added a reviewer: Plasma. jnicolay set the repository for this revision to rKDEPLASMAADDONS Plasma Addons. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY On startup the media frame will always start with the same image, even if random is selected. The reason is that the images are added to the list of items one by one and if no item is currently showing one will be picked as soon as it's available. In that case, always the first one that's discovered. The fix skips to the next (now random) item after loading is done when set to random. TEST PLAN 1. put media frame on desktop 2. add several images 3. set to random 4. restart plasma several times (killall plasmashell && kstart5 plasmashell) 5. without patch: the media frame will always start with the same image 6. with patch: a random image is choosen on every start REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D2839 AFFECTED FILES applets/mediaframe/package/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jnicolay, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D2837: Cleanup test case properly
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMASDKd5e06ba31129: Cleanup test case properly (authored by davidedmundson). REPOSITORY rPLASMASDK Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2837?vs=6878=6881 REVISION DETAIL https://phabricator.kde.org/D2837 AFFECTED FILES plasmate/app/tests/projecthandlertest.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, bshah Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D2837: Cleanup test case properly
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rPLASMASDK Plasma SDK BRANCH master REVISION DETAIL https://phabricator.kde.org/D2837 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, bshah Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 6 lines] D2838: Fix memory leak + cleanup in projecthandlertest
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Had to open the file to fix something. Fixed some obvious improvements REPOSITORY rPLASMASDK Plasma SDK BRANCH master REVISION DETAIL https://phabricator.kde.org/D2838 AFFECTED FILES plasmate/app/tests/projecthandlertest.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 1 line] D2837: Cleanup test case properly
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise if a test fails it would leave a dangling folder which causes subsequent tests to fail, which in turn means it doesn't clean up properly. TEST PLAN Broke my test Tests then always failed leaving stray dir Applied patch Ran twice Second time now passes again Possibly fix CI REPOSITORY rPLASMASDK Plasma SDK BRANCH master REVISION DETAIL https://phabricator.kde.org/D2837 AFFECTED FILES plasmate/app/tests/projecthandlertest.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 1 line] D2836: Enable high DPI support in KCMShell
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I already have this set in system settings for a year so this won't cause any new problems. REPOSITORY rKDECLITOOLS KDE CLI Utilities BRANCH master REVISION DETAIL https://phabricator.kde.org/D2836 AFFECTED FILES kcmshell/main.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D2835: add a temporary timer
mart added a comment. In https://phabricator.kde.org/D2835#52790, @davidedmundson wrote: > have you seen Aleix's timing stuff in p-f? i don't think it's really useful anymore, as in plasma-framework just tracks how long it takes to build the corona/containments/applets, which is negligible, then building the qml stuff starts... REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2835 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
