[sysadmin/ci-tooling] system-images: Include libXxf86vm in our images for KGamma5.

[Ben Cooksley]

Git commit fb5f3e02330c9d8a95d1580f16adbf7ca016da90 by Ben Cooksley.
Committed on 15/01/2020 at 07:29.
Pushed by bcooksley into branch 'master'.

Include libXxf86vm in our images for KGamma5.

CCMAIL: plasma-devel@kde.org

M  +2-0system-images/suse-qt512/Dockerfile
M  +2-0system-images/suse-qt513/Dockerfile

https://invent.kde.org/sysadmin/ci-tooling/commit/fb5f3e02330c9d8a95d1580f16adbf7ca016da90

diff --git a/system-images/suse-qt512/Dockerfile 
b/system-images/suse-qt512/Dockerfile
index 334b62c..6a3cc53 100755
--- a/system-images/suse-qt512/Dockerfile
+++ b/system-images/suse-qt512/Dockerfile
@@ -98,6 +98,8 @@ RUN zypper --non-interactive in --allow-vendor-change \
 # kwin
 libepoxy-devel Mesa-demo Mesa-demo-x xorg-x11-server-extra 
dmz-icon-theme-cursors libgbm-devel weston \
 xorg-x11-server-wayland \
+# kgamma5
+libXxf86vm-devel \
 # kgraphviewer
 graphviz-devel \
 # drkonqi
diff --git a/system-images/suse-qt513/Dockerfile 
b/system-images/suse-qt513/Dockerfile
index dfb8207..dc7dd16 100755
--- a/system-images/suse-qt513/Dockerfile
+++ b/system-images/suse-qt513/Dockerfile
@@ -98,6 +98,8 @@ RUN zypper --non-interactive in --allow-vendor-change \
 # kwin
 libepoxy-devel Mesa-demo Mesa-demo-x xorg-x11-server-extra 
dmz-icon-theme-cursors libgbm-devel weston \
 xorg-x11-server-wayland \
+# kgamma5
+libXxf86vm-devel \
 # kgraphviewer
 graphviz-devel \
 # drkonqi

D26681: [TabBox] Thumbnail Grid window switcher

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  Cleaned up my code from https://github.com/Zren/kwin-tabbox-thumbnail_grid
  
  The column is calculated recursively, but survived a stress test.
  https://github.com/Zren/kwin-tabbox-thumbnail_grid/pull/2
  
  > I tested when "show desktop" is configured to be hidden since I know it 
didn't like it with modding by 0 items in the python test. "show desktop" will 
show up on an empty desktop though so there's always at least 1 item it seems.
  
  I wrote a python script to easily test the recursive column calculation with 
__ number of windows.
  
https://github.com/Zren/kwin-tabbox-thumbnail_grid/blob/master/test_recursion.py

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26681

AFFECTED FILES
  windowswitchers/CMakeLists.txt
  windowswitchers/thumbnail_grid/contents/ui/main.qml
  windowswitchers/thumbnail_grid/metadata.desktop

To: Zren
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26680: [kcms/feedback] Implement setRepresentsDefaults

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Moved slider
  Defaults button enabled/disabled appropriately

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26680

AFFECTED FILES
  kcms/feedback/feedback.cpp
  kcms/feedback/feedback.h

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26679: [kcms/feedback] Fix default button not showing

[David Edmundson]

davidedmundson updated this revision to Diff 73588.
davidedmundson added a comment.


  stupid phab

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26679?vs=73587=73588

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26679

AFFECTED FILES
  kcms/feedback/package/contents/ui/main.qml

To: davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26679: [kcms/feedback] Fix default button not showing

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26679

AFFECTED FILES
  kcms/feedback/package/contents/ui/main.qml

To: davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26678: [kcms/feedback] Fix slider value

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  If the kcm's property changes externally we don't update the slider
  after the initial load, which is before KConfigModule::load which actually 
sets
  the property.
  
  Whilst there is an alternative fix calling load() a second time, we need
  this anyway for default and reset buttons to work correctly.
  
  I also think the original code was broken, I don't see why we would map
  the value back to modeOptions[idx], we want the slider value to be the
  index of the array, not the enum value. They just happen to be the same.

TEST PLAN
  Opened KCM changed it, opened KCM repeat

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26678

AFFECTED FILES
  kcms/feedback/package/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26676: [applets/calculator] Use Qt's in-built number formatting

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:a51086867c0f: [applets/calculator] Use Qts in-built 
number formatting (authored by davidedmundson).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26676?vs=73580=73583

REVISION DETAIL
  https://phabricator.kde.org/D26676

AFFECTED FILES
  applets/calculator/package/contents/ui/calculator.qml

To: davidedmundson, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26676: [applets/calculator] Use Qt's in-built number formatting

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Can confirm that it fixes the bug, and the code change looks sane to me.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26676

To: davidedmundson, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26421: Only show full name in review dialog

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:ec5464e70642: Only show full name in review dialog 
(authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26421?vs=72767=73582

REVISION DETAIL
  https://phabricator.kde.org/D26421

AFFECTED FILES
  libdiscover/appstream/OdrsReviewsBackend.cpp

To: ngraham, #discover_software_store, apol
Cc: jgrulich, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26421: Only show full name in review dialog

[Nathaniel Graham]

ngraham added a comment.


  Thanks!

REPOSITORY
  R134 Discover Software Store

BRANCH
  full-name-only (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26421

To: ngraham, #discover_software_store, apol
Cc: jgrulich, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26676: [applets/calculator] Use Qt's in-built number formatting

[Nathaniel Graham]

ngraham added a reviewer: VDG.
ngraham added a comment.


  > Potentially this inadvertedly introduces a behaviour change
  >  of including group separators depending on locale.
  >  Is this a a good feature?
  
  I can't speak for everyone, but personally I like seeing the localized 
separators as I feel like they make it easier to read long numbers.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26676

To: davidedmundson, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26676: [applets/calculator] Use Qt's in-built number formatting

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Gets rid of a load of code. 
  Correctly handles floating point issues.
  Results are correct.
  
  Potentially this inadvertedly introduces a behaviour change
  of including group separators depending on locale. 
  Is this a a good feature?
  
  BUG: 410988

TEST PLAN
  62 * 1.3 = 80.6
  
  1 * 500 = 5e+17
  (with whatever the right number of zeroes is)
  
  42 * 1.3 = 6.665

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26676

AFFECTED FILES
  applets/calculator/package/contents/ui/calculator.qml

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26675: [sddm-theme] Don't have a broken reveal password button

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  sddm-greeter will have a button for the reveal password button, but due
  to sddm-greeter not loading a relevant QPT has no code to force it to
  load the breeze icon set.
  
  Without the breeze icon set, the clear button does not show.
  
  There are ways to solve this, but none are trivial or reliable.
  
  I threatened to do a revert in 5.12 (https://phabricator.kde.org/D9040)
  but the bug has still not been fixed since.
  
  BUG: 396039
  CCBUG: 387418

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26675

AFFECTED FILES
  sddm-theme/Login.qml

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26672: Fix crash when loading a top level entry from system settings home page

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:27b8f182409a: Fix crash when loading a top level entry 
from system settings home page (authored by davidedmundson).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26672?vs=73570=73575

REVISION DETAIL
  https://phabricator.kde.org/D26672

AFFECTED FILES
  sidebar/SidebarMode.cpp

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:8be6fb749ced: [wallpapers/image] Add default XDG 
wallpaper locations for slideshow (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26483?vs=73572=73574

REVISION DETAIL
  https://phabricator.kde.org/D26483

AFFECTED FILES
  wallpapers/image/image.cpp
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: ngraham, #plasma, #vdg, ndavis, davidedmundson
Cc: davidre, broulik, davidedmundson, ndavis, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow

[Nathaniel Graham]

ngraham added a comment.


  Thanks David!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  add-a-default-wallpaper-slideshow-location (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26483

To: ngraham, #plasma, #vdg, ndavis, davidedmundson
Cc: davidre, broulik, davidedmundson, ndavis, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow

[Nathaniel Graham]

ngraham updated this revision to Diff 73571.
ngraham marked an inline comment as done.
ngraham added a comment.


  Shallow copy instead of deep copy

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26483?vs=73067=73571

BRANCH
  add-a-default-wallpaper-slideshow-location (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26483

AFFECTED FILES
  wallpapers/image/image.cpp
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: ngraham, #plasma, #vdg, ndavis, davidedmundson
Cc: davidre, broulik, davidedmundson, ndavis, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow

[Nathaniel Graham]

ngraham updated this revision to Diff 73572.
ngraham added a comment.


  Rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26483?vs=73571=73572

BRANCH
  add-a-default-wallpaper-slideshow-location (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26483

AFFECTED FILES
  wallpapers/image/image.cpp
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: ngraham, #plasma, #vdg, ndavis, davidedmundson
Cc: davidre, broulik, davidedmundson, ndavis, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> davidedmundson wrote in image.cpp:362
> there's two mistakes that cancel kinda each other out here.
> 
> typically, this should be qAsConst(m_slidePaths)
> m_slidePaths here detatches and does a full deep-copy
> 
> https://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops/
> 
> BUT:
> 
> you modify m_slidePaths whilst you are iterating through m_slidePaths. If we 
> hadn't accidentally detached this would be very crashy dangerous code.
> 
> Feel free to claim it was deliberate because you are a genius.
> 
> -
> 
> However, rather than a deep copy ideally we would just force a shallow copy 
> i.e
> 
> const QStringList preprocssedPaths = m_slidePaths;
> for (const QString : preprocssedPaths) {
> ...
> }
> 
> best of all worlds

haha, in fact it was deliberate, but I'm hardly a genius, and your suggestion 
makes more sense. I'll do that.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26483

To: ngraham, #plasma, #vdg, ndavis, davidedmundson
Cc: davidre, broulik, davidedmundson, ndavis, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26672: Fix crash when loading a top level entry from system settings home page

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26672

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26672: Fix crash when loading a top level entry from system settings home page

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  BUG: 416227

TEST PLAN
  Clicked "look and feel" from the home screen

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26672

AFFECTED FILES
  sidebar/SidebarMode.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  >> my complain here is that this argument was either not made or discarded, 
when the first switch to thin scrollbar was done.
  >>  This is my main concern about this change: the going back and forth using 
adhoc arguments each time to justify the change, often contradicting each 
other.  It means essentially that we either don't know what we are doing, or 
dont think our changes enough. This is bad imo
  > 
  > If I had been around back then or noticed the patch, I would have made this 
argument.
  
  For the record, you were around for the original commit that made the 
scrollbar thiner (https://phabricator.kde.org/D9792)

REPOSITORY
  R31 Breeze

BRANCH
  phab/scrollbarseparator

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> image.cpp:362
> +// Replace 'preferred://wallpaperlocations' with real paths
> +for (QString  : m_slidePaths) {
> +if (path == QLatin1String("preferred://wallpaperlocations")) {

there's two mistakes that cancel kinda each other out here.

typically, this should be qAsConst(m_slidePaths)
m_slidePaths here detatches and does a full deep-copy

https://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops/

BUT:

you modify m_slidePaths whilst you are iterating through m_slidePaths. If we 
hadn't accidentally detached this would be very crashy dangerous code.

Feel free to claim it was deliberate because you are a genius.

-

However, rather than a deep copy ideally we would just force a shallow copy i.e

const QStringList preprocssedPaths = m_slidePaths;
for (const QString : preprocssedPaths) {
...
}

best of all worlds

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26483

To: ngraham, #plasma, #vdg, ndavis, davidedmundson
Cc: davidre, broulik, davidedmundson, ndavis, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26660: [Applets/Task Manager] Fix and improve behavior tab layouts

[George Vogiatzis]

gvgeo updated this revision to Diff 73569.
gvgeo edited the test plan for this revision.
gvgeo added a comment.


  On more careful examination, "Group only when the Task Manager is full" 
option, does not affect grouping, when "combing into single button" is disabled.
  Flipped back the order of the 2 options, and brought back the condition and 
text.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26660?vs=73516=73569

BRANCH
  config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26660

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26483

To: ngraham, #plasma, #vdg, ndavis, davidedmundson
Cc: davidre, broulik, davidedmundson, ndavis, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26421: Only show full name in review dialog

[Nathaniel Graham]

ngraham added a comment.


  @apol ping.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D26421

To: ngraham, #discover_software_store, apol
Cc: jgrulich, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Long press global shortcuts

[Nate Graham]

On 1/14/20 1:07 PM, Aleix Pol wrote:

We are talking about shortcuts for physical keys (e.g. keyboard, the 3
or 4 buttons you'd have on a phone).


Oh my mistake, sorry.

One thing I miss from macOS is long-pressing a key on the keyboard to 
display a pop-up containing accented and other non-Latin versions of 
that character. It was much more discoverable and user-friendly than 
using a compose key shortcut or an IBus input method. This behavior was 
implemented on long-press (not release) for keyboard keys, so if the 
proposed change would allow us to gain something like this, that would 
be nice.


Nate

Re: Long press global shortcuts

[Aleix Pol]

On Tue, Jan 14, 2020 at 9:05 PM Nate Graham  wrote:
>
> On 1/12/20 10:11 AM, Aleix Pol wrote:
> > The second part of this is why I'm sending this e-mail. We're
> > responding to global shortcuts on press rather than on release, which
> > makes it impossible to handle the long press. Would it make sense to
> > change it to on release? Maybe only in the cases where there's a long
> > press counterpart?
>
> It might depend on what action the long-press is going to trigger. For
> long-press to show a mobile-friendly grid-based context menu, it might
> be nice to be able to long-press, slide your finger over to the item you
> want to select, then release it. In this case, the release would trigger
> the item under the finger, if any.
>
> I continue to believe that long-click almost never makes sense when
> using a pointing device, though. :)

We are talking about shortcuts for physical keys (e.g. keyboard, the 3
or 4 buttons you'd have on a phone).

Aleix

Re: Long press global shortcuts

[Nate Graham]

On 1/12/20 10:11 AM, Aleix Pol wrote:

The second part of this is why I'm sending this e-mail. We're
responding to global shortcuts on press rather than on release, which
makes it impossible to handle the long press. Would it make sense to
change it to on release? Maybe only in the cases where there's a long
press counterpart?


It might depend on what action the long-press is going to trigger. For 
long-press to show a mobile-friendly grid-based context menu, it might 
be nice to be able to long-press, slide your finger over to the item you 
want to select, then release it. In this case, the release would trigger 
the item under the finger, if any.


I continue to believe that long-click almost never makes sense when 
using a pointing device, though. :)


Nate

D26565: KCM/Component Revamp email config

[Nathaniel Graham]

ngraham added a comment.


  Let me know if and when this is reviewable, or if it's still WIP.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26565

To: meven, ngraham, ervin, #plasma, bport, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24070: [WIP] Don't use toolTipMainText to show info, rather use the second line

[Nathaniel Graham]

ngraham updated this revision to Diff 73554.
ngraham added a comment.


  Fix FIXME and don't show "Calculating blah..." text in subtitle when exact 
time isn't available

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24070?vs=73088=73554

BRANCH
  arcpatch-D24070

REVISION DETAIL
  https://phabricator.kde.org/D24070

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: ngraham, #vdg, #plasma, ndavis, mthw
Cc: GB_2, ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26654: support mobile mode scrollbar

[Nathaniel Graham]

ngraham accepted this revision as: VDG, ngraham.
ngraham added a comment.
This revision is now accepted and ready to land.


  Seems like that's a local issue actually.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  phab/mobilescrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26654

To: mart, #plasma, #vdg, #kirigami, ngraham
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24748: [containmentlayoutmanager] Don't accept button events that only start timers

[Nathaniel Graham]

ngraham added a comment.


  This patch fixes the bug, but it does indeed break leaving per-widget edit 
mode. Could we also exit that on left-click regardless of what other action it 
performs?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24748

To: davidedmundson, #plasma
Cc: ngraham, anthonyfieroni, wbauer, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kgamma5 » kf5-qt5 SUSEQt5.12 - Build # 24 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kgamma5/job/kf5-qt5%20SUSEQt5.12/24/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 14 Jan 2020 17:53:18 +
 Build duration:
54 sec and counting
   CONSOLE OUTPUT
  [...truncated 228 lines...][2020-01-14T17:54:10.127Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kgamma5/job/kf5-qt5%20SUSEQt5.12/'[2020-01-14T17:54:10.127Z] BUILD_NUMBER  = '24'[2020-01-14T17:54:10.127Z] _ = '/usr/bin/python3'[2020-01-14T17:54:10.127Z] XKEYSYMDB = '/usr/X11R6/lib/X11/XKeysymDB'[2020-01-14T17:54:10.127Z] BUILD_DISPLAY_NAME= '#24'[2020-01-14T17:54:10.127Z] XNLSPATH  = '/usr/X11R6/lib/X11/nls'[2020-01-14T17:54:10.127Z] HOME  = '/home/jenkins/'[2020-01-14T17:54:10.127Z] JENKINS_URL   = 'https://build.kde.org/'[2020-01-14T17:54:10.127Z] JOB_BASE_NAME = 'kf5-qt5 SUSEQt5.12'[2020-01-14T17:54:10.127Z] OSTYPE= 'linux'[2020-01-14T17:54:10.127Z] JOB_NAME  = 'Plasma/kgamma5/kf5-qt5 SUSEQt5.12'[2020-01-14T17:54:10.127Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2020-01-14T17:54:10.127Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kgamma5/job/kf5-qt5%20SUSEQt5.12/24/display/redirect'[2020-01-14T17:54:10.127Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kgamma5/job/kf5-qt5%20SUSEQt5.12/display/redirect'[2020-01-14T17:54:10.127Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kgamma5/kf5-qt5 SUSEQt5.12'[2020-01-14T17:54:10.127Z] HUDSON_URL= 'https://build.kde.org/'[2020-01-14T17:54:10.127Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-01-14T17:54:10.127Z] NODE_NAME = 'Docker Swarm-2a98971f2306'[2020-01-14T17:54:10.127Z] HOST  = '2a98971f2306'[2020-01-14T17:54:10.127Z] LESSOPEN  = 'lessopen.sh %s'[2020-01-14T17:54:10.127Z] USER  = 'jenkins'[2020-01-14T17:54:10.127Z] MORE  = '-sl'[2020-01-14T17:54:10.127Z] CSHEDIT   = 'emacs'[2020-01-14T17:54:10.127Z] SHLVL = '2'[2020-01-14T17:54:10.127Z] BUILD_TAG = 'jenkins-Plasma-kgamma5-kf5-qt5 SUSEQt5.12-24'[2020-01-14T17:54:10.127Z] WINDOWMANAGER = 'xterm'[2020-01-14T17:54:10.127Z] PAGER = 'less'[2020-01-14T17:54:10.127Z] EXECUTOR_NUMBER   = '0'[2020-01-14T17:54:10.127Z] CVS_RSH   = 'ssh'[2020-01-14T17:54:10.127Z] LIBGL_DEBUG   = 'quiet'[2020-01-14T17:54:10.127Z] STAGE_NAME= 'Configuring Build'[2020-01-14T17:54:10.127Z] NODE_LABELS   = 'Docker Swarm-2a98971f2306 SUSEQt5.12'[2020-01-14T17:54:10.127Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-01-14T17:54:10.127Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-01-14T17:54:10.127Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-01-14T17:54:10.127Z] PROFILEREAD   = 'true'[2020-01-14T17:54:10.127Z] MAIL  = '/var/spool/mail/jenkins'[2020-01-14T17:54:10.127Z] HOSTTYPE  = 'x86_64'[2020-01-14T17:54:10.127Z] BUILD_ID  = '24'[2020-01-14T17:54:10.127Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-01-14T17:54:10.128Z] OLDPWD= '/home/jenkins'[2020-01-14T17:54:10.128Z] LC_CTYPE  = 'C.UTF-8'[2020-01-14T17:54:10.128Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-01-14T17:54:10.128Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-01-14T17:54:10.128Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-01-14T17:54:10.128Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-01-14T17:54:10.128Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-01-14T17:54:10.128Z] QT_SELECT = 'qt5'[2020-01-14T17:54:10.128Z] LANG  = 'en_US.UTF-8'[2020-01-14T17:54:10.128Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-01-14T17:54:10.128Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-01-14T17:54:10.128Z] [2020-01-14T17:54:10.128Z] [2020-01-14T17:54:10.128Z] == Commencing Configuration:[2020-01-14T17:54:10.128Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/kgamma5/kf5-qt5 SUSEQt5.12"[2020-01-14T17:54:10.128Z] -- The C compiler identification is GNU 

D26223: Explictly state which X11 components are required

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R100:26f55f10c026: Explictly state which X11 components are 
required (authored by davidedmundson).

REPOSITORY
  R100 KGamma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26223?vs=72177=73552

REVISION DETAIL
  https://phabricator.kde.org/D26223

AFFECTED FILES
  CMakeLists.txt

To: davidedmundson, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26660: [Task Manager]Fix and improve configuration behavior

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks, this is a nice improvement, and thanks for fixing that bug which I 
caused when I originally rewrote the layout to use FormLayouts last year.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26660

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26665: Switch to KNSQuick for getting new wallpapers

[Victor Ryzhykh]

victorr added a comment.


downloadNewWhat: i18n("Wallpapers")
  
  But now the translation does not work.
  This is reported here https://bugs.kde.org/show_bug.cgi?id=415541
  Now I am fixing this error with three patches.
  
  F7883230: knewstuff-5.6-tr.patch 
  F7883232: plasma-workspace-5.17.80-fix.patch 

  F7883233: plasma-desktop-5.17.80-tr.patch 

  Before:
  F7883227: Before.jpeg 
  After: 
  F7883223: After.jpeg 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26665

To: leinir, mart, #plasma, ngraham
Cc: victorr, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D26655#594280 , @mart wrote:
  
  > In D26655#594257 , 
@hpereiradacosta wrote:
  >
  > > Is this really intended ? 
  > >  I would at least keep the color blending, making the color stronger only 
when the scrollbar is actually hovered.
  >
  >
  > ouch, well spotted, i will fix that :)
  
  
  Great :)
  And rebase to latest master, so that the patch appears cleanly :)

REPOSITORY
  R31 Breeze

BRANCH
  phab/scrollbarseparator

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26655: show a thin separator between view and scrollbar

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  I would start by
  
  - rebase this patch to apply cleanly
  - split it in two (one for the separator line and one for the think handle 
removal), because these are really two features, adressing two different issues:
  
  1: the floating bar
  2: the two small handle that few people dislike.
  
  Adding an option does not really solve anything (especially if it is not the 
default) in terms of the back and forth. 
  If everyone is ok with the back and forth, you should go with it. 
  I can always hack my own breeze clone so that I am happy with it. 
  Just warning how some users could feel about it.

REPOSITORY
  R31 Breeze

BRANCH
  phab/scrollbarseparator

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26655: show a thin separator between view and scrollbar

[Marco Martin]

mart added a comment.


  In D26655#594257 , 
@hpereiradacosta wrote:
  
  > Is this really intended ? 
  >  I would at least keep the color blending, making the color stronger only 
when the scrollbar is actually hovered.
  
  
  ouch, well spotted, i will fix that :)

REPOSITORY
  R31 Breeze

BRANCH
  phab/scrollbarseparator

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Nathaniel Graham]

ngraham added a comment.


  Phab strikes again...
  
  I would revert to a previous version of this patch using the history tab in 
the web UI, download the raw diff from the web UI, and then manually apply it 
on top of HEAD.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  switch-kcms-to-knsquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart, ngraham
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26586: [SystemTray] Rework system tray settings

[Nathaniel Graham]

ngraham added a comment.


  Use the QQC2 ScrollView, and we should fix that elsewhere.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: ahiemstra, mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D26655: show a thin separator between view and scrollbar

[Nathaniel Graham]

ngraham added a comment.


  In D26655#594250 , 
@hpereiradacosta wrote:
  
  > With all due respect: 
  >  This is irrelevant unless you do an actual poll. 
  >  You will have user feedback that want the thin scrollbar back. (I will).
  
  
  Sure, you can't please everyone. However we have gotten bug reports: 
https://bugs.kde.org/show_bug.cgi?id=396747. In addition, I spend a lot of time 
interacting with the community through social media and my blog. And I watch a 
lot of YouTube video of people reviewing Plasma. In those venues, I see people 
expressing this complaint a lot.
  
  I know it's not a scientific poll, but it's my impression. I can't do any 
better that that, I'm afraid.
  
  > my complain here is that this argument was either not made or discarded, 
when the first switch to thin scrollbar was done.
  >  This is my main concern about this change: the going back and forth using 
adhoc arguments each time to justify the change, often contradicting each 
other.  It means essentially that we either don't know what we are doing, or 
dont think our changes enough. This is bad imo
  
  If I had been around back then or noticed the patch, I would have made this 
argument.
  
  I understand the complaint about going back and forth on things. However I 
see it another way: it means we have the humility to acknowledge when a change 
didn't have the effect we were hoping. It means we are flexible and mature 
enough to try an experiment, see if it worked, and go back to the old thing if 
we see that it didn't work, or that our users didn't really like it. Personally 
I see this as a good thing.
  
  Anyway, I respect your opinion, Hugo, and maybe we can find a compromise. 
Perhaps we could make the always-thick behavior on by default but optional?

REPOSITORY
  R31 Breeze

BRANCH
  phab/scrollbarseparator

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26655: show a thin separator between view and scrollbar

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Removed previous comment because after testing the patch it turns out that 
this is not too strong of an issue. 
  However I also noticed that you not only removed the think handle but also 
the color blending. This make the handle not only larger but also stronger in 
terms of colors, especially in the case where the parent list has focus (you 
get a strong blue handle). 
  Is this really intended ? 
  I would at least keep the color blending, making the color stronger only when 
the scrollbar is actually hovered.

REPOSITORY
  R31 Breeze

BRANCH
  phab/scrollbarseparator

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26586: [SystemTray] Rework system tray settings

[Konrad Materka]

kmaterka added a comment.


  In D26586#594236 , @nicolasfella 
wrote:
  
  > There's a minor problem (that I've seen in other place as well). When 
scrolling the content overflows the frame on the top a bit:
  
  
  Should I use `import QtQuick.Controls 2.5 as QQC2` or `import 
org.kde.plasma.components 3.0 as PlasmaComponents` is preferred? With 
PlasmaComponents there is no problem with overflow, but there is no frame.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: ahiemstra, mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D26565: KCM/Component Revamp email config

[Méven Car]

meven updated this revision to Diff 73548.
meven added a comment.


  clean some unused incudes

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26565?vs=73547=73548

BRANCH
  email-config

REVISION DETAIL
  https://phabricator.kde.org/D26565

AFFECTED FILES
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser_ui.ui
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/emailclientconfig_ui.ui

To: meven, ngraham, ervin, #plasma, bport, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Also, concerning the separator line: how does it look with hovered 
scrollbars, when the handle grove is also rendered. 
  Isn't there some redundancy between the handle groove and the separator ? 
(essentially a frame inside a frame)
  should the handle groove be removed entirely ?

REPOSITORY
  R31 Breeze

BRANCH
  phab/scrollbarseparator

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26565: KCM/Component Revamp email config

[Méven Car]

meven updated this revision to Diff 73547.
meven added a comment.


  Allow to select any app as email client, mimeapps.list preferred email is the 
source of truth regarding default mail client, depends on KF5.67 (post plasma 
5.18)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26565?vs=73375=73547

BRANCH
  email-config

REVISION DETAIL
  https://phabricator.kde.org/D26565

AFFECTED FILES
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser_ui.ui
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/emailclientconfig_ui.ui

To: meven, ngraham, ervin, #plasma, bport, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D26655#594240 , @ngraham wrote:
  
  > Regarding the thickened scrollbars, I think it makes sense for a few 
reasons:
  >
  > - Acknowledging user feedback: we've had a bunch of complaints about the 
thin scrollbars.
  
  
  With all due respect: 
  This is irrelevant unless you do an actual poll. 
  You will have user feedback that want the thin scrollbar back. (I will).
  
  > - Usability: even though the click area was the same size for the thin 
inactive scrollbars, it didn't //look// as large. This can make people 
subconsciously position their cursors more precisely than they need to
  
  my complain here is that this argument was either not made or discarded, when 
the first switch to thin scrollbar was done. 
  This is my main concern about this change: the going back and forth using 
adhoc arguments each time to justify the change, often contradicting each 
other.  It means essentially that we either don't know what we are doing, or 
dont think our changes enough. This is bad imo
  
  > - If we draw a separator line but keep the thin scrollbar, then the track 
looks much too wide because the thin inactive scroll handle looks lost in the 
wide track. But we can't make the track narrower since it has to accommodate 
the scroll handle's thicker expanded width too. Much simpler and more visually 
pleasing to just make it always thicker and not change its size on hover.
  
  Matter of taste. It think I would be happy with thin handle and separator 
line.
  
  > - IMO the overall result just looks good. :)
  
  IMO so does the above (thin handle and separator line). With the advantage 
that it does not feel like a step backward.
  
  > F7883097: Screenshot_20200114_091952.png 

  > 
  > F7883099: Scrollers.png 
  > 
  > F7883100: Scroller 2.png 

REPOSITORY
  R31 Breeze

BRANCH
  phab/scrollbarseparator

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26655: show a thin separator between view and scrollbar

[Nathaniel Graham]

ngraham added a comment.


  Regarding the thickened scrollbars, I think it makes sense for a few reasons:
  
  - Acknowledging user feedback: we've had a bunch of complaints about the thin 
scrollbars.
  - Usability: even though the click area was the same size for the thin 
inactive scrollbars, it didn't //look// as large. This can make people 
subconsciously position their cursors more precisely than they need to
  - If we draw a separator line but keep the thin scrollbar, then the track 
looks much too wide because the thin inactive scroll handle looks lost in the 
wide track. But we can't make the track narrower since it has to accommodate 
the scroll handle's thicker expanded width too. Much simpler and more visually 
pleasing to just make it always thicker and not change its size on hover.
  - IMO the overall result just looks good. :)
  
  F7883097: Screenshot_20200114_091952.png 

  
  F7883099: Scrollers.png 
  
  F7883100: Scroller 2.png 

REPOSITORY
  R31 Breeze

BRANCH
  phab/scrollbarseparator

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26654: support mobile mode scrollbar

[Nathaniel Graham]

ngraham added a comment.


  Very nice! Overall it works very well. I found a few issues in QML KCMs:
  
  F7883084: Regression: Notifications KCM.jpg 

  
  F7883085: Regression: Desktop Effects KCM.jpg 


REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D26654

To: mart, #plasma, #vdg, #kirigami, ngraham
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26586: [SystemTray] Rework system tray settings

[Nicolas Fella]

nicolasfella added a comment.


  There's a minor problem (that I've seen in other place as well). When 
scrolling the content overflows the frame on the top a bit:
  
  See how the top frame is white while the side is blue
  F7883066: Screenshot_20200114_170622.png 

  
  Also the text/icon sometimes overflows:
  F7883073: Screenshot_20200114_170912.png 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: ahiemstra, mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir added a comment.


  Right, everything blew up i guess. Nice.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  switch-kcms-to-knsquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart, ngraham
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Nathaniel Graham]

ngraham accepted this revision as: VDG, ngraham.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oh man, I think this just looks so good everywhere.

REPOSITORY
  R31 Breeze

BRANCH
  phab/scrollbarseparator

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 73544.
leinir added a comment.


  - Merge remote-tracking branch 'origin/master' into switch-kcms-to-knsquick
  - Fix build (by removing stuff that was removed in master it seems)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26544?vs=73409=73544

BRANCH
  switch-kcms-to-knsquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26544

AFFECTED FILES
  CMakeLists.txt
  applets/icontasks/metadata.desktop
  applets/kicker/package/contents/ui/ActionMenu.qml
  applets/kicker/package/contents/ui/CompactRepresentation.qml
  applets/kicker/package/contents/ui/ConfigGeneral.qml
  applets/kicker/package/contents/ui/DashboardRepresentation.qml
  applets/kicker/package/contents/ui/DashboardTabBar.qml
  applets/kicker/package/contents/ui/DashboardTabButton.qml
  applets/kicker/package/contents/ui/ItemGridDelegate.qml
  applets/kicker/package/contents/ui/ItemGridView.qml
  applets/kicker/package/contents/ui/ItemListDelegate.qml
  applets/kicker/package/contents/ui/ItemListDialog.qml
  applets/kicker/package/contents/ui/ItemListView.qml
  applets/kicker/package/contents/ui/MenuRepresentation.qml
  applets/kicker/package/contents/ui/SideBarItem.qml
  applets/kicker/package/contents/ui/SideBarSection.qml
  applets/kicker/package/contents/ui/main.qml
  applets/kicker/package/metadata.desktop
  applets/kimpanel/backend/ibus/emojier/emojier.cpp
  applets/kimpanel/backend/ibus/emojier/org.kde.plasma.emojier.desktop
  applets/kimpanel/backend/ibus/emojier/resources.qrc
  applets/kimpanel/backend/ibus/emojier/ui/CategoryAction.qml
  applets/kimpanel/backend/ibus/emojier/ui/CategoryPage.qml
  applets/kimpanel/backend/ibus/emojier/ui/emojier.qml
  applets/kimpanel/package/contents/ui/main.qml
  applets/minimizeall/package/metadata.desktop
  applets/pager/package/contents/ui/main.qml
  applets/pager/plugin/windowmodel.cpp
  applets/showActivityManager/package/metadata.desktop
  applets/showdesktop/package/metadata.desktop
  applets/taskmanager/CMakeLists.txt
  applets/taskmanager/package/contents/ui/AudioStream.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/PulseAudio.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml
  applets/taskmanager/package/contents/ui/code/layout.js
  applets/taskmanager/plugin/backend.cpp
  applets/taskmanager/plugin/backend.h
  applets/window-list/metadata.desktop
  containments/desktop/package/contents/ui/ConfigOverlay.qml
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/plugins/folder/autotests/positionertest.cpp
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/panel/contents/ui/ConfigOverlay.qml
  design/plasmoids
  imports/activitymanager/CMakeLists.txt
  kcms/access/kcmaccess.desktop
  kcms/activities/BlacklistedApplicationsModel.cpp
  kcms/activities/CMakeLists.txt
  kcms/activities/ExtraActivitiesInterface.cpp
  kcms/activities/MainConfigurationWidget.cpp
  kcms/activities/MainConfigurationWidget.h
  kcms/activities/PrivacyTab.cpp
  kcms/activities/PrivacyTab.h
  kcms/activities/SwitchingTab.cpp
  kcms/activities/SwitchingTab.h
  kcms/activities/kactivitymanagerd_plugins_settings.kcfg
  kcms/activities/kactivitymanagerd_plugins_settings.kcfgc
  kcms/activities/kactivitymanagerd_settings.kcfg
  kcms/activities/kactivitymanagerd_settings.kcfgc
  kcms/activities/kcm_activities.desktop
  kcms/activities/qml/activitiesTab/ActivitiesView.qml
  kcms/activities/ui/PrivacyTabBase.ui
  kcms/activities/utils/dbusfuture_p.cpp
  kcms/activities/utils/dbusfuture_p.h
  kcms/autostart/autostart.cpp
  kcms/autostart/autostart.desktop
  kcms/baloo/CMakeLists.txt
  kcms/baloo/Messages.sh
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/kcm_baloofile.desktop
  kcms/baloo/package/metadata.desktop
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/colorsmodel.cpp
  kcms/colors/editor/org.kde.kcolorschemeeditor.desktop
  kcms/colors/filterproxymodel.cpp
  kcms/colors/kcm_colors.desktop
  kcms/colors/package/contents/ui/main.qml
  kcms/colors/package/metadata.desktop
  kcms/componentchooser/CMakeLists.txt
  kcms/componentchooser/EXAMPLE.desktop
  kcms/componentchooser/browser_settings.kcfg
  kcms/componentchooser/browser_settings.kcfgc
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser.desktop
  kcms/componentchooser/componentchooser.h
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooserbrowser.h
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserfilemanager.h
  kcms/componentchooser/componentchooserterminal.cpp
  kcms/componentchooser/componentchooserterminal.h
  

D26586: [SystemTray] Rework system tray settings

[Konrad Materka]

kmaterka added a comment.


  In D26586#594211 , @ngraham wrote:
  
  > Some of the code looks a bit hairy to me, but I don't see anything 
catastrophic. :)
  
  
  What exactly? I can quickly fix/refactor that.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: ahiemstra, mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D26654: support mobile mode scrollbar

[Marco Martin]

mart updated this revision to Diff 73542.
mart added a comment.


  - smoother transition

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26654?vs=73507=73542

BRANCH
  phab/mobilescrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26654

AFFECTED FILES
  org.kde.desktop/ScrollBar.qml

To: mart, #plasma, #vdg, #kirigami, ngraham
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26586: [SystemTray] Rework system tray settings

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yep, the freeze is on Friday. I think we can get this in before then.
  
  UI and behavior look good. Some of the code looks a bit hairy to me, but I 
don't see anything catastrophic. :) I'll let #plasma 
 folks do the final code review.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: ahiemstra, mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D26667: refactor about-distro to more generically support textual dumps

[Harald Sitter]

sitter added a comment.


  not sure if it's worth splitting into multiple files. personally I prefer 
many tiny files over one long one though *shrug*.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D26667

To: sitter
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26667: refactor about-distro to more generically support textual dumps

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this previously relied on manually replicating strings and whatnot, it was
  very awkward to read and the load functions were also getting a bit long.
  
  introducing the new entry system:
  generic table entries are now represented by a more generic Entry object
  comprised of the entry label (e.g. 'Plasma Version:') and its value
  (e.g. '5.17.0'). from those entries the UI is then constructed (i.e.
  large parts of the UI are now no longer in the designer file but rather
  constructed manually).
  all visible entries are further more collected in a global list of entries
  from which we'll generate the clipboard dump.
  localization switching is now carried out through KLocalized String instead
  of having string copies floating about. depending on context we'll either
  resolve the localized or original string.
  
  this should also make it easier to change the data set in the future, be
  it adding or removing new data
  
  RTL languages have a broken clipboard but it looks that was the case before
  as well and I utterly failed to bend it into shape with bidirectional
  control characters :(

TEST PLAN
  1. LANGUAGE=en
  2. all entires shown
  3. copy to clipboard dumps all entries as before
  
  1. LANGUAGE=de
  2. as above
  3. copy to as english dumps in english rather than german
  
  1. LANGUAGE=he
  2. as above
  3. copy in hebrew seems incorrectly order (probably because bidi algorithm 
falls over from both the RTL label being in the same line as the LTR numbers)

REPOSITORY
  R102 KInfoCenter

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26667

AFFECTED FILES
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/Module.h
  Modules/about-distro/src/Module.ui

To: sitter
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D26544#594194 , @ngraham wrote:
  
  > Thanks for the explanation!
  
  
  Not a problem, it's not necessarily easy to spot at a glance - and thanks! :D

REPOSITORY
  R119 Plasma Desktop

BRANCH
  switch-kcms-to-knsquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart, ngraham
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks for the explanation!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  switch-kcms-to-knsquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart, ngraham
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26627: Mark applications that play audio for small panels.

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6e130a23f2e1: Mark applications that play audio for small 
panels. (authored by gvgeo, committed by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26627?vs=73413=73540

REVISION DETAIL
  https://phabricator.kde.org/D26627

AFFECTED FILES
  applets/taskmanager/package/contents/ui/AudioStream.qml

To: gvgeo, #vdg, #plasma, hein, ngraham, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D26655#594173 , @ahiemstra 
wrote:
  
  > > In QQC there is an issue of overlap between item selection (and header 
titles) and scrollbar. Isn't that made even worth with the addition of the thin 
separator ?
  >
  > That problem is caused by overlapping scrollbars, D26530 
 makes them no longer overlapping thus 
fixing that problem.
  
  
  Clear enough yes. Thanks !

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26583: [Application Style] Add GTK Application Style Page

[Mikhail Zolotukhin]

gikari updated this revision to Diff 73536.
gikari added a comment.


  Return accidentally removed empty lines in `kcmstyle.h`

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26583?vs=73534=73536

BRANCH
  gtk-style-page

REVISION DETAIL
  https://phabricator.kde.org/D26583

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/cgcgtk3.knsrc
  kcms/style/cgctheme.knsrc
  kcms/style/gtkpage.cpp
  kcms/style/gtkpage.h
  kcms/style/gtkthemesmodel.cpp
  kcms/style/gtkthemesmodel.h
  kcms/style/kcmstyle.cpp
  kcms/style/kcmstyle.h
  kcms/style/package/contents/ui/GtkStylePage.qml
  kcms/style/package/contents/ui/main.qml

To: gikari, #vdg, broulik, #plasma, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26552: [KCMs/Feedback] Adjust UI to be more user-friendly

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:61a89ec98af5: [KCMs/Feedback] Adjust UI to be more 
user-friendly (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26552?vs=73167=73537

REVISION DETAIL
  https://phabricator.kde.org/D26552

AFFECTED FILES
  kcms/feedback/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Arjen Hiemstra]

ahiemstra added a comment.


  > In QQC there is an issue of overlap between item selection (and header 
titles) and scrollbar. Isn't that made even worth with the addition of the thin 
separator ?
  
  That problem is caused by overlapping scrollbars, D26530 
 makes them no longer overlapping thus 
fixing that problem.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D26583: [Application Style] Add GTK Application Style Page

[Mikhail Zolotukhin]

gikari updated this revision to Diff 73534.
gikari marked 3 inline comments as done.
gikari added a comment.


  Remove `columnCount` method and fix `rowCount` method

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26583?vs=73519=73534

BRANCH
  gtk-style-page

REVISION DETAIL
  https://phabricator.kde.org/D26583

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/cgcgtk3.knsrc
  kcms/style/cgctheme.knsrc
  kcms/style/gtkpage.cpp
  kcms/style/gtkpage.h
  kcms/style/gtkthemesmodel.cpp
  kcms/style/gtkthemesmodel.h
  kcms/style/kcmstyle.cpp
  kcms/style/kcmstyle.h
  kcms/style/package/contents/ui/GtkStylePage.qml
  kcms/style/package/contents/ui/main.qml

To: gikari, #vdg, broulik, #plasma, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26583: [Application Style] Add GTK Application Style Page

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> davidedmundson wrote in gtkthemesmodel.cpp:107
> this needs to be
> 
> if (parent.isValid()) {
> return m_themesList.count();
> }
> return 0;
> 
> Otherwise your're saying every item has children with N rows, which have 
> children with N rows forever.

Did you mean

  if (parent.isValid()) {
  return 0;
  }
  return m_themesList.count();

?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  gtk-style-page

REVISION DETAIL
  https://phabricator.kde.org/D26583

To: gikari, #vdg, broulik, #plasma, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24070: [WIP] Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw added a comment.


  @ngraham How does it look with this patch? Will it make it in?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: ngraham, #vdg, #plasma, ndavis, mthw
Cc: GB_2, ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26583: [Application Style] Add GTK Application Style Page

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> gikari wrote in gtkthemesmodel.cpp:107
> Did you mean
> 
>   if (parent.isValid()) {
>   return 0;
>   }
>   return m_themesList.count();
> 
> ?

I think so :D

REPOSITORY
  R119 Plasma Desktop

BRANCH
  gtk-style-page

REVISION DETAIL
  https://phabricator.kde.org/D26583

To: gikari, #vdg, broulik, #plasma, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Matej Mrenica]

mthw added a comment.


  In D26655#594149 , @mart wrote:
  
  > In D26655#594135 , @mthw wrote:
  >
  > > It does look better but looking at this 
  (image) it looks like a step backwards. 
Wouldn't it be better to have the scrollbar floating above the content?
  >
  >
  > in general i would agree, but in the (very long) discussion of D26530 
 it was decided for this look
  
  
  In that case, this patch does look better. The current state looks like 
neiher here, neither there. (If that is the correct way to say it).

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: hpereiradacosta, mthw, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Marco Martin]

mart added a comment.


  In D26655#594135 , @mthw wrote:
  
  > It does look better but looking at this 
  (image) it looks like a step backwards. 
Wouldn't it be better to have the scrollbar floating above the content?
  
  
  in general i would agree, but in the (very long) discussion of D26530 
 it was decided for this look

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: hpereiradacosta, mthw, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26665: Switch to KNSQuick for getting new wallpapers

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:47a1091be9f5: Switch to KNSQuick for getting new 
wallpapers (authored by leinir).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26665?vs=73526=73531

REVISION DETAIL
  https://phabricator.kde.org/D26665

AFFECTED FILES
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/config.qml

To: leinir, mart, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Hi Notmart,
  you need to rebase (you have some unrelated changes in the diff, which revert 
latest change from Noah)
  
  - Concerning the separator, it looks great.
  - Concerning reverting the thin bar, I think this is really unfortunate. I 
expect you will have as many complaints after the revert for people to have it 
back, as now of people who want the thick one. I would be among the former. 
Going back and forth in these design issues really gives wrong impression IMHO 
on our design capabilities, and I think this would be one of VDG's task to 
avoid this at all cost.
  
  Now, the thin bar might not work very well with the new separator (and both 
pursue opposite goals: one to make the scrollbar more visible and the other 
less visible). 
  But then again, it just means that we, (including our designers and 
usuability experts), keep going back and forth on which direction to follow 
(here regarding whether we should make the scrollbars more prominent or less 
prominent). This does not give a good impressing to the outside world IMHO.
  
  - In QQC there is an issue of overlap between item selection (and header 
titles) and scrollbar. Isn't that made even worth with the addition of the thin 
separator ?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: hpereiradacosta, mthw, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Matej Mrenica]

mthw added a comment.


  It does look better but looking at this  
 (image) it looks like a step backwards. Wouldn't it be better to have the 
scrollbar floating above the content?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham
Cc: mthw, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26665: Switch to KNSQuick for getting new wallpapers

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This switches the image plugin to using KNewStuffQuick instead of
  launching the widget dialog through that ol' widget dialog hack.
  It further uses the big preview mode by default, which just seems
  to make a lot of sense for wallpapers.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  use-knsquick-for-wallpapers (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26665

AFFECTED FILES
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/config.qml

To: leinir
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26583: [Application Style] Add GTK Application Style Page

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> gtkthemesmodel.cpp:107
> +int GtkThemesModel::rowCount(const QModelIndex& parent) const
> +{
> +Q_UNUSED(parent)

this needs to be

if (parent.isValid()) {
return m_themesList.count();
}
return 0;

Otherwise your're saying every item has children with N rows, which have 
children with N rows forever.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  gtk-style-page

REVISION DETAIL
  https://phabricator.kde.org/D26583

To: gikari, #vdg, broulik, #plasma, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26583: [Application Style] Add GTK Application Style Page

[Mikhail Zolotukhin]

gikari updated this revision to Diff 73519.
gikari added a comment.


  Remove Q_SLOT keyword from `load` and add override to destructor

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26583?vs=73429=73519

BRANCH
  gtk-style-page

REVISION DETAIL
  https://phabricator.kde.org/D26583

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/cgcgtk3.knsrc
  kcms/style/cgctheme.knsrc
  kcms/style/gtkpage.cpp
  kcms/style/gtkpage.h
  kcms/style/gtkthemesmodel.cpp
  kcms/style/gtkthemesmodel.h
  kcms/style/kcmstyle.cpp
  kcms/style/kcmstyle.h
  kcms/style/package/contents/ui/GtkStylePage.qml
  kcms/style/package/contents/ui/main.qml

To: gikari, #vdg, broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26660: [Task Manager]Fix and improve configuration behavior

[George Vogiatzis]

gvgeo added a comment.


  From https://bugs.kde.org/show_bug.cgi?id=415649
  Option 3 affects option 1 instead of 2.
  F7882757: Screenshot_20191229_170949.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26660

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26660: [Task Manager]Fix and improve configuration behavior

[George Vogiatzis]

gvgeo created this revision.
gvgeo added reviewers: VDG, Plasma, hein, ngraham.
gvgeo added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Fix the group conditions.
  Change layout.
  Rename various labels and texts.

TEST PLAN
  Before:
  The default settings, disable grouping until taskbar is full.
  The option "Group only when the Task Manager is full" is true,
  and affects grouping By program name. At the same time is disabled
  from editing, till enable "Open groups in popups".

REPOSITORY
  R119 Plasma Desktop

BRANCH
  config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26660

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26658: WIP: fix(kwayland): stall tablet config change

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  It seems only checking on no outputs initializing and signals being unblocked
  is not enough when cancelling a config change on tablet mode information
  change.
  
  There can be a race between the interface being announced and tablet mode
  information being changed before any output device received. In this case a
  config change is applied with no output management yet being available.
  
  Looking at the code though this seems to only be possible if the interfaces
  announced event is received before the output maangement interface announced
  event. This is not what should happen.

TEST PLAN
  Starts without seg fault on output management object in applyConfig.

REPOSITORY
  R110 KScreen Library

BRANCH
  tablet-fix

REVISION DETAIL
  https://phabricator.kde.org/D26658

AFFECTED FILES
  backends/kwayland/waylandconfig.cpp
  backends/kwayland/waylandconfig.h

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26586: [SystemTray] Rework system tray settings

[Konrad Materka]

kmaterka marked an inline comment as done.
kmaterka added a comment.


  In D26586#593966 , @ahiemstra 
wrote:
  
  > There should be no need to explicitly specify paddings now that D26530 
 has landed. But there's a bunch of 
workarounds that we still need to remove, so you may have some intermittent 
weird results.
  
  
  I saw that and hoped that it will apply automatically. I recompiled KDE (with 
qqc2-desktop-style), restarted but it is not working for me. Is there anything 
needed on my side to enable D26530 ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: ahiemstra, mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D25943: Expose ActionToolBar's overflow button icon name

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:d4bf3ed38a9f: Expose ActionToolBars overflow button 
icon name (authored by ahiemstra).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25943?vs=71420=73512#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25943?vs=71420=73512

REVISION DETAIL
  https://phabricator.kde.org/D25943

AFFECTED FILES
  src/controls/ActionToolBar.qml

To: ahiemstra, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26656: Use QQC2 Page as base for Kirigami Page

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:2829d2be5584: Use QQC2 Page as base for Kirigami Page 
(authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26656?vs=73505=73511

REVISION DETAIL
  https://phabricator.kde.org/D26656

AFFECTED FILES
  src/controls/Page.qml

To: ahiemstra, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26586: [SystemTray] Rework system tray settings

[Arjen Hiemstra]

ahiemstra added a comment.


  There should be no need to explicitly specify paddings now that D26530 
 has landed. But there's a bunch of 
workarounds that we still need to remove, so you may have some intermittent 
weird results.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: ahiemstra, mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D26423: [Notifications KCM] Move Plasma Workspace "service" to the top of its category

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a0f16565015e: [Notifications] Move Plasma Workspace 
service to the top of its category (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26423?vs=73419=73508#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26423?vs=73419=73508

REVISION DETAIL
  https://phabricator.kde.org/D26423

AFFECTED FILES
  kcms/notifications/sourcesmodel.cpp

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26654: support mobile mode scrollbar

[Marco Martin]

mart updated this revision to Diff 73507.
mart added a comment.


  - support also horizontal scrollbars

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26654?vs=73502=73507

BRANCH
  phab/mobilescrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26654

AFFECTED FILES
  org.kde.desktop/ScrollBar.qml

To: mart, #plasma, #vdg, #kirigami
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26654: support mobile mode scrollbar

[Marco Martin]

mart marked an inline comment as done.
mart added a comment.


  screenshots done with also D26655  in

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D26654

To: mart, #plasma, #vdg, #kirigami
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26656: Use QQC2 Page as base for Kirigami Page

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Instead of using Templates directly, use QQC2 page as base class for
  Kirigami's Page. With Qt 5.14 something in the typing has become more
  strict, so assigning Kirigami's Page to a property using QQC2 Page as
  type fails.
  
  This fixes Kirigami Gallery for me.

TEST PLAN
  Kirigami Gallery works again.

REPOSITORY
  R169 Kirigami

BRANCH
  page-is-not-page

REVISION DETAIL
  https://phabricator.kde.org/D26656

AFFECTED FILES
  src/controls/Page.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26586: [SystemTray] Rework system tray settings

[Konrad Materka]

kmaterka marked 2 inline comments as done.
kmaterka added a comment.


  Anything else to change/fix? When is the code freeze, this Friday?

INLINE COMMENTS

> kmaterka wrote in ConfigEntries.qml:114
> Yes, I don't like this neither. It is a workaround for a problem in 
> Kirigami.AbstractListItem. It automatically calculates paddings when 
> scrollbars are detected:
> kirigami/src/controls/templates/AbstractListItem.qml$144-165 
> 
> It checks if view has scrollbars attached: 
> `internal.view.T2.ScrollBar.vertical`.
> I checked other projects (Discover), Kirigami.AbstractListItem is used inside 
> ScrollablePage, which add scrollbars directly to the ListView (defined in 
> custom templates/private/ScrollView.qml 
> .
> 
> I use plain QQC2.ScrollView, which attaches scrollbars to itself, not 
> ListView. As a result scrollbars are not detected and padding is not added.
> 
> I don't know how to fix that correctly without duplicating a code in 
> ConfigEntries.qml. I can override leftPadding and rightPadding, but I prefer 
> to use original logic (in case it changes in the future). Can you advice?

I replaced this hack with explicit paddings settings

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D26586: [SystemTray] Rework system tray settings

[Konrad Materka]

kmaterka updated this revision to Diff 73504.
kmaterka added a comment.


  Replaced hack with explicit padding settings

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26586?vs=73470=73504

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26586

AFFECTED FILES
  applets/systemtray/package/contents/config/config.qml
  applets/systemtray/package/contents/config/main.xml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/ConfigGeneral.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D26654: support mobile mode scrollbar

[Kai Uwe Broulik]

broulik added a comment.


  Cool! The width change during the slide animation looks a bit odd, though

INLINE COMMENTS

> ScrollBar.qml:50
> +id: handleGraphics
> +x: scrolling ? parent.width/2 - width/2 : parent.width - width
> +

`Math.round`

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D26654

To: mart, #plasma, #vdg, #kirigami
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26655: show a thin separator between view and scrollbar

[Marco Martin]

mart created this revision.
mart added reviewers: Plasma, Breeze, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  This look makes listviews look way better, not having the selected
  items look truncated into nothingness.

REPOSITORY
  R31 Breeze

BRANCH
  phab/scrollbarseparator

REVISION DETAIL
  https://phabricator.kde.org/D26655

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: mart, #plasma, #breeze, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26654: support mobile mode scrollbar

[Marco Martin]

mart created this revision.
mart added reviewers: Plasma, VDG, Kirigami.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  when on mobile (or just "tabletmode" the scrollbar goes to "not interactive"
  in that case it draws like a typical mobile scroll indicator, overlayed to 
the 
  view and disappearing
  
  tough, it still shows a couple of pixels line when not in use so the users 
always 
  knows where in the view they are

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  phab/mobilescrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26654

AFFECTED FILES
  org.kde.desktop/ScrollBar.qml

To: mart, #plasma, #vdg, #kirigami
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26653: KCM Joystick : restore Default button to allow reset calibration.

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, ervin, bport, meven, mart, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Since there is no configuration saved, all button are hidden thanks to D26519 
, restore Default button which was used to 
reset calibration.
  Remove emit changed(true) as there is nothing to save.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26653

AFFECTED FILES
  kcms/hardware/joystick/joystick.cpp

To: crossi, #plasma, ervin, bport, meven, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26622: RFC: [Notifications] Raise application window if no default action is provided

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:48d3613aa843: [Notifications] Raise application window if 
no default action is provided (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26622?vs=73403=73497#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26622?vs=73403=73497

REVISION DETAIL
  https://phabricator.kde.org/D26622

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma, #vdg, hein, mart
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26530: ScrollView: Do not overlay scrollbars over contents

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:06d4bb0e6b86: ScrollView: Do not overlay scrollbars over 
contents (authored by ahiemstra).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26530?vs=73495=73496

REVISION DETAIL
  https://phabricator.kde.org/D26530

AFFECTED FILES
  org.kde.desktop/ScrollView.qml

To: ahiemstra, #plasma, #goal_consistency, mart
Cc: kmaterka, mart, ndavis, IlyaBizyaev, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra

D26530: ScrollView: Do not overlay scrollbars over contents

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 73495.
ahiemstra added a comment.


  - Review comments

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26530?vs=73093=73495

BRANCH
  scrollview_scrollbar_spacing

REVISION DETAIL
  https://phabricator.kde.org/D26530

AFFECTED FILES
  org.kde.desktop/ScrollView.qml

To: ahiemstra, #plasma, #goal_consistency, mart
Cc: kmaterka, mart, ndavis, IlyaBizyaev, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> ngraham wrote in colors.cpp:128
> This wraps a lot of existing functionality into that conditional as well. Was 
> all of that stuff broken and useless without D26543 
> ?
> 
> Everything seems to work anyway, but I'm curious to know if everything here 
> needs to be wrapped up in this.

All the code inside this conditional is for setting the most recent newly 
installed theme as the currently selected - perhaps a slightly long winded way 
of doing so, but yup, that's really all it does :) (and if it can't use the 
data being pulled out of the changedEntries, there doesn't seem any good reason 
to run the rest of the code which arguably would build and run, as it just 
wouldn't do anything)

> ngraham wrote in kcmcursortheme.cpp:433
> ditto

Also ditto - all the code here depends on having an entry to work with, and if 
that can't be pulled out of changedEntries (which doesn't work until 5.67) then 
there's no particularly good reason to run the other bits of the code :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart