D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

[Douglas Kosovic]

dkosovic added a comment.


  I'm of mixed minds on the group boxes.
  
  With L2TP/IPsec connection setup instructions for macOS and iOS, they 
typically have screenshots of the "User Authentication" and "Machine 
Authentication" settings. Many Linux users try to match what they see for other 
platforms to what they need to enter. A typical user probably wouldn't know 
that machine authentication is IPsec authentication, although if it is a 
pre-shared key it doesn't need to be spelt out, for certificates it can get a 
bit more confusing between user and machine certificates. But having said that, 
I did explicitly use "User Certificate" and "Machine Certificate" labels, 
perhaps most users would realize "Machine Certificate" corresponds to "Machine 
Authentication"?
  
  I got the idea of using a checkable group box as the existing PPP settings 
dialog used one, but granted it didn't have nested group boxes. I was trying to 
imply with the Advanced group box that it is optional and should only be 
touched if you know what you are doing.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27764

To: dkosovic, jgrulich
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27792: [Applet]Fix traffic monitor labels width

[George Vogiatzis]

gvgeo added a comment.


  #VDG  Does a better way exist, to 
measure the width of transfer speed text?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27792

To: gvgeo, #vdg, #plasma, jgrulich, ngraham
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26946: Changed leftMargins to smallSpacing to be consistent

[George Vogiatzis]

gvgeo added inline comments.

INLINE COMMENTS

> PopupDialog.qml:120
>  boundsBehavior: Flickable.StopAtBounds
> -spacing: Math.round(units.gridUnit / 2)
> +spacing: Math.round(units.smallSpacing / 2)
>  

I don't see why decrease  this spacing.
Were you able to verify this? I don't have access to two batteries, but I 
expect this to look bad.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  smallspacingmargin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26946

To: niccolove, #vdg, #plasma, ngraham
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

[Nathaniel Graham]

ngraham added a comment.


  -1 for using group boxes. :) I don't think they're needed at all. Just change 
the "Type:" label to "Authentication:" and that section is clear enough, then 
just separate the logical sections with whitespace

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27764

To: dkosovic, jgrulich
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27595: Watch for language change events, and forward those to the QML engine

[Nathaniel Graham]

ngraham added a comment.


  `git bisect` says this caused https://bugs.kde.org/show_bug.cgi?id=418447.
  
  F8148416: Spacing sometimes too high.mp4 

  
  Would be nice to fix that regression before it gets shipped with Frameworks 
5.68.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27595

To: vkrause, mart
Cc: ngraham, apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart

D24706: [RFC] Change button style

[Nathaniel Graham]

ngraham added a comment.


  In D24706#595764 , @ngraham wrote:
  
  > Thanks Noah.
  >
  > So you're the boss after all (as the de- facto Breeze maintainer now), and 
I think we should follow your lead design-wise. But it might also be 
interesting to have a discussion about what we want this to accomplish.
  >
  > Personally here's my wishlist:
  >
  > 1. Make it much more visually obvious which button is the default button
  > 2. Make the focused state look less like what most people would assume is 
the appearance for the default button
  > 3. Avoid making the focused state look too subtle
  > 4. Make the pressed state look more "pressed"
  >
  >   I think this patch does #3 and #4, but not #1 or #2. However it's 
possible that the focus style you've chosen will be just fine once the 
selection effects look like this everywhere for consistency, and if the default 
button gets a stronger look.
  
  
  With the current state of the patch, IMO nothing has changed. The focused 
state still has more visual weighting than the "I'm a Default Button" state and 
still makes the background blue (with the default color scheme), so #1 and #2 
are not achieved. #3 is still achieved, and #4 is improved by darkening the 
background for the pressed state, but IMO impaired by removing the gradient and 
the diagonal movement.
  
  I don't dislike the new focus appearance, but I think if we keep it like 
that, then the default button appearance needs to be made much stronger.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: mart, ahiemstra, cfeck, The-Feren-OS-Dev, cblack, bodoeggert, ngraham, 
plasma-devel, manueljlin, Orage, LeGast00n, konkinartem, ian, jguidon, Ghost6, 
jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender

D27645: [KCM]Align volume controls row

[George Vogiatzis]

gvgeo updated this revision to Diff 76884.
gvgeo added a comment.


  Fix rebase.

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27645?vs=76874&id=76884

BRANCH
  mute (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27645

AFFECTED FILES
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/StreamListItem.qml

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27421: [Cuttleffish] Use proper QSortFilterProxyModel

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> iconmodel.h:100
>  QStringList m_icons;
>  QString m_category;
>  QStringList m_categories;

m_category can be removed?

> iconmodel.h:102
>  QStringList m_categories;
>  QString m_filter;
>  QHash m_data;

m_filter can be removed now, right?

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D27421

To: davidre, #plasma
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27608: Fixes for applet configuration layout.

[Filip Fila]

filipf added a comment.


  Seems to run pretty well, but there is a tiny padding regression introduced.
  
  Using `plasmashell --reverse --replace` to test a right to left layout we see 
that there is excessive padding between the content and the sidebar.
  
  F8148094: image.png 
  
  I.e. there is more padding than when using a left to right layout, and when 
resizing the window the padding actually increases some more (to level that's 
shown in the screenshot)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  configscollcat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27608

To: gvgeo, #plasma, #vdg, filipf, ngraham
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27421: [Cuttleffish] Use proper QSortFilterProxyModel

[David Redondo]

davidre added a comment.


  Ping

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D27421

To: davidre, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27645: [KCM]Align volume controls row

[George Vogiatzis]

gvgeo updated this revision to Diff 76874.
gvgeo added a comment.


  Math round.

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27645?vs=76873&id=76874

BRANCH
  mute (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27645

AFFECTED FILES
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/StreamListItem.qml

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27645: [KCM]Align volume controls row

[George Vogiatzis]

gvgeo updated this revision to Diff 76873.
gvgeo added a comment.


  rebase

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27645?vs=76519&id=76873

BRANCH
  mute (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27645

AFFECTED FILES
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/StreamListItem.qml

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27608: Fixes for applet configuration layout.

[George Vogiatzis]

gvgeo marked an inline comment as done.
gvgeo added a comment.


  I'll give a bit more time, so @filipf gets a chance to check again and accept 
if possible.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  configscollcat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27608

To: gvgeo, #plasma, #vdg, filipf, ngraham
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27608: Fixes for applet configuration layout.

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yep! Everything else looks good to me.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  configscollcat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27608

To: gvgeo, #plasma, #vdg, filipf, ngraham
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27645: [KCM]Align volume controls row

[Nathaniel Graham]

ngraham added a comment.


  Needs a rebase

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27645

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27422: [KCM]Update Device item layout based on applet

[George Vogiatzis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:606c6499750a: [KCM]Update Device item layout based on 
applet (authored by gvgeo).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27422?vs=76840&id=76870

REVISION DETAIL
  https://phabricator.kde.org/D27422

AFFECTED FILES
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/MuteButton.qml
  src/kcm/package/contents/ui/StreamListItem.qml

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27608: Fixes for applet configuration layout.

[George Vogiatzis]

gvgeo updated this revision to Diff 76869.
gvgeo edited the test plan for this revision.
gvgeo added a comment.


  Restore code for vertical line.
  Cannot find a reason this happens or replicate. But realized that the change 
was unnecessary.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27608?vs=76356&id=76869

BRANCH
  configscollcat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27608

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: gvgeo, #plasma, #vdg, filipf, ngraham
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27422: [KCM]Update Device item layout based on applet

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Ship it, the jagginess is clearly caused by something lower in the stack.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  kcmports3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27422

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27675: feat: avoid duplicated text when assembling user-facing output names

[Roman Gilg]

romangg added a reviewer: romangg.
romangg added a comment.


  I am currently working on some projects. But if you don't hear till Sunday 
from me about this, ping me.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D27675

To: dvratil, #plasma, romangg
Cc: romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27697: WIP: Added top area to notification header

[Nathaniel Graham]

ngraham added a comment.


  Man this looks nice.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27697

To: niccolove, broulik
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

[Ahmad Samir]

ahmadsamir updated this revision to Diff 76868.
ahmadsamir added reviewers: broulik, ervin, meven.
ahmadsamir added a comment.


  Tweak

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27785?vs=76779&id=76868

BRANCH
  l-fonts-kcm-nearest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27785

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, davidedmundson, broulik, ervin, meven.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  When using ajustAllFonts(), try to set the fixed width/Monospace font
  from the font family the user has selected, otherwise fallback to whatever
  QFontDatabase::systemFont(QFontDatabase::FixedFont) gets.
  
  Depends on D27785 

TEST PLAN
  Changing a font still works.
  Due to the change to clear font styleName property when saving via
  KConfig (D27735 ), if in kdegloblas you 
removed the ",Regular|Normal|Book|Roman"
  from the end of the *font*=  entries, openin the font selection dialog
  in the KCM, the very first style is selected, not "Regular" and co. as
  it should be. This will be addressed in an upcoming diff.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  l-qfontdlg-track-nearest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27808

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27807: Changed style of pressed list item to be consistent

[Nathaniel Graham]

ngraham added a comment.


  In D27807#621347 , @ndavis wrote:
  
  > It's strange that the plasma-devel mailing list isn't automatically added, 
even when it's a reviewer group.
  
  
  Because then people who are both subscribed to the mailing list and also 
members/watchers of the #plasma  group 
get two emails for every comment/change/update/etc.
  
  Anyway, it seems like we generally need to rethink these states. I think 
KRunner should be used as the model for how to have both visually distinct and 
visually pleasing hovered and pressed states.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove, #vdg, #plasma
Cc: ngraham, plasma-devel, ndavis, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns

D27608: Fixes for applet configuration layout.

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  So with this patch, I see a new visual issue: the first time I open an applet 
config window, the vertical separator is not visible: F8147412: 
Screenshot_20200303_093031.png 
  
  It becomes it becomes visible (and thereafter stays visible) if I resize the 
window or switch categories. I don't see this issue with the current state of 
git master, so it seems to be a regression.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27608

To: gvgeo, #plasma, #vdg, filipf, ngraham
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27807: Changed style of pressed list item to be consistent

[Noah Davis]

ndavis added a subscriber: plasma-devel.
ndavis added a comment.


  It's strange that the plasma-devel mailing list isn't automatically added, 
even when it's a reviewer group.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove, #vdg, #plasma
Cc: plasma-devel, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D26946: Changed leftMargins to smallSpacing to be consistent

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Right, this is good to go now. We should remove the margin in the checkbox 
too.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  smallspacingmargin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26946

To: niccolove, #vdg, #plasma, ngraham
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27806: fix: consider DSI display to be embedded panel

[Bhushan Shah]

This revision was automatically updated to reflect the committed changes.
Closed by commit R110:624ff86e4766: fix: consider DSI display to be embedded 
panel (authored by bshah).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27806?vs=76857&id=76859

REVISION DETAIL
  https://phabricator.kde.org/D27806

AFFECTED FILES
  backends/utils.cpp

To: bshah, romangg, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27806: fix: consider DSI display to be embedded panel

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Seems that way: 
https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_modeset_helper.c#L61

REPOSITORY
  R110 KScreen Library

BRANCH
  bshah/dsi-embedded

REVISION DETAIL
  https://phabricator.kde.org/D27806

To: bshah, romangg, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27806: fix: consider DSI display to be embedded panel

[Bhushan Shah]

bshah created this revision.
bshah added a reviewer: romangg.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.

REVISION SUMMARY
  DSI connector type is widely used in mobile and tablet devices. Consider
  them embedded so auto-rotation feature is available.

TEST PLAN
  tested on pinephone and pinetab which have a DSI displays

REPOSITORY
  R110 KScreen Library

BRANCH
  bshah/dsi-embedded

REVISION DETAIL
  https://phabricator.kde.org/D27806

AFFECTED FILES
  backends/utils.cpp

To: bshah, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

[Jan Grulich]

jgrulich added a comment.


  In D27764#621204 , @dkosovic wrote:
  
  > In D27764#621173 , @jgrulich 
wrote:
  >
  > > @dkosovic will you update the review to address my comments?
  >
  >
  > I agree with all your comments and they are great nitpicks and suggestions.
  >
  > Sorry I didn't have time tonight to work on testing everything and 
submitting an updated patch. I'm guessing submitting an updated patch is what I 
need to do for the review?
  
  
  No problem, take your time. I don't know the way you submitted this change, 
whether you used **arc** to do so or you just uploaded a patch. With **arc** 
you just create another commit and run again:
  
arc diff
  
  If you uploaded just a patch, then I guess you will need to update it the 
same way.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27764

To: dkosovic, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

[Douglas Kosovic]

dkosovic added a comment.


  In D27764#621173 , @jgrulich wrote:
  
  > @dkosovic will you update the review to address my comments?
  
  
  I agree with all your comments and they are great nitpicks and suggestions.
  
  Sorry I didn't have time tonight to work on testing everything and submitting 
an updated patch. I'm guessing submitting an updated patch is what I need to do 
for the review?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27764

To: dkosovic, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 7 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/7/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 03 Mar 2020 12:36:29 +
 Build duration:
3 min 35 sec and counting
   CONSOLE OUTPUT
  [...truncated 502 lines...][2020-03-03T12:39:55.985Z] [118/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportassistantdialog.cpp.obj[2020-03-03T12:39:55.985Z] [119/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\productmapping.cpp.obj[2020-03-03T12:39:56.259Z] [120/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\bugtest.dir\bugtest_autogen\mocs_compilation.cpp.obj[2020-03-03T12:39:56.548Z] [121/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\parsebugbacktraces.cpp.obj[2020-03-03T12:39:56.548Z] [122/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportassistantpages_base.cpp.obj[2020-03-03T12:39:56.548Z] [123/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\duplicatefinderjob.cpp.obj[2020-03-03T12:39:56.548Z] [124/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportinterface.cpp.obj[2020-03-03T12:39:56.819Z] [125/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportassistantpages_bugzilla_duplicates.cpp.obj[2020-03-03T12:39:56.819Z] [126/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\drkonqi_debug.cpp.obj[2020-03-03T12:39:56.819Z] [127/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\attachmenttest.dir\attachmenttest_autogen\mocs_compilation.cpp.obj[2020-03-03T12:39:57.096Z] [128/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\bugzillatest.dir\bugzillatest_autogen\mocs_compilation.cpp.obj[2020-03-03T12:39:57.096Z] [129/149] Linking CXX executable bin\bugzillalibtest.exe[2020-03-03T12:39:57.378Z] [130/149] Automatic MOC for target producttest[2020-03-03T12:39:57.657Z] [131/149] Linking CXX executable bin\backtraceparsertest.exe[2020-03-03T12:39:57.657Z] [132/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\producttest.dir\producttest_autogen\mocs_compilation.cpp.obj[2020-03-03T12:39:57.923Z] [133/149] Linking CXX executable bin\commenttest.exe[2020-03-03T12:39:58.189Z] [134/149] Linking CXX executable bin\bugtest.exe[2020-03-03T12:39:58.189Z] [135/149] Linking CXX executable bin\bugfieldtest.exe[2020-03-03T12:39:58.189Z] [136/149] Linking CXX executable bin\connectiontest.exe[2020-03-03T12:39:58.767Z] [137/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportassistantpages_bugzilla.cpp.obj[2020-03-03T12:39:58.767Z] [138/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\DrKonqiInternal_autogen\mocs_compilation.cpp.obj[2020-03-03T12:39:59.029Z] [139/149] Linking CXX static library lib\DrKonqiInternal.lib[2020-03-03T12:39:59.029Z] [140/149] Automatic MOC for target drkonqi[2020-03-03T12:39:59.029Z] [141/149] Building CXX object src\CMakeFiles\drkonqi.dir\drkonqi_autogen\mocs_compilation.cpp.obj[2020-03-03T12:39:59.029Z] [142/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\attachmenttest.dir\attachmenttest.cpp.obj[2020-03-03T12:39:59.304Z] [143/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\bugzillatest.dir\bugzillatest.cpp.obj[2020-03-03T12:39:59.304Z] [144/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\producttest.dir\producttest.cpp.obj[2020-03-03T12:39:59.881Z] [145/149] Linking CXX executable bin\attachmenttest.exe[2020-03-03T12:39:59.881Z] [146/149] Linking CXX executable bin\bugzillatest.exe[2020-03-03T12:40:00.141Z] [147/149] Linking CXX executable bin\producttest.exe[2020-03-03T12:40:00.711Z] [148/149] Building CXX object src\CMakeFiles\drkonqi.dir\main.cpp.obj[2020-03-03T12:40:01.309Z] [149/149] Linking CXX executable bin\drkonqi.exe[2020-03-03T12:40:01.309Z] FAILED: bin/drkonqi.exe [2020-03-03T12:40:01.309Z] cmd.exe /C "cd . && C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\cmake-base\bin\cmake.exe -E vs_link_exe --intdir=src\CMakeFiles\drkonqi.dir --manifests  -- C:\PROGRA~2\MICROS~1\2019\PROFES~1\VC\Tools\MSVC\1424~1.283\bin\Hostx64\x64\link.exe /nologo src\CMakeFiles\drkonqi.dir\main.cpp.obj src\CMakeFiles\drkonqi.dir\drkonqi_autogen\mocs_compilation.cpp.obj  /out:bin\drkonqi.exe /implib:lib\drkonqi.lib /pdb:bin\drkonqi.pdb /version:0.0  /machine:x64 /NODEFAULTLIB:libcmtd /DEFAULTLIB:msvcrtd /debug /INCREMENTAL  /subsystem:console  lib\DrKonqiInternal.lib "C:\CI\Software Installs\drkonqi\lib\KF5ConfigWidgets.lib" "C:\CI\Software Installs\drkonqi\lib\KF5Codecs.lib" "C:\CI\Software Installs\drkonqi\lib\KF5Auth.lib" "C:\CI\Software Installs\drkonqi\lib\KF5AuthCore.lib" "C:\CI\Software Insta

D27799: Use system color scheme from Kirigami instead of Plasma theme color

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:c9b2684a49d3: Use system color scheme from Kirigami 
instead of Plasma theme color (authored by jgrulich).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27799?vs=76830&id=76842

REVISION DETAIL
  https://phabricator.kde.org/D27799

AFFECTED FILES
  CMakeLists.txt
  kcm/qml/main.qml

To: jgrulich, ngraham, #plasma, davidedmundson
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

[Jan Grulich]

jgrulich added a comment.


  @dkosovic will you update the review to address my comments?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27764

To: dkosovic, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27422: [KCM]Update Device item layout based on applet

[George Vogiatzis]

gvgeo added a comment.


  In D27422#614236 , @ngraham wrote:
  
  > I'm seeing some weird jagginess on radio buttons, slider handles, and 
combobox shadows:
  >
  > F8112849: Screenshot_20200219_075319.png 

  >
  > This is just 1x scaling with no weird font DPI fiddling.
  
  
  Is it a problem with this patch or can this land?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  kcmports3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27422

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27422: [KCM]Update Device item layout based on applet

[George Vogiatzis]

gvgeo updated this revision to Diff 76840.
gvgeo added a comment.


  rebase

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27422?vs=76475&id=76840

BRANCH
  kcmports3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27422

AFFECTED FILES
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/MuteButton.qml
  src/kcm/package/contents/ui/StreamListItem.qml

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27577: [KCM]Fix content below scrollbars

[George Vogiatzis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:552b0384ffd2: [KCM]Fix content below scrollbars (authored 
by gvgeo).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27577?vs=76467&id=76836

REVISION DETAIL
  https://phabricator.kde.org/D27577

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/Header.qml
  src/kcm/package/contents/ui/main.qml

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27782: expose IncludeUsage to QML api

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0775faf25323: expose IncludeUsage to QML api (authored by 
mart).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27782?vs=76774&id=76835

REVISION DETAIL
  https://phabricator.kde.org/D27782

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/recentusagemodel.h

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27155: libnotificationmanager : add app-specific kconfig settings

[Cyril Rossi]

crossi updated this revision to Diff 76834.
crossi added a comment.


  use parentGroup attribute

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27155?vs=75090&id=76834

REVISION DETAIL
  https://phabricator.kde.org/D27155

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/behaviorsettings.kcfg
  libnotificationmanager/kcfg/behaviorsettings.kcfgc
  libnotificationmanager/plasmanotifyrc

To: crossi, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27734: [Applet/TaskManager]Don't create extra PulseAudio component

[George Vogiatzis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:bfcc6df32396: [Applet/TaskManager]Don't create extra 
PulseAudio component (authored by gvgeo).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27734?vs=76669&id=76831

REVISION DETAIL
  https://phabricator.kde.org/D27734

AFFECTED FILES
  applets/taskmanager/package/contents/ui/main.qml

To: gvgeo, #plasma, hein, ngraham
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27799: Use system color scheme from Kirigami instead of Plasma theme color

[Jan Grulich]

jgrulich updated this revision to Diff 76830.
jgrulich added a comment.


  Don't use deprecated color

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27799?vs=76824&id=76830

BRANCH
  bug-418416

REVISION DETAIL
  https://phabricator.kde.org/D27799

AFFECTED FILES
  CMakeLists.txt
  kcm/qml/main.qml

To: jgrulich, ngraham, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27799: Use system color scheme from Kirigami instead of Plasma theme color

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> main.qml:43
>  focus: true
> -color: theme.backgroundColor
> +color: Kirigami.Theme.viewBackgroundColor
>  }

viewBackgroundColor is deprecated
`WARNING: viewBackgroundColor is deprecated, use backgroundColor with colorSet: 
Theme.View instead`

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27799

To: jgrulich, ngraham, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 6 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/6/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 03 Mar 2020 09:38:49 +
 Build duration:
5 min 26 sec and counting
   CONSOLE OUTPUT
  [...truncated 504 lines...][2020-03-03T09:44:10.124Z] [118/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\bugzillalib.cpp.obj[2020-03-03T09:44:10.124Z] [119/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\gdbhighlighter.cpp.obj[2020-03-03T09:44:10.124Z] [120/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\assistantpage_bugzilla_version.cpp.obj[2020-03-03T09:44:10.124Z] [121/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\statusnotifier.cpp.obj[2020-03-03T09:44:10.386Z] [122/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportassistantpage.cpp.obj[2020-03-03T09:44:10.973Z] [123/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportassistantdialog.cpp.obj[2020-03-03T09:44:10.973Z] [124/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportassistantpages_base.cpp.obj[2020-03-03T09:44:11.240Z] [125/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\productmapping.cpp.obj[2020-03-03T09:44:11.502Z] [126/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\drkonqi_debug.cpp.obj[2020-03-03T09:44:11.776Z] [127/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\parsebugbacktraces.cpp.obj[2020-03-03T09:44:11.776Z] [128/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportinterface.cpp.obj[2020-03-03T09:44:12.038Z] [129/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\duplicatefinderjob.cpp.obj[2020-03-03T09:44:12.038Z] [130/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\producttest.dir\producttest_autogen\mocs_compilation.cpp.obj[2020-03-03T09:44:12.038Z] [131/149] Linking CXX executable bin\attachmenttest.exe[2020-03-03T09:44:12.038Z] [132/149] Linking CXX executable bin\bugzillalibtest.exe[2020-03-03T09:44:12.038Z] [133/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\commenttest.dir\commenttest_autogen\mocs_compilation.cpp.obj[2020-03-03T09:44:12.038Z] [134/149] Linking CXX executable bin\bugtest.exe[2020-03-03T09:44:12.299Z] [135/149] Linking CXX executable bin\bugzillatest.exe[2020-03-03T09:44:12.299Z] [136/149] Linking CXX executable bin\bugfieldtest.exe[2020-03-03T09:44:12.299Z] [137/149] Linking CXX executable bin\connectiontest.exe[2020-03-03T09:44:12.559Z] [138/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportassistantpages_bugzilla_duplicates.cpp.obj[2020-03-03T09:44:12.819Z] [139/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportassistantpages_bugzilla.cpp.obj[2020-03-03T09:44:12.819Z] [140/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\DrKonqiInternal_autogen\mocs_compilation.cpp.obj[2020-03-03T09:44:12.819Z] [141/149] Linking CXX static library lib\DrKonqiInternal.lib[2020-03-03T09:44:12.819Z] [142/149] Automatic MOC for target drkonqi[2020-03-03T09:44:13.080Z] [143/149] Building CXX object src\CMakeFiles\drkonqi.dir\drkonqi_autogen\mocs_compilation.cpp.obj[2020-03-03T09:44:13.343Z] [144/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\commenttest.dir\commenttest.cpp.obj[2020-03-03T09:44:13.343Z] [145/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\producttest.dir\producttest.cpp.obj[2020-03-03T09:44:13.921Z] [146/149] Linking CXX executable bin\commenttest.exe[2020-03-03T09:44:13.921Z] [147/149] Linking CXX executable bin\producttest.exe[2020-03-03T09:44:14.493Z] [148/149] Building CXX object src\CMakeFiles\drkonqi.dir\main.cpp.obj[2020-03-03T09:44:15.077Z] [149/149] Linking CXX executable bin\drkonqi.exe[2020-03-03T09:44:15.077Z] FAILED: bin/drkonqi.exe [2020-03-03T09:44:15.077Z] cmd.exe /C "cd . && C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\cmake-base\bin\cmake.exe -E vs_link_exe --intdir=src\CMakeFiles\drkonqi.dir --manifests  -- C:\PROGRA~2\MICROS~1\2019\PROFES~1\VC\Tools\MSVC\1424~1.283\bin\Hostx64\x64\link.exe /nologo src\CMakeFiles\drkonqi.dir\main.cpp.obj src\CMakeFiles\drkonqi.dir\drkonqi_autogen\mocs_compilation.cpp.obj  /out:bin\drkonqi.exe /implib:lib\drkonqi.lib /pdb:bin\drkonqi.pdb /version:0.0  /machine:x64 /NODEFAULTLIB:libcmtd /DEFAULTLIB:msvcrtd /debug /INCREMENTAL  /subsystem:console  lib\DrKonqiInternal.lib "C:\CI\Software Installs\drkonqi\lib\KF5ConfigWidgets.lib" "C:\CI\Software Installs\drkonqi\lib\KF5Codecs.lib" "C:\CI\Software Installs\drkonqi\lib\KF5Auth.lib" "C:\CI\Software Installs\drkonqi\lib\KF5AuthCore.lib" "C:\CI\Software Installs\drkonqi\lib\K

D27776: focus email input line by default

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:ed33c2803511: focus email input line by default (authored 
by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27776?vs=76753&id=76827

REVISION DETAIL
  https://phabricator.kde.org/D27776

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp

To: sitter, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 6 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.14/6/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 03 Mar 2020 09:38:49 +
 Build duration:
3 min 14 sec and counting
   CONSOLE OUTPUT
  [...truncated 398 lines...][2020-03-03T09:41:53.474Z] [13/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsergdb.cpp.obj[2020-03-03T09:41:53.474Z] [14/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparser.cpp.obj[2020-03-03T09:41:54.084Z] [15/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\bugzilla.cpp.obj[2020-03-03T09:41:54.349Z] [16/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\main.cpp.obj[2020-03-03T09:41:54.349Z] [17/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\callbacks.cpp.obj[2020-03-03T09:41:54.927Z] [18/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\bugupdate.cpp.obj[2020-03-03T09:41:54.927Z] [19/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\bugsearch.cpp.obj[2020-03-03T09:41:54.927Z] [20/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\newattachment.cpp.obj[2020-03-03T09:41:54.927Z] [21/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\apijob.cpp.obj[2020-03-03T09:41:54.927Z] [22/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\jsoncommand.cpp.obj[2020-03-03T09:41:55.190Z] [23/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\productclient.cpp.obj[2020-03-03T09:41:55.190Z] [24/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commentclient.cpp.obj[2020-03-03T09:41:55.190Z] [25/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\connection.cpp.obj[2020-03-03T09:41:55.190Z] [26/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\bugclient.cpp.obj[2020-03-03T09:41:55.190Z] [27/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\exceptions.cpp.obj[2020-03-03T09:41:55.452Z] [28/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\attachmentclient.cpp.obj[2020-03-03T09:41:55.452Z] [29/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\bugfieldclient.cpp.obj[2020-03-03T09:41:56.030Z] [30/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\clientbase.cpp.obj[2020-03-03T09:41:56.030Z] [31/149] Linking CXX static library lib\drkonqi_backtrace_parser.lib[2020-03-03T09:41:56.030Z] [32/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\bugfield.cpp.obj[2020-03-03T09:41:56.030Z] [33/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\logindetails.cpp.obj[2020-03-03T09:41:56.030Z] [34/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\querycommand.cpp.obj[2020-03-03T09:41:56.030Z] [35/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\comment.cpp.obj[2020-03-03T09:41:56.290Z] [36/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\newbug.cpp.obj[2020-03-03T09:41:56.290Z] [37/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\bug.cpp.obj[2020-03-03T09:41:56.290Z] [38/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\bugzilla_debug.cpp.obj[2020-03-03T09:41:56.290Z] [39/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\product.cpp.obj[2020-03-03T09:41:56.290Z] [40/149] Linking CXX executable bin\crashtest.exe[2020-03-03T09:41:56.550Z] [41/149] Automatic MOC for target gdbbacktracelinetest[2020-03-03T09:41:56.550Z] [42/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\qbugzilla_autogen\mocs_compilation.cpp.obj[2020-03-03T09:41:56.550Z] [43/149] Automatic MOC for target backtraceparsertest_manual[2020-03-03T09:41:56.550Z] [44/149] Building CXX object src\tests\CMakeFiles\gdbbacktracelinetest.dir\gdbbacktracelinetest_autogen\mocs_compilation.cpp.obj[2020-03-03T09:41:56.550Z] [45/149] Linking CXX static library lib\qbugzilla.lib[2020-03-03T09:41:56.815Z] [46/149] Automatic MOC for target backtraceparsertest[2020-03-03T09:41:58.221Z] [47/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\abstract_generator.cpp.obj[2020-03-03T09:41:58.221Z] [48/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\kdbgwin_process.

D26946: Changed leftMargins to smallSpacing to be consistent

[Niccolò Venerandi]

niccolove added a comment.


  F8146611: Screenshot_20200303_103831.png 

  Seems aligned to me, the problem is that the new small checkbox has a margin 
to the left by default.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26946

To: niccolove, #vdg, #plasma
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27799: Use system color scheme from Kirigami instead of Plasma theme color

[Jan Grulich]

jgrulich added a comment.


  One thing I'm not sure about whether to use **viewBackgroundColor** or just 
**backgroundColor**, because I want the buttons to look like they are part of 
the view.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27799

To: jgrulich, ngraham, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27697: WIP: Added top area to notification header

[Niccolò Venerandi]

niccolove updated this revision to Diff 76825.
niccolove added a comment.


  Components and rounding

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27697?vs=76674&id=76825

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27697

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: niccolove, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27799: Use system color scheme from Kirigami instead of Plasma theme color

[Jan Grulich]

jgrulich created this revision.
jgrulich added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jgrulich requested review of this revision.

REVISION SUMMARY
  BUG: 418416

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  bug-418416

REVISION DETAIL
  https://phabricator.kde.org/D27799

AFFECTED FILES
  CMakeLists.txt
  kcm/qml/main.qml

To: jgrulich, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 76823.
niccolove added a comment.


  Make anchors fill parent

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=76530&id=76823

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27698: Fix PrivateActionToolButton behaviour with showText vs IconOnly

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:6f27f90cfa1e: Fix PrivateActionToolButton behaviour with 
showText vs IconOnly (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27698?vs=76537&id=76821

REVISION DETAIL
  https://phabricator.kde.org/D27698

AFFECTED FILES
  src/controls/private/PrivateActionToolButton.qml

To: ahiemstra, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27700: Add an autotest for ActionToolBar

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:fd0f3ea202f3: Add an autotest for ActionToolBar (authored 
by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27700?vs=76556&id=76820

REVISION DETAIL
  https://phabricator.kde.org/D27700

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/tst_actiontoolbar.qml
  src/CMakeLists.txt

To: ahiemstra, #kirigami, mart
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein

D27608: Fixes for applet configuration layout.

[George Vogiatzis]

gvgeo added a comment.


  > I'm starting to agree that this is the wrong place to add the titlebar 
separator.
  
  Can this go as is, for now? I don't believe there is an alternative in the 
near future.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27608

To: gvgeo, #plasma, #vdg, filipf
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart