D18939: KMenuEdit: add search/filter bar

tuxxi marked 2 inline comments as done. tuxxi added a comment. Good point about CJK, I had not considered that. REPOSITORY R103 KMenu Editor BRANCH search-bar REVISION DETAIL https://phabricator.kde.org/D18939 To: tuxxi, ngraham, #plasma, cfeck Cc: ognarb, mlaurent, ngraham,

D18939: KMenuEdit: add search/filter bar

tuxxi updated this revision to Diff 52129. tuxxi added a comment. - Use logicalLength for non-latin characters - Fix ptr style REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18939?vs=51565=52129 BRANCH search-bar REVISION DETAIL

D18939: KMenuEdit: add search/filter bar

tuxxi added a comment. In D18939#411450 , @ngraham wrote: > If you use a blank QWidget, you won't have to do that `setContentsMargin()` workaround, right? I actually tried this first, I was surprised when the plain `QWidget` still had

D18939: KMenuEdit: add search/filter bar

tuxxi added a comment. Yes, that's exactly what I'm doing. QFrame works fine for doing the same thing with the added benefit of easier styling around the edges. But if you *really want* I can switch it to a blank QWidget... it makes absolutely no difference though. REPOSITORY R103 KMenu

D18939: KMenuEdit: add search/filter bar

tuxxi updated this revision to Diff 51565. tuxxi added a comment. - Fix padding issues REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18939?vs=51562=51565 BRANCH search-bar REVISION DETAIL https://phabricator.kde.org/D18939 AFFECTED FILES

D18939: KMenuEdit: add search/filter bar

tuxxi added inline comments. INLINE COMMENTS > ngraham wrote in kmenuedit.cpp:143 > If there's nothing specifically in the style guidelines about it, it's best > to follow the existing coding style. Nothing else here uses `auto` with `new` > constructors, so we should follow the same style for

D18939: KMenuEdit: add search/filter bar

tuxxi updated this revision to Diff 51562. tuxxi marked 8 inline comments as done. tuxxi added a comment. - resolve (hopefully) final nitpicks REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18939?vs=51561=51562 BRANCH search-bar REVISION DETAIL

D18939: KMenuEdit: add search/filter bar

tuxxi added inline comments. INLINE COMMENTS > ngraham wrote in kmenuedit.cpp:30 > Unrelated change. IMHO it looks cleaner to separate includes into categories, which is what I did here. > ngraham wrote in kmenuedit.cpp:141 > Since the placeholder text says "Search..." we should probably not

D18939: KMenuEdit: add search/filter bar

tuxxi updated this revision to Diff 51561. tuxxi marked 5 inline comments as done. tuxxi added a comment. Fix various nitpicks REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18939?vs=51545=51561 BRANCH search-bar REVISION DETAIL

D18939: KMenuEdit: add search/filter bar

tuxxi updated this revision to Diff 51545. tuxxi marked an inline comment as done. tuxxi added a comment. - search -> search... REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18939?vs=51540=51545 BRANCH search-bar REVISION DETAIL

D18939: KMenuEdit: add search/filter bar

tuxxi updated this revision to Diff 51540. tuxxi added a comment. - Removed `.gitignore` changes - Switch label to placeholder text CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18939?vs=51468=51540 REVISION DETAIL https://phabricator.kde.org/D18939 AFFECTED FILES

D18970: update gitignore

tuxxi abandoned this revision. tuxxi added a comment. whoops REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D18970 To: tuxxi Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18970: update gitignore

tuxxi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tuxxi requested review of this revision. REVISION SUMMARY add basic filtering added label fix category expansion when searching simplify expansion code use QTreeView methods

D18939: KMenuEdit: add search/filter bar

tuxxi added a comment. Hi ngraham: OK, can do on the label / placeholder. RE: `.gitignore`, those files are generated by my IDE (CLion). What do you suggest I do? REVISION DETAIL https://phabricator.kde.org/D18939 To: tuxxi, ngraham, #plasma, cfeck Cc: ngraham, plasma-devel,

D18939: KMenuEdit: add search/filter bar

tuxxi updated this revision to Diff 51468. tuxxi added a comment. - Switch to using QTreeView's methods for expand/collapse - Filter threshold is 2 chars like KOpenWithDialog to avoid cluttering - Reverted unnecessary changes (will do a different revision for refactor, error fixing, and

D18939: KMenuEdit search/filter

tuxxi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tuxxi requested review of this revision. REVISION SUMMARY This diff contains a much-requested feature, adding a search or filter bar to KMenuEdit's application tree view. see: bug 57314