[sysadmin/ci-tooling] system-images: Include libXxf86vm in our images for KGamma5.

Git commit fb5f3e02330c9d8a95d1580f16adbf7ca016da90 by Ben Cooksley. Committed on 15/01/2020 at 07:29. Pushed by bcooksley into branch 'master'. Include libXxf86vm in our images for KGamma5. CCMAIL: plasma-devel@kde.org M +2-0system-images/suse-qt512/Dockerfile M +2-0

D26586: [SystemTray] Rework system tray settings

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, the freeze is on Friday. I think we can get this in before then. UI and behavior look good. Some of the code looks a bit hairy to me, but I don't see anything catastrophic. :)

D26665: Switch to KNSQuick for getting new wallpapers

leinir created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY This switches the image plugin to using KNewStuffQuick instead of launching the widget dialog through that ol' widget dialog hack.

D26583: [Application Style] Add GTK Application Style Page

gikari updated this revision to Diff 73534. gikari marked 3 inline comments as done. gikari added a comment. Remove `columnCount` method and fix `rowCount` method REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26583?vs=73519=73534 BRANCH

D26667: refactor about-distro to more generically support textual dumps

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY this previously relied on manually replicating strings and whatnot, it was very awkward to read and the load functions were also

D26667: refactor about-distro to more generically support textual dumps

sitter added a comment. not sure if it's worth splitting into multiple files. personally I prefer many tiny files over one long one though *shrug*. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D26667 To: sitter Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir added a comment. In D26544#594194 , @ngraham wrote: > Thanks for the explanation! Not a problem, it's not necessarily easy to spot at a glance - and thanks! :D REPOSITORY R119 Plasma Desktop BRANCH switch-kcms-to-knsquick

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir added a comment. Right, everything blew up i guess. Nice. REPOSITORY R119 Plasma Desktop BRANCH switch-kcms-to-knsquick (branched from master) REVISION DETAIL https://phabricator.kde.org/D26544 To: leinir, mart, ngraham Cc: bcooksley, davidedmundson, ngraham, plasma-devel,

D26655: show a thin separator between view and scrollbar

ngraham accepted this revision as: VDG, ngraham. ngraham added a comment. This revision is now accepted and ready to land. Oh man, I think this just looks so good everywhere. REPOSITORY R31 Breeze BRANCH phab/scrollbarseparator REVISION DETAIL https://phabricator.kde.org/D26655 To:

D26655: show a thin separator between view and scrollbar

ngraham added a comment. Regarding the thickened scrollbars, I think it makes sense for a few reasons: - Acknowledging user feedback: we've had a bunch of complaints about the thin scrollbars. - Usability: even though the click area was the same size for the thin inactive scrollbars,

D26655: show a thin separator between view and scrollbar

mthw added a comment. It does look better but looking at this (image) it looks like a step backwards. Wouldn't it be better to have the scrollbar floating above the content? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26655

D26655: show a thin separator between view and scrollbar

hpereiradacosta added a comment. Hi Notmart, you need to rebase (you have some unrelated changes in the diff, which revert latest change from Noah) - Concerning the separator, it looks great. - Concerning reverting the thin bar, I think this is really unfortunate. I expect you will

D26552: [KCMs/Feedback] Adjust UI to be more user-friendly

This revision was automatically updated to reflect the committed changes. Closed by commit R120:61a89ec98af5: [KCMs/Feedback] Adjust UI to be more user-friendly (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26583: [Application Style] Add GTK Application Style Page

gikari updated this revision to Diff 73536. gikari added a comment. Return accidentally removed empty lines in `kcmstyle.h` REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26583?vs=73534=73536 BRANCH gtk-style-page REVISION DETAIL

D26627: Mark applications that play audio for small panels.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6e130a23f2e1: Mark applications that play audio for small panels. (authored by gvgeo, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks for the explanation! REPOSITORY R119 Plasma Desktop BRANCH switch-kcms-to-knsquick (branched from master) REVISION DETAIL https://phabricator.kde.org/D26544 To: leinir,

D26665: Switch to KNSQuick for getting new wallpapers

This revision was automatically updated to reflect the committed changes. Closed by commit R120:47a1091be9f5: Switch to KNSQuick for getting new wallpapers (authored by leinir). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26665?vs=73526=73531

D26655: show a thin separator between view and scrollbar

mart added a comment. In D26655#594135 , @mthw wrote: > It does look better but looking at this (image) it looks like a step backwards. Wouldn't it be better to have the scrollbar floating above the

D26583: [Application Style] Add GTK Application Style Page

broulik added inline comments. INLINE COMMENTS > gikari wrote in gtkthemesmodel.cpp:107 > Did you mean > > if (parent.isValid()) { > return 0; > } > return m_themesList.count(); > > ? I think so :D REPOSITORY R119 Plasma Desktop BRANCH gtk-style-page REVISION DETAIL

D24070: [WIP] Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. @ngraham How does it look with this patch? Will it make it in? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: ngraham, #vdg, #plasma, ndavis, mthw Cc: GB_2, ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D26583: [Application Style] Add GTK Application Style Page

gikari added inline comments. INLINE COMMENTS > davidedmundson wrote in gtkthemesmodel.cpp:107 > this needs to be > > if (parent.isValid()) { > return m_themesList.count(); > } > return 0; > > Otherwise your're saying every item has children with N rows, which have > children with N rows

D26655: show a thin separator between view and scrollbar

hpereiradacosta added a comment. In D26655#594173 , @ahiemstra wrote: > > In QQC there is an issue of overlap between item selection (and header titles) and scrollbar. Isn't that made even worth with the addition of the thin separator ? >

D26654: support mobile mode scrollbar

ngraham added a comment. Very nice! Overall it works very well. I found a few issues in QML KCMs: F7883084: Regression: Notifications KCM.jpg F7883085: Regression: Desktop Effects KCM.jpg REPOSITORY

D26565: KCM/Component Revamp email config

meven updated this revision to Diff 73547. meven added a comment. Allow to select any app as email client, mimeapps.list preferred email is the source of truth regarding default mail client, depends on KF5.67 (post plasma 5.18) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26655: show a thin separator between view and scrollbar

hpereiradacosta added a comment. Also, concerning the separator line: how does it look with hovered scrollbars, when the handle grove is also rendered. Isn't there some redundancy between the handle groove and the separator ? (essentially a frame inside a frame) should the handle groove

D26655: show a thin separator between view and scrollbar

mthw added a comment. In D26655#594149 , @mart wrote: > In D26655#594135 , @mthw wrote: > > > It does look better but looking at this (image) it looks like a

D26655: show a thin separator between view and scrollbar

ahiemstra added a comment. > In QQC there is an issue of overlap between item selection (and header titles) and scrollbar. Isn't that made even worth with the addition of the thin separator ? That problem is caused by overlapping scrollbars, D26530

D26654: support mobile mode scrollbar

mart updated this revision to Diff 73542. mart added a comment. - smoother transition REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26654?vs=73507=73542 BRANCH phab/mobilescrollbar REVISION DETAIL

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. In D26586#594211 , @ngraham wrote: > Some of the code looks a bit hairy to me, but I don't see anything catastrophic. :) What exactly? I can quickly fix/refactor that. REPOSITORY R120 Plasma Workspace BRANCH

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir updated this revision to Diff 73544. leinir added a comment. - Merge remote-tracking branch 'origin/master' into switch-kcms-to-knsquick - Fix build (by removing stuff that was removed in master it seems) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26583: [Application Style] Add GTK Application Style Page

davidedmundson added inline comments. INLINE COMMENTS > gtkthemesmodel.cpp:107 > +int GtkThemesModel::rowCount(const QModelIndex& parent) const > +{ > +Q_UNUSED(parent) this needs to be if (parent.isValid()) { return m_themesList.count(); } return 0; Otherwise your're saying every item

D26586: [SystemTray] Rework system tray settings

nicolasfella added a comment. There's a minor problem (that I've seen in other place as well). When scrolling the content overflows the frame on the top a bit: See how the top frame is white while the side is blue F7883066: Screenshot_20200114_170622.png

D26655: show a thin separator between view and scrollbar

hpereiradacosta added a comment. In D26655#594240 , @ngraham wrote: > Regarding the thickened scrollbars, I think it makes sense for a few reasons: > > - Acknowledging user feedback: we've had a bunch of complaints about the thin

D26565: KCM/Component Revamp email config

meven updated this revision to Diff 73548. meven added a comment. clean some unused incudes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26565?vs=73547=73548 BRANCH email-config REVISION DETAIL https://phabricator.kde.org/D26565 AFFECTED

D26655: show a thin separator between view and scrollbar

mart added a comment. In D26655#594257 , @hpereiradacosta wrote: > Is this really intended ? > I would at least keep the color blending, making the color stronger only when the scrollbar is actually hovered. ouch, well spotted, i

D26665: Switch to KNSQuick for getting new wallpapers

victorr added a comment. downloadNewWhat: i18n("Wallpapers") But now the translation does not work. This is reported here https://bugs.kde.org/show_bug.cgi?id=415541 Now I am fixing this error with three patches. F7883230: knewstuff-5.6-tr.patch

D26660: [Task Manager]Fix and improve configuration behavior

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, this is a nice improvement, and thanks for fixing that bug which I caused when I originally rewrote the layout to use FormLayouts last year. REPOSITORY R119 Plasma Desktop

D26565: KCM/Component Revamp email config

ngraham added a comment. Let me know if and when this is reviewable, or if it's still WIP. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26565 To: meven, ngraham, ervin, #plasma, bport, crossi Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. In D26586#594236 , @nicolasfella wrote: > There's a minor problem (that I've seen in other place as well). When scrolling the content overflows the frame on the top a bit: Should I use `import QtQuick.Controls

KDE CI: Plasma » kgamma5 » kf5-qt5 SUSEQt5.12 - Build # 24 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kgamma5/job/kf5-qt5%20SUSEQt5.12/24/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 14 Jan 2020 17:53:18 + Build duration: 54 sec and counting CONSOLE OUTPUT [...truncated 228

D26223: Explictly state which X11 components are required

This revision was automatically updated to reflect the committed changes. Closed by commit R100:26f55f10c026: Explictly state which X11 components are required (authored by davidedmundson). REPOSITORY R100 KGamma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26223?vs=72177=73552

D26655: show a thin separator between view and scrollbar

hpereiradacosta added a comment. Removed previous comment because after testing the patch it turns out that this is not too strong of an issue. However I also noticed that you not only removed the think handle but also the color blending. This make the handle not only larger but also

D26586: [SystemTray] Rework system tray settings

ngraham added a comment. Use the QQC2 ScrollView, and we should fix that elsewhere. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26586 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham Cc: ahiemstra, mart,

D26655: show a thin separator between view and scrollbar

hpereiradacosta added a comment. I would start by - rebase this patch to apply cleanly - split it in two (one for the separator line and one for the think handle removal), because these are really two features, adressing two different issues: 1: the floating bar 2: the two small

D26655: show a thin separator between view and scrollbar

hpereiradacosta added a comment. In D26655#594280 , @mart wrote: > In D26655#594257 , @hpereiradacosta wrote: > > > Is this really intended ? > > I would at least keep the color blending, making

D24070: [WIP] Don't use toolTipMainText to show info, rather use the second line

ngraham updated this revision to Diff 73554. ngraham added a comment. Fix FIXME and don't show "Calculating blah..." text in subtitle when exact time isn't available REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=73088=73554 BRANCH

D26655: show a thin separator between view and scrollbar

ngraham added a comment. In D26655#594250 , @hpereiradacosta wrote: > With all due respect: > This is irrelevant unless you do an actual poll. > You will have user feedback that want the thin scrollbar back. (I will). Sure, you

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

ngraham added a comment. Phab strikes again... I would revert to a previous version of this patch using the history tab in the web UI, download the raw diff from the web UI, and then manually apply it on top of HEAD. REPOSITORY R119 Plasma Desktop BRANCH switch-kcms-to-knsquick

D24748: [containmentlayoutmanager] Don't accept button events that only start timers

ngraham added a comment. This patch fixes the bug, but it does indeed break leaving per-widget edit mode. Could we also exit that on left-click regardless of what other action it performs? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24748 To:

D26654: support mobile mode scrollbar

ngraham accepted this revision as: VDG, ngraham. ngraham added a comment. This revision is now accepted and ready to land. Seems like that's a local issue actually. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH phab/mobilescrollbar REVISION DETAIL

Re: Long press global shortcuts

On 1/12/20 10:11 AM, Aleix Pol wrote: The second part of this is why I'm sending this e-mail. We're responding to global shortcuts on press rather than on release, which makes it impossible to handle the long press. Would it make sense to change it to on release? Maybe only in the cases where

Re: Long press global shortcuts

On 1/14/20 1:07 PM, Aleix Pol wrote: We are talking about shortcuts for physical keys (e.g. keyboard, the 3 or 4 buttons you'd have on a phone). Oh my mistake, sorry. One thing I miss from macOS is long-pressing a key on the keyboard to display a pop-up containing accented and other

D26660: [Applets/Task Manager] Fix and improve behavior tab layouts

gvgeo updated this revision to Diff 73569. gvgeo edited the test plan for this revision. gvgeo added a comment. On more careful examination, "Group only when the Task Manager is full" option, does not affect grouping, when "combing into single button" is disabled. Flipped back the order of

D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > image.cpp:362 > +// Replace 'preferred://wallpaperlocations' with real paths > +for (QString : m_slidePaths) { > +

D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow

ngraham updated this revision to Diff 73571. ngraham marked an inline comment as done. ngraham added a comment. Shallow copy instead of deep copy REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26483?vs=73067=73571 BRANCH

D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow

ngraham updated this revision to Diff 73572. ngraham added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26483?vs=73571=73572 BRANCH add-a-default-wallpaper-slideshow-location (branched from master) REVISION DETAIL

D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in image.cpp:362 > there's two mistakes that cancel kinda each other out here. > > typically, this should be qAsConst(m_slidePaths) > m_slidePaths here detatches and does a full deep-copy > >

D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow

ngraham added a comment. Thanks David! REPOSITORY R120 Plasma Workspace BRANCH add-a-default-wallpaper-slideshow-location (branched from master) REVISION DETAIL https://phabricator.kde.org/D26483 To: ngraham, #plasma, #vdg, ndavis, davidedmundson Cc: davidre, broulik, davidedmundson,

D26672: Fix crash when loading a top level entry from system settings home page

This revision was automatically updated to reflect the committed changes. Closed by commit R124:27b8f182409a: Fix crash when loading a top level entry from system settings home page (authored by davidedmundson). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE

D26655: show a thin separator between view and scrollbar

hpereiradacosta added a comment. >> my complain here is that this argument was either not made or discarded, when the first switch to thin scrollbar was done. >> This is my main concern about this change: the going back and forth using adhoc arguments each time to justify the change,

D26672: Fix crash when loading a top level entry from system settings home page

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY BUG: 416227 TEST PLAN Clicked "look and feel" from the home screen

D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8be6fb749ced: [wallpapers/image] Add default XDG wallpaper locations for slideshow (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

Re: Long press global shortcuts

On Tue, Jan 14, 2020 at 9:05 PM Nate Graham wrote: > > On 1/12/20 10:11 AM, Aleix Pol wrote: > > The second part of this is why I'm sending this e-mail. We're > > responding to global shortcuts on press rather than on release, which > > makes it impossible to handle the long press. Would it make

D26672: Fix crash when loading a top level entry from system settings home page

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D26672 To: davidedmundson, #plasma, ngraham Cc: ngraham, plasma-devel,

D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow

ngraham added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26483 To: ngraham, #plasma, #vdg, ndavis, davidedmundson Cc: davidre, broulik, davidedmundson, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,

D26421: Only show full name in review dialog

ngraham added a comment. @apol ping. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D26421 To: ngraham, #discover_software_store, apol Cc: jgrulich, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D26675: [sddm-theme] Don't have a broken reveal password button

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY sddm-greeter will have a button for the reveal password button, but due to

D26676: [applets/calculator] Use Qt's in-built number formatting

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Gets rid of a load of code. Correctly handles floating point issues.

D26676: [applets/calculator] Use Qt's in-built number formatting

ngraham added a reviewer: VDG. ngraham added a comment. > Potentially this inadvertedly introduces a behaviour change > of including group separators depending on locale. > Is this a a good feature? I can't speak for everyone, but personally I like seeing the localized separators

D26676: [applets/calculator] Use Qt's in-built number formatting

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Can confirm that it fixes the bug, and the code change looks sane to me. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26676 To:

D26421: Only show full name in review dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R134:ec5464e70642: Only show full name in review dialog (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26421?vs=72767=73582

D26421: Only show full name in review dialog

ngraham added a comment. Thanks! REPOSITORY R134 Discover Software Store BRANCH full-name-only (branched from master) REVISION DETAIL https://phabricator.kde.org/D26421 To: ngraham, #discover_software_store, apol Cc: jgrulich, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D26676: [applets/calculator] Use Qt's in-built number formatting

This revision was automatically updated to reflect the committed changes. Closed by commit R114:a51086867c0f: [applets/calculator] Use Qts in-built number formatting (authored by davidedmundson). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D26679: [kcms/feedback] Fix default button not showing

davidedmundson updated this revision to Diff 73588. davidedmundson added a comment. stupid phab REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26679?vs=73587=73588 BRANCH origin-master (branched from master) REVISION DETAIL

D26679: [kcms/feedback] Fix default button not showing

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D26679

D26680: [kcms/feedback] Implement setRepresentsDefaults

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Moved slider Defaults button enabled/disabled appropriately REPOSITORY R120

D26678: [kcms/feedback] Fix slider value

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY If the kcm's property changes externally we don't update the slider after

D26681: [TabBox] Thumbnail Grid window switcher

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Cleaned up my code from https://github.com/Zren/kwin-tabbox-thumbnail_grid The column is calculated recursively, but survived a

D26530: ScrollView: Do not overlay scrollbars over contents

ahiemstra updated this revision to Diff 73495. ahiemstra added a comment. - Review comments REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26530?vs=73093=73495 BRANCH scrollview_scrollbar_spacing REVISION DETAIL

D26627: Mark applications that play audio for small panels.

broulik accepted this revision. broulik added a comment. Lovely, thanks. REPOSITORY R119 Plasma Desktop BRANCH audiosize (branched from master) REVISION DETAIL https://phabricator.kde.org/D26627 To: gvgeo, #vdg, #plasma, hein, ngraham, broulik Cc: plasma-devel, LeGast00n,

D26518: ModuleView: Hide button when KCModule don't need them

This revision was automatically updated to reflect the committed changes. Closed by commit R124:01cecb1602aa: ModuleView: Hide button when KCModule dont need them (authored by bport). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26518?vs=73043=73493

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir added inline comments. INLINE COMMENTS > ngraham wrote in colors.cpp:128 > This wraps a lot of existing functionality into that conditional as well. Was > all of that stuff broken and useless without D26543 > ? > > Everything seems to work anyway,

D26530: ScrollView: Do not overlay scrollbars over contents

This revision was automatically updated to reflect the committed changes. Closed by commit R858:06d4bb0e6b86: ScrollView: Do not overlay scrollbars over contents (authored by ahiemstra). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D26622: RFC: [Notifications] Raise application window if no default action is provided

This revision was automatically updated to reflect the committed changes. Closed by commit R120:48d3613aa843: [Notifications] Raise application window if no default action is provided (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26622?vs=73403=73497#toc

D25943: Expose ActionToolBar's overflow button icon name

This revision was automatically updated to reflect the committed changes. Closed by commit R169:d4bf3ed38a9f: Expose ActionToolBars overflow button icon name (authored by ahiemstra). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25943?vs=71420=73512#toc REPOSITORY R169 Kirigami

D26656: Use QQC2 Page as base for Kirigami Page

This revision was automatically updated to reflect the committed changes. Closed by commit R169:2829d2be5584: Use QQC2 Page as base for Kirigami Page (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26656?vs=73505=73511 REVISION

D26586: [SystemTray] Rework system tray settings

kmaterka marked an inline comment as done. kmaterka added a comment. In D26586#593966 , @ahiemstra wrote: > There should be no need to explicitly specify paddings now that D26530 has landed. But there's a

D26658: WIP: fix(kwayland): stall tablet config change

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY It seems only checking on no outputs initializing and signals being unblocked is not enough

D26660: [Task Manager]Fix and improve configuration behavior

gvgeo created this revision. gvgeo added reviewers: VDG, Plasma, hein, ngraham. gvgeo added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Fix the group conditions. Change layout. Rename various labels and texts. TEST

D26654: support mobile mode scrollbar

broulik added a comment. Cool! The width change during the slide animation looks a bit odd, though INLINE COMMENTS > ScrollBar.qml:50 > +id: handleGraphics > +x: scrolling ? parent.width/2 - width/2 : parent.width - width > + `Math.round` REPOSITORY R858 Qt Quick

D26586: [SystemTray] Rework system tray settings

kmaterka updated this revision to Diff 73504. kmaterka added a comment. Replaced hack with explicit padding settings REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26586?vs=73470=73504 BRANCH master REVISION DETAIL

D26656: Use QQC2 Page as base for Kirigami Page

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Instead of using Templates directly, use QQC2 page as base class for Kirigami's Page.

D26423: [Notifications KCM] Move Plasma Workspace "service" to the top of its category

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a0f16565015e: [Notifications] Move Plasma Workspace service to the top of its category (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26423?vs=73419=73508#toc

D26653: KCM Joystick : restore Default button to allow reset calibration.

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, meven, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Since there is no configuration saved, all button are

D26654: support mobile mode scrollbar

mart created this revision. mart added reviewers: Plasma, VDG, Kirigami. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY when on mobile (or just "tabletmode" the scrollbar goes to "not interactive" in that case

D26655: show a thin separator between view and scrollbar

mart created this revision. mart added reviewers: Plasma, Breeze, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY This look makes listviews look way better, not having the selected items look truncated into

D26586: [SystemTray] Rework system tray settings

kmaterka marked 2 inline comments as done. kmaterka added a comment. Anything else to change/fix? When is the code freeze, this Friday? INLINE COMMENTS > kmaterka wrote in ConfigEntries.qml:114 > Yes, I don't like this neither. It is a workaround for a problem in >

D26654: support mobile mode scrollbar

mart marked an inline comment as done. mart added a comment. screenshots done with also D26655 in REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D26654 To: mart, #plasma, #vdg, #kirigami Cc: broulik,

D26654: support mobile mode scrollbar

mart updated this revision to Diff 73507. mart added a comment. - support also horizontal scrollbars REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26654?vs=73502=73507 BRANCH phab/mobilescrollbar REVISION DETAIL

D26586: [SystemTray] Rework system tray settings

ahiemstra added a comment. There should be no need to explicitly specify paddings now that D26530 has landed. But there's a bunch of workarounds that we still need to remove, so you may have some intermittent weird results. REPOSITORY R120 Plasma

  1   2   >