D26992: [SystemTray] Use unified data model everywhere

2020-07-02 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > systemtray.h:100 > */ > -Q_INVOKABLE void reorderItemAfter(QQuickItem* after, QQuickItem* before); > - > -Q_INVOKABLE bool isSystemTrayApplet(const QString ); > +Q_INVOKABLE Plasma::Service *serviceForSource(const QString ); >

D26992: [SystemTray] Use unified data model everywhere

2020-07-02 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kmaterka wrote in systemtray.h:100 > I don't know, this code was there before my changes, I've just done some > refactoring here. Thanks for your reply. Okay, so seems you did not hit anything related. Thing is, you added `` Q_INVOKABLE

D24223: [RFC] Add global themes that mimic other platforms' workflows

2020-07-02 Thread Jason Playne
Boxie added a comment. In D24223#675715 , @ngraham wrote: > Do folks have any ideas for alternative layouts that don't explicitly mimic other platforms? How about a "Laptop" Layout. - Typically on a laptop you have a lot of

D26992: [SystemTray] Use unified data model everywhere

2020-07-02 Thread Konrad Materka
kmaterka marked an inline comment as done. kmaterka added inline comments. INLINE COMMENTS > kossebau wrote in systemtray.h:100 > Hi. Seeing this code, I have a question: from what I understood so far, for > this method to be useable from the JavaScript inside QML, the type > "Plasma::Service

D26992: [SystemTray] Use unified data model everywhere

2020-07-02 Thread Konrad Materka
kmaterka marked an inline comment as done. kmaterka added inline comments. INLINE COMMENTS > kossebau wrote in systemtray.h:100 > Thanks for your reply. Okay, so seems you did not hit anything related. > > Thing is, you added > `` > Q_INVOKABLE Plasma::Service *serviceForSource(const QString );

D26992: [SystemTray] Use unified data model everywhere

2020-07-02 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kmaterka wrote in systemtray.h:100 > Oh, OK, now I remember, sorry for misinforming you... > > I haven't had any problems with this, it "Just Worked" :) Maybe it should > return just plain QObject*, I'm not experienced in this area, what do you