Re: Plasma and a bachelor thesis

Hi Ilya, > That's fair. Even though the format would declare it an engineering thesis > and shift the focus more to the code, I would still need to show research > skills, explain the novelty of this work (maybe by using a more general > topic name) and write plenty of text. Do you think the topic

Re: Monday meeting notes for 9/11/2020

Am Montag, 9. November 2020, 15:22:51 CET schrieb Nate Graham: > On 11/9/20 5:18 AM, Marco Martin wrote: > > Missing form David Redondo: > > * I made a simple patch so QMenus are polished before creating the > > platform window > > * https://codereview.qt-proje

D27036: KApiDox: add "Plasma Workspaces Libraries" group info

davidre added a comment. Ping? REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D27036 To: davidedmundson, #plasma Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himce

D23257: Allow for easier syncing of Plasma font

davidre added a comment. Everybody ok if I push this, before it is forgotten again? REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH easier-font-syncing (branched from master) REVISION DETAIL https://phabricator.kde.org/D23257 To: filipf, ngraham, #plasma, davidedmundson Cc: davi

D23257: Allow for easier syncing of Plasma font

davidre updated this revision to Diff 83430. davidre added a comment. Rebase CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23257?vs=64999&id=83430 BRANCH arcpatch-D23257 REVISION DETAIL https://phabricator.kde.org/D23257 AFFECTED FILES src/sddmkcm.cpp To: filipf, ngraham,

D23257: Allow for easier syncing of Plasma font

davidre added a comment. I rebased it because of the rewrite that happened, can you check if everything is still ok @filipf BRANCH arcpatch-D23257 REVISION DETAIL https://phabricator.kde.org/D23257 To: filipf, ngraham, #plasma, davidedmundson Cc: davidre, plasma-devel, Orage, LeGast00n,

D23257: Allow for easier syncing of Plasma font

davidre added inline comments. INLINE COMMENTS > sddmkcm.cpp:243 > > if (!kdeglobalsPath.isEmpty()) { > args[QStringLiteral("kdeglobals")] = kdeglobalsPath; Should I remove this then? BRANCH arcpatch-D23257 REVISION DETAIL https://phabricator.kde.org/D23257 To: filipf, ngr

D23257: Allow for easier syncing of Plasma font

davidre added inline comments. INLINE COMMENTS > filipf wrote in sddmkcm.cpp:243 > Unfortunately not yet because we still need the `kdeglobals` file for color > schemes. From my previous testing it's not enough to just copy some line > `colorScheme=Adwaita`, we actually need to copy all of the

D23257: Allow for easier syncing of Plasma font

davidre closed this revision. REVISION DETAIL https://phabricator.kde.org/D23257 To: filipf, ngraham, #plasma, davidedmundson Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, je

qqc2-breeze-style should use bugs.kde.org for bug tracking

Hi, I think when the gitlab migration happened, it was agreed that bug tracking still happens on bugs.kde.org and gitlab issues will eventually replace phabricator tasks. The readme of qqc2-breeze-style includes: > # Bug Reports/Feature Requests/Issues: > >File your reports/requests here: >h

Re: Plasma 5.22 Kickoff Notes

Thank you for your opinion Marco. Am Mittwoch, 10. März 2021, 09:30:35 CET schrieb Marco Martin: > wasn't present at the kickoff meeting so commenting just here, just now. > I'm quite against qqc2-breeze-style and i think it was a mistake. > It was that the style used in plasma-mobile had bugs, so

Fwd: Krunner plugins - basic questions from the new plasma dev

Forwarding to plasma-devel -- Weitergeleitete Nachricht -- Betreff: Krunner plugins - basic questions from the new plasma dev Datum: Sonntag, 18. April 2021, 21:07:37 CEST Von: Slawek Kaplonski An: kde-de...@kde.org Hi, I'm user of the KDE since some time and now I want to ge

Re: Monday meeting notes for 14/06/2021

Am Montag, 14. Juni 2021, 15:43:52 CEST schrieb Nate Graham: > KGlobaAccel seems somewhat fragile; I feel like every time anyone > touches anything about it, stuff breaks. Is it possible to improve unit > test coverage for it? I don't think more testing of KGlobalAccel would solve the problem. The

Microsoft taking inspiration from Plasma slogan

Hi, after many people saying that Windows 11 looks a bit similar to Plasma (which is not the focus of this message, please don't start discussing it in detail). They are now using a very familiar slogan to promote Windows 11. Go to https://insider.windows.com/en-us/insidewindows11 and scroll dow

Re: The unfortunate state of Plasma's stable branch CI coverage

I executed the steps that David described and the dependency builds did succeed and the build queue is still filled at this moment. But the stable jobs should now be on 5.22 I hope. Regards, David

Re: ECM 5.85: introducing KDE_COMPILERSETTINGS_LEVEL concept

This (being the thing described in Friedrich's email, that was sent to kde-devel and that I've attached below) is going to affect us. We migrated to KDECompilerSettings because we were using KDEFrameworksCompilerSettings when we should not have been and the find version bump hit us. At the moment w

Re: KDE CI: Plasma » libksysguard » kf5-qt5 FreeBSDQt5.15 - Build # 295 - Failure!

Am Mittwoch, 1. September 2021, 00:01:49 CEST schrieb David Edmundson: > CC'ing BSD people as only BSD is affected. > > https://build.kde.org/job/Plasma/job/libksysguard/job/kf5-qt5%20FreeBSDQt5.1 > 5/295/ > > I'm stumped on this, the code looks fine. > The build started failing from an SVN_SILEN

Re: [sysadmin/repo-metadata] projects-invent/plasma/ksysguard: There's no ksysguard 5.23

Am Sonntag, 19. September 2021, 23:09:04 CEST schrieb Albert Astals Cid: > Plasma devs if there will be no new ksysguard 5.22.x release please tell > us and we'll clean it up from stable i18n Hi Albert, yes that's correct. From Plasma side there will be no further ksysguard releases. Of course s

Re: [sysadmin/repo-metadata] projects-invent/plasma/ksysguard: There's no ksysguard 5.23

Am Dienstag, 21. September 2021, 10:23:57 CEST schrieb Ben Cooksley: > [...] > [2021-09-20T19:24:50.371Z] * KSysGuard Afaik that's libksysguard and not ksysguard as in the repo, that's fine > Currently the CI Dependency Build jobs for Plasma on the stable side are a > sea of red. > Can someone p

D26675: [sddm-theme] Don't have a broken reveal password button

davidre added a comment. we could install an icon into hicolor as fallback REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26675 To: davidedmundson, #plasma Cc: davidre, ahmadsamir, bharadwaj-raju, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, j

D27036: KApiDox: add "Plasma Workspaces Libraries" group info

davidre added a comment. This has been done elsewhere REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D27036 To: davidedmundson, #plasma Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen,

Re: [GSoC Draft proposal] Redesign system settings modules by porting them to QtQuick

Am Freitag, 1. April 2022, 19:09:07 CEST schrieb Nate Graham: > I would be willing to co-mentor alongside someone else with more dev > experience. I am happy to be co-mentor. As I was never a mentor before you can also mentor my mentoring ;) - >I'm looking for potentials mentors

Re: semicolons and the policy that was none

Am 2022-08-10 15:57, schrieb Harald Sitter: Aloha, Someone recently dug up this page from 2012 https://community.kde.org/Plasma/QMLStyle#JS_Code_Blocks First I'd like to point out that this page isn't a policy page, if it was meant to be then it needs to be linked on the policies page and supp

Re: Using layershell-qt

Am Freitag, 23. September 2022, 13:19:05 CEST schrieb Ralf Van Bogaert: > Hi, > Cool project, that you are trying to use layershell-qt with Qt6! > *qt.qpa.wayland: No shell integration named "layer-shell" > foundqt.qpa.wayland: Loading shell integration failed.qt.qpa.wayland: > Attempted to load

Re: Cherry-picking policy

Am Samstag, 19. November 2022, 05:06:11 CET schrieb Ben Cooksley: > Not sure how much of this is on our radar at the moment, but I do know that > we were playing with a bot to do tagging of MRs at one point in time. > > In terms of how this bot operates, how are people thinking it should work? I

Re: Latte Dock 0.10.9

Am Mittwoch, 16. November 2022, 17:38:12 CET schrieb Jonathan Riddell: > Hi Michael, I've been asking to make a new latte-dock bugfix release to > include this Wayland fix > https://invent.kde.org/plasma/latte-dock/-/commit/1d468a94e931d684f1ec180584 > eaa1d25765f100 > > I've made a tar from that

Re: make IDEs aware of the headers

Am Samstag, 7. Januar 2023, 16:40:27 CET schrieb Andrey Butirsky: > > Other IDEs should benefit too. KDevelop (and I think Kate too) displays headers in "Project" view without this. I am not convinced of this amount of work (and cluttering of our CMake files) to workaround IDE/editor deficienc

Re: Splitting KGlobalAccel interface and runtime

Am Montag, 13. Februar 2023, 21:05:33 CET schrieb Nicolas Fella: > It wouldn't automatically solve the coinstallability problem of KF5 and > KF6, because a kglobalacceld provided by KF5-KGlobalAccel would still > conflict with a Plasma-provided kglobalacceld, but it's at least > conceptually less m

Re: Adjusting Kickoff favorites for Plasma 5.27 not working anymore

I think this issue has been reported as https://bugs.kde.org/show_bug.cgi?id=448660 Seems distros resort to patching files, as these are installed maybe you can do so as well. On my system that is /usr/share/plasma/plasmoids/org.kde.plasma.kickoff/contents/config/main.xml David Am Freitag, 19

Re: kio-extras and the KF5/KF6 period

Am Donnerstag, 25. Mai 2023, 12:51:32 CEST schrieb Nicolas Fella: > Hi, > > Am 17.05.23 um 00:02 schrieb Albert Astals Cid: > > kio-extras provides plugins for kio. > > > > So KF5 applications want a KF5 kio-extras and KF6 applications want a KF6 > > kio- extras. > > This is also the case in mor

Re: kio-extras and the KF5/KF6 period

Am Mittwoch, 7. Juni 2023, 13:00:13 CEST schrieb Luigi Toscano: > I think this is a different case: plasma-integration is part of plasma, and > afaik the maser branch of all repositories which are part of plasma are > Qt6-only already. Note that plasma-integration is our Qt Platform Theme and is i

Re: Plasma-integration and branches

Am Freitag, 16. Juni 2023, 13:37:20 CEST schrieb David Edmundson: > We've discussed a few times an issue with plasma-integration and > supporting Qt5 and Qt6 clients. > > When we release Plasma 6, we need to ensure that a Qt5 and Qt6 builds > are released. We need users to have both as they are pl

Re: Plasma 6 alpha modules list

Am Freitag, 27. Oktober 2023, 17:39:22 CET schrieb Jonathan Riddell: > kwayland-integration - drop No, it is needed for Qt5 apps. David

Re: QML: a packagers nightmare. Assistance please.

Am Mittwoch, 8. November 2023, 12:22:33 CET schrieb Scarlett Moore: > Hi everyone, > As we progress through the Qt6 transition I have been trying to keep > up on our QML dependencies and I keep tripping over circular > dependency nightmare. We switched to a mega package format which > includes qml

Wayland Nvidia situation for initial Plasma 6 release

Hi, when using Wayland on Nvidia there is a significant problem that QtQuick windows freeze when resized, this can also manifest in plasma popups sometimes not showing up. ref. https://bugreports.qt.io/browse/QTBUG-95817 This can be worked around with using the basic render loop instead of the

Re: Wayland Nvidia situation for initial Plasma 6 release

Am Mittwoch, 7. Februar 2024, 10:37:13 CET schrieb Kai Uwe Broulik: > Hi, > > plasma-integration already (which I am NOT happy about!) creates a GL > context to check whether to use software rendering, there we could also > check the GL_VENDOR and set basic render loop. > Yes we did that in 5 a

Re: feature freeze exception

Am Donnerstag, 21. März 2024, 16:51:00 CET schrieb Mike Noe: > Hello fellow developers! > > I'd like to request a feature freeze exception for > https://invent.kde.org/plasma/print-manager/-/merge_requests/116. I feel > that this is important to get into the next release because we've had a > c

[kwrited] [Bug 491272] Write Daemon/Local System Message Service does not show notifications sent using wall(1) or write(1)

https://bugs.kde.org/show_bug.cgi?id=491272 --- Comment #2 from David Redondo --- No this was certainly brainstormed but it's still there and released with plasma 6 https://invent.kde.org/plasma/kwrited It also still works for me on plasma 6 -- You are receiving this mail because: Yo

Biweekly Plasma meetings

Hi, as discussed at the BoF, there is now a repo (thanks to Ben) to organise and keep track of Plasma video meetings. It also shortly explains how the whole process works. You can find it at https://invent.kde.org/plasma/plasma-meetings The first meeting will be on 2024-09-23 16:00 CEST Set t

D24375: [kcms/colors] Generate colored GTK2 assets based off of user's colorscheme

davidre added a comment. So the way forward I see as follows: Eventually we will move stuff out of KRDB to places where it also fits in sementically. Whenever an option is changed in the kcms which call runrdb currently these things can react to that by listening to the DBus signal which i

D27799: Use system color scheme from Kirigami instead of Plasma theme color

davidre added inline comments. INLINE COMMENTS > main.qml:43 > focus: true > -color: theme.backgroundColor > +color: Kirigami.Theme.viewBackgroundColor > } viewBackgroundColor is deprecated `WARNING: viewBackgroundColor is deprecated, use backgroundColor with colorS

D27421: [Cuttleffish] Use proper QSortFilterProxyModel

davidre added a comment. Ping REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D27421 To: davidre, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-moha

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY For a quick tiled window we currently don't draw a border on the edges it is tiled to but we still draw a shadow. In a one screen

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre updated this revision to Diff 77094. davidre added a comment. set padding REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27892?vs=77092&id=77094 BRANCH shadow (branched from master) REVISION DETAIL https://phabricator.kde.org/D27892 AFFECTED FI

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre added a comment. What happens is maybe more clear when using custom window shadows: F8154350: Screenshot_20200306_133119.PNG F8154374: Screenshot_20200306_133130.PNG F8154369: Screenshot_20200306

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre added inline comments. INLINE COMMENTS > CMakeLists.txt:89 > + > +set_target_properties(breezedecoration PROPERTIES CXX_STANDARD 17) > if(BREEZE_HAVE_X11) Sorry, that was just for the initial version of this patch to allow for static inline variables to arrive at the first implementat

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre added a subscriber: davidedmundson. davidre added a comment. In D27892#623425 , @ngraham wrote: > +1 for the concept and resulting appearance. But, should this maybe be done in KWin instead? That way all window decoration themes would get

D25919: Add open containing folder action

davidre abandoned this revision. davidre added a comment. Needs changes in cuttlefish REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D25919 To: davidre, #plasma, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D27421: [Cuttleffish] Use proper QSortFilterProxyModel

davidre updated this revision to Diff 77171. davidre added a comment. Remove members that are not needed anymore REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27421?vs=75742&id=77171 BRANCH searchproxy (branched from master) REVISION DETAIL https:

D27915: Use breeze icons for categories

davidre added a comment. There is something wrong on your system, this is how before looks for me: F8163706: Screenshot_20200307_171017.PNG REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27915 To: guoyunhe, #plasma Cc

D27915: Use breeze icons for categories

davidre added a comment. In D27915#623859 , @guoyunhe wrote: > In D27915#623854 , @davidre wrote: > > > There is something wrong on your system, this is how before looks for me: > > F8163706: Scre

D27823: Use consistent highlight

davidre added a comment. Probably your arc diff base target thingy didn't switch and is on the old commit so this includes everything new on the master branch. Specify it manually with `arc diff master` or `arc diff origin/master` REPOSITORY R116 Plasma Network Management Applet REVISION

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

davidre added a comment. I want to echo the sentiment that Breeze should not gain more options and this instead be a new decoration. I see the issue with mdi windows having different titlebars because they are drawn by the QStyle but you add these options here you are only solving this probl

D27669: [kstyle] Tools area

davidre added inline comments. INLINE COMMENTS > breezetoolsareamanager.cpp:102 > +{ > +if (QApplication::desktopFileName() == > QStringLiteral("telegram-desktop.desktop")) return; > +auto window = qobject_cast (widget); This needs at least a comment why we have this hack fo

D27669: [kstyle] Tools area

davidre added inline comments. INLINE COMMENTS > breezetoolsareamanager.cpp:109 > +window->setContentsMargins(0,1,0,0); > +} > +}); Maybe the decision whether to do this could only be made based on the colors of the active

D27669: [kstyle] Tools area

davidre added a comment. One other thing to consider, this looks really bad with everything else other than no border: F8168528: grafik.png F8168533: grafik.png > No border is now the default! Yes I know

D27669: [kstyle] Tools area

davidre added a comment. I removed the separator line for comparison: F8168553: grafik.png F8168557: Screenshot_20200310_095331.PNG I thought the goal was to have less separators (see the attached task and thi

D27669: [kstyle] Tools area

davidre added a comment. Oh another thing I noticed: this doesn't work, when an app changes its color scheme rather than the default one. The toolbar is not updated. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg Cc: davidre,

D27669: [kstyle] Tools area

davidre added a comment. In D27669#625349 , @ngraham wrote: > In D27669#625187 , @davidre wrote: > > > Again why are we introducing this separator line and even drawing it under normal titlebars? Co

D27669: [kstyle] Tools area

davidre added inline comments. INLINE COMMENTS > breeze.h:104 > // toolbars > -ToolBar_FrameWidth = 2, > +ToolBar_FrameWidth = 6, > ToolBar_HandleExtent = 10, Is that the reason why the toolbar moves down and to the left? If so it seems not to do your intended

D27421: [Cuttleffish] Use proper QSortFilterProxyModel

This revision was automatically updated to reflect the committed changes. Closed by commit R118:2bae103fa66e: [Cuttleffish] Use proper QSortFilterProxyModel (authored by davidre). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27421?vs=77171&id=77399#toc REPOSITORY R118 Plasma SDK CHA

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre added a comment. ping REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27892 To: davidre, #breeze, #vdg, zzag, hpereiradacosta Cc: davidedmundson, ngraham, anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D27669: [kstyle] Tools area

davidre added a comment. In D27669#627444 , @ngraham wrote: > Why does it have to grab the widget's palette? Can't it simply use the colors defined for active/inactive titlebar bg color in the color scheme? Because the iconloader replaces

D27669: [kstyle] Tools area

davidre added a comment. In D27669#627464 , @ndavis wrote: > Do we need to add a Header color set to KColorScheme? How would that help? KIconLoader still wouldn't know which color to use, wouldn't it? REPOSITORY R31 Breeze REVISION DE

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre added a comment. In D27892#628090 , @zzag wrote: > Yes, whether tiled windows should cast shadows is something that must be decided by the compositor or ultimately implemented somewhere in KDecoration2 (not a big fan of this though).

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre added a comment. In D27892#628432 , @ngraham wrote: > In D27892#628109 , @davidre wrote: > > > Please note that his doesn't disable shadows completely for quick tiled windows, only on the ed

D28096: Don't overwrite status

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. TEST PLAN set an attentionIconByName in kstatusnotifieritemtest REPOSITORY R120 Plasma Workspace BRANCH attention (branched from master) REVIS

D28107: Fix overlayIcon sometimes not visible

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Workaround a specific behavior in IconItem if the source is a QIcon with a name and pixmaps. IconItem will use the name to find t

D28107: Fix overlayIcon sometimes not visible

davidre added a comment. I don't think the described behavior is not a bug in IconItem but rather a quirk in the interaction of all three (data engine, IconItem and KIconEngine) components. SO nothing to fix on that side. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabrica

D28107: Fix overlayIcon sometimes not visible

davidre added a comment. In D28107#629446 , @anthonyfieroni wrote: > Can we just set/clear OverlayIconName depends of icon presence then `overlays: model.OverlayIconName` ? Of course thats much easier! Thank you! REPOSITORY R120 Plasm

D28107: Fix overlayIcon sometimes not visible

davidre updated this revision to Diff 77866. davidre added a comment. Only set the role conditionally REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28107?vs=77853&id=77866 BRANCH workaround (branched from master) REVISION DETAIL https://phab

D28096: Don't overwrite status

davidre abandoned this revision. davidre added a comment. In D28096#629508 , @kmaterka wrote: > > The qml checks the value against the enum but updateItemData inserts the string. > > These are two different roles: > "status" with enum valu

D28107: Fix overlayIcon sometimes not visible

davidre added a comment. In D28107#629521 , @kmaterka wrote: > Yep, icons in SNI are a mess... > Icons are processed in `StatusNotifierItemSource`, including overlay - that's were this should be fixed. From you comment I see it won't be easy..

D28072: [GTK Config] Apply color scheme to GTK3 applications

davidre added a comment. It seems it is possible to do this (removing stuff from the data engine) after all. I will try to work on this in the next time REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: davidre,

D28107: Fix overlayIcon sometimes not visible

davidre added a comment. It seems it is possible to do this (removing stuff from the data engine) after all. I will try to work on this in the next time REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28107 To: davidre, kmaterka, #plasma, broulik, davidedmu

D27669: [kstyle] Tools area

davidre added a comment. Some colorschemes do have transparent titlebars, do you plan to support transparency or leave it as is? F8185862: Screenshot_20200320_090510.PNG To support apps that have another color schemes than the global one look at th

D28143: Add "veryLongDuration" animation duration

davidre added a comment. Also needs adding in plasma In D28143#631225 , @mart wrote: > a problem tough.. this one won't follow system settngs, so globally disabling anoimations won't disable this one > it also needs implementing in plasm

D28107: Fix overlayIcon sometimes not visible

davidre added a comment. In D28107#631804 , @kmaterka wrote: > In D28107#630144 , @davidre wrote: > > > It seems it is possible to do this (removing stuff from the data engine) after all. I will try

D27669: [kstyle] Tools area

davidre added inline comments. INLINE COMMENTS > breezehelper.cpp:90 > +_decorationConfig->load(); > +if (qApp && qApp->property("KDE_COLOR_SCHEME_PATH").isValid()) { > +const auto path = > qApp->property("KDE_COLOR_SCHEME_PATH").toString(); I don't think you need su

D28208: Move sni icon handling logic from data engine to applet

davidre created this revision. davidre added reviewers: kmaterka, broulik, mart, Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY The engine does complicated logig in order to provide a pre rendered

D28208: Move sni icon handling logic from data engine to applet

davidre added a comment. For now I tried to replicate `KIconLoader::drawOverlays` that is used in IconItem but that results in very small overlays. Because of this I added #vdg for opinions on better sizing. REPOSITORY R120 Plasma Workspace REVISION

D28208: Move sni icon handling logic from data engine to applet

davidre added inline comments. INLINE COMMENTS > StatusNotifierItem.qml:84 > +} > +return 64; > +} Good to know! That was a straight copy from https://cgit.kde.org/kiconthemes.git/tree/src/kiconloader.cpp#n478 :D I'm sure we can find better sizing though, I thin

D28208: Move sni icon handling logic from data engine to applet

davidre updated this revision to Diff 78298. davidre added a comment. Use units iconsizes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28208?vs=78253&id=78298 BRANCH sni (branched from master) REVISION DETAIL https://phabricator.kde.org/D28

D28208: Move sni icon handling logic from data engine to applet

davidre marked an inline comment as done. davidre added a comment. I think for now we should just recreate the old behaviour from statusnotifieritemsource as this commit is about moving the icon handling. And in a follow up commit we can then change it REPOSITORY R120 Plasma Workspace REV

D28208: Move sni icon handling logic from data engine to applet

davidre marked 3 inline comments as done and an inline comment as not done. davidre added inline comments. INLINE COMMENTS > StatusNotifierItem.qml:90 > +bottom: iconItem.bottom > +bottomMargin: 0.05 * iconItem.width > +rightMargin: anchors.bottomMargin Hmm to

D28208: Move sni icon handling logic from data engine to applet

davidre updated this revision to Diff 78384. davidre marked 6 inline comments as done. davidre added a comment. Use Math.floor REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28208?vs=78298&id=78384 BRANCH sni (branched from master) REVISION DET

D28208: Move sni icon handling logic from data engine to applet

davidre updated this revision to Diff 78479. davidre marked an inline comment as done. davidre added a comment. rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28208?vs=78384&id=78479 BRANCH sni (branched from master) REVISION DETAIL ht

D28208: Move sni icon handling logic from data engine to applet

davidre updated this revision to Diff 78481. davidre marked an inline comment as done. davidre added a comment. Also change it in the tooltip icon REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28208?vs=78479&id=78481 BRANCH sni (branched from m

D28208: Move sni icon handling logic from data engine to applet

davidre added a comment. Do you know if `IconThemePath` is specified somewhere? What I could observe is that some apps create a folder hierachy under this path and palce their icon there. I currently don't have any idea how to handle this in qml. Maybe we need to do this in the model / c++

D27669: [kstyle] Tools area

davidre requested changes to this revision. davidre added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > breezehelper.cpp:1782 > +auto borderSize = kdecorationGroup.readEntry("BorderSize", > "Invalid"); > +if (borderSize != "None" && borderSize

D27669: [kstyle] Tools area

davidre added a comment. Some observation: - Performance in KDevelop is horrible (First startup, opening files, switching between file tabs...) - It also colors the toolbars of mdi windows F8199474: Screenshot_20200326_101026.png - It also d

D27669: [kstyle] Tools area

davidre added a comment. In D27669#635243 , @cblack wrote: > Assume there's no borders when there's not a BorderSize entry That's totally not correct. The default value when there's no BorderSize entry is "Normal" . This patch is now also

D27669: [kstyle] Tools area

davidre added a comment. two videos showing the performance regression (on the left current breeze, on the right with this patch applied) F8200103: breeze.webm F8200105: toolarea.webm REPOSITORY R31 Breeze REV

D28317: Adjust default color scheme and titlebar appearance for Tools Area

davidre added a comment. Will we ship a "Breeze classic" colorscheme/or decoration? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: davidre, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbamp

D28330: Color icons in titlebar if possible

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Some icons can be recolored. However if the titlebar color is different compared to the normal color scheme, this can lead to bad

D28330: Color icons in titlebar if possible

davidre updated this revision to Diff 78639. davidre added a comment. Use decoration()->fontColor() REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28330?vs=78618&id=78639 BRANCH icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D28330: Color icons in titlebar if possible

davidre added inline comments. INLINE COMMENTS > breezebutton.cpp:148 > +QPalette palette = decoration()->client().data()->palette(); > +palette.setColor(QPalette::Foreground, > qobject_cast(decoration())->fontColor()); > +KIconLoader::global()->setCustomPalet

D28330: Color icons in titlebar if possible

davidre added inline comments. INLINE COMMENTS > breezebutton.cpp:151 > decoration()->client().data()->icon().paint(painter, > iconRect.toRect()); > - > +KIconLoader::global()->resetPalette(); > I will look into it REPOSITORY R31 Breeze BRANCH icons (branched fr

D28317: Adjust default color scheme and titlebar appearance for Tools Area

davidre added a comment. In D28317#636115 , @ngraham wrote: > This isn't really a new version of Breeze Light. I see Breeze Light as the light version of Breeze Dark; both are unibody (titlebar is same color as window background), but one is lig

D28356: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze

davidre added subscribers: broulik, davidre. davidre requested changes to this revision. davidre added a comment. -1 I think the current design is fine. It has been part of the default kde look for many years (for all of oxygen and breeze) and forms a core part of our design brand. It's so

  1   2   3   4   5   >